Compiled binary files should be added to .gitignore
'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) alsa/global-timer alsa/utimer-test
Cc: Mark Brown broonie@kernel.org Cc: Jaroslav Kysela perex@perex.cz Cc: Takashi Iwai tiwai@suse.com Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: linux-sound@vger.kernel.org --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/alsa/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore index 12dc3fcd3456..1407fd24a97b 100644 --- a/tools/testing/selftests/alsa/.gitignore +++ b/tools/testing/selftests/alsa/.gitignore @@ -1,3 +1,5 @@ mixer-test pcm-test test-pcmtest-driver +global-timer +utimer-test
Compiled binary files should be added to .gitignore
'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) filesystems/statmount/statmount_test_ns
Cc: Shuah Khan shuah@kernel.org Cc: Christian Brauner brauner@kernel.org Cc: Miklos Szeredi mszeredi@redhat.com Cc: Josef Bacik josef@toxicpanda.com Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/filesystems/statmount/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore index 82a4846cbc4b..66a21f289453 100644 --- a/tools/testing/selftests/filesystems/statmount/.gitignore +++ b/tools/testing/selftests/filesystems/statmount/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only /*_test +statmount_test_ns
Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) mm/hugetlb_dio mm/pkey_sighandler_tests_32 mm/pkey_sighandler_tests_64
Cc: Donet Tom donettom@linux.ibm.com Cc: Andrew Morton akpm@linux-foundation.org Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: linux-mm@kvack.org --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as seperate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/mm/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore index da030b43e43b..2ac11b7fcb26 100644 --- a/tools/testing/selftests/mm/.gitignore +++ b/tools/testing/selftests/mm/.gitignore @@ -51,3 +51,5 @@ hugetlb_madv_vs_map mseal_test seal_elf droppable +hugetlb_dio +pkey_sighandler_tests*
On 10/24/24 6:40 PM, Li Zhijian wrote:
Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) mm/hugetlb_dio mm/pkey_sighandler_tests_32 mm/pkey_sighandler_tests_64
Cc: Donet Tom donettom@linux.ibm.com Cc: Andrew Morton akpm@linux-foundation.org Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com
Cc: linux-mm@kvack.org
Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests.
V2: split as seperate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu...
tools/testing/selftests/mm/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore index da030b43e43b..2ac11b7fcb26 100644 --- a/tools/testing/selftests/mm/.gitignore +++ b/tools/testing/selftests/mm/.gitignore @@ -51,3 +51,5 @@ hugetlb_madv_vs_map mseal_test seal_elf droppable +hugetlb_dio +pkey_sighandler_tests*
Reviewed-by: John Hubbard jhubbard@nvidia.com
thanks,
Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) net/netfilter/conntrack_reverse_clash
Cc: Pablo Neira Ayuso pablo@netfilter.org Cc: Jozsef Kadlecsik kadlec@netfilter.org Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org Cc: netdev@vger.kernel.org --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/net/netfilter/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore index 0a64d6d0e29a..eef8d5784e94 100644 --- a/tools/testing/selftests/net/netfilter/.gitignore +++ b/tools/testing/selftests/net/netfilter/.gitignore @@ -4,3 +4,4 @@ connect_close conntrack_dump_flush sctp_collision nf_queue +conntrack_reverse_clash
On Fri, 25 Oct 2024 09:40:07 +0800 Li Zhijian wrote:
diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore index 0a64d6d0e29a..eef8d5784e94 100644 --- a/tools/testing/selftests/net/netfilter/.gitignore +++ b/tools/testing/selftests/net/netfilter/.gitignore @@ -4,3 +4,4 @@ connect_close conntrack_dump_flush sctp_collision nf_queue +conntrack_reverse_clash
This gitignore file appears to be sorted, please move the new entry up into the right place and repost as a standalone patch (not part of a series) so that its easier to netfilter maintainers to pick it up.
After `make run_tests`, the git status complains: Untracked files: (use "git add <file>..." to include in what will be committed) cpufreq/cpufreq_selftest.dmesg_cpufreq.txt cpufreq/cpufreq_selftest.dmesg_full.txt cpufreq/cpufreq_selftest.txt
Cc: "Rafael J. Wysocki" rafael@kernel.org Cc: Viresh Kumar viresh.kumar@linaro.org Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: linux-pm@vger.kernel.org --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/cpufreq/.gitignore | 1 + tools/testing/selftests/cpufreq/Makefile | 1 + 2 files changed, 2 insertions(+) create mode 100644 tools/testing/selftests/cpufreq/.gitignore
diff --git a/tools/testing/selftests/cpufreq/.gitignore b/tools/testing/selftests/cpufreq/.gitignore new file mode 100644 index 000000000000..f684d27f5d91 --- /dev/null +++ b/tools/testing/selftests/cpufreq/.gitignore @@ -0,0 +1 @@ +cpufreq_selftest.* diff --git a/tools/testing/selftests/cpufreq/Makefile b/tools/testing/selftests/cpufreq/Makefile index c86ca8342222..9b2ccb10b0cf 100644 --- a/tools/testing/selftests/cpufreq/Makefile +++ b/tools/testing/selftests/cpufreq/Makefile @@ -3,6 +3,7 @@ all:
TEST_PROGS := main.sh TEST_FILES := cpu.sh cpufreq.sh governor.sh module.sh special-tests.sh +EXTRA_CLEAN := cpufreq_selftest.dmesg_cpufreq.txt cpufreq_selftest.dmesg_full.txt cpufreq_selftest.txt
include ../lib.mk
After `make run_tests`, the git status complains: Untracked files: (use "git add <file>..." to include in what will be committed) zram/err.log
This file will be cleaned up when execute 'make clean'
Cc: Shuah Khan shuah@kernel.org Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: split as a separate patch from a small one [0] [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fu... --- tools/testing/selftests/zram/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/zram/.gitignore
diff --git a/tools/testing/selftests/zram/.gitignore b/tools/testing/selftests/zram/.gitignore new file mode 100644 index 000000000000..b4a2cb6fafa6 --- /dev/null +++ b/tools/testing/selftests/zram/.gitignore @@ -0,0 +1 @@ +err.log
``` readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS` ``` It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: netdev@vger.kernel.org
--- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: nothing change --- tools/testing/selftests/net/veth.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh index 4f1edbafb946..457312ef135a 100755 --- a/tools/testing/selftests/net/veth.sh +++ b/tools/testing/selftests/net/veth.sh @@ -46,8 +46,8 @@ create_ns() { ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24 ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad done - echo "#kernel" > $BASE - chmod go-rw $BASE + echo "#kernel" > $STATS + chmod go-rw $STATS }
__chk_flag() {
On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote:
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS`
It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Agreed, although since we've been creating the wrong file this whole time and everything worked -- should we just just delete those two lines completely?
Similarly to patch 6 - please repost as a standalone patch so that our CI will test it. If you only CC a mailing list on subset of patches they are likely to be ignored by automation..
On 30/10/2024 07:43, Jakub Kicinski wrote:
On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote:
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS`
It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Agreed, although since we've been creating the wrong file this whole time and everything worked -- should we just just delete those two lines completely?
Yes, it also works.
Similarly to patch 6 - please repost as a standalone patch so that our CI will test it. If you only CC a mailing list on subset of patches they are likely to be ignored by automation..
Got it
Thanks Zhijian
On Fri, Oct 25, 2024 at 09:40:04AM +0800, Li Zhijian wrote:
index 12dc3fcd3456..1407fd24a97b 100644 --- a/tools/testing/selftests/alsa/.gitignore +++ b/tools/testing/selftests/alsa/.gitignore @@ -1,3 +1,5 @@ mixer-test pcm-test test-pcmtest-driver +global-timer
+utimer-test
Please keep the file sorted, this avoids spurious conflicts in future.
On 25/10/2024 18:05, Mark Brown wrote:
On Fri, Oct 25, 2024 at 09:40:04AM +0800, Li Zhijian wrote:
index 12dc3fcd3456..1407fd24a97b 100644 --- a/tools/testing/selftests/alsa/.gitignore +++ b/tools/testing/selftests/alsa/.gitignore @@ -1,3 +1,5 @@ mixer-test pcm-test test-pcmtest-driver +global-timer
+utimer-test
Please keep the file sorted, this avoids spurious conflicts in future.
Thanks for your review, will update it after get feedback on other patches.
linux-kselftest-mirror@lists.linaro.org