The test.py should not be run separately. It should be run via run.sh, which will do some sanity checks first. Move the test.py from TEST_PROGS to TEST_FILES.
Reported-by: Maximilian Heyne mheyne@amazon.de Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-5567... Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure") Signed-off-by: Hangbin Liu liuhangbin@gmail.com --- tools/testing/selftests/net/rds/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile index 1803c39dbacb..612a7219990e 100644 --- a/tools/testing/selftests/net/rds/Makefile +++ b/tools/testing/selftests/net/rds/Makefile @@ -3,10 +3,9 @@ all: @echo mk_build_dir="$(shell pwd)" > include.sh
-TEST_PROGS := run.sh \ - test.py +TEST_PROGS := run.sh
-TEST_FILES := include.sh +TEST_FILES := include.sh test.py
EXTRA_CLEAN := /tmp/rds_logs include.sh
On Sun, 2024-11-24 at 07:32 +0000, Hangbin Liu wrote:
The test.py should not be run separately. It should be run via run.sh, which will do some sanity checks first. Move the test.py from TEST_PROGS to TEST_FILES.
This looks fine to me. Thanks for the catch! Reviewed-by: Allison Henderson allison.henderson@oracle.com
Reported-by: Maximilian Heyne mheyne@amazon.de Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-5567... Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure") Signed-off-by: Hangbin Liu liuhangbin@gmail.com
tools/testing/selftests/net/rds/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile index 1803c39dbacb..612a7219990e 100644 --- a/tools/testing/selftests/net/rds/Makefile +++ b/tools/testing/selftests/net/rds/Makefile @@ -3,10 +3,9 @@ all: @echo mk_build_dir="$(shell pwd)" > include.sh -TEST_PROGS := run.sh \
- test.py
+TEST_PROGS := run.sh -TEST_FILES := include.sh +TEST_FILES := include.sh test.py EXTRA_CLEAN := /tmp/rds_logs include.sh
Hello:
This patch was applied to netdev/net.git (main) by Paolo Abeni pabeni@redhat.com:
On Sun, 24 Nov 2024 07:32:43 +0000 you wrote:
The test.py should not be run separately. It should be run via run.sh, which will do some sanity checks first. Move the test.py from TEST_PROGS to TEST_FILES.
Reported-by: Maximilian Heyne mheyne@amazon.de Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-5567... Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure") Signed-off-by: Hangbin Liu liuhangbin@gmail.com
[...]
Here is the summary with links: - [net] selftests: rds: move test.py to TEST_FILES https://git.kernel.org/netdev/net/c/663a91747553
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org
-
Allison Henderson -
Hangbin Liu -
patchwork-bot+netdevbpf＠kernel.org