I failed to build this test on Ubuntu 24.04. Compiler complained about undefined functions mount, umount and some mount related flags.
Signed-off-by: Chen Linxuan chenlinxuan@uniontech.com --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c index 96f274f0582b6..c3ee8a2eff75b 100644 --- a/tools/testing/selftests/pid_namespace/pid_max.c +++ b/tools/testing/selftests/pid_namespace/pid_max.c @@ -12,6 +12,7 @@ #include <syscall.h> #include <sys/mount.h> #include <sys/wait.h> +#include <sys/mount.h>
#include "../kselftest_harness.h" #include "../pidfd/pidfd.h"
On 6/9/25 20:08, Chen Linxuan wrote:
I failed to build this test on Ubuntu 24.04. Compiler complained about undefined functions mount, umount and some mount related flags.
Signed-off-by: Chen Linxuan chenlinxuan@uniontech.com
tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c index 96f274f0582b6..c3ee8a2eff75b 100644 --- a/tools/testing/selftests/pid_namespace/pid_max.c +++ b/tools/testing/selftests/pid_namespace/pid_max.c @@ -12,6 +12,7 @@ #include <syscall.h> #include <sys/mount.h>
Hmm. I see mount.h included here?
#include <sys/wait.h> +#include <sys/mount.h>
You are adding a duplicate include for the same file?
#include "../kselftest_harness.h" #include "../pidfd/pidfd.h"
thanks, -- Shuah
On Thu, Jun 19, 2025 at 5:25 AM Shuah Khan skhan@linuxfoundation.org wrote:
On 6/9/25 20:08, Chen Linxuan wrote:
I failed to build this test on Ubuntu 24.04. Compiler complained about undefined functions mount, umount and some mount related flags.
Signed-off-by: Chen Linxuan chenlinxuan@uniontech.com
tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c index 96f274f0582b6..c3ee8a2eff75b 100644 --- a/tools/testing/selftests/pid_namespace/pid_max.c +++ b/tools/testing/selftests/pid_namespace/pid_max.c @@ -12,6 +12,7 @@ #include <syscall.h> #include <sys/mount.h>
Hmm. I see mount.h included here?
我在重新发送补丁的时候犯了个错误，这个补丁之前就已经被合并了。抱歉。
#include <sys/wait.h> +#include <sys/mount.h>
You are adding a duplicate include for the same file?
#include "../kselftest_harness.h" #include "../pidfd/pidfd.h"
thanks, -- Shuah
On Thu, Jun 19, 2025 at 5:25 AM Shuah Khan skhan@linuxfoundation.org wrote:
On 6/9/25 20:08, Chen Linxuan wrote:
I failed to build this test on Ubuntu 24.04. Compiler complained about undefined functions mount, umount and some mount related flags.
Signed-off-by: Chen Linxuan chenlinxuan@uniontech.com
tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c index 96f274f0582b6..c3ee8a2eff75b 100644 --- a/tools/testing/selftests/pid_namespace/pid_max.c +++ b/tools/testing/selftests/pid_namespace/pid_max.c @@ -12,6 +12,7 @@ #include <syscall.h> #include <sys/mount.h>
Hmm. I see mount.h included here?
#include <sys/wait.h> +#include <sys/mount.h>
You are adding a duplicate include for the same file?
I made a mistake when resending the patch; this patch has already been merged before. Sorry.
#include "../kselftest_harness.h" #include "../pidfd/pidfd.h"
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org
-
Chen Linxuan -
Shuah Khan