On 8/29/24 23:29, Dev Jain wrote:

A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly introduced ksft_exit_fail_perror().

Signed-off-by: Dev Jain dev.jain@arm.com

tools/testing/selftests/arm64/abi/ptrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c index e4fa507cbdd0..b51d21f78cf9 100644 --- a/tools/testing/selftests/arm64/abi/ptrace.c +++ b/tools/testing/selftests/arm64/abi/ptrace.c @@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name) static int do_child(void) { if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))

• ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
  

• ksft_exit_fail_perror("PTRACE_TRACEME");
  

if (raise(SIGSTOP))

• ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
  

• ksft_exit_fail_perror("raise(SIGSTOP)");
  

return EXIT_SUCCESS; }

Thanks for doing this.

Reviewed-by: Shuah Khan skhan@linuxfoundation.org

thanks, -- Shuah