On 5/25/20 12:28 AM, Yauheni Kaliuta wrote:

Hi!

lib.mk expects TEST_GEN_PROGS, TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES to be in local directory and tries to handle out of tree build adding OUTPUT to it at the beginning.

commit be16a244c199 ("selftests: lib.mk: add TEST_CUSTOM_PROGS to allow custom test run/install") adds TEST_CUSTOM_PROGS but it handles it differently. Should it add OUTPUT as well?

Individual tests apply OUTPUT to TEST_CUSTOM_PROGS. lib.mk rules can't build TEST_CUSTOM_PROGS and it is left up to tests to handle them as custom.

So no on adding OUTPUT to TEST_CUSTOM_PROGS in lib.mk.

thanks, -- Shuah