Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: David Gow davidgow@google.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v2: followed new convention MAINTAINERS | 2 +- lib/Makefile | 2 +- lib/{list-test.c => list_kunit.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename lib/{list-test.c => list_kunit.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS index 4538378de6f5..20facbca9388 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10188,7 +10188,7 @@ M: David Gow davidgow@google.com L: linux-kselftest@vger.kernel.org L: kunit-dev@googlegroups.com S: Maintained -F: lib/list-test.c +F: lib/list_kunit.c
LIVE PATCHING M: Josh Poimboeuf jpoimboe@redhat.com diff --git a/lib/Makefile b/lib/Makefile index 5ca03ba6ee45..1a5e6a6ebe8d 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o -obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o +obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o obj-$(CONFIG_BITS_TEST) += test_bits.o diff --git a/lib/list-test.c b/lib/list_kunit.c similarity index 100% rename from lib/list-test.c rename to lib/list_kunit.c
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: Mark Brown broonie@kernel.org Cc: Matti Vaittinen matti.vaittinen@fi.rohmeurope.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v2: new patch MAINTAINERS | 3 +-- lib/Makefile | 2 +- lib/{test_linear_ranges.c => linear_ranges_kunit.c} | 0 3 files changed, 2 insertions(+), 3 deletions(-) rename lib/{test_linear_ranges.c => linear_ranges_kunit.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS index 20facbca9388..249417a036f9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10069,8 +10069,7 @@ F: include/uapi/linux/lightnvm.h LINEAR RANGES HELPERS M: Mark Brown broonie@kernel.org R: Matti Vaittinen matti.vaittinen@fi.rohmeurope.com -F: lib/linear_ranges.c -F: lib/test_linear_ranges.c +F: lib/linear_ranges*.c F: include/linux/linear_range.h
LINUX FOR POWER MACINTOSH diff --git a/lib/Makefile b/lib/Makefile index 1a5e6a6ebe8d..5c18519d6733 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o +obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o -obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o obj-$(CONFIG_BITS_TEST) += test_bits.o diff --git a/lib/test_linear_ranges.c b/lib/linear_ranges_kunit.c similarity index 100% rename from lib/test_linear_ranges.c rename to lib/linear_ranges_kunit.c
On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: Mark Brown broonie@kernel.org Cc: Matti Vaittinen matti.vaittinen@fi.rohmeurope.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Thanks. This looks good to me from an "I tested it and it worked" and a "matches the naming guidelines" point of view.
(Since the naming documentation isn't actually in Linus' branch yet, I'll drop a link to it here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tr... )
I'm not the test author though, and the naming doc does explicitly leave the possibility of keeping the old filenames for tests if there's a particularly good reason to (e.g., a lot depending on the module name). I'm not aware of any such thing, and so am in favour of the rename, but will defer to the test authors on that point if they object.
Either way, Reviewed-by: David Gow davidgow@google.com
Cheers, -- David
On Fri, Oct 16, 2020 at 01:02:20PM +0800, David Gow wrote:
On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: Mark Brown broonie@kernel.org Cc: Matti Vaittinen matti.vaittinen@fi.rohmeurope.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Thanks. This looks good to me from an "I tested it and it worked" and a "matches the naming guidelines" point of view.
(Since the naming documentation isn't actually in Linus' branch yet, I'll drop a link to it here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tr... )
I'm not the test author though, and the naming doc does explicitly leave the possibility of keeping the old filenames for tests if there's a particularly good reason to (e.g., a lot depending on the module name).
Can you point out to this? Briefly looking into I haven't found that.
I'm not aware of any such thing, and so am in favour of the rename, but will defer to the test authors on that point if they object.
Either way, Reviewed-by: David Gow davidgow@google.com
Thanks!
On Fri, Oct 16, 2020 at 5:29 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Fri, Oct 16, 2020 at 01:02:20PM +0800, David Gow wrote:
On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: Mark Brown broonie@kernel.org Cc: Matti Vaittinen matti.vaittinen@fi.rohmeurope.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Thanks. This looks good to me from an "I tested it and it worked" and a "matches the naming guidelines" point of view.
(Since the naming documentation isn't actually in Linus' branch yet, I'll drop a link to it here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tr... )
I'm not the test author though, and the naming doc does explicitly leave the possibility of keeping the old filenames for tests if there's a particularly good reason to (e.g., a lot depending on the module name).
Can you point out to this? Briefly looking into I haven't found that.
This was what was intended by the first "exemption" listed[1] at the beginning of the document: "It's recommended that you only deviate from these guidelines when: [...] Porting tests to KUnit which are already known with an existing name"
Admittedly, this test was originally a KUnit test, rather than a port of another test, so the exact wording probably doesn't apply here, but that's more an artefact of the naming guidelines landing after this test did.
The goal here is really just to make sure that existing test modules can be ported to KUnit without breaking existing users which may depend on the name. It doesn't look like that applies for this test, though.
Cheers, -- David
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tr...
On Thu, Oct 15, 2020 at 09:44:15PM +0300, Andy Shevchenko wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
I'm missing the rest of this series - what's the story with dependencies here?
On Fri, Oct 16, 2020 at 11:38:41AM +0100, Mark Brown wrote:
On Thu, Oct 15, 2020 at 09:44:15PM +0300, Andy Shevchenko wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
I'm missing the rest of this series - what's the story with dependencies here?
There is a dependency in Makefile. Do you want me to send a new version with Cc'ing you all?
On Fri, Oct 16, 2020 at 02:03:44PM +0300, Andy Shevchenko wrote:
On Fri, Oct 16, 2020 at 11:38:41AM +0100, Mark Brown wrote:
On Thu, Oct 15, 2020 at 09:44:15PM +0300, Andy Shevchenko wrote:
I'm missing the rest of this series - what's the story with dependencies here?
There is a dependency in Makefile. Do you want me to send a new version with Cc'ing you all?
v3 has been sent.
On Fri, Oct 16, 2020 at 02:03:44PM +0300, Andy Shevchenko wrote:
On Fri, Oct 16, 2020 at 11:38:41AM +0100, Mark Brown wrote:
I'm missing the rest of this series - what's the story with dependencies here?
There is a dependency in Makefile. Do you want me to send a new version with Cc'ing you all?
It's fine this time but please don't do this in future, people need at least a cover letter so they know how things rae related to each other.
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v2: new patch lib/Makefile | 2 +- lib/{test_bits.c => bits_kunit.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename lib/{test_bits.c => bits_kunit.c} (100%)
diff --git a/lib/Makefile b/lib/Makefile index 5c18519d6733..70a4a21ff5d6 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
# KUnit tests obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o +obj-$(CONFIG_BITS_TEST) += bits_kunit.o obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o -obj-$(CONFIG_BITS_TEST) += test_bits.o diff --git a/lib/test_bits.c b/lib/bits_kunit.c similarity index 100% rename from lib/test_bits.c rename to lib/bits_kunit.c
On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Again, this worked and looks good to me. Apart from noting that the module name will change (so if people are depending on that, it'll break things), I'm all in favour of this.
For the record (since it's not quite upstream yet), the naming documentation referenced is currently available here: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tr...
Anyway, Reviewed-by: David Gow davidgow@google.com
Thanks, -- David
On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.
Cc: David Gow davidgow@google.com Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Thanks! You've saved me the work of doing this myself. :-)
Reviewed-by: David Gow davidgow@google.com
linux-kselftest-mirror@lists.linaro.org
-
Andy Shevchenko -
David Gow -
Mark Brown