The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com --- tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/tpm2/test_async.sh b/tools/testing/selftests/tpm2/test_async.sh index 43bf5bd772fd4..cf5a9c826097b 100755 --- a/tools/testing/selftests/tpm2/test_async.sh +++ b/tools/testing/selftests/tpm2/test_async.sh @@ -7,4 +7,4 @@ ksft_skip=4 [ -e /dev/tpm0 ] || exit $ksft_skip [ -e /dev/tpmrm0 ] || exit $ksft_skip
-python3 -m unittest -v tpm2_tests.AsyncTest +python3 -m unittest -v tpm2_tests.AsyncTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index 58af963e5b55a..20fa70f970a9a 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -6,4 +6,4 @@ ksft_skip=4
[ -e /dev/tpm0 ] || exit $ksft_skip
-python3 -m unittest -v tpm2_tests.SmokeTest +python3 -m unittest -v tpm2_tests.SmokeTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index 04c47b13fe8ac..93894cbc89a80 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -6,4 +6,4 @@ ksft_skip=4
[ -e /dev/tpmrm0 ] || exit $ksft_skip
-python3 -m unittest -v tpm2_tests.SpaceTest +python3 -m unittest -v tpm2_tests.SpaceTest 2>&1
Reminder
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/tpm2/test_async.sh b/tools/testing/selftests/tpm2/test_async.sh index 43bf5bd772fd4..cf5a9c826097b 100755 --- a/tools/testing/selftests/tpm2/test_async.sh +++ b/tools/testing/selftests/tpm2/test_async.sh @@ -7,4 +7,4 @@ ksft_skip=4 [ -e /dev/tpm0 ] || exit $ksft_skip [ -e /dev/tpmrm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.AsyncTest +python3 -m unittest -v tpm2_tests.AsyncTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index 58af963e5b55a..20fa70f970a9a 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -6,4 +6,4 @@ ksft_skip=4 [ -e /dev/tpm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.SmokeTest +python3 -m unittest -v tpm2_tests.SmokeTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index 04c47b13fe8ac..93894cbc89a80 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -6,4 +6,4 @@ ksft_skip=4 [ -e /dev/tpmrm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.SpaceTest +python3 -m unittest -v tpm2_tests.SpaceTest 2>&1
On 7/31/24 07:42, Muhammad Usama Anjum wrote:
Reminder
top post???
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to linux-kselftest next for Linux 6.12-rc1
thanks, -- Shuah
On Wed Jul 31, 2024 at 8:45 PM EEST, Shuah Khan wrote:
On 7/31/24 07:42, Muhammad Usama Anjum wrote:
Reminder
top post???
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to linux-kselftest next for Linux 6.12-rc1
thanks, -- Shuah
OK, great. Maybe it is not *that* critical to backport this.
BR, Jarkko
On 8/1/24 16:24, Jarkko Sakkinen wrote:
On Wed Jul 31, 2024 at 8:45 PM EEST, Shuah Khan wrote:
On 7/31/24 07:42, Muhammad Usama Anjum wrote:
Reminder
top post???
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to linux-kselftest next for Linux 6.12-rc1
thanks, -- Shuah
OK, great. Maybe it is not *that* critical to backport this.
I took the liberty to pull this in. I agree that this doesn't need backport. It suppresses messages and doesn't really fix any bug.
I tested it to make sure it doesn't suppress important messages.
thanks, -- Shuah
On Fri Aug 2, 2024 at 1:58 AM EEST, Shuah Khan wrote:
On 8/1/24 16:24, Jarkko Sakkinen wrote:
On Wed Jul 31, 2024 at 8:45 PM EEST, Shuah Khan wrote:
On 7/31/24 07:42, Muhammad Usama Anjum wrote:
Reminder
top post???
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to linux-kselftest next for Linux 6.12-rc1
thanks, -- Shuah
OK, great. Maybe it is not *that* critical to backport this.
I took the liberty to pull this in. I agree that this doesn't need backport. It suppresses messages and doesn't really fix any bug.
I tested it to make sure it doesn't suppress important messages.
OK, great thanks a lot!
thanks, -- Shuah
BR, Jarkko
On Wed Jul 31, 2024 at 4:42 PM EEST, Muhammad Usama Anjum wrote:
Reminder
On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote:
The python unittest module writes all its output to stderr, even when the run is clean. Redirect its output logs to stdout.
Cc: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/tpm2/test_async.sh b/tools/testing/selftests/tpm2/test_async.sh index 43bf5bd772fd4..cf5a9c826097b 100755 --- a/tools/testing/selftests/tpm2/test_async.sh +++ b/tools/testing/selftests/tpm2/test_async.sh @@ -7,4 +7,4 @@ ksft_skip=4 [ -e /dev/tpm0 ] || exit $ksft_skip [ -e /dev/tpmrm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.AsyncTest +python3 -m unittest -v tpm2_tests.AsyncTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index 58af963e5b55a..20fa70f970a9a 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -6,4 +6,4 @@ ksft_skip=4 [ -e /dev/tpm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.SmokeTest +python3 -m unittest -v tpm2_tests.SmokeTest 2>&1 diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index 04c47b13fe8ac..93894cbc89a80 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -6,4 +6,4 @@ ksft_skip=4 [ -e /dev/tpmrm0 ] || exit $ksft_skip -python3 -m unittest -v tpm2_tests.SpaceTest +python3 -m unittest -v tpm2_tests.SpaceTest 2>&1
I was on holiday for four weeks so thus the latency. And also mbsync failed on me for sometime:
https://social.kernel.org/notice/AkX1oAnWFMXja3uN84
Anyway, agreeing with the code changes but I think this categorizes as a bug so please add the fixes tag and send v2.
BR, Jarkko
linux-kselftest-mirror@lists.linaro.org
-
Jarkko Sakkinen -
Jarkko Sakkinen -
Muhammad Usama Anjum -
Shuah Khan