On Wed, 18 Nov 2020 16:43:33 -0500 Willem de Bruijn wrote:

On Tue, Nov 17, 2020 at 12:19 PM Jakub Kicinski kuba@kernel.org wrote:

...

Sorry I misremembered it's 4. We can leave that as is.

Instead of having to remember, maybe we should have a file in tools/testing/selftest to define constants?

I defined them one-off in tools/testing/selftests/net/udpgso_bench.sh

readonly KSFT_PASS=0 readonly KSFT_FAIL=1 readonly KSFT_SKIP=4

along with some other kselftest shell support infra. But having each test figure this out independently is duplicative and error prone.

Sounds like a good idea, I was surprised it wasn't already defined in any lib.

CCing the selftest ML.