Due to the raw_output() function on kunit_parser.py actually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen if raw_output is enabled), it was not printing anything.
Fixes: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse") Signed-off-by: David Gow davidgow@google.com --- tools/testing/kunit/kunit_parser.py | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py index 8019e3dd4c32..744ee9cb0073 100644 --- a/tools/testing/kunit/kunit_parser.py +++ b/tools/testing/kunit/kunit_parser.py @@ -66,7 +66,6 @@ def isolate_kunit_output(kernel_output): def raw_output(kernel_output): for line in kernel_output: print(line) - yield line
DIVIDER = '=' * 60
On Wed, Oct 21, 2020 at 8:05 PM David Gow davidgow@google.com wrote:
Due to the raw_output() function on kunit_parser.py actually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen if raw_output is enabled), it was not printing anything.
Fixes: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse") Signed-off-by: David Gow davidgow@google.com
Thanks for fixing this!
Reviewed-by: Brendan Higgins brendanhiggins@google.com Tested-by: Brendan Higgins brendanhiggins@google.com
On 10/21/20 10:11 PM, Brendan Higgins wrote:
On Wed, Oct 21, 2020 at 8:05 PM David Gow davidgow@google.com wrote:
Due to the raw_output() function on kunit_parser.py actually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen if raw_output is enabled), it was not printing anything.
Fixes: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
You need just the SHA1 45ba7a893ad8
Fixed this up and applied to linux-kselftest kunit-fixes branch
Signed-off-by: David Gow davidgow@google.com
Thanks for fixing this!
Reviewed-by: Brendan Higgins brendanhiggins@google.com Tested-by: Brendan Higgins brendanhiggins@google.com
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org