From: Li Zhijian zhijianx.li@intel.com
test_maps contains a series of stress tests, and previously it will break the reset tests when it failed to alloc memory. ----------------------- Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=16 value=262144 'Cannot allocate memory' Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=8 value=262144 'Cannot allocate memory' test_maps: test_maps.c:955: run_parallel: Assertion `status == 0' failed. Aborted not ok 1..3 selftests: test_maps [FAIL] ----------------------- after this patch, the rest tests will be continue when it occurs a ENOMEM failure
CC: Alexei Starovoitov alexei.starovoitov@gmail.com CC: Philip Li philip.li@intel.com Suggest-by: Daniel Borkmann daniel@iogearbox.net Signed-off-by: Li Zhijian zhijianx.li@intel.com --- tools/testing/selftests/bpf/test_maps.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c index 436c4c7..9e03a4c 100644 --- a/tools/testing/selftests/bpf/test_maps.c +++ b/tools/testing/selftests/bpf/test_maps.c @@ -126,6 +126,8 @@ static void test_hashmap_sizes(int task, void *data) fd = bpf_create_map(BPF_MAP_TYPE_HASH, i, j, 2, map_flags); if (fd < 0) { + if (errno == ENOMEM) + return; printf("Failed to create hashmap key=%d value=%d '%s'\n", i, j, strerror(errno)); exit(1);
On Mon, Feb 12, 2018 at 09:52:04PM +0800, Li Zhijian wrote:
From: Li Zhijian zhijianx.li@intel.com
test_maps contains a series of stress tests, and previously it will break the reset tests when it failed to alloc memory.
Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=16 value=262144 'Cannot allocate memory' Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=8 value=262144 'Cannot allocate memory' test_maps: test_maps.c:955: run_parallel: Assertion `status == 0' failed. Aborted not ok 1..3 selftests: test_maps [FAIL]
after this patch, the rest tests will be continue when it occurs a ENOMEM failure
CC: Alexei Starovoitov alexei.starovoitov@gmail.com CC: Philip Li philip.li@intel.com Suggest-by: Daniel Borkmann daniel@iogearbox.net Signed-off-by: Li Zhijian zhijianx.li@intel.com
could you please resend it and cc netdev so it appears in patchworks properly.
Thanks!
-- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
linux-kselftest-mirror@lists.linaro.org