When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty static function.
But GCC complains about unused static functions, *unless* they're static inline. So add inline to make GCC happy.
Signed-off-by: Daniel Latypov dlatypov@google.com Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools") --- include/kunit/test-bug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/kunit/test-bug.h b/include/kunit/test-bug.h index ce6f6edc7801..5fc58081d511 100644 --- a/include/kunit/test-bug.h +++ b/include/kunit/test-bug.h @@ -19,8 +19,8 @@ extern __printf(3, 4) void __kunit_fail_current_test(const char *file, int line,
#else
-static __printf(3, 4) void __kunit_fail_current_test(const char *file, int line, - const char *fmt, ...) +static inline __printf(3, 4) void __kunit_fail_current_test(const char *file, int line, + const char *fmt, ...) { }
base-commit: 359a376081d4fadfb073e3ddeb6bd6dc94d98341
On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov dlatypov@google.com wrote:
When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty static function.
But GCC complains about unused static functions, *unless* they're static inline. So add inline to make GCC happy.
Signed-off-by: Daniel Latypov dlatypov@google.com Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools")
Reviewed-by: Brendan Higgins brendanhiggins@google.com
On 4/6/21 2:50 PM, Brendan Higgins wrote:
On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov dlatypov@google.com wrote:
When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty static function.
But GCC complains about unused static functions, *unless* they're static inline. So add inline to make GCC happy.
Signed-off-by: Daniel Latypov dlatypov@google.com Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools")
Signed-off-by comes after Fixes. Also good to add Reported-by for Stephen acknowledging the reporter.
I will fix this up when I apply - for future reference.
Reviewed-by: Brendan Higgins brendanhiggins@google.com
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org