On 11/23/22 16:25, Maxime Ripard wrote:

DRM-managed actions are supposed to be ran whenever the device is released. Let's introduce a basic unit test to make sure it happens.

Signed-off-by: Maxime Ripard maxime@cerno.tech

drivers/gpu/drm/tests/Makefile | 1 + drivers/gpu/drm/tests/drm_managed_test.c | 68 ++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+)

diff --git a/drivers/gpu/drm/tests/Makefile b/drivers/gpu/drm/tests/Makefile index b29ef1085cad..35962c6ef0c4 100644 --- a/drivers/gpu/drm/tests/Makefile +++ b/drivers/gpu/drm/tests/Makefile @@ -9,6 +9,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ drm_format_test.o \ drm_framebuffer_test.o \ drm_kunit_helpers.o \

• drm_managed_test.o \ drm_mm_test.o \ drm_plane_helper_test.o \ drm_rect_test.o

diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c new file mode 100644 index 000000000000..4fc11b289d9e --- /dev/null +++ b/drivers/gpu/drm/tests/drm_managed_test.c @@ -0,0 +1,68 @@ +// SPDX-License-Identifier: GPL-2.0

+#include <drm/drm_drv.h> +#include <drm/drm_managed.h>

+#include <kunit/resource.h>

+#include <linux/device.h>

+#include "drm_kunit_helpers.h"

+#define TEST_TIMEOUT_MS 100

Why did you choose this timeout value? Maybe we can add some comments explaining the rationale.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com