This fix solves this error, when calling kselftest with targets "net/rds":
The error was found by running tests manually with the command: make kselftest TARGETS="net/rds"
The patch also specifies to import ip() function from the utils module.
Signed-off-by: Alessandro Zanni alessandro.zanni87@gmail.com ---
Notes: v2: modified the way the parent path is added added test to reproduce the error
tools/testing/selftests/net/rds/test.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py index e6bb109bcead..4a7178d11193 100755 --- a/tools/testing/selftests/net/rds/test.py +++ b/tools/testing/selftests/net/rds/test.py @@ -14,8 +14,11 @@ import sys import atexit from pwd import getpwuid from os import stat -from lib.py import ip
+# Allow utils module to be imported from different directory +this_dir = os.path.dirname(os.path.realpath(__file__)) +sys.path.append(os.path.join(this_dir, "../")) +from lib.py.utils import ip
libc = ctypes.cdll.LoadLibrary('libc.so.6') setns = libc.setns
On Thu, 2024-10-10 at 21:44 +0200, Alessandro Zanni wrote:
This fix solves this error, when calling kselftest with targets "net/rds":
The error was found by running tests manually with the command: make kselftest TARGETS="net/rds"
The patch also specifies to import ip() function from the utils module.
Signed-off-by: Alessandro Zanni alessandro.zanni87@gmail.com
I think this one looks ok. Thanks Alessandro!
Reviewed-by: Allison Henderson allison.henderson@oracle.com
Notes: v2: modified the way the parent path is added added test to reproduce the error
tools/testing/selftests/net/rds/test.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py index e6bb109bcead..4a7178d11193 100755 --- a/tools/testing/selftests/net/rds/test.py +++ b/tools/testing/selftests/net/rds/test.py @@ -14,8 +14,11 @@ import sys import atexit from pwd import getpwuid from os import stat -from lib.py import ip +# Allow utils module to be imported from different directory +this_dir = os.path.dirname(os.path.realpath(__file__)) +sys.path.append(os.path.join(this_dir, "../")) +from lib.py.utils import ip libc = ctypes.cdll.LoadLibrary('libc.so.6') setns = libc.setns
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski kuba@kernel.org:
On Thu, 10 Oct 2024 21:44:17 +0200 you wrote:
This fix solves this error, when calling kselftest with targets "net/rds":
The error was found by running tests manually with the command: make kselftest TARGETS="net/rds"
The patch also specifies to import ip() function from the utils module.
[...]
Here is the summary with links: - [v2] selftests: net/rds: add module not found https://git.kernel.org/netdev/net/c/6ea8a1c28fd3
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org