On 9/5/24 02:13, zhangjiao2 wrote:

From: zhang jiao zhangjiao2@cmss.chinamobile.com

This macro NSEC_PER_SEC is never referenced in the code. Just remove it.

I think I commented on your patch on futex - include how you found the problem in change logs. Also you have to include subsystem prefix in the subject line:

selftests/timers: Remove unused NSEC_PER_SEC macro

I see another patch with similar problems from you. Refer to submitting patches document in the kernel repo.

Signed-off-by: zhang jiao zhangjiao2@cmss.chinamobile.com

tools/testing/selftests/timers/skew_consistency.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c index c8e6bffe4e0a..83450145fe65 100644 --- a/tools/testing/selftests/timers/skew_consistency.c +++ b/tools/testing/selftests/timers/skew_consistency.c @@ -36,8 +36,6 @@ #include <sys/wait.h> #include "../kselftest.h" -#define NSEC_PER_SEC 1000000000LL

• int main(int argc, char **argv) { struct timex tx;

thanks, -- Shuah