Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
Signed-off-by: Bui Quang Minh minhquangbui99@gmail.com --- tools/testing/selftests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 6aa11cd3db42..5b04d83ad9a1 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -205,7 +205,7 @@ export KHDR_INCLUDES
all: @ret=1; \ - for TARGET in $(TARGETS); do \ + for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ mkdir $$BUILD_TARGET -p; \ $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET \ @@ -270,7 +270,7 @@ ifdef INSTALL_PATH install -m 744 run_kselftest.sh $(INSTALL_PATH)/ rm -f $(TEST_LIST) @ret=1; \ - for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \ + for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET install \ INSTALL_PATH=$(INSTALL_PATH)/$$TARGET \
On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
Hi,
The above describes what is being done. I think it would be good to also describe why.
Signed-off-by: Bui Quang Minh minhquangbui99@gmail.com
...
On 5/29/25 17:32, Simon Horman wrote:
On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
Hi,
The above describes what is being done. I think it would be good to also describe why.
Hi,
Currently, when building net related selftests, we need to
make install
so that the net/lib is compiled. In case we do
make
or
make run_tests
the net/lib is not compiled. So I move the INSTALL_DEP_TARGETS which is net/lib if the selftests is net related to all. As a result, all make/make install/make run_tests will have the net/lib compiled.
Thanks, Quang Minh.
On Thu, May 29, 2025 at 06:04:17PM +0700, Bui Quang Minh wrote:
On 5/29/25 17:32, Simon Horman wrote:
On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
Hi,
The above describes what is being done. I think it would be good to also describe why.
Hi,
Currently, when building net related selftests, we need to
make install
so that the net/lib is compiled. In case we do
make
or
make run_tests
the net/lib is not compiled. So I move the INSTALL_DEP_TARGETS which is net/lib if the selftests is net related to all. As a result, all make/make install/make run_tests will have the net/lib compiled.
Thanks for the explanation, it is much appreciated.
I think it would be good to include something along those lines in the commit message of the patch.
Please note, that if you post a v2, before doing so you should allow 24h to elapse since the posting of v1.
On 5/29/25 20:34, Simon Horman wrote:
On Thu, May 29, 2025 at 06:04:17PM +0700, Bui Quang Minh wrote:
On 5/29/25 17:32, Simon Horman wrote:
On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
Hi,
The above describes what is being done. I think it would be good to also describe why.
Hi,
Currently, when building net related selftests, we need to
make install
so that the net/lib is compiled. In case we do
make
or
make run_tests
the net/lib is not compiled. So I move the INSTALL_DEP_TARGETS which is net/lib if the selftests is net related to all. As a result, all make/make install/make run_tests will have the net/lib compiled.
Thanks for the explanation, it is much appreciated.
I think it would be good to include something along those lines in the commit message of the patch.
Please note, that if you post a v2, before doing so you should allow 24h to elapse since the posting of v1.
Thanks for your review and for pointing me the document.
Quang Minh.
On Thu, 29 May 2025 14:05:36 +0700 Bui Quang Minh wrote:
Currently, we only build net/lib dependency in install target. This commit moves that to all target so that net/lib is included in in-tree build and run_tests.
With Simon's comments addressed, feel free to add to v2:
Reviewed-by: Jakub Kicinski kuba@kernel.org
Thanks!
linux-kselftest-mirror@lists.linaro.org
-
Bui Quang Minh -
Jakub Kicinski -
Simon Horman