On Wed, Sep 06, 2023 at 08:39:22AM -0700, Beau Belgrave wrote:
What is the expected behavior of self tests if run without their feature enabled? Is it expected these should skip vs fail in that case?
Yes, tests should skip if preconditions for running them aren't met.
On Wed, 6 Sep 2023 17:02:19 +0100 Mark Brown broonie@kernel.org wrote:
On Wed, Sep 06, 2023 at 08:39:22AM -0700, Beau Belgrave wrote:
What is the expected behavior of self tests if run without their feature enabled? Is it expected these should skip vs fail in that case?
Yes, tests should skip if preconditions for running them aren't met.
Yep, see how the ftrace selftests run. If it is determined that the feature is not present, it simple returns UNSUPPORTED and not FAILED.
-- Steve
On Wed, Sep 06, 2023 at 12:28:22PM -0400, Steven Rostedt wrote:
Mark Brown broonie@kernel.org wrote:
Yes, tests should skip if preconditions for running them aren't met.
Yep, see how the ftrace selftests run. If it is determined that the feature is not present, it simple returns UNSUPPORTED and not FAILED.
In KTAP terms that's specifically SKIP, generated by calling SKIP() if using kselftest_harness.h.
linux-kselftest-mirror@lists.linaro.org
-
Mark Brown -
Steven Rostedt