Currently, sendmmsg is implemented in udpgso_bench_tx.c, but it is not called by any test script.
This patch adds a test for sendmmsg in udpgso_bench.sh. This allows for basic API testing and benchmarking comparisons with GSO. --- tools/testing/selftests/net/udpgso_bench.sh | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh index 640bc43452fa..88fa1d53ba2b 100755 --- a/tools/testing/selftests/net/udpgso_bench.sh +++ b/tools/testing/selftests/net/udpgso_bench.sh @@ -92,6 +92,9 @@ run_udp() { echo "udp" run_in_netns ${args}
+ echo "udp sendmmsg" + run_in_netns ${args} -m + echo "udp gso" run_in_netns ${args} -S 0
On Tue, Dec 03, 2024 at 08:21:29AM +0900, Kenjiro Nakayama wrote:
Currently, sendmmsg is implemented in udpgso_bench_tx.c, but it is not called by any test script.
This patch adds a test for sendmmsg in udpgso_bench.sh. This allows for basic API testing and benchmarking comparisons with GSO.
tools/testing/selftests/net/udpgso_bench.sh | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh index 640bc43452fa..88fa1d53ba2b 100755 --- a/tools/testing/selftests/net/udpgso_bench.sh +++ b/tools/testing/selftests/net/udpgso_bench.sh @@ -92,6 +92,9 @@ run_udp() { echo "udp" run_in_netns ${args}
- echo "udp sendmmsg"
- run_in_netns ${args} -m
- echo "udp gso" run_in_netns ${args} -S 0
2.39.3 (Apple Git-146)
Reviewed-by: Hangbin Liu liuhangbin@gmail.com
Kenjiro Nakayama wrote:
Currently, sendmmsg is implemented in udpgso_bench_tx.c, but it is not called by any test script.
This patch adds a test for sendmmsg in udpgso_bench.sh. This allows for basic API testing and benchmarking comparisons with GSO.
The change looks fine to me, but the commit is missing your Signed-off-by.
Also, if resubmitting, please mark [PATCH net-next v2].
tools/testing/selftests/net/udpgso_bench.sh | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh index 640bc43452fa..88fa1d53ba2b 100755 --- a/tools/testing/selftests/net/udpgso_bench.sh +++ b/tools/testing/selftests/net/udpgso_bench.sh @@ -92,6 +92,9 @@ run_udp() { echo "udp" run_in_netns ${args}
- echo "udp sendmmsg"
- run_in_netns ${args} -m
- echo "udp gso" run_in_netns ${args} -S 0
2.39.3 (Apple Git-146)
linux-kselftest-mirror@lists.linaro.org
-
Hangbin Liu -
Kenjiro Nakayama -
Willem de Bruijn