Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com --- tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh index b76a881d4013..289eb7d4c4b3 100755 --- a/tools/testing/selftests/livepatch/test-syscall.sh +++ b/tools/testing/selftests/livepatch/test-syscall.sh @@ -15,7 +15,10 @@ setup_config
start_test "patch getpid syscall while being heavily hammered"
-for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do +NPROC=$(getconf _NPROCESSORS_ONLN) +MAXPROC=128 + +for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do ./test_klp-call_getpid & pids[$i]="$!" done
From: mpdesouza@suse.com
On Wed, 29 May 2024 16:19:41 -0400 Ryan Sullivan rysulliv@redhat.com wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
I believe that 128 threads hammering getpid is good enough :)
Tested-by: Marcos Paulo de Souza mpdesouza@suse.com Reviewed-by: Marcos Paulo de Souza mpdesouza@suse.com
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh index b76a881d4013..289eb7d4c4b3 100755 --- a/tools/testing/selftests/livepatch/test-syscall.sh +++ b/tools/testing/selftests/livepatch/test-syscall.sh @@ -15,7 +15,10 @@ setup_config start_test "patch getpid syscall while being heavily hammered" -for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do +NPROC=$(getconf _NPROCESSORS_ONLN) +MAXPROC=128
+for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do ./test_klp-call_getpid & pids[$i]="$!" done -- 2.44.0
On Wed 2024-05-29 16:19:41, Ryan Sullivan wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
Looks reasonable.
Reviewed-by: Petr Mladek pmladek@suse.com
Best Regards, Petr
PS: I am going to queue it for 6.11. I will add it into a pull request for 6.10-rcX if there will be another more critical fix which would need such a pull request.
Hi,
On Wed, 29 May 2024, Ryan Sullivan wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
a nit: we usually use just "selftests/livepatch:" prefix in Subject.
Acked-by: Miroslav Benes mbenes@suse.cz
M
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com --- tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh index b76a881d4013..289eb7d4c4b3 100755 --- a/tools/testing/selftests/livepatch/test-syscall.sh +++ b/tools/testing/selftests/livepatch/test-syscall.sh @@ -15,7 +15,10 @@ setup_config
start_test "patch getpid syscall while being heavily hammered"
-for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do +NPROC=$(getconf _NPROCESSORS_ONLN) +MAXPROC=128 + +for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do ./test_klp-call_getpid & pids[$i]="$!" done
On Thu, Jun 6, 2024 at 9:54 AM Ryan Sullivan rysulliv@redhat.com wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh index b76a881d4013..289eb7d4c4b3 100755 --- a/tools/testing/selftests/livepatch/test-syscall.sh +++ b/tools/testing/selftests/livepatch/test-syscall.sh @@ -15,7 +15,10 @@ setup_config
start_test "patch getpid syscall while being heavily hammered"
-for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do +NPROC=$(getconf _NPROCESSORS_ONLN) +MAXPROC=128
+for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do ./test_klp-call_getpid & pids[$i]="$!" done -- 2.44.0
Acked-by: Joel Savitz jsavitz@redhat.com
On Thu, 2024-06-06 at 09:53 -0400, Ryan Sullivan wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
Hi Ryan,
is this the same patch that you sent on ? I couldn't spot any changes, and you also didn't tagged a different version for this patch.
tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh index b76a881d4013..289eb7d4c4b3 100755 --- a/tools/testing/selftests/livepatch/test-syscall.sh +++ b/tools/testing/selftests/livepatch/test-syscall.sh @@ -15,7 +15,10 @@ setup_config start_test "patch getpid syscall while being heavily hammered" -for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do +NPROC=$(getconf _NPROCESSORS_ONLN) +MAXPROC=128
+for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do ./test_klp-call_getpid & pids[$i]="$!" done
On Thu, 6 Jun 2024, Ryan Sullivan wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
Acked-by: Miroslav Benes mbenes@suse.cz
M
On Thu 2024-06-06 09:53:48, Ryan Sullivan wrote:
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error.
Reported-by: CKI Project cki-project@redhat.com Signed-off-by: Ryan Sullivan rysulliv@redhat.com
JFYI, the patch has been committed into livepatching.git, branch for-6.11.
Best Regards, Petr
linux-kselftest-mirror@lists.linaro.org
-
Joel Savitz -
Marcos Paulo de Souza -
Miroslav Benes -
Petr Mladek -
Ryan Sullivan