CoreSight

coresight@lists.linaro.org

6 participants
2390 discussions

Re: [PATCH] coresight: constify the struct device_type usage

by James Clark

On 19/02/2024 13:43, Ricardo B. Marliere wrote: > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver > core can properly handle constant struct device_type. Move the > coresight_dev_type variable to be a constant structure as well, placing it > into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo(a)marliere.net> > --- > drivers/hwtracing/coresight/coresight-priv.h | 2 +- > drivers/hwtracing/coresight/coresight-sysfs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index eb365236f9a9..ca3362cbdb70 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -13,7 +13,7 @@ > #include <linux/pm_runtime.h> > > extern struct mutex coresight_mutex; > -extern struct device_type coresight_dev_type[]; > +extern const struct device_type coresight_dev_type[]; > > /* > * Coresight management registers (0xf00-0xfcc) > diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtracing/coresight/coresight-sysfs.c > index f9444e2cb1d9..1e67cc7758d7 100644 > --- a/drivers/hwtracing/coresight/coresight-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-sysfs.c > @@ -377,7 +377,7 @@ static struct attribute *coresight_source_attrs[] = { > }; > ATTRIBUTE_GROUPS(coresight_source); > > -struct device_type coresight_dev_type[] = { > +const struct device_type coresight_dev_type[] = { > [CORESIGHT_DEV_TYPE_SINK] = { > .name = "sink", > .groups = coresight_sink_groups, > > --- > base-commit: c099fdd218a0fedfe87e0b88d2ba0667eab3b3c8 > change-id: 20240219-device_cleanup-coresight-00ba00fd5f21 > > Best regards, Reviewed-by: James Clark <james.clark(a)arm.com>

1 year, 4 months

[PATCH v2 0/2] coresight: tpdm: Change qcom,dsb-element-size to qcom,dsb-elem-bits

by Mao Jinlong

As unit of dsb element size is bit, change qcom,dsb-element-size to qcom,dsb-elem-bits. And CMB uses -bits suffix as well. There is no TPDM node in any DT now. Make such change before any TPDM node is added to DT. Change since V1: 1. Update the commit message for dt-binding. 2. Fix the dt_binding_check error for dt-binding change. Mao Jinlong (2): dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size coresight-tpda: Change qcom,dsb-element-size to qcom,dsb-elem-bits .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 ++--- drivers/hwtracing/coresight/coresight-tpda.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) -- 2.41.0

1 year, 4 months

Re: [PATCH v1 1/2] dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size

by Suzuki K Poulose

On 14/02/2024 16:03, Rob Herring wrote: > On Wed, Feb 14, 2024 at 9:56 AM Suzuki K Poulose <suzuki.poulose(a)arm.com> wrote: >> >> On 13/02/2024 22:29, Rob Herring wrote: >>> On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote: >>>> Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is >>>> bit. >>> >>> That may be, but this is an ABI and you are stuck with it. Unless, you >>> can justify why that doesn't matter. (IIRC, this is new, so maybe no >>> users yet?) >> >> This was added and support queued in v6.8. This change won't make it to >> v6.8 (given it has to go via two levels and is technically not a fix). > > I'd argue it is a fix. But given no users yet, delaying is fine. I agree it is a fix, but not something that maintainers would like to pull it during an rc cycle. As you said, since there are no real users for this yet (and given it is all under a single vendor), it may be fine to queue this if the DT maintainers are OK with this. > >> As James also pointed out, it doesn't matter what the name is (now that >> it has been published). > > v6.8 final is what we consider published. I can't send this to Greg as a fix. For v6.8. We can fix it for v6.9 cycle. Suzuki > > Rob

1 year, 4 months

Re: [PATCH v1 1/2] dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size

by Suzuki K Poulose

On 13/02/2024 22:29, Rob Herring wrote: > On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote: >> Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is >> bit. > > That may be, but this is an ABI and you are stuck with it. Unless, you > can justify why that doesn't matter. (IIRC, this is new, so maybe no > users yet?) This was added and support queued in v6.8. This change won't make it to v6.8 (given it has to go via two levels and is technically not a fix). As James also pointed out, it doesn't matter what the name is (now that it has been published). Suzuki

1 year, 4 months

Re: [PATCH v1 1/2] dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size

by Jinlong Mao

On 2/14/2024 6:29 AM, Rob Herring wrote: > On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote: >> Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is >> bit. > That may be, but this is an ABI and you are stuck with it. Unless, you > can justify why that doesn't matter. (IIRC, this is new, so maybe no > users yet?) Hi Rob, Because for CMB type, it uses qcom,cmb-element-bits. So I change the format to be the same as CMB. Thanks Jinlong Mao

1 year, 4 months

[PATCH v1 0/2] coresight: tpdm: Change qcom,dsb-element-size to qcom,dsb-elem-bits

by Mao Jinlong

As unit of dsb element size is bit, change qcom,dsb-element-size to qcom,dsb-elem-bits. Mao Jinlong (2): dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size coresight-tpda: Change qcom,dsb-element-size to qcom,dsb-elem-bits .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 4 ++-- drivers/hwtracing/coresight/coresight-tpda.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.41.0

1 year, 4 months

Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB

by Suzuki K Poulose

On 13/02/2024 10:45, Arnd Bergmann wrote: > On Tue, Feb 13, 2024, at 11:22, Suzuki K Poulose wrote: > >> coresight: tpdm: Fix build break due to uninitialised field >> >> {CMB/DSB}_PATT_ENABLE_TS attributes do not use an index field. >> But some compilers complain for uninitialised "index" field in >> the struct tpdm_dataset_attribute: >> > ... >> >> Reported-by: Arnd Bergmann <arnd(a)arndb.de> >> Cc: Tao Zhang <quic_taozha(a)quicinc.com> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose(a)arm.com> > > Works fine here with this, thanks for the fix! > > Acked-by: Arnd Bergmann <arnd(a)arndb.de> > > I had actually missed that this is a warning option that > is normally disabled even at W=1 level, but it does get > added by drivers/hwtracing/coresight/Makefile setting > -Wextra again because that comes after the > -Wno-missing-field-initializers from scripts/Makefile.extrawarn. > > Arnd Thanks for verifying, I have queued this. https://git.kernel.org/coresight/c/c099fdd218a0 Suzuki

1 year, 4 months

Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB

by Suzuki K Poulose

1 year, 4 months

Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB

by Suzuki K Poulose

n 13/02/2024 09:50, Arnd Bergmann wrote: > On Sun, Feb 4, 2024, at 06:30, Tao Zhang wrote: > >> @@ -910,7 +1014,7 @@ static struct attribute *tpdm_dsb_patt_attrs[] = { >> DSB_PATT_MASK_ATTR(5), >> DSB_PATT_MASK_ATTR(6), >> DSB_PATT_MASK_ATTR(7), >> - &dev_attr_enable_ts.attr, >> + DSB_PATT_ENABLE_TS, >> &dev_attr_set_type.attr, >> NULL, >> }; >> @@ -964,6 +1068,7 @@ static struct attribute *tpdm_cmb_patt_attrs[] = { >> CMB_PATT_ATTR(1), >> CMB_PATT_MASK_ATTR(0), >> CMB_PATT_MASK_ATTR(1), >> + CMB_PATT_ENABLE_TS, >> NULL, >> }; >> >> @@ -158,6 +175,10 @@ >> tpdm_simple_dataset_rw(tpmr##nr, \ >> DSB_PATT_MASK, nr) >> >> +#define DSB_PATT_ENABLE_TS \ >> + tpdm_patt_enable_ts(enable_ts, \ >> + DSB_PATT) >> + >> #define DSB_MSR_ATTR(nr) \ >> tpdm_simple_dataset_rw(msr##nr, \ >> DSB_MSR, nr) > > This is causing build failures in linux-next now: > > drivers/hwtracing/coresight/coresight-tpdm.c:1055:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers] > 1055 | DSB_PATT_ENABLE_TS, > | ^ > drivers/hwtracing/coresight/coresight-tpdm.h:184:3: note: expanded from macro 'DSB_PATT_ENABLE_TS' > 184 | tpdm_patt_enable_ts(enable_ts, \ > | ^ > drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts' > 156 | } \ > | ^ > drivers/hwtracing/coresight/coresight-tpdm.c:1109:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers] > 1109 | CMB_PATT_ENABLE_TS, > | ^ > drivers/hwtracing/coresight/coresight-tpdm.h:208:3: note: expanded from macro 'CMB_PATT_ENABLE_TS' > 208 | tpdm_patt_enable_ts(enable_ts, \ > | ^ > drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts' > 156 | } \ > | ^ > > Not sure what is going on, so I reverted your patch locally > for my test setup. > Can you send a fix to make it build again? The idx field is not used for the {DSB,CMB}_PATT_ENABLE_TS attributes and as such the macros do not set it. May be something like this fixes the problem ? But any uninitiliased fields must be set to 0 implicitly ? --->8--- coresight: tpdm: Fix build break due to uninitialised field {CMB/DSB}_PATT_ENABLE_TS attributes do not use an index field. But some compilers complain for uninitialised "index" field in the struct tpdm_dataset_attribute: drivers/hwtracing/coresight/coresight-tpdm.c:1055:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers] 1055 | DSB_PATT_ENABLE_TS, | ^ drivers/hwtracing/coresight/coresight-tpdm.h:184:3: note: expanded from macro 'DSB_PATT_ENABLE_TS' 184 | tpdm_patt_enable_ts(enable_ts, \ | ^ drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts' 156 | } \ | ^ drivers/hwtracing/coresight/coresight-tpdm.c:1109:2: error: missing field 'idx' initializer [-Werror,-Wmissing-field-initializers] 1109 | CMB_PATT_ENABLE_TS, | ^ drivers/hwtracing/coresight/coresight-tpdm.h:208:3: note: expanded from macro 'CMB_PATT_ENABLE_TS' 208 | tpdm_patt_enable_ts(enable_ts, \ | ^ drivers/hwtracing/coresight/coresight-tpdm.h:156:5: note: expanded from macro 'tpdm_patt_enable_ts' 156 | } \ | ^ Reported-by: Arnd Bergmann <arnd(a)arndb.de> Cc: Tao Zhang <quic_taozha(a)quicinc.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose(a)arm.com> --- drivers/hwtracing/coresight/coresight-tpdm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.h b/drivers/hwtracing/coresight/coresight-tpdm.h index f3a8f56d0fe7..e08d212642e3 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.h +++ b/drivers/hwtracing/coresight/coresight-tpdm.h @@ -153,6 +153,7 @@ __ATTR(name, 0644, enable_ts_show, \ enable_ts_store), \ mem, \ + 0, \ } \ })[0].attr.attr) -- 2.34.1

1 year, 4 months

Re: [PATCH] coresight: make coresight_bustype const

by Suzuki K Poulose

On Fri, 5 Jan 2024 13:33:32 +0100, Greg Kroah-Hartman wrote: > Now that the driver core can properly handle constant struct bus_type, > move the coresight_bustype variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Moved to next, thanks! [1/1] coresight: make coresight_bustype const https://git.kernel.org/coresight/c/dd95255d44c0 Best regards, -- Suzuki K Poulose <suzuki.poulose(a)arm.com>

1 year, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight