Hi
On Tue, 22 Jul 2025 at 10:14, Leo Yan leo.yan@arm.com wrote:
On Tue, Jul 22, 2025 at 09:49:28AM +0100, Suzuki Kuruppassery Poulose wrote:
On 22/07/2025 09:14, Mao Jinlong wrote:
From: Yingchao Deng quic_yingdeng@quicinc.com
Add Qualcomm extended CTI support in CTI binding file. Qualcomm extended CTI supports up to 128 triggers.
Signed-off-by: Yingchao Deng quic_yingdeng@quicinc.com Signed-off-by: Mao Jinlong quic_jinlmao@quicinc.com
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index 2d5545a2b49c..1aa27461f5bc 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -84,7 +84,9 @@ properties: - const: arm,coresight-cti - const: arm,primecell - items:
- const: arm,coresight-cti-v8-arch
- enum:- arm,coresight-cti-v8-arch- qcom,coresight-cti-extendedWhy not call it qcom,coresight-cti ?
There are no other "qcom,coresight-cti", so "extended" is not required. Is this specific to CPU (i.e., CPU bound) ?
I roughly went through the second path. Combining two patches in this series, I am wandering if can directly check registers (e.g. PID/CID) to find CTI with qcom extension. If so, you do not need an extra DT binding, right?
Thanks, Leo
Suzuki
- const: arm,coresight-cti - const: arm,primecell
CoreSight mailing list -- coresight@lists.linaro.org To unsubscribe send an email to coresight-leave@lists.linaro.org
For a change of this magnitude to a CS component, that the ID registers will also have to change. This is a requirement of the Visible Component Architecture in the CoreSight specification. External tools cannot see the device tree.
This is effectively no longer an ARM designed component, so the CoreSight specification requires that the DEVARCH register change to show qualcomm as the designer, and the architecture value change to represent this component. DEVID should be used to allow the driver to pick up parameters such as number of triggers as per the existing CTI component.
If this component is Coresight compliant then the driver can use the ID registers to configure to the extended trigger architecture.
With complete remapping of most of the registers, and the dropping of claim tag compatibility - which appears to be a breach of the CoreSight specification - it may be better to have a completely separate driver for this component.
Regards
Mike
-- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK