On 11 June 2018 at 19:02, Leo Yan leo.yan@linaro.org wrote:
On Mon, Jun 11, 2018 at 11:13:48AM -0600, Mathieu Poirier wrote:
On 10 June 2018 at 02:28, Leo Yan leo.yan@linaro.org wrote:
Hi Mathieu,
On Sun, Jun 10, 2018 at 04:19:05PM +0800, Leo Yan wrote:
CS_ETM_TRACE_ON packet itself can give the info that there have a discontinuity in the trace, this patch is to add branch sample for CS_ETM_TRACE_ON packet if it is inserted in the middle of CS_ETM_RANGE packets; as result we can have hint for the trace discontinuity.
I followed your suggestion to prepare the cs-etm fixing patch series (if I didn't miss anything), but I am struggling to add this patch into the fixing patch series or not, though I understand I should keep the patch series as simple as possible for easier reviewing and merging.
Seems to me, the patch 5/6 'perf cs-etm: Generate branch sample when receiving a CS_ETM_TRACE_ON packet' has inserted partial info of CS_ETM_TRACE_ON for samples, e.g. the CS_ETM_TRACE_ON packet::addr has been used to generate branch sample, if without this patch we will miss the branch sample for CS_ETM_TRACE_ON::ip. So I decided to add this patch into fixing series. So my main reason for adding patch 6/6 is to make the fixing to be more complete.
Please let me know if you agree with this? Or have other suggestion. Thanks in advance.
Good day Leo,
Aside from the comment in 1/6 I think the compartmentalisation of this series is just fine as it is. I am personally fine with it and think it is ready for action on the public mailing list again. As I said earlier, you will need to wait for the merge window to close.
Thanks for reviewing, Mathieu. Will fix 1/6 with suggestion.
In the mean time, Mike and Rob - please review this set and see if anything is missing.
Yeah, It's good to get green light or suggestions from Mike and Rob before I send patch series to public mailing list.
BTW, from LWN article [1] I get to know the 4.18 merge window seems to be delayed; I will check with you offline for when will be good time to send to LKML.
The merge window hasn't been delayed. It opens on the day the official kernel release happens and lasts for two weeks. In this case 4.17 was released on the 3rd of June, which means the merge window will close on the 16th and a new 4.18-rc1 released on the 17th. You can send you patches as soon as you have a 4.18-rc1 to base your work on.
[1] https://lwn.net/Articles/756898/
Thanks, Leo Yan