Why include the ARM in there? The usual convention is a single string, not multiple words - I'd have expected libopencsd.so and libcstraced.so (why are they separate libraries BTW).
ARM - architecture - as per Intel PT being lib ipt. Not crucial I guess but descriptive. As for the single word convention - see the boost C++ libs! - though in our case multiple words does separate the C-API from the main lib. i.e. libarm_cstraced.so is the C++ lib, libarm_cstrace_c_api.so is the C API wrapper. The windows equivalents would be arm_cstraced.dll and arm_cstrace_c_api.dll, with the static versions libarm_cstraced.lib and libarm_cstraced_c_api.lib. Windows uses arm_cstraced.lib as the link stub for arm_cstraced.dll, so the actual static lib has to have a different name. Again a convention borrowed from the boost libs.
Separate libs as the C API is an optional wrapper on top of the main C++ library. C++ application developers can just use the main lib and get additional flexibility of direct manipulation of the C++ decoder objects should they want that. The C API currently consists of the interface to the DecodeTree object plus a few additions.
coccinelle might be able to help?
Lots of google entries for a hat shop for this! - once I got past that then I spotted what you meant - it is possible I guess - but learning a new tool might take longer than refactoring in a tool I already know. There are actual file names, corresponding #include lines, macro names, variable names, enum prefix names, doxygen comments etc to change, so it is beyond just a few variables and functions to be tweaked.
Regards
Mike
---------------------------------------------------------------- Mike Leach +44 (0)1254 893911 (Direct) Principal Engineer +44 (0)1254 893900 (Main) Arm Blackburn Design Centre +44 (0)1254 893901 (Fax) Belthorn House Walker Rd mailto:mike.leach@arm.com Guide Blackburn BB1 2QE ----------------------------------------------------------------
-----Original Message----- From: Mark Brown [mailto:broonie@linaro.org] Sent: 03 December 2015 19:16 To: Mike Leach Cc: coresight@lists.linaro.org Subject: Re: Library names.
On 3 December 2015 at 15:49, Mike Leach Mike.Leach@arm.com wrote:
My thoughts were either libarm_opencsd.so / libarm_opencsd_c_api.so or libarm_cstraced.so / libarm_cstraced_c_api.so
Both of which specify the architecture and function a little better than the old names.
Opinions??
Why include the ARM in there? The usual convention is a single string, not multiple words - I'd have expected libopencsd.so and libcstraced.so (why are they separate libraries BTW).
(RCTDL appears across much of the source code too, but changing that is a massive job, so I'm not considering that at present).
coccinelle might be able to help?
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.