Hi Arnaldo,
On Fri, Mar 05, 2021 at 02:29:44PM -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu:
On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote:
On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote:
From: Suzuki K Poulose suzuki.poulose@arm.com
When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly takes these two values (14 and 28 prespectively) as bit masks, but actually both are the offset for bits. But this doesn't lead to further failure due to the AND logic operation will be always true for ETM_OPT_CTXTID / ETM_OPT_TS.
This patch defines new independent macros (rather than using the "config" bits) for requesting the "contextid" and "timestamp" for cs_etm_set_option().
[leoy: Extract the change as a separate patch for easier review]
This should go just above your name - see below.
I fixed this up and added this patch to my perf/urgent branch, for v5.12, since the kernel bits are upstream and this is a fix.
Yeah, it makes sense to pick this patch into perf/urgent branch since it's a fixing patch.
Actually, this patch has been merged into the tmp.perf/core branch [1], after you move it to the perf/urgent branch, I can confirm all other patches for perf tool in this series have been merged into the tmp.perf/core branch.
Thanks, Leo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp...