On Thu, 19 Oct 2017 09:58:12 +0100 Mike Leach mike.leach@linaro.org wrote:
decoder/build/linux/ref_trace_decode_lib/makefile | 3 +- .../ref_trace_decode_lib.vcxproj | 3 +- .../ref_trace_decode_lib.vcxproj.filters | 9 +- decoder/include/etmv4/trc_etmv4_stack_elem.h | 338 +++++++++++++++++++++
...
decoder/include/etmv4/trc_pkt_decode_etmv4i.h | 7 +- decoder/source/etmv4/trc_etmv4_stack_elem.cpp | 110 +++++++ decoder/source/etmv4/trc_etmv4_stack_elem.h | 227 --------------
Not that I'm really reviewing the content here, but I noticed this patch moves trc_etmv4_stack_elem.h from source/ to include/, and the email shows the entire contents of the file to be removed, and the entire contents being re-added in the new location, which makes review very difficult.
This problem used to be fixed by specifying the --find-renames flag in git format-patch manually, but they changed it and it is now the default behaviour. Please consider upgrading your git package from:
2.7.4
to something more modern. Version 2.11 produces this rename-aware diff by default:
decoder/build/linux/ref_trace_decode_lib/makefile | 3 +- .../ref_trace_decode_lib.vcxproj | 3 +- .../ref_trace_decode_lib.vcxproj.filters | 9 +- .../etmv4/trc_etmv4_stack_elem.h | 123 +++++++++++++++++- decoder/include/etmv4/trc_pkt_decode_etmv4i.h | 7 +- decoder/source/etmv4/trc_etmv4_stack_elem.cpp | 110 ++++++++++++++++ decoder/source/etmv4/trc_pkt_decode_etmv4i.cpp | 144 ++++++--------------- 7 files changed, 282 insertions(+), 117 deletions(-) rename decoder/{source => include}/etmv4/trc_etmv4_stack_elem.h (69%) create mode 100644 decoder/source/etmv4/trc_etmv4_stack_elem.cpp
Thanks,
Kim