Hi Leo,
Hi Tanmay,
On Thu, Aug 26, 2021 at 07:03:22AM +0000, Tanmay Jagdale wrote:
[...]
I would suggest, if we're adding a DT property that the TMC driver would look at in all cases, we should go with "arm,max-burst-size" as Leo suggested. I.e. as TMC driver functionality, the ability to override the burst size using a DT property wouldn't be SoC-specific or vendor-specific in any way - even though the motivation for introducing it is to work with a specific SoC and we expect it to only be needed on specific SoCs.
Then, if any other vendor's SoC needs to do the same thing, or even if someone wants to play with burst size as a performance tweak, they can use the same DT property.
Okay sure, I will send a patch for these changes using "arm,max-burst-
size"
DT binding.
The kernel has particular requirement for upstreaming DT patches, it's good to split into several patches:
- the dt-binding patch;
- the driver patch (the driver patch should also validate the value 'max-burst-size' passed from DT binding);
- you also might want to use an extra patch for updating dts/dtsi to use the new property for Marvell specific platform.
Please refer the kernel document [1] for the details.
Thanks for the guidelines. I'll submit the patches accordingly.
Thanks and Regards, Tanmay
Thanks, Leo
[1] Documentation/devicetree/bindings/submitting-patches.rst