Hi
On 2021-03-02 04:13, Doug Anderson wrote:
Hi,
On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org wrote:
Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel config which excludes kernel mode instruction tracing to help perf tool users identify the perf event open failure when they attempt kernel mode tracing with this config enabled.
Tested-by: Denis Nikitin denik@chromium.org Signed-off-by: Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org
tools/perf/util/evsel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
I'm not really knowledgeable at all about the perf subsystem so my review doesn't hold a lot of weight. However, Sai's patch seems sane to me.
Reviewed-by: Douglas Anderson dianders@chromium.org
Thanks for the review, I carefully modified all the patch commit messages to change the config and wording from CONFIG_EXCLUDE_KERNEL_HW_ITRACE to CONFIG_EXCLUDE_KERNEL_PMU_TRACE but missed this commit message. I will fix this up in v3, but will hold off posting v3 till I get some feedback on other patches.
Thanks, Sai