greybus-dev

greybus-dev@lists.linaro.org

6 participants
602 discussions

Re: [PATCH] staging: greybus: Alignment should match open parenthesis

by Nandha Kumar Singaram

greybus-dev(a)lists.linaro.org, linux-staging(a)lists.linux.dev, linux-kernel(a)vger.kernel.org, kumaran.4353(a)gmail.com Bcc: Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To: In-Reply-To: <2023102131-slacker-lily-28ff@gregkh> On Sat, Oct 21, 2023 at 11:48:32AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2023 at 02:39:49PM -0700, Nandha Kumar Singaram wrote: > > Adhere to linux coding style. Reported by checkpatch.pl: > > CHECK: Alignment should match open parenthesis > > > > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> > > --- > > drivers/staging/greybus/camera.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > index cdbb42cd413b..405c8e78aa72 100644 > > --- a/drivers/staging/greybus/camera.c > > +++ b/drivers/staging/greybus/camera.c > > @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, > > } > > > > static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, > > - struct gb_camera_configure_streams_response *resp) > > + struct gb_camera_configure_streams_response *resp) > > { > > unsigned int max_pkt_size = 0; > > unsigned int i; > > @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, > > * Validate the stream configuration response verifying padding is correctly > > * set and the returned number of streams is supported > > */ > > -static const int gb_camera_configure_streams_validate_response( > > - struct gb_camera *gcam, > > +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam, > > Why change this line? > did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl > It's fine, but then: > > > struct gb_camera_configure_streams_response *resp, > > unsigned int nstreams) > > These lines are not fixed up? > > thanks, > > greg k-h Fixing these lines results in another checkpatch check(CHECK: line length of 113 exceeds 100 columns) so didn't added any change Thanks, Nandha Kumar

2 years

[PATCH] staging: greybus: Alignment should match open parenthesis

by Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> --- drivers/staging/greybus/camera.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index cdbb42cd413b..405c8e78aa72 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, } static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, - struct gb_camera_configure_streams_response *resp) + struct gb_camera_configure_streams_response *resp) { unsigned int max_pkt_size = 0; unsigned int i; @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, * Validate the stream configuration response verifying padding is correctly * set and the returned number of streams is supported */ -static const int gb_camera_configure_streams_validate_response( - struct gb_camera *gcam, +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam, struct gb_camera_configure_streams_response *resp, unsigned int nstreams) { @@ -378,8 +377,8 @@ struct ap_csi_config_request { #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U static int gb_camera_setup_data_connection(struct gb_camera *gcam, - struct gb_camera_configure_streams_response *resp, - struct gb_camera_csi_params *csi_params) + struct gb_camera_configure_streams_response *resp, + struct gb_camera_csi_params *csi_params) { struct ap_csi_config_request csi_cfg; struct gb_connection *conn; @@ -783,8 +782,9 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) } static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams, - unsigned int *flags, struct gb_camera_stream *streams, - struct gb_camera_csi_params *csi_params) + unsigned int *flags, + struct gb_camera_stream *streams, + struct gb_camera_csi_params *csi_params) { struct gb_camera *gcam = priv; struct gb_camera_stream_config *gb_streams; -- 2.25.1

2 years

Re: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

by Greg KH

On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote: > This patch fixes the checks reported by checkpatch.pl > for alignment should match open parenthesis No it does not, sorry. Also, any reaason you did not also cc: the proper maintainers as scripts/get_maintainer.pl told you to? thanks, greg k-h

2 years

Re: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

by Dan Carpenter

On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote: > This patch fixes the checks reported by checkpatch.pl > for alignment should match open parenthesis > > Signed-off-by: Chen Shuo <1289151713(a)qq.com> > --- > drivers/staging/greybus/camera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > index cdbb42cd413b..ed9e16bab4cc 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -378,7 +378,7 @@ struct ap_csi_config_request { > #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U > > static int gb_camera_setup_data_connection(struct gb_camera *gcam, > - struct gb_camera_configure_streams_response *resp, > + struct gb_camera_configure_streams_response *resp, > struct gb_camera_csi_params *csi_params) > { Just leave it as-is. The original was fine. I know that these days we can go over the 80 character mark but, really, does this make things easier to read? regards, dan carpenter

2 years

[PATCH] staging: greybus: Modify lines end with a '('

by Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Lines should not end with a '(' Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> --- drivers/staging/greybus/audio_manager_private.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h index 2b3a766c7de7..daca5b48b986 100644 --- a/drivers/staging/greybus/audio_manager_private.h +++ b/drivers/staging/greybus/audio_manager_private.h @@ -12,10 +12,9 @@ #include "audio_manager.h" -int gb_audio_manager_module_create( - struct gb_audio_manager_module **module, - struct kset *manager_kset, - int id, struct gb_audio_manager_module_descriptor *desc); +int gb_audio_manager_module_create(struct gb_audio_manager_module **module, + struct kset *manager_kset, int id, + struct gb_audio_manager_module_descriptor *desc); /* module destroyed via kobject_put */ -- 2.25.1

2 years

Re: [PATCH] [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

by Greg KH

On Thu, Oct 12, 2023 at 08:50:21PM +0800, Chen Shuo wrote: > This patch fixes the checks reported by checkpatch.pl > for alignment should match open parenthesis No it doesn't :( Also, please always use scripts/checkpatch.pl to get the proper mailing lists to send patches to. thanks, greg k-h

2 years

[PATCH v8 0/3] greybus: Add BeaglePlay Greybus Driver

by Ayush Singh

BeagleConnect is both a technology concept and a line of board designs that implement the technology. Born from Greybus, a mechanism for dynamically extending a Linux system with embedded peripherals, BeagleConnect adds two key elements: a 6LoWPAN transport and mikroBUS manifests. The 6LoWPAN transport provides for arbitrary connections, including the IEEE802.15.4g long-range wireless transport supported between BeaglePlay and BeagleConnect Freedom (the first BeagleConnect board design). The mikroBUS manifests provide for rapid prototyping and low-node-count production with sensor boards following the mikroBUS freely-licensable embedded bus standard such that existing Linux drivers can be loaded upon Greybus discovery of the nodes. This patch set provides the Linux-side hooks required for the 6LoWPAN transport for BeagleConnect on BeaglePlay. Also adds required devicetree additions. Tested over `next-20230825`. Link: https://programmershideaway.xyz/tags/gsoc23/ GSoC23 Blog Link: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware Zephyr App Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay GitHub Branch Link: https://docs.beagleboard.org/latest/boards/beagleconnect/index.html BeagleConnect Link: https://docs.beagleboard.org/latest/boards/beagleplay/index.html BeaglePlay Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay Github Repo Link: https://lists.linaro.org/archives/list/greybus-dev@lists.linaro.org/thread/… Patch v7 Changes in Patch v8 v7 -> v8: - fix clocks - fix reset-gpios - depend on serdev v6 -> v7: - Drop speed variable - Fix commit message - add clock-names and descriptions - fix power lines v5 -> v6: - Rename compatible to `ti,cc1352p7` - Fix formatting - Use kerneldoc - Add clocks, power-gpios, reset-gpios to dt bindings v4 -> v5: - Move DT Bindings to net - Rename compatible to `beagle,play-cc1352` - Expose CC1352 as MCU - Remove redundant tracing messages - Fix memory leaks v3 -> v4: - Add DT Bindings - Reorder commits - Improve commit messages v2 -> v3: - Move gb-beagleplay out of staging v1 -> v2: - Combine the driver into a single file - Remove redundant code - Fix Checkpatch complaints - Other suggested changes Ayush Singh (3): dt-bindings: net: Add ti,cc1352p7 greybus: Add BeaglePlay Linux Driver dts: ti: k3-am625-beagleplay: Add beaglecc1352 .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 ++ MAINTAINERS | 7 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 + drivers/greybus/Kconfig | 10 + drivers/greybus/Makefile | 2 + drivers/greybus/gb-beagleplay.c | 501 ++++++++++++++++++ 6 files changed, 575 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml create mode 100644 drivers/greybus/gb-beagleplay.c base-commit: 6269320850097903b30be8f07a5c61d9f7592393 -- 2.41.0

2 years

[PATCH][next] staging: greybus: Add __counted_by for struct apr_rx_buf and use struct_size()

by Gustavo A. R. Silva

Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). While there, use struct_size() helper, instead of the open-coded version, to calculate the size for the allocation of the whole flexible structure, including of course, the flexible-array member. This code was found with the help of Coccinelle, and audited and fixed manually. Signed-off-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> --- drivers/staging/greybus/raw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c index a00978c8e1d2..b9c6eff7cdc1 100644 --- a/drivers/staging/greybus/raw.c +++ b/drivers/staging/greybus/raw.c @@ -29,7 +29,7 @@ struct gb_raw { struct raw_data { struct list_head entry; u32 len; - u8 data[]; + u8 data[] __counted_by(len); }; static const struct class raw_class = { @@ -73,7 +73,7 @@ static int receive_data(struct gb_raw *raw, u32 len, u8 *data) goto exit; } - raw_data = kmalloc(sizeof(*raw_data) + len, GFP_KERNEL); + raw_data = kmalloc(struct_size(raw_data, data, len), GFP_KERNEL); if (!raw_data) { retval = -ENOMEM; goto exit; -- 2.34.1

2 years

[PATCH 1/3] staging: greybus: raw: make raw_class constant

by Greg Kroah-Hartman

Now that the driver core allows for struct class to be in read-only memory, making all 'class' structures to be declared at build time placing them into read-only memory, instead of having to be dynamically allocated at load time. Cc: Johan Hovold <johan(a)kernel.org> Cc: Alex Elder <elder(a)kernel.org> Cc: greybus-dev(a)lists.linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/staging/greybus/raw.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c index 8bca8cb12cc6..a00978c8e1d2 100644 --- a/drivers/staging/greybus/raw.c +++ b/drivers/staging/greybus/raw.c @@ -32,7 +32,10 @@ struct raw_data { u8 data[]; }; -static struct class *raw_class; +static const struct class raw_class = { + .name = "gb_raw", +}; + static int raw_major; static const struct file_operations raw_fops; static DEFINE_IDA(minors); @@ -195,7 +198,7 @@ static int gb_raw_probe(struct gb_bundle *bundle, if (retval) goto error_connection_disable; - raw->device = device_create(raw_class, &connection->bundle->dev, + raw->device = device_create(&raw_class, &connection->bundle->dev, raw->dev, raw, "gb!raw%d", minor); if (IS_ERR(raw->device)) { retval = PTR_ERR(raw->device); @@ -229,7 +232,7 @@ static void gb_raw_disconnect(struct gb_bundle *bundle) struct raw_data *temp; // FIXME - handle removing a connection when the char device node is open. - device_destroy(raw_class, raw->dev); + device_destroy(&raw_class, raw->dev); cdev_del(&raw->cdev); gb_connection_disable(connection); ida_simple_remove(&minors, MINOR(raw->dev)); @@ -340,11 +343,9 @@ static int raw_init(void) dev_t dev; int retval; - raw_class = class_create("gb_raw"); - if (IS_ERR(raw_class)) { - retval = PTR_ERR(raw_class); + retval = class_register(&raw_class); + if (retval) goto error_class; - } retval = alloc_chrdev_region(&dev, 0, NUM_MINORS, "gb_raw"); if (retval < 0) @@ -361,7 +362,7 @@ static int raw_init(void) error_gb: unregister_chrdev_region(dev, NUM_MINORS); error_chrdev: - class_destroy(raw_class); + class_unregister(&raw_class); error_class: return retval; } @@ -371,7 +372,7 @@ static void __exit raw_exit(void) { greybus_deregister(&gb_raw_driver); unregister_chrdev_region(MKDEV(raw_major, 0), NUM_MINORS); - class_destroy(raw_class); + class_unregister(&raw_class); ida_destroy(&minors); } module_exit(raw_exit); -- 2.42.0

2 years, 1 month

[PATCH v7 0/3] greybus: Add BeaglePlay Greybus Driver

by Ayush Singh

BeagleConnect is both a technology concept and a line of board designs that implement the technology. Born from Greybus, a mechanism for dynamically extending a Linux system with embedded peripherals, BeagleConnect adds two key elements: a 6LoWPAN transport and mikroBUS manifests. The 6LoWPAN transport provides for arbitrary connections, including the IEEE802.15.4g long-range wireless transport supported between BeaglePlay and BeagleConnect Freedom (the first BeagleConnect board design). The mikroBUS manifests provide for rapid prototyping and low-node-count production with sensor boards following the mikroBUS freely-licensable embedded bus standard such that existing Linux drivers can be loaded upon Greybus discovery of the nodes. This patch set provides the Linux-side hooks required for the 6LoWPAN transport for BeagleConnect on BeaglePlay. Also adds required devicetree additions. Tested over `next-20230825`. Link: https://programmershideaway.xyz/tags/gsoc23/ GSoC23 Blog Link: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware Zephyr App Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay GitHub Branch Link: https://docs.beagleboard.org/latest/boards/beagleconnect/index.html BeagleConnect Link: https://docs.beagleboard.org/latest/boards/beagleplay/index.html BeaglePlay Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay Github Repo Link: https://lists.linaro.org/archives/list/greybus-dev@lists.linaro.org/thread/… Patch v6 Changes in Patch v7 v6 -> v7: - Drop speed variable - Fix commit message - add clock-names and descriptions - fix power lines v5 -> v6: - Rename compatible to `ti,cc1352p7` - Fix formatting - Use kerneldoc - Add clocks, power-gpios, reset-gpios to dt bindings v4 -> v5: - Move DT Bindings to net - Rename compatible to `beagle,play-cc1352` - Expose CC1352 as MCU - Remove redundant tracing messages - Fix memory leaks v3 -> v4: - Add DT Bindings - Reorder commits - Improve commit messages v2 -> v3: - Move gb-beagleplay out of staging v1 -> v2: - Combine the driver into a single file - Remove redundant code - Fix Checkpatch complaints - Other suggested changes Ayush Singh (3): dt-bindings: net: Add ti,cc1352p7 greybus: Add BeaglePlay Linux Driver dts: ti: k3-am625-beagleplay: Add beaglecc1352 .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 ++ MAINTAINERS | 7 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 + drivers/greybus/Kconfig | 10 + drivers/greybus/Makefile | 2 + drivers/greybus/gb-beagleplay.c | 501 ++++++++++++++++++ 6 files changed, 575 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml create mode 100644 drivers/greybus/gb-beagleplay.c base-commit: 6269320850097903b30be8f07a5c61d9f7592393 -- 2.41.0

2 years, 1 month

← Newer
1
...
12
13
14
15
16
17
18
...
61
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev