greybus-dev

greybus-dev@lists.linaro.org

17 participants
824 discussions

[PATCH 0/2] staging: greybus: arche-platform: minor cleanups

by Holden Hsu

Holden Hsu (2): staging: greybus: arche-platform: clarify TODO comment staging: greybus: arche-platform: fix spelling mistake in comment drivers/staging/greybus/arche-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0

6 months, 3 weeks

[PATCH 0/2] staging: greybus: arche-platform: minor fixes

by Hsu Holden

This patch series contains two minor cleanups for the arche-platform driver: Patch 1: Clarifies an unclear TODO comment to make the intent more obvious to future developers. Patch 2: Fixes a simple spelling mistake in a comment. These are low-risk changes that improve code readability. Get Outlook for Android<https://aka.ms/AAb9ysg>

6 months, 3 weeks

[PATCH 0/2] staging: greybus: arche-platform: minor fixes

by Hsu Holden

6 months, 3 weeks

[PATCH] staging: greybus: split gb_audio_gb_get_topology() into helper functions

by Khaled Saleh

From: khaled <khaled.saleh.req(a)gmail.com> The gb_audio_gb_get_topology() function performs multiple distinct operations: retrieving the topology size, allocating the topology buffer, and fetching the topology data. A TODO comment in the file notes that this logic should be split into separate calls. Introduce helper functions for each step and update gb_audio_gb_get_topology() to use them. This improves readability and maintainability without changing behavior. Signed-off-by: Khaled Saleh <khaled.saleh.req(a)gmail.com> --- drivers/staging/greybus/audio_gb.c | 47 +++++++++++++++++++++++------- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/staging/greybus/audio_gb.c b/drivers/staging/greybus/audio_gb.c index 9d8994fdb41a..0d5109ec14f6 100644 --- a/drivers/staging/greybus/audio_gb.c +++ b/drivers/staging/greybus/audio_gb.c @@ -9,36 +9,61 @@ #include "audio_codec.h" /* TODO: Split into separate calls */ +static int gb_audio_topology_get_size(struct gb_connection *connection, u16 *size) +{ + struct gb_audio_get_topology_size_response resp; + int ret; + + ret = gb_operation_sync(connection, + GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, + NULL, 0, + &resp, sizeof(resp)); + if (ret) + return ret; + + *size = le16_to_cpu(resp.size); + + return 0; +} + +static struct gb_audio_topology *gb_audio_topology_alloc(u16 size) +{ + if (size < sizeof(struct gb_audio_topology)) + return NULL; + + return kzalloc(size, GFP_KERNEL); +} + +static int gb_audio_topology_fetch(struct gb_connection *connection, + struct gb_audio_topology *topo, u16 size) +{ + return gb_operation_sync(connection, + GB_AUDIO_TYPE_GET_TOPOLOGY, + NULL, 0, + topo, size); +} int gb_audio_gb_get_topology(struct gb_connection *connection, struct gb_audio_topology **topology) { - struct gb_audio_get_topology_size_response size_resp; struct gb_audio_topology *topo; u16 size; int ret; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, - NULL, 0, &size_resp, sizeof(size_resp)); + ret = gb_audio_topology_get_size(connection, &size); if (ret) return ret; - size = le16_to_cpu(size_resp.size); - if (size < sizeof(*topo)) - return -ENODATA; - - topo = kzalloc(size, GFP_KERNEL); + topo = gb_audio_topology_alloc(size); if (!topo) return -ENOMEM; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, NULL, 0, - topo, size); + ret = gb_audio_topology_fetch(connection, topo, size); if (ret) { kfree(topo); return ret; } *topology = topo; - return 0; } EXPORT_SYMBOL_GPL(gb_audio_gb_get_topology); -- 2.43.0

6 months, 3 weeks

[PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

by Gideon Adjei

use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument in arche_platform_set_wake_detect_state. This keeps lines under 80 columns and satisfies kernel style guidelines. Signed-off-by: Gideon Adjei <gideonadjei.dev(a)gmail.com> --- drivers/staging/greybus/arche-platform.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 8aaff4e45660..bb9b3c3c7a2d 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) { struct arche_platform_drvdata *arche_pdata = devid; unsigned long flags; + int state; spin_lock_irqsave(&arche_pdata->wake_lock, flags); @@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) */ if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { - arche_platform_set_wake_detect_state(arche_pdata, - WD_STATE_COLDBOOT_TRIG); + state = WD_STATE_COLDBOOT_TRIG; + arche_platform_set_wake_detect_state(arche_pdata, state); spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); return IRQ_WAKE_THREAD; -- 2.34.1

6 months, 3 weeks

Re: [PATCH v3] staging: greybus: audio: avoid snprintf truncation warnings

by david.laight.linux＠gmail.com

The content of this message was lost. It was probably cross-posted to multiple lists and previously handled on another list.

7 months

[PATCH 00/14] greybus: introduce CPC as transport layer

by Damien Riégel

Hi, This patchset brings support for Silicon Labs' Co-Processor Communication (CPC) protocol as transport layer for Greybus. This is introduced as a module that sits between Greybus and CPC Host Device Drivers implementations, like SDIO or SPI. This patchset includes SDIO as physical layer but the protocol is not final and might change, it's mostly there to showcase all the elements. +----------------------------------------------------+ | Greybus | +----------------------------------------------------+ /|\ | \|/ +----------------------------------------------------+ | CPC | +----------------------------------------------------+ /|\ /|\ /|\ | | | \|/ \|/ \|/ +----------+ +---------+ +-----------+ | SDIO | | SPI | | Others | +----------+ +---------+ +-----------+ CPC implements some of the features of Unipro that Greybus relies upon, like reliable transmission. CPC takes care of detecting transmission errors and retransmit frames if necessary, but that feature is not part of the RFC to keep it concise. There's also a flow-control feature, preventing sending messages to already full cports. In order to implement these features, a 4-byte header is prepended to Greybus messages, making the whole header 12 bytes (Greybus header itself is 8 bytes). This RFC starts by implementing a shim layer between physical bus drivers (like SDIO and SPI) and Greybus, and progressively add more elements to it to make it useful in its own right. Finally, an SDIO driver is added to enable the communication with a remote device. Changes since the RFC: - added missing Signed-off-by on one commit - added SDIO driver to give a full example Damien Riégel (13): greybus: cpc: add minimal CPC Host Device infrastructure greybus: cpc: introduce CPC cport structure greybus: cpc: use socket buffers instead of gb_message in TX path greybus: cpc: pack cport ID in Greybus header greybus: cpc: switch RX path to socket buffers greybus: cpc: introduce CPC header structure greybus: cpc: account for CPC header size in RX and TX path greybus: cpc: add and validate sequence numbers greybus: cpc: acknowledge all incoming messages greybus: cpc: use holding queue instead of sending out immediately greybus: cpc: honour remote's RX window greybus: cpc: let host device drivers dequeue TX frames greybus: cpc: add private data pointer in CPC Host Device Gabriel Beaulieu (1): greybus: cpc: add CPC SDIO host driver MAINTAINERS | 6 + drivers/greybus/Kconfig | 2 + drivers/greybus/Makefile | 2 + drivers/greybus/cpc/Kconfig | 22 ++ drivers/greybus/cpc/Makefile | 9 + drivers/greybus/cpc/cpc.h | 75 +++++ drivers/greybus/cpc/cport.c | 107 +++++++ drivers/greybus/cpc/header.c | 146 +++++++++ drivers/greybus/cpc/header.h | 55 ++++ drivers/greybus/cpc/host.c | 313 +++++++++++++++++++ drivers/greybus/cpc/host.h | 63 ++++ drivers/greybus/cpc/protocol.c | 167 ++++++++++ drivers/greybus/cpc/sdio.c | 554 +++++++++++++++++++++++++++++++++ 13 files changed, 1521 insertions(+) create mode 100644 drivers/greybus/cpc/Kconfig create mode 100644 drivers/greybus/cpc/Makefile create mode 100644 drivers/greybus/cpc/cpc.h create mode 100644 drivers/greybus/cpc/cport.c create mode 100644 drivers/greybus/cpc/header.c create mode 100644 drivers/greybus/cpc/header.h create mode 100644 drivers/greybus/cpc/host.c create mode 100644 drivers/greybus/cpc/host.h create mode 100644 drivers/greybus/cpc/protocol.c create mode 100644 drivers/greybus/cpc/sdio.c -- 2.49.0

7 months, 1 week

[PATCH] staging: greybus: split gb_audio_gb_get_topology() into helper functions

by Khaled Saleh

The gb_audio_gb_get_topology() function performs multiple distinct operations: retrieving the topology size, allocating the topology buffer, and fetching the topology data. A TODO comment in the file notes that this logic should be split into separate calls. Introduce helper functions for each step and update gb_audio_gb_get_topology() to use them. This improves readability and maintainability without changing behavior. Signed-off-by: Khaled Saleh <khaled.saleh.req(a)gmail.com> --- drivers/staging/greybus/audio_gb.c | 47 +++++++++++++++++++++++------- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/staging/greybus/audio_gb.c b/drivers/staging/greybus/audio_gb.c index 9d8994fdb41a..0d5109ec14f6 100644 --- a/drivers/staging/greybus/audio_gb.c +++ b/drivers/staging/greybus/audio_gb.c @@ -9,36 +9,61 @@ #include "audio_codec.h" /* TODO: Split into separate calls */ +static int gb_audio_topology_get_size(struct gb_connection *connection, u16 *size) +{ + struct gb_audio_get_topology_size_response resp; + int ret; + + ret = gb_operation_sync(connection, + GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, + NULL, 0, + &resp, sizeof(resp)); + if (ret) + return ret; + + *size = le16_to_cpu(resp.size); + + return 0; +} + +static struct gb_audio_topology *gb_audio_topology_alloc(u16 size) +{ + if (size < sizeof(struct gb_audio_topology)) + return NULL; + + return kzalloc(size, GFP_KERNEL); +} + +static int gb_audio_topology_fetch(struct gb_connection *connection, + struct gb_audio_topology *topo, u16 size) +{ + return gb_operation_sync(connection, + GB_AUDIO_TYPE_GET_TOPOLOGY, + NULL, 0, + topo, size); +} int gb_audio_gb_get_topology(struct gb_connection *connection, struct gb_audio_topology **topology) { - struct gb_audio_get_topology_size_response size_resp; struct gb_audio_topology *topo; u16 size; int ret; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, - NULL, 0, &size_resp, sizeof(size_resp)); + ret = gb_audio_topology_get_size(connection, &size); if (ret) return ret; - size = le16_to_cpu(size_resp.size); - if (size < sizeof(*topo)) - return -ENODATA; - - topo = kzalloc(size, GFP_KERNEL); + topo = gb_audio_topology_alloc(size); if (!topo) return -ENOMEM; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, NULL, 0, - topo, size); + ret = gb_audio_topology_fetch(connection, topo, size); if (ret) { kfree(topo); return ret; } *topology = topo; - return 0; } EXPORT_SYMBOL_GPL(gb_audio_gb_get_topology); -- 2.43.0

7 months, 1 week

[PATCH v2 1/1] staging: greybus: Remove completed PWM TODO item.

by Sammy Malik

The pwm.c driver already uses pwm_ops::apply. This item was completed in commit 832ce36f44a2 ("staging: greybus: introduce pwm_ops::apply") but never removed from the TODO list. Removed the outdated TODO item. Signed-off-by: Sammy Malik <sammy(a)parkour.is> --- Changes in v2: - Added commit reference 832ce36f44a2 that originally implemented pwm_ops::apply - Fixed typos: PWN -> PWM, pwn_ops -> pwm_ops drivers/staging/greybus/TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO index 6461e0132fe3..31f1f2cb401c 100644 --- a/drivers/staging/greybus/TODO +++ b/drivers/staging/greybus/TODO @@ -1,5 +1,3 @@ * Convert all uses of the old GPIO API from <linux/gpio.h> to the GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO lines from device tree or ACPI. -* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity, - ::enable and ::disable. -- 2.52.0

7 months, 1 week

[PATCH 0/3] staging: greybus: arche-platform: fix probe issues

by Johan Hovold

This series fixes some issues with the arche platform drivers probe function. A fix for the first issue was sent to the list two months ago, but there has been no reply to the review feedback given then. Non of these are tagged for stable backport as very few people should have the hardware in question and be bothered by this. Johan Johan Hovold (3): staging: greybus: arche-platform: fix coldboot probe error path staging: greybus: arche-platform: fix memleak on probe failure staging: greybus: arche-platform: fix OF populate on driver rebind drivers/staging/greybus/arche-platform.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) -- 2.51.2

7 months, 1 week

← Newer
1
...
14
15
16
17
18
19
20
...
83
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev