greybus-dev

greybus-dev@lists.linaro.org

15 participants
700 discussions

Re: [PATCH v2 00/31] tty: cleanup no. 99

by Jiri Slaby

Cc (sorry): Alex Elder <elder(a)kernel.org> Andrew Lunn <andrew+netdev(a)lunn.ch> Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> David Lin <dtwlin(a)gmail.com> "David S. Miller" <davem(a)davemloft.net> Eric Dumazet <edumazet(a)google.com> greybus-dev(a)lists.linaro.org "Ilpo Järvinen" <ilpo.jarvinen(a)linux.intel.com> Jakub Kicinski <kuba(a)kernel.org> Johan Hovold <johan(a)kernel.org> linux-alpha(a)vger.kernel.org linux-mmc(a)vger.kernel.org linux-staging(a)lists.linux.dev Matt Turner <mattst88(a)gmail.com> netdev(a)vger.kernel.org Paolo Abeni <pabeni(a)redhat.com> Richard Henderson <richard.henderson(a)linaro.org> Rob Herring <robh(a)kernel.org> sparclinux(a)vger.kernel.org Ulf Hansson <ulf.hansson(a)linaro.org> On 17. 03. 25, 8:00, Jiri Slaby (SUSE) wrote: > Hi, > > this is (again) a series of cleanup in tty. I am trying to rework > tty+serial to avoid limitations of devices (so called NR_UART or > tty_alloc_driver()'s first parameter). And the below popped up while > crawling through the code. So this is only a prep cleanup. > > * many tty flags are now enums > * many functions were improved for readability > * quite a few unused or old code dropped > > In particular, the runtime behaviour of the kernel before and after the > changes is supposed to be bug to bug compatible (except moxa's ioctl > and ISA evils dropped). That is, noone should notice. > > [v2] > * use serial_port_in/out() helpers in 26/30 (and not use serial_in/out()) > * the last patch is new > > Jiri Slaby (SUSE) (31): > tty: convert "TTY Struct Flags" to an enum > tty: audit: do not use N_TTY_BUF_SIZE > tty: caif: do not use N_TTY_BUF_SIZE > tty: move N_TTY_BUF_SIZE to n_tty > tty: n_tty: use uint for space returned by tty_write_room() > tty: n_tty: simplify process_output() > tty: n_tty: clean up process_output_block() > tty: n_tty: drop n_tty_trace() > tty: n_tty: extract n_tty_continue_cookie() from n_tty_read() > tty: n_tty: extract n_tty_wait_for_input() > tty: n_tty: move more_to_be_read to the end of n_tty_read() > tty: tty_driver: move TTY macros to the top > tty: tty_driver: convert "TTY Driver Flags" to an enum > tty: tty_driver: document both {,__}tty_alloc_driver() properly > tty: tty_driver: introduce TTY driver sub/types enums > tty: serdev: drop serdev_controller_ops::write_room() > tty: mmc: sdio: use bool for cts and remove parentheses > tty: moxa: drop version dump to logs > tty: moxa: drop ISA support > tty: moxa: carve out special ioctls and extra tty_port > tty: srmcons: fix retval from srmcons_init() > tty: staging/greybus: pass tty_driver flags to tty_alloc_driver() > tty: sunsu: drop serial_{in,out}p() > tty: sunsu: remove unused serial_icr_read() > serial: remove redundant tty_port_link_device() > serial: pass struct uart_state to uart_line_info() > serial: 8250: use serial_port_in/out() helpers > serial: 8250_rsa: simplify rsa8250_{request/release}_resource() > serial: 8250_port: do not use goto for UPQ_NO_TXEN_TEST code flow > serial: 8250_port: simplify serial8250_request_std_resource() > serial: switch change_irq and change_port to bool in uart_set_info() > > Documentation/driver-api/tty/tty_driver.rst | 4 +- > Documentation/driver-api/tty/tty_struct.rst | 2 +- > arch/alpha/kernel/srmcons.c | 62 ++--- > drivers/mmc/core/sdio_uart.c | 2 +- > drivers/net/caif/caif_serial.c | 2 +- > drivers/staging/greybus/uart.c | 4 +- > drivers/tty/Kconfig | 2 +- > drivers/tty/moxa.c | 251 +------------------- > drivers/tty/n_tty.c | 212 ++++++++--------- > drivers/tty/serdev/core.c | 11 - > drivers/tty/serdev/serdev-ttyport.c | 9 - > drivers/tty/serial/8250/8250_dw.c | 16 +- > drivers/tty/serial/8250/8250_fsl.c | 8 +- > drivers/tty/serial/8250/8250_omap.c | 2 +- > drivers/tty/serial/8250/8250_port.c | 59 ++--- > drivers/tty/serial/8250/8250_rsa.c | 21 +- > drivers/tty/serial/serial_core.c | 10 +- > drivers/tty/serial/sunsu.c | 178 ++++++-------- > drivers/tty/tty_audit.c | 10 +- > drivers/tty/tty_io.c | 8 +- > include/linux/serdev.h | 6 - > include/linux/tty.h | 53 +++-- > include/linux/tty_driver.h | 180 +++++++------- > 23 files changed, 412 insertions(+), 700 deletions(-) > -- js suse labs

11 months

[PATCH 00/29] tty: cleanup no. 99

by Jiri Slaby (SUSE)

Hi, this is (again) a series of cleanup in tty. I am trying to rework tty+serial to avoid limitations of devices (so called NR_UART or tty_alloc_driver()'s first parameter). And the below popped up while crawling through the code. So this is only a prep cleanup. * many tty flags are now enums * many functions were improved for readability * quite a few unused or old code dropped In particular, the runtime behaviour of the kernel before and after the changes is supposed to be bug to bug compatible (except moxa's ioctl and ISA evils dropped). That is, noone should notice. Cc: Alex Elder <elder(a)kernel.org> Cc: Andrew Lunn <andrew+netdev(a)lunn.ch> Cc: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Cc: David Lin <dtwlin(a)gmail.com> Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Eric Dumazet <edumazet(a)google.com> Cc: greybus-dev(a)lists.linaro.org Cc: "Ilpo Järvinen" <ilpo.jarvinen(a)linux.intel.com> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Johan Hovold <johan(a)kernel.org> Cc: linux-alpha(a)vger.kernel.org Cc: linux-staging(a)lists.linux.dev Cc: Matt Turner <mattst88(a)gmail.com> Cc: netdev(a)vger.kernel.org Cc: Paolo Abeni <pabeni(a)redhat.com> Cc: Richard Henderson <richard.henderson(a)linaro.org> Cc: Rob Herring <robh(a)kernel.org> Cc: sparclinux(a)vger.kernel.org Jiri Slaby (SUSE) (29): tty: convert "TTY Struct Flags" to an enum tty: audit: do not use N_TTY_BUF_SIZE tty: caif: do not use N_TTY_BUF_SIZE tty: move N_TTY_BUF_SIZE to n_tty tty: n_tty: use uint for space returned by tty_write_room() tty: n_tty: simplify process_output() tty: n_tty: clean up process_output_block() tty: n_tty: drop n_tty_trace() tty: n_tty: extract n_tty_continue_cookie() from n_tty_read() tty: n_tty: extract n_tty_wait_for_input() tty: n_tty: move more_to_be_read to the end of n_tty_read() tty: tty_driver: move TTY macros to the top tty: tty_driver: convert "TTY Driver Flags" to an enum tty: tty_driver: document both {,__}tty_alloc_driver() properly tty: tty_driver: introduce TTY driver sub/types enums tty: serdev: drop serdev_controller_ops::write_room() tty: moxa: drop version dump to logs tty: moxa: drop ISA support tty: moxa: carve out special ioctls and extra tty_port tty: srmcons: fix retval from srmcons_init() tty: staging/greybus: pass tty_driver flags to tty_alloc_driver() tty: sunsu: drop serial_{in,out}p() tty: sunsu: remove unused serial_icr_read() serial: remove redundant tty_port_link_device() serial: pass struct uart_state to uart_line_info() serial: 8250: use serial_in/out() helpers serial: 8250_rsa: simplify rsa8250_{request/release}_resource() serial: 8250_port: do not use goto for UPQ_NO_TXEN_TEST code flow serial: 8250_port: simplify serial8250_request_std_resource() Documentation/driver-api/tty/tty_driver.rst | 4 +- Documentation/driver-api/tty/tty_struct.rst | 2 +- arch/alpha/kernel/srmcons.c | 62 ++--- drivers/net/caif/caif_serial.c | 2 +- drivers/staging/greybus/uart.c | 4 +- drivers/tty/Kconfig | 2 +- drivers/tty/moxa.c | 251 +------------------- drivers/tty/n_tty.c | 212 ++++++++--------- drivers/tty/serdev/core.c | 11 - drivers/tty/serdev/serdev-ttyport.c | 9 - drivers/tty/serial/8250/8250_dw.c | 17 +- drivers/tty/serial/8250/8250_fsl.c | 8 +- drivers/tty/serial/8250/8250_omap.c | 2 +- drivers/tty/serial/8250/8250_port.c | 59 ++--- drivers/tty/serial/8250/8250_rsa.c | 21 +- drivers/tty/serial/serial_core.c | 6 +- drivers/tty/serial/sunsu.c | 178 ++++++-------- drivers/tty/tty_audit.c | 10 +- drivers/tty/tty_io.c | 8 +- include/linux/serdev.h | 6 - include/linux/tty.h | 53 +++-- include/linux/tty_driver.h | 180 +++++++------- 22 files changed, 410 insertions(+), 697 deletions(-) -- 2.48.1

11 months

[PATCH 00/34] address all -Wunused-const warnings

by Arnd Bergmann

From: Arnd Bergmann <arnd(a)arndb.de> Compilers traditionally warn for unused 'static' variables, but not if they are constant. The reason here is a custom for C++ programmers to define named constants as 'static const' variables in header files instead of using macros or enums. In W=1 builds, we get warnings only static const variables in C files, but not in headers, which is a good compromise, but this still produces warning output in at least 30 files. These warnings are almost all harmless, but also trivial to fix, and there is no good reason to warn only about the non-const variables being unused. I've gone through all the files that I found using randconfig and allmodconfig builds and created patches to avoid these warnings, with the goal of retaining a clean build once the option is enabled by default. Unfortunately, there is one fairly large patch ("drivers: remove incorrect of_match_ptr/ACPI_PTR annotations") that touches 34 individual drivers that all need the same one-line change. If necessary, I can split it up by driver or by subsystem, but at least for reviewing I would keep it as one piece for the moment. Please merge the individual patches through subsystem trees. I expect that some of these will have to go through multiple revisions before they are picked up, so anything that gets applied early saves me from resending. Arnd Arnd Bergmann (31): powerpc/fsl-soc: hide unused const variable ubsan: fix unused variable warning in test module platform: goldfish: remove ACPI_PTR() annotations i2c: pxa: hide unused icr_bits[] variable 3c515: remove unused 'mtu' variable tracing: hide unused ftrace_event_id_fops Input: synaptics: hide unused smbus_pnp_ids[] array power: rt9455: hide unused rt9455_boost_voltage_values efi: sysfb: don't build when EFI is disabled clk: ti: dpll: fix incorrect #ifdef checks apm-emulation: hide an unused variable sisfb: hide unused variables dma/congiguous: avoid warning about unused size_bytes leds: apu: remove duplicate DMI lookup data iio: ad5755: hook up of_device_id lookup to platform driver greybus: arche-ctrl: move device table to its right location lib: checksum: hide unused expected_csum_ipv6_magic[] sunrpc: suppress warnings for unused procfs functions comedi: ni_atmio: avoid warning for unused device_ids[] table iwlegacy: don't warn for unused variables with DEBUG_FS=n drm/komeda: don't warn for unused debugfs files firmware: qcom_scm: mark qcom_scm_qseecom_allowlist as __maybe_unused crypto: ccp - drop platform ifdef checks usb: gadget: omap_udc: remove unused variable isdn: kcapi: don't build unused procfs code cpufreq: intel_pstate: hide unused intel_pstate_cpu_oob_ids[] net: xgbe: remove extraneous #ifdef checks Input: imagis - remove incorrect ifdef checks sata: mv: drop unnecessary #ifdef checks ASoC: remove incorrect of_match_ptr/ACPI_PTR annotations spi: remove incorrect of_match_ptr annotations drivers: remove incorrect of_match_ptr/ACPI_PTR annotations kbuild: always enable -Wunused-const-variable Krzysztof Kozlowski (1): Input: stmpe-ts - mark OF related data as maybe unused arch/powerpc/sysdev/fsl_msi.c | 2 + drivers/ata/sata_mv.c | 64 +++++++++---------- drivers/char/apm-emulation.c | 5 +- drivers/char/ipmi/ipmb_dev_int.c | 2 +- drivers/char/tpm/tpm_ftpm_tee.c | 2 +- drivers/clk/ti/dpll.c | 10 ++- drivers/comedi/drivers/ni_atmio.c | 2 +- drivers/cpufreq/intel_pstate.c | 2 + drivers/crypto/ccp/sp-platform.c | 14 +--- drivers/dma/img-mdc-dma.c | 2 +- drivers/firmware/efi/Makefile | 3 +- drivers/firmware/efi/sysfb_efi.c | 2 - drivers/firmware/qcom/qcom_scm.c | 2 +- drivers/fpga/versal-fpga.c | 2 +- .../gpu/drm/arm/display/komeda/komeda_dev.c | 8 --- drivers/hid/hid-google-hammer.c | 6 +- drivers/i2c/busses/i2c-pxa.c | 2 +- drivers/i2c/muxes/i2c-mux-ltc4306.c | 2 +- drivers/i2c/muxes/i2c-mux-reg.c | 2 +- drivers/iio/dac/ad5755.c | 1 + drivers/input/mouse/synaptics.c | 2 + drivers/input/touchscreen/imagis.c | 4 +- drivers/input/touchscreen/stmpe-ts.c | 2 +- drivers/input/touchscreen/wdt87xx_i2c.c | 2 +- drivers/isdn/capi/Makefile | 3 +- drivers/isdn/capi/kcapi.c | 7 +- drivers/leds/leds-apu.c | 3 +- drivers/mux/adg792a.c | 2 +- drivers/net/ethernet/3com/3c515.c | 3 - drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 8 --- drivers/net/ethernet/apm/xgene-v2/main.c | 2 +- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-rs.c | 15 +---- drivers/net/wireless/intel/iwlegacy/common.h | 2 - drivers/platform/goldfish/goldfish_pipe.c | 2 +- drivers/power/supply/rt9455_charger.c | 2 + drivers/regulator/pbias-regulator.c | 2 +- drivers/regulator/twl-regulator.c | 2 +- drivers/regulator/twl6030-regulator.c | 2 +- drivers/rtc/rtc-fsl-ftm-alarm.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 +- drivers/spi/spi-armada-3700.c | 2 +- drivers/spi/spi-img-spfi.c | 2 +- drivers/spi/spi-meson-spicc.c | 2 +- drivers/spi/spi-meson-spifc.c | 2 +- drivers/spi/spi-orion.c | 2 +- drivers/spi/spi-pic32-sqi.c | 2 +- drivers/spi/spi-pic32.c | 2 +- drivers/spi/spi-rockchip.c | 2 +- drivers/spi/spi-s3c64xx.c | 2 +- drivers/spi/spi-st-ssc4.c | 2 +- drivers/staging/greybus/arche-apb-ctrl.c | 1 + drivers/staging/greybus/arche-platform.c | 9 +-- drivers/staging/pi433/pi433_if.c | 2 +- drivers/tty/serial/amba-pl011.c | 6 +- drivers/tty/serial/ma35d1_serial.c | 2 +- drivers/usb/gadget/udc/omap_udc.c | 10 +-- drivers/video/fbdev/sis/init301.c | 3 +- kernel/dma/contiguous.c | 2 +- kernel/trace/trace_events.c | 4 ++ lib/checksum_kunit.c | 2 + lib/test_ubsan.c | 2 +- net/sunrpc/cache.c | 10 +-- scripts/Makefile.extrawarn | 1 - sound/soc/atmel/sam9x5_wm8731.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/qcom/lpass-sc7280.c | 2 +- sound/soc/samsung/aries_wm8994.c | 2 +- 69 files changed, 121 insertions(+), 169 deletions(-) -- 2.39.2 Cc: Michael Ellerman <mpe(a)ellerman.id.au> Cc: Christophe Leroy <christophe.leroy(a)csgroup.eu> Cc: Damien Le Moal <dlemoal(a)kernel.org> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Corey Minyard <minyard(a)acm.org> Cc: Peter Huewe <peterhuewe(a)gmx.de> Cc: Jarkko Sakkinen <jarkko(a)kernel.org> Cc: Tero Kristo <kristo(a)kernel.org> Cc: Stephen Boyd <sboyd(a)kernel.org> Cc: Ian Abbott <abbotti(a)mev.co.uk> Cc: H Hartley Sweeten <hsweeten(a)visionengravers.com> Cc: Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> Cc: Len Brown <lenb(a)kernel.org> Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Cc: John Allen <john.allen(a)amd.com> Cc: Herbert Xu <herbert(a)gondor.apana.org.au> Cc: Vinod Koul <vkoul(a)kernel.org> Cc: Ard Biesheuvel <ardb(a)kernel.org> Cc: Bjorn Andersson <andersson(a)kernel.org> Cc: Moritz Fischer <mdf(a)kernel.org> Cc: Liviu Dudau <liviu.dudau(a)arm.com> Cc: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> Cc: Andi Shyti <andi.shyti(a)kernel.org> Cc: Michael Hennerich <michael.hennerich(a)analog.com> Cc: Peter Rosin <peda(a)axentia.se> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Cc: Jonathan Cameron <jic23(a)kernel.org> Cc: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Cc: Markuss Broks <markuss.broks(a)gmail.com> Cc: Alexandre Torgue <alexandre.torgue(a)foss.st.com> Cc: Lee Jones <lee(a)kernel.org> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Shyam Sundar S K <Shyam-sundar.S-k(a)amd.com> Cc: Iyappan Subramanian <iyappan(a)os.amperecomputing.com> Cc: Yisen Zhuang <yisen.zhuang(a)huawei.com> Cc: Stanislaw Gruszka <stf_xl(a)wp.pl> Cc: Kalle Valo <kvalo(a)kernel.org> Cc: Sebastian Reichel <sre(a)kernel.org> Cc: Tony Lindgren <tony(a)atomide.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Alexandre Belloni <alexandre.belloni(a)bootlin.com> Cc: Xiang Chen <chenxiang66(a)hisilicon.com> Cc: "Martin K. Petersen" <martin.petersen(a)oracle.com> Cc: Neil Armstrong <neil.armstrong(a)linaro.org> Cc: Heiko Stuebner <heiko(a)sntech.de> Cc: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Cc: Vaibhav Hiremath <hvaibhav.linux(a)gmail.com> Cc: Alex Elder <elder(a)kernel.org> Cc: Jiri Slaby <jirislaby(a)kernel.org> Cc: Jacky Huang <ychuang3(a)nuvoton.com> Cc: Helge Deller <deller(a)gmx.de> Cc: Christoph Hellwig <hch(a)lst.de> Cc: Robin Murphy <robin.murphy(a)arm.com> Cc: Steven Rostedt <rostedt(a)goodmis.org> Cc: Masami Hiramatsu <mhiramat(a)kernel.org> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Kees Cook <keescook(a)chromium.org> Cc: Trond Myklebust <trond.myklebust(a)hammerspace.com> Cc: Anna Schumaker <anna(a)kernel.org> Cc: Masahiro Yamada <masahiroy(a)kernel.org> Cc: Nathan Chancellor <nathan(a)kernel.org> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-kernel(a)vger.kernel.org Cc: linux-ide(a)vger.kernel.org Cc: openipmi-developer(a)lists.sourceforge.net Cc: linux-integrity(a)vger.kernel.org Cc: linux-omap(a)vger.kernel.org Cc: linux-clk(a)vger.kernel.org Cc: linux-pm(a)vger.kernel.org Cc: linux-crypto(a)vger.kernel.org Cc: dmaengine(a)vger.kernel.org Cc: linux-efi(a)vger.kernel.org Cc: linux-arm-msm(a)vger.kernel.org Cc: linux-fpga(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-input(a)vger.kernel.org Cc: linux-i2c(a)vger.kernel.org Cc: linux-iio(a)vger.kernel.org Cc: linux-stm32(a)st-md-mailman.stormreply.com Cc: linux-arm-kernel(a)lists.infradead.org Cc: netdev(a)vger.kernel.org Cc: linux-leds(a)vger.kernel.org Cc: linux-wireless(a)vger.kernel.org Cc: linux-rtc(a)vger.kernel.org Cc: linux-scsi(a)vger.kernel.org Cc: linux-spi(a)vger.kernel.org Cc: linux-amlogic(a)lists.infradead.org Cc: linux-rockchip(a)lists.infradead.org Cc: linux-samsung-soc(a)vger.kernel.org Cc: greybus-dev(a)lists.linaro.org Cc: linux-staging(a)lists.linux.dev Cc: linux-serial(a)vger.kernel.org Cc: linux-usb(a)vger.kernel.org Cc: linux-fbdev(a)vger.kernel.org Cc: iommu(a)lists.linux.dev Cc: linux-trace-kernel(a)vger.kernel.org Cc: kasan-dev(a)googlegroups.com Cc: linux-hardening(a)vger.kernel.org Cc: linux-nfs(a)vger.kernel.org Cc: linux-kbuild(a)vger.kernel.org Cc: alsa-devel(a)alsa-project.org Cc: linux-sound(a)vger.kernel.org

1 year

[PATCH] staging: greybus: remove unnecessary parentheses

by Will Walsh

Unnecessary parentheses in boolean comparisons make it harder to read. Removed the extra parentheses on line 305 for code readability. Signed-off-by: Will Walsh <iron.will.walsh(a)gmail.com> --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 2f05e761fb9a..dfb5322964de 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -305,7 +305,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, dev_dbg(module->dev, "%s:Module update %s sequence\n", w->name, enable ? "Enable" : "Disable"); - if ((w->id != snd_soc_dapm_aif_in) && (w->id != snd_soc_dapm_aif_out)) { + if (w->id != snd_soc_dapm_aif_in && w->id != snd_soc_dapm_aif_out) { dev_dbg(codec->dev, "No action required for %s\n", w->name); return 0; } -- 2.45.2

1 year, 1 month

[PATCH] staging: greybus: Remove module from list before freeing in gb_audio_module_release

by Atharva Tiwari

Previously,the module was freed without detaching it from the list which could lead to memory leak this patch uses list_del to safely remove the module from the list Signed-off-by: Atharva Tiwari <evepolonium(a)gmail.com> --- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 4a4dfb42f50f..7e52c3f95692 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -69,7 +69,8 @@ static void gb_audio_module_release(struct kobject *kobj) struct gb_audio_manager_module *module = to_gb_audio_module(kobj); pr_info("Destroying audio module #%d\n", module->id); - /* TODO -> delete from list */ + if (module->list.prev && module->list.next) + list_del(&module->list); kfree(module); } -- 2.39.5

1 year, 1 month

[PATCH v3] staging: greybus: uart: Fix atomicity violation in get_serial_info()

by Qiu-ji Chen

Our static checker found a bug where set_serial_info() uses a mutex, but get_serial_info() does not. Fortunately, the impact of this is relatively minor. It doesn't cause a crash or any other serious issues. However, if a race condition occurs between set_serial_info() and get_serial_info(), there is a chance that the data returned by get_serial_info() will be meaningless. Signed-off-by: Qiu-ji Chen <chenqiuji666(a)gmail.com> Fixes: 0aad5ad563c8 ("greybus/uart: switch to ->[sg]et_serial()") --- V2: Modified the patch description to make it more concise and easier to understand. Changed the fix code to ensure the logic is correct. Thanks to Johan Hovold and Dan Carpenter for helpful suggestion. V3: Used the correct patch prefix. Thanks Johan Hovold, Dan Carpenter, Alex Elder and Greg KH for helpful suggestion. --- drivers/staging/greybus/uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index cdf4ebb93b10..8eab94cb06fa 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -596,11 +596,13 @@ static int get_serial_info(struct tty_struct *tty, struct gb_tty *gb_tty = tty->driver_data; ss->line = gb_tty->minor; + mutex_lock(&gb_tty->port.mutex); ss->close_delay = jiffies_to_msecs(gb_tty->port.close_delay) / 10; ss->closing_wait = gb_tty->port.closing_wait == ASYNC_CLOSING_WAIT_NONE ? ASYNC_CLOSING_WAIT_NONE : jiffies_to_msecs(gb_tty->port.closing_wait) / 10; + mutex_unlock(&gb_tty->port.mutex); return 0; } -- 2.34.1

1 year, 3 months

[PATCH v2] greybus/uart: Fix atomicity violation in get_serial_info()

by Qiu-ji Chen

Our static checker found a bug where set_serial_info() uses a mutex, but get_serial_info() does not. Fortunately, the impact of this is relatively minor. It doesn't cause a crash or any other serious issues. However, if a race condition occurs between set_serial_info() and get_serial_info(), there is a chance that the data returned by get_serial_info() will be meaningless. Signed-off-by: Qiu-ji Chen <chenqiuji666(a)gmail.com> Fixes: 0aad5ad563c8 ("greybus/uart: switch to ->[sg]et_serial()") --- V2: Modified the patch description to make it more concise and easier to understand. Changed the fix code to ensure the logic is correct. Thanks to Johan Hovold and Dan Carpenter for helpful suggestion. --- drivers/staging/greybus/uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index cdf4ebb93b10..8eab94cb06fa 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -596,11 +596,13 @@ static int get_serial_info(struct tty_struct *tty, struct gb_tty *gb_tty = tty->driver_data; ss->line = gb_tty->minor; + mutex_lock(&gb_tty->port.mutex); ss->close_delay = jiffies_to_msecs(gb_tty->port.close_delay) / 10; ss->closing_wait = gb_tty->port.closing_wait == ASYNC_CLOSING_WAIT_NONE ? ASYNC_CLOSING_WAIT_NONE : jiffies_to_msecs(gb_tty->port.closing_wait) / 10; + mutex_unlock(&gb_tty->port.mutex); return 0; } -- 2.34.1

1 year, 3 months

[PATCH] greybus: Fix a typo

by Christophe JAILLET

s/interfce/interface/ A 'a' is missing. Add it. Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- drivers/greybus/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/greybus/interface.c b/drivers/greybus/interface.c index d022bfb5e95d..a0f3e9422721 100644 --- a/drivers/greybus/interface.c +++ b/drivers/greybus/interface.c @@ -780,7 +780,7 @@ const struct device_type greybus_interface_type = { * The position of interface within the Endo is encoded in "interface_id" * argument. * - * Returns a pointer to the new interfce or a null pointer if a + * Returns a pointer to the new interface or a null pointer if a * failure occurs due to memory exhaustion. */ struct gb_interface *gb_interface_create(struct gb_module *module, -- 2.47.0

1 year, 3 months

[PATCH] staging: greybus: fix possible null-ptr-deref in gb_audio_manager_get_module()

by Yi Yang

The gb_audio_manager_get_module() is EXPORT_SYMBOL, and will return NULL when incoming parameter id < 0, fix possible null-ptr-deref by add check for return value. Fixes: 8db00736d365 ("greybus: audio: Add Audio Manager") Signed-off-by: Yi Yang <yiyang13(a)huawei.com> --- drivers/staging/greybus/audio_manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index 27ca5f796c5f..1da8804e61ca 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id) down_read(&modules_rwsem); module = gb_audio_manager_get_locked(id); - kobject_get(&module->kobj); + if (module) + kobject_get(&module->kobj); up_read(&modules_rwsem); return module; } -- 2.25.1

1 year, 3 months

[PATCH] greybus: Fix null pointer dereference in gb_operation_response_send()

by Suraj Sonawane

Fix an issue detected by the Smatch static tool: drivers/greybus/operation.c:852 gb_operation_response_send() error: we previously assumed 'operation->response' could be null (see line 829) The issue occurs because 'operation->response' may be null if the response allocation fails at line 829. However, the code tries to access 'operation->response->header' at line 852 without checking if it was successfully allocated. This can cause a crash if 'response' is null. To fix this, add a check to ensure 'operation->response' is not null before accessing its header. If the response is null, log an error message and return -ENOMEM to stop further processing, preventing any crashes or undefined behavior. Signed-off-by: Suraj Sonawane <surajsonawane0215(a)gmail.com> --- drivers/greybus/operation.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c index 8459e9bc0..521899fbc 100644 --- a/drivers/greybus/operation.c +++ b/drivers/greybus/operation.c @@ -849,7 +849,13 @@ static int gb_operation_response_send(struct gb_operation *operation, goto err_put; /* Fill in the response header and send it */ - operation->response->header->result = gb_operation_errno_map(errno); + if (operation->response) { + operation->response->header->result = gb_operation_errno_map(errno); + } else { + dev_err(&connection->hd->dev, "failed to allocate response\n"); + ret = -ENOMEM; + goto err_put_active; + } ret = gb_message_send(operation->response, GFP_KERNEL); if (ret) -- 2.34.1

1 year, 3 months

← Newer
1
...
13
14
15
16
17
18
19
...
70
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev