- greybus-dev - lists.linaro.org

[PATCH] Staging: greybus: Prefer kcalloc over kzalloc

by karthik＠techveda.org

From: Karthik Tummala <karthik(a)techveda.org> Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala <karthik(a)techveda.org> --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 1681362..861a249 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); - light->channels = kzalloc(light->channels_count * + light->channels = kcalloc(light->channels_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) return -ENOMEM; @@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights) if (ret < 0) goto out; - glights->lights = kzalloc(glights->lights_count * + glights->lights = kcalloc(glights->lights_count, sizeof(struct gb_light), GFP_KERNEL); if (!glights->lights) { ret = -ENOMEM; -- 1.9.1

7 years

3
3
0 0

[PATCH 0/3] Add the Generic Netlink controller

by Alexandre Bailon

Currently, only the es2 hd controller is supported, which restrict the usage of greybus to few products. This series intents to add a support of new hd controllers. The driver doesn't support any hardware. Actually, the controller is just a bridge between Greybus kernel and userspace. The real driver must be implemented in userspace. This give the ability to support any kind of transport layer (such as Bluetooth, WiFi, Ethernet). The controller uses Generic Netlink. My original intent was to implement a TCP/IP controller but it was very slow, unstable. In addition, some features such as SVC or module discovery were to add to implement in kernel side. With the generic netlink controller, we can easily add support of new controller. It also helps to deal with all the project ARA legacy such as SVC. I have started to implement an application which is able to emulate the SVC, a module (like gbsim but only support control and loopback protcols), TCP/IP, Bluetooth and UART. It is still under development but it was stable enough to test this series. The application can found here: https://github.com/anobli/gbridge Alexandre Bailon (3): staging greybus: make cport_quiesce() method optional staging: greybus: Add Greybus netlink driver staging: greybus: netlink: Add a way to "hot remove" SVC drivers/staging/greybus/Kconfig | 9 ++ drivers/staging/greybus/Makefile | 2 + drivers/staging/greybus/connection.c | 3 + drivers/staging/greybus/gb_netlink.h | 38 ++++++ drivers/staging/greybus/netlink.c | 256 +++++++++++++++++++++++++++++++++++ 5 files changed, 308 insertions(+) create mode 100644 drivers/staging/greybus/gb_netlink.h create mode 100644 drivers/staging/greybus/netlink.c -- 2.10.2

7 years

3
10
0 0

[PATCH 1/2] staging: greybus: light.c: Remove include linux/version.h

by Darryl T. Agostinelli

Fixes: $ make versioncheck | grep staging ./drivers/staging/greybus/light.c: 15 linux/version.h not needed. Signed-off-by: Darryl T. Agostinelli <dagostinelli(a)gmail.com> --- drivers/staging/greybus/light.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a..1681362 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -12,7 +12,6 @@ #include <linux/led-class-flash.h> #include <linux/module.h> #include <linux/slab.h> -#include <linux/version.h> #include <media/v4l2-flash-led-class.h> #include "greybus.h" -- 2.9.3

7 years, 1 month

3
4
0 0

[PATCH] staging: greybus: compress return logic

by Arushi Singhal

Simplify function returns by merging assignment and return. Signed-off-by: Arushi Singhal <arushisinghal19971997(a)gmail.com> --- drivers/staging/greybus/loopback.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index aaf29a5fac83..08e255884206 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -365,11 +365,8 @@ static void gb_loopback_calculate_stats(struct gb_loopback *gb, bool error); static u32 gb_loopback_nsec_to_usec_latency(u64 elapsed_nsecs) { - u32 lat; - do_div(elapsed_nsecs, NSEC_PER_USEC); - lat = elapsed_nsecs; - return lat; + return elapsed_nsecs; } static u64 __gb_loopback_calc_latency(u64 t1, u64 t2) -- 2.11.0

7 years, 1 month

2
1
0 0

greybus file names

by Tobin C. Harding

Is there a technical reason why greybus files mix hyphen and underscore in their names? $ ls drivers/staging/greybus/arch* arche-apb-ctrl.c arche-platform.c arche_platform.h thanks, Tobin.

7 years, 1 month

2
1
0 0

virtual USB device

by Greg Hazel

Hi, I’m working with Greybus and I’m wondering if there’s any support or code for virtual USB devices. On one side of Greybus I have a small nuttX environment with a UART connected device which I can write modules for, and on the other side of Greybus I’d like to provide a network interface. I can’t modify that side, so I have to work with the kernel modules it has available. I thought it might be possible to present a virtual USB CDC-EVM to Greybus, and my guess (hope) is that cdc_ether would pick it up on the other side. Is this possible? Has this sort of virtual USB device been created before? -Greg

7 years, 1 month

3
12
0 0

[PATCH v4 0/4] staging: greybus: Documentation/firmware checkpatch fixes

by Michael Sartain

Five ways to screw up a patch by Michael Sartain _hopefully_ finds the final chapter here... -Mike This patch series fixes several checkpatch issues with the greybus Documentation/firmware files. V2: Add "greybus: firmware:" prefix to subject lines Add Acked-by: Viresh Kumar <viresh.kumar(a)linaro.org> V3: Add "staging:" prefix to subject lines V4: Resubmit without diff.staging=true Michael Sartain (4): staging: greybus: firmware: Remove trailing semicolon from FW_TIMEOUT_DEFAULT staging: greybus: firmware: Remove extra braces from single line if staging: greybus: firmware: Change long long unsigned to unsigned long long staging: greybus: firmware: Convert sscanf calls to strtoul .../greybus/Documentation/firmware/authenticate.c | 2 +- .../greybus/Documentation/firmware/firmware.c | 21 +++++++++++---------- 2 files changed, 12 insertions(+), 11 deletions(-) -- 2.11.0

7 years, 2 months

1
4
0 0

[PATCH v3 0/4] staging: greybus: Documentation/firmware checkpatch fixes

by Michael Sartain

Sigh. Hopefully I got it right this time. Apologies for the spam and thanks in advance for the patience and help. -Mike This patch series fixes several checkpatch issues with the greybus Documentation/firmware files. V2: Add "greybus: firmware:" prefix to subject lines Add Acked-by: Viresh Kumar <viresh.kumar(a)linaro.org> V3: Add "staging:" prefix to subject lines Michael Sartain (4): greybus: firmware: Remove trailing semicolon from FW_TIMEOUT_DEFAULT greybus: firmware: Remove extra braces from single line if greybus: firmware: Change long long unsigned to unsigned long long greybus: firmware: Convert sscanf calls to strtoul .../greybus/Documentation/firmware/authenticate.c | 2 +- .../greybus/Documentation/firmware/firmware.c | 21 +++++++++++---------- 2 files changed, 12 insertions(+), 11 deletions(-) -- 2.11.0

7 years, 2 months

3
6
0 0

[PATCH v1 0/3] staging: Replace "is is " with "is"

by simran singhal

This patch series replace "is is " with "is" in various drivers. v1: -change the subject -Changed "If is a command..." to "It is a command..." in rtl8192u/r819xU_cmdpkt.c simran singhal (3): staging: rtl8192u: Replace "is is" with "is" staging: greybus: Replace "is is" with "is" staging: comedi: Replace "is is" with "is" drivers/staging/comedi/drivers/ni_usb6501.c | 2 +- drivers/staging/greybus/uart.c | 2 +- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4

7 years, 2 months

2
4
0 0

[PATCH 0/3] Replace "is is " with "is"

by simran singhal

This patch series replace "is is " with "is" in various drivers. simran singhal (3): staging: rtl8192u: Replace "is is" with "is" staging: greybus: Replace "is is" with "is" staging: comedi: Replace "is is" with "is" drivers/staging/comedi/drivers/ni_usb6501.c | 2 +- drivers/staging/greybus/uart.c | 2 +- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4

7 years, 2 months

4
9
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev