Hi Dan,
Thank you for the explanation and the link. I understand that changing existing sysfs output formats can break userspace ABI. I will drop this patch and take the time to read through your guide and lore discussions before submitting future work. Thanks for your time and guidance, Ronit
On Thu, Oct 1, 2026 at 6:37 PM Dan Carpenter error27@gmail.com wrote:
On Thu, Oct 01, 2026 at 05:43:28AM -0700, Ronit Gupta wrote:
According to Documentation/filesystems/sysfs.rst, sysfs attribute values should terminate with a single newline character.
Add missing trailing '\n' characters to the format strings of all sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
Signed-off-by: Ronit Gupta ronitgupta138@gmail.com
Please slow down...
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Anyway, see my previous response. This potentially breaks the API so we can't do it. Search lore.kernel.org for the function name for more details.
regards, dan carpenter