According to Documentation/filesystems/sysfs.rst, sysfs attribute values should terminate with a single newline character.
Add missing trailing '\n' characters to the format strings of all sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
Signed-off-by: Ronit Gupta ronitgupta138@gmail.com --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index dc90cc2d2..5737f2a32 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); }
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); }
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); }
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); }
static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); }
static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); }
static struct gb_audio_manager_module_attribute
On Thu, Oct 01, 2026 at 05:43:28AM -0700, Ronit Gupta wrote:
According to Documentation/filesystems/sysfs.rst, sysfs attribute values should terminate with a single newline character.
Add missing trailing '\n' characters to the format strings of all sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
Signed-off-by: Ronit Gupta ronitgupta138@gmail.com
Please slow down...
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Anyway, see my previous response. This potentially breaks the API so we can't do it. Search lore.kernel.org for the function name for more details.
regards, dan carpenter
Hi Dan,
Thank you for the explanation and the link. I understand that changing existing sysfs output formats can break userspace ABI. I will drop this patch and take the time to read through your guide and lore discussions before submitting future work. Thanks for your time and guidance, Ronit
On Thu, Oct 1, 2026 at 6:37 PM Dan Carpenter error27@gmail.com wrote:
On Thu, Oct 01, 2026 at 05:43:28AM -0700, Ronit Gupta wrote:
According to Documentation/filesystems/sysfs.rst, sysfs attribute values should terminate with a single newline character.
Add missing trailing '\n' characters to the format strings of all sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
Signed-off-by: Ronit Gupta ronitgupta138@gmail.com
Please slow down...
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Anyway, see my previous response. This potentially breaks the API so we can't do it. Search lore.kernel.org for the function name for more details.
regards, dan carpenter