[greybus-dev] Re: [PATCH 2/2] staging: greybus: Fix Alignment with parenthesis

On ١١‏/٣‏/٢٠٢٣ ١٠:٥٧, Julia Lawall wrote:

On Fri, 10 Mar 2023, Menna Mahmoud wrote:

...

Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath

The log message could be better, to explain what you have done and why. The word "fix" doesn't express any of that, and should be avoided if possible.

julia

got it, thank you

...

Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com

drivers/staging/greybus/fw-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index f562cb12d5ad..0fb15a60412f 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -110,7 +110,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, }

	connection = gb_connection_create(bundle, cport_id,

• 				gb_fw_download_request_handler);
  

• 					  gb_fw_download_request_handler);
  if (IS_ERR(connection)) {
  	dev_err(&bundle->dev, "failed to create download connection (%ld)\n",
  		PTR_ERR(connection));
  

-- 2.34.1