On ١١‏/٣‏/٢٠٢٣ ١٠:٥٧, Julia Lawall wrote:

On Fri, 10 Mar 2023, Menna Mahmoud wrote:

...

Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath

The log message could be better, to explain what you have done and why. The word "fix" doesn't express any of that, and should be avoided if possible.

julia

got it, thank you

...

Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com

drivers/staging/greybus/fw-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index f562cb12d5ad..0fb15a60412f 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -110,7 +110,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, }

	connection = gb_connection_create(bundle, cport_id,

• 				gb_fw_download_request_handler);
  

• 					  gb_fw_download_request_handler);
  if (IS_ERR(connection)) {
  	dev_err(&bundle->dev, "failed to create download connection (%ld)\n",
  		PTR_ERR(connection));
  

-- 2.34.1

On ١٠‏/٣‏/٢٠٢٣ ١٨:١٦, Alex Elder wrote:

On 3/10/23 9:51 AM, Menna Mahmoud wrote:

...

Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath

Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com

Is this (and your second patch) the only place(s) where this issue gets reported?

yes, after fixed them i got 0 check.

I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way.

Okay, thanks.

-Menna

-Alex

...

---

drivers/staging/greybus/fw-core.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 57bebf24636b..f562cb12d5ad 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,               }                 connection = gb_connection_create(bundle, cport_id, -                        gb_fw_mgmt_request_handler); +                              gb_fw_mgmt_request_handler);               if (IS_ERR(connection)) {                   ret = PTR_ERR(connection);                   dev_err(&bundle->dev,

On ١١‏/٣‏/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:

On Fri, 10 Mar 2023, Menna Mahmoud wrote:

...

Fix " CHECK: Alignment should match open parenthesis " Reported by checkpath

See the message in the other mail about the log message.

Also, you should not have two patches with the same subject. Here, the changes are on the same file and are essentially the same, even involving the same function call. So they can be together in one patch.

julia

okay, I will. appreciate your feedback. thanks.

...

Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com

drivers/staging/greybus/fw-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 57bebf24636b..f562cb12d5ad 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, }

	connection = gb_connection_create(bundle, cport_id,

• 				gb_fw_mgmt_request_handler);
  

• 					  gb_fw_mgmt_request_handler);
  if (IS_ERR(connection)) {
  	ret = PTR_ERR(connection);
  	dev_err(&bundle->dev,
  

-- 2.34.1