Hi Dan Carpenter
I have not been able to test this on hardware. I based this change on the standard sysfs formatting requirement as documented in Documentation/filesystems/sysfs.rst. If there is a concern that specific Greybus userspace tools are sensitive to the trailing newline, I can withdraw the patch. However, this change aligns the driver with the standard sysfs formatting used across the kernel.
Best Regards Shyam
On Fri, 1 May 2026 at 21:40, Dan Carpenter error27@gmail.com wrote:
On Fri, May 01, 2026 at 08:12:08PM +0530, Shyam Sunder Reddy Padira wrote:
Sysfs show() functions should return newline-terminated strings.Add missing newline to sysfs_emit() format string.
Signed-off-by: Shyam Sunder Reddy Padira shyamsunderreddypadira@gmail.com
v2: -Remove "no functional changes" from the description as per Greg's feedback.
How do you know this doesn't break anything?
regards, dan carpenter