Sysfs show() functions should return newline-terminated strings.Add missing newline to sysfs_emit() format string.
Signed-off-by: Shyam Sunder Reddy Padira shyamsunderreddypadira@gmail.com ---- v2: -Remove "no functional changes" from the description as per Greg's feedback. --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); }
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); }
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); }
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); }
static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); }
static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); }
static struct gb_audio_manager_module_attribute
On Fri, May 01, 2026 at 08:12:08PM +0530, Shyam Sunder Reddy Padira wrote:
Sysfs show() functions should return newline-terminated strings.Add missing newline to sysfs_emit() format string.
Signed-off-by: Shyam Sunder Reddy Padira shyamsunderreddypadira@gmail.com
v2: -Remove "no functional changes" from the description as per Greg's feedback.
How do you know this doesn't break anything?
regards, dan carpenter
Hi Dan Carpenter
I have not been able to test this on hardware. I based this change on the standard sysfs formatting requirement as documented in Documentation/filesystems/sysfs.rst. If there is a concern that specific Greybus userspace tools are sensitive to the trailing newline, I can withdraw the patch. However, this change aligns the driver with the standard sysfs formatting used across the kernel.
Best Regards Shyam
On Fri, 1 May 2026 at 21:40, Dan Carpenter error27@gmail.com wrote:
On Fri, May 01, 2026 at 08:12:08PM +0530, Shyam Sunder Reddy Padira wrote:
Sysfs show() functions should return newline-terminated strings.Add missing newline to sysfs_emit() format string.
Signed-off-by: Shyam Sunder Reddy Padira shyamsunderreddypadira@gmail.com
v2: -Remove "no functional changes" from the description as per Greg's feedback.
How do you know this doesn't break anything?
regards, dan carpenter
On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote:
Hi Dan Carpenter
I have not been able to test this on hardware. I based this change on the standard sysfs formatting requirement as documented in Documentation/filesystems/sysfs.rst. If there is a concern that specific Greybus userspace tools are sensitive to the trailing newline, I can withdraw the patch. However, this change aligns the driver with the standard sysfs formatting used across the kernel.
You need to test it with the Greybus userspace tools, yes.
regards, dan carpenter
Hi Dan Carpenter and everyone,
I understand the need for verification. Unfortunately, I do not have access to the physical hardware to test this specific Greybus driver myself.
Would anyone on the CC list who has access to the hardware would be willing to run a quick test with the userspace tools.
If not, I am happy to withdraw the patch for now to avoid any risk of regression.
Best Regards, Shyam
On Fri, 1 May 2026 at 22:23, Dan Carpenter error27@gmail.com wrote:
On Fri, May 01, 2026 at 10:15:57PM +0530, Shyam Sunder Reddy Padira wrote:
Hi Dan Carpenter
I have not been able to test this on hardware. I based this change on the standard sysfs formatting requirement as documented in Documentation/filesystems/sysfs.rst. If there is a concern that specific Greybus userspace tools are sensitive to the trailing newline, I can withdraw the patch. However, this change aligns the driver with the standard sysfs formatting used across the kernel.
You need to test it with the Greybus userspace tools, yes.
regards, dan carpenter
-
Dan Carpenter -
Shyam Sunder Reddy Padira