On Wed, Mar 18, 2020 at 08:28:31AM +0000, Will Deacon wrote:
On Tue, Mar 17, 2020 at 04:15:44PM -0700, kernelci.org bot wrote:
arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6)
Full Build Summary: https://kernelci.org/build/arm64/branch/for-kernelci/kernel/v5.6-rc6-67-gcf8...
Tree: arm64 Branch: for-kernelci Git Describe: v5.6-rc6-67-gcf89e8c383a6 Git Commit: cf89e8c383a6447a635400f669d0cd97e89770d9 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git Built: 1 unique architecture
Build Failure Detected:
arm64: allnoconfig: (gcc-8) FAIL
Errors Detected:
arm64: allnoconfig (gcc-8): 1 error
Looks like this is easily fixed as per below.
Will
--->8
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index d65d226a77ec..53c77711f752 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -64,7 +64,7 @@ config ARM64 select ARCH_INLINE_SPIN_UNLOCK_IRQRESTORE if !PREEMPTION select ARCH_KEEP_MEMBLOCK select ARCH_USE_CMPXCHG_LOCKREF
- select ARCH_USE_GNU_PROPERTY if BINFMT_ELF
- select ARCH_USE_GNU_PROPERTY select ARCH_USE_QUEUED_RWLOCKS select ARCH_USE_QUEUED_SPINLOCKS select ARCH_SUPPORTS_MEMORY_FAILURE
If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select it unconditionally (and the option should probably depend on BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we could fix it up as below:
diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h index 4f00d50585a4..2eef3672de50 100644 --- a/arch/arm64/include/asm/elf.h +++ b/arch/arm64/include/asm/elf.h @@ -238,6 +238,7 @@ struct arch_elf_state { .flags = 0, \ }
+#ifdef CONFIG_ARCH_USE_GNU_PROPERTY static inline int arch_parse_elf_property(u32 type, const void *data, size_t datasz, bool compat, struct arch_elf_state *arch) @@ -259,6 +260,7 @@ static inline int arch_parse_elf_property(u32 type, const void *data,
return 0; } +#endif
static inline int arch_elf_pt_proc(void *ehdr, void *phdr, struct file *f, bool is_interp,