On Wed, Mar 18, 2020 at 12:16:27PM +0000, Mark Brown wrote:
On Wed, Mar 18, 2020 at 12:06:14PM +0000, Catalin Marinas wrote:
If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select it unconditionally (and the option should probably depend on BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we could fix it up as below:
diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h index 4f00d50585a4..2eef3672de50 100644 --- a/arch/arm64/include/asm/elf.h +++ b/arch/arm64/include/asm/elf.h @@ -238,6 +238,7 @@ struct arch_elf_state { .flags = 0, \ } +#ifdef CONFIG_ARCH_USE_GNU_PROPERTY
That makes sense to me.
+#endif static inline int arch_elf_pt_proc(void *ehdr, void *phdr, struct file *f, bool is_interp,
Though presumably this is all eventually dead code too?
I'll let you pick one ;), I don't have a strong preference either way.