On Thu, Jul 24, 2014 at 09:40:41PM +0200, Philipp Zabel wrote:
Hi,
Am Donnerstag, den 24.07.2014, 22:48 +0800 schrieb Shawn Guo:
Hi Philipp,
On Thu, Jul 24, 2014 at 03:31:21AM -0700, Olof's autobuilder wrote:
Here are the build results from automated periodic testing.
[...]
arm.imx_v4_v5_defconfig: drivers/media/platform/coda.c:3782:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
It seems the error is caused by your commit 8f45284c4ed7 ([media] coda: add reset control support). Can you please check?
On i.MX27 there is no reason to expect CONFIG_RESET_CONTROLLER to be enabled, so I should have used devm_reset_control_get_optional. Here is a fix:
Has this fix been submitted or queued on media tree? The error is still seen on the latest next-20140801.
Shawn
-- 8< -- Subject: [PATCH] [media] coda: fix build error by making reset control optional
make reset control optional for i.MX27
The patch "[media] coda: add reset control support" introduced a build failure if CONFIG_RESET_CONTROLLER is disabled:
drivers/media/platform/coda.c:3734:2: error: implicit declaration of function 'devm_reset_control_get'Since not all SoCs containing CODA VPUs do have a system reset controller, use devm_reset_control_get_optional to make it optional.
Reported-by: Shawn Guo shawn.guo@linaro.org Reported-by: Olof's autobuilder build@lixom.net Reported-by: kbuild test robot fengguang.wu@intel.com Signed-off-by: Philipp Zabel p.zabel@pengutronix.de
drivers/media/platform/coda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 18758e2..ff61bb0 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -3779,10 +3779,10 @@ static int coda_probe(struct platform_device *pdev) return -ENOENT; }
- dev->rstc = devm_reset_control_get(&pdev->dev, NULL);
- dev->rstc = devm_reset_control_get_optional(&pdev->dev, NULL); if (IS_ERR(dev->rstc)) { ret = PTR_ERR(dev->rstc);
if (ret == -ENOENT) {
if (ret == -ENOENT || ret == -ENOSYS) { dev->rstc = NULL;-- 2.0.1
regards Philipp