On Mon, Mar 03, 2014 at 10:12:17AM -0600, Josh Cartwright wrote:
On Sat, Mar 01, 2014 at 08:12:58AM -0800, Andi Kleen wrote:
These seem to be caused by 128ea04a9885 (lto: Make asmlinkage __visible, 2014-02-08). Before that change asmlinkage was defined to nothing on ARM, but now it's __visible. Should we just drop asmlinkage here?
These functions are just called by the generic C interrupt layer right? Yes should just drop asmlinkage. It doesn't make any sense to mark functions that only called from C asmlinkage.
On ARM[64], these functions are called from assembly indirectly through the 'handle_arch_irq' function pointer, so I don't think it makes sense to drop 'asmlinkage'.
If building with a C++ compiler:
asmlinkage = extern "C"
static asmlinkage = static extern "C"
That doesn't quite make much sense when you think about it - even with the existing definition in current mainline kernels.