Mark Brown broonie@kernel.org writes:
On Thu, Nov 26, 2015 at 09:06:25AM +0000, Build bot for Mark Brown wrote:
Today's -next fails to build an arm64 allmodconfig due to:
arm64-allmodconfig ../drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of 'ath10k_thermal_event_temperature' ../drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of 'ath10k_thermal_set_throttling' ../drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of 'ath10k_thermal_register' ../drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of 'ath10k_thermal_unregister'
This is happening because there are stub functions provided in the driver's thermal.h for !THERMAL cases but these are guarded by an #ifdef not an #if and so fails to do the right thing if the thermal code is built as a module.
Thanks, I'll apply the fix soon. Just wait for comments from others first.
It looks like this was somehow triggered as part of the reorganisation of the WiFi directory structure.
This is surprising and also worrying, any ideas why? It would be good to understand the root cause in case there's a bug in wireless drivers directory reorganisation.