On Wednesday 10 September 2014 06:22:05 Build bot for Mark Brown wrote:
Tree/Branch: master Git describe: v3.17-rc4-158-ge874a5f Commit: e874a5fe3e Merge branch 'for-next-3.17' of git://git.samba.org/sfrench/cifs-2.6
Build Time: 29 min 41 sec
Passed: 6 / 6 (100.00 %) Failed: 0 / 6 ( 0.00 %)
Errors: 0 Warnings: 28 Section Mismatches: 0
defconfigs with issues (other than build errors): 2 warnings 0 mismatches : arm64-allnoconfig 18 warnings 0 mismatches : arm-allmodconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 7 warnings 0 mismatches : arm64-allmodconfig
Seriously, is that all?
Are you filtering out old warnings to just see regressions or is that all that is left to fix now?
arm64-allnoconfig : PASS, 0 errors, 2 warnings, 0 section mismatches
Warnings: ../drivers/irqchip/irq-gic-v3.c:132:13: warning: 'gic_write_sgi1r' defined but not used [-Wunused-function] ../drivers/irqchip/irq-gic-v3.c:203:12: warning: 'gic_peek_irq' defined but not used [-Wunused-function]
I haven't seen this one before, should be easy to fix.
arm-allmodconfig : PASS, 0 errors, 18 warnings, 0 section mismatches
Warnings: ../arch/arm/mach-cns3xxx/pcie.c:311:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
I guess we should try to find a new cns3xxx maintainer, Anton no longer has access to the hardware as far as I know, and the patch I made for this needs to be tested.
../net/rds/iw_rdma.c:200:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../drivers/isdn/hardware/mISDN/w6692.c:1181:75: warning: unsupported argument to '__builtin_return_address' ../drivers/isdn/hardware/mISDN/mISDNipac.c:759:75: warning: unsupported argument to '__builtin_return_address'
I have a patch for these.
../drivers/infiniband/hw/mlx5/mem.c:71:143: warning: comparison of distinct pointer types lacks a cast
trivial fix, should submit:
@@ -68,7 +68,7 @@ void mlx5_ib_cont_pages(struct ib_umem *umem, u64 addr, int *count, int *shift, for (k = 0; k < len; k++) { if (!(i & mask)) { tmp = (unsigned long)pfn; - m = min(m, find_first_bit(&tmp, sizeof(tmp))); + m = min_t(unsigned long, m, find_first_bit(&tmp, sizeof(tmp))); skip = 1 << m; mask = skip - 1; base = pfn;
../drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1192 bytes is larger than 1024 bytes [-Wframe-larger-than=]
I tried fixing this before, but couldn't come up with a nice solution.
../drivers/net/ethernet/amd/nmclan_cs.c:624:3: warning: 'pcmcia_request_exclusive_irq' is deprecated (declared at ../include/pcmcia/ds.h:213) [-Wdeprecated-declarations]
A few people have tried to work around this one in the past, it comes down to proving that mace_interrupt() is safe when called on a shared interrupt line, and then replacing pcmcia_request_exclusive_irq() with pcmcia_request_irq, and finally removing pcmcia_request_exclusive_irq() from the kernel, as this is the last user.
I think it's safe, but I'm not totally convinced.
../drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp] ../drivers/scsi/ips.c:210:2: warning: #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" [-Wcpp]
Those should not be hard to fix at all, I made patches for them that I need to submit.
../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:303:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:307:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:467:46: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
trivial fix:
- param = (u64)mlx5_qp_state_str(be32_to_cpu(ctx->flags) >> 28); + param = (unsigned long)mlx5_qp_state_str(be32_to_cpu(ctx->flags) >> 28);
../drivers/tty/isicom.c:1058:240: warning: integer overflow in expression [-Woverflow]
trivial fix:
- outw((length & 0xff00), base); + outw((length & 0xff00u), base);
../drivers/staging/rtl8192ee/pci.c:885:5: warning: format '%d' expects argument of type 'int', but argument 2 has type 'sk_buff_data_t' [-Wformat=] ../drivers/staging/rtl8192ee/pci.c:885:5: warning: format '%d' expects argument of type 'int', but argument 3 has type 'sk_buff_data_t' [-Wformat=]
trivial fix: - pr_info("skb->end (%d) - skb->tail (%d) > len (%d)\n", - skb->end, skb->tail, len); + pr_info("skb->end (%d) - skb->tail = %d > len (%d)\n", + skb_end_offset(skb), skb->end - skb->tail, len);
../drivers/staging/dgnc/dgnc_tty.c:572:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
We can probably just make TMPBUFLEN slightly smaller and review the code to ensure it will still work.
../drivers/staging/vt6655/device_main.c:3091:1: warning: the frame size of 1296 bytes is larger than 1024 bytes [-Wframe-larger-than=]
I have a nontrivial patch
../drivers/staging/wlan-ng/prism2fw.c:792:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
DMA to stack is broken anyway, need to fix by using kmalloc.
arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches
Warnings: ../drivers/pci/host/pci-mvebu.c:887:39: warning: 'rtype' may be used uninitialized in this function [-Wmaybe-uninitialized]
Multiple fixes have been posted.
Arnd