linaro-toolchain

linaro-toolchain@lists.linaro.org

6 participants
5587 discussions

by Andrew Stubbs

Hi All, As you know, the compiler currently has difficulties choosing between whether to do an operation in NEON or not. As I see it there are three problems: 1. Simply, is it profitable? NEON can do many DImode operations in one or two instructions where 2 to 10 normal ARM/Thumb instructions would be required (not to mention the added register pressure), but there is a cost associated with moving the inputs to NEON, and the results back. If the data can stay in NEON for more than one operation, then that's even better. If the data must be loaded from memory, and the result stored back to memory, then it's only a question of whether the register space is available, or not. Currently these decisions are made in the IRA/reload passes. 2. Values that originate in hard-registers stay there. This applies to function parameters, mostly, but also in general where the result of an operation is allocated first. If there is no instruction that can use the value there then the value is 'reloaded' to a more suitable register. If there is any alternative that avoids the move then the register allocator will use it, regardless of the relatives costs of the other alternatives. This problem is reduced where an operation and move can happen in one instruction, but NEON instructions do not do this much. We can write insns that appear to do it, but these output multiple instructions (see my recent core-SI=>NEON-DI extend patch). 3. It all happens too late. The decision whether to use NEON or not is not made until register allocation time. Naturally this means that most of the optimization passes are already completed. Part of the problem is that the operation almost certainly needs splitting (into whatever form was chosen) and this might not be straight forward, post-reload. (However, the split1 pass is already quite late, so perhaps this isn't such a big deal.) Another part of the problem is that passes such as the two lower-subreg passes make assumptions about the register width which are not accurate if the operation is to end up in NEON. There are other, lesser problems, such as it being hard to adjust the costs for different cores (A8 in particular) and the cost of generating an immediate constant can't be known until it's known what instructions will be used to generate it. These problems are not specific to NEON, of course. I believe IWMMXT suffers from the same issues. Likewise the C6X port, and also the i386 MMX to some degree. Anything that has instructions that only operate on a subset of registers, basically. So, Bernd has suggested an outline of a solution. I've quizzed him on this, added a few of my own ideas, and probably a good selection of misunderstandings, bad assumptions, and general cock ups, and come up with something I can write here for comment. I can post something to upstream later if it doesn't get totally shot down now. The basic idea is that we add a new RTL optimization pass (or two) that assesses the usage of pseudo registers, and makes recommendations about what register class each should end up in, if there's a choice. These recommendations would then be used by later passes to get a better use of NEON. I might call this the "prealloc" pass, or something. Firstly, for each pseudo-register in a function, the pass would look at the insn constraints for each "def" and "use", and see how the registers relate to one another. This might determine things like "if rN is in class A, then rM must be also in class A". E.g. if you have two registers with constraints like this: "r,w" "r,w" .. (and 'r' and 'w' do not overlap) then you know that there is a choice between one mode or another, whereas this: "r,w,r,w" "r,w,w,r" .. would impose no restrictions and we can carry on as normal. Having done that we'd end up with sets of pseudo-registers that must make a decision one way or the other, and we'd know where the operations are that would force a move from one class to the other. There's a fair amount of handwavium in there at present, because I've not worked out what to do with overlapping register classes (think VFP_LO_REGS) and all the other complications. Secondly, the pass would consider the costs of each alternative, and store a recommended register class for each pseudo-register in a table somewhere. It would also create new pseudos and insert extra move instructions at the register file boundaries where an existing register would have had split recommendations (this would solve problem 2 above). Again, there's handwavium in "consider the costs". This isn't too hard for size-optimization (assuming the "length" attributes on the insn is correct), but more difficult for speed optimization. Factors to include would be the move costs (here the A8 issues would be addresses) and the relative speeds of the operations in both alternatives. Also, the various possible transition points between the two modes might need some comparisons. Thirdly, the subsequent passes would need to be modified, as would some of the back-end bits and bobs. 1. Lower-subreg would need to detect 'word_mode' based on the recommended register class, not the global value. 2. The many split patterns in the machine description could be adjusted so that, instead of simply conditionalizing on "reload_completed", they split at split1 if that's the best option. (Maybe it would be profitable to insert a new, earlier split pass specifically for this case to take advantage of the likes of combine? I mean, ideally this decision would have been made at expand time, if it could have been?) It might be useful to *not* split too soon, in some cases, so that the register allocator can still make the final decision based on register pressure, and whatever other factors it uses. Of course, the existing late-split option would need to be retained in case the prealloc pass is disabled, in any case. 3. Various passes would have to be taught not to remove seemingly superfluous register moves where they actually move between register classes. 4. Pretty much nothing would need doing to register allocation! The extra moves should make allocation a register pressure management issue, rather than a question of making it work. DImode operations preallocated to core-registers may already have been lowered, one way or the other (by split1) so there's no decision left there, and if no lowering was necessary then that option ought to be obviously cheaper. If it insists on making contrary decisions then it can be taught to use the recommendation as a hint, perhaps? In specific problem cases it would also be possible to use instruction attributes to disable (or strongly discourage) certain alternatives based on the recommended class. 5. The existing 'onlya8'/'nota8' nonsense can be removed. 6. The register move cost can be set correctly for each core. 7. If a constant is destined for a NEON register, most likely, arm_gen_constant can use the NEON immediate rules to determine the cost. There's clearly a lot of thought that needs to go into the pseudo-register scan and decision making logic, but the whole thing doesn't look like it'll boil down to very much code in the end. There's also the question of where to put the pass? Too early and you'd need to put a second one in to reassess the much changed RTL later, and too late and lower-subreg won't be able to use it. It's possible that it might be better to treat it more like the data-flow analysis where it's not actually a stand-alone pass, but rather a tool other passes can use? That might depend how computationally expensive it is. Any thoughts anyone? Might something like this actually work? Would it be worth spending the time on this? Andrew

13 years, 3 months

lp:gcc/4.7

by Andrew Stubbs

Hi Matthias, GCC 4.7.0 has branched upstream. SVN trunk is now 4.8. Could you please create lp:gcc/4.7 from the release branch. Thanks Andrew

13 years, 3 months

Please pull upstream rev. 184603 into gcc-linaro 4.7

by Bernhard Rosenkränzer

Hi, 184603 fixes an ICE we're running into with Android test builds. Please pull it in ASAP so I don't have to mess with the CFLAGS as a workaround. ttyl bero

13 years, 3 months

Cross toolchain for lucid updated

by Marcin Juszkiewicz

Linaro cross toolchain backport PPA [1] got updated to recent Ubuntu 12.04 versions: - gcc 4.5.3 - gcc 4.6.2 - binutils 2.22 - eglibc 2.15 - linux 3.2 I tested both compiler versions against few packages, U-Boot and Linux 2.6.32. Those packages may also work under Ubuntu 10.10 'maverick' and 11.04 'natty' but it was not tested. Users of Ubuntu 11.10 'oneiric' may install libmpfr1ldbl package [2] and then use 'lucid' repository to install cross compiler while I will prepare packages for their version of Ubuntu. Please report any problems with those backported packages in launchpad [3][4][5]. 1. https://launchpad.net/~linaro-maintainers/+archive/toolchain 2. http://packages.ubuntu.com/lucid/libmpfr1ldbl 3. https://launchpad.net/ubuntu/+source/gcc-4.5-armel-cross/+bugs 4. https://launchpad.net/ubuntu/+source/gcc-4.5-armel-cross/+bugs 5. https://launchpad.net/ubuntu/+source/armel-cross-toolchain-base/+bugs

13 years, 3 months

Status call number is unchanged

by Michael Hope

No news yet on the new conference call numbers. Let's see if the old numbers still work. -- Michael

13 years, 3 months

Spec 2000 broken?

by Andrew Stubbs

Hi Michael, I ran the benchmark tests on GCC 4.7, but the spec2000 run seems to have failed. This is both on the baseline, and on my patch. See here: http://ex.seabright.co.nz/benchmarks/gcc-linaro-4.7%2bbzr114968~ams-codesou… Andrew

13 years, 3 months

Saturated operations

by Michael Hope

Hi Ulrich. The saturated work you're doing at the moment - is it the saturated add/subtract QADD/QSUB/QDADD/QDSUB or the ARMv6 saturate-word-with-shift SSAT/USAT? I've updated the old blueprint and added a new one for SSAT/USAT: https://blueprints.launchpad.net/gcc-linaro/+spec/armv6-saturation-instruct… https://blueprints.launchpad.net/gcc-linaro/+spec/armv5-saturated-ops and was wondering which to put against your name. -- Michael

13 years, 3 months

Fleshing out the QEMU blueprints

by Michael Hope

Hi Peter, Rusty. I've fleshed out the KVM blueprints a bit more at: https://wiki.linaro.org/MichaelHope/Sandbox/Q1.12ToDo Notable is adding validation and de-PENDING a few things. I need to know the following things before talking to Validation and Platforms about things that are in their queue: * What's the host kernel? Christoffers, or a linux-linaro-kvm based off his plus work in progress? * What's the guest kernel? * Anything special that needs to be in the host rootfs outside qemu and libvirt? Do you have a host and guest kernel .config that I can pass on to Platforms? -- Michael

13 years, 3 months

[ACTIVITY] Feb 20 - Feb 24

by Thiago Jung Bauermann

Hi, GDB on Android: * Set up cross compiling environment using both the Android toolchain and the Linaro toolchain. * Tested Android and Mozilla GDB running as a native binary on the Linaro Android image on qemu. None of them were able to see all threads in a multi-threaded process. The same happens with a native binary on Android talking to a gdbserver on localhost. * I was able to produce an Android GDB 7.1.x binary which when running on an i386 host talking to the Android SDK emulator sees all threads. It is not able to generate a backtrace though. * Carnival holidays. -- []'s Thiago Jung Bauermann Linaro Toolchain Working Group

13 years, 3 months

[ACTIVITY] 20th - 24th February

by Andrew Stubbs

Investigated and produced and patch for bug lp936863. Continued work on 64-bit shifts. I updated my neon shifts patch twice: once to take -Os optimization into account, and once because I noticed that the CC clobbers were being retained even after they were known to be not required, and presumably this could be a bad thing. Posted a patch to improve SI->DImode sign- and zero-extends that also move values from core registers to neon registers. Wrote a patch to implement negation in neon register, albeit at the cost of a scratch register to hold the constant zero. This worked, but insisted on loading the zero from memory, despite the fact that NEON has a suitable instruction for loading zero. Attempted to get "vmov dN, #0" to work. The problem appears to be that DImode loads are handled by the VFP load pattern in vfp.md and that that doesn't seem to DTRT for integer constants. I've got as far as trying to figure out what it does do, but there's more to be done to get to the bottom of the problem. Tried to get the benchmarking going for 64-bit shifts. Unfortunately ursa1 has been experiencing outages. Michael has been trying to fix it, but so far I've not been able to run anything there. Instead, I've launched benchmark runs via Michael's normal test infrastructure. Hopefully this can replace the manual ones anyway. That would be more convenient.

13 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-toolchain