- linaro-toolchain - lists.linaro.org

[CI-NOTIFY]: TCWG Bisect tcwg_cross/gnu-master-arm-build_cross - Build # 61 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_cross/gnu-master-arm-build_cross. So far, this commit has regressed CI configurations: - tcwg_cross/gnu-master-arm-build_cross Culprit: <cut> commit 832f50be6c9c010e46180d14126bbb81f35e808c Author: Florian Weimer <fweimer(a)redhat.com> Date: Tue Jul 6 13:22:01 2021 +0200 elf: Call free from base namespace on error in dl-libc.c [BZ #27646] In dlerror_run, free corresponds to the local malloc in the namespace, but GLRO (dl_catch_error) uses the malloc from the base namespace. elf/tst-dlmopen-gethostbyname triggers this mismatch, but it does not crash, presumably because of a fastbin deallocation. Fixes commit c2059edce20c124d1a99f1a94cc52e83b77a917a ("elf: Use _dl_catch_error from base namespace in dl-libc.c [BZ #27646]") and commit b2964eb1d9a6b8ab1250e8a881cf406182da5875 ("dlfcn: Failures after dlmopen should not terminate process [BZ #24772]"). </cut> Results regressed to (for first_bad == 832f50be6c9c010e46180d14126bbb81f35e808c) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # First few build errors in logs: # 00:00:11 ./sysdeps/arm/sysdep.h:49:4: error: #error unknown arm architecture # 00:00:11 ./sysdeps/arm/sysdep.h:53:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:56:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:59:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:62:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:49:4: error: #error unknown arm architecture # 00:00:11 ./sysdeps/arm/sysdep.h:53:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:56:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:59:5: error: is not defined, evaluates to 0 [-Werror=undef] # 00:00:11 ./sysdeps/arm/sysdep.h:62:5: error: is not defined, evaluates to 0 [-Werror=undef] from (for last_good == c8935581de4ff931bc32fb03da5d87f0ee2378a1) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # build_abe glibc: 4 # build_abe stage2: 5 # build_abe qemu: 6 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… Build top page/logs: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/ Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-832f50be6c9c010e46180d14126bbb81f35e808c cd investigate-glibc-832f50be6c9c010e46180d14126bbb81f35e808c git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach 832f50be6c9c010e46180d14126bbb81f35e808c ../artifacts/test.sh # Reproduce last_good build git checkout --detach c8935581de4ff931bc32fb03da5d87f0ee2378a1 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/a… Build log: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/61/c… Full commit (up to 1000 lines): <cut> commit 832f50be6c9c010e46180d14126bbb81f35e808c Author: Florian Weimer <fweimer(a)redhat.com> Date: Tue Jul 6 13:22:01 2021 +0200 elf: Call free from base namespace on error in dl-libc.c [BZ #27646] In dlerror_run, free corresponds to the local malloc in the namespace, but GLRO (dl_catch_error) uses the malloc from the base namespace. elf/tst-dlmopen-gethostbyname triggers this mismatch, but it does not crash, presumably because of a fastbin deallocation. Fixes commit c2059edce20c124d1a99f1a94cc52e83b77a917a ("elf: Use _dl_catch_error from base namespace in dl-libc.c [BZ #27646]") and commit b2964eb1d9a6b8ab1250e8a881cf406182da5875 ("dlfcn: Failures after dlmopen should not terminate process [BZ #24772]"). --- elf/dl-libc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-libc.c b/elf/dl-libc.c index a49df22029..ba792e9589 100644 --- a/elf/dl-libc.c +++ b/elf/dl-libc.c @@ -48,7 +48,7 @@ dlerror_run (void (*operate) (void *), void *args) ?: last_errstring != NULL); if (result && malloced) - free ((char *) last_errstring); + GLRO (dl_error_free) ((char *) last_errstring); return result; } </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-release-aarch64-spec2k6-O3 - Build # 26 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-release-aarch64-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-release-aarch64-spec2k6-O3 Culprit: <cut> commit f30b3d2891cef9803badb3f85d739c0fcfafd585 Author: Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> Date: Tue Oct 1 17:10:01 2019 +0000 tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce after local CSE. 2019-10-01 Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> * tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce after local CSE. From-SVN: r276417 </cut> Results regressed to (for first_bad == f30b3d2891cef9803badb3f85d739c0fcfafd585) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3 -- artifacts/build-f30b3d2891cef9803badb3f85d739c0fcfafd585/results_id: 1 # 470.lbm,lbm_base.default regressed by 104 from (for last_good == 0b92cf305dcf34387a8e2564e55ca8948df3b47a) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3 -- artifacts/build-baseline/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/baseline-gnu-release-aarch64-spec2k6-O3/1273 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-release-aarch64-spec2k6-O3/1330 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-f30b3d2891cef9803badb3f85d739c0fcfafd585 cd investigate-gcc-f30b3d2891cef9803badb3f85d739c0fcfafd585 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach f30b3d2891cef9803badb3f85d739c0fcfafd585 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 0b92cf305dcf34387a8e2564e55ca8948df3b47a ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Full commit (up to 1000 lines): <cut> commit f30b3d2891cef9803badb3f85d739c0fcfafd585 Author: Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> Date: Tue Oct 1 17:10:01 2019 +0000 tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce after local CSE. 2019-10-01 Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> * tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce after local CSE. From-SVN: r276417 --- gcc/ChangeLog | 5 +++++ gcc/tree-if-conv.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b4c4292c299..08951d94f50 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2019-10-01 Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> + + * tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce + after local CSE. + 2019-10-01 Jan Hubicka <hubicka(a)ucw.cz> * doc/invoke.texi (early-inlining-insns-O2): Document. diff --git a/gcc/tree-if-conv.c b/gcc/tree-if-conv.c index 40ad4c5947a..822aae5b83f 100644 --- a/gcc/tree-if-conv.c +++ b/gcc/tree-if-conv.c @@ -3060,9 +3060,6 @@ tree_if_conversion (class loop *loop, vec<gimple *> *preds) on-the-fly. */ combine_blocks (loop); - /* Delete dead predicate computations. */ - ifcvt_local_dce (loop->header); - /* Perform local CSE, this esp. helps the vectorizer analysis if loads and stores are involved. CSE only the loop body, not the entry PHIs, those are to be kept in sync with the non-if-converted copy. @@ -3071,6 +3068,9 @@ tree_if_conversion (class loop *loop, vec<gimple *> *preds) bitmap_set_bit (exit_bbs, single_exit (loop)->dest->index); bitmap_set_bit (exit_bbs, loop->latch->index); todo |= do_rpo_vn (cfun, loop_preheader_edge (loop), exit_bbs); + + /* Delete dead predicate computations. */ + ifcvt_local_dce (loop->header); BITMAP_FREE (exit_bbs); todo |= TODO_cleanup_cfg; </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_cross/gnu-master-aarch64-build_cross - Build # 20 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_cross/gnu-master-aarch64-build_cross. So far, this commit has regressed CI configurations: - tcwg_cross/gnu-master-aarch64-build_cross Culprit: <cut> commit c8935581de4ff931bc32fb03da5d87f0ee2378a1 Author: Khem Raj <raj.khem(a)gmail.com> Date: Fri Jul 2 13:28:10 2021 -0700 linux: Check for null value msghdr struct before use This avoids crashes in libc when cmsg is null and refrencing msg structure when it is null Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Reviewed-by: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> </cut> Results regressed to (for first_bad == c8935581de4ff931bc32fb03da5d87f0ee2378a1) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # First few build errors in logs: # 00:00:14 make[2]: *** [/home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:499: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/start.os] Error 1 # 00:00:14 make[2]: *** [/home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/crti.o] Error 1 # 00:00:14 make[2]: *** [/home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/start.o] Error 1 # 00:00:14 make[2]: *** [/home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:483: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/crtn.o] Error 1 # 00:00:14 make[2]: *** [../o-iterator.mk:9: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/check_fds.os] Error 1 # 00:00:14 make[2]: *** [../o-iterator.mk:9: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/check_fds.o] Error 1 # 00:00:14 ../sysdeps/aarch64/nptl/tls.h:91:19: error: ‘__builtin_thread_pointer’ is not supported on this target # 00:00:14 make[2]: *** [/home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/sysd-rules:485: /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/builds/x86_64-pc-linux-gnu/aarch64-linux-gnu/glibc-glibc.git~master/csu/libc-tls.o] Error 1 # 00:00:14 ../sysdeps/unix/sysv/linux/aarch64/sysdep.h:190:17: error: invalid register name for ‘_x0’ # 00:00:14 ../sysdeps/unix/sysv/linux/aarch64/sysdep.h:174:22: error: invalid register name for ‘_x8’ from (for last_good == 91fb0f17a5779da6e7877eb74119a83dbe8bf167) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # build_abe glibc: 4 # build_abe stage2: 5 # build_abe qemu: 6 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… Build top page/logs: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-c8935581de4ff931bc32fb03da5d87f0ee2378a1 cd investigate-glibc-c8935581de4ff931bc32fb03da5d87f0ee2378a1 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach c8935581de4ff931bc32fb03da5d87f0ee2378a1 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 91fb0f17a5779da6e7877eb74119a83dbe8bf167 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… Build log: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-aarch64-build_cross/… Full commit (up to 1000 lines): <cut> commit c8935581de4ff931bc32fb03da5d87f0ee2378a1 Author: Khem Raj <raj.khem(a)gmail.com> Date: Fri Jul 2 13:28:10 2021 -0700 linux: Check for null value msghdr struct before use This avoids crashes in libc when cmsg is null and refrencing msg structure when it is null Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Reviewed-by: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> --- sysdeps/unix/sysv/linux/convert_scm_timestamps.c | 2 ++ sysdeps/unix/sysv/linux/recvmsg.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c index d75a4618dd..5af71847f5 100644 --- a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c +++ b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c @@ -87,6 +87,8 @@ __convert_scm_timestamps (struct msghdr *msg, socklen_t msgsize) msg->msg_controllen += CMSG_SPACE (sizeof tvts); cmsg = CMSG_NXTHDR(msg, last); + if (cmsg == NULL) + return; cmsg->cmsg_level = SOL_SOCKET; cmsg->cmsg_type = type; cmsg->cmsg_len = CMSG_LEN (sizeof tvts); diff --git a/sysdeps/unix/sysv/linux/recvmsg.c b/sysdeps/unix/sysv/linux/recvmsg.c index a2a600228b..57c3cf7e36 100644 --- a/sysdeps/unix/sysv/linux/recvmsg.c +++ b/sysdeps/unix/sysv/linux/recvmsg.c @@ -25,7 +25,7 @@ __libc_recvmsg (int fd, struct msghdr *msg, int flags) { ssize_t r; #ifndef __ASSUME_TIME64_SYSCALLS - socklen_t orig_controllen = msg->msg_controllen; + socklen_t orig_controllen = msg != NULL ? msg->msg_controllen : 0; #endif #ifdef __ASSUME_RECVMSG_SYSCALL @@ -35,7 +35,7 @@ __libc_recvmsg (int fd, struct msghdr *msg, int flags) #endif #ifndef __ASSUME_TIME64_SYSCALLS - if (r >= 0) + if (r >= 0 && orig_controllen != 0) __convert_scm_timestamps (msg, orig_controllen); #endif </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_cross/gnu-master-arm-build_cross - Build # 60 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_cross/gnu-master-arm-build_cross. So far, this commit has regressed CI configurations: - tcwg_cross/gnu-master-arm-build_cross Culprit: <cut> commit a110855667782dac7b674d3e328b253b3b3c919b Author: Martin Sebor <msebor(a)redhat.com> Date: Wed Jul 7 14:05:25 2021 -0600 Correct handling of variable offset minus constant in -Warray-bounds [PR100137] Resolves: PR tree-optimization/100137 - -Warray-bounds false positive on varying offset plus negative PR tree-optimization/99121 - ICE in -Warray-bounds on a multidimensional PR tree-optimization/97027 - missing warning on buffer overflow storing a larger scalar into a smaller array gcc/ChangeLog: PR tree-optimization/100137 PR tree-optimization/99121 PR tree-optimization/97027 * builtins.c (access_ref::access_ref): Also set offmax. (access_ref::offset_in_range): Define new function. (access_ref::add_offset): Set offmax. (access_ref::inform_access): Handle access_none. (handle_mem_ref): Clear ostype. (compute_objsize_r): Handle ASSERT_EXPR. * builtins.h (struct access_ref): Add offmax member. * gimple-array-bounds.cc (array_bounds_checker::check_mem_ref): Use compute_objsize() and simplify. gcc/testsuite/ChangeLog: PR tree-optimization/100137 PR tree-optimization/99121 PR tree-optimization/97027 * c-c++-common/Warray-bounds-3.c: Remove xfail * c-c++-common/Warray-bounds-4.c: Add an expected warning. * c-c++-common/Warray-bounds-9.c: New test. * c-c++-common/Warray-bounds-10.c: New test. * g++.dg/asan/asan_test.C: Suppress expected warnings. * g++.dg/pr95768.C: Same. * g++.dg/warn/Warray-bounds-10.C: Adjust text of expected messages. * g++.dg/warn/Warray-bounds-11.C: Same. * g++.dg/warn/Warray-bounds-12.C: Same. * g++.dg/warn/Warray-bounds-13.C: Same. * g++.dg/warn/Warray-bounds-17.C: Same. * g++.dg/warn/Warray-bounds-20.C: Same. * gcc.dg/Warray-bounds-29.c: Same. * gcc.dg/Warray-bounds-30.c: Add xfail. * gcc.dg/Warray-bounds-31.c: Adjust text of expected messages. * gcc.dg/Warray-bounds-32.c: Same. * gcc.dg/Warray-bounds-52.c: Same. * gcc.dg/Warray-bounds-53.c: Same. * gcc.dg/Warray-bounds-58.c: Remove xfail. * gcc.dg/Warray-bounds-63.c: Adjust text of expected messages. * gcc.dg/Warray-bounds-66.c: Same. * gcc.dg/Warray-bounds-69.c: Same. * gcc.dg/Wstringop-overflow-34.c: Same. * gcc.dg/Wstringop-overflow-47.c: Same. * gcc.dg/Wstringop-overflow-61.c: Same. * gcc.dg/Warray-bounds-77.c: New test. * gcc.dg/Warray-bounds-78.c: New test. * gcc.dg/Warray-bounds-79.c: New test. </cut> Results regressed to (for first_bad == a110855667782dac7b674d3e328b253b3b3c919b) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # build_abe glibc: 4 # First few build errors in logs: # 00:04:02 cc1: error: no include path in which to search for stdc-predef.h # 00:04:53 /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libatomic/config/linux/arm/host-config.h:42:34: error: array subscript 0 is outside array bounds of ‘unsigned int[0]’ [-Werror=array-bounds] # 00:04:53 /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libatomic/config/linux/arm/host-config.h:42:34: error: array subscript 0 is outside array bounds of ‘unsigned int[0]’ [-Werror=array-bounds] # 00:04:53 /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libatomic/config/linux/arm/host-config.h:42:34: error: array subscript 0 is outside array bounds of ‘unsigned int[0]’ [-Werror=array-bounds] # 00:04:53 make[4]: *** [Makefile:586: glfree.lo] Error 1 # 00:04:53 /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libatomic/config/linux/arm/host-config.h:42:34: error: array subscript 0 is outside array bounds of ‘unsigned int[0]’ [-Werror=array-bounds] # 00:04:53 make[4]: *** [Makefile:586: gstore.lo] Error 1 # 00:04:54 make[4]: *** [Makefile:586: gcas.lo] Error 1 # 00:04:54 make[4]: *** [Makefile:586: gexch.lo] Error 1 # 00:04:54 make[3]: *** [Makefile:608: all-recursive] Error 1 from (for last_good == 6278065af07634278ba30029d92a82b089969baa) # reset_artifacts: -10 # true: 0 # build_abe binutils: 1 # build_abe stage1: 2 # build_abe linux: 3 # build_abe glibc: 4 # build_abe stage2: 5 # build_abe qemu: 6 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… Build top page/logs: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-a110855667782dac7b674d3e328b253b3b3c919b cd investigate-gcc-a110855667782dac7b674d3e328b253b3b3c919b git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach a110855667782dac7b674d3e328b253b3b3c919b ../artifacts/test.sh # Reproduce last_good build git checkout --detach 6278065af07634278ba30029d92a82b089969baa ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/a… Build log: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-master-arm-build_cross/60/c… Full commit (up to 1000 lines): <cut> commit a110855667782dac7b674d3e328b253b3b3c919b Author: Martin Sebor <msebor(a)redhat.com> Date: Wed Jul 7 14:05:25 2021 -0600 Correct handling of variable offset minus constant in -Warray-bounds [PR100137] Resolves: PR tree-optimization/100137 - -Warray-bounds false positive on varying offset plus negative PR tree-optimization/99121 - ICE in -Warray-bounds on a multidimensional PR tree-optimization/97027 - missing warning on buffer overflow storing a larger scalar into a smaller array gcc/ChangeLog: PR tree-optimization/100137 PR tree-optimization/99121 PR tree-optimization/97027 * builtins.c (access_ref::access_ref): Also set offmax. (access_ref::offset_in_range): Define new function. (access_ref::add_offset): Set offmax. (access_ref::inform_access): Handle access_none. (handle_mem_ref): Clear ostype. (compute_objsize_r): Handle ASSERT_EXPR. * builtins.h (struct access_ref): Add offmax member. * gimple-array-bounds.cc (array_bounds_checker::check_mem_ref): Use compute_objsize() and simplify. gcc/testsuite/ChangeLog: PR tree-optimization/100137 PR tree-optimization/99121 PR tree-optimization/97027 * c-c++-common/Warray-bounds-3.c: Remove xfail * c-c++-common/Warray-bounds-4.c: Add an expected warning. * c-c++-common/Warray-bounds-9.c: New test. * c-c++-common/Warray-bounds-10.c: New test. * g++.dg/asan/asan_test.C: Suppress expected warnings. * g++.dg/pr95768.C: Same. * g++.dg/warn/Warray-bounds-10.C: Adjust text of expected messages. * g++.dg/warn/Warray-bounds-11.C: Same. * g++.dg/warn/Warray-bounds-12.C: Same. * g++.dg/warn/Warray-bounds-13.C: Same. * g++.dg/warn/Warray-bounds-17.C: Same. * g++.dg/warn/Warray-bounds-20.C: Same. * gcc.dg/Warray-bounds-29.c: Same. * gcc.dg/Warray-bounds-30.c: Add xfail. * gcc.dg/Warray-bounds-31.c: Adjust text of expected messages. * gcc.dg/Warray-bounds-32.c: Same. * gcc.dg/Warray-bounds-52.c: Same. * gcc.dg/Warray-bounds-53.c: Same. * gcc.dg/Warray-bounds-58.c: Remove xfail. * gcc.dg/Warray-bounds-63.c: Adjust text of expected messages. * gcc.dg/Warray-bounds-66.c: Same. * gcc.dg/Warray-bounds-69.c: Same. * gcc.dg/Wstringop-overflow-34.c: Same. * gcc.dg/Wstringop-overflow-47.c: Same. * gcc.dg/Wstringop-overflow-61.c: Same. * gcc.dg/Warray-bounds-77.c: New test. * gcc.dg/Warray-bounds-78.c: New test. * gcc.dg/Warray-bounds-79.c: New test. --- gcc/builtins.c | 69 +++++- gcc/builtins.h | 5 + gcc/gimple-array-bounds.cc | 336 ++++---------------------- gcc/testsuite/c-c++-common/Warray-bounds-10.c | 114 +++++++++ gcc/testsuite/c-c++-common/Warray-bounds-3.c | 4 +- gcc/testsuite/c-c++-common/Warray-bounds-4.c | 12 +- gcc/testsuite/c-c++-common/Warray-bounds-9.c | 144 +++++++++++ gcc/testsuite/g++.dg/asan/asan_test.C | 2 +- gcc/testsuite/g++.dg/pr95768.C | 2 +- gcc/testsuite/g++.dg/warn/Warray-bounds-10.C | 4 +- gcc/testsuite/g++.dg/warn/Warray-bounds-11.C | 4 +- gcc/testsuite/g++.dg/warn/Warray-bounds-12.C | 4 +- gcc/testsuite/g++.dg/warn/Warray-bounds-13.C | 4 +- gcc/testsuite/g++.dg/warn/Warray-bounds-17.C | 2 +- gcc/testsuite/g++.dg/warn/Warray-bounds-20.C | 8 +- gcc/testsuite/gcc.dg/Warray-bounds-29.c | 22 +- gcc/testsuite/gcc.dg/Warray-bounds-30.c | 2 +- gcc/testsuite/gcc.dg/Warray-bounds-31.c | 8 +- gcc/testsuite/gcc.dg/Warray-bounds-32.c | 26 +- gcc/testsuite/gcc.dg/Warray-bounds-52.c | 6 +- gcc/testsuite/gcc.dg/Warray-bounds-53.c | 6 +- gcc/testsuite/gcc.dg/Warray-bounds-58.c | 2 +- gcc/testsuite/gcc.dg/Warray-bounds-63.c | 6 +- gcc/testsuite/gcc.dg/Warray-bounds-66.c | 12 +- gcc/testsuite/gcc.dg/Warray-bounds-69.c | 2 +- gcc/testsuite/gcc.dg/Warray-bounds-77.c | 135 +++++++++++ gcc/testsuite/gcc.dg/Warray-bounds-78.c | 109 +++++++++ gcc/testsuite/gcc.dg/Warray-bounds-79.c | 112 +++++++++ gcc/testsuite/gcc.dg/Wstringop-overflow-34.c | 8 +- gcc/testsuite/gcc.dg/Wstringop-overflow-47.c | 14 +- gcc/testsuite/gcc.dg/Wstringop-overflow-61.c | 4 +- 31 files changed, 817 insertions(+), 371 deletions(-) diff --git a/gcc/builtins.c b/gcc/builtins.c index e52fe4291c8..39ab139b7e1 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -206,6 +206,7 @@ access_ref::access_ref (tree bound /* = NULL_TREE */, { /* Set to valid. */ offrng[0] = offrng[1] = 0; + offmax[0] = offmax[1] = 0; /* Invalidate. */ sizrng[0] = sizrng[1] = -1; @@ -457,6 +458,21 @@ access_ref::size_remaining (offset_int *pmin /* = NULL */) const return sizrng[1] - or0; } +/* Return true if the offset and object size are in range for SIZE. */ + +bool +access_ref::offset_in_range (const offset_int &size) const +{ + if (size_remaining () < size) + return false; + + if (base0) + return offmax[0] >= 0 && offmax[1] <= sizrng[1]; + + offset_int maxoff = wi::to_offset (TYPE_MAX_VALUE (ptrdiff_type_node)); + return offmax[0] > -maxoff && offmax[1] < maxoff; +} + /* Add the range [MIN, MAX] to the offset range. For known objects (with zero-based offsets) at least one of whose offset's bounds is in range, constrain the other (or both) to the bounds of the object (i.e., zero @@ -493,6 +509,8 @@ void access_ref::add_offset (const offset_int &min, const offset_int &max) if (max >= 0) { offrng[0] = 0; + if (offmax[0] > 0) + offmax[0] = 0; return; } @@ -509,6 +527,12 @@ void access_ref::add_offset (const offset_int &min, const offset_int &max) offrng[0] = 0; } + /* Set the minimum and maximmum computed so far. */ + if (offrng[1] < 0 && offrng[1] < offmax[0]) + offmax[0] = offrng[1]; + if (offrng[0] > 0 && offrng[0] > offmax[1]) + offmax[1] = offrng[0]; + if (!base0) return; @@ -4571,23 +4595,46 @@ access_ref::inform_access (access_mode mode) const return; } + if (mode == access_read_only) + { + if (allocfn == NULL_TREE) + { + if (*offstr) + inform (loc, "at offset %s into source object %qE of size %s", + offstr, ref, sizestr); + else + inform (loc, "source object %qE of size %s", ref, sizestr); + + return; + } + + if (*offstr) + inform (loc, + "at offset %s into source object of size %s allocated by %qE", + offstr, sizestr, allocfn); + else + inform (loc, "source object of size %s allocated by %qE", + sizestr, allocfn); + return; + } + if (allocfn == NULL_TREE) { if (*offstr) - inform (loc, "at offset %s into source object %qE of size %s", + inform (loc, "at offset %s into object %qE of size %s", offstr, ref, sizestr); else - inform (loc, "source object %qE of size %s", ref, sizestr); + inform (loc, "object %qE of size %s", ref, sizestr); return; } if (*offstr) inform (loc, - "at offset %s into source object of size %s allocated by %qE", + "at offset %s into object of size %s allocated by %qE", offstr, sizestr, allocfn); else - inform (loc, "source object of size %s allocated by %qE", + inform (loc, "object of size %s allocated by %qE", sizestr, allocfn); } @@ -5433,16 +5480,16 @@ handle_mem_ref (tree mref, int ostype, access_ref *pref, if (VECTOR_TYPE_P (TREE_TYPE (mref))) { - /* Hack: Give up for MEM_REFs of vector types; those may be - synthesized from multiple assignments to consecutive data - members (see PR 93200 and 96963). + /* Hack: Handle MEM_REFs of vector types as those to complete + objects; those may be synthesized from multiple assignments + to consecutive data members (see PR 93200 and 96963). FIXME: Vectorized assignments should only be present after vectorization so this hack is only necessary after it has run and could be avoided in calls from prior passes (e.g., tree-ssa-strlen.c). FIXME: Deal with this more generally, e.g., by marking up such MEM_REFs at the time they're created. */ - return false; + ostype = 0; } tree mrefop = TREE_OPERAND (mref, 0); @@ -5796,6 +5843,12 @@ compute_objsize_r (tree ptr, int ostype, access_ref *pref, tree rhs = gimple_assign_rhs1 (stmt); + if (code == ASSERT_EXPR) + { + rhs = TREE_OPERAND (rhs, 0); + return compute_objsize_r (rhs, ostype, pref, snlim, qry); + } + if (code == POINTER_PLUS_EXPR && TREE_CODE (TREE_TYPE (rhs)) == POINTER_TYPE) { diff --git a/gcc/builtins.h b/gcc/builtins.h index e71f40c300a..a64ece3f1cd 100644 --- a/gcc/builtins.h +++ b/gcc/builtins.h @@ -222,6 +222,9 @@ struct access_ref argument to the minimum. */ offset_int size_remaining (offset_int * = NULL) const; +/* Return true if the offset and object size are in range for SIZE. */ + bool offset_in_range (const offset_int &) const; + /* Return true if *THIS is an access to a declared object. */ bool ref_declared () const { @@ -261,6 +264,8 @@ struct access_ref /* Range of byte offsets into and sizes of the object(s). */ offset_int offrng[2]; offset_int sizrng[2]; + /* The minimum and maximum offset computed. */ + offset_int offmax[2]; /* Range of the bound of the access: denotes that the access is at least BNDRNG[0] bytes but no more than BNDRNG[1]. For string functions the size of the actual access is diff --git a/gcc/gimple-array-bounds.cc b/gcc/gimple-array-bounds.cc index 13f08685f8f..83b8db9755e 100644 --- a/gcc/gimple-array-bounds.cc +++ b/gcc/gimple-array-bounds.cc @@ -414,269 +414,72 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, if (warning_suppressed_p (ref, OPT_Warray_bounds)) return false; - tree arg = TREE_OPERAND (ref, 0); - /* The constant and variable offset of the reference. */ - tree cstoff = TREE_OPERAND (ref, 1); - tree varoff = NULL_TREE; - - const offset_int maxobjsize = tree_to_shwi (max_object_size ()); - - /* The zero-based array or string constant bounds in bytes. Initially - set to [-MAXOBJSIZE - 1, MAXOBJSIZE] until a tighter bound is - determined. */ - offset_int arrbounds[2] = { -maxobjsize - 1, maxobjsize }; - - /* The minimum and maximum intermediate offset. For a reference - to be valid, not only does the final offset/subscript must be - in bounds but all intermediate offsets should be as well. - GCC may be able to deal gracefully with such out-of-bounds - offsets so the checking is only enabled at -Warray-bounds=2 - where it may help detect bugs in uses of the intermediate - offsets that could otherwise not be detectable. */ - offset_int ioff = wi::to_offset (fold_convert (ptrdiff_type_node, cstoff)); - offset_int extrema[2] = { 0, wi::abs (ioff) }; - - /* The range of the byte offset into the reference. */ - offset_int offrange[2] = { 0, 0 }; - /* The statement used to allocate the array or null. */ gimple *alloc_stmt = NULL; /* For an allocation statement, the low bound of the size range. */ offset_int minbound = 0; + /* The type and size of the access. */ + tree axstype = TREE_TYPE (ref); + offset_int axssize = 0; + if (TREE_CODE (axstype) != UNION_TYPE) + if (tree access_size = TYPE_SIZE_UNIT (axstype)) + if (TREE_CODE (access_size) == INTEGER_CST) + axssize = wi::to_offset (access_size); - /* Determine the offsets and increment OFFRANGE for the bounds of each. - The loop computes the range of the final offset for expressions such - as (A + i0 + ... + iN)[CSTOFF] where i0 through iN are SSA_NAMEs in - some range. */ - const unsigned limit = param_ssa_name_def_chain_limit; - for (unsigned n = 0; TREE_CODE (arg) == SSA_NAME && n < limit; ++n) - { - gimple *def = SSA_NAME_DEF_STMT (arg); - if (is_gimple_call (def)) - { - /* Determine the byte size of the array from an allocation call. */ - wide_int sizrng[2]; - if (gimple_call_alloc_size (def, sizrng)) - { - arrbounds[0] = 0; - arrbounds[1] = offset_int::from (sizrng[1], UNSIGNED); - minbound = offset_int::from (sizrng[0], UNSIGNED); - alloc_stmt = def; - } - break; - } - - if (gimple_nop_p (def)) - { - /* For a function argument try to determine the byte size - of the array from the current function declaratation - (e.g., attribute access or related). */ - wide_int wr[2]; - tree ref = gimple_parm_array_size (arg, wr); - if (!ref) - break; - arrbounds[0] = offset_int::from (wr[0], UNSIGNED); - arrbounds[1] = offset_int::from (wr[1], UNSIGNED); - arg = ref; - break; - } - - if (!is_gimple_assign (def)) - break; - - tree_code code = gimple_assign_rhs_code (def); - if (code == POINTER_PLUS_EXPR) - { - arg = gimple_assign_rhs1 (def); - varoff = gimple_assign_rhs2 (def); - } - else if (code == ASSERT_EXPR) - { - arg = TREE_OPERAND (gimple_assign_rhs1 (def), 0); - continue; - } - else - return false; - - /* VAROFF should always be a SSA_NAME here (and not even - INTEGER_CST) but there's no point in taking chances. */ - if (TREE_CODE (varoff) != SSA_NAME) - break; - - const value_range* const vr = get_value_range (varoff); - if (!vr || vr->undefined_p () || vr->varying_p ()) - break; - - if (!vr->constant_p ()) - break; - - if (vr->kind () == VR_RANGE) - { - offset_int min - = wi::to_offset (fold_convert (ptrdiff_type_node, vr->min ())); - offset_int max - = wi::to_offset (fold_convert (ptrdiff_type_node, vr->max ())); - if (min < max) - { - offrange[0] += min; - offrange[1] += max; - } - else - { - /* When MIN >= MAX, the offset is effectively in a union - of two ranges: [-MAXOBJSIZE -1, MAX] and [MIN, MAXOBJSIZE]. - Since there is no way to represent such a range across - additions, conservatively add [-MAXOBJSIZE -1, MAXOBJSIZE] - to OFFRANGE. */ - offrange[0] += arrbounds[0]; - offrange[1] += arrbounds[1]; - } - } - else - { - /* For an anti-range, analogously to the above, conservatively - add [-MAXOBJSIZE -1, MAXOBJSIZE] to OFFRANGE. */ - offrange[0] += arrbounds[0]; - offrange[1] += arrbounds[1]; - } - - /* Keep track of the minimum and maximum offset. */ - if (offrange[1] < 0 && offrange[1] < extrema[0]) - extrema[0] = offrange[1]; - if (offrange[0] > 0 && offrange[0] > extrema[1]) - extrema[1] = offrange[0]; - - if (offrange[0] < arrbounds[0]) - offrange[0] = arrbounds[0]; - - if (offrange[1] > arrbounds[1]) - offrange[1] = arrbounds[1]; - } + access_ref aref; + if (!compute_objsize (ref, 1, &aref, ranges)) + return false; - tree reftype = NULL_TREE; - offset_int eltsize = -1; - if (arrbounds[0] >= 0) - { - /* The byte size of the array has already been determined above - based on a pointer ARG. Set ELTSIZE to the size of the type - it points to and REFTYPE to the array with the size, rounded - down as necessary. */ - reftype = TREE_TYPE (TREE_TYPE (arg)); - if (TREE_CODE (reftype) == ARRAY_TYPE) - reftype = TREE_TYPE (reftype); - if (tree refsize = TYPE_SIZE_UNIT (reftype)) - if (TREE_CODE (refsize) == INTEGER_CST) - eltsize = wi::to_offset (refsize); - - if (eltsize < 0) - return false; + if (aref.offset_in_range (axssize)) + return false; - offset_int nelts = arrbounds[1] / eltsize; - reftype = build_printable_array_type (reftype, nelts.to_uhwi ()); - } - else if (TREE_CODE (arg) == ADDR_EXPR) + if (TREE_CODE (aref.ref) == SSA_NAME) { - arg = TREE_OPERAND (arg, 0); - if (TREE_CODE (arg) != STRING_CST - && TREE_CODE (arg) != PARM_DECL - && TREE_CODE (arg) != VAR_DECL) - return false; - - /* The type of the object being referred to. It can be an array, - string literal, or a non-array type when the MEM_REF represents - a reference/subscript via a pointer to an object that is not - an element of an array. Incomplete types are excluded as well - because their size is not known. */ - reftype = TREE_TYPE (arg); - if (POINTER_TYPE_P (reftype) - || !COMPLETE_TYPE_P (reftype) - || TREE_CODE (TYPE_SIZE_UNIT (reftype)) != INTEGER_CST) - return false; - - /* Except in declared objects, references to trailing array members - of structs and union objects are excluded because MEM_REF doesn't - make it possible to identify the member where the reference - originated. */ - if (RECORD_OR_UNION_TYPE_P (reftype) - && (!VAR_P (arg) - || (DECL_EXTERNAL (arg) && array_at_struct_end_p (ref)))) - return false; - - /* FIXME: Should this be 1 for Fortran? */ - arrbounds[0] = 0; - - if (TREE_CODE (reftype) == ARRAY_TYPE) - { - /* Set to the size of the array element (and adjust below). */ - eltsize = wi::to_offset (TYPE_SIZE_UNIT (TREE_TYPE (reftype))); - /* Use log2 of size to convert the array byte size in to its - upper bound in elements. */ - const offset_int eltsizelog2 = wi::floor_log2 (eltsize); - if (tree dom = TYPE_DOMAIN (reftype)) - { - tree bnds[] = { TYPE_MIN_VALUE (dom), TYPE_MAX_VALUE (dom) }; - if (TREE_CODE (arg) == COMPONENT_REF) - { - offset_int size = maxobjsize; - if (tree fldsize = component_ref_size (arg)) - size = wi::to_offset (fldsize); - arrbounds[1] = wi::lrshift (size, eltsizelog2); - } - else if (array_at_struct_end_p (arg) || !bnds[0] || !bnds[1]) - arrbounds[1] = wi::lrshift (maxobjsize, eltsizelog2); - else - arrbounds[1] = (wi::to_offset (bnds[1]) - wi::to_offset (bnds[0]) - + 1) * eltsize; - } - else - arrbounds[1] = wi::lrshift (maxobjsize, eltsizelog2); - - /* Determine a tighter bound of the non-array element type. */ - tree eltype = TREE_TYPE (reftype); - while (TREE_CODE (eltype) == ARRAY_TYPE) - eltype = TREE_TYPE (eltype); - eltsize = wi::to_offset (TYPE_SIZE_UNIT (eltype)); - } - else + gimple *def = SSA_NAME_DEF_STMT (aref.ref); + if (is_gimple_call (def)) { - eltsize = 1; - tree size = TYPE_SIZE_UNIT (reftype); - if (VAR_P (arg)) - if (tree initsize = DECL_SIZE_UNIT (arg)) - if (tree_int_cst_lt (size, initsize)) - size = initsize; - - arrbounds[1] = wi::to_offset (size); + /* Save the allocation call and the low bound on the size. */ + alloc_stmt = def; + minbound = aref.sizrng[0]; } } - else - return false; - - offrange[0] += ioff; - offrange[1] += ioff; + + /* The range of the byte offset into the reference. Adjusted below. */ + offset_int offrange[2] = { aref.offrng[0], aref.offrng[1] }; + + /* The type of the referenced object. */ + tree reftype = TREE_TYPE (aref.ref); + /* The size of the referenced array element. */ + offset_int eltsize = 1; + /* The byte size of the array has already been determined above + based on a pointer ARG. Set ELTSIZE to the size of the type + it points to and REFTYPE to the array with the size, rounded + down as necessary. */ + if (POINTER_TYPE_P (reftype)) + reftype = TREE_TYPE (reftype); + if (TREE_CODE (reftype) == ARRAY_TYPE) + reftype = TREE_TYPE (reftype); + if (tree refsize = TYPE_SIZE_UNIT (reftype)) + if (TREE_CODE (refsize) == INTEGER_CST) + eltsize = wi::to_offset (refsize); + + const offset_int nelts = aref.sizrng[1] / eltsize; + reftype = build_printable_array_type (reftype, nelts.to_uhwi ()); /* Compute the more permissive upper bound when IGNORE_OFF_BY_ONE is set (when taking the address of the one-past-last element of an array) but always use the stricter bound in diagnostics. */ - offset_int ubound = arrbounds[1]; + offset_int ubound = aref.sizrng[1]; if (ignore_off_by_one) ubound += eltsize; - bool warned = false; /* Set if the lower bound of the subscript is out of bounds. */ - const bool lboob = (arrbounds[0] == arrbounds[1] + const bool lboob = (aref.sizrng[1] == 0 || offrange[0] >= ubound - || offrange[1] < arrbounds[0]); + || offrange[1] < 0); /* Set if only the upper bound of the subscript is out of bounds. This can happen when using a bigger type to index into an array of a smaller type, as is common with unsigned char. */ - tree axstype = TREE_TYPE (ref); - offset_int axssize = 0; - if (TREE_CODE (axstype) != UNION_TYPE) - if (tree access_size = TYPE_SIZE_UNIT (axstype)) - if (TREE_CODE (access_size) == INTEGER_CST) - axssize = wi::to_offset (access_size); - const bool uboob = !lboob && offrange[0] + axssize > ubound; if (lboob || uboob) { @@ -689,9 +492,7 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, to compute the index to print in the diagnostic; arrays in MEM_REF don't mean anything. A type with no size like void is as good as having a size of 1. */ - tree type = TREE_TYPE (ref); - while (TREE_CODE (type) == ARRAY_TYPE) - type = TREE_TYPE (type); + tree type = strip_array_types (TREE_TYPE (ref)); if (tree size = TYPE_SIZE_UNIT (type)) { offrange[0] = offrange[0] / wi::to_offset (size); @@ -699,6 +500,7 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, } } + bool warned = false; if (lboob) { if (offrange[0] == offrange[1]) @@ -720,7 +522,7 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, /* If the memory was dynamically allocated refer to it as if it were an untyped array of bytes. */ backtype = build_array_type_nelts (unsigned_char_type_node, - arrbounds[1].to_uhwi ()); + aref.sizrng[1].to_uhwi ()); warned = warning_at (location, OPT_Warray_bounds, "array subscript %<%T[%wi]%> is partly " @@ -730,46 +532,8 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, if (warned) { - if (DECL_P (arg)) - inform (DECL_SOURCE_LOCATION (arg), "while referencing %qD", arg); - else if (alloc_stmt) - { - location_t loc = gimple_location (alloc_stmt); - if (gimple_call_builtin_p (alloc_stmt, BUILT_IN_ALLOCA_WITH_ALIGN)) - { - if (minbound == arrbounds[1]) - inform (loc, "referencing a variable length array " - "of size %wu", minbound.to_uhwi ()); - else - inform (loc, "referencing a variable length array " - "of size between %wu and %wu", - minbound.to_uhwi (), arrbounds[1].to_uhwi ()); - } - else if (tree fndecl = gimple_call_fndecl (alloc_stmt)) - { - if (minbound == arrbounds[1]) - inform (loc, "referencing an object of size %wu " - "allocated by %qD", - minbound.to_uhwi (), fndecl); - else - inform (loc, "referencing an object of size between " - "%wu and %wu allocated by %qD", - minbound.to_uhwi (), arrbounds[1].to_uhwi (), fndecl); - } - else - { - tree fntype = gimple_call_fntype (alloc_stmt); - if (minbound == arrbounds[1]) - inform (loc, "referencing an object of size %wu " - "allocated by %qT", - minbound.to_uhwi (), fntype); - else - inform (loc, "referencing an object of size between " - "%wu and %wu allocated by %qT", - minbound.to_uhwi (), arrbounds[1].to_uhwi (), fntype); - } - } - + /* TODO: Determine the access from the statement and use it. */ + aref.inform_access (access_none); suppress_warning (ref, OPT_Warray_bounds); return true; } @@ -779,9 +543,9 @@ array_bounds_checker::check_mem_ref (location_t location, tree ref, /* At level 2 check also intermediate offsets. */ int i = 0; - if (extrema[i] < -arrbounds[1] || extrema[i = 1] > ubound) + if (aref.offmax[i] < -aref.sizrng[1] || aref.offmax[i = 1] > ubound) { - HOST_WIDE_INT tmpidx = extrema[i].to_shwi () / eltsize.to_shwi (); + HOST_WIDE_INT tmpidx = aref.offmax[i].to_shwi () / eltsize.to_shwi (); if (warning_at (location, OPT_Warray_bounds, "intermediate array offset %wi is outside array bounds " diff --git a/gcc/testsuite/c-c++-common/Warray-bounds-10.c b/gcc/testsuite/c-c++-common/Warray-bounds-10.c new file mode 100644 index 00000000000..cfe9a383410 --- /dev/null +++ b/gcc/testsuite/c-c++-common/Warray-bounds-10.c @@ -0,0 +1,114 @@ +/* PR tree-optimization/99475 - bogus -Warray-bounds accessing an array + element of empty structs + { dg-do compile } + { dg-options "-O2 -Wall" } */ + +struct S +{ +#if SOME_CONFIG_MACRO + /* Suppose the contents are empty in the development configuration + but non-empty in others. Out of bounds accesses to elements of + the arrays below should be diagnosed in all configurations, + including when S is empty, even if they are folded away. */ + int member; +#endif +}; + +extern struct S sa3[3]; +extern struct S sa2_3[2][3]; +extern struct S sa3_4_5[3][4][5]; + +void sink (void*); + + +void access_sa3 (struct S s) +{ + sa3[0] = s; + sa3[1] = s; + sa3[2] = s; + sa3[3] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } +} + +void access_sa3_ptr (struct S s) +{ + struct S *p = &sa3[0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[3] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } +} + +void access_sa2_3_ptr (struct S s) +{ + struct S *p = &sa2_3[0][0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[6] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } +} + +void access_sa3_4_5_ptr (struct S s, int i) +{ + struct S *p = &sa3_4_5[0][0][0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[60] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } +} + + +void access_vla3 (struct S s, unsigned n) +{ + struct S vla3[3 < n ? 3 : n]; + + vla3[0] = s; + vla3[1] = s; + vla3[2] = s; + vla3[3] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } + + sink (vla3); +} + +void access_vla3_ptr (struct S s, unsigned n) +{ + struct S vla3[3 < n ? 3 : n]; + struct S *p = &vla3[0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[3] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } + + sink (vla3); +} + +void access_vla2_3_ptr (struct S s, unsigned n) +{ + struct S vla2_3[2 < n ? 2 : n][3 < n ? 3 : n]; + struct S *p = &vla2_3[0][0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[6] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } + + sink (vla2_3); +} + +void access_vla3_4_5_ptr (struct S s, unsigned n) +{ + struct S vla3_4_5[3 < n ? 3 : n][4 < n ? 4 : n][5 < n ? 5 : n]; + struct S *p = &vla3_4_5[0][0][0]; + + p[0] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[1] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[2] = s; // { dg-bogus "\\\[-Warray-bounds" } + p[60] = s; // { dg-warning "\\\[-Warray-bounds" "pr?????" { xfail *-*-* } } + + sink (vla3_4_5); +} + +// { dg-prune-output "empty struct has size 0 in C" } diff --git a/gcc/testsuite/c-c++-common/Warray-bounds-3.c b/gcc/testsuite/c-c++-common/Warray-bounds-3.c index aae4999ea13..3d7c7687374 100644 --- a/gcc/testsuite/c-c++-common/Warray-bounds-3.c +++ b/gcc/testsuite/c-c++-common/Warray-bounds-3.c @@ -158,7 +158,7 @@ void test_memcpy_overflow (char *d, const char *s, size_t n) but known access size is detected. This works except with small sizes that are powers of 2 due to bug . */ T (char, 1, arr + SR (DIFF_MAX - 1, DIFF_MAX), s, 1); - T (char, 1, arr + SR (DIFF_MAX - 1, DIFF_MAX), s, 2); /* { dg-warning "pointer overflow between offset \\\[\[0-9\]+, \[0-9\]+] and size 2 accessing array " "bug " { xfail non_strict_align } } */ + T (char, 1, arr + SR (DIFF_MAX - 1, DIFF_MAX), s, 2); /* { dg-warning "\\\[-Warray-bounds" } */ T (char, 1, arr + SR (DIFF_MAX - 2, DIFF_MAX), s, 3); /* { dg-warning "pointer overflow between offset \\\[\[0-9\]+, \[0-9\]+] and size 3 accessing array " "memcpy" } */ T (char, 1, arr + SR (DIFF_MAX - 4, DIFF_MAX), s, 5); /* { dg-warning "pointer overflow between offset \\\[\[0-9\]+, \[0-9\]+] and size 5 accessing array " "memcpy" } */ } @@ -178,7 +178,7 @@ void test_memcpy_bounds_memarray_range (void) TM (ma.a5, ma.a5 + i, ma.a5, 1); TM (ma.a5, ma.a5 + i, ma.a5, 3); - TM (ma.a5, ma.a5 + i, ma.a5, 5); + TM (ma.a5, ma.a5 + i, ma.a5, 5); /* { dg-warning "\\\[-Warray-bounds" } */ TM (ma.a5, ma.a5 + i, ma.a5, 7); /* diagnosed with -Warray-bounds=2 */ } diff --git a/gcc/testsuite/c-c++-common/Warray-bounds-4.c b/gcc/testsuite/c-c++-common/Warray-bounds-4.c index 22a23a12651..1f73f11943f 100644 --- a/gcc/testsuite/c-c++-common/Warray-bounds-4.c +++ b/gcc/testsuite/c-c++-common/Warray-bounds-4.c @@ -43,7 +43,17 @@ void test_memcpy_bounds_memarray_range (void) TM (ma.a5, ma.a5 + j, ma.a5, 1); TM (ma.a5, ma.a5 + j, ma.a5, 3); - TM (ma.a5, ma.a5 + j, ma.a5, 5); + + /* The copy below is invalid for two reasons: 1) it overlaps and 2) it + writes past the end of ma.a5. The warning is a little cryptic here + because the GIMPLE is: + _4 = &ma.a5 + prephitmp_14; + MEM <unsigned char[5]> [(char * {ref-all})_4] + = MEM <unsigned char[5]> [(char * {ref-all})&ma]; + and could be improved. Just verify that one is issued but not its + full text. */ + TM (ma.a5, ma.a5 + j, ma.a5, 5); /* { dg-warning "\\\[-Warray-bounds" } */ + TM (ma.a5, ma.a5 + j, ma.a5, 7); /* { dg-warning "offset \\\[5, 7] from the object at .ma. is out of the bounds of referenced subobject .$MA::$?a5. with type .char ?\\\[5]. at offset 0" } */ TM (ma.a5, ma.a5 + j, ma.a5, 9); /* { dg-warning "offset \\\[5, 9] from the object at .ma. is out of the bounds of referenced subobject .$MA::$?a5. with type .char ?\\\[5]. at offset 0" } */ } diff --git a/gcc/testsuite/c-c++-common/Warray-bounds-9.c b/gcc/testsuite/c-c++-common/Warray-bounds-9.c new file mode 100644 index 00000000000..be05775fa91 --- /dev/null +++ b/gcc/testsuite/c-c++-common/Warray-bounds-9.c @@ -0,0 +1,144 @@ +/* PR tree-optimization/99121 - ICE in -Warray-bounds on a multidimensional + VLA + { dg-do compile } + { dg-options "-O2 -Wall -ftrack-macro-expansion=0" } */ + +#define NOIPA __attribute__ ((noipa)) + +void sink (void*, ...); +#define T(a, x) sink (a, x) + + +NOIPA void a_0_n (int n) +{ + int a[0][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_n_0 (int n) +{ + int a[n][0]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + + +NOIPA void a_1_n_0 (int n) +{ + int a[1][n][0]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_1_0_n (int n) +{ + int a[1][0][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_0_1_n (int n) +{ + int a[0][1][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_0_n_1 (int n) +{ + int a[0][n][1]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_n_0_n (int n) +{ + int a[n][0][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_n_n_0 (int n) +{ + int a[n][n][0]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_0_n_n (int n) +{ + int a[0][n][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_0_0_n (int n) +{ + int a[0][0][n]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_n_0_0 (int n) +{ + int a[n][0][0]; + + sink (a); + + T (a, ((int *) a)[0]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((char *) a)[1]); // { dg-warning "\\\[-Warray-bounds" } + T (a, ((float *) a)[n]); // { dg-warning "\\\[-Warray-bounds" } +} + +NOIPA void a_n_n_n (int n) +{ + int a[n][n][n]; + + sink (a); + + T (a, ((int *) a)[-1]); // { dg-warning "\\\[-Warray-bounds" "pr99140" } + T (a, ((int *) a)[0]); + T (a, ((char *) a)[1]); + T (a, ((float *) a)[n]); +} diff --git a/gcc/testsuite/g++.dg/asan/asan_test.C b/gcc/testsuite/g++.dg/asan/asan_test.C index c62568f48ec..49933ab8e4d 100644 --- a/gcc/testsuite/g++.dg/asan/asan_test.C +++ b/gcc/testsuite/g++.dg/asan/asan_test.C @@ -2,7 +2,7 @@ // { dg-skip-if "" { *-*-* } { "*" } { "-O2" } } // { dg-skip-if "" { *-*-* } { "-flto" } { "" } } // { dg-additional-sources "asan_globals_test-wrapper.cc" } -// { dg-options "-std=c++11 -fsanitize=address -fno-builtin -Wall -Werror -Wno-alloc-size-larger-than -Wno-stringop-overflow -g -DASAN_UAR=0 -DASAN_HAS_EXCEPTIONS=1 -DASAN_HAS_BLACKLIST=0 -DSANITIZER_USE_DEJAGNU_GTEST=1 -lasan -lpthread" } +// { dg-options "-std=c++11 -fsanitize=address -fno-builtin -Wall -Werror -Wno-alloc-size-larger-than -Wno-array-bounds -Wno-stringop-overflow -g -DASAN_UAR=0 -DASAN_HAS_EXCEPTIONS=1 -DASAN_HAS_BLACKLIST=0 -DSANITIZER_USE_DEJAGNU_GTEST=1 -lasan -lpthread" } // { dg-additional-options "-ldl" { target { ! *-*-freebsd* } } } // { dg-additional-options "-DASAN_NEEDS_SEGV=1" { target { ! arm*-*-* } } } // { dg-additional-options "-DASAN_LOW_MEMORY=1 -DASAN_NEEDS_SEGV=0" { target arm*-*-* } } diff --git a/gcc/testsuite/g++.dg/pr95768.C b/gcc/testsuite/g++.dg/pr95768.C index 5e2c8c44ad0..d34d5133134 100644 --- a/gcc/testsuite/g++.dg/pr95768.C +++ b/gcc/testsuite/g++.dg/pr95768.C @@ -1,6 +1,6 @@ /* PR c++/95768 - pretty-printer ICE on -Wuninitialized with allocated storage { dg-do compile } - { dg-options "-O2 -Wall" } */ + { dg-options "-O2 -Wall -Wno-array-bounds" } */ </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_cross/gnu-release-aarch64-check_cross - Build # 28 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_cross/gnu-release-aarch64-check_cross. So far, this commit has regressed CI configurations: - tcwg_cross/gnu-release-aarch64-check_cross Culprit: <cut> commit ca094af16ce810b1e553e000354b5d64a9b90a1a Author: Eric Botcazou <ebotcazou(a)adacore.com> Date: Fri Jul 9 18:30:54 2021 +0200 Missing piece in earlier change gcc/ada/ * gcc-interface/utils.c (finish_subprog_decl): Remove obsolete line. </cut> Results regressed to (for first_bad == ca094af16ce810b1e553e000354b5d64a9b90a1a) # reset_artifacts: -10 # build_abe binutils: -8 # build_abe stage1: -7 # build_abe linux: -6 # build_abe glibc: -5 # build_abe stage2: -4 # build_abe qemu: -3 # build_abe dejagnu: 0 # build_abe check_gcc -- --set runtestflags=g++.dg/asan/asan.exp --set runtestflags=gcc.c-torture/execute/execute.exp --set runtestflags=gcc.dg/asan/asan.exp --set runtestflags=gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp --set runtestflags=gcc.target/aarch64/sve/aarch64-sve.exp --set runtestflags=gcc.target/aarch64/sve/pcs/aarch64-sve-pcs.exp --set runtestflags=gfortran.dg/dg.exp --set runtestflags=gfortran.dg/ieee/ieee.exp --set runtestflags=g++.dg/analyzer/analyzer.exp --set runtestflags=g++.dg/compat/compat.exp --set runtestflags=g++.dg/compat/struct-layout-1.exp --set runtestflags=g++.dg/coroutines/coroutines.exp --set runtestflags=g++.dg/coroutines/torture/coro-torture.exp --set runtestflags=g++.dg/debug/debug.exp --set runtestflags=g++.dg/debug/dwarf2/dwarf2.exp --set runtestflags=g++.dg/dg.exp --set runtestflags=g++.dg/goacc/goacc.exp --set runtestflags=g++.dg/gomp/gomp.exp --set runtestflags=g++.dg/lto/lto.exp --set runtestflags=g++.dg/pch/pch.exp --set runtestflags=g++.dg/special/ecos.exp --set runtestflags=g++.dg/tls/tls.exp --set runtestflags=g++.dg/tm/tm.exp --set runtestflags=g++.dg/torture/dg-torture.exp --set runtestflags=g++.dg/torture/stackalign/stackalign.exp --set runtestflags=g++.dg/vect/vect.exp --set runtestflags=g++.old-deja/old-deja.exp --set runtestflags=g++.target/aarch64/aarch64.exp --set runtestflags=g++.target/aarch64/sve/aarch64-sve.exp --set runtestflags=g++.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp --set runtestflags=g++.target/aarch64/sve/acle/aarch64-sve-acle.exp --set runtestflags=g++.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp --set runtestflags=gcc.c-torture/compile/compile.exp --set runtestflags=gcc.c-torture/execute/builtins/builtins.exp --set runtestflags=gcc.c-torture/execute/execute.exp --set runtestflags=gcc.c-torture/execute/ieee/ieee.exp --set runtestflags=gcc.c-torture/unsorted/unsorted.exp --set runtestflags=gcc.dg/analyzer/analyzer.exp --set runtestflags=gcc.dg/analyzer/torture/analyzer-torture.exp --set runtestflags=gcc.dg/compat/compat.exp --set runtestflags=gcc.dg/compat/struct-layout-1.exp --set runtestflags=gcc.dg/cpp/cpp.exp --set runtestflags=gcc.dg/cpp/trad/trad.exp --set runtestflags=gcc.dg/debug/debug.exp --set runtestflags=gcc.dg/dg.exp --set runtestflags=gcc.dg/goacc/goacc.exp --set runtestflags=gcc.dg/gomp/gomp.exp --set runtestflags=gcc.dg/ipa/ipa.exp --set runtestflags=gcc.dg/lto/lto.exp --set runtestflags=gcc.dg/pch/pch.exp --set runtestflags=gcc.dg/plugin/plugin.exp --set runtestflags=gcc.dg/special/special.exp --set runtestflags=gcc.dg/sso/sso.exp --set runtestflags=gcc.dg/tm/tm.exp --set runtestflags=gcc.dg/torture/dg-torture.exp --set runtestflags=gcc.dg/torture/stackalign/stackalign.exp --set runtestflags=gcc.dg/tree-ssa/tree-ssa.exp --set runtestflags=gcc.dg/vect/vect.exp --set runtestflags=gcc.dg/weak/weak.exp --set runtestflags=gcc.target/aarch64/aapcs64/aapcs64.exp --set runtestflags=gcc.target/aarch64/aarch64.exp --set runtestflags=gcc.target/aarch64/acle/acle.exp --set runtestflags=gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp --set runtestflags=gcc.target/aarch64/fp16/fp16.exp --set runtestflags=gcc.target/aarch64/simd/simd.exp --set runtestflags=gcc.target/aarch64/sve/aarch64-sve.exp --set runtestflags=gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp --set runtestflags=gcc.target/aarch64/sve/acle/aarch64-sve-acle.exp --set runtestflags=gcc.target/aarch64/sve/pcs/aarch64-sve-pcs.exp --set runtestflags=gcc.target/aarch64/sve2/aarch64-sve2.exp --set runtestflags=gcc.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp --set runtestflags=gcc.target/aarch64/sve2/acle/aarch64-sve2-acle.exp --set runtestflags=gcc.target/aarch64/torture/aarch64-torture.exp --set runtestflags=gfortran.dg/coarray/caf.exp --set runtestflags=gfortran.dg/dg.exp --set runtestflags=gfortran.dg/guality/guality.exp --set runtestflags=gfortran.dg/lto/lto.exp --set runtestflags=gfortran.dg/vect/vect.exp --set runtestflags=gfortran.fortran-torture/execute/execute.exp --set runtestflags=libatomic.c/c.exp --set runtestflags=libgomp.c++/c++.exp --set runtestflags=libgomp.c/c.exp --set runtestflags=libgomp.fortran/fortran.exp --set runtestflags=libgomp.oacc-c++/c++.exp --set runtestflags=libgomp.oacc-c/c.exp --set runtestflags=libgomp.oacc-fortran/fortran.exp --set runtestflags=libitm.c++/c++.exp --set runtestflags=libitm.c/c.exp --set runtestflags=libstdc++-abi/abi.exp --set runtestflags=libstdc++-dg/conformance.exp --set runtestflags=libstdc++-prettyprinters/prettyprinters.exp --set runtestflags=libstdc++-xmethods/xmethods.exp: 1 # Getting actual results from build directory /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/libitm.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/libgomp.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/libstdc++.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/g++.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/gcc.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/gfortran.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_0/artifacts/build-ca094af16ce810b1e553e000354b5d64a9b90a1a/sumfiles/libatomic.sum # Manifest: gcc-compare-results/contrib/testsuite-management/flaky.xfail # Getting actual results from build directory base-artifacts/sumfiles # base-artifacts/sumfiles/libitm.sum # base-artifacts/sumfiles/libgomp.sum # base-artifacts/sumfiles/libstdc++.sum # base-artifacts/sumfiles/g++.sum # base-artifacts/sumfiles/gcc.sum # base-artifacts/sumfiles/gfortran.sum # base-artifacts/sumfiles/libatomic.sum # # # Unexpected results in this build (new failures) # === gcc tests === # # Running g++.dg/asan/asan.exp ... # FAIL: c-c++-common/asan/halt_on_error-1.c -O0 execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -O1 execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -O2 execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -O3 -g execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -Os execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test # FAIL: c-c++-common/asan/halt_on_error-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test # # Running g++.dg/coroutines/torture/coro-torture.exp ... # FAIL: g++.dg/coroutines/torture/pr95519-06-grooaf.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-06-grooaf.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O1 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O1 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O3 -g (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O3 -g compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -Os (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -Os compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 -flto -fno-use-linker-plugin -flto-partition=none compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95519-07-unhandled-exception.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O1 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O1 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O2 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O2 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O3 -g (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O3 -g compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -Os (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -Os compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O2 -flto -fno-use-linker-plugin -flto-partition=none compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-01.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-01.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O1 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O1 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O2 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O2 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O3 -g (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O3 -g compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -Os (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -Os compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O2 -flto -fno-use-linker-plugin -flto-partition=none compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-02.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-02.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O1 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O1 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O2 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O2 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O3 -g (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O3 -g compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -Os (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -Os compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O2 -flto -fno-use-linker-plugin -flto-partition=none (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O2 -flto -fno-use-linker-plugin -flto-partition=none compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-03.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-03.C -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-04.C -O0 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-04.C -O0 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-04.C -O1 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-04.C -O1 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-04.C -O2 (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-04.C -O2 compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-04.C -O3 -g (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-04.C -O3 -g compilation failed to produce executable # FAIL: g++.dg/coroutines/torture/pr95615-04.C -Os (test for excess errors) # UNRESOLVED: g++.dg/coroutines/torture/pr95615-04.C -Os compilation failed to produce executable # ... and 1079 more entries from (for last_good == d826bff6ad62b3bda59f6418147cfbbd2435da0d) # reset_artifacts: -10 # build_abe binutils: -8 # build_abe stage1: -7 # build_abe linux: -6 # build_abe glibc: -5 # build_abe stage2: -4 # build_abe qemu: -3 # build_abe dejagnu: 0 # build_abe check_gcc -- --set runtestflags=g++.dg/asan/asan.exp --set runtestflags=gcc.c-torture/execute/execute.exp --set runtestflags=gcc.dg/asan/asan.exp --set runtestflags=gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp --set runtestflags=gcc.target/aarch64/sve/aarch64-sve.exp --set runtestflags=gcc.target/aarch64/sve/pcs/aarch64-sve-pcs.exp --set runtestflags=gfortran.dg/dg.exp --set runtestflags=gfortran.dg/ieee/ieee.exp --set runtestflags=g++.dg/analyzer/analyzer.exp --set runtestflags=g++.dg/compat/compat.exp --set runtestflags=g++.dg/compat/struct-layout-1.exp --set runtestflags=g++.dg/coroutines/coroutines.exp --set runtestflags=g++.dg/coroutines/torture/coro-torture.exp --set runtestflags=g++.dg/debug/debug.exp --set runtestflags=g++.dg/debug/dwarf2/dwarf2.exp --set runtestflags=g++.dg/dg.exp --set runtestflags=g++.dg/goacc/goacc.exp --set runtestflags=g++.dg/gomp/gomp.exp --set runtestflags=g++.dg/lto/lto.exp --set runtestflags=g++.dg/pch/pch.exp --set runtestflags=g++.dg/special/ecos.exp --set runtestflags=g++.dg/tls/tls.exp --set runtestflags=g++.dg/tm/tm.exp --set runtestflags=g++.dg/torture/dg-torture.exp --set runtestflags=g++.dg/torture/stackalign/stackalign.exp --set runtestflags=g++.dg/vect/vect.exp --set runtestflags=g++.old-deja/old-deja.exp --set runtestflags=g++.target/aarch64/aarch64.exp --set runtestflags=g++.target/aarch64/sve/aarch64-sve.exp --set runtestflags=g++.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp --set runtestflags=g++.target/aarch64/sve/acle/aarch64-sve-acle.exp --set runtestflags=g++.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp --set runtestflags=gcc.c-torture/compile/compile.exp --set runtestflags=gcc.c-torture/execute/builtins/builtins.exp --set runtestflags=gcc.c-torture/execute/execute.exp --set runtestflags=gcc.c-torture/execute/ieee/ieee.exp --set runtestflags=gcc.c-torture/unsorted/unsorted.exp --set runtestflags=gcc.dg/analyzer/analyzer.exp --set runtestflags=gcc.dg/analyzer/torture/analyzer-torture.exp --set runtestflags=gcc.dg/compat/compat.exp --set runtestflags=gcc.dg/compat/struct-layout-1.exp --set runtestflags=gcc.dg/cpp/cpp.exp --set runtestflags=gcc.dg/cpp/trad/trad.exp --set runtestflags=gcc.dg/debug/debug.exp --set runtestflags=gcc.dg/dg.exp --set runtestflags=gcc.dg/goacc/goacc.exp --set runtestflags=gcc.dg/gomp/gomp.exp --set runtestflags=gcc.dg/ipa/ipa.exp --set runtestflags=gcc.dg/lto/lto.exp --set runtestflags=gcc.dg/pch/pch.exp --set runtestflags=gcc.dg/plugin/plugin.exp --set runtestflags=gcc.dg/special/special.exp --set runtestflags=gcc.dg/sso/sso.exp --set runtestflags=gcc.dg/tm/tm.exp --set runtestflags=gcc.dg/torture/dg-torture.exp --set runtestflags=gcc.dg/torture/stackalign/stackalign.exp --set runtestflags=gcc.dg/tree-ssa/tree-ssa.exp --set runtestflags=gcc.dg/vect/vect.exp --set runtestflags=gcc.dg/weak/weak.exp --set runtestflags=gcc.target/aarch64/aapcs64/aapcs64.exp --set runtestflags=gcc.target/aarch64/aarch64.exp --set runtestflags=gcc.target/aarch64/acle/acle.exp --set runtestflags=gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp --set runtestflags=gcc.target/aarch64/fp16/fp16.exp --set runtestflags=gcc.target/aarch64/simd/simd.exp --set runtestflags=gcc.target/aarch64/sve/aarch64-sve.exp --set runtestflags=gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp --set runtestflags=gcc.target/aarch64/sve/acle/aarch64-sve-acle.exp --set runtestflags=gcc.target/aarch64/sve/pcs/aarch64-sve-pcs.exp --set runtestflags=gcc.target/aarch64/sve2/aarch64-sve2.exp --set runtestflags=gcc.target/aarch64/sve2/acle/aarch64-sve2-acle-asm.exp --set runtestflags=gcc.target/aarch64/sve2/acle/aarch64-sve2-acle.exp --set runtestflags=gcc.target/aarch64/torture/aarch64-torture.exp --set runtestflags=gfortran.dg/coarray/caf.exp --set runtestflags=gfortran.dg/dg.exp --set runtestflags=gfortran.dg/guality/guality.exp --set runtestflags=gfortran.dg/lto/lto.exp --set runtestflags=gfortran.dg/vect/vect.exp --set runtestflags=gfortran.fortran-torture/execute/execute.exp --set runtestflags=libatomic.c/c.exp --set runtestflags=libgomp.c++/c++.exp --set runtestflags=libgomp.c/c.exp --set runtestflags=libgomp.fortran/fortran.exp --set runtestflags=libgomp.oacc-c++/c++.exp --set runtestflags=libgomp.oacc-c/c.exp --set runtestflags=libgomp.oacc-fortran/fortran.exp --set runtestflags=libitm.c++/c++.exp --set runtestflags=libitm.c/c.exp --set runtestflags=libstdc++-abi/abi.exp --set runtestflags=libstdc++-dg/conformance.exp --set runtestflags=libstdc++-prettyprinters/prettyprinters.exp --set runtestflags=libstdc++-xmethods/xmethods.exp: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Build top page/logs: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-ca094af16ce810b1e553e000354b5d64a9b90a1a cd investigate-gcc-ca094af16ce810b1e553e000354b5d64a9b90a1a git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach ca094af16ce810b1e553e000354b5d64a9b90a1a ../artifacts/test.sh # Reproduce last_good build git checkout --detach d826bff6ad62b3bda59f6418147cfbbd2435da0d ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Build log: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Full commit (up to 1000 lines): <cut> commit ca094af16ce810b1e553e000354b5d64a9b90a1a Author: Eric Botcazou <ebotcazou(a)adacore.com> Date: Fri Jul 9 18:30:54 2021 +0200 Missing piece in earlier change gcc/ada/ * gcc-interface/utils.c (finish_subprog_decl): Remove obsolete line. --- gcc/ada/gcc-interface/utils.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/ada/gcc-interface/utils.c b/gcc/ada/gcc-interface/utils.c index 63a0ad9461e..abb456216c7 100644 --- a/gcc/ada/gcc-interface/utils.c +++ b/gcc/ada/gcc-interface/utils.c @@ -3438,9 +3438,6 @@ finish_subprog_decl (tree decl, tree asm_name, tree type) DECL_BY_REFERENCE (result_decl) = TREE_ADDRESSABLE (type); DECL_RESULT (decl) = result_decl; - /* Propagate the "const" property. */ - TREE_READONLY (decl) = TYPE_READONLY (type); - /* Propagate the "pure" property. */ DECL_PURE_P (decl) = TYPE_RESTRICT (type); </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-master-arm-spec2k6-O2 - Build # 8 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-O2. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-O2 Culprit: <cut> commit 87065c0d242d955e6f3fddf5cbc790d025c3521c Author: Guillaume Chatelet <gchatelet(a)google.com> Date: Wed Jun 23 14:19:40 2021 +0000 [libc] add benchmarks for memcmp and bzero Differential Revision: https://reviews.llvm.org/D104511 </cut> Results regressed to (for first_bad == 87065c0d242d955e6f3fddf5cbc790d025c3521c) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_marm -- artifacts/build-87065c0d242d955e6f3fddf5cbc790d025c3521c/results_id: 1 # 400.perlbench,perlbench_base.default regressed by 103 from (for last_good == c125af82a5ff5dbbbcb8ebc5cde156d41e6ac281) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_marm -- artifacts/build-c125af82a5ff5dbbbcb8ebc5cde156d41e6ac281/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-O2/1292 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-O2/1297 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-87065c0d242d955e6f3fddf5cbc790d025c3521c cd investigate-llvm-87065c0d242d955e6f3fddf5cbc790d025c3521c git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 87065c0d242d955e6f3fddf5cbc790d025c3521c ../artifacts/test.sh # Reproduce last_good build git checkout --detach c125af82a5ff5dbbbcb8ebc5cde156d41e6ac281 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Full commit (up to 1000 lines): <cut> commit 87065c0d242d955e6f3fddf5cbc790d025c3521c Author: Guillaume Chatelet <gchatelet(a)google.com> Date: Wed Jun 23 14:19:40 2021 +0000 [libc] add benchmarks for memcmp and bzero Differential Revision: https://reviews.llvm.org/D104511 --- libc/benchmarks/CMakeLists.txt | 2 ++ libc/benchmarks/LibcMemoryBenchmarkMain.cpp | 47 +++++++++++++++++++++++++++-- libc/src/string/CMakeLists.txt | 38 +++++++++++++++++------ 3 files changed, 75 insertions(+), 12 deletions(-) diff --git a/libc/benchmarks/CMakeLists.txt b/libc/benchmarks/CMakeLists.txt index feff80cf4501..390b802bd8f7 100644 --- a/libc/benchmarks/CMakeLists.txt +++ b/libc/benchmarks/CMakeLists.txt @@ -169,3 +169,5 @@ endfunction() add_libc_multi_impl_benchmark(memcpy) add_libc_multi_impl_benchmark(memset) +add_libc_multi_impl_benchmark(bzero) +add_libc_multi_impl_benchmark(memcmp) diff --git a/libc/benchmarks/LibcMemoryBenchmarkMain.cpp b/libc/benchmarks/LibcMemoryBenchmarkMain.cpp index e3d455423de2..6fa01ede52e3 100644 --- a/libc/benchmarks/LibcMemoryBenchmarkMain.cpp +++ b/libc/benchmarks/LibcMemoryBenchmarkMain.cpp @@ -17,10 +17,14 @@ #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/raw_ostream.h" +#include <cstring> + namespace __llvm_libc { extern void *memcpy(void *__restrict, const void *__restrict, size_t); extern void *memset(void *, int, size_t); +extern void bzero(void *, size_t); +extern int memcmp(const void *, const void *, size_t); } // namespace __llvm_libc @@ -79,7 +83,7 @@ struct Benchmark { return [this](ParameterType P) { __llvm_libc::memcpy(DstBuffer + P.OffsetBytes, SrcBuffer + P.OffsetBytes, P.SizeBytes); - return DstBuffer + P.OffsetBytes; + return DstBuffer[P.OffsetBytes]; }; } @@ -97,18 +101,55 @@ struct Benchmark { return [this](ParameterType P) { __llvm_libc::memset(DstBuffer + P.OffsetBytes, P.OffsetBytes & 0xFF, P.SizeBytes); - return DstBuffer + P.OffsetBytes; + return DstBuffer[P.OffsetBytes]; + }; + } + + AlignedBuffer DstBuffer; +}; +#elif defined(LIBC_BENCHMARK_FUNCTION_BZERO) +struct Benchmark { + static constexpr auto GetDistributions = &getMemsetSizeDistributions; + static constexpr size_t BufferCount = 1; + + Benchmark(const size_t BufferSize) : DstBuffer(BufferSize) {} + + inline auto functor() { + return [this](ParameterType P) { + __llvm_libc::bzero(DstBuffer + P.OffsetBytes, P.SizeBytes); + return DstBuffer[P.OffsetBytes]; }; } AlignedBuffer DstBuffer; }; +#elif defined(LIBC_BENCHMARK_FUNCTION_MEMCMP) +struct Benchmark { + static constexpr auto GetDistributions = &getMemcmpSizeDistributions; + static constexpr size_t BufferCount = 2; + + Benchmark(const size_t BufferSize) + : BufferA(BufferSize), BufferB(BufferSize) { + // The memcmp buffers always compare equal. + memset(BufferA.begin(), 0xF, BufferSize); + memset(BufferB.begin(), 0xF, BufferSize); + } + + inline auto functor() { + return [this](ParameterType P) { + return __llvm_libc::memcmp(BufferA + P.OffsetBytes, + BufferB + P.OffsetBytes, P.SizeBytes); + }; + } + + AlignedBuffer BufferA; + AlignedBuffer BufferB; +}; #else #error "Missing LIBC_BENCHMARK_FUNCTION_XXX definition" #endif struct Harness : Benchmark { - Harness(const size_t BufferSize, size_t BatchParameterCount, std::function<unsigned()> SizeSampler, std::function<unsigned()> OffsetSampler) diff --git a/libc/src/string/CMakeLists.txt b/libc/src/string/CMakeLists.txt index 4dd8ee0bf4a2..97ac99cb89fe 100644 --- a/libc/src/string/CMakeLists.txt +++ b/libc/src/string/CMakeLists.txt @@ -58,14 +58,6 @@ add_entrypoint_object( .string_utils ) -add_entrypoint_object( - memcmp - SRCS - memcmp.cpp - HDRS - memcmp.h -) - add_entrypoint_object( memmove SRCS @@ -280,7 +272,6 @@ function(add_bzero bzero_name) .memory_utils.memory_utils libc.include.string COMPILE_OPTIONS - -fno-builtin-memset -fno-builtin-bzero ${ARGN} ) @@ -297,3 +288,32 @@ else() add_bzero(bzero_opt_host COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_NATIVE}) add_bzero(bzero) endif() + +# ------------------------------------------------------------------------------ +# memcmp +# ------------------------------------------------------------------------------ + +function(add_memcmp memcmp_name) + add_implementation(memcmp ${memcmp_name} + SRCS ${LIBC_SOURCE_DIR}/src/string/memcmp.cpp + HDRS ${LIBC_SOURCE_DIR}/src/string/memcmp.h + DEPENDS + .memory_utils.memory_utils + libc.include.string + COMPILE_OPTIONS + -fno-builtin-memcmp + ${ARGN} + ) +endfunction() + +if(${LIBC_TARGET_ARCHITECTURE_IS_X86}) + add_memcmp(memcmp_x86_64_opt_sse2 COMPILE_OPTIONS -march=k8 REQUIRE SSE2) + add_memcmp(memcmp_x86_64_opt_sse4 COMPILE_OPTIONS -march=nehalem REQUIRE SSE4_2) + add_memcmp(memcmp_x86_64_opt_avx2 COMPILE_OPTIONS -march=haswell REQUIRE AVX2) + add_memcmp(memcmp_x86_64_opt_avx512 COMPILE_OPTIONS -march=skylake-avx512 REQUIRE AVX512F) + add_memcmp(memcmp_opt_host COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_NATIVE}) + add_memcmp(memcmp) +else() + add_memcmp(memcmp_opt_host COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_NATIVE}) + add_memcmp(memcmp) +endif() </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-master-arm-spec2k6-O2 - Build # 15 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O2. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O2 Culprit: <cut> commit 2da5f22fff639e891b9f516724683d9d7ad1511c Author: Florian Weimer <fweimer(a)redhat.com> Date: Fri Jun 25 10:42:52 2021 +0200 Linux: Move mq_notify from librt to libc The symbol was moved using scripts/move-symbol-to-libc.py. An explicit call from fork into the mq_notify implementation replaces the previous use of pthread_atfork. Reviewed-by: Adhemerva Zanella <adhemerval.zanella(a)linaro.org> </cut> Results regressed to (for first_bad == 2da5f22fff639e891b9f516724683d9d7ad1511c) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_marm -- artifacts/build-2da5f22fff639e891b9f516724683d9d7ad1511c/results_id: 1 # 481.wrf,[.] __module_small_step_em_MOD_advance_uv regressed by 117 from (for last_good == f66d9abca7ecc4ee4c7afcc1d1496411bfc70911) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_marm -- artifacts/build-f66d9abca7ecc4ee4c7afcc1d1496411bfc70911/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O2/1284 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O2/1277 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-2da5f22fff639e891b9f516724683d9d7ad1511c cd investigate-glibc-2da5f22fff639e891b9f516724683d9d7ad1511c git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach 2da5f22fff639e891b9f516724683d9d7ad1511c ../artifacts/test.sh # Reproduce last_good build git checkout --detach f66d9abca7ecc4ee4c7afcc1d1496411bfc70911 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Full commit (up to 1000 lines): <cut> commit 2da5f22fff639e891b9f516724683d9d7ad1511c Author: Florian Weimer <fweimer(a)redhat.com> Date: Fri Jun 25 10:42:52 2021 +0200 Linux: Move mq_notify from librt to libc The symbol was moved using scripts/move-symbol-to-libc.py. An explicit call from fork into the mq_notify implementation replaces the previous use of pthread_atfork. Reviewed-by: Adhemerva Zanella <adhemerval.zanella(a)linaro.org> --- include/mqueue.h | 4 ++ include/pthread.h | 3 ++ rt/Makefile | 2 +- rt/Versions | 4 +- sysdeps/nptl/fork.h | 3 ++ sysdeps/unix/sysv/linux/aarch64/libc.abilist | 2 + sysdeps/unix/sysv/linux/aarch64/librt.abilist | 1 - sysdeps/unix/sysv/linux/alpha/libc.abilist | 2 + sysdeps/unix/sysv/linux/alpha/librt.abilist | 1 - sysdeps/unix/sysv/linux/arc/libc.abilist | 2 + sysdeps/unix/sysv/linux/arc/librt.abilist | 1 - sysdeps/unix/sysv/linux/arm/be/libc.abilist | 2 + sysdeps/unix/sysv/linux/arm/be/librt.abilist | 1 - sysdeps/unix/sysv/linux/arm/le/libc.abilist | 2 + sysdeps/unix/sysv/linux/arm/le/librt.abilist | 1 - sysdeps/unix/sysv/linux/csky/libc.abilist | 2 + sysdeps/unix/sysv/linux/csky/librt.abilist | 1 - sysdeps/unix/sysv/linux/hppa/libc.abilist | 2 + sysdeps/unix/sysv/linux/hppa/librt.abilist | 1 - sysdeps/unix/sysv/linux/i386/libc.abilist | 2 + sysdeps/unix/sysv/linux/i386/librt.abilist | 1 - sysdeps/unix/sysv/linux/ia64/libc.abilist | 2 + sysdeps/unix/sysv/linux/ia64/librt.abilist | 1 - sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist | 2 + .../unix/sysv/linux/m68k/coldfire/librt.abilist | 1 - sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist | 2 + sysdeps/unix/sysv/linux/m68k/m680x0/librt.abilist | 1 - sysdeps/unix/sysv/linux/microblaze/be/libc.abilist | 2 + .../unix/sysv/linux/microblaze/be/librt.abilist | 1 - sysdeps/unix/sysv/linux/microblaze/le/libc.abilist | 2 + .../unix/sysv/linux/microblaze/le/librt.abilist | 1 - .../unix/sysv/linux/mips/mips32/fpu/libc.abilist | 2 + sysdeps/unix/sysv/linux/mips/mips32/librt.abilist | 1 - .../unix/sysv/linux/mips/mips32/nofpu/libc.abilist | 2 + .../unix/sysv/linux/mips/mips64/n32/libc.abilist | 2 + .../unix/sysv/linux/mips/mips64/n32/librt.abilist | 1 - .../unix/sysv/linux/mips/mips64/n64/libc.abilist | 2 + .../unix/sysv/linux/mips/mips64/n64/librt.abilist | 1 - sysdeps/unix/sysv/linux/mq_notify.c | 59 +++++++++------------- sysdeps/unix/sysv/linux/nios2/libc.abilist | 2 + sysdeps/unix/sysv/linux/nios2/librt.abilist | 1 - .../sysv/linux/powerpc/powerpc32/fpu/libc.abilist | 2 + .../sysv/linux/powerpc/powerpc32/librt.abilist | 1 - .../linux/powerpc/powerpc32/nofpu/libc.abilist | 2 + .../sysv/linux/powerpc/powerpc64/be/libc.abilist | 2 + .../sysv/linux/powerpc/powerpc64/be/librt.abilist | 1 - .../sysv/linux/powerpc/powerpc64/le/libc.abilist | 2 + .../sysv/linux/powerpc/powerpc64/le/librt.abilist | 1 - sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist | 2 + sysdeps/unix/sysv/linux/riscv/rv32/librt.abilist | 1 - sysdeps/unix/sysv/linux/riscv/rv64/libc.abilist | 2 + sysdeps/unix/sysv/linux/riscv/rv64/librt.abilist | 1 - sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist | 2 + sysdeps/unix/sysv/linux/s390/s390-32/librt.abilist | 1 - sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist | 2 + sysdeps/unix/sysv/linux/s390/s390-64/librt.abilist | 1 - sysdeps/unix/sysv/linux/sh/be/libc.abilist | 2 + sysdeps/unix/sysv/linux/sh/be/librt.abilist | 1 - sysdeps/unix/sysv/linux/sh/le/libc.abilist | 2 + sysdeps/unix/sysv/linux/sh/le/librt.abilist | 1 - sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist | 2 + .../unix/sysv/linux/sparc/sparc32/librt.abilist | 1 - sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist | 2 + .../unix/sysv/linux/sparc/sparc64/librt.abilist | 1 - sysdeps/unix/sysv/linux/x86_64/64/libc.abilist | 2 + sysdeps/unix/sysv/linux/x86_64/64/librt.abilist | 1 - sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist | 2 + sysdeps/unix/sysv/linux/x86_64/x32/librt.abilist | 1 - 68 files changed, 101 insertions(+), 68 deletions(-) diff --git a/include/mqueue.h b/include/mqueue.h index 008589f0fa..2c40c1e3fc 100644 --- a/include/mqueue.h +++ b/include/mqueue.h @@ -15,6 +15,10 @@ hidden_proto (mq_setattr) # if PTHREAD_IN_LIBC libc_hidden_proto (mq_setattr) + +/* Called from fork so that the new subprocess re-creates the + notification thread if necessary. */ +void __mq_notify_fork_subprocess (void) attribute_hidden; # endif #include <struct___timespec64.h> diff --git a/include/pthread.h b/include/pthread.h index 1158919247..819bf3f235 100644 --- a/include/pthread.h +++ b/include/pthread.h @@ -13,6 +13,9 @@ libc_hidden_proto (__pthread_barrier_init) #endif extern int __pthread_barrier_wait (pthread_barrier_t *__barrier) __THROWNL __nonnull ((1)); +#if PTHREAD_IN_LIBC +libc_hidden_proto (__pthread_barrier_wait) +#endif /* This function is called to initialize the pthread library. */ extern void __pthread_initialize (void) __attribute__ ((weak)); diff --git a/rt/Makefile b/rt/Makefile index f753a9aa7a..e86a3107ee 100644 --- a/rt/Makefile +++ b/rt/Makefile @@ -30,7 +30,6 @@ routines = \ librt-routines = \ librt-compat \ - mq_notify \ mq_open \ mq_receive \ mq_send \ @@ -62,6 +61,7 @@ $(librt-routines-var) += \ lio_listio64 \ mq_close \ mq_getattr \ + mq_notify \ mq_setattr \ tests := tst-shm tst-timer tst-timer2 \ diff --git a/rt/Versions b/rt/Versions index 38f23c16ef..b3c9bba9ff 100644 --- a/rt/Versions +++ b/rt/Versions @@ -28,6 +28,7 @@ libc { %if PTHREAD_IN_LIBC mq_close; mq_getattr; + mq_notify; mq_setattr; %endif } @@ -58,6 +59,7 @@ libc { lio_listio64; mq_close; mq_getattr; + mq_notify; mq_setattr; %endif shm_open; @@ -112,9 +114,9 @@ librt { %if !PTHREAD_IN_LIBC mq_close; mq_getattr; + mq_notify; mq_setattr; %endif - mq_notify; mq_open; mq_receive; mq_send; diff --git a/sysdeps/nptl/fork.h b/sysdeps/nptl/fork.h index 3134d7ab94..1fc3a83bd3 100644 --- a/sysdeps/nptl/fork.h +++ b/sysdeps/nptl/fork.h @@ -22,6 +22,7 @@ #include <assert.h> #include <ldsodefs.h> #include <list.h> +#include <mqueue.h> #include <pthreadP.h> #include <sysdep.h> @@ -41,6 +42,8 @@ fork_system_setup_after_fork (void) /* Initialize thread library locks. */ GL (dl_stack_cache_lock) = LLL_LOCK_INITIALIZER; __default_pthread_attr_lock = LLL_LOCK_INITIALIZER; + + call_function_static_weak (__mq_notify_fork_subprocess); } /* In case of a fork() call the memory allocation in the child will be diff --git a/sysdeps/unix/sysv/linux/aarch64/libc.abilist b/sysdeps/unix/sysv/linux/aarch64/libc.abilist index c6b225527c..98dd344aaf 100644 --- a/sysdeps/unix/sysv/linux/aarch64/libc.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/libc.abilist @@ -1359,6 +1359,7 @@ GLIBC_2.17 mprobe F GLIBC_2.17 mprotect F GLIBC_2.17 mq_close F GLIBC_2.17 mq_getattr F +GLIBC_2.17 mq_notify F GLIBC_2.17 mq_setattr F GLIBC_2.17 mrand48 F GLIBC_2.17 mrand48_r F @@ -2404,6 +2405,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/aarch64/librt.abilist b/sysdeps/unix/sysv/linux/aarch64/librt.abilist index 33b825d874..6cab033b12 100644 --- a/sysdeps/unix/sysv/linux/aarch64/librt.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.17 __mq_open_2 F -GLIBC_2.17 mq_notify F GLIBC_2.17 mq_open F GLIBC_2.17 mq_receive F GLIBC_2.17 mq_send F diff --git a/sysdeps/unix/sysv/linux/alpha/libc.abilist b/sysdeps/unix/sysv/linux/alpha/libc.abilist index 4930bfef60..5026e54d51 100644 --- a/sysdeps/unix/sysv/linux/alpha/libc.abilist +++ b/sysdeps/unix/sysv/linux/alpha/libc.abilist @@ -2394,6 +2394,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2499,6 +2500,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/alpha/librt.abilist b/sysdeps/unix/sysv/linux/alpha/librt.abilist index 29f9030371..d85884d888 100644 --- a/sysdeps/unix/sysv/linux/alpha/librt.abilist +++ b/sysdeps/unix/sysv/linux/alpha/librt.abilist @@ -10,7 +10,6 @@ GLIBC_2.3.3 timer_delete F GLIBC_2.3.3 timer_getoverrun F GLIBC_2.3.3 timer_gettime F GLIBC_2.3.3 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/arc/libc.abilist b/sysdeps/unix/sysv/linux/arc/libc.abilist index 78a01ca136..f677395bd2 100644 --- a/sysdeps/unix/sysv/linux/arc/libc.abilist +++ b/sysdeps/unix/sysv/linux/arc/libc.abilist @@ -1290,6 +1290,7 @@ GLIBC_2.32 mprobe F GLIBC_2.32 mprotect F GLIBC_2.32 mq_close F GLIBC_2.32 mq_getattr F +GLIBC_2.32 mq_notify F GLIBC_2.32 mq_setattr F GLIBC_2.32 mrand48 F GLIBC_2.32 mrand48_r F @@ -2163,6 +2164,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/arc/librt.abilist b/sysdeps/unix/sysv/linux/arc/librt.abilist index 4143924c8b..16864093a0 100644 --- a/sysdeps/unix/sysv/linux/arc/librt.abilist +++ b/sysdeps/unix/sysv/linux/arc/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.32 __mq_open_2 F -GLIBC_2.32 mq_notify F GLIBC_2.32 mq_open F GLIBC_2.32 mq_receive F GLIBC_2.32 mq_send F diff --git a/sysdeps/unix/sysv/linux/arm/be/libc.abilist b/sysdeps/unix/sysv/linux/arm/be/libc.abilist index 4ad531fb76..38e6fc61d4 100644 --- a/sysdeps/unix/sysv/linux/arm/be/libc.abilist +++ b/sysdeps/unix/sysv/linux/arm/be/libc.abilist @@ -315,6 +315,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F @@ -1731,6 +1732,7 @@ GLIBC_2.4 mprobe F GLIBC_2.4 mprotect F GLIBC_2.4 mq_close F GLIBC_2.4 mq_getattr F +GLIBC_2.4 mq_notify F GLIBC_2.4 mq_setattr F GLIBC_2.4 mrand48 F GLIBC_2.4 mrand48_r F diff --git a/sysdeps/unix/sysv/linux/arm/be/librt.abilist b/sysdeps/unix/sysv/linux/arm/be/librt.abilist index ba9f5f6422..6d3cb7c1fa 100644 --- a/sysdeps/unix/sysv/linux/arm/be/librt.abilist +++ b/sysdeps/unix/sysv/linux/arm/be/librt.abilist @@ -2,7 +2,6 @@ GLIBC_2.34 __mq_timedreceive_time64 F GLIBC_2.34 __mq_timedsend_time64 F GLIBC_2.34 __timer_gettime64 F GLIBC_2.34 __timer_settime64 F -GLIBC_2.4 mq_notify F GLIBC_2.4 mq_open F GLIBC_2.4 mq_receive F GLIBC_2.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/arm/le/libc.abilist b/sysdeps/unix/sysv/linux/arm/le/libc.abilist index aae2e215f3..c31f58229a 100644 --- a/sysdeps/unix/sysv/linux/arm/le/libc.abilist +++ b/sysdeps/unix/sysv/linux/arm/le/libc.abilist @@ -312,6 +312,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F @@ -1728,6 +1729,7 @@ GLIBC_2.4 mprobe F GLIBC_2.4 mprotect F GLIBC_2.4 mq_close F GLIBC_2.4 mq_getattr F +GLIBC_2.4 mq_notify F GLIBC_2.4 mq_setattr F GLIBC_2.4 mrand48 F GLIBC_2.4 mrand48_r F diff --git a/sysdeps/unix/sysv/linux/arm/le/librt.abilist b/sysdeps/unix/sysv/linux/arm/le/librt.abilist index ba9f5f6422..6d3cb7c1fa 100644 --- a/sysdeps/unix/sysv/linux/arm/le/librt.abilist +++ b/sysdeps/unix/sysv/linux/arm/le/librt.abilist @@ -2,7 +2,6 @@ GLIBC_2.34 __mq_timedreceive_time64 F GLIBC_2.34 __mq_timedsend_time64 F GLIBC_2.34 __timer_gettime64 F GLIBC_2.34 __timer_settime64 F -GLIBC_2.4 mq_notify F GLIBC_2.4 mq_open F GLIBC_2.4 mq_receive F GLIBC_2.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/csky/libc.abilist b/sysdeps/unix/sysv/linux/csky/libc.abilist index 0bbe74a51a..bd0cec183d 100644 --- a/sysdeps/unix/sysv/linux/csky/libc.abilist +++ b/sysdeps/unix/sysv/linux/csky/libc.abilist @@ -1345,6 +1345,7 @@ GLIBC_2.29 mprobe F GLIBC_2.29 mprotect F GLIBC_2.29 mq_close F GLIBC_2.29 mq_getattr F +GLIBC_2.29 mq_notify F GLIBC_2.29 mq_setattr F GLIBC_2.29 mrand48 F GLIBC_2.29 mrand48_r F @@ -2424,6 +2425,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/csky/librt.abilist b/sysdeps/unix/sysv/linux/csky/librt.abilist index 1ffc068f62..7c20548140 100644 --- a/sysdeps/unix/sysv/linux/csky/librt.abilist +++ b/sysdeps/unix/sysv/linux/csky/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.29 __mq_open_2 F -GLIBC_2.29 mq_notify F GLIBC_2.29 mq_open F GLIBC_2.29 mq_receive F GLIBC_2.29 mq_send F diff --git a/sysdeps/unix/sysv/linux/hppa/libc.abilist b/sysdeps/unix/sysv/linux/hppa/libc.abilist index f96ed60028..e089d91a80 100644 --- a/sysdeps/unix/sysv/linux/hppa/libc.abilist +++ b/sysdeps/unix/sysv/linux/hppa/libc.abilist @@ -2208,6 +2208,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2378,6 +2379,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/hppa/librt.abilist b/sysdeps/unix/sysv/linux/hppa/librt.abilist index d208e7b7a8..c4164f4149 100644 --- a/sysdeps/unix/sysv/linux/hppa/librt.abilist +++ b/sysdeps/unix/sysv/linux/hppa/librt.abilist @@ -4,7 +4,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/i386/libc.abilist b/sysdeps/unix/sysv/linux/i386/libc.abilist index a724074718..d04f1e1a95 100644 --- a/sysdeps/unix/sysv/linux/i386/libc.abilist +++ b/sysdeps/unix/sysv/linux/i386/libc.abilist @@ -2389,6 +2389,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2562,6 +2563,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/i386/librt.abilist b/sysdeps/unix/sysv/linux/i386/librt.abilist index d208e7b7a8..c4164f4149 100644 --- a/sysdeps/unix/sysv/linux/i386/librt.abilist +++ b/sysdeps/unix/sysv/linux/i386/librt.abilist @@ -4,7 +4,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/ia64/libc.abilist b/sysdeps/unix/sysv/linux/ia64/libc.abilist index 3b5c72f307..c7569a5138 100644 --- a/sysdeps/unix/sysv/linux/ia64/libc.abilist +++ b/sysdeps/unix/sysv/linux/ia64/libc.abilist @@ -2243,6 +2243,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2337,6 +2338,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/ia64/librt.abilist b/sysdeps/unix/sysv/linux/ia64/librt.abilist index 38edc31e90..1ec96c2786 100644 --- a/sysdeps/unix/sysv/linux/ia64/librt.abilist +++ b/sysdeps/unix/sysv/linux/ia64/librt.abilist @@ -9,7 +9,6 @@ GLIBC_2.3.3 timer_delete F GLIBC_2.3.3 timer_getoverrun F GLIBC_2.3.3 timer_gettime F GLIBC_2.3.3 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist index 85de809b2d..57139d935a 100644 --- a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist +++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist @@ -316,6 +316,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F @@ -1715,6 +1716,7 @@ GLIBC_2.4 mprobe F GLIBC_2.4 mprotect F GLIBC_2.4 mq_close F GLIBC_2.4 mq_getattr F +GLIBC_2.4 mq_notify F GLIBC_2.4 mq_setattr F GLIBC_2.4 mrand48 F GLIBC_2.4 mrand48_r F diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/librt.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/librt.abilist index ba9f5f6422..6d3cb7c1fa 100644 --- a/sysdeps/unix/sysv/linux/m68k/coldfire/librt.abilist +++ b/sysdeps/unix/sysv/linux/m68k/coldfire/librt.abilist @@ -2,7 +2,6 @@ GLIBC_2.34 __mq_timedreceive_time64 F GLIBC_2.34 __mq_timedsend_time64 F GLIBC_2.34 __timer_gettime64 F GLIBC_2.34 __timer_settime64 F -GLIBC_2.4 mq_notify F GLIBC_2.4 mq_open F GLIBC_2.4 mq_receive F GLIBC_2.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist index a9abdfa950..5fd9bf57ec 100644 --- a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist +++ b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist @@ -2332,6 +2332,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2505,6 +2506,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/librt.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/librt.abilist index d208e7b7a8..c4164f4149 100644 --- a/sysdeps/unix/sysv/linux/m68k/m680x0/librt.abilist +++ b/sysdeps/unix/sysv/linux/m68k/m680x0/librt.abilist @@ -4,7 +4,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist b/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist index 6bf22e63e3..434b3f6844 100644 --- a/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist +++ b/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist @@ -1361,6 +1361,7 @@ GLIBC_2.18 mprobe F GLIBC_2.18 mprotect F GLIBC_2.18 mq_close F GLIBC_2.18 mq_getattr F +GLIBC_2.18 mq_notify F GLIBC_2.18 mq_setattr F GLIBC_2.18 mrand48 F GLIBC_2.18 mrand48_r F @@ -2475,6 +2476,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/microblaze/be/librt.abilist b/sysdeps/unix/sysv/linux/microblaze/be/librt.abilist index a8bbeb6a20..f82d9ba705 100644 --- a/sysdeps/unix/sysv/linux/microblaze/be/librt.abilist +++ b/sysdeps/unix/sysv/linux/microblaze/be/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.18 __mq_open_2 F -GLIBC_2.18 mq_notify F GLIBC_2.18 mq_open F GLIBC_2.18 mq_receive F GLIBC_2.18 mq_send F diff --git a/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist b/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist index 4e211638c9..1d97080a9c 100644 --- a/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist +++ b/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist @@ -1361,6 +1361,7 @@ GLIBC_2.18 mprobe F GLIBC_2.18 mprotect F GLIBC_2.18 mq_close F GLIBC_2.18 mq_getattr F +GLIBC_2.18 mq_notify F GLIBC_2.18 mq_setattr F GLIBC_2.18 mrand48 F GLIBC_2.18 mrand48_r F @@ -2472,6 +2473,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/microblaze/le/librt.abilist b/sysdeps/unix/sysv/linux/microblaze/le/librt.abilist index a8bbeb6a20..f82d9ba705 100644 --- a/sysdeps/unix/sysv/linux/microblaze/le/librt.abilist +++ b/sysdeps/unix/sysv/linux/microblaze/le/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.18 __mq_open_2 F -GLIBC_2.18 mq_notify F GLIBC_2.18 mq_open F GLIBC_2.18 mq_receive F GLIBC_2.18 mq_send F diff --git a/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist index 96d2e57a71..d43b66902d 100644 --- a/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist @@ -2300,6 +2300,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2470,6 +2471,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/mips/mips32/librt.abilist b/sysdeps/unix/sysv/linux/mips/mips32/librt.abilist index 7704fd1722..12c3cbae0d 100644 --- a/sysdeps/unix/sysv/linux/mips/mips32/librt.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips32/librt.abilist @@ -3,7 +3,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist index 3f8736354d..86dfc85225 100644 --- a/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist @@ -2298,6 +2298,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2468,6 +2469,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist index ab6ca602b9..3314c50b3c 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist @@ -2306,6 +2306,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2476,6 +2477,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n32/librt.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/librt.abilist index 7704fd1722..12c3cbae0d 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n32/librt.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips64/n32/librt.abilist @@ -3,7 +3,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist index 328abb0e02..a23ebf24a8 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist @@ -2300,6 +2300,7 @@ GLIBC_2.3.4 getipv4sourcefilter F GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2393,6 +2394,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/librt.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/librt.abilist index a249a4623f..7afe4e83cf 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n64/librt.abilist +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/librt.abilist @@ -3,7 +3,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/mq_notify.c b/sysdeps/unix/sysv/linux/mq_notify.c index e22850a910..9799dcdaa4 100644 --- a/sysdeps/unix/sysv/linux/mq_notify.c +++ b/sysdeps/unix/sysv/linux/mq_notify.c @@ -29,7 +29,7 @@ #include <sys/socket.h> #include <not-cancel.h> #include <pthreadP.h> - +#include <shlib-compat.h> /* Defined in the kernel headers: */ #define NOTIFY_COOKIE_LEN 32 /* Length of the cookie used. */ @@ -75,7 +75,7 @@ change_sigmask (int how, sigset_t *oss) { sigset_t ss; sigfillset (&ss); - return pthread_sigmask (how, &ss, oss); + return __pthread_sigmask (how, &ss, oss); } @@ -93,7 +93,7 @@ notification_function (void *arg) (void) __pthread_barrier_wait (&notify_barrier); /* Make the thread detached. */ - (void) pthread_detach (pthread_self ()); + __pthread_detach (__pthread_self ()); /* The parent thread has all signals blocked. This is probably a bit surprising for this thread. So we unblock all of them. */ @@ -125,9 +125,8 @@ helper_thread (void *arg) /* Just create the thread as instructed. There is no way to report a problem with creating a thread. */ pthread_t th; - if (__builtin_expect (pthread_create (&th, data.attr, - notification_function, &data) - == 0, 0)) + if (__pthread_create (&th, data.attr, notification_function, &data) + == 0) /* Since we passed a pointer to DATA to the new thread we have to wait until it is done with it. */ (void) __pthread_barrier_wait (&notify_barrier); @@ -135,7 +134,7 @@ helper_thread (void *arg) else if (data.raw[NOTIFY_COOKIE_LEN - 1] == NOTIFY_REMOVED) { /* The only state we keep is the copy of the thread attributes. */ - pthread_attr_destroy (data.attr); + __pthread_attr_destroy (data.attr); free (data.attr); } } @@ -143,8 +142,8 @@ helper_thread (void *arg) } -static void -reset_once (void) +void +__mq_notify_fork_subprocess (void) { once = PTHREAD_ONCE_INIT; } @@ -167,15 +166,14 @@ init_mq_netlink (void) int err = 1; /* Initialize the barrier. */ - if (__builtin_expect (__pthread_barrier_init (&notify_barrier, NULL, 2) == 0, - 0)) + if (__pthread_barrier_init (&notify_barrier, NULL, 2) == 0) { /* Create the helper thread. */ pthread_attr_t attr; - (void) pthread_attr_init (&attr); - (void) pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED); + __pthread_attr_init (&attr); + __pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED); /* We do not need much stack space, the bare minimum will be enough. */ - (void) pthread_attr_setstacksize (&attr, __pthread_get_minstack (&attr)); + __pthread_attr_setstacksize (&attr, __pthread_get_minstack (&attr)); /* Temporarily block all signals so that the newly created thread inherits the mask. */ @@ -183,29 +181,13 @@ init_mq_netlink (void) int have_no_oss = change_sigmask (SIG_BLOCK, &oss); pthread_t th; - err = pthread_create (&th, &attr, helper_thread, NULL); + err = __pthread_create (&th, &attr, helper_thread, NULL); /* Reset the signal mask. */ if (!have_no_oss) - pthread_sigmask (SIG_SETMASK, &oss, NULL); - - (void) pthread_attr_destroy (&attr); + __pthread_sigmask (SIG_SETMASK, &oss, NULL); - if (err == 0) - { - static int added_atfork; - - if (added_atfork == 0 - && pthread_atfork (NULL, NULL, reset_once) != 0) - { - /* The child thread will call recv() which is a - cancellation point. */ - (void) pthread_cancel (th); - err = 1; - } - else - added_atfork = 1; - } + __pthread_attr_destroy (&attr); } if (err != 0) @@ -219,7 +201,7 @@ init_mq_netlink (void) /* Register notification upon message arrival to an empty message queue MQDES. */ int -mq_notify (mqd_t mqdes, const struct sigevent *notification) +__mq_notify (mqd_t mqdes, const struct sigevent *notification) { /* Make sure the type is correctly defined. */ assert (sizeof (union notify_data) == NOTIFY_COOKIE_LEN); @@ -235,7 +217,7 @@ mq_notify (mqd_t mqdes, const struct sigevent *notification) response. */ /* Initialize only once. */ - pthread_once (&once, init_mq_netlink); + __pthread_once (&once, init_mq_netlink); /* If we cannot create the netlink socket we cannot provide SIGEV_THREAD support. */ @@ -280,9 +262,14 @@ mq_notify (mqd_t mqdes, const struct sigevent *notification) /* If it failed, free the allocated memory. */ if (retval != 0 && data.attr != NULL) { - pthread_attr_destroy (data.attr); + __pthread_attr_destroy (data.attr); free (data.attr); } return retval; } +versioned_symbol (libc, __mq_notify, mq_notify, GLIBC_2_34); +libc_hidden_ver (__mq_notify, mq_notify) +#if OTHER_SHLIB_COMPAT (librt, GLIBC_2_3_4, GLIBC_2_34) +compat_symbol (librt, __mq_notify, mq_notify, GLIBC_2_3_4); +#endif diff --git a/sysdeps/unix/sysv/linux/nios2/libc.abilist b/sysdeps/unix/sysv/linux/nios2/libc.abilist index b8dd80465f..50b5f57efc 100644 --- a/sysdeps/unix/sysv/linux/nios2/libc.abilist +++ b/sysdeps/unix/sysv/linux/nios2/libc.abilist @@ -1404,6 +1404,7 @@ GLIBC_2.21 mprobe F GLIBC_2.21 mprotect F GLIBC_2.21 mq_close F GLIBC_2.21 mq_getattr F +GLIBC_2.21 mq_notify F GLIBC_2.21 mq_setattr F GLIBC_2.21 mrand48 F GLIBC_2.21 mrand48_r F @@ -2514,6 +2515,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/nios2/librt.abilist b/sysdeps/unix/sysv/linux/nios2/librt.abilist index 64a169169f..0ad1b47423 100644 --- a/sysdeps/unix/sysv/linux/nios2/librt.abilist +++ b/sysdeps/unix/sysv/linux/nios2/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.21 __mq_open_2 F -GLIBC_2.21 mq_notify F GLIBC_2.21 mq_open F GLIBC_2.21 mq_receive F GLIBC_2.21 mq_send F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist index 04a263f810..c8b663ff2f 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist @@ -2346,6 +2346,7 @@ GLIBC_2.3.4 longjmp F GLIBC_2.3.4 makecontext F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2532,6 +2533,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/librt.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/librt.abilist index d208e7b7a8..c4164f4149 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/librt.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/librt.abilist @@ -4,7 +4,6 @@ GLIBC_2.2 timer_delete F GLIBC_2.2 timer_getoverrun F GLIBC_2.2 timer_gettime F GLIBC_2.2 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist index 9e8043323c..551af732bb 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist @@ -2379,6 +2379,7 @@ GLIBC_2.3.4 longjmp F GLIBC_2.3.4 makecontext F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2565,6 +2566,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist index 21e7cb9a28..a79b8863e1 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist @@ -2192,6 +2192,7 @@ GLIBC_2.3.4 getsourcefilter F GLIBC_2.3.4 longjmp F GLIBC_2.3.4 mq_close F GLIBC_2.3.4 mq_getattr F +GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_setattr F GLIBC_2.3.4 pthread_attr_getaffinity_np F GLIBC_2.3.4 pthread_attr_setaffinity_np F @@ -2301,6 +2302,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/librt.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/librt.abilist index 073df9d157..a7117238c4 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/librt.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/librt.abilist @@ -8,7 +8,6 @@ GLIBC_2.3.3 timer_delete F GLIBC_2.3.3 timer_getoverrun F GLIBC_2.3.3 timer_gettime F GLIBC_2.3.3 timer_settime F -GLIBC_2.3.4 mq_notify F GLIBC_2.3.4 mq_open F GLIBC_2.3.4 mq_receive F GLIBC_2.3.4 mq_send F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist index 5487741113..89293145e4 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist @@ -1447,6 +1447,7 @@ GLIBC_2.17 mprobe F GLIBC_2.17 mprotect F GLIBC_2.17 mq_close F GLIBC_2.17 mq_getattr F +GLIBC_2.17 mq_notify F GLIBC_2.17 mq_setattr F GLIBC_2.17 mrand48 F GLIBC_2.17 mrand48_r F @@ -2600,6 +2601,7 @@ GLIBC_2.34 lio_listio F GLIBC_2.34 lio_listio64 F GLIBC_2.34 mq_close F GLIBC_2.34 mq_getattr F +GLIBC_2.34 mq_notify F GLIBC_2.34 mq_setattr F GLIBC_2.34 mtx_destroy F GLIBC_2.34 mtx_init F diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/librt.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/librt.abilist index 33b825d874..6cab033b12 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/librt.abilist +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/librt.abilist @@ -1,5 +1,4 @@ GLIBC_2.17 __mq_open_2 F -GLIBC_2.17 mq_notify F GLIBC_2.17 mq_open F GLIBC_2.17 mq_receive F GLIBC_2.17 mq_send F </cut>

3 years, 11 months

1
0
0 0

[ACTIVITY] week ending 11 Jul 2021

by Richard Henderson

[ UM-2 ] * Sent v2 vdso + signal page patch set. * Fix #457 (tb_phys_invalidate_cont) * Fix #187 (arm on s390x) * Sent new rev for i386 fcs:fip patch set. * Sent v3 translator_use_goto_tb patch set. * Sent bswap cleanup. * Sent tcg_constant cleanups: alpha, hppa, openrisc, riscv. r~

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_cross/gnu-release-aarch64-check_cross - Build # 27 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *binutils* in CI configuration tcwg_cross/gnu-release-aarch64-check_cross. So far, this commit has regressed CI configurations: - tcwg_cross/gnu-release-aarch64-check_cross Culprit: <cut> commit abe2a28aaa7a2bfd0f3061c72a98eb898976b721 Author: Nick Clifton <nickc(a)redhat.com> Date: Fri Jul 9 16:39:06 2021 +0100 Backportpatch to fix parsing of DWARF fuction and variable tags. PR 27484 bfd * dwarf2.c (scan_unit_for_symbols): Scan twice, once to accumulate function and variable tags and a second time to resolve their attributes. </cut> Results regressed to (for first_bad == abe2a28aaa7a2bfd0f3061c72a98eb898976b721) # reset_artifacts: -10 # build_abe binutils: -8 # build_abe stage1: -7 # build_abe linux: -6 # build_abe glibc: -5 # build_abe stage2: -4 # build_abe qemu: -3 # build_abe dejagnu: 0 # build_abe check_gcc --: 1 # Getting actual results from build directory /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/libitm.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/libgomp.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/libstdc++.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/g++.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/gcc.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/gfortran.sum # /home/tcwg-buildslave/workspace/tcwg_gnu_1/artifacts/build-abe2a28aaa7a2bfd0f3061c72a98eb898976b721/sumfiles/libatomic.sum # Manifest: gcc-compare-results/contrib/testsuite-management/flaky.xfail # Getting actual results from build directory base-artifacts/sumfiles # base-artifacts/sumfiles/libitm.sum # base-artifacts/sumfiles/libgomp.sum # base-artifacts/sumfiles/libstdc++.sum # base-artifacts/sumfiles/g++.sum # base-artifacts/sumfiles/gcc.sum # base-artifacts/sumfiles/gfortran.sum # base-artifacts/sumfiles/libatomic.sum # # SUCCESS: No unexpected failures. from (for last_good == 814d9ecf9b08018aa8ae2cd768ad8628945fd6aa) # reset_artifacts: -10 # build_abe binutils: -8 # build_abe stage1: -7 # build_abe linux: -6 # build_abe glibc: -5 # build_abe stage2: -4 # build_abe qemu: -3 # build_abe dejagnu: 0 # build_abe check_gcc --: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Build top page/logs: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Configuration details: Reproduce builds: <cut> mkdir investigate-binutils-abe2a28aaa7a2bfd0f3061c72a98eb898976b721 cd investigate-binutils-abe2a28aaa7a2bfd0f3061c72a98eb898976b721 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd binutils # Reproduce first_bad build git checkout --detach abe2a28aaa7a2bfd0f3061c72a98eb898976b721 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 814d9ecf9b08018aa8ae2cd768ad8628945fd6aa ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Build log: https://ci.linaro.org/job/tcwg_cross-bisect-gnu-release-aarch64-check_cross… Full commit (up to 1000 lines): <cut> commit abe2a28aaa7a2bfd0f3061c72a98eb898976b721 Author: Nick Clifton <nickc(a)redhat.com> Date: Fri Jul 9 16:39:06 2021 +0100 Backportpatch to fix parsing of DWARF fuction and variable tags. PR 27484 bfd * dwarf2.c (scan_unit_for_symbols): Scan twice, once to accumulate function and variable tags and a second time to resolve their attributes. --- bfd/ChangeLog | 10 +++++ bfd/dwarf2.c | 134 ++++++++++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 117 insertions(+), 27 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index a8b7415fadc..cd6f3706fe2 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,13 @@ +2021-07-09 Nick Clifton <nickc(a)redhat.com> + + Backport this patch from the mainline: + 2021-03-02 Nick Clifton <nickc(a)redhat.com> + + PR 27484 + * dwarf2.c (scan_unit_for_symbols): Scan twice, once to accumulate + function and variable tags and a second time to resolve their + attributes. + 2021-05-03 Alan Modra <amodra(a)gmail.com> PR 27755 diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c index 5651696c0f7..02618154a21 100644 --- a/bfd/dwarf2.c +++ b/bfd/dwarf2.c @@ -1484,6 +1484,8 @@ struct funcinfo struct arange arange; /* Where the symbol is defined. */ asection * sec; + /* The offset of the funcinfo from the start of the unit. */ + bfd_uint64_t unit_offset; }; struct lookup_funcinfo @@ -3304,6 +3306,15 @@ read_rangelist (struct comp_unit *unit, struct arange *arange, return read_rnglists (unit, arange, offset); } +static struct funcinfo * +lookup_func_by_offset (bfd_uint64_t offset, struct funcinfo * table) +{ + for (; table != NULL; table = table->prev_func) + if (table->unit_offset == offset) + return table; + return NULL; +} + static struct varinfo * lookup_var_by_offset (bfd_uint64_t offset, struct varinfo * table) { @@ -3317,7 +3328,6 @@ lookup_var_by_offset (bfd_uint64_t offset, struct varinfo * table) return NULL; } - /* DWARF2 Compilation unit functions. */ /* Scan over each die in a comp. unit looking for functions to add @@ -3330,7 +3340,8 @@ scan_unit_for_symbols (struct comp_unit *unit) bfd_byte *info_ptr = unit->first_child_die_ptr; bfd_byte *info_ptr_end = unit->end_ptr; int nesting_level = 0; - struct nest_funcinfo { + struct nest_funcinfo + { struct funcinfo *func; } *nested_funcs; int nested_funcs_size; @@ -3344,16 +3355,16 @@ scan_unit_for_symbols (struct comp_unit *unit) return FALSE; nested_funcs[nesting_level].func = 0; + /* PR 27484: We must scan the DIEs twice. The first time we look for + function and variable tags and accumulate them into their respective + tables. The second time through we process the attributes of the + functions/variables and augment the table entries. */ while (nesting_level >= 0) { unsigned int abbrev_number, bytes_read, i; struct abbrev_info *abbrev; - struct attribute attr; struct funcinfo *func; struct varinfo *var; - bfd_vma low_pc = 0; - bfd_vma high_pc = 0; - bfd_boolean high_pc_relative = FALSE; bfd_uint64_t current_offset; /* PR 17512: file: 9f405d9d. */ @@ -3365,7 +3376,7 @@ scan_unit_for_symbols (struct comp_unit *unit) FALSE, info_ptr_end); info_ptr += bytes_read; - if (! abbrev_number) + if (abbrev_number == 0) { nesting_level--; continue; @@ -3400,6 +3411,7 @@ scan_unit_for_symbols (struct comp_unit *unit) goto fail; func->tag = abbrev->tag; func->prev_func = unit->function_table; + func->unit_offset = current_offset; unit->function_table = func; unit->number_of_functions++; BFD_ASSERT (!unit->cached); @@ -3420,6 +3432,7 @@ scan_unit_for_symbols (struct comp_unit *unit) || abbrev->tag == DW_TAG_member) { size_t amt = sizeof (struct varinfo); + var = (struct varinfo *) bfd_zalloc (abfd, amt); if (var == NULL) goto fail; @@ -3438,6 +3451,89 @@ scan_unit_for_symbols (struct comp_unit *unit) nested_funcs[nesting_level].func = 0; } + for (i = 0; i < abbrev->num_attrs; ++i) + { + struct attribute attr; + + info_ptr = read_attribute (&attr, &abbrev->attrs[i], + unit, info_ptr, info_ptr_end); + if (info_ptr == NULL) + goto fail; + } + + if (abbrev->has_children) + { + nesting_level++; + + if (nesting_level >= nested_funcs_size) + { + struct nest_funcinfo *tmp; + + nested_funcs_size *= 2; + tmp = (struct nest_funcinfo *) + bfd_realloc (nested_funcs, + nested_funcs_size * sizeof (*nested_funcs)); + if (tmp == NULL) + goto fail; + nested_funcs = tmp; + } + nested_funcs[nesting_level].func = 0; + } + } + + /* This is the second pass over the abbrevs. */ + info_ptr = unit->first_child_die_ptr; + nesting_level = 0; + + while (nesting_level >= 0) + { + unsigned int abbrev_number, bytes_read, i; + struct abbrev_info *abbrev; + struct attribute attr; + struct funcinfo *func; + struct varinfo *var; + bfd_vma low_pc = 0; + bfd_vma high_pc = 0; + bfd_boolean high_pc_relative = FALSE; + bfd_uint64_t current_offset; + + /* PR 17512: file: 9f405d9d. */ + if (info_ptr >= info_ptr_end) + goto fail; + + current_offset = info_ptr - unit->info_ptr_unit; + abbrev_number = _bfd_safe_read_leb128 (abfd, info_ptr, &bytes_read, + FALSE, info_ptr_end); + info_ptr += bytes_read; + + if (! abbrev_number) + { + nesting_level--; + continue; + } + + abbrev = lookup_abbrev (abbrev_number, unit->abbrevs); + /* This should have been handled above. */ + BFD_ASSERT (abbrev != NULL); + + func = NULL; + var = NULL; + if (abbrev->tag == DW_TAG_subprogram + || abbrev->tag == DW_TAG_entry_point + || abbrev->tag == DW_TAG_inlined_subroutine) + { + func = lookup_func_by_offset (current_offset, unit->function_table); + if (func == NULL) + goto fail; + } + else if (abbrev->tag == DW_TAG_variable + || abbrev->tag == DW_TAG_member) + { + var = lookup_var_by_offset (current_offset, unit->variable_table); + if (var == NULL) + goto fail; + } + for (i = 0; i < abbrev->num_attrs; ++i) { info_ptr = read_attribute (&attr, &abbrev->attrs[i], @@ -3532,7 +3628,7 @@ scan_unit_for_symbols (struct comp_unit *unit) { _bfd_error_handler (_("DWARF error: could not find " "variable specification " - "at offset %lx"), + "at offset 0x%lx"), (unsigned long) attr.u.val); break; } @@ -3604,6 +3700,9 @@ scan_unit_for_symbols (struct comp_unit *unit) } } + if (abbrev->has_children) + nesting_level++; + if (high_pc_relative) high_pc += low_pc; @@ -3612,25 +3711,6 @@ scan_unit_for_symbols (struct comp_unit *unit) if (!arange_add (unit, &func->arange, low_pc, high_pc)) goto fail; } - - if (abbrev->has_children) - { - nesting_level++; - - if (nesting_level >= nested_funcs_size) - { - struct nest_funcinfo *tmp; - - nested_funcs_size *= 2; - tmp = (struct nest_funcinfo *) - bfd_realloc (nested_funcs, - nested_funcs_size * sizeof (*nested_funcs)); - if (tmp == NULL) - goto fail; - nested_funcs = tmp; - } - nested_funcs[nesting_level].func = 0; - } } free (nested_funcs); </cut>

3 years, 11 months

1
0
0 0

[ACTIVITY] report week ending 9 Jul

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Code review: - RTH's translator_use_goto_tb() series - Shashi's v5 ITS series + Arm pullreq * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Good progress with implementing more insns: VMULL poly, VIDUP, VIWDUP, VDDUP, VDWDUP, VCMP, VPT, VPSEL, VMLAS, VSHL T2, VRSHL T2, VQSHL T2, VQRSHL T2, VMAXV, VMINV, VMAXAV, VMINAV, VABAV, VMOVN, VQMOVUN, VQMOVN, VMLADAV, VMLSDAV, VMLA, VQDMLAH, VQRDMLAH, VQDMLASH, VQRDMLASH, VQABS, VQNEG, VMAXA, VMINA, VMOV-to-2gp, VMOV-from-2gp, VPNOT + Remaining is mostly floating point, and some loads and stores + Progress: 161/210 (76%) thanks -- PMM

3 years, 11 months

1
0
0 0

[ACTIVITY] week ending Jul. 11 2021

by Alex Bennée

QEMU Upstream Work ([UM-2]) =========================== - spent some time pulling together various maintainer trees for final 6.1 PRs - hopefully [this is the last iteration before Monday] - posted [PATCH for 6.1 v2 0/5] custom device configs Message-Id: <20210707131744.26027-1-alex.bennee(a)linaro.org> - chips away at the mega ARM re-factor patch set - posted [PATCH v1 0/2] some device emulation documentation cleanup Message-Id: <20210707184549.24436-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> [this is the last iteration before Monday] <https://patchew.org/QEMU/20210709143005.1554-1-alex.bennee@linaro.org/> Other ===== - ARM CCA Announcement Event - Rust Training - Bunch of meetings with various members talking about future for QEMU - now the JIRA is migrated there are some things to add - wrote and abstract for KVM forum and [experimented with some visualisation] [experimented with some visualisation] <https://mastodon.org.uk/web/statuses/106535665831189241> Announced QEMU 6.1 on Linux Open Discussion Message-Id: <87zgv0tt7a.fsf(a)linaro.org> Completed Reviews [5/5] ======================= [PATCH v6 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI) Message-Id: <20210608031425.833536-1-crosa(a)redhat.com> [PATCH v4 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Message-Id: <20210623142245.307776-1-berrange(a)redhat.com> [PATCH v4 0/5] plugins: New TCG plugin for cache modelling Message-Id: <20210623125458.450462-1-ma.mandourr(a)gmail.com> [PATCH v3 0/2] execlog TCG plugin to log instructions Message-Id: <20210702081307.1653644-1-erdnaxe(a)crans.org> [PATCH 0/3] ci: use cirrus-run to utilize Cirrus CI from GitLab CI Message-Id: <20210625172211.451010-1-berrange(a)redhat.com> Absences ======== Current Review Queue ==================== TODO [PATCH v5 00/10] GICv3 LPI and ITS feature implementation Message-Id: <20210630153156.9421-1-shashi.mallela(a)linaro.org> =========================================================================================================================== TODO [PATCH 00/17] tcg: breakpoint reorg Message-Id: <20210701152537.3330420-1-richard.henderson(a)linaro.org> =========================================================================================================== TODO [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Message-Id: <20210630183226.3290849-1-richard.henderson(a)linaro.org> ==================================================================================================================================== TODO [PATCH v3 00/29] tcg: bswap improvements Message-Id: <20210626063631.2411938-1-richard.henderson(a)linaro.org> ================================================================================================================ -- Alex Bennée

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-master-arm-spec2k6-Oz_LTO - Build # 10 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-Oz_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-Oz_LTO Culprit: <cut> commit 51d334a845a082338735b0fdfc620a4b15fa26fe Author: Max Kazantsev <mkazantsev(a)azul.com> Date: Thu May 27 13:20:57 2021 +0700 [NFCI] Lazily evaluate SCEVs of PHIs Eager evaluation has cost of compile time. Only query them if they are required for proving predicates. </cut> Results regressed to (for first_bad == 51d334a845a082338735b0fdfc620a4b15fa26fe) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz_LTO_mthumb -- artifacts/build-51d334a845a082338735b0fdfc620a4b15fa26fe/results_id: 1 # 450.soplex,soplex_base.default regressed by 509909 # 473.astar,astar_base.default regressed by 4232401 # 453.povray,povray_base.default regressed by 166915 # 403.gcc,gcc_base.default regressed by 50755 from (for last_good == 59d938e649e62db0cef4903d495e838fbc6a6eb8) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz_LTO_mthumb -- artifacts/build-59d938e649e62db0cef4903d495e838fbc6a6eb8/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-Oz_LTO/1235 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-Oz_LTO/1241 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-51d334a845a082338735b0fdfc620a4b15fa26fe cd investigate-llvm-51d334a845a082338735b0fdfc620a4b15fa26fe git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 51d334a845a082338735b0fdfc620a4b15fa26fe ../artifacts/test.sh # Reproduce last_good build git checkout --detach 59d938e649e62db0cef4903d495e838fbc6a6eb8 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Full commit (up to 1000 lines): <cut> commit 51d334a845a082338735b0fdfc620a4b15fa26fe Author: Max Kazantsev <mkazantsev(a)azul.com> Date: Thu May 27 13:20:57 2021 +0700 [NFCI] Lazily evaluate SCEVs of PHIs Eager evaluation has cost of compile time. Only query them if they are required for proving predicates. --- llvm/lib/Transforms/Scalar/LoopDeletion.cpp | 115 +++++++++++++++++----------- 1 file changed, 72 insertions(+), 43 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/LoopDeletion.cpp b/llvm/lib/Transforms/Scalar/LoopDeletion.cpp index cd2a3fc48e3b..ed6b078fcf8e 100644 --- a/llvm/lib/Transforms/Scalar/LoopDeletion.cpp +++ b/llvm/lib/Transforms/Scalar/LoopDeletion.cpp @@ -136,30 +136,88 @@ static bool isLoopNeverExecuted(Loop *L) { return true; } +BasicBlock * +getSolePredecessorOnFirstIteration(BasicBlock *BB, Loop *L, + const DenseSet<BasicBlockEdge> &LiveEdges) { + if (BB == L->getHeader()) + return L->getLoopPredecessor(); + BasicBlock *OnlyPred = nullptr; + for (auto *Pred : predecessors(BB)) + if (OnlyPred != Pred && LiveEdges.count({ Pred, BB })) { + // 2 live preds. + if (OnlyPred) + return nullptr; + OnlyPred = Pred; + } + + assert(OnlyPred && "No live predecessors?"); + return OnlyPred; +} + +// Forward declaration. +static const SCEV * +getSCEVOnFirstIteration(Value *V, Loop *L, DominatorTree &DT, + ScalarEvolution &SE, + DenseMap<Value *, const SCEV *> &FirstIterSCEV, + const DenseSet<BasicBlockEdge> &LiveEdges); + static const SCEV * -getSCEVOnFirstIteration(Value *V, Loop *L, ScalarEvolution &SE, - DenseMap<Value *, const SCEV *> &FirstIterSCEV) { +getPHISCEVOnFirstIteration(PHINode *PN, Loop *L, DominatorTree &DT, + ScalarEvolution &SE, + DenseMap<Value *, const SCEV *> &FirstIterSCEV, + const DenseSet<BasicBlockEdge> &LiveEdges) { + auto *BB = PN->getParent(); + if (!L->contains(PN)) + return SE.getSCEV(PN); + // If this block has only one live pred, map its phis onto their SCEVs. + // Check if there is only one predecessor on 1st iteration. Note that because + // we iterate in RPOT, we have already visited all its (non-latch) + // predecessors. + auto *OnlyPred = getSolePredecessorOnFirstIteration(BB, L, LiveEdges); + if (!OnlyPred) + return SE.getSCEV(PN); + auto *Incoming = PN->getIncomingValueForBlock(OnlyPred); + if (DT.dominates(Incoming, BB->getTerminator())) + return getSCEVOnFirstIteration(Incoming, L, DT, SE, FirstIterSCEV, + LiveEdges); + return SE.getSCEV(PN); +} + +static const SCEV * +getSCEVOnFirstIteration(Value *V, Loop *L, DominatorTree &DT, + ScalarEvolution &SE, + DenseMap<Value *, const SCEV *> &FirstIterSCEV, + const DenseSet<BasicBlockEdge> &LiveEdges) { // Fist, check in cache. auto Existing = FirstIterSCEV.find(V); if (Existing != FirstIterSCEV.end()) return Existing->second; + const SCEV *S = nullptr; // TODO: Once ScalarEvolution supports getValueOnNthIteration for anything // else but AddRecs, it's a good use case for it. So far, just consider some // simple cases, like arithmetic operations. Value *LHS, *RHS; using namespace PatternMatch; - if (match(V, m_Add(m_Value(LHS), m_Value(RHS)))) { - const SCEV *LHSS = getSCEVOnFirstIteration(LHS, L, SE, FirstIterSCEV); - const SCEV *RHSS = getSCEVOnFirstIteration(RHS, L, SE, FirstIterSCEV); + if (auto *PN = dyn_cast<PHINode>(V)) { + S = getPHISCEVOnFirstIteration(PN, L, DT, SE, FirstIterSCEV, LiveEdges); + } else if (match(V, m_Add(m_Value(LHS), m_Value(RHS)))) { + const SCEV *LHSS = + getSCEVOnFirstIteration(LHS, L, DT, SE, FirstIterSCEV, LiveEdges); + const SCEV *RHSS = + getSCEVOnFirstIteration(RHS, L, DT, SE, FirstIterSCEV, LiveEdges); S = SE.getAddExpr(LHSS, RHSS); } else if (match(V, m_Sub(m_Value(LHS), m_Value(RHS)))) { - const SCEV *LHSS = getSCEVOnFirstIteration(LHS, L, SE, FirstIterSCEV); - const SCEV *RHSS = getSCEVOnFirstIteration(RHS, L, SE, FirstIterSCEV); + const SCEV *LHSS = + getSCEVOnFirstIteration(LHS, L, DT, SE, FirstIterSCEV, LiveEdges); + const SCEV *RHSS = + getSCEVOnFirstIteration(RHS, L, DT, SE, FirstIterSCEV, LiveEdges); S = SE.getMinusSCEV(LHSS, RHSS); } else if (match(V, m_Mul(m_Value(LHS), m_Value(RHS)))) { - const SCEV *LHSS = getSCEVOnFirstIteration(LHS, L, SE, FirstIterSCEV); - const SCEV *RHSS = getSCEVOnFirstIteration(RHS, L, SE, FirstIterSCEV); + const SCEV *LHSS = + getSCEVOnFirstIteration(LHS, L, DT, SE, FirstIterSCEV, LiveEdges); + const SCEV *RHSS = + getSCEVOnFirstIteration(RHS, L, DT, SE, FirstIterSCEV, LiveEdges); S = SE.getMulExpr(LHSS, RHSS); } else S = SE.getSCEV(V); @@ -185,7 +243,7 @@ static bool canProveExitOnFirstIteration(Loop *L, DominatorTree &DT, SmallPtrSet<BasicBlock *, 4> LiveBlocks; // Edges that are reachable on the 1st iteration. DenseSet<BasicBlockEdge> LiveEdges; - LiveBlocks.insert(L->getHeader()); + LiveBlocks.insert(Header); auto MarkLiveEdge = [&](BasicBlock *From, BasicBlock *To) { assert(LiveBlocks.count(From) && "Must be live!"); @@ -198,24 +256,6 @@ static bool canProveExitOnFirstIteration(Loop *L, DominatorTree &DT, MarkLiveEdge(BB, Succ); }; - // Check if there is only one predecessor on 1st iteration. Note that because - // we iterate in RPOT, we have already visited all its (non-latch) - // predecessors. - auto GetSolePredecessorOnFirstIteration = [&](BasicBlock * BB)->BasicBlock * { - if (BB == Header) - return L->getLoopPredecessor(); - BasicBlock *OnlyPred = nullptr; - for (auto *Pred : predecessors(BB)) - if (OnlyPred != Pred && LiveEdges.count({ Pred, BB })) { - // 2 live preds. - if (OnlyPred) - return nullptr; - OnlyPred = Pred; - } - - assert(OnlyPred && "No live predecessors?"); - return OnlyPred; - }; DenseMap<Value *, const SCEV *> FirstIterSCEV; SmallPtrSet<BasicBlock *, 4> Visited; @@ -250,19 +290,6 @@ static bool canProveExitOnFirstIteration(Loop *L, DominatorTree &DT, if (!Visited.count(Pred)) return false; - // If this block has only one live pred, map its phis onto their SCEVs. - if (auto *OnlyPred = GetSolePredecessorOnFirstIteration(BB)) - for (auto &PN : BB->phis()) { - if (!SE.isSCEVable(PN.getType())) - continue; - auto *Incoming = PN.getIncomingValueForBlock(OnlyPred); - if (DT.dominates(Incoming, BB->getTerminator())) { - const SCEV *IncSCEV = - getSCEVOnFirstIteration(Incoming, L, SE, FirstIterSCEV); - FirstIterSCEV[&PN] = IncSCEV; - } - } - using namespace PatternMatch; ICmpInst::Predicate Pred; Value *LHS, *RHS; @@ -281,8 +308,10 @@ static bool canProveExitOnFirstIteration(Loop *L, DominatorTree &DT, } // Can we prove constant true or false for this condition? - const SCEV *LHSS = getSCEVOnFirstIteration(LHS, L, SE, FirstIterSCEV); - const SCEV *RHSS = getSCEVOnFirstIteration(RHS, L, SE, FirstIterSCEV); + const SCEV *LHSS = + getSCEVOnFirstIteration(LHS, L, DT, SE, FirstIterSCEV, LiveEdges); + const SCEV *RHSS = + getSCEVOnFirstIteration(RHS, L, DT, SE, FirstIterSCEV, LiveEdges); // Only query for liveness of in-loop edge if another successor is also // in-loop. // TODO: isKnownPredicateAt is more powerful, but it's too compile time </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-master-arm-spec2k6-O3_LTO - Build # 28 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O3_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O3_LTO Culprit: <cut> commit 52a5fe70a2c77935afe807fb6e904e512ddd894e Author: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> Date: Tue Mar 2 17:06:02 2021 -0300 Use 64 bit time_t stat internally For the legacy ABI with supports 32-bit time_t it calls the 64-bit time directly, since the LFS symbols calls the 64-bit time_t ones internally. Checked on i686-linux-gnu and x86_64-linux-gnu. Reviewed-by: Lukasz Majewski <lukma(a)denx.de> </cut> Results regressed to (for first_bad == 52a5fe70a2c77935afe807fb6e904e512ddd894e) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO_marm -- artifacts/build-52a5fe70a2c77935afe807fb6e904e512ddd894e/results_id: 1 # 465.tonto,tonto_base.default regressed by 104 from (for last_good == a318262bc0081ab83e3f3c90e50462f99148605e) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO_marm -- artifacts/build-a318262bc0081ab83e3f3c90e50462f99148605e/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O3_LTO/1228 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O3_LTO/1189 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-52a5fe70a2c77935afe807fb6e904e512ddd894e cd investigate-glibc-52a5fe70a2c77935afe807fb6e904e512ddd894e git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach 52a5fe70a2c77935afe807fb6e904e512ddd894e ../artifacts/test.sh # Reproduce last_good build git checkout --detach a318262bc0081ab83e3f3c90e50462f99148605e ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Full commit (up to 1000 lines): <cut> commit 52a5fe70a2c77935afe807fb6e904e512ddd894e Author: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> Date: Tue Mar 2 17:06:02 2021 -0300 Use 64 bit time_t stat internally For the legacy ABI with supports 32-bit time_t it calls the 64-bit time directly, since the LFS symbols calls the 64-bit time_t ones internally. Checked on i686-linux-gnu and x86_64-linux-gnu. Reviewed-by: Lukasz Majewski <lukma(a)denx.de> --- csu/check_fds.c | 8 ++++---- elf/dl-load.c | 8 ++++---- elf/dl-misc.c | 4 ++-- elf/dl-profile.c | 4 ++-- iconv/gconv_cache.c | 4 ++-- include/dirent.h | 2 +- include/file_change_detection.h | 6 +++--- inet/rcmd.c | 6 +++--- intl/loadmsgcat.c | 4 ++-- io/Makefile | 4 ++-- io/file_change_detection.c | 10 +++++----- io/getdirname.c | 6 +++--- libio/filedoalloc.c | 2 +- libio/fileops.c | 8 ++++---- libio/oldfileops.c | 2 +- libio/wfileops.c | 2 +- locale/loadarchive.c | 8 ++++---- locale/loadlocale.c | 6 +++--- nscd/nscd_helper.c | 4 ++-- nss/nss_database.c | 4 ++-- sysdeps/posix/dl-fileid.h | 4 ++-- sysdeps/posix/euidaccess.c | 4 ++-- sysdeps/posix/getaddrinfo.c | 18 +++++++++--------- sysdeps/posix/getcwd.c | 15 ++++++++------- sysdeps/posix/pathconf.c | 4 ++-- sysdeps/posix/sysconf.c | 4 ++-- sysdeps/posix/tempname.c | 8 ++++---- sysdeps/unix/sysv/linux/fdopendir.c | 4 ++-- sysdeps/unix/sysv/linux/fexecve.c | 4 ++-- sysdeps/unix/sysv/linux/opendir.c | 7 ++++--- sysdeps/unix/sysv/linux/pathconf.c | 5 +++-- sysdeps/unix/sysv/linux/ttyname.h | 10 ++-------- sysdeps/unix/sysv/linux/ttyname_r.c | 16 ++++++++-------- sysvipc/ftok.c | 4 ++-- time/tzfile.c | 6 +++--- 35 files changed, 106 insertions(+), 109 deletions(-) diff --git a/csu/check_fds.c b/csu/check_fds.c index fbab28c284..6dc67334af 100644 --- a/csu/check_fds.c +++ b/csu/check_fds.c @@ -69,10 +69,10 @@ check_one_fd (int fd, int mode) Note that the following code assumes that STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO are the three lowest file decsriptor numbers, in this order. */ - struct stat64 st; - if (__builtin_expect (nullfd != fd, 0) - || __builtin_expect (__fstat64 (fd, &st), 0) != 0 - || __builtin_expect (S_ISCHR (st.st_mode), 1) == 0 + struct __stat64_t64 st; + if (__glibc_unlikely (nullfd != fd) + || __glibc_likely (__fstat64_time64 (fd, &st) != 0) + || __glibc_unlikely (S_ISCHR (st.st_mode) == 0) || st.st_rdev != dev) /* We cannot even give an error message here since it would run into the same problems. */ diff --git a/elf/dl-load.c b/elf/dl-load.c index 918ec7546c..a08df001af 100644 --- a/elf/dl-load.c +++ b/elf/dl-load.c @@ -1946,11 +1946,11 @@ open_path (const char *name, size_t namelen, int mode, { /* We failed to open machine dependent library. Let's test whether there is any directory at all. */ - struct stat64 st; + struct __stat64_t64 st; buf[buflen - namelen - 1] = '\0'; - if (__stat64 (buf, &st) != 0 + if (__stat64_time64 (buf, &st) != 0 || ! S_ISDIR (st.st_mode)) /* The directory does not exist or it is no directory. */ this_dir->status[cnt] = nonexisting; @@ -1968,9 +1968,9 @@ open_path (const char *name, size_t namelen, int mode, /* This is an extra security effort to make sure nobody can preload broken shared objects which are in the trusted directories and so exploit the bugs. */ - struct stat64 st; + struct __stat64_t64 st; - if (__fstat64 (fd, &st) != 0 + if (__fstat64_time64 (fd, &st) != 0 || (st.st_mode & S_ISUID) == 0) { /* The shared object cannot be tested for being SUID diff --git a/elf/dl-misc.c b/elf/dl-misc.c index d4803bba4e..b256d792c6 100644 --- a/elf/dl-misc.c +++ b/elf/dl-misc.c @@ -43,11 +43,11 @@ void * _dl_sysdep_read_whole_file (const char *file, size_t *sizep, int prot) { void *result = MAP_FAILED; - struct stat64 st; + struct __stat64_t64 st; int fd = __open64_nocancel (file, O_RDONLY | O_CLOEXEC); if (fd >= 0) { - if (__fstat64 (fd, &st) >= 0) + if (__fstat64_time64 (fd, &st) >= 0) { *sizep = st.st_size; diff --git a/elf/dl-profile.c b/elf/dl-profile.c index 35b03959bc..088c023d95 100644 --- a/elf/dl-profile.c +++ b/elf/dl-profile.c @@ -185,7 +185,7 @@ _dl_start_profile (void) { char *filename; int fd; - struct stat64 st; + struct __stat64_t64 st; const ElfW(Phdr) *ph; ElfW(Addr) mapstart = ~((ElfW(Addr)) 0); ElfW(Addr) mapend = 0; @@ -342,7 +342,7 @@ _dl_start_profile (void) return; } - if (__fstat64 (fd, &st) < 0 || !S_ISREG (st.st_mode)) + if (__fstat64_time64 (fd, &st) < 0 || !S_ISREG (st.st_mode)) { /* Not stat'able or not a regular file => don't use it. */ errstr = "%s: cannot stat file: %s\n"; diff --git a/iconv/gconv_cache.c b/iconv/gconv_cache.c index 642cc731eb..68d6386d01 100644 --- a/iconv/gconv_cache.c +++ b/iconv/gconv_cache.c @@ -48,7 +48,7 @@ int __gconv_load_cache (void) { int fd; - struct stat64 st; + struct __stat64_t64 st; struct gconvcache_header *header; /* We cannot use the cache if the GCONV_PATH environment variable is @@ -64,7 +64,7 @@ __gconv_load_cache (void) return -1; /* Get information about the file. */ - if (__builtin_expect (__fstat64 (fd, &st), 0) < 0 + if (__glibc_unlikely (__fstat64_time64 (fd, &st) < 0) /* We do not have to start looking at the file if it cannot contain at least the cache header. */ || (size_t) st.st_size < sizeof (struct gconvcache_header)) diff --git a/include/dirent.h b/include/dirent.h index f1d7e8359c..d7567f5e86 100644 --- a/include/dirent.h +++ b/include/dirent.h @@ -49,7 +49,7 @@ extern int __versionsort64 (const struct dirent64 **a, const struct dirent64 **b) __attribute_pure__; extern DIR *__alloc_dir (int fd, bool close_fd, int flags, - const struct stat64 *statp) + const struct __stat64_t64 *statp) __nonnull (4) attribute_hidden; extern __typeof (rewinddir) __rewinddir; extern __typeof (seekdir) __seekdir; diff --git a/include/file_change_detection.h b/include/file_change_detection.h index 9de2bd0b79..953de7c7fd 100644 --- a/include/file_change_detection.h +++ b/include/file_change_detection.h @@ -33,8 +33,8 @@ struct file_change_detection off64_t size; ino64_t ino; - struct timespec mtime; - struct timespec ctime; + struct __timespec64 mtime; + struct __timespec64 ctime; }; /* Returns true if *LEFT and *RIGHT describe the same version of the @@ -45,7 +45,7 @@ bool __file_is_unchanged (const struct file_change_detection *left, /* Extract file change information to *FILE from the stat buffer *ST. */ void __file_change_detection_for_stat (struct file_change_detection *file, - const struct stat64 *st); + const struct __stat64_t64 *st); /* Writes file change information for PATH to *FILE. Returns true on success. For benign errors, *FILE is cleared, and true is diff --git a/inet/rcmd.c b/inet/rcmd.c index 0cfdaee15e..0d6b595572 100644 --- a/inet/rcmd.c +++ b/inet/rcmd.c @@ -468,14 +468,14 @@ ruserok (const char *rhost, int superuser, const char *ruser, static FILE * iruserfopen (const char *file, uid_t okuser) { - struct stat64 st; + struct __stat64_t64 st; char *cp = NULL; FILE *res = NULL; /* If not a regular file, if owned by someone other than user or root, if writeable by anyone but the owner, or if hardlinked anywhere, quit. */ - if (__lstat64 (file, &st)) + if (__lstat64_time64 (file, &st)) cp = _("lstat failed"); else if (!S_ISREG (st.st_mode)) cp = _("not regular file"); @@ -484,7 +484,7 @@ iruserfopen (const char *file, uid_t okuser) res = fopen (file, "rce"); if (!res) cp = _("cannot open"); - else if (__fstat64 (fileno (res), &st) < 0) + else if (__fstat64_time64 (fileno (res), &st) < 0) cp = _("fstat failed"); else if (st.st_uid && st.st_uid != okuser) cp = _("bad owner"); diff --git a/intl/loadmsgcat.c b/intl/loadmsgcat.c index 4fda9b0219..9b10697dd9 100644 --- a/intl/loadmsgcat.c +++ b/intl/loadmsgcat.c @@ -756,7 +756,7 @@ _nl_load_domain (struct loaded_l10nfile *domain_file, int fd = -1; size_t size; #ifdef _LIBC - struct stat64 st; + struct __stat64_t64 st; #else struct stat st; #endif @@ -804,7 +804,7 @@ _nl_load_domain (struct loaded_l10nfile *domain_file, /* We must know about the size of the file. */ if ( #ifdef _LIBC - __builtin_expect (__fstat64 (fd, &st) != 0, 0) + __glibc_unlikely (__fstat64_time64 (fd, &st) != 0) #else __builtin_expect (fstat (fd, &st) != 0, 0) #endif diff --git a/io/Makefile b/io/Makefile index ba8bd37355..1a16990205 100644 --- a/io/Makefile +++ b/io/Makefile @@ -69,7 +69,7 @@ tests := test-utime test-stat test-stat2 test-lfs tst-getcwd \ tst-posix_fallocate tst-posix_fallocate64 \ tst-fts tst-fts-lfs tst-open-tmpfile \ tst-copy_file_range tst-getcwd-abspath tst-lockf \ - tst-ftw-lnk tst-file_change_detection tst-lchmod \ + tst-ftw-lnk tst-lchmod \ tst-ftw-bz26353 tst-stat tst-stat-lfs \ tst-utime \ tst-utimes \ @@ -90,7 +90,7 @@ tests-time64 := \ tst-utimes-time64 \ # Likewise for statx, but we do not need static linking here. -tests-internal += tst-statx +tests-internal += tst-statx tst-file_change_detection tests-static += tst-statx ifeq ($(run-built-tests),yes) diff --git a/io/file_change_detection.c b/io/file_change_detection.c index 9871bc9166..fad0907223 100644 --- a/io/file_change_detection.c +++ b/io/file_change_detection.c @@ -44,7 +44,7 @@ libc_hidden_def (__file_is_unchanged) void __file_change_detection_for_stat (struct file_change_detection *file, - const struct stat64 *st) + const struct __stat64_t64 *st) { if (S_ISDIR (st->st_mode)) /* Treat as empty file. */ @@ -66,8 +66,8 @@ bool __file_change_detection_for_path (struct file_change_detection *file, const char *path) { - struct stat64 st; - if (__stat64 (path, &st) != 0) + struct __stat64_t64 st; + if (__stat64_time64 (path, &st) != 0) switch (errno) { case EACCES: @@ -104,8 +104,8 @@ __file_change_detection_for_fp (struct file_change_detection *file, } else { - struct stat64 st; - if (__fstat64 (__fileno (fp), &st) != 0) + struct __stat64_t64 st; + if (__fstat64_time64 (__fileno (fp), &st) != 0) /* If we already have a file descriptor, all errors are fatal. */ return false; else diff --git a/io/getdirname.c b/io/getdirname.c index 32b5ab4b6c..f29e910b37 100644 --- a/io/getdirname.c +++ b/io/getdirname.c @@ -28,12 +28,12 @@ char * get_current_dir_name (void) { char *pwd; - struct stat64 dotstat, pwdstat; + struct __stat64_t64 dotstat, pwdstat; pwd = getenv ("PWD"); if (pwd != NULL - && __stat64 (".", &dotstat) == 0 - && __stat64 (pwd, &pwdstat) == 0 + && __stat64_time64 (".", &dotstat) == 0 + && __stat64_time64 (pwd, &pwdstat) == 0 && pwdstat.st_dev == dotstat.st_dev && pwdstat.st_ino == dotstat.st_ino) /* The PWD value is correct. Use it. */ diff --git a/libio/filedoalloc.c b/libio/filedoalloc.c index 7afa3cb683..c792eec88f 100644 --- a/libio/filedoalloc.c +++ b/libio/filedoalloc.c @@ -78,7 +78,7 @@ _IO_file_doallocate (FILE *fp) { size_t size; char *p; - struct stat64 st; + struct __stat64_t64 st; size = BUFSIZ; if (fp->_fileno >= 0 && __builtin_expect (_IO_SYSSTAT (fp, &st), 0) >= 0) diff --git a/libio/fileops.c b/libio/fileops.c index a71a567547..e8ee374821 100644 --- a/libio/fileops.c +++ b/libio/fileops.c @@ -545,7 +545,7 @@ libc_hidden_ver (_IO_new_file_underflow, _IO_file_underflow) static int mmap_remap_check (FILE *fp) { - struct stat64 st; + struct __stat64_t64 st; if (_IO_SYSSTAT (fp, &st) == 0 && S_ISREG (st.st_mode) && st.st_size != 0 @@ -663,7 +663,7 @@ decide_maybe_mmap (FILE *fp) file descriptors are for mmap-able objects and on 32-bit machines we don't want to map files which are too large since this would require too much virtual memory. */ - struct stat64 st; + struct __stat64_t64 st; if (_IO_SYSSTAT (fp, &st) == 0 && S_ISREG (st.st_mode) && st.st_size != 0 @@ -962,7 +962,7 @@ _IO_new_file_seekoff (FILE *fp, off64_t offset, int dir, int mode) break; case _IO_seek_end: { - struct stat64 st; + struct __stat64_t64 st; if (_IO_SYSSTAT (fp, &st) == 0 && S_ISREG (st.st_mode)) { offset += st.st_size; @@ -1145,7 +1145,7 @@ libc_hidden_def (_IO_file_seek) int _IO_file_stat (FILE *fp, void *st) { - return __fstat64 (fp->_fileno, (struct stat64 *) st); + return __fstat64_time64 (fp->_fileno, (struct __stat64_t64 *) st); } libc_hidden_def (_IO_file_stat) diff --git a/libio/oldfileops.c b/libio/oldfileops.c index ed235360ad..ed3c98bd6d 100644 --- a/libio/oldfileops.c +++ b/libio/oldfileops.c @@ -487,7 +487,7 @@ _IO_old_file_seekoff (FILE *fp, off64_t offset, int dir, int mode) break; case _IO_seek_end: { - struct stat64 st; + struct __stat64_t64 st; if (_IO_SYSSTAT (fp, &st) == 0 && S_ISREG (st.st_mode)) { offset += st.st_size; diff --git a/libio/wfileops.c b/libio/wfileops.c index 5d23566171..37f44780f8 100644 --- a/libio/wfileops.c +++ b/libio/wfileops.c @@ -840,7 +840,7 @@ _IO_wfile_seekoff (FILE *fp, off64_t offset, int dir, int mode) break; case _IO_seek_end: { - struct stat64 st; + struct __stat64_t64 st; if (_IO_SYSSTAT (fp, &st) == 0 && S_ISREG (st.st_mode)) { offset += st.st_size; diff --git a/locale/loadarchive.c b/locale/loadarchive.c index 4177fc8972..512769eaec 100644 --- a/locale/loadarchive.c +++ b/locale/loadarchive.c @@ -78,7 +78,7 @@ static struct archmapped *archmapped; ARCHMAPPED points to this; if mapping the archive header failed, then headmap.ptr is null. */ static struct archmapped headmap; -static struct stat64 archive_stat; /* stat of archive when header mapped. */ +static struct __stat64_t64 archive_stat; /* stat of archive when header mapped. */ /* Record of locales that we have already loaded from the archive. */ struct locale_in_archive @@ -207,7 +207,7 @@ _nl_load_locale_from_archive (int category, const char **namep) /* Cannot open the archive, for whatever reason. */ return NULL; - if (__fstat64 (fd, &archive_stat) == -1) + if (__fstat64_time64 (fd, &archive_stat) == -1) { /* stat failed, very strange. */ close_and_out: @@ -396,7 +396,7 @@ _nl_load_locale_from_archive (int category, const char **namep) /* Open the file if it hasn't happened yet. */ if (fd == -1) { - struct stat64 st; + struct __stat64_t64 st; fd = __open_nocancel (archfname, O_RDONLY|O_LARGEFILE|O_CLOEXEC); if (fd == -1) @@ -405,7 +405,7 @@ _nl_load_locale_from_archive (int category, const char **namep) /* Now verify we think this is really the same archive file we opened before. If it has been changed we cannot trust the header we read previously. */ - if (__fstat64 (fd, &st) < 0 + if (__fstat64_time64 (fd, &st) < 0 || st.st_size != archive_stat.st_size || st.st_mtime != archive_stat.st_mtime || st.st_dev != archive_stat.st_dev diff --git a/locale/loadlocale.c b/locale/loadlocale.c index 9c03490883..f4e6cc9fc2 100644 --- a/locale/loadlocale.c +++ b/locale/loadlocale.c @@ -167,7 +167,7 @@ _nl_load_locale (struct loaded_l10nfile *file, int category) { int fd; void *filedata; - struct stat64 st; + struct __stat64_t64 st; struct __locale_data *newdata; int save_err; int alloc = ld_mapped; @@ -180,7 +180,7 @@ _nl_load_locale (struct loaded_l10nfile *file, int category) /* Cannot open the file. */ return; - if (__builtin_expect (__fstat64 (fd, &st), 0) < 0) + if (__glibc_unlikely (__fstat64_time64 (fd, &st) < 0)) { puntfd: __close_nocancel_nostatus (fd); @@ -206,7 +206,7 @@ _nl_load_locale (struct loaded_l10nfile *file, int category) if (__builtin_expect (fd, 0) < 0) return; - if (__builtin_expect (__fstat64 (fd, &st), 0) < 0) + if (__glibc_unlikely (__fstat64_time64 (fd, &st) < 0)) goto puntfd; } diff --git a/nscd/nscd_helper.c b/nscd/nscd_helper.c index 462504d828..06ba7476e5 100644 --- a/nscd/nscd_helper.c +++ b/nscd/nscd_helper.c @@ -324,8 +324,8 @@ __nscd_get_mapping (request_type type, const char *key, if (__glibc_unlikely (n == keylen)) { - struct stat64 st; - if (__builtin_expect (__fstat64 (mapfd, &st) != 0, 0) + struct __stat64_t64 st; + if (__glibc_unlikely (__fstat64_time64 (mapfd, &st) != 0) || __builtin_expect (st.st_size < sizeof (struct database_pers_head), 0)) goto out_close; diff --git a/nss/nss_database.c b/nss/nss_database.c index 1e11294406..ab121cb371 100644 --- a/nss/nss_database.c +++ b/nss/nss_database.c @@ -394,7 +394,7 @@ nss_database_check_reload_and_get (struct nss_database_state *local, nss_action_list *result, enum nss_database database_index) { - struct stat64 str; + struct __stat64_t64 str; /* Acquire MO is needed because the thread that sets reload_disabled may have loaded the configuration first, so synchronize with the @@ -424,7 +424,7 @@ nss_database_check_reload_and_get (struct nss_database_state *local, errors here are very unlikely, but the chance that we're entering a container is also very unlikely, so we err on the side of both very unlikely things not happening at the same time. */ - if (__stat64 ("/", &str) != 0 + if (__stat64_time64 ("/", &str) != 0 || (local->root_ino != 0 && (str.st_ino != local->root_ino || str.st_dev != local->root_dev))) diff --git a/sysdeps/posix/dl-fileid.h b/sysdeps/posix/dl-fileid.h index 0bb6794dbe..bf437f3d71 100644 --- a/sysdeps/posix/dl-fileid.h +++ b/sysdeps/posix/dl-fileid.h @@ -32,9 +32,9 @@ struct r_file_id static inline bool _dl_get_file_id (int fd, struct r_file_id *id) { - struct stat64 st; + struct __stat64_t64 st; - if (__glibc_unlikely (__fstat64 (fd, &st) < 0)) + if (__glibc_unlikely (__fstat64_time64 (fd, &st) < 0)) return false; id->dev = st.st_dev; diff --git a/sysdeps/posix/euidaccess.c b/sysdeps/posix/euidaccess.c index 26ebb432a2..86f3285471 100644 --- a/sysdeps/posix/euidaccess.c +++ b/sysdeps/posix/euidaccess.c @@ -119,7 +119,7 @@ int group_member (); int euidaccess (const char *path, int mode) { - struct stat64 stats; + struct __stat64_t64 stats; int granted; #ifdef _LIBC @@ -140,7 +140,7 @@ euidaccess (const char *path, int mode) return access (path, mode); #endif - if (__stat64 (path, &stats)) + if (__stat64_time64 (path, &stats)) return -1; mode &= (X_OK | W_OK | R_OK); /* Clear any bogus bits. */ diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c index b7e1aee80f..f7f19f1d7c 100644 --- a/sysdeps/posix/getaddrinfo.c +++ b/sysdeps/posix/getaddrinfo.c @@ -1636,16 +1636,16 @@ static int gaiconf_reload_flag_ever_set; /* Last modification time. */ #ifdef _STATBUF_ST_NSEC -static struct timespec gaiconf_mtime; +static struct __timespec64 gaiconf_mtime; static inline void -save_gaiconf_mtime (const struct stat64 *st) +save_gaiconf_mtime (const struct __stat64_t64 *st) { gaiconf_mtime = st->st_mtim; } static inline bool -check_gaiconf_mtime (const struct stat64 *st) +check_gaiconf_mtime (const struct __stat64_t64 *st) { return (st->st_mtim.tv_sec == gaiconf_mtime.tv_sec && st->st_mtim.tv_nsec == gaiconf_mtime.tv_nsec); @@ -1656,13 +1656,13 @@ check_gaiconf_mtime (const struct stat64 *st) static time_t gaiconf_mtime; static inline void -save_gaiconf_mtime (const struct stat64 *st) +save_gaiconf_mtime (const struct __stat64_t64 *st) { gaiconf_mtime = st->st_mtime; } static inline bool -check_gaiconf_mtime (const struct stat64 *st) +check_gaiconf_mtime (const struct __stat64_t64 *st) { return st->st_mtime == gaiconf_mtime; } @@ -1777,8 +1777,8 @@ gaiconf_init (void) FILE *fp = fopen (GAICONF_FNAME, "rce"); if (fp != NULL) { - struct stat64 st; - if (__fstat64 (fileno (fp), &st) != 0) + struct __stat64_t64 st; + if (__fstat64_time64 (fileno (fp), &st) != 0) { fclose (fp); goto no_file; @@ -2130,8 +2130,8 @@ gaiconf_init (void) static void gaiconf_reload (void) { - struct stat64 st; - if (__stat64 (GAICONF_FNAME, &st) != 0 + struct __stat64_t64 st; + if (__stat64_time64 (GAICONF_FNAME, &st) != 0 || !check_gaiconf_mtime (&st)) gaiconf_init (); } diff --git a/sysdeps/posix/getcwd.c b/sysdeps/posix/getcwd.c index f11644aae7..13680026ff 100644 --- a/sysdeps/posix/getcwd.c +++ b/sysdeps/posix/getcwd.c @@ -183,7 +183,7 @@ __getcwd_generic (char *buf, size_t size) ino_t rootino, thisino; char *dir; register char *dirp; - struct stat64 st; + struct __stat64_t64 st; size_t allocated = size; size_t used; @@ -249,12 +249,12 @@ __getcwd_generic (char *buf, size_t size) dirp = dir + allocated; *--dirp = '\0'; - if (__lstat64 (".", &st) < 0) + if (__lstat64_time64 (".", &st) < 0) goto lose; thisdev = st.st_dev; thisino = st.st_ino; - if (__lstat64 ("/", &st) < 0) + if (__lstat64_time64 ("/", &st) < 0) goto lose; rootdev = st.st_dev; rootino = st.st_ino; @@ -276,12 +276,12 @@ __getcwd_generic (char *buf, size_t size) if (fd < 0) goto lose; fd_needs_closing = true; - parent_status = __fstat64 (fd, &st); + parent_status = __fstat64_time64 (fd, &st); #else dotlist[dotlen++] = '.'; dotlist[dotlen++] = '.'; dotlist[dotlen] = '\0'; - parent_status = __lstat64 (dotlist, &st); + parent_status = __lstat64_time64 (dotlist, &st); #endif if (parent_status != 0) goto lose; @@ -353,7 +353,8 @@ __getcwd_generic (char *buf, size_t size) { int entry_status; #if HAVE_OPENAT_SUPPORT - entry_status = __fstatat64 (fd, d->d_name, &st, AT_SYMLINK_NOFOLLOW); + entry_status = __fstatat64_time64 (fd, d->d_name, &st, + AT_SYMLINK_NOFOLLOW); #else /* Compute size needed for this file name, or for the file name ".." in the same directory, whichever is larger. @@ -390,7 +391,7 @@ __getcwd_generic (char *buf, size_t size) } memcpy (dotlist + dotlen, d->d_name, _D_ALLOC_NAMLEN (d)); - entry_status = __lstat64 (dotlist, &st); + entry_status = __lstat64_time64 (dotlist, &st); #endif /* We don't fail here if we cannot stat() a directory entry. This can happen when (network) file systems fail. If this diff --git a/sysdeps/posix/pathconf.c b/sysdeps/posix/pathconf.c index 9eb17d1536..89fcfad49d 100644 --- a/sysdeps/posix/pathconf.c +++ b/sysdeps/posix/pathconf.c @@ -129,9 +129,9 @@ __pathconf (const char *path, int name) #ifdef _POSIX_ASYNC_IO { /* AIO is only allowed on regular files and block devices. */ - struct stat64 st; + struct __stat64_t64 st; - if (__stat64 (path, &st) < 0 + if (__stat64_time64 (path, &st) < 0 || (! S_ISREG (st.st_mode) && ! S_ISBLK (st.st_mode))) return -1; else diff --git a/sysdeps/posix/sysconf.c b/sysdeps/posix/sysconf.c index 54d6046d00..3e8ec5cd51 100644 --- a/sysdeps/posix/sysconf.c +++ b/sysdeps/posix/sysconf.c @@ -1215,8 +1215,8 @@ __sysconf_check_spec (const char *spec) "/POSIX_V6_", sizeof ("/POSIX_V6_") - 1), spec, speclen + 1); - struct stat64 st; - long int ret = __stat64 (name, &st) >= 0 ? 1 : -1; + struct __stat64_t64 st; + long int ret = __stat64_time64 (name, &st) >= 0 ? 1 : -1; __set_errno (save_errno); return ret; diff --git a/sysdeps/posix/tempname.c b/sysdeps/posix/tempname.c index 5f804b38d7..ff38f1e31f 100644 --- a/sysdeps/posix/tempname.c +++ b/sysdeps/posix/tempname.c @@ -55,14 +55,14 @@ #include <time.h> #if _LIBC -# define struct_stat64 struct stat64 +# define struct_stat64 struct __stat64_t64 # define __secure_getenv __libc_secure_getenv #else # define struct_stat64 struct stat # define __gen_tempname gen_tempname # define __mkdir mkdir # define __open open -# define __lstat64(file, buf) lstat (file, buf) +# define __lstat64_time64(file, buf) lstat (file, buf) # define __stat64(file, buf) stat (file, buf) # define __getrandom getrandom # define __clock_gettime64 clock_gettime @@ -99,7 +99,7 @@ static int direxists (const char *dir) { struct_stat64 buf; - return __stat64 (dir, &buf) == 0 && S_ISDIR (buf.st_mode); + return __stat64_time64 (dir, &buf) == 0 && S_ISDIR (buf.st_mode); } /* Path search algorithm, for tmpnam, tmpfile, etc. If DIR is @@ -191,7 +191,7 @@ try_nocreate (char *tmpl, void *flags _GL_UNUSED) { struct_stat64 st; - if (__lstat64 (tmpl, &st) == 0 || errno == EOVERFLOW) + if (__lstat64_time64 (tmpl, &st) == 0 || errno == EOVERFLOW) __set_errno (EEXIST); return errno == ENOENT ? 0 : -1; } diff --git a/sysdeps/unix/sysv/linux/fdopendir.c b/sysdeps/unix/sysv/linux/fdopendir.c index ede43f2485..32ec10e206 100644 --- a/sysdeps/unix/sysv/linux/fdopendir.c +++ b/sysdeps/unix/sysv/linux/fdopendir.c @@ -27,9 +27,9 @@ DIR * __fdopendir (int fd) { - struct stat64 statbuf; + struct __stat64_t64 statbuf; - if (__builtin_expect (__fstat64 (fd, &statbuf), 0) < 0) + if (__glibc_unlikely (__fstat64_time64 (fd, &statbuf) < 0)) return NULL; if (__glibc_unlikely (! S_ISDIR (statbuf.st_mode))) { diff --git a/sysdeps/unix/sysv/linux/fexecve.c b/sysdeps/unix/sysv/linux/fexecve.c index df25c2acb8..4dfcaeedc1 100644 --- a/sysdeps/unix/sysv/linux/fexecve.c +++ b/sysdeps/unix/sysv/linux/fexecve.c @@ -58,8 +58,8 @@ fexecve (int fd, char *const argv[], char *const envp[]) /* We come here only if the 'execve' call fails. Determine whether /proc is mounted. If not we return ENOSYS. */ - struct stat64 st; - if (__stat64 ("/proc/self/fd", &st) != 0 && errno == ENOENT) + struct __stat64_t64 st; + if (__stat64_time64 ("/proc/self/fd", &st) != 0 && errno == ENOENT) save = ENOSYS; __set_errno (save); diff --git a/sysdeps/unix/sysv/linux/opendir.c b/sysdeps/unix/sysv/linux/opendir.c index 4020a826f9..48f254d169 100644 --- a/sysdeps/unix/sysv/linux/opendir.c +++ b/sysdeps/unix/sysv/linux/opendir.c @@ -49,8 +49,8 @@ opendir_tail (int fd) /* Now make sure this really is a directory and nothing changed since the `stat' call. The S_ISDIR check is superfluous if O_DIRECTORY works, but it's cheap and we need the stat call for st_blksize anyway. */ - struct stat64 statbuf; - if (__glibc_unlikely (__fstat64 (fd, &statbuf) < 0)) + struct __stat64_t64 statbuf; + if (__glibc_unlikely (__fstat64_time64 (fd, &statbuf) < 0)) goto lose; if (__glibc_unlikely (! S_ISDIR (statbuf.st_mode))) { @@ -88,7 +88,8 @@ __opendir (const char *name) weak_alias (__opendir, opendir) DIR * -__alloc_dir (int fd, bool close_fd, int flags, const struct stat64 *statp) +__alloc_dir (int fd, bool close_fd, int flags, + const struct __stat64_t64 *statp) { /* We have to set the close-on-exit flag if the user provided the file descriptor. */ diff --git a/sysdeps/unix/sysv/linux/pathconf.c b/sysdeps/unix/sysv/linux/pathconf.c index f37e8aaf68..b599a66c93 100644 --- a/sysdeps/unix/sysv/linux/pathconf.c +++ b/sysdeps/unix/sysv/linux/pathconf.c @@ -65,9 +65,10 @@ distinguish_extX (const struct statfs *fsbuf, const char *file, int fd) { char buf[64]; char path[PATH_MAX]; - struct stat64 st; + struct __stat64_t64 st; - if ((file == NULL ? __fstat64 (fd, &st) : __stat64 (file, &st)) != 0) + if ((file == NULL ? __fstat64_time64 (fd, &st) + : __stat64_time64 (file, &st)) != 0) /* Strange. The statfd call worked, but stat fails. Default to the more pessimistic value. */ return EXT2_LINK_MAX; diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h index 0a0048cc02..5dcbfef973 100644 --- a/sysdeps/unix/sysv/linux/ttyname.h +++ b/sysdeps/unix/sysv/linux/ttyname.h @@ -25,24 +25,18 @@ linux/Documentation/devices.txt (on linux < 4.10) or linux/Documentation/admin-guide/devices.txt (on linux >= 4.10). */ static inline bool -is_pty (struct stat64 *sb) +is_pty (struct __stat64_t64 *sb) { -#ifdef _STATBUF_ST_RDEV int m = __gnu_dev_major (sb->st_rdev); return (136 <= m && m <= 143); -#else - return false; -#endif } static inline bool -is_mytty (const struct stat64 *mytty, const struct stat64 *maybe) +is_mytty (const struct __stat64_t64 *mytty, const struct __stat64_t64 *maybe) { return (maybe->st_ino == mytty->st_ino && maybe->st_dev == mytty->st_dev -#ifdef _STATBUF_ST_RDEV && S_ISCHR (maybe->st_mode) && maybe->st_rdev == mytty->st_rdev -#endif ); } diff --git a/sysdeps/unix/sysv/linux/ttyname_r.c b/sysdeps/unix/sysv/linux/ttyname_r.c index 899a851a83..9ef9f42883 100644 --- a/sysdeps/unix/sysv/linux/ttyname_r.c +++ b/sysdeps/unix/sysv/linux/ttyname_r.c @@ -31,15 +31,15 @@ #include "ttyname.h" static int getttyname_r (char *buf, size_t buflen, - const struct stat64 *mytty, int save, + const struct __stat64_t64 *mytty, int save, int *dostat); static int attribute_compat_text_section -getttyname_r (char *buf, size_t buflen, const struct stat64 *mytty, +getttyname_r (char *buf, size_t buflen, const struct __stat64_t64 *mytty, int save, int *dostat) { - struct stat64 st; + struct __stat64_t64 st; DIR *dirstream; struct dirent64 *d; size_t devlen = strlen (buf); @@ -71,7 +71,7 @@ getttyname_r (char *buf, size_t buflen, const struct stat64 *mytty, cp = __stpncpy (buf + devlen, d->d_name, needed); cp[0] = '\0'; - if (__stat64 (buf, &st) == 0 + if (__stat64_time64 (buf, &st) == 0 && is_mytty (mytty, &st)) { (void) __closedir (dirstream); @@ -93,7 +93,7 @@ int __ttyname_r (int fd, char *buf, size_t buflen) { struct fd_to_filename filename; - struct stat64 st, st1; + struct __stat64_t64 st, st1; int dostat = 0; int doispty = 0; int save = errno; @@ -118,7 +118,7 @@ __ttyname_r (int fd, char *buf, size_t buflen) if (__glibc_unlikely (__tcgetattr (fd, &term) < 0)) return errno; - if (__fstat64 (fd, &st) < 0) + if (__fstat64_time64 (fd, &st) < 0) return errno; /* We try using the /proc filesystem. */ @@ -144,7 +144,7 @@ __ttyname_r (int fd, char *buf, size_t buflen) /* Verify readlink result, fall back on iterating through devices. */ if (buf[0] == '/' - && __stat64 (buf, &st1) == 0 + && __stat64_time64 (buf, &st1) == 0 && is_mytty (&st, &st1)) return 0; @@ -155,7 +155,7 @@ __ttyname_r (int fd, char *buf, size_t buflen) memcpy (buf, "/dev/pts/", sizeof ("/dev/pts/")); buflen -= sizeof ("/dev/pts/") - 1; - if (__stat64 (buf, &st1) == 0 && S_ISDIR (st1.st_mode)) + if (__stat64_time64 (buf, &st1) == 0 && S_ISDIR (st1.st_mode)) { ret = getttyname_r (buf, buflen, &st, save, &dostat); diff --git a/sysvipc/ftok.c b/sysvipc/ftok.c index 2e39c74415..bd633bd395 100644 --- a/sysvipc/ftok.c +++ b/sysvipc/ftok.c @@ -22,10 +22,10 @@ key_t ftok (const char *pathname, int proj_id) { - struct stat64 st; + struct __stat64_t64 st; key_t key; - if (__stat64 (pathname, &st) < 0) + if (__stat64_time64 (pathname, &st) < 0) return (key_t) -1; key = ((st.st_ino & 0xffff) | ((st.st_dev & 0xff) << 16) diff --git a/time/tzfile.c b/time/tzfile.c index 040a5e341f..4377018a55 100644 --- a/time/tzfile.c +++ b/time/tzfile.c @@ -150,9 +150,9 @@ __tzfile_read (const char *file, size_t extra, char **extrap) } /* If we were already using tzfile, check whether the file changed. */ - struct stat64 st; + struct __stat64_t64 st; if (was_using_tzfile - && __stat64 (file, &st) == 0 + && __stat64_time64 (file, &st) == 0 && tzfile_ino == st.st_ino && tzfile_dev == st.st_dev && tzfile_mtime == st.st_mtime) goto done; /* Nothing to do. */ @@ -164,7 +164,7 @@ __tzfile_read (const char *file, size_t extra, char **extrap) goto ret_free_transitions; /* Get information about the file we are actually using. */ - if (__fstat64 (__fileno (f), &st) != 0) + if (__fstat64_time64 (__fileno (f), &st) != 0) goto lose; free ((void *) transitions); </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-release-aarch64-spec2k6-O2 - Build # 14 - Fixed!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-release-aarch64-spec2k6-O2. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-release-aarch64-spec2k6-O2 Culprit: <cut> commit 9593e8e5e391e77bb065d4689b7511bed6a640a3 Author: Richard Biener <rguenther(a)suse.de> Date: Thu Sep 26 13:52:45 2019 +0000 tree-vect-loop.c (vect_analyze_loop_operations): Also call vectorizable_reduction for vect_double_reduction_def. 2019-09-26 Richard Biener <rguenther(a)suse.de> * tree-vect-loop.c (vect_analyze_loop_operations): Also call vectorizable_reduction for vect_double_reduction_def. (vect_transform_loop): Likewise. (vect_create_epilog_for_reduction): Move double-reduction PHI creation and preheader argument setting of PHIs ... (vectorizable_reduction): ... here. Also process vect_double_reduction_def PHIs, creating the vectorized PHI nodes, remembering the scalar adjustment computed for the epilogue in STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT. Remember the original reduction code in STMT_VINFO_REDUC_CODE. * tree-vectorizer.c (vec_info::new_stmt_vec_info): Initialize STMT_VINFO_REDUC_CODE. * tree-vectorizer.h (_stmt_vec_info::reduc_epilogue_adjustment): New. (_stmt_vec_info::reduc_code): Likewise. (STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT): Likewise. (STMT_VINFO_REDUC_CODE): Likewise. From-SVN: r276150 </cut> Results regressed to (for first_bad == 9593e8e5e391e77bb065d4689b7511bed6a640a3) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2 -- artifacts/build-9593e8e5e391e77bb065d4689b7511bed6a640a3/results_id: 1 # 482.sphinx3,[.] subvq_mgau_shortlist regressed by 112 from (for last_good == 5fdd1d33524c94783eadbf9dcd2c900d65baee72) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2 -- artifacts/build-5fdd1d33524c94783eadbf9dcd2c900d65baee72/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-release-aarch64-spec2k6-O2/1200 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-release-aarch64-spec2k6-O2/1186 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-9593e8e5e391e77bb065d4689b7511bed6a640a3 cd investigate-gcc-9593e8e5e391e77bb065d4689b7511bed6a640a3 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 9593e8e5e391e77bb065d4689b7511bed6a640a3 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 5fdd1d33524c94783eadbf9dcd2c900d65baee72 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-release-a… Full commit (up to 1000 lines): <cut> commit 9593e8e5e391e77bb065d4689b7511bed6a640a3 Author: Richard Biener <rguenther(a)suse.de> Date: Thu Sep 26 13:52:45 2019 +0000 tree-vect-loop.c (vect_analyze_loop_operations): Also call vectorizable_reduction for vect_double_reduction_def. 2019-09-26 Richard Biener <rguenther(a)suse.de> * tree-vect-loop.c (vect_analyze_loop_operations): Also call vectorizable_reduction for vect_double_reduction_def. (vect_transform_loop): Likewise. (vect_create_epilog_for_reduction): Move double-reduction PHI creation and preheader argument setting of PHIs ... (vectorizable_reduction): ... here. Also process vect_double_reduction_def PHIs, creating the vectorized PHI nodes, remembering the scalar adjustment computed for the epilogue in STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT. Remember the original reduction code in STMT_VINFO_REDUC_CODE. * tree-vectorizer.c (vec_info::new_stmt_vec_info): Initialize STMT_VINFO_REDUC_CODE. * tree-vectorizer.h (_stmt_vec_info::reduc_epilogue_adjustment): New. (_stmt_vec_info::reduc_code): Likewise. (STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT): Likewise. (STMT_VINFO_REDUC_CODE): Likewise. From-SVN: r276150 --- gcc/ChangeLog | 19 +++ gcc/tree-vect-loop.c | 319 +++++++++++++++++++++++++++----------------------- gcc/tree-vectorizer.c | 1 + gcc/tree-vectorizer.h | 8 ++ 4 files changed, 198 insertions(+), 149 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 98fa0ffe56b..19892af07c0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,22 @@ +2019-09-26 Richard Biener <rguenther(a)suse.de> + + * tree-vect-loop.c (vect_analyze_loop_operations): Also call + vectorizable_reduction for vect_double_reduction_def. + (vect_transform_loop): Likewise. + (vect_create_epilog_for_reduction): Move double-reduction + PHI creation and preheader argument setting of PHIs ... + (vectorizable_reduction): ... here. Also process + vect_double_reduction_def PHIs, creating the vectorized + PHI nodes, remembering the scalar adjustment computed for + the epilogue in STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT. + Remember the original reduction code in STMT_VINFO_REDUC_CODE. + * tree-vectorizer.c (vec_info::new_stmt_vec_info): + Initialize STMT_VINFO_REDUC_CODE. + * tree-vectorizer.h (_stmt_vec_info::reduc_epilogue_adjustment): New. + (_stmt_vec_info::reduc_code): Likewise. + (STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT): Likewise. + (STMT_VINFO_REDUC_CODE): Likewise. + 2019-09-26 Matt Turner <mattst88(a)gmail.com> PR driver/69471 diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index ec00912e67d..1a561f9d16f 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -1548,6 +1548,8 @@ vect_analyze_loop_operations (loop_vec_info loop_vinfo) ok = vectorizable_induction (stmt_info, NULL, NULL, NULL, &cost_vec); else if ((STMT_VINFO_DEF_TYPE (stmt_info) == vect_reduction_def + || (STMT_VINFO_DEF_TYPE (stmt_info) + == vect_double_reduction_def) || STMT_VINFO_DEF_TYPE (stmt_info) == vect_nested_cycle) && ! PURE_SLP_STMT (stmt_info)) ok = vectorizable_reduction (stmt_info, NULL, NULL, NULL, NULL, @@ -4299,20 +4301,17 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, gimple *exit_phi; tree bitsize; tree adjustment_def = NULL; - tree vec_initial_def = NULL; tree expr, def, initial_def = NULL; tree orig_name, scalar_result; imm_use_iterator imm_iter, phi_imm_iter; use_operand_p use_p, phi_use_p; gimple *use_stmt; - stmt_vec_info reduction_phi_info = NULL; bool nested_in_vect_loop = false; auto_vec<gimple *> new_phis; auto_vec<stmt_vec_info> inner_phis; int j, i; auto_vec<tree> scalar_results; unsigned int group_size = 1, k, ratio; - auto_vec<tree> vec_initial_defs; auto_vec<gimple *> phis; bool slp_reduc = false; bool direct_slp_reduc; @@ -4336,10 +4335,10 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, mode = TYPE_MODE (vectype); /* 1. Create the reduction def-use cycle: - Set the arguments of REDUCTION_PHIS, i.e., transform + Set the backedge argument of REDUCTION_PHIS, i.e., transform loop: - vec_def = phi <null, null> # REDUCTION_PHI + vec_def = phi <vec_init, null> # REDUCTION_PHI VECT_DEF = vector_stmt # vectorized form of STMT ... @@ -4350,18 +4349,10 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, VECT_DEF = vector_stmt # vectorized form of STMT ... - (in case of SLP, do it for all the phis). */ + (in case of SLP, do it for all the phis). */ - /* Get the loop-entry arguments. */ if (slp_node) - { - unsigned vec_num = SLP_TREE_NUMBER_OF_VEC_STMTS (slp_node); - vec_initial_defs.reserve (vec_num); - get_initial_defs_for_reduction (slp_node_instance->reduc_phis, - &vec_initial_defs, vec_num, - REDUC_GROUP_FIRST_ELEMENT (stmt_info), - neutral_op); - } + ; else { /* Get at the scalar def before the loop, that defines the initial value @@ -4373,64 +4364,29 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, for REDUC_MIN and initial_def larger than the base. */ if (STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info) == INTEGER_INDUC_COND_REDUCTION) - { - induc_val = STMT_VINFO_VEC_INDUC_COND_INITIAL_VAL (stmt_info); - if (TREE_CODE (initial_def) == INTEGER_CST - && (STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info) - == INTEGER_INDUC_COND_REDUCTION) - && !integer_zerop (induc_val) - && ((code == MAX_EXPR - && tree_int_cst_lt (initial_def, induc_val)) - || (code == MIN_EXPR - && tree_int_cst_lt (induc_val, initial_def)))) - induc_val = initial_def; - vec_initial_def = build_vector_from_val (vectype, induc_val); - } + induc_val = STMT_VINFO_VEC_INDUC_COND_INITIAL_VAL (stmt_info); else if (double_reduc) - /* In case of double reduction we only create a vector variable - to be put in the reduction phi node. The actual statement - creation is done later in this function. */ - vec_initial_def = vect_create_destination_var (initial_def, vectype); + ; else if (nested_in_vect_loop) - { - /* Do not use an adjustment def as that case is not supported - correctly if ncopies is not one. */ - vec_initial_def = vect_get_vec_def_for_operand (initial_def, - stmt_info); - } + ; else - vec_initial_def - = get_initial_def_for_reduction (stmt_info, code, initial_def, - &adjustment_def); - vec_initial_defs.create (1); - vec_initial_defs.quick_push (vec_initial_def); + adjustment_def = STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT (stmt_info); } - /* Set phi nodes arguments. */ + /* Set phi nodes latch arguments. */ FOR_EACH_VEC_ELT (reduction_phis, i, phi_info) { - tree vec_init_def = vec_initial_defs[i]; tree def = vect_defs[i]; for (j = 0; j < ncopies; j++) { + /* Set the loop-latch arg for the reduction-phi. */ if (j != 0) { phi_info = STMT_VINFO_RELATED_STMT (phi_info); - if (nested_in_vect_loop) - vec_init_def - = vect_get_vec_def_for_stmt_copy (loop_vinfo, vec_init_def); + def = vect_get_vec_def_for_stmt_copy (loop_vinfo, def); } - /* Set the loop-entry arg of the reduction-phi. */ - gphi *phi = as_a <gphi *> (phi_info->stmt); - add_phi_arg (phi, vec_init_def, loop_preheader_edge (loop), - UNKNOWN_LOCATION); - - /* Set the loop-latch arg for the reduction-phi. */ - if (j > 0) - def = vect_get_vec_def_for_stmt_copy (loop_vinfo, def); - add_phi_arg (phi, def, loop_latch_edge (loop), UNKNOWN_LOCATION); if (dump_enabled_p ()) @@ -4934,7 +4890,7 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, if ((STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info) == INTEGER_INDUC_COND_REDUCTION) - && !operand_equal_p (initial_def, induc_val, 0)) + && induc_val) { /* Earlier we set the initial value to be a vector if induc_val values. Check the result and if it is induc_val then replace @@ -5297,7 +5253,7 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, if ((STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info) == INTEGER_INDUC_COND_REDUCTION) - && !operand_equal_p (initial_def, induc_val, 0)) + && induc_val) { /* Earlier we set the initial value to be a vector if induc_val values. Check the result and if it is induc_val then replace @@ -5420,7 +5376,6 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, if (k % ratio == 0) { epilog_stmt_info = loop_vinfo->lookup_stmt (new_phis[k / ratio]); - reduction_phi_info = reduction_phis[k / ratio]; if (double_reduc) inner_phi = inner_phis[k / ratio]; } @@ -5435,6 +5390,8 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, scalar_dest = gimple_assign_lhs (scalar_stmt_info->stmt); } + if (outer_loop) + { phis.create (3); /* Find the loop-closed-use at the loop exit of the original scalar result. (The reduction result is expected to have two immediate uses - @@ -5449,8 +5406,6 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, FOR_EACH_VEC_ELT (phis, i, exit_phi) { - if (outer_loop) - { stmt_vec_info exit_phi_vinfo = loop_vinfo->lookup_stmt (exit_phi); gphi *vect_phi; @@ -5482,7 +5437,6 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, FOR_EACH_IMM_USE_STMT (use_stmt, imm_iter, orig_name) { stmt_vec_info use_stmt_vinfo; - tree vect_phi_init, preheader_arg, vect_phi_res; basic_block bb = gimple_bb (use_stmt); /* Check that USE_STMT is really double reduction phi @@ -5497,53 +5451,23 @@ vect_create_epilog_for_reduction (vec<tree> vect_defs, != vect_double_reduction_def) continue; - /* Create vector phi node for double reduction: - vs1 = phi <vs0, vs2> - vs1 was created previously in this function by a call to - vect_get_vec_def_for_operand and is stored in - vec_initial_def; - vs2 is defined by INNER_PHI, the vectorized EXIT_PHI; - vs0 is created here. */ - - /* Create vector phi node. */ - vect_phi = create_phi_node (vec_initial_def, bb); - loop_vec_info_for_loop (outer_loop)->add_stmt (vect_phi); - - /* Create vs0 - initial def of the double reduction phi. */ - preheader_arg = PHI_ARG_DEF_FROM_EDGE (use_stmt, - loop_preheader_edge (outer_loop)); - vect_phi_init = get_initial_def_for_reduction - (stmt_info, code, preheader_arg, NULL); - - /* Update phi node arguments with vs0 and vs2. */ - add_phi_arg (vect_phi, vect_phi_init, - loop_preheader_edge (outer_loop), - UNKNOWN_LOCATION); + /* Set the outer loop vector phi args. The PHI node + itself was created in vectorizable_reduction. */ + vect_phi = as_a <gphi *> + (STMT_VINFO_VEC_STMT (use_stmt_vinfo)->stmt); + + /* Update phi node argument with vs2. */ add_phi_arg (vect_phi, PHI_RESULT (inner_phi->stmt), loop_latch_edge (outer_loop), UNKNOWN_LOCATION); if (dump_enabled_p ()) dump_printf_loc (MSG_NOTE, vect_location, "created double reduction phi node: %G", vect_phi); - - vect_phi_res = PHI_RESULT (vect_phi); - - /* Replace the use, i.e., set the correct vs1 in the regular - reduction phi node. FORNOW, NCOPIES is always 1, so the - loop is redundant. */ - stmt_vec_info use_info = reduction_phi_info; - for (j = 0; j < ncopies; j++) - { - edge pr_edge = loop_preheader_edge (loop); - SET_PHI_ARG_DEF (as_a <gphi *> (use_info->stmt), - pr_edge->dest_idx, vect_phi_res); - use_info = STMT_VINFO_RELATED_STMT (use_info); - } } - } } - phis.release (); + } + if (nested_in_vect_loop) { if (double_reduc) @@ -6027,6 +5951,7 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, /* Make sure it was already recognized as a reduction computation. */ if (STMT_VINFO_DEF_TYPE (stmt_info) != vect_reduction_def + && STMT_VINFO_DEF_TYPE (stmt_info) != vect_double_reduction_def && STMT_VINFO_DEF_TYPE (stmt_info) != vect_nested_cycle) return false; @@ -6067,25 +5992,24 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, /* Leave the scalar phi in place. */ return true; - gassign *reduc_stmt = as_a <gassign *> (reduc_stmt_info->stmt); - code = gimple_assign_rhs_code (reduc_stmt); - for (unsigned k = 1; k < gimple_num_ops (reduc_stmt); ++k) - { - tree op = gimple_op (reduc_stmt, k); - if (op == phi_result) - continue; - if (k == 1 && code == COND_EXPR) - continue; - bool is_simple_use = vect_is_simple_use (op, loop_vinfo, &dt); - gcc_assert (is_simple_use); - if (dt == vect_constant_def || dt == vect_external_def) - continue; - if (!vectype_in - || (GET_MODE_SIZE (SCALAR_TYPE_MODE (TREE_TYPE (vectype_in))) - < GET_MODE_SIZE (SCALAR_TYPE_MODE (TREE_TYPE (op))))) - vectype_in = get_vectype_for_scalar_type (TREE_TYPE (op)); - break; - } + if (gassign *reduc_stmt = dyn_cast <gassign *> (reduc_stmt_info->stmt)) + for (unsigned k = 1; k < gimple_num_ops (reduc_stmt); ++k) + { + tree op = gimple_op (reduc_stmt, k); + if (op == phi_result) + continue; + if (k == 1 && gimple_assign_rhs_code (reduc_stmt) == COND_EXPR) + continue; + bool is_simple_use = vect_is_simple_use (op, loop_vinfo, &dt); + gcc_assert (is_simple_use); + if (dt == vect_constant_def || dt == vect_external_def) + continue; + if (!vectype_in + || (GET_MODE_SIZE (SCALAR_TYPE_MODE (TREE_TYPE (vectype_in))) + < GET_MODE_SIZE (SCALAR_TYPE_MODE (TREE_TYPE (op))))) + vectype_in = get_vectype_for_scalar_type (TREE_TYPE (op)); + break; + } /* For a nested cycle we might end up with an operation like phi_result * phi_result. */ if (!vectype_in) @@ -6093,10 +6017,21 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, gcc_assert (vectype_in); if (slp_node) - ncopies = 1; + { + /* The size vect_schedule_slp_instance computes is off for us. */ + vec_num = vect_get_num_vectors + (LOOP_VINFO_VECT_FACTOR (loop_vinfo) + * SLP_TREE_SCALAR_STMTS (slp_node).length (), vectype_in); + ncopies = 1; + } else - ncopies = vect_get_num_copies (loop_vinfo, vectype_in); + { + vec_num = 1; + ncopies = vect_get_num_copies (loop_vinfo, vectype_in); + } + /* Check whether we can use a single PHI node and accumulate + vectors to one before the backedge. */ stmt_vec_info use_stmt_info; if (ncopies > 1 && STMT_VINFO_RELEVANT (reduc_stmt_info) <= vect_used_only_live @@ -6104,45 +6039,129 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, && (!STMT_VINFO_IN_PATTERN_P (use_stmt_info) || !STMT_VINFO_PATTERN_DEF_SEQ (use_stmt_info)) && vect_stmt_to_vectorize (use_stmt_info) == reduc_stmt_info) - single_defuse_cycle = true; + { + single_defuse_cycle = true; + ncopies = 1; + } /* Create the destination vector */ - scalar_dest = gimple_assign_lhs (reduc_stmt); - vec_dest = vect_create_destination_var (scalar_dest, vectype_out); + vec_dest = vect_create_destination_var (phi_result, vectype_out); + /* Get the loop-entry arguments. */ + tree vec_initial_def; + auto_vec<tree> vec_initial_defs; if (slp_node) - /* The size vect_schedule_slp_instance computes is off for us. */ - vec_num = vect_get_num_vectors - (LOOP_VINFO_VECT_FACTOR (loop_vinfo) - * SLP_TREE_SCALAR_STMTS (slp_node).length (), - vectype_in); + { + vec_initial_defs.reserve (vec_num); + gcc_assert (slp_node == slp_node_instance->reduc_phis); + stmt_vec_info first = REDUC_GROUP_FIRST_ELEMENT (reduc_stmt_info); + tree neutral_op + = neutral_op_for_slp_reduction (slp_node, + STMT_VINFO_REDUC_CODE + (first ? first : reduc_stmt_info), + first != NULL); + get_initial_defs_for_reduction (slp_node_instance->reduc_phis, + &vec_initial_defs, vec_num, + first != NULL, neutral_op); + } else - vec_num = 1; + { + /* Get at the scalar def before the loop, that defines the initial + value of the reduction variable. */ + tree initial_def = PHI_ARG_DEF_FROM_EDGE (phi, + loop_preheader_edge (loop)); + /* Optimize: if initial_def is for REDUC_MAX smaller than the base + and we can't use zero for induc_val, use initial_def. Similarly + for REDUC_MIN and initial_def larger than the base. */ + if (STMT_VINFO_VEC_REDUCTION_TYPE (reduc_stmt_info) + == INTEGER_INDUC_COND_REDUCTION) + { + tree induc_val + = STMT_VINFO_VEC_INDUC_COND_INITIAL_VAL (reduc_stmt_info); + if (TREE_CODE (initial_def) == INTEGER_CST + && (STMT_VINFO_VEC_REDUCTION_TYPE (reduc_stmt_info) + == INTEGER_INDUC_COND_REDUCTION) + && !integer_zerop (induc_val) + && (((STMT_VINFO_VEC_COND_REDUC_CODE (reduc_stmt_info) + == MAX_EXPR) + && tree_int_cst_lt (initial_def, induc_val)) + || ((STMT_VINFO_VEC_COND_REDUC_CODE (reduc_stmt_info) + == MIN_EXPR) + && tree_int_cst_lt (induc_val, initial_def)))) + { + induc_val = initial_def; + /* Communicate we used the initial_def to epilouge + generation. */ + STMT_VINFO_VEC_INDUC_COND_INITIAL_VAL (reduc_stmt_info) + = NULL_TREE; + } + vec_initial_def = build_vector_from_val (vectype_out, induc_val); + } + else if (nested_cycle) + { + /* Do not use an adjustment def as that case is not supported + correctly if ncopies is not one. */ + vec_initial_def = vect_get_vec_def_for_operand (initial_def, + reduc_stmt_info); + } + else + { + tree adjustment_def = NULL_TREE; + tree *adjustment_defp = &adjustment_def; + enum tree_code code = STMT_VINFO_REDUC_CODE (reduc_stmt_info); + /* ??? For the outer loop PHI we have to do a bit of searching + to find the stmt with the code. reduc_stmt_info here is the + loop-closed PHI of the inner reduction which means we can look + at its single-arg def. */ + if (STMT_VINFO_DEF_TYPE (stmt_info) == vect_double_reduction_def) + { + tree def = gimple_phi_arg_def + (as_a <gphi *> (reduc_stmt_info->stmt), 0); + code = STMT_VINFO_REDUC_CODE + (vect_stmt_to_vectorize (loop_vinfo->lookup_def (def))); + adjustment_defp = NULL; + } + vec_initial_def + = get_initial_def_for_reduction (reduc_stmt_info, code, + initial_def, adjustment_defp); + STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT (reduc_stmt_info) + = adjustment_def; + } + vec_initial_defs.create (1); + vec_initial_defs.quick_push (vec_initial_def); + } /* Generate the reduction PHIs upfront. */ prev_phi_info = NULL; - for (j = 0; j < ncopies; j++) + for (i = 0; i < vec_num; i++) { - if (j == 0 || !single_defuse_cycle) + tree vec_init_def = vec_initial_defs[i]; + for (j = 0; j < ncopies; j++) { - for (i = 0; i < vec_num; i++) + /* Create the reduction-phi that defines the reduction + operand. */ + gphi *new_phi = create_phi_node (vec_dest, loop->header); + stmt_vec_info new_phi_info = loop_vinfo->add_stmt (new_phi); + + /* Set the loop-entry arg of the reduction-phi. */ + if (j != 0 && nested_cycle) + vec_init_def = vect_get_vec_def_for_stmt_copy (loop_vinfo, + vec_init_def); + add_phi_arg (new_phi, vec_init_def, loop_preheader_edge (loop), + UNKNOWN_LOCATION); + + /* The loop-latch arg is set in epilogue processing. */ + + if (slp_node) + SLP_TREE_VEC_STMTS (slp_node).quick_push (new_phi_info); + else { - /* Create the reduction-phi that defines the reduction - operand. */ - gimple *new_phi = create_phi_node (vec_dest, loop->header); - stmt_vec_info new_phi_info = loop_vinfo->add_stmt (new_phi); - - if (slp_node) - SLP_TREE_VEC_STMTS (slp_node).quick_push (new_phi_info); + if (j == 0) + STMT_VINFO_VEC_STMT (stmt_info) + = *vec_stmt = new_phi_info; else - { - if (j == 0) - STMT_VINFO_VEC_STMT (stmt_info) - = *vec_stmt = new_phi_info; - else - STMT_VINFO_RELATED_STMT (prev_phi_info) = new_phi_info; - prev_phi_info = new_phi_info; - } + STMT_VINFO_RELATED_STMT (prev_phi_info) = new_phi_info; + prev_phi_info = new_phi_info; } } } @@ -6633,6 +6652,7 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, gcc_assert (orig_code == MAX_EXPR || orig_code == MIN_EXPR); } } + STMT_VINFO_REDUC_CODE (stmt_info) = orig_code; reduc_fn = IFN_LAST; @@ -8378,6 +8398,7 @@ vect_transform_loop (loop_vec_info loop_vinfo) if ((STMT_VINFO_DEF_TYPE (stmt_info) == vect_induction_def || STMT_VINFO_DEF_TYPE (stmt_info) == vect_reduction_def + || STMT_VINFO_DEF_TYPE (stmt_info) == vect_double_reduction_def || STMT_VINFO_DEF_TYPE (stmt_info) == vect_nested_cycle) && ! PURE_SLP_STMT (stmt_info)) { diff --git a/gcc/tree-vectorizer.c b/gcc/tree-vectorizer.c index 8fb70b751da..50d508db7cd 100644 --- a/gcc/tree-vectorizer.c +++ b/gcc/tree-vectorizer.c @@ -639,6 +639,7 @@ vec_info::new_stmt_vec_info (gimple *stmt) STMT_VINFO_VECTORIZABLE (res) = true; STMT_VINFO_VEC_REDUCTION_TYPE (res) = TREE_CODE_REDUCTION; STMT_VINFO_VEC_COND_REDUC_CODE (res) = ERROR_MARK; + STMT_VINFO_REDUC_CODE (res) = ERROR_MARK; STMT_VINFO_REDUC_IDX (res) = -1; STMT_VINFO_SLP_VECT_ONLY (res) = false; diff --git a/gcc/tree-vectorizer.h b/gcc/tree-vectorizer.h index 370ce132f74..f140405bbd6 100644 --- a/gcc/tree-vectorizer.h +++ b/gcc/tree-vectorizer.h @@ -941,10 +941,16 @@ public: /* For INTEGER_INDUC_COND_REDUCTION, the initial value to be used. */ tree induc_cond_initial_val; + /* If not NULL the value to be added to compute final reduction value. */ + tree reduc_epilogue_adjustment; + /* On a reduction PHI the reduction type as detected by vect_force_simple_reduction. */ enum vect_reduction_type reduc_type; + /* The original reduction code, to be used in the epilogue. */ + enum tree_code reduc_code; + /* On a stmt participating in the reduction the index of the operand on the reduction SSA cycle. */ int reduc_idx; @@ -1039,6 +1045,7 @@ STMT_VINFO_BB_VINFO (stmt_vec_info stmt_vinfo) #define STMT_VINFO_VEC_REDUCTION_TYPE(S) (S)->v_reduc_type #define STMT_VINFO_VEC_COND_REDUC_CODE(S) (S)->cond_reduc_code #define STMT_VINFO_VEC_INDUC_COND_INITIAL_VAL(S) (S)->induc_cond_initial_val +#define STMT_VINFO_REDUC_EPILOGUE_ADJUSTMENT(S) (S)->reduc_epilogue_adjustment #define STMT_VINFO_REDUC_IDX(S) (S)->reduc_idx #define STMT_VINFO_DR_WRT_VEC_LOOP(S) (S)->dr_wrt_vec_loop @@ -1070,6 +1077,7 @@ STMT_VINFO_BB_VINFO (stmt_vec_info stmt_vinfo) #define STMT_VINFO_MIN_NEG_DIST(S) (S)->min_neg_dist #define STMT_VINFO_NUM_SLP_USES(S) (S)->num_slp_uses #define STMT_VINFO_REDUC_TYPE(S) (S)->reduc_type +#define STMT_VINFO_REDUC_CODE(S) (S)->reduc_code #define STMT_VINFO_REDUC_DEF(S) (S)->reduc_def #define STMT_VINFO_SLP_VECT_ONLY(S) (S)->slp_vect_only_p </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-release-arm-spec2k6-O3 - Build # 25 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *binutils* in CI configuration tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3 Culprit: <cut> commit 3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24 Author: GDB Administrator <gdbadmin(a)sourceware.org> Date: Wed Apr 21 00:00:45 2021 +0000 Automatic date update in version.in </cut> Results regressed to (for first_bad == 3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_marm -- artifacts/build-3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24/results_id: 1 # 456.hmmer,hmmer_base.default regressed by 105 from (for last_good == 54254f3896521d79edd4b6b9d5848a365cc483f2) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_marm -- artifacts/build-54254f3896521d79edd4b6b9d5848a365cc483f2/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3/1141 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3/1128 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Configuration details: Reproduce builds: <cut> mkdir investigate-binutils-3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24 cd investigate-binutils-3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd binutils # Reproduce first_bad build git checkout --detach 3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 54254f3896521d79edd4b6b9d5848a365cc483f2 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Full commit (up to 1000 lines): <cut> commit 3f07ddd6899e382b28b14bc3c2d4cb0b52a61a24 Author: GDB Administrator <gdbadmin(a)sourceware.org> Date: Wed Apr 21 00:00:45 2021 +0000 Automatic date update in version.in --- bfd/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/version.h b/bfd/version.h index cc83f5bbda2..1f17c744c22 100644 --- a/bfd/version.h +++ b/bfd/version.h @@ -16,7 +16,7 @@ In releases, the date is not included in either version strings or sonames. */ -#define BFD_VERSION_DATE 20210420 +#define BFD_VERSION_DATE 20210421 #define BFD_VERSION @bfd_version@ #define BFD_VERSION_STRING @bfd_version_package@ @bfd_version_string@ #define REPORT_BUGS_TO @report_bugs_to@ </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O3_LTO - Build # 16 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O3_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O3_LTO Culprit: <cut> commit 39ed6a88c74db5412652f0167d03f71eca4f02fc Author: Ian Lance Taylor <iant(a)golang.org> Date: Tue May 18 18:28:17 2021 -0700 libgo: use Windows line endings in testwinsignal </cut> Results regressed to (for first_bad == 39ed6a88c74db5412652f0167d03f71eca4f02fc) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO -- artifacts/build-39ed6a88c74db5412652f0167d03f71eca4f02fc/results_id: 1 # 453.povray,povray_base.default regressed by 103 from (for last_good == 01b2864757540d24c4e717a77b40b29369c064b2) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO -- artifacts/build-01b2864757540d24c4e717a77b40b29369c064b2/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O3_LTO/1130 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O3_LTO/1096 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-39ed6a88c74db5412652f0167d03f71eca4f02fc cd investigate-gcc-39ed6a88c74db5412652f0167d03f71eca4f02fc git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 39ed6a88c74db5412652f0167d03f71eca4f02fc ../artifacts/test.sh # Reproduce last_good build git checkout --detach 01b2864757540d24c4e717a77b40b29369c064b2 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit 39ed6a88c74db5412652f0167d03f71eca4f02fc Author: Ian Lance Taylor <iant(a)golang.org> Date: Tue May 18 18:28:17 2021 -0700 libgo: use Windows line endings in testwinsignal --- libgo/go/runtime/testdata/testwinsignal/main.go | 38 ++++++++++++------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libgo/go/runtime/testdata/testwinsignal/main.go b/libgo/go/runtime/testdata/testwinsignal/main.go index 1e7c9475fd6..d8cd884ffac 100644 --- a/libgo/go/runtime/testdata/testwinsignal/main.go +++ b/libgo/go/runtime/testdata/testwinsignal/main.go @@ -1,19 +1,19 @@ -package main - -import ( - "fmt" - "os" - "os/signal" - "time" -) - -func main() { - c := make(chan os.Signal, 1) - signal.Notify(c) - - fmt.Println("ready") - sig := <-c - - time.Sleep(time.Second) - fmt.Println(sig) -} +package main + +import ( + "fmt" + "os" + "os/signal" + "time" +) + +func main() { + c := make(chan os.Signal, 1) + signal.Notify(c) + + fmt.Println("ready") + sig := <-c + + time.Sleep(time.Second) + fmt.Println(sig) +} </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-release-aarch64-spec2k6-O2 - Build # 9 - Fixed!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O2. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O2 Culprit: <cut> commit e00f189d392dd9bf95f6a98f05f2d341d06cd65c Author: Roman Lebedev <lebedev.ri(a)gmail.com> Date: Mon Oct 5 22:35:59 2020 +0300 [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592) (it was introduced in https://lists.llvm.org/pipermail/llvm-dev/2015-January/080956.html) This canonicalization seems dubious. Most importantly, while it does not create `inttoptr` casts by itself, it may cause them to appear later, see e.g. D88788. I think it's pretty obvious that it is an undesirable outcome, by now we've established that seemingly no-op `inttoptr`/`ptrtoint` casts are not no-op, and are no longer eager to look past them. Which e.g. means that given ``` %a = load i32 %b = inttoptr %a %c = inttoptr %a ``` we likely won't be able to tell that `%b` and `%c` is the same thing. As we can see in D88789 / D88788 / D88806 / D75505, we can't really teach SCEV about this (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at least) And we can't recover the situation post-inlining in instcombine. So it really does look like this fold is actively breaking otherwise-good IR, in a way that is not recoverable. And that means, this fold isn't helpful in exposing the passes that are otherwise unaware of these patterns it produces. Thusly, i propose to simply not perform such a canonicalization. The original motivational RFC does not state what larger problem that canonicalization was trying to solve, so i'm not sure how this plays out in the larger picture. On vanilla llvm test-suite + RawSpeed, this results in increase of asm instructions and final object size by ~+0.05% decreases final count of bitcasts by -4.79% (-28990), ptrtoint casts by -15.41% (-3423), and of inttoptr casts by -25.59% (-6919, *sic*). Overall, there's -0.04% less IR blocks, -0.39% instructions. See https://bugs.llvm.org/show_bug.cgi?id=47592 Differential Revision: https://reviews.llvm.org/D88789 </cut> Results regressed to (for first_bad == e00f189d392dd9bf95f6a98f05f2d341d06cd65c) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2 -- artifacts/build-e00f189d392dd9bf95f6a98f05f2d341d06cd65c/results_id: 1 # 470.lbm,lbm_base.default regressed by 111 # 470.lbm,[.] LBM_performStreamCollide regressed by 111 from (for last_good == 567462b48eba1c2d286ce97117994463f4535d2e) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2 -- artifacts/build-567462b48eba1c2d286ce97117994463f4535d2e/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O2/1124 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O2/1119 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-e00f189d392dd9bf95f6a98f05f2d341d06cd65c cd investigate-llvm-e00f189d392dd9bf95f6a98f05f2d341d06cd65c git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach e00f189d392dd9bf95f6a98f05f2d341d06cd65c ../artifacts/test.sh # Reproduce last_good build git checkout --detach 567462b48eba1c2d286ce97117994463f4535d2e ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Full commit (up to 1000 lines): <cut> commit e00f189d392dd9bf95f6a98f05f2d341d06cd65c Author: Roman Lebedev <lebedev.ri(a)gmail.com> Date: Mon Oct 5 22:35:59 2020 +0300 [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592) (it was introduced in https://lists.llvm.org/pipermail/llvm-dev/2015-January/080956.html) This canonicalization seems dubious. Most importantly, while it does not create `inttoptr` casts by itself, it may cause them to appear later, see e.g. D88788. I think it's pretty obvious that it is an undesirable outcome, by now we've established that seemingly no-op `inttoptr`/`ptrtoint` casts are not no-op, and are no longer eager to look past them. Which e.g. means that given ``` %a = load i32 %b = inttoptr %a %c = inttoptr %a ``` we likely won't be able to tell that `%b` and `%c` is the same thing. As we can see in D88789 / D88788 / D88806 / D75505, we can't really teach SCEV about this (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at least) And we can't recover the situation post-inlining in instcombine. So it really does look like this fold is actively breaking otherwise-good IR, in a way that is not recoverable. And that means, this fold isn't helpful in exposing the passes that are otherwise unaware of these patterns it produces. Thusly, i propose to simply not perform such a canonicalization. The original motivational RFC does not state what larger problem that canonicalization was trying to solve, so i'm not sure how this plays out in the larger picture. On vanilla llvm test-suite + RawSpeed, this results in increase of asm instructions and final object size by ~+0.05% decreases final count of bitcasts by -4.79% (-28990), ptrtoint casts by -15.41% (-3423), and of inttoptr casts by -25.59% (-6919, *sic*). Overall, there's -0.04% less IR blocks, -0.39% instructions. See https://bugs.llvm.org/show_bug.cgi?id=47592 Differential Revision: https://reviews.llvm.org/D88789 --- .../CodeGen/attr-arm-sve-vector-bits-bitcast.c | 18 +++-- clang/test/CodeGen/attr-arm-sve-vector-bits-call.c | 78 ++++++++++------------ clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c | 24 +++---- .../CodeGen/attr-arm-sve-vector-bits-globals.c | 6 +- .../InstCombine/InstCombineLoadStoreAlloca.cpp | 34 ---------- llvm/test/Transforms/InstCombine/atomic.ll | 18 ++--- llvm/test/Transforms/InstCombine/load.ll | 44 ++++++------ .../Transforms/InstCombine/loadstore-metadata.ll | 19 +----- .../InstCombine/non-integral-pointers.ll | 16 ++--- .../PhaseOrdering/instcombine-sroa-inttoptr.ll | 32 ++++----- 10 files changed, 107 insertions(+), 182 deletions(-) diff --git a/clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c b/clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c index 3a5628d7f57e..5df1e83b13bf 100644 --- a/clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c +++ b/clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c @@ -255,22 +255,20 @@ svbool_t read_bool(struct struct_bool *s) { // CHECK-256-NEXT: entry: // CHECK-256-NEXT: [[X_ADDR:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-256-NEXT: store <vscale x 16 x i1> [[X:%.*]], <vscale x 16 x i1>* [[X_ADDR]], align 16, [[TBAA15:!tbaa !.*]] -// CHECK-256-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[X_ADDR]] to i32* -// CHECK-256-NEXT: [[TMP1:%.*]] = load i32, i32* [[TMP0]], align 16, [[TBAA6]] -// CHECK-256-NEXT: [[Y:%.*]] = getelementptr inbounds [[STRUCT_STRUCT_BOOL:%.*]], %struct.struct_bool* [[S:%.*]], i64 0, i32 1 -// CHECK-256-NEXT: [[TMP2:%.*]] = bitcast [3 x <4 x i8>]* [[Y]] to i32* -// CHECK-256-NEXT: store i32 [[TMP1]], i32* [[TMP2]], align 2, [[TBAA6]] +// CHECK-256-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[X_ADDR]] to <4 x i8>* +// CHECK-256-NEXT: [[TMP1:%.*]] = load <4 x i8>, <4 x i8>* [[TMP0]], align 16, [[TBAA6]] +// CHECK-256-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds [[STRUCT_STRUCT_BOOL:%.*]], %struct.struct_bool* [[S:%.*]], i64 0, i32 1, i64 0 +// CHECK-256-NEXT: store <4 x i8> [[TMP1]], <4 x i8>* [[ARRAYIDX]], align 2, [[TBAA6]] // CHECK-256-NEXT: ret void // // CHECK-512-LABEL: @write_bool( // CHECK-512-NEXT: entry: // CHECK-512-NEXT: [[X_ADDR:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-512-NEXT: store <vscale x 16 x i1> [[X:%.*]], <vscale x 16 x i1>* [[X_ADDR]], align 16, [[TBAA15:!tbaa !.*]] -// CHECK-512-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[X_ADDR]] to i64* -// CHECK-512-NEXT: [[TMP1:%.*]] = load i64, i64* [[TMP0]], align 16, [[TBAA6]] -// CHECK-512-NEXT: [[Y:%.*]] = getelementptr inbounds [[STRUCT_STRUCT_BOOL:%.*]], %struct.struct_bool* [[S:%.*]], i64 0, i32 1 -// CHECK-512-NEXT: [[TMP2:%.*]] = bitcast [3 x <8 x i8>]* [[Y]] to i64* -// CHECK-512-NEXT: store i64 [[TMP1]], i64* [[TMP2]], align 2, [[TBAA6]] +// CHECK-512-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[X_ADDR]] to <8 x i8>* +// CHECK-512-NEXT: [[TMP1:%.*]] = load <8 x i8>, <8 x i8>* [[TMP0]], align 16, [[TBAA6]] +// CHECK-512-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds [[STRUCT_STRUCT_BOOL:%.*]], %struct.struct_bool* [[S:%.*]], i64 0, i32 1, i64 0 +// CHECK-512-NEXT: store <8 x i8> [[TMP1]], <8 x i8>* [[ARRAYIDX]], align 2, [[TBAA6]] // CHECK-512-NEXT: ret void // void write_bool(struct struct_bool *s, svbool_t x) { diff --git a/clang/test/CodeGen/attr-arm-sve-vector-bits-call.c b/clang/test/CodeGen/attr-arm-sve-vector-bits-call.c index 5442d58e96be..13979197999e 100644 --- a/clang/test/CodeGen/attr-arm-sve-vector-bits-call.c +++ b/clang/test/CodeGen/attr-arm-sve-vector-bits-call.c @@ -169,28 +169,24 @@ fixed_float64_t call_float64_ff(svbool_t pg, fixed_float64_t op1, fixed_float64_ // CHECK-NEXT: [[RETVAL_COERCE:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-NEXT: [[TMP0:%.*]] = bitcast <8 x i8>* [[OP1]] to <vscale x 16 x i1>* // CHECK-NEXT: store <vscale x 16 x i1> [[OP1_COERCE:%.*]], <vscale x 16 x i1>* [[TMP0]], align 16 -// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[OP1]] to i64* -// CHECK-NEXT: [[OP113:%.*]] = load i64, i64* [[TMP1]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP2:%.*]] = bitcast <8 x i8>* [[OP2]] to <vscale x 16 x i1>* -// CHECK-NEXT: store <vscale x 16 x i1> [[OP2_COERCE:%.*]], <vscale x 16 x i1>* [[TMP2]], align 16 -// CHECK-NEXT: [[TMP3:%.*]] = bitcast <8 x i8>* [[OP2]] to i64* -// CHECK-NEXT: [[OP224:%.*]] = load i64, i64* [[TMP3]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP4:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to i64* -// CHECK-NEXT: store i64 [[OP113]], i64* [[TMP4]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP5:%.*]] = bitcast <8 x i8>* [[OP2_ADDR]] to i64* -// CHECK-NEXT: store i64 [[OP224]], i64* [[TMP5]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP6:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to <vscale x 16 x i1>* -// CHECK-NEXT: [[TMP7:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP6]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP8:%.*]] = bitcast <8 x i8>* [[OP2_ADDR]] to <vscale x 16 x i1>* -// CHECK-NEXT: [[TMP9:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP8]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP10:%.*]] = call <vscale x 16 x i1> @llvm.aarch64.sve.sel.nxv16i1(<vscale x 16 x i1> [[PG:%.*]], <vscale x 16 x i1> [[TMP7]], <vscale x 16 x i1> [[TMP9]]) -// CHECK-NEXT: store <vscale x 16 x i1> [[TMP10]], <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]], align 16, [[TBAA13:!tbaa !.*]] -// CHECK-NEXT: [[TMP11:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to i64* -// CHECK-NEXT: [[TMP12:%.*]] = load i64, i64* [[TMP11]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP13:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to i64* -// CHECK-NEXT: store i64 [[TMP12]], i64* [[TMP13]], align 16 -// CHECK-NEXT: [[TMP14:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 -// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP14]] +// CHECK-NEXT: [[OP11:%.*]] = load <8 x i8>, <8 x i8>* [[OP1]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[OP2]] to <vscale x 16 x i1>* +// CHECK-NEXT: store <vscale x 16 x i1> [[OP2_COERCE:%.*]], <vscale x 16 x i1>* [[TMP1]], align 16 +// CHECK-NEXT: [[OP22:%.*]] = load <8 x i8>, <8 x i8>* [[OP2]], align 16, [[TBAA6]] +// CHECK-NEXT: store <8 x i8> [[OP11]], <8 x i8>* [[OP1_ADDR]], align 16, [[TBAA6]] +// CHECK-NEXT: store <8 x i8> [[OP22]], <8 x i8>* [[OP2_ADDR]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP2:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to <vscale x 16 x i1>* +// CHECK-NEXT: [[TMP3:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP2]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP4:%.*]] = bitcast <8 x i8>* [[OP2_ADDR]] to <vscale x 16 x i1>* +// CHECK-NEXT: [[TMP5:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP4]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP6:%.*]] = call <vscale x 16 x i1> @llvm.aarch64.sve.sel.nxv16i1(<vscale x 16 x i1> [[PG:%.*]], <vscale x 16 x i1> [[TMP3]], <vscale x 16 x i1> [[TMP5]]) +// CHECK-NEXT: store <vscale x 16 x i1> [[TMP6]], <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]], align 16, [[TBAA13:!tbaa !.*]] +// CHECK-NEXT: [[CASTFIXEDSVE:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to <8 x i8>* +// CHECK-NEXT: [[TMP7:%.*]] = load <8 x i8>, <8 x i8>* [[CASTFIXEDSVE]], align 16, [[TBAA6]] +// CHECK-NEXT: [[RETVAL_0__SROA_CAST:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to <8 x i8>* +// CHECK-NEXT: store <8 x i8> [[TMP7]], <8 x i8>* [[RETVAL_0__SROA_CAST]], align 16 +// CHECK-NEXT: [[TMP8:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 +// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP8]] // fixed_bool_t call_bool_ff(svbool_t pg, fixed_bool_t op1, fixed_bool_t op2) { return svsel(pg, op1, op2); @@ -260,20 +256,18 @@ fixed_float64_t call_float64_fs(svbool_t pg, fixed_float64_t op1, svfloat64_t op // CHECK-NEXT: [[RETVAL_COERCE:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-NEXT: [[TMP0:%.*]] = bitcast <8 x i8>* [[OP1]] to <vscale x 16 x i1>* // CHECK-NEXT: store <vscale x 16 x i1> [[OP1_COERCE:%.*]], <vscale x 16 x i1>* [[TMP0]], align 16 -// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[OP1]] to i64* -// CHECK-NEXT: [[OP112:%.*]] = load i64, i64* [[TMP1]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP2:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to i64* -// CHECK-NEXT: store i64 [[OP112]], i64* [[TMP2]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP3:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to <vscale x 16 x i1>* -// CHECK-NEXT: [[TMP4:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP3]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP5:%.*]] = call <vscale x 16 x i1> @llvm.aarch64.sve.sel.nxv16i1(<vscale x 16 x i1> [[PG:%.*]], <vscale x 16 x i1> [[TMP4]], <vscale x 16 x i1> [[OP2:%.*]]) -// CHECK-NEXT: store <vscale x 16 x i1> [[TMP5]], <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]], align 16, [[TBAA13]] -// CHECK-NEXT: [[TMP6:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to i64* -// CHECK-NEXT: [[TMP7:%.*]] = load i64, i64* [[TMP6]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP8:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to i64* -// CHECK-NEXT: store i64 [[TMP7]], i64* [[TMP8]], align 16 -// CHECK-NEXT: [[TMP9:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 -// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP9]] +// CHECK-NEXT: [[OP11:%.*]] = load <8 x i8>, <8 x i8>* [[OP1]], align 16, [[TBAA6]] +// CHECK-NEXT: store <8 x i8> [[OP11]], <8 x i8>* [[OP1_ADDR]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[OP1_ADDR]] to <vscale x 16 x i1>* +// CHECK-NEXT: [[TMP2:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP1]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP3:%.*]] = call <vscale x 16 x i1> @llvm.aarch64.sve.sel.nxv16i1(<vscale x 16 x i1> [[PG:%.*]], <vscale x 16 x i1> [[TMP2]], <vscale x 16 x i1> [[OP2:%.*]]) +// CHECK-NEXT: store <vscale x 16 x i1> [[TMP3]], <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]], align 16, [[TBAA13]] +// CHECK-NEXT: [[CASTFIXEDSVE:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to <8 x i8>* +// CHECK-NEXT: [[TMP4:%.*]] = load <8 x i8>, <8 x i8>* [[CASTFIXEDSVE]], align 16, [[TBAA6]] +// CHECK-NEXT: [[RETVAL_0__SROA_CAST:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to <8 x i8>* +// CHECK-NEXT: store <8 x i8> [[TMP4]], <8 x i8>* [[RETVAL_0__SROA_CAST]], align 16 +// CHECK-NEXT: [[TMP5:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 +// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP5]] // fixed_bool_t call_bool_fs(svbool_t pg, fixed_bool_t op1, svbool_t op2) { return svsel(pg, op1, op2); @@ -325,12 +319,12 @@ fixed_float64_t call_float64_ss(svbool_t pg, svfloat64_t op1, svfloat64_t op2) { // CHECK-NEXT: [[RETVAL_COERCE:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-NEXT: [[TMP0:%.*]] = call <vscale x 16 x i1> @llvm.aarch64.sve.sel.nxv16i1(<vscale x 16 x i1> [[PG:%.*]], <vscale x 16 x i1> [[OP1:%.*]], <vscale x 16 x i1> [[OP2:%.*]]) // CHECK-NEXT: store <vscale x 16 x i1> [[TMP0]], <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]], align 16, [[TBAA13]] -// CHECK-NEXT: [[TMP1:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to i64* -// CHECK-NEXT: [[TMP2:%.*]] = load i64, i64* [[TMP1]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP3:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to i64* -// CHECK-NEXT: store i64 [[TMP2]], i64* [[TMP3]], align 16 -// CHECK-NEXT: [[TMP4:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 -// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP4]] +// CHECK-NEXT: [[CASTFIXEDSVE:%.*]] = bitcast <vscale x 16 x i1>* [[SAVED_CALL_RVALUE]] to <8 x i8>* +// CHECK-NEXT: [[TMP1:%.*]] = load <8 x i8>, <8 x i8>* [[CASTFIXEDSVE]], align 16, [[TBAA6]] +// CHECK-NEXT: [[RETVAL_0__SROA_CAST:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to <8 x i8>* +// CHECK-NEXT: store <8 x i8> [[TMP1]], <8 x i8>* [[RETVAL_0__SROA_CAST]], align 16 +// CHECK-NEXT: [[TMP2:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 +// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP2]] // fixed_bool_t call_bool_ss(svbool_t pg, svbool_t op1, svbool_t op2) { return svsel(pg, op1, op2); diff --git a/clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c b/clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c index 17267d6038e4..8568c820ae6f 100644 --- a/clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c +++ b/clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c @@ -81,13 +81,11 @@ fixed_float64_t from_svfloat64_t(svfloat64_t type) { // CHECK-NEXT: [[TYPE_ADDR:%.*]] = alloca <8 x i8>, align 16 // CHECK-NEXT: [[TMP0:%.*]] = bitcast <8 x i8>* [[TYPE]] to <vscale x 16 x i1>* // CHECK-NEXT: store <vscale x 16 x i1> [[TYPE_COERCE:%.*]], <vscale x 16 x i1>* [[TMP0]], align 16 -// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[TYPE]] to i64* -// CHECK-NEXT: [[TYPE12:%.*]] = load i64, i64* [[TMP1]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP2:%.*]] = bitcast <8 x i8>* [[TYPE_ADDR]] to i64* -// CHECK-NEXT: store i64 [[TYPE12]], i64* [[TMP2]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP3:%.*]] = bitcast <8 x i8>* [[TYPE_ADDR]] to <vscale x 16 x i1>* -// CHECK-NEXT: [[TMP4:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP3]], align 16, [[TBAA6]] -// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP4]] +// CHECK-NEXT: [[TYPE1:%.*]] = load <8 x i8>, <8 x i8>* [[TYPE]], align 16, [[TBAA6]] +// CHECK-NEXT: store <8 x i8> [[TYPE1]], <8 x i8>* [[TYPE_ADDR]], align 16, [[TBAA6]] +// CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i8>* [[TYPE_ADDR]] to <vscale x 16 x i1>* +// CHECK-NEXT: [[TMP2:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[TMP1]], align 16, [[TBAA6]] +// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP2]] // svbool_t to_svbool_t(fixed_bool_t type) { return type; @@ -98,12 +96,12 @@ svbool_t to_svbool_t(fixed_bool_t type) { // CHECK-NEXT: [[TYPE_ADDR:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-NEXT: [[RETVAL_COERCE:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-NEXT: store <vscale x 16 x i1> [[TYPE:%.*]], <vscale x 16 x i1>* [[TYPE_ADDR]], align 16, [[TBAA13:!tbaa !.*]] -// CHECK-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[TYPE_ADDR]] to i64* -// CHECK-NEXT: [[TMP1:%.*]] = load i64, i64* [[TMP0]], align 16, [[TBAA6]] -// CHECK-NEXT: [[TMP2:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to i64* -// CHECK-NEXT: store i64 [[TMP1]], i64* [[TMP2]], align 16 -// CHECK-NEXT: [[TMP3:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 -// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP3]] +// CHECK-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[TYPE_ADDR]] to <8 x i8>* +// CHECK-NEXT: [[TMP1:%.*]] = load <8 x i8>, <8 x i8>* [[TMP0]], align 16, [[TBAA6]] +// CHECK-NEXT: [[RETVAL_0__SROA_CAST:%.*]] = bitcast <vscale x 16 x i1>* [[RETVAL_COERCE]] to <8 x i8>* +// CHECK-NEXT: store <8 x i8> [[TMP1]], <8 x i8>* [[RETVAL_0__SROA_CAST]], align 16 +// CHECK-NEXT: [[TMP2:%.*]] = load <vscale x 16 x i1>, <vscale x 16 x i1>* [[RETVAL_COERCE]], align 16 +// CHECK-NEXT: ret <vscale x 16 x i1> [[TMP2]] // fixed_bool_t from_svbool_t(svbool_t type) { return type; diff --git a/clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c b/clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c index 5babb9c7c410..8f0d3c9f97e7 100644 --- a/clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c +++ b/clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c @@ -72,9 +72,9 @@ void write_global_bf16(svbfloat16_t v) { global_bf16 = v; } // CHECK-512-NEXT: entry: // CHECK-512-NEXT: [[V_ADDR:%.*]] = alloca <vscale x 16 x i1>, align 16 // CHECK-512-NEXT: store <vscale x 16 x i1> [[V:%.*]], <vscale x 16 x i1>* [[V_ADDR]], align 16, [[TBAA13:!tbaa !.*]] -// CHECK-512-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[V_ADDR]] to i64* -// CHECK-512-NEXT: [[TMP1:%.*]] = load i64, i64* [[TMP0]], align 16, [[TBAA10]] -// CHECK-512-NEXT: store i64 [[TMP1]], i64* bitcast (<8 x i8>* @global_bool to i64*), align 2, [[TBAA10]] +// CHECK-512-NEXT: [[TMP0:%.*]] = bitcast <vscale x 16 x i1>* [[V_ADDR]] to <8 x i8>* +// CHECK-512-NEXT: [[TMP1:%.*]] = load <8 x i8>, <8 x i8>* [[TMP0]], align 16, [[TBAA10]] +// CHECK-512-NEXT: store <8 x i8> [[TMP1]], <8 x i8>* @global_bool, align 2, [[TBAA10]] // CHECK-512-NEXT: ret void // void write_global_bool(svbool_t v) { global_bool = v; } diff --git a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp index 328cbde4da67..b7bb34022ecc 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp @@ -554,42 +554,8 @@ static Instruction *combineLoadToOperationType(InstCombinerImpl &IC, if (LI.getPointerOperand()->isSwiftError()) return nullptr; - Type *Ty = LI.getType(); const DataLayout &DL = IC.getDataLayout(); - // Try to canonicalize loads which are only ever stored to operate over - // integers instead of any other type. We only do this when the loaded type - // is sized and has a size exactly the same as its store size and the store - // size is a legal integer type. - // Do not perform canonicalization if minmax pattern is found (to avoid - // infinite loop). - Type *Dummy; - if (!Ty->isIntegerTy() && Ty->isSized() && !isa<ScalableVectorType>(Ty) && - DL.isLegalInteger(DL.getTypeStoreSizeInBits(Ty)) && - DL.typeSizeEqualsStoreSize(Ty) && !DL.isNonIntegralPointerType(Ty) && - !isMinMaxWithLoads(InstCombiner::peekThroughBitcast( - LI.getPointerOperand(), /*OneUseOnly=*/true), - Dummy)) { - if (all_of(LI.users(), [&LI](User *U) { - auto *SI = dyn_cast<StoreInst>(U); - return SI && SI->getPointerOperand() != &LI && - !SI->getPointerOperand()->isSwiftError(); - })) { - LoadInst *NewLoad = IC.combineLoadToNewType( - LI, Type::getIntNTy(LI.getContext(), DL.getTypeStoreSizeInBits(Ty))); - // Replace all the stores with stores of the newly loaded value. - for (auto UI = LI.user_begin(), UE = LI.user_end(); UI != UE;) { - auto *SI = cast<StoreInst>(*UI++); - IC.Builder.SetInsertPoint(SI); - combineStoreToNewValue(IC, *SI, NewLoad); - IC.eraseInstFromFunction(*SI); - } - assert(LI.use_empty() && "Failed to remove all users of the load!"); - // Return the old load so the combiner can delete it safely. - return &LI; - } - } - // Fold away bit casts of the loaded value by loading the desired type. // We can do this for BitCastInsts as well as casts from and to pointer types, // as long as those are noops (i.e., the source or dest type have the same diff --git a/llvm/test/Transforms/InstCombine/atomic.ll b/llvm/test/Transforms/InstCombine/atomic.ll index 382d23d15309..fc134bcd7e4b 100644 --- a/llvm/test/Transforms/InstCombine/atomic.ll +++ b/llvm/test/Transforms/InstCombine/atomic.ll @@ -325,11 +325,9 @@ declare void @clobber() define i32 @test18(float* %p) { ; CHECK-LABEL: @test18( -; CHECK-NEXT: [[TMP1:%.*]] = bitcast float* [[P:%.*]] to i32* -; CHECK-NEXT: [[X1:%.*]] = load atomic i32, i32* [[TMP1]] unordered, align 4 +; CHECK-NEXT: [[X:%.*]] = load atomic float, float* [[P:%.*]] unordered, align 4 ; CHECK-NEXT: call void @clobber() -; CHECK-NEXT: [[TMP2:%.*]] = bitcast float* [[P]] to i32* -; CHECK-NEXT: store atomic i32 [[X1]], i32* [[TMP2]] unordered, align 4 +; CHECK-NEXT: store atomic float [[X]], float* [[P]] unordered, align 4 ; CHECK-NEXT: ret i32 0 ; %x = load atomic float, float* %p unordered, align 4 @@ -376,10 +374,8 @@ define i32 @test21(i32** %p, i8* %v) { define void @pr27490a(i8** %p1, i8** %p2) { ; CHECK-LABEL: @pr27490a( -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8** [[P1:%.*]] to i64* -; CHECK-NEXT: [[L1:%.*]] = load i64, i64* [[TMP1]], align 8 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast i8** [[P2:%.*]] to i64* -; CHECK-NEXT: store volatile i64 [[L1]], i64* [[TMP2]], align 8 +; CHECK-NEXT: [[L:%.*]] = load i8*, i8** [[P1:%.*]], align 8 +; CHECK-NEXT: store volatile i8* [[L]], i8** [[P2:%.*]], align 8 ; CHECK-NEXT: ret void ; %l = load i8*, i8** %p1 @@ -389,10 +385,8 @@ define void @pr27490a(i8** %p1, i8** %p2) { define void @pr27490b(i8** %p1, i8** %p2) { ; CHECK-LABEL: @pr27490b( -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8** [[P1:%.*]] to i64* -; CHECK-NEXT: [[L1:%.*]] = load i64, i64* [[TMP1]], align 8 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast i8** [[P2:%.*]] to i64* -; CHECK-NEXT: store atomic i64 [[L1]], i64* [[TMP2]] seq_cst, align 8 +; CHECK-NEXT: [[L:%.*]] = load i8*, i8** [[P1:%.*]], align 8 +; CHECK-NEXT: store atomic i8* [[L]], i8** [[P2:%.*]] seq_cst, align 8 ; CHECK-NEXT: ret void ; %l = load i8*, i8** %p1 diff --git a/llvm/test/Transforms/InstCombine/load.ll b/llvm/test/Transforms/InstCombine/load.ll index 4fc87219fa83..032da41de6a5 100644 --- a/llvm/test/Transforms/InstCombine/load.ll +++ b/llvm/test/Transforms/InstCombine/load.ll @@ -205,18 +205,16 @@ define i8 @test15(i8 %x, i32 %y) { define void @test16(i8* %x, i8* %a, i8* %b, i8* %c) { ; CHECK-LABEL: @test16( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = bitcast i8* [[X:%.*]] to i32* -; CHECK-NEXT: [[X11:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8* [[A:%.*]] to i32* -; CHECK-NEXT: store i32 [[X11]], i32* [[TMP1]], align 4 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast i8* [[B:%.*]] to i32* -; CHECK-NEXT: store i32 [[X11]], i32* [[TMP2]], align 4 -; CHECK-NEXT: [[TMP3:%.*]] = bitcast i8* [[X]] to i32* -; CHECK-NEXT: [[X22:%.*]] = load i32, i32* [[TMP3]], align 4 -; CHECK-NEXT: [[TMP4:%.*]] = bitcast i8* [[B]] to i32* -; CHECK-NEXT: store i32 [[X22]], i32* [[TMP4]], align 4 -; CHECK-NEXT: [[TMP5:%.*]] = bitcast i8* [[C:%.*]] to i32* -; CHECK-NEXT: store i32 [[X22]], i32* [[TMP5]], align 4 +; CHECK-NEXT: [[X_CAST:%.*]] = bitcast i8* [[X:%.*]] to float* +; CHECK-NEXT: [[A_CAST:%.*]] = bitcast i8* [[A:%.*]] to float* +; CHECK-NEXT: [[B_CAST:%.*]] = bitcast i8* [[B:%.*]] to float* +; CHECK-NEXT: [[X1:%.*]] = load float, float* [[X_CAST]], align 4 +; CHECK-NEXT: store float [[X1]], float* [[A_CAST]], align 4 +; CHECK-NEXT: store float [[X1]], float* [[B_CAST]], align 4 +; CHECK-NEXT: [[X2:%.*]] = load float, float* [[X_CAST]], align 4 +; CHECK-NEXT: store float [[X2]], float* [[B_CAST]], align 4 +; CHECK-NEXT: [[TMP0:%.*]] = bitcast i8* [[C:%.*]] to float* +; CHECK-NEXT: store float [[X2]], float* [[TMP0]], align 4 ; CHECK-NEXT: ret void ; entry: @@ -240,18 +238,16 @@ entry: define void @test16-vect(i8* %x, i8* %a, i8* %b, i8* %c) { ; CHECK-LABEL: @test16-vect( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = bitcast i8* [[X:%.*]] to i32* -; CHECK-NEXT: [[X11:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8* [[A:%.*]] to i32* -; CHECK-NEXT: store i32 [[X11]], i32* [[TMP1]], align 4 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast i8* [[B:%.*]] to i32* -; CHECK-NEXT: store i32 [[X11]], i32* [[TMP2]], align 4 -; CHECK-NEXT: [[TMP3:%.*]] = bitcast i8* [[X]] to i32* -; CHECK-NEXT: [[X22:%.*]] = load i32, i32* [[TMP3]], align 4 -; CHECK-NEXT: [[TMP4:%.*]] = bitcast i8* [[B]] to i32* -; CHECK-NEXT: store i32 [[X22]], i32* [[TMP4]], align 4 -; CHECK-NEXT: [[TMP5:%.*]] = bitcast i8* [[C:%.*]] to i32* -; CHECK-NEXT: store i32 [[X22]], i32* [[TMP5]], align 4 +; CHECK-NEXT: [[X_CAST:%.*]] = bitcast i8* [[X:%.*]] to <4 x i8>* +; CHECK-NEXT: [[A_CAST:%.*]] = bitcast i8* [[A:%.*]] to <4 x i8>* +; CHECK-NEXT: [[B_CAST:%.*]] = bitcast i8* [[B:%.*]] to <4 x i8>* +; CHECK-NEXT: [[X1:%.*]] = load <4 x i8>, <4 x i8>* [[X_CAST]], align 4 +; CHECK-NEXT: store <4 x i8> [[X1]], <4 x i8>* [[A_CAST]], align 4 +; CHECK-NEXT: store <4 x i8> [[X1]], <4 x i8>* [[B_CAST]], align 4 +; CHECK-NEXT: [[X2:%.*]] = load <4 x i8>, <4 x i8>* [[X_CAST]], align 4 +; CHECK-NEXT: store <4 x i8> [[X2]], <4 x i8>* [[B_CAST]], align 4 +; CHECK-NEXT: [[TMP0:%.*]] = bitcast i8* [[C:%.*]] to <4 x i8>* +; CHECK-NEXT: store <4 x i8> [[X2]], <4 x i8>* [[TMP0]], align 4 ; CHECK-NEXT: ret void ; entry: diff --git a/llvm/test/Transforms/InstCombine/loadstore-metadata.ll b/llvm/test/Transforms/InstCombine/loadstore-metadata.ll index e443c6ed0075..42f6900c2ab5 100644 --- a/llvm/test/Transforms/InstCombine/loadstore-metadata.ll +++ b/llvm/test/Transforms/InstCombine/loadstore-metadata.ll @@ -161,24 +161,11 @@ exit: } define void @test_load_cast_combine_nonnull(float** %ptr) { -; We can't preserve nonnull metadata when converting a load of a pointer to -; a load of an integer. Instead, we translate it to range metadata. -; FIXME: We should also transform range metadata back into nonnull metadata. -; FIXME: This test is very fragile. If any LABEL lines are added after -; this point, the test will fail, because this test depends on a metadata tuple, -; which is always emitted at the end of the file. At some point, we should -; consider an option to the IR printer to emit MD tuples after the function -; that first uses them--this will allow us to refer to them like this and not -; have the tests break. For now, this function must always come last in this -; file, and no LABEL lines are to be added after this point. -; ; CHECK-LABEL: @test_load_cast_combine_nonnull( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = bitcast float** [[PTR:%.*]] to i64* -; CHECK-NEXT: [[P1:%.*]] = load i64, i64* [[TMP0]], align 8, !range ![[MD:[0-9]+]] +; CHECK-NEXT: [[P:%.*]] = load float*, float** [[PTR:%.*]], align 8, !nonnull !7 ; CHECK-NEXT: [[GEP:%.*]] = getelementptr float*, float** [[PTR]], i64 42 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast float** [[GEP]] to i64* -; CHECK-NEXT: store i64 [[P1]], i64* [[TMP1]], align 8 +; CHECK-NEXT: store float* [[P]], float** [[GEP]], align 8 ; CHECK-NEXT: ret void ; entry: @@ -188,8 +175,6 @@ entry: ret void } -; This is the metadata tuple that we reference above: -; CHECK: ![[MD]] = !{i64 1, i64 0} !0 = !{!1, !1, i64 0} !1 = !{!"scalar type", !2} !2 = !{!"root"} diff --git a/llvm/test/Transforms/InstCombine/non-integral-pointers.ll b/llvm/test/Transforms/InstCombine/non-integral-pointers.ll index e8f0013604a9..a1166bf49193 100644 --- a/llvm/test/Transforms/InstCombine/non-integral-pointers.ll +++ b/llvm/test/Transforms/InstCombine/non-integral-pointers.ll @@ -41,10 +41,8 @@ define void @f_3(i8 addrspace(3)** %ptr0, i8 addrspace(3)** %ptr1) { ; integers, since pointers in address space 3 are integral. ; CHECK-LABEL: @f_3( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = bitcast i8 addrspace(3)** [[PTR0:%.*]] to i64* -; CHECK-NEXT: [[VAL1:%.*]] = load i64, i64* [[TMP0]], align 8 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8 addrspace(3)** [[PTR1:%.*]] to i64* -; CHECK-NEXT: store i64 [[VAL1]], i64* [[TMP1]], align 8 +; CHECK-NEXT: [[VAL:%.*]] = load i8 addrspace(3)*, i8 addrspace(3)** [[PTR0:%.*]], align 8 +; CHECK-NEXT: store i8 addrspace(3)* [[VAL]], i8 addrspace(3)** [[PTR1:%.*]], align 8 ; CHECK-NEXT: ret void ; entry: @@ -79,13 +77,13 @@ define i64 @g(i8 addrspace(4)** %gp) { define i64 @g2(i8* addrspace(4)* %gp) { ; CHECK-LABEL: @g2( -; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8* addrspace(4)* [[GP:%.*]] to i64 addrspace(4)* -; CHECK-NEXT: [[DOTPRE1:%.*]] = load i64, i64 addrspace(4)* [[TMP1]], align 8 +; CHECK-NEXT: [[DOTPRE:%.*]] = load i8*, i8* addrspace(4)* [[GP:%.*]], align 8 ; CHECK-NEXT: [[V74:%.*]] = call i8 addrspace(4)* @alloc() ; CHECK-NEXT: [[V77:%.*]] = getelementptr i8, i8 addrspace(4)* [[V74]], i64 -8 -; CHECK-NEXT: [[TMP2:%.*]] = bitcast i8 addrspace(4)* [[V77]] to i64 addrspace(4)* -; CHECK-NEXT: store i64 [[DOTPRE1]], i64 addrspace(4)* [[TMP2]], align 8 -; CHECK-NEXT: ret i64 [[DOTPRE1]] +; CHECK-NEXT: [[TMP1:%.*]] = bitcast i8 addrspace(4)* [[V77]] to i8* addrspace(4)* +; CHECK-NEXT: store i8* [[DOTPRE]], i8* addrspace(4)* [[TMP1]], align 8 +; CHECK-NEXT: [[V81_CAST:%.*]] = ptrtoint i8* [[DOTPRE]] to i64 +; CHECK-NEXT: ret i64 [[V81_CAST]] ; %.pre = load i8*, i8* addrspace(4)* %gp, align 8 %v74 = call i8 addrspace(4)* @alloc() diff --git a/llvm/test/Transforms/PhaseOrdering/instcombine-sroa-inttoptr.ll b/llvm/test/Transforms/PhaseOrdering/instcombine-sroa-inttoptr.ll index 6de0282e9448..3308a0ecc7fa 100644 --- a/llvm/test/Transforms/PhaseOrdering/instcombine-sroa-inttoptr.ll +++ b/llvm/test/Transforms/PhaseOrdering/instcombine-sroa-inttoptr.ll @@ -50,10 +50,10 @@ target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16 define dso_local void @_Z3gen1S(%0* noalias sret align 8 %arg, %0* byval(%0) align 8 %arg1) { ; CHECK-LABEL: @_Z3gen1S( ; CHECK-NEXT: bb: -; CHECK-NEXT: [[TMP0:%.*]] = bitcast %0* [[ARG1:%.*]] to i64* -; CHECK-NEXT: [[I21:%.*]] = load i64, i64* [[TMP0]], align 8 -; CHECK-NEXT: [[TMP1:%.*]] = bitcast %0* [[ARG:%.*]] to i64* -; CHECK-NEXT: store i64 [[I21]], i64* [[TMP1]], align 8 +; CHECK-NEXT: [[I:%.*]] = getelementptr inbounds [[TMP0:%.*]], %0* [[ARG1:%.*]], i64 0, i32 0 +; CHECK-NEXT: [[I2:%.*]] = load i32*, i32** [[I]], align 8 +; CHECK-NEXT: [[I3:%.*]] = getelementptr inbounds [[TMP0]], %0* [[ARG:%.*]], i64 0, i32 0 +; CHECK-NEXT: store i32* [[I2]], i32** [[I3]], align 8 ; CHECK-NEXT: ret void ; bb: @@ -68,13 +68,12 @@ define dso_local i32* @_Z3foo1S(%0* byval(%0) align 8 %arg) { ; CHECK-LABEL: @_Z3foo1S( ; CHECK-NEXT: bb: ; CHECK-NEXT: [[I2:%.*]] = alloca [[TMP0:%.*]], align 8 -; CHECK-NEXT: [[I1_SROA_0_0_I5_SROA_CAST:%.*]] = bitcast %0* [[ARG:%.*]] to i64* -; CHECK-NEXT: [[I1_SROA_0_0_COPYLOAD:%.*]] = load i64, i64* [[I1_SROA_0_0_I5_SROA_CAST]], align 8 -; CHECK-NEXT: [[I_SROA_0_0_I6_SROA_CAST:%.*]] = bitcast %0* [[I2]] to i64* -; CHECK-NEXT: store i64 [[I1_SROA_0_0_COPYLOAD]], i64* [[I_SROA_0_0_I6_SROA_CAST]], align 8 +; CHECK-NEXT: [[I1_SROA_0_0_I5_SROA_IDX:%.*]] = getelementptr inbounds [[TMP0]], %0* [[ARG:%.*]], i64 0, i32 0 +; CHECK-NEXT: [[I1_SROA_0_0_COPYLOAD:%.*]] = load i32*, i32** [[I1_SROA_0_0_I5_SROA_IDX]], align 8 +; CHECK-NEXT: [[I_SROA_0_0_I6_SROA_IDX:%.*]] = getelementptr inbounds [[TMP0]], %0* [[I2]], i64 0, i32 0 +; CHECK-NEXT: store i32* [[I1_SROA_0_0_COPYLOAD]], i32** [[I_SROA_0_0_I6_SROA_IDX]], align 8 ; CHECK-NEXT: tail call void @_Z7escape01S(%0* nonnull byval(%0) align 8 [[I2]]) -; CHECK-NEXT: [[TMP0]] = inttoptr i64 [[I1_SROA_0_0_COPYLOAD]] to i32* -; CHECK-NEXT: ret i32* [[TMP0]] +; CHECK-NEXT: ret i32* [[I1_SROA_0_0_COPYLOAD]] ; bb: %i = alloca %0, align 8 @@ -108,24 +107,21 @@ declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture) define dso_local i32* @_Z3bar1S(%0* byval(%0) align 8 %arg) { ; CHECK-LABEL: @_Z3bar1S( ; CHECK-NEXT: bb: -; CHECK-NEXT: [[I1_SROA_0_0_I4_SROA_CAST:%.*]] = bitcast %0* [[ARG:%.*]] to i64* -; CHECK-NEXT: [[I1_SROA_0_0_COPYLOAD:%.*]] = load i64, i64* [[I1_SROA_0_0_I4_SROA_CAST]], align 8 +; CHECK-NEXT: [[I1_SROA_0_0_I4_SROA_IDX:%.*]] = getelementptr inbounds [[TMP0:%.*]], %0* [[ARG:%.*]], i64 0, i32 0 +; CHECK-NEXT: [[I1_SROA_0_0_COPYLOAD:%.*]] = load i32*, i32** [[I1_SROA_0_0_I4_SROA_IDX]], align 8 ; CHECK-NEXT: [[I5:%.*]] = tail call i32 @_Z4condv() ; CHECK-NEXT: [[I6_NOT:%.*]] = icmp eq i32 [[I5]], 0 ; CHECK-NEXT: br i1 [[I6_NOT]], label [[BB10:%.*]], label [[BB7:%.*]] ; CHECK: bb7: ; CHECK-NEXT: tail call void @_Z5sync0v() -; CHECK-NEXT: [[TMP0:%.*]] = inttoptr i64 [[I1_SROA_0_0_COPYLOAD]] to i32* -; CHECK-NEXT: tail call void @_Z7escape0Pi(i32* [[TMP0]]) +; CHECK-NEXT: tail call void @_Z7escape0Pi(i32* [[I1_SROA_0_0_COPYLOAD]]) ; CHECK-NEXT: br label [[BB13:%.*]] ; CHECK: bb10: ; CHECK-NEXT: tail call void @_Z5sync1v() -; CHECK-NEXT: [[TMP1:%.*]] = inttoptr i64 [[I1_SROA_0_0_COPYLOAD]] to i32* -; CHECK-NEXT: tail call void @_Z7escape1Pi(i32* [[TMP1]]) +; CHECK-NEXT: tail call void @_Z7escape1Pi(i32* [[I1_SROA_0_0_COPYLOAD]]) ; CHECK-NEXT: br label [[BB13]] ; CHECK: bb13: -; CHECK-NEXT: [[DOTPRE_PHI:%.*]] = phi i32* [ [[TMP1]], [[BB10]] ], [ [[TMP0]], [[BB7]] ] -; CHECK-NEXT: ret i32* [[DOTPRE_PHI]] +; CHECK-NEXT: ret i32* [[I1_SROA_0_0_COPYLOAD]] ; bb: %i = alloca %0, align 8 </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_gnu/gnu-master-arm-check_bootstrap - Build # 73 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_gnu/gnu-master-arm-check_bootstrap. So far, this commit has regressed CI configurations: - tcwg_gnu/gnu-master-arm-check_bootstrap Culprit: <cut> commit 7d8211603a3d04384812b481b0ae01205a287a72 Author: Richard Biener <rguenther(a)suse.de> Date: Wed Jun 30 16:28:50 2021 +0200 tree-optimization/101178 - handle VEC_PERM in SLP permute propagation This adds handling of VEC_PERM nodes to SLP permute propagation. Previously VEC_PERM acted as forced materialization of incoming permutes since it is a good place to do that (with the constraint of those only appearing for two-operator nodes). The following patch, in addition to supporting (but not forcing) this, enables VEC_PERM nodes acting as "any" permute on the outgoing side since they also can consume arbitrary permutes on that side. This again (meh) changes how we represent permutes and materialization on the graph vertices now explicitely having the common incoming permute as well as an outgoing permute and in case both are different the vertex acts as materialization point of the incoming permute. 2021-06-30 Richard Biener <rguenther(a)suse.de> PR tree-optimization/101178 * tree-vect-slp.c (slpg_vertex::materialize): Remove. (slpg::perm_in): Add. (slpg::get_perm_in): Remove. (slpg::get_perm_materialized): Add. (vect_optimize_slp): Handle VEC_PERM nodes more optimally during permute propagation and materialization. * gcc.dg/vect/bb-slp-72.c: New testcase. * gcc.dg/vect/bb-slp-73.c: Likewise. * gcc.dg/vect/bb-slp-74.c: Likewise. </cut> Results regressed to (for first_bad == 7d8211603a3d04384812b481b0ae01205a287a72) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 # # Comparing directories # # REFERENCE: base-artifacts/sumfiles # # CURRENT: /home/tcwg-buildslave/workspace/tcwg_gnu_2/artifacts/build-7d8211603a3d04384812b481b0ae01205a287a72/sumfiles # # # Comparing 12 common sum files: # g++.sum # gcc.sum # gfortran.sum # go.sum # gotools.sum # libatomic.sum # libffi.sum # libgo.sum # libgomp.sum # libitm.sum # libstdc++.sum # objc.sum # Comparing: # REFERENCE:/tmp/gxx-sum1.3498108 # CURRENT: /tmp/gxx-sum2.3498108 # # ` +---------+---------+ # o RUN STATUS: | REF | RES | # +------------------------------------------+---------+---------+ # | Passes [PASS] | 460520 | 460704 | # | Unexpected fails [FAIL] | 196 | 195 | # | Errors [ERROR] | 0 | 0 | # | Unexpected passes [XPASS] | 15 | 15 | # | Expected fails [XFAIL] | 2737 | 2723 | # | Unresolved [UNRESOLVED] | 104 | 104 | # | Unsupported [UNSUPPORTED] | 22896 | 22903 | # | Untested [UNTESTED] | 10 | 10 | # +------------------------------------------+---------+---------+ # # REF PASS ratio: 0.952267 # RES PASS ratio: 0.952272 # # o REGRESSIONS: # +------------------------------------------+---------+ # | FAIL appears [ => FAIL] | 2 | # +------------------------------------------+---------+ # | TOTAL_REGRESSIONS | 2 | # +------------------------------------------+---------+ # # - FAIL appears [ => FAIL]: # # Executed from: gcc.dg/vect/vect.exp # gcc:gcc.dg/vect/bb-slp-74.c -flto -ffat-lto-objects scan-tree-dump-times slp2 " [^ ]+ = VEC_PERM_EXPR" 1 # gcc:gcc.dg/vect/bb-slp-74.c scan-tree-dump-times slp2 " [^ ]+ = VEC_PERM_EXPR" 1 # # # # o IMPROVEMENTS TO BE CHECKED: # +------------------------------------------+---------+ # | PASS disappears [PASS => ] | 114 | # | New PASS [ => PASS] | 296 | # | FAIL now PASS [FAIL => PASS] | 2 | # | FAIL disappears [FAIL => ] | 1 | # | XFAIL disappears [XFAIL=> ] | 17 | # | XFAIL appears [ =>XFAIL] | 3 | # | UNSUPPORTED appears [ =>UNSUP] | 7 | # +------------------------------------------+---------+ # | TOTAL_IMPROVEMENTS_TO_BE_CHECKED | 440 | # +------------------------------------------+---------+ # # - PASS disappears [PASS => ]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/cpp0x/auto24.C -std=c++14 (test for errors, line 5) # g++:g++.dg/cpp0x/auto24.C -std=c++17 (test for errors, line 5) # g++:g++.dg/cpp0x/auto24.C -std=c++2a (test for errors, line 5) # g++:g++.dg/diagnostic/auto1.C -std=c++17 (test for errors, line 4) # g++:g++.dg/diagnostic/auto1.C -std=c++2a (test for errors, line 4) # Executed from: gcc.dg/analyzer/analyzer.exp # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1007) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1009) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1010) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1013) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1018) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1025) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1026) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 510) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 518) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 519) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 539) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 540) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 557) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 559) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 562) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 565) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 566) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 570) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 573) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 574) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 578) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 579) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 581) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 582) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 586) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 587) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 604) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 606) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 609) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 612) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 613) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 617) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 620) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 621) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 628) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 629) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 632) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 635) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 636) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 654) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 656) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 659) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 662) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 663) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 667) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 670) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 671) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 676) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 678) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 679) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 682) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 684) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 685) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 703) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 705) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 708) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 711) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 712) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 716) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 719) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 720) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 725) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 727) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 728) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 731) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 733) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 744) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 745) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 765) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 769) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 770) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 781) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 787) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 795) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 800) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 801) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 812) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 816) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 842) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 850) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 870) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 873) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 875) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 895) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 908) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 909) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 914) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 923) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 932) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 947) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 950) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 965) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 968) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 1038) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 506) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 511) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 525) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 528) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 532) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 535) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 63) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 67) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 68) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 77) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 81) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 82) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 98) # Executed from: libstdc++-dg/conformance.exp # libstdc++:26_numerics/random/pr60037-neg.cc (test for errors, line 167) # libstdc++:26_numerics/random/pr60037-neg.cc (test for errors, line 3346) # # # - New PASS [ => PASS]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/cpp0x/constexpr-empty16.C -std=c++14 (test for excess errors) # g++:g++.dg/cpp0x/constexpr-empty16.C -std=c++17 (test for excess errors) # g++:g++.dg/cpp0x/constexpr-empty16.C -std=c++2a (test for excess errors) # g++:g++.dg/cpp23/auto-array.C -std=c++14 (test for excess errors) # g++:g++.dg/cpp23/auto-array.C -std=c++17 (test for excess errors) # g++:g++.dg/cpp23/auto-array.C -std=c++2a (test for excess errors) # g++:g++.dg/cpp2a/concepts-access2.C -std=c++2a (test for errors, line 13) # g++:g++.dg/cpp2a/concepts-access2.C -std=c++2a (test for errors, line 4) # g++:g++.dg/cpp2a/concepts-access2.C -std=c++2a (test for excess errors) # g++:g++.dg/template/access41.C -std=c++14 (test for excess errors) # g++:g++.dg/template/access41.C -std=c++17 (test for excess errors) # g++:g++.dg/template/access41.C -std=c++2a (test for excess errors) # g++:g++.dg/template/access41a.C -std=c++14 (test for excess errors) # g++:g++.dg/template/access41a.C -std=c++17 (test for excess errors) # g++:g++.dg/template/access41a.C -std=c++2a (test for excess errors) # Executed from: gcc.misc-tests/help.exp # gcc:compiler driver --help=common option(s): ^ +-.*[^:.]$ # Executed from: gcc.dg/analyzer/analyzer.exp # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 22) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 24) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 25) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 33) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 35) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 36) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 44) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 46) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 47) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 54) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 55) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 67) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 68) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 69) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 70) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 71) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 72) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 73) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 74) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 88) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 89) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 90) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 91) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 92) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 93) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 94) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 95) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 96) # gcc:gcc.dg/analyzer/clobbers-1.c (test for warnings, line 97) # gcc:gcc.dg/analyzer/clobbers-1.c (test for excess errors) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 11) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 12) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 13) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 14) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 15) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 19) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 20) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 21) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 22) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 23) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 24) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 31) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 32) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 33) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 37) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 38) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 39) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 40) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 47) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 48) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 49) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 53) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 54) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 55) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 56) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 63) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 64) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 68) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 69) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 70) # gcc:gcc.dg/analyzer/clobbers-2.c (test for warnings, line 71) # gcc:gcc.dg/analyzer/clobbers-2.c (test for excess errors) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1000) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1003) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1015) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1028) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 1029) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 506) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 508) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 516) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 517) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 523) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 524) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 526) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 527) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 529) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 530) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 546) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 547) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 549) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 550) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 552) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 553) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 555) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 561) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 564) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 568) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 569) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 572) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 576) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 577) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 593) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 594) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 596) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 597) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 599) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 600) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 602) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 608) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 611) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 615) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 616) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 619) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 622) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 643) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 644) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 646) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 647) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 649) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 650) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 652) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 658) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 661) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 665) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 666) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 669) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 672) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 674) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 692) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 693) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 695) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 696) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 698) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 699) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 701) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 707) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 710) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 714) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 715) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 718) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 721) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 723) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 735) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 755) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 759) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 760) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 767) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 771) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 785) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 790) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 791) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 802) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 806) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 832) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 840) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 860) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 863) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 865) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 885) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 898) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 899) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 903) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 904) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 922) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 937) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 940) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 955) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 958) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 996) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 997) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 998) # gcc:gcc.dg/analyzer/data-model-1.c (test for warnings, line 999) # gcc:gcc.dg/analyzer/data-model-1.c status quo (test for warnings, line 509) # gcc:gcc.dg/analyzer/explode-1.c (test for warnings, line 15) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 100) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 110) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 111) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 112) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 126) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 127) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 128) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 129) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 130) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 131) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 132) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 133) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 134) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 135) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 136) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 137) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 138) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 139) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 140) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 141) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 142) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 143) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 144) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 145) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 154) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 155) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 156) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 157) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 158) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 159) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 160) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 161) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 164) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 165) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 166) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 167) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 168) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 169) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 170) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 171) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 174) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 175) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 176) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 177) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 178) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 179) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 180) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 181) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 184) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 185) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 186) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 187) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 188) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 189) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 190) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 191) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 194) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 195) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 196) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 197) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 198) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 199) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 200) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 201) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 39) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 48) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 57) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 61) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 62) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 71) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 75) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 76) # gcc:gcc.dg/analyzer/memset-1.c (test for warnings, line 92) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 100) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 101) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 102) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 103) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 104) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 105) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 106) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 62) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 63) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 64) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 65) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 66) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 67) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 68) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 71) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 72) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 98) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for warnings, line 99) # gcc:gcc.dg/analyzer/memset-CVE-2017-18549-1.c (test for excess errors) # gcc:gcc.dg/analyzer/symbolic-8.c (test for excess errors) # Executed from: gcc.dg/dg.exp # gcc:gcc.dg/pr101254.c (test for excess errors) # gcc:gcc.dg/pr101254.c execution test # gcc:gcc.dg/pr101266.c (test for excess errors) # Executed from: gcc.dg/vect/vect.exp # gcc:gcc.dg/vect/bb-slp-72.c (test for excess errors) # gcc:gcc.dg/vect/bb-slp-72.c -flto -ffat-lto-objects (test for excess errors) # gcc:gcc.dg/vect/bb-slp-72.c -flto -ffat-lto-objects execution test # gcc:gcc.dg/vect/bb-slp-72.c execution test # gcc:gcc.dg/vect/bb-slp-73.c (test for excess errors) # gcc:gcc.dg/vect/bb-slp-73.c -flto -ffat-lto-objects (test for excess errors) # gcc:gcc.dg/vect/bb-slp-73.c -flto -ffat-lto-objects execution test # gcc:gcc.dg/vect/bb-slp-73.c execution test # gcc:gcc.dg/vect/bb-slp-74.c (test for excess errors) # gcc:gcc.dg/vect/bb-slp-74.c -flto -ffat-lto-objects (test for excess errors) # gcc:gcc.dg/vect/bb-slp-74.c -flto -ffat-lto-objects execution test # gcc:gcc.dg/vect/bb-slp-74.c execution test # Executed from: gfortran.dg/dg.exp # gfortran:gfortran.dg/pr101264.f90 -O (test for excess errors) # gfortran:gfortran.dg/pr101267.f90 -O (test for excess errors) # Executed from: libgomp.c++/c++.exp # libgomp:libgomp.c++/../libgomp.c-c++-common/pr94366.c (test for excess errors) # libgomp:libgomp.c++/../libgomp.c-c++-common/pr94366.c execution test # Executed from: libgomp.c/c.exp # libgomp:libgomp.c/../libgomp.c-c++-common/pr94366.c (test for excess errors) # libgomp:libgomp.c/../libgomp.c-c++-common/pr94366.c execution test # Executed from: libstdc++-dg/conformance.exp # libstdc++:26_numerics/random/pr60037-neg.cc (test for errors, line 166) # libstdc++:26_numerics/random/pr60037-neg.cc (test for errors, line 3350) # # # - FAIL now PASS [FAIL => PASS]: # # Executed from: gcc.dg/debug/ctf/ctf.exp # gcc:gcc.dg/debug/ctf/ctf-skip-types-2.c (test for excess errors) # Executed from: go.test/go-test.exp # go:go.test/test/fixedbugs/issue19182.go execution, -O2 -g # # # - FAIL disappears [FAIL => ]: # # Executed from: gcc.misc-tests/help.exp # gcc:compiler driver --help=common option(s): "^ +-.*[^:.]$" absent from output: " -foffload=<targets>=<options> Specify options for the offloading targets" # # # - XFAIL disappears [XFAIL=> ]: # # Executed from: gcc.dg/analyzer/analyzer.exp # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 1038) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 506) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 511) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 525) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 528) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 532) # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 535) # gcc:gcc.dg/analyzer/data-model-1.c uninit-warning-removed (test for warnings, line 824) # gcc:gcc.dg/analyzer/data-model-1.c uninit-warning-removed (test for warnings, line 832) # gcc:gcc.dg/analyzer/memset-1.c known nonzero (test for warnings, line 110) # gcc:gcc.dg/analyzer/memset-1.c known nonzero (test for warnings, line 112) # gcc:gcc.dg/analyzer/memset-1.c known nonzero (test for warnings, line 41) # gcc:gcc.dg/analyzer/memset-1.c known nonzero (test for warnings, line 53) # gcc:gcc.dg/analyzer/memset-1.c status quo (test for bogus messages, line 110) # gcc:gcc.dg/analyzer/memset-1.c status quo (test for bogus messages, line 112) # gcc:gcc.dg/analyzer/memset-1.c status quo (test for bogus messages, line 41) # gcc:gcc.dg/analyzer/memset-1.c status quo (test for bogus messages, line 53) # # # - XFAIL appears [ =>XFAIL]: # # Executed from: gcc.dg/analyzer/analyzer.exp # gcc:gcc.dg/analyzer/data-model-1.c desired (test for warnings, line 509) # gcc:gcc.dg/analyzer/data-model-1.c uninit-warning-removed (test for warnings, line 814) # gcc:gcc.dg/analyzer/data-model-1.c uninit-warning-removed (test for warnings, line 822) # # # - UNSUPPORTED appears [ =>UNSUP]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/cpp0x/constexpr-empty16.C -std=c++98 # g++:g++.dg/cpp23/auto-array.C -std=c++98 # g++:g++.dg/cpp2a/concepts-access2.C -std=c++14 # g++:g++.dg/cpp2a/concepts-access2.C -std=c++17 # g++:g++.dg/cpp2a/concepts-access2.C -std=c++98 # g++:g++.dg/template/access41.C -std=c++98 # g++:g++.dg/template/access41a.C -std=c++98 # # # # # Regressions found # # Regressions in 12 common sum files found from (for last_good == b0ab968999c9af88d45acf552ca673ef3960306a) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… Build top page/logs: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-7d8211603a3d04384812b481b0ae01205a287a72 cd investigate-gcc-7d8211603a3d04384812b481b0ae01205a287a72 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 7d8211603a3d04384812b481b0ae01205a287a72 ../artifacts/test.sh # Reproduce last_good build git checkout --detach b0ab968999c9af88d45acf552ca673ef3960306a ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… Build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/73… Full commit (up to 1000 lines): <cut> commit 7d8211603a3d04384812b481b0ae01205a287a72 Author: Richard Biener <rguenther(a)suse.de> Date: Wed Jun 30 16:28:50 2021 +0200 tree-optimization/101178 - handle VEC_PERM in SLP permute propagation This adds handling of VEC_PERM nodes to SLP permute propagation. Previously VEC_PERM acted as forced materialization of incoming permutes since it is a good place to do that (with the constraint of those only appearing for two-operator nodes). The following patch, in addition to supporting (but not forcing) this, enables VEC_PERM nodes acting as "any" permute on the outgoing side since they also can consume arbitrary permutes on that side. This again (meh) changes how we represent permutes and materialization on the graph vertices now explicitely having the common incoming permute as well as an outgoing permute and in case both are different the vertex acts as materialization point of the incoming permute. 2021-06-30 Richard Biener <rguenther(a)suse.de> PR tree-optimization/101178 * tree-vect-slp.c (slpg_vertex::materialize): Remove. (slpg::perm_in): Add. (slpg::get_perm_in): Remove. (slpg::get_perm_materialized): Add. (vect_optimize_slp): Handle VEC_PERM nodes more optimally during permute propagation and materialization. * gcc.dg/vect/bb-slp-72.c: New testcase. * gcc.dg/vect/bb-slp-73.c: Likewise. * gcc.dg/vect/bb-slp-74.c: Likewise. --- gcc/testsuite/gcc.dg/vect/bb-slp-72.c | 29 +++++ gcc/testsuite/gcc.dg/vect/bb-slp-73.c | 29 +++++ gcc/testsuite/gcc.dg/vect/bb-slp-74.c | 30 +++++ gcc/tree-vect-slp.c | 200 ++++++++++++++++++++-------------- 4 files changed, 204 insertions(+), 84 deletions(-) diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-72.c b/gcc/testsuite/gcc.dg/vect/bb-slp-72.c new file mode 100644 index 00000000000..5b243fc1ace --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-72.c @@ -0,0 +1,29 @@ +/* { dg-do run } */ + +#include "tree-vect.h" + +double x[2], y[2], z[2], w[2]; + +void __attribute__((noipa)) foo () +{ + double tem0 = x[1] + y[1]; + double tem1 = x[0] - y[0]; + double tem2 = z[1] * tem0; + double tem3 = z[0] * tem1; + z[0] = tem2 - w[0]; + z[1] = tem3 + w[1]; +} + +int main() +{ + check_vect (); + + x[0] = 1.; x[1] = 2.; + y[0] = 7.; y[1] = -5.; + z[0] = 2.; z[1] = 3.; + w[0] = 9.; w[1] = -5.; + foo (); + if (z[0] != -18. || z[1] != -17.) + __builtin_abort (); + return 0; +} diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-73.c b/gcc/testsuite/gcc.dg/vect/bb-slp-73.c new file mode 100644 index 00000000000..d4c8a514b1c --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-73.c @@ -0,0 +1,29 @@ +/* { dg-do run } */ + +#include "tree-vect.h" + +double x[2], y[2], z[2], w[2]; + +void __attribute__((noipa)) foo () +{ + double tem0 = x[1] + y[1]; + double tem1 = x[0] - y[0]; + double tem2 = z[1] * tem0; + double tem3 = z[0] * tem1; + z[0] = tem2 - w[1]; + z[1] = tem3 + w[0]; +} + +int main() +{ + check_vect (); + + x[0] = 1.; x[1] = 2.; + y[0] = 7.; y[1] = -5.; + z[0] = 2.; z[1] = 3.; + w[0] = 9.; w[1] = -5.; + foo (); + if (z[0] != -4. || z[1] != -3.) + __builtin_abort (); + return 0; +} diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-74.c b/gcc/testsuite/gcc.dg/vect/bb-slp-74.c new file mode 100644 index 00000000000..d3d5a02a29b --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-74.c @@ -0,0 +1,30 @@ +/* { dg-do run } */ + +#include "tree-vect.h" + +double a[2], b[2], c[2]; + +void __attribute__((noipa)) foo () +{ + double tem0 = a[1] + b[1]; + double tem1 = a[0] - b[0]; + c[0] = 2. * tem0; + c[1] = 5. * tem1; +} + +int main() +{ + check_vect (); + + a[0] = 1.; a[1] = 3.; + b[0] = -5.; b[1] = 13.; + foo (); + if (c[0] != 32. || c[1] != 30.) + __builtin_abort (); + return 0; +} + +/* We'd like to see at most one VEC_PERM_EXPR, not one for a blend + and one for a permute materialized somewhere else. But addsub + pattern recog can likely get in the way here. */ +/* { dg-final { scan-tree-dump-times " \[^ \]\+ = VEC_PERM_EXPR" 1 "slp2" } } */ diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c index 10195d3629f..966b281ffae 100644 --- a/gcc/tree-vect-slp.c +++ b/gcc/tree-vect-slp.c @@ -3470,16 +3470,19 @@ vect_analyze_slp (vec_info *vinfo, unsigned max_tree_size) struct slpg_vertex { slpg_vertex (slp_tree node_) - : node (node_), perm_out (-1), materialize (0) {} + : node (node_), perm_in (-1), perm_out (-1) {} - int get_perm_in () const { return materialize ? materialize : perm_out; } + int get_perm_materialized () const + { return perm_in != perm_out ? perm_in : 0; } slp_tree node; - /* The permutation on the outgoing lanes (towards SLP parents). */ + /* The common permutation on the incoming lanes (towards SLP children). */ + int perm_in; + /* The permutation on the outgoing lanes (towards SLP parents). When + the node is a materialization point for a permute this differs + from perm_in (and is then usually zero). Materialization happens + on the input side. */ int perm_out; - /* The permutation that is applied by this node. perm_out is - relative to this. */ - int materialize; }; /* Fill the vertices and leafs vector with all nodes in the SLP graph. */ @@ -3614,7 +3617,11 @@ vect_optimize_slp (vec_info *vinfo) /* Leafs do not change across iterations. Note leafs also double as entries to the reverse graph. */ if (!slpg->vertices[idx].succ) - vertices[idx].perm_out = 0; + { + vertices[idx].perm_in = 0; + vertices[idx].perm_out = 0; + } + /* Loads are the only thing generating permutes. */ if (!SLP_TREE_LOAD_PERMUTATION (node).exists ()) continue; @@ -3663,6 +3670,7 @@ vect_optimize_slp (vec_info *vinfo) for (unsigned j = 0; j < SLP_TREE_LANES (node); ++j) perm[j] = SLP_TREE_LOAD_PERMUTATION (node)[j] - imin; perms.safe_push (perm); + vertices[idx].perm_in = perms.length () - 1; vertices[idx].perm_out = perms.length () - 1; } @@ -3702,8 +3710,11 @@ vect_optimize_slp (vec_info *vinfo) if (STMT_VINFO_DATA_REF (rep) && DR_IS_WRITE (STMT_VINFO_DATA_REF (rep))) { + /* ??? We're forcing materialization in place + of the child here, we'd need special handling + in materialization to leave perm_in -1 here. */ + vertices[idx].perm_in = 0; vertices[idx].perm_out = 0; - continue; } /* We cannot move a permute across an operation that is not independent on lanes. Note this is an explicit @@ -3717,20 +3728,19 @@ vect_optimize_slp (vec_info *vinfo) case CFN_COMPLEX_MUL: case CFN_COMPLEX_MUL_CONJ: case CFN_VEC_ADDSUB: + vertices[idx].perm_in = 0; vertices[idx].perm_out = 0; - continue; default:; } } - int perm; if (!slpg->vertices[idx].succ) /* Pick up pre-computed leaf values. */ - perm = vertices[idx].perm_out; + ; else { bool any_succ_perm_out_m1 = false; - perm = vertices[idx].get_perm_in (); + int perm_in = vertices[idx].perm_in; for (graph_edge *succ = slpg->vertices[idx].succ; succ; succ = succ->succ_next) { @@ -3752,18 +3762,18 @@ vect_optimize_slp (vec_info *vinfo) any_succ_perm_out_m1 = true; continue; } - if (perm == -1) - perm = succ_perm; + if (perm_in == -1) + perm_in = succ_perm; else if (succ_perm == 0 - || !vect_slp_perms_eq (perms, perm, succ_perm)) + || !vect_slp_perms_eq (perms, perm_in, succ_perm)) { - perm = 0; + perm_in = 0; break; } } /* Adjust any incoming permutes we treated optimistically. */ - if (perm != -1 && any_succ_perm_out_m1) + if (perm_in != -1 && any_succ_perm_out_m1) { for (graph_edge *succ = slpg->vertices[idx].succ; succ; succ = succ->succ_next) @@ -3772,24 +3782,36 @@ vect_optimize_slp (vec_info *vinfo) if (vertices[succ->dest].perm_out == -1 && SLP_TREE_DEF_TYPE (succ_node) != vect_external_def && SLP_TREE_DEF_TYPE (succ_node) != vect_constant_def) - vertices[succ->dest].perm_out = perm; + { + vertices[succ->dest].perm_out = perm_in; + /* And ensure this propagates. */ + if (vertices[succ->dest].perm_in == -1) + vertices[succ->dest].perm_in = perm_in; + } } changed = true; } - if (!vect_slp_perms_eq (perms, perm, - vertices[idx].get_perm_in ())) + if (!vect_slp_perms_eq (perms, perm_in, + vertices[idx].perm_in)) { /* Make sure we eventually converge. */ - gcc_checking_assert (vertices[idx].get_perm_in () == -1 - || perm == 0); - if (perm == 0) - { - vertices[idx].perm_out = 0; - vertices[idx].materialize = 0; - } - if (!vertices[idx].materialize) - vertices[idx].perm_out = perm; + gcc_checking_assert (vertices[idx].perm_in == -1 + || perm_in == 0); + vertices[idx].perm_in = perm_in; + + /* While we can handle VEC_PERM nodes as transparent + pass-through they can be a cheap materialization + point as well. In addition they can act as source + of a random permutation as well. + The following ensures that former materialization + points that now have zero incoming permutes no + longer appear as such and that former "any" permutes + get pass-through. We keep VEC_PERM nodes optimistic + as "any" outgoing permute though. */ + if (vertices[idx].perm_out != 0 + && SLP_TREE_CODE (node) != VEC_PERM_EXPR) + vertices[idx].perm_out = perm_in; changed = true; } } @@ -3799,25 +3821,19 @@ vect_optimize_slp (vec_info *vinfo) if (!do_materialization) continue; + int perm = vertices[idx].perm_out; if (perm == 0 || perm == -1) continue; /* Decide on permute materialization. Look whether there's a use (pred) edge that is permuted differently than us. - In that case mark ourselves so the permutation is applied. - For VEC_PERM_EXPRs the permutation doesn't carry along - from children to parents so force materialization at the - point of the VEC_PERM_EXPR. In principle VEC_PERM_EXPRs - are a source of an arbitrary permutation again, similar - to constants/externals - that's something we do not yet - optimally handle. */ - bool all_preds_permuted = (SLP_TREE_CODE (node) != VEC_PERM_EXPR - && slpg->vertices[idx].pred != NULL); + In that case mark ourselves so the permutation is applied. */ + bool all_preds_permuted = slpg->vertices[idx].pred != NULL; if (all_preds_permuted) for (graph_edge *pred = slpg->vertices[idx].pred; pred; pred = pred->pred_next) { - int pred_perm = vertices[pred->src].get_perm_in (); + int pred_perm = vertices[pred->src].perm_in; gcc_checking_assert (pred_perm != -1); if (!vect_slp_perms_eq (perms, perm, pred_perm)) { @@ -3827,10 +3843,8 @@ vect_optimize_slp (vec_info *vinfo) } if (!all_preds_permuted) { - if (!vertices[idx].materialize) - changed = true; - vertices[idx].materialize = perm; vertices[idx].perm_out = 0; + changed = true; } } @@ -3848,46 +3862,43 @@ vect_optimize_slp (vec_info *vinfo) /* Materialize. */ for (i = 0; i < vertices.length (); ++i) { - int perm = vertices[i].get_perm_in (); - if (perm <= 0) - continue; - + int perm_in = vertices[i].perm_in; slp_tree node = vertices[i].node; - /* First permute invariant/external original successors. */ + /* First permute invariant/external original successors, we handle + those optimistically during propagation and duplicate them if + they are used with different permutations. */ unsigned j; slp_tree child; - FOR_EACH_VEC_ELT (SLP_TREE_CHILDREN (node), j, child) - { - if (!child - || (SLP_TREE_DEF_TYPE (child) != vect_constant_def - && SLP_TREE_DEF_TYPE (child) != vect_external_def)) - continue; + if (perm_in > 0) + FOR_EACH_VEC_ELT (SLP_TREE_CHILDREN (node), j, child) + { + if (!child + || (SLP_TREE_DEF_TYPE (child) != vect_constant_def + && SLP_TREE_DEF_TYPE (child) != vect_external_def)) + continue; - /* If the vector is uniform there's nothing to do. */ - if (vect_slp_tree_uniform_p (child)) - continue; + /* If the vector is uniform there's nothing to do. */ + if (vect_slp_tree_uniform_p (child)) + continue; - /* We can end up sharing some externals via two_operator - handling. Be prepared to unshare those. */ - if (child->refcnt != 1) - { - gcc_assert (slpg->vertices[child->vertex].pred->pred_next); - SLP_TREE_CHILDREN (node)[j] = child - = vect_create_new_slp_node - (SLP_TREE_SCALAR_OPS (child).copy ()); - } - vect_slp_permute (perms[perm], - SLP_TREE_SCALAR_OPS (child), true); - } + /* We can end up sharing some externals via two_operator + handling. Be prepared to unshare those. */ + if (child->refcnt != 1) + { + gcc_assert (slpg->vertices[child->vertex].pred->pred_next); + SLP_TREE_CHILDREN (node)[j] = child + = vect_create_new_slp_node + (SLP_TREE_SCALAR_OPS (child).copy ()); + } + vect_slp_permute (perms[perm_in], + SLP_TREE_SCALAR_OPS (child), true); + } - if (vertices[i].materialize) + if (SLP_TREE_CODE (node) == VEC_PERM_EXPR) { - if (SLP_TREE_LOAD_PERMUTATION (node).exists ()) - /* For loads simply drop the permutation, the load permutation - already performs the desired permutation. */ - ; - else if (SLP_TREE_LANE_PERMUTATION (node).exists ()) + /* Apply the common permutes to the input vectors. */ + if (perm_in > 0) { /* If the node is already a permute node we can apply the permutation to the lane selection, effectively @@ -3896,12 +3907,30 @@ vect_optimize_slp (vec_info *vinfo) dump_printf_loc (MSG_NOTE, vect_location, "simplifying permute node %p\n", node); - for (unsigned k = 0; k < SLP_TREE_LANE_PERMUTATION (node).length (); ++k) SLP_TREE_LANE_PERMUTATION (node)[k].second - = perms[perm][SLP_TREE_LANE_PERMUTATION (node)[k].second]; + = perms[perm_in][SLP_TREE_LANE_PERMUTATION (node)[k].second]; + } + /* Apply the anticipated output permute to the permute and + stmt vectors. */ + int perm_out = vertices[i].perm_out; + if (perm_out > 0) + { + vect_slp_permute (perms[perm_out], + SLP_TREE_SCALAR_STMTS (node), true); + vect_slp_permute (perms[perm_out], + SLP_TREE_LANE_PERMUTATION (node), true); } + } + else if (vertices[i].get_perm_materialized () != 0) + { + if (SLP_TREE_LOAD_PERMUTATION (node).exists ()) + /* For loads simply drop the permutation, the load permutation + already performs the desired permutation. */ + ; + else if (SLP_TREE_LANE_PERMUTATION (node).exists ()) + gcc_unreachable (); else { if (dump_enabled_p ()) @@ -3916,7 +3945,7 @@ vect_optimize_slp (vec_info *vinfo) SLP_TREE_CHILDREN (node) = vNULL; SLP_TREE_SCALAR_STMTS (copy) = SLP_TREE_SCALAR_STMTS (node).copy (); - vect_slp_permute (perms[perm], + vect_slp_permute (perms[perm_in], SLP_TREE_SCALAR_STMTS (copy), true); gcc_assert (!SLP_TREE_SCALAR_OPS (node).exists ()); SLP_TREE_REPRESENTATIVE (copy) = SLP_TREE_REPRESENTATIVE (node); @@ -3936,28 +3965,31 @@ vect_optimize_slp (vec_info *vinfo) SLP_TREE_LANE_PERMUTATION (node).create (SLP_TREE_LANES (node)); for (unsigned j = 0; j < SLP_TREE_LANES (node); ++j) SLP_TREE_LANE_PERMUTATION (node) - .quick_push (std::make_pair (0, perms[perm][j])); + .quick_push (std::make_pair (0, perms[perm_in][j])); SLP_TREE_CODE (node) = VEC_PERM_EXPR; } } - else + else if (perm_in > 0) /* perm_in == perm_out */ { /* Apply the reverse permutation to our stmts. */ - vect_slp_permute (perms[perm], + vect_slp_permute (perms[perm_in], SLP_TREE_SCALAR_STMTS (node), true); - /* And to the load permutation, which we can simply + /* And to the lane/load permutation, which we can simply make regular by design. */ if (SLP_TREE_LOAD_PERMUTATION (node).exists ()) { + gcc_assert (!SLP_TREE_LANE_PERMUTATION (node).exists ()); /* ??? When we handle non-bijective permutes the idea is that we can force the load-permutation to be { min, min + 1, min + 2, ... max }. But then the scalar defs might no longer match the lane content which means wrong-code with live lane vectorization. So we possibly have to have NULL entries for those. */ - vect_slp_permute (perms[perm], + vect_slp_permute (perms[perm_in], SLP_TREE_LOAD_PERMUTATION (node), true); } + else if (SLP_TREE_LANE_PERMUTATION (node).exists ()) + gcc_unreachable (); } } @@ -3991,14 +4023,14 @@ vect_optimize_slp (vec_info *vinfo) } else if (SLP_TREE_LOAD_PERMUTATION (old).exists () && SLP_TREE_REF_COUNT (old) == 1 - && vertices[old->vertex].materialize) + && vertices[old->vertex].get_perm_materialized () != 0) { /* ??? For loads the situation is more complex since we can't modify the permute in place in case the node is used multiple times. In fact for loads this should be somehow handled in the propagation engine. */ /* Apply the reverse permutation to our stmts. */ - int perm = vertices[old->vertex].get_perm_in (); + int perm = vertices[old->vertex].get_perm_materialized (); vect_slp_permute (perms[perm], SLP_TREE_SCALAR_STMTS (old), true); vect_slp_permute (perms[perm], </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-release-arm-spec2k6-O3_LTO - Build # 26 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3_LTO Culprit: <cut> commit 9b0365879b3c4917f5a2485a1fca8bb678484bfe Author: Richard Sandiford <richard.sandiford(a)arm.com> Date: Mon Oct 7 08:39:12 2019 +0000 [IRA] Handle fully-tied destinations in a similar way to earlyclobbers IRA's make_early_clobber_and_input_conflicts checks for cases in which an output operand is likely to be an earlyclobber and an input operand is unlikely to be tieable with it. If so, the allocno for the output conflicts with the allocno for the input. This seems to work well. However, a similar situation arises if an output operand is likely to be tied to one of a set of input operands X and if another input operand has a different value from all of the operands in X. E.g. if we have: 0: "=r, r" 1: "0, r" 2: "r, 0" 3: "r, r" operand 0 will always be tied to operand 1 or operand 2, so if operand 3 is different from them both, operand 0 acts like an earlyclobber as far as operand 3 (only) is concerned. The same is true for operand 2 in: 0: "=r" 1: "0" 2: "r" In the second example, we'd normally have a copy between operand 1 and operand 0 if operand 1 dies in the instruction, and so there's rarely a problem. But if operand 1 doesn't die in the instruction, operand 0 still acts as an earlyclobber for operand 2 (if different from operand 1), since in that case LRA must copy operand 1 to operand 0 before the instruction. As the existing comment says: Avoid introducing unnecessary conflicts by checking classes of the constraints and pseudos because otherwise significant code degradation is possible for some targets. I think that's doubly true here. E.g. it's perfectly reasonable to have constraints like: 0: "=r, r" 1: "0, r" 2: "r, r" on targets like s390 that have shorter instructions for tied operands, but that don't want the size difference to influence RA too much. We shouldn't treat operand 0 as earlyclobber wrt operand 2 in that case. This patch therefore treats a normal tied non-earlyclobber output as being effectively earlyclobber wrt to an input if it is so for *all* preferred alternatives. 2019-10-07 Richard Sandiford <richard.sandiford(a)arm.com> gcc/ * ira-lives.c (check_and_make_def_conflict): Handle cases in which DEF is not a true earlyclobber but is tied to a specific input operand, and so is effectively earlyclobber wrt inputs that have different values. (make_early_clobber_and_input_conflicts): Pass this case to the above. From-SVN: r276650 </cut> Results regressed to (for first_bad == 9b0365879b3c4917f5a2485a1fca8bb678484bfe) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO_marm -- artifacts/build-9b0365879b3c4917f5a2485a1fca8bb678484bfe/results_id: 1 # 470.lbm,lbm_base.default regressed by 122 # 454.calculix,calculix_base.default regressed by 105 from (for last_good == ad00d6c1746fdcbfd86b2d50f2500d7ccb0d1691) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_LTO_marm -- artifacts/build-ad00d6c1746fdcbfd86b2d50f2500d7ccb0d1691/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3_LTO/1079 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3_LTO/1049 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-9b0365879b3c4917f5a2485a1fca8bb678484bfe cd investigate-gcc-9b0365879b3c4917f5a2485a1fca8bb678484bfe git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 9b0365879b3c4917f5a2485a1fca8bb678484bfe ../artifacts/test.sh # Reproduce last_good build git checkout --detach ad00d6c1746fdcbfd86b2d50f2500d7ccb0d1691 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Full commit (up to 1000 lines): <cut> commit 9b0365879b3c4917f5a2485a1fca8bb678484bfe Author: Richard Sandiford <richard.sandiford(a)arm.com> Date: Mon Oct 7 08:39:12 2019 +0000 [IRA] Handle fully-tied destinations in a similar way to earlyclobbers IRA's make_early_clobber_and_input_conflicts checks for cases in which an output operand is likely to be an earlyclobber and an input operand is unlikely to be tieable with it. If so, the allocno for the output conflicts with the allocno for the input. This seems to work well. However, a similar situation arises if an output operand is likely to be tied to one of a set of input operands X and if another input operand has a different value from all of the operands in X. E.g. if we have: 0: "=r, r" 1: "0, r" 2: "r, 0" 3: "r, r" operand 0 will always be tied to operand 1 or operand 2, so if operand 3 is different from them both, operand 0 acts like an earlyclobber as far as operand 3 (only) is concerned. The same is true for operand 2 in: 0: "=r" 1: "0" 2: "r" In the second example, we'd normally have a copy between operand 1 and operand 0 if operand 1 dies in the instruction, and so there's rarely a problem. But if operand 1 doesn't die in the instruction, operand 0 still acts as an earlyclobber for operand 2 (if different from operand 1), since in that case LRA must copy operand 1 to operand 0 before the instruction. As the existing comment says: Avoid introducing unnecessary conflicts by checking classes of the constraints and pseudos because otherwise significant code degradation is possible for some targets. I think that's doubly true here. E.g. it's perfectly reasonable to have constraints like: 0: "=r, r" 1: "0, r" 2: "r, r" on targets like s390 that have shorter instructions for tied operands, but that don't want the size difference to influence RA too much. We shouldn't treat operand 0 as earlyclobber wrt operand 2 in that case. This patch therefore treats a normal tied non-earlyclobber output as being effectively earlyclobber wrt to an input if it is so for *all* preferred alternatives. 2019-10-07 Richard Sandiford <richard.sandiford(a)arm.com> gcc/ * ira-lives.c (check_and_make_def_conflict): Handle cases in which DEF is not a true earlyclobber but is tied to a specific input operand, and so is effectively earlyclobber wrt inputs that have different values. (make_early_clobber_and_input_conflicts): Pass this case to the above. From-SVN: r276650 --- gcc/ChangeLog | 8 ++++++ gcc/ira-lives.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++---------- 2 files changed, 80 insertions(+), 14 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index ce915859592..798d16cf0c6 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2019-10-07 Richard Sandiford <richard.sandiford(a)arm.com> + + * ira-lives.c (check_and_make_def_conflict): Handle cases in which + DEF is not a true earlyclobber but is tied to a specific input + operand, and so is effectively earlyclobber wrt inputs that have + different values. + (make_early_clobber_and_input_conflicts): Pass this case to the above. + 2019-10-07 Richard Sandiford <richard.sandiford(a)arm.com> * machmode.h (opt_mode): Mark constructors with CONSTEXPR. diff --git a/gcc/ira-lives.c b/gcc/ira-lives.c index cce73a1c3d4..098b0e73953 100644 --- a/gcc/ira-lives.c +++ b/gcc/ira-lives.c @@ -633,9 +633,28 @@ check_and_make_def_use_conflict (rtx dreg, rtx orig_dreg, /* Check and make if necessary conflicts for definition DEF of class DEF_CL of the current insn with input operands. Process only - constraints of alternative ALT. */ + constraints of alternative ALT. + + One of three things is true when this function is called: + + (1) DEF is an earlyclobber for alternative ALT. Input operands then + conflict with DEF in ALT unless they explicitly match DEF via 0-9 + constraints. + + (2) DEF matches (via 0-9 constraints) an operand that is an + earlyclobber for alternative ALT. Other input operands then + conflict with DEF in ALT. + + (3) [FOR_TIE_P] Some input operand X matches DEF for alternative ALT. + Input operands with a different value from X then conflict with + DEF in ALT. + + However, there's still a judgement call to make when deciding + whether a conflict in ALT is important enough to be reflected + in the pan-alternative allocno conflict set. */ static void -check_and_make_def_conflict (int alt, int def, enum reg_class def_cl) +check_and_make_def_conflict (int alt, int def, enum reg_class def_cl, + bool for_tie_p) { int use, use_match; ira_allocno_t a; @@ -669,14 +688,40 @@ check_and_make_def_conflict (int alt, int def, enum reg_class def_cl) if (use == def || recog_data.operand_type[use] == OP_OUT) continue; + /* An earlyclobber on DEF doesn't apply to an input operand X if X + explicitly matches DEF, but it applies to other input operands + even if they happen to be the same value as X. + + In contrast, if an input operand X is tied to a non-earlyclobber + DEF, there's no conflict with other input operands that have the + same value as X. */ + if (op_alt[use].matches == def + || (for_tie_p + && rtx_equal_p (recog_data.operand[use], + recog_data.operand[op_alt[def].matched]))) + continue; + if (op_alt[use].anything_ok) use_cl = ALL_REGS; else use_cl = op_alt[use].cl; + if (use_cl == NO_REGS) + continue; + + /* If DEF is simply a tied operand, ignore cases in which this + alternative requires USE to have a likely-spilled class. + Adding a conflict would just constrain USE further if DEF + happens to be allocated first. */ + if (for_tie_p && targetm.class_likely_spilled_p (use_cl)) + continue; /* If there's any alternative that allows USE to match DEF, do not record a conflict. If that causes us to create an invalid - instruction due to the earlyclobber, reload must fix it up. */ + instruction due to the earlyclobber, reload must fix it up. + + Likewise, if we're treating a tied DEF like a partial earlyclobber, + do not record a conflict if there's another alternative in which + DEF is neither tied nor earlyclobber. */ for (alt1 = 0; alt1 < recog_data.n_alternatives; alt1++) { if (!TEST_BIT (preferred_alternatives, alt1)) @@ -691,6 +736,12 @@ check_and_make_def_conflict (int alt, int def, enum reg_class def_cl) && recog_data.constraints[use - 1][0] == '%' && op_alt1[use - 1].matches == def)) break; + if (for_tie_p + && !op_alt1[def].earlyclobber + && op_alt1[def].matched < 0 + && alternative_class (op_alt1, def) != NO_REGS + && alternative_class (op_alt1, use) != NO_REGS) + break; } if (alt1 < recog_data.n_alternatives) @@ -701,8 +752,7 @@ check_and_make_def_conflict (int alt, int def, enum reg_class def_cl) if ((use_match = op_alt[use].matches) >= 0) { - if (use_match == def) - continue; + gcc_checking_assert (use_match != def); if (op_alt[use_match].anything_ok) use_cl = ALL_REGS; @@ -717,7 +767,11 @@ check_and_make_def_conflict (int alt, int def, enum reg_class def_cl) /* Make conflicts of early clobber pseudo registers of the current insn with its inputs. Avoid introducing unnecessary conflicts by checking classes of the constraints and pseudos because otherwise - significant code degradation is possible for some targets. */ + significant code degradation is possible for some targets. + + For these purposes, tying an input to an output makes that output act + like an earlyclobber for inputs with a different value, since the output + register then has a predetermined purpose on input to the instruction. */ static void make_early_clobber_and_input_conflicts (void) { @@ -732,15 +786,19 @@ make_early_clobber_and_input_conflicts (void) if (TEST_BIT (preferred_alternatives, alt)) for (def = 0; def < n_operands; def++) { - def_cl = NO_REGS; - if (op_alt[def].earlyclobber) + if (op_alt[def].anything_ok) + def_cl = ALL_REGS; + else + def_cl = op_alt[def].cl; + if (def_cl != NO_REGS) { - if (op_alt[def].anything_ok) - def_cl = ALL_REGS; - else - def_cl = op_alt[def].cl; - check_and_make_def_conflict (alt, def, def_cl); + if (op_alt[def].earlyclobber) + check_and_make_def_conflict (alt, def, def_cl, false); + else if (op_alt[def].matched >= 0 + && !targetm.class_likely_spilled_p (def_cl)) + check_and_make_def_conflict (alt, def, def_cl, true); } + if ((def_match = op_alt[def].matches) >= 0 && (op_alt[def_match].earlyclobber || op_alt[def].earlyclobber)) @@ -749,7 +807,7 @@ make_early_clobber_and_input_conflicts (void) def_cl = ALL_REGS; else def_cl = op_alt[def_match].cl; - check_and_make_def_conflict (alt, def, def_cl); + check_and_make_def_conflict (alt, def, def_cl, false); } } } </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O3 - Build # 28 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O3 Culprit: <cut> commit a7e655ae4016eaf04e261ff32fc67a14ebb0e329 Author: Andrew MacLeod <amacleod(a)redhat.com> Date: Fri Jun 25 11:24:30 2021 -0400 Add stmt context in simplify_using_ranges. There were places simplify_using_ranges was not utilzing the stmt context. * vr-values.c (vr_values::vrp_stmt_computes_nonzero): Use stmt. (simplify_using_ranges::op_with_boolean_value_range_p): Add a statement for location context. (check_for_binary_op_overflow): Ditto. (simplify_using_ranges::get_vr_for_comparison): Ditto. (simplify_using_ranges::compare_name_with_value): Ditto. (simplify_using_ranges::compare_names): Ditto. (vrp_evaluate_conditional_warnv_with_ops_using_ranges): Ditto. (simplify_using_ranges::simplify_truth_ops_using_ranges): Ditto. (simplify_using_ranges::simplify_min_or_max_using_ranges): Ditto. (simplify_using_ranges::simplify_internal_call_using_ranges): Ditto. (simplify_using_ranges::two_valued_val_range_p): Ditto. (simplify_using_ranges::simplify): Ditto. * vr-values.h: Adjust prototypes. </cut> Results regressed to (for first_bad == a7e655ae4016eaf04e261ff32fc67a14ebb0e329) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3 -- artifacts/build-a7e655ae4016eaf04e261ff32fc67a14ebb0e329/results_id: 1 # 447.dealII,dealII_base.default regressed by 104 # 447.dealII,[.] _ZNK12SparseMatrixIdE5vmultI6VectorIdES3_EEvRT regressed by 125 from (for last_good == 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3 -- artifacts/build-8a8a7d332d5d01db5aea7336a36d9fd71a679fb1/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O3/1076 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O3/1068 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-a7e655ae4016eaf04e261ff32fc67a14ebb0e329 cd investigate-gcc-a7e655ae4016eaf04e261ff32fc67a14ebb0e329 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach a7e655ae4016eaf04e261ff32fc67a14ebb0e329 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit a7e655ae4016eaf04e261ff32fc67a14ebb0e329 Author: Andrew MacLeod <amacleod(a)redhat.com> Date: Fri Jun 25 11:24:30 2021 -0400 Add stmt context in simplify_using_ranges. There were places simplify_using_ranges was not utilzing the stmt context. * vr-values.c (vr_values::vrp_stmt_computes_nonzero): Use stmt. (simplify_using_ranges::op_with_boolean_value_range_p): Add a statement for location context. (check_for_binary_op_overflow): Ditto. (simplify_using_ranges::get_vr_for_comparison): Ditto. (simplify_using_ranges::compare_name_with_value): Ditto. (simplify_using_ranges::compare_names): Ditto. (vrp_evaluate_conditional_warnv_with_ops_using_ranges): Ditto. (simplify_using_ranges::simplify_truth_ops_using_ranges): Ditto. (simplify_using_ranges::simplify_min_or_max_using_ranges): Ditto. (simplify_using_ranges::simplify_internal_call_using_ranges): Ditto. (simplify_using_ranges::two_valued_val_range_p): Ditto. (simplify_using_ranges::simplify): Ditto. * vr-values.h: Adjust prototypes. --- gcc/vr-values.c | 71 ++++++++++++++++++++++++++++++--------------------------- gcc/vr-values.h | 14 +++++++----- 2 files changed, 46 insertions(+), 39 deletions(-) diff --git a/gcc/vr-values.c b/gcc/vr-values.c index 3ae2c68499d..190676de2c0 100644 --- a/gcc/vr-values.c +++ b/gcc/vr-values.c @@ -429,7 +429,7 @@ vr_values::vrp_stmt_computes_nonzero (gimple *stmt) && !TYPE_OVERFLOW_WRAPS (TREE_TYPE (expr)))) { const value_range_equiv *vr - = get_value_range (TREE_OPERAND (base, 0)); + = get_value_range (TREE_OPERAND (base, 0), stmt); if (!range_includes_zero_p (vr)) return true; } @@ -486,7 +486,7 @@ vr_values::op_with_constant_singleton_value_range (tree op) /* Return true if op is in a boolean [0, 1] value-range. */ bool -simplify_using_ranges::op_with_boolean_value_range_p (tree op) +simplify_using_ranges::op_with_boolean_value_range_p (tree op, gimple *s) { if (TYPE_PRECISION (TREE_TYPE (op)) == 1) return true; @@ -500,7 +500,7 @@ simplify_using_ranges::op_with_boolean_value_range_p (tree op) /* ?? Errr, this should probably check for [0,0] and [1,1] as well as [0,1]. */ - const value_range *vr = query->get_value_range (op); + const value_range *vr = query->get_value_range (op, s); return *vr == value_range (build_zero_cst (TREE_TYPE (op)), build_one_cst (TREE_TYPE (op))); } @@ -1057,18 +1057,18 @@ vr_values::extract_range_from_comparison (value_range_equiv *vr, static bool check_for_binary_op_overflow (range_query *query, enum tree_code subcode, tree type, - tree op0, tree op1, bool *ovf) + tree op0, tree op1, bool *ovf, gimple *s = NULL) { value_range vr0, vr1; if (TREE_CODE (op0) == SSA_NAME) - vr0 = *query->get_value_range (op0); + vr0 = *query->get_value_range (op0, s); else if (TREE_CODE (op0) == INTEGER_CST) vr0.set (op0); else vr0.set_varying (TREE_TYPE (op0)); if (TREE_CODE (op1) == SSA_NAME) - vr1 = *query->get_value_range (op1); + vr1 = *query->get_value_range (op1, s); else if (TREE_CODE (op1) == INTEGER_CST) vr1.set (op1); else @@ -1980,10 +1980,11 @@ vr_values::vrp_visit_assignment_or_call (gimple *stmt, tree *output_p, is varying or undefined. Uses TEM as storage for the alternate range. */ const value_range_equiv * -simplify_using_ranges::get_vr_for_comparison (int i, value_range_equiv *tem) +simplify_using_ranges::get_vr_for_comparison (int i, value_range_equiv *tem, + gimple *s) { /* Shallow-copy equiv bitmap. */ - const value_range_equiv *vr = query->get_value_range (ssa_name (i)); + const value_range_equiv *vr = query->get_value_range (ssa_name (i), s); /* If name N_i does not have a valid range, use N_i as its own range. This allows us to compare against names that may @@ -2005,10 +2006,11 @@ simplify_using_ranges::get_vr_for_comparison (int i, value_range_equiv *tem) tree simplify_using_ranges::compare_name_with_value (enum tree_code comp, tree var, tree val, - bool *strict_overflow_p, bool use_equiv_p) + bool *strict_overflow_p, bool use_equiv_p, + gimple *s) { /* Get the set of equivalences for VAR. */ - bitmap e = query->get_value_range (var)->equiv (); + bitmap e = query->get_value_range (var, s)->equiv (); /* Start at -1. Set it to 0 if we do a comparison without relying on overflow, or 1 if all comparisons rely on overflow. */ @@ -2017,7 +2019,7 @@ simplify_using_ranges::compare_name_with_value /* Compare vars' value range with val. */ value_range_equiv tem_vr; const value_range_equiv *equiv_vr - = get_vr_for_comparison (SSA_NAME_VERSION (var), &tem_vr); + = get_vr_for_comparison (SSA_NAME_VERSION (var), &tem_vr, s); bool sop = false; tree retval = compare_range_with_value (comp, equiv_vr, val, &sop); if (retval) @@ -2044,7 +2046,7 @@ simplify_using_ranges::compare_name_with_value && prop_simulate_again_p (SSA_NAME_DEF_STMT (name))) continue; - equiv_vr = get_vr_for_comparison (i, &tem_vr); + equiv_vr = get_vr_for_comparison (i, &tem_vr, s); sop = false; tree t = compare_range_with_value (comp, equiv_vr, val, &sop); if (t) @@ -2084,12 +2086,12 @@ simplify_using_ranges::compare_name_with_value tree simplify_using_ranges::compare_names (enum tree_code comp, tree n1, tree n2, - bool *strict_overflow_p) + bool *strict_overflow_p, gimple *s) { /* Compare the ranges of every name equivalent to N1 against the ranges of every name equivalent to N2. */ - bitmap e1 = query->get_value_range (n1)->equiv (); - bitmap e2 = query->get_value_range (n2)->equiv (); + bitmap e1 = query->get_value_range (n1, s)->equiv (); + bitmap e2 = query->get_value_range (n2, s)->equiv (); /* Use the fake bitmaps if e1 or e2 are not available. */ static bitmap s_e1 = NULL, s_e2 = NULL; @@ -2139,7 +2141,7 @@ simplify_using_ranges::compare_names (enum tree_code comp, tree n1, tree n2, continue; value_range_equiv tem_vr1; - const value_range_equiv *vr1 = get_vr_for_comparison (i1, &tem_vr1); + const value_range_equiv *vr1 = get_vr_for_comparison (i1, &tem_vr1, s); tree t = NULL_TREE, retval = NULL_TREE; bitmap_iterator bi2; @@ -2152,7 +2154,8 @@ simplify_using_ranges::compare_names (enum tree_code comp, tree n1, tree n2, bool sop = false; value_range_equiv tem_vr2; - const value_range_equiv *vr2 = get_vr_for_comparison (i2, &tem_vr2); + const value_range_equiv *vr2 = get_vr_for_comparison (i2, &tem_vr2, + s); t = compare_ranges (comp, vr1, vr2, &sop); if (t) @@ -2198,11 +2201,12 @@ simplify_using_ranges::compare_names (enum tree_code comp, tree n1, tree n2, tree simplify_using_ranges::vrp_evaluate_conditional_warnv_with_ops_using_ranges - (enum tree_code code, tree op0, tree op1, bool * strict_overflow_p) + (enum tree_code code, tree op0, tree op1, bool * strict_overflow_p, + gimple *s) { const value_range_equiv *vr0, *vr1; - vr0 = (TREE_CODE (op0) == SSA_NAME) ? query->get_value_range (op0) : NULL; - vr1 = (TREE_CODE (op1) == SSA_NAME) ? query->get_value_range (op1) : NULL; + vr0 = (TREE_CODE (op0) == SSA_NAME) ? query->get_value_range (op0, s) : NULL; + vr1 = (TREE_CODE (op1) == SSA_NAME) ? query->get_value_range (op1, s) : NULL; tree res = NULL_TREE; if (vr0 && vr1) @@ -2302,20 +2306,20 @@ simplify_using_ranges::vrp_evaluate_conditional_warnv_with_ops } if ((ret = vrp_evaluate_conditional_warnv_with_ops_using_ranges - (code, op0, op1, strict_overflow_p))) + (code, op0, op1, strict_overflow_p, stmt))) return ret; if (only_ranges) *only_ranges = false; /* Do not use compare_names during propagation, it's quadratic. */ if (TREE_CODE (op0) == SSA_NAME && TREE_CODE (op1) == SSA_NAME && use_equiv_p) - return compare_names (code, op0, op1, strict_overflow_p); + return compare_names (code, op0, op1, strict_overflow_p, stmt); else if (TREE_CODE (op0) == SSA_NAME) return compare_name_with_value (code, op0, op1, - strict_overflow_p, use_equiv_p); + strict_overflow_p, use_equiv_p, stmt); else if (TREE_CODE (op1) == SSA_NAME) return compare_name_with_value (swap_tree_comparison (code), op1, op0, - strict_overflow_p, use_equiv_p); + strict_overflow_p, use_equiv_p, stmt); return NULL_TREE; } @@ -2929,11 +2933,11 @@ simplify_using_ranges::simplify_truth_ops_using_ranges gcc_assert (rhs_code == EQ_EXPR || rhs_code == NE_EXPR); op0 = gimple_assign_rhs1 (stmt); - if (!op_with_boolean_value_range_p (op0)) + if (!op_with_boolean_value_range_p (op0, stmt)) return false; op1 = gimple_assign_rhs2 (stmt); - if (!op_with_boolean_value_range_p (op1)) + if (!op_with_boolean_value_range_p (op1, stmt)) return false; /* Reduce number of cases to handle to NE_EXPR. As there is no @@ -3131,12 +3135,12 @@ simplify_using_ranges::simplify_min_or_max_using_ranges tree val; val = (vrp_evaluate_conditional_warnv_with_ops_using_ranges - (LE_EXPR, op0, op1, &sop)); + (LE_EXPR, op0, op1, &sop, stmt)); if (!val) { sop = false; val = (vrp_evaluate_conditional_warnv_with_ops_using_ranges - (LT_EXPR, op0, op1, &sop)); + (LT_EXPR, op0, op1, &sop, stmt)); } if (val) @@ -4000,7 +4004,7 @@ simplify_using_ranges::simplify_internal_call_using_ranges return false; else type = TREE_TYPE (TREE_TYPE (gimple_call_lhs (stmt))); - if (!check_for_binary_op_overflow (query, subcode, type, op0, op1, &ovf) + if (!check_for_binary_op_overflow (query, subcode, type, op0, op1, &ovf, stmt) || (is_ubsan && ovf)) return false; @@ -4057,9 +4061,10 @@ simplify_using_ranges::simplify_internal_call_using_ranges two-values when it is true. Return false otherwise. */ bool -simplify_using_ranges::two_valued_val_range_p (tree var, tree *a, tree *b) +simplify_using_ranges::two_valued_val_range_p (tree var, tree *a, tree *b, + gimple *s) { - value_range vr = *query->get_value_range (var); + value_range vr = *query->get_value_range (var, s); vr.normalize_symbolics (); if (vr.varying_p () || vr.undefined_p ()) return false; @@ -4133,7 +4138,7 @@ simplify_using_ranges::simplify (gimple_stmt_iterator *gsi) tree cmp_var = NULL_TREE; if (TREE_CODE (rhs2) == SSA_NAME - && two_valued_val_range_p (rhs2, &val1, &val2)) + && two_valued_val_range_p (rhs2, &val1, &val2, stmt)) { /* Optimize RHS1 OP [VAL1, VAL2]. */ new_rhs1 = int_const_binop (rhs_code, rhs1, val1); @@ -4141,7 +4146,7 @@ simplify_using_ranges::simplify (gimple_stmt_iterator *gsi) cmp_var = rhs2; } else if (TREE_CODE (rhs1) == SSA_NAME - && two_valued_val_range_p (rhs1, &val1, &val2)) + && two_valued_val_range_p (rhs1, &val1, &val2, stmt)) { /* Optimize [VAL1, VAL2] OP RHS2. */ new_rhs1 = int_const_binop (rhs_code, val1, rhs2); diff --git a/gcc/vr-values.h b/gcc/vr-values.h index 81b9131f7f1..7fdefef2fdf 100644 --- a/gcc/vr-values.h +++ b/gcc/vr-values.h @@ -56,14 +56,16 @@ private: gimple *); bool simplify_internal_call_using_ranges (gimple_stmt_iterator *, gimple *); - bool two_valued_val_range_p (tree, tree *, tree *); - bool op_with_boolean_value_range_p (tree); - tree compare_name_with_value (enum tree_code, tree, tree, bool *, bool); - tree compare_names (enum tree_code, tree, tree, bool *); - const value_range_equiv *get_vr_for_comparison (int, value_range_equiv *); + bool two_valued_val_range_p (tree, tree *, tree *, gimple *); + bool op_with_boolean_value_range_p (tree, gimple *); + tree compare_name_with_value (enum tree_code, tree, tree, bool *, bool, + gimple *); + tree compare_names (enum tree_code, tree, tree, bool *, gimple *s); + const value_range_equiv *get_vr_for_comparison (int, value_range_equiv *, + gimple *s); tree vrp_evaluate_conditional_warnv_with_ops_using_ranges (enum tree_code, tree, tree, - bool *); + bool *, gimple *s); void cleanup_edges_and_switches (void); /* Vectors of edges that need removing and switch statements that </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-master-arm-spec2k6-O2_LTO - Build # 10 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-master-arm-spec2k6-O2_LTO Culprit: <cut> commit a310bb73edc9548e08d1fa28e7a56246caf27757 Author: Richard Biener <rguenther(a)suse.de> Date: Tue May 4 10:07:35 2021 +0200 tree-optimization/100329 - avoid reassociating asm goto defs This avoids reassociating asm goto defs because we have no idea on which outgoing edge to insert defs. 2021-05-04 Richard Biener <rguenther(a)suse.de> PR tree-optimization/100329 * tree-ssa-reassoc.c (can_reassociate_p): Do not reassociate asm goto defs. (insert_stmt_after): Assert we're not running into asm goto. * gcc.dg/torture/pr100329.c: New testcase. </cut> Results regressed to (for first_bad == a310bb73edc9548e08d1fa28e7a56246caf27757) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO_marm -- artifacts/build-a310bb73edc9548e08d1fa28e7a56246caf27757/results_id: 1 # 471.omnetpp,omnetpp_base.default regressed by 103 from (for last_good == 2326627eb19d8c21251fd60479f1a190621c475b) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO_marm -- artifacts/build-2326627eb19d8c21251fd60479f1a190621c475b/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-O2_LTO/1063 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-master-arm-spec2k6-O2_LTO/1045 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-a310bb73edc9548e08d1fa28e7a56246caf27757 cd investigate-gcc-a310bb73edc9548e08d1fa28e7a56246caf27757 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach a310bb73edc9548e08d1fa28e7a56246caf27757 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 2326627eb19d8c21251fd60479f1a190621c475b ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-master-… Full commit (up to 1000 lines): <cut> commit a310bb73edc9548e08d1fa28e7a56246caf27757 Author: Richard Biener <rguenther(a)suse.de> Date: Tue May 4 10:07:35 2021 +0200 tree-optimization/100329 - avoid reassociating asm goto defs This avoids reassociating asm goto defs because we have no idea on which outgoing edge to insert defs. 2021-05-04 Richard Biener <rguenther(a)suse.de> PR tree-optimization/100329 * tree-ssa-reassoc.c (can_reassociate_p): Do not reassociate asm goto defs. (insert_stmt_after): Assert we're not running into asm goto. * gcc.dg/torture/pr100329.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr100329.c | 16 ++++++++++++++++ gcc/tree-ssa-reassoc.c | 10 ++++++++++ 2 files changed, 26 insertions(+) diff --git a/gcc/testsuite/gcc.dg/torture/pr100329.c b/gcc/testsuite/gcc.dg/torture/pr100329.c new file mode 100644 index 00000000000..b90700dd5f0 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr100329.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-additional-options "--param tree-reassoc-width=2" } */ + +unsigned int a0; + +unsigned int +foo (unsigned int a1, unsigned int a2) +{ + unsigned int x; + + asm goto ("" : "=r" (x) : : : lab); + a0 = x; + + lab: + return x + a1 + a2 + 1; +} diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c index 8e2a4896d14..359367c9382 100644 --- a/gcc/tree-ssa-reassoc.c +++ b/gcc/tree-ssa-reassoc.c @@ -1446,6 +1446,10 @@ insert_stmt_after (gimple *stmt, gimple *insert_point) gsi_insert_after (&gsi, stmt, GSI_NEW_STMT); return; } + else if (gimple_code (insert_point) == GIMPLE_ASM) + /* We have no idea where to insert - it depends on where the + uses will be placed. */ + gcc_unreachable (); else /* We assume INSERT_POINT is a SSA_NAME_DEF_STMT of some SSA_NAME, thus if it must end a basic block, it should be a call that can @@ -5893,6 +5897,12 @@ can_reassociate_p (tree op) tree type = TREE_TYPE (op); if (TREE_CODE (op) == SSA_NAME && SSA_NAME_OCCURS_IN_ABNORMAL_PHI (op)) return false; + /* Make sure asm goto outputs do not participate in reassociation since + we have no way to find an insertion place after asm goto. */ + if (TREE_CODE (op) == SSA_NAME + && gimple_code (SSA_NAME_DEF_STMT (op)) == GIMPLE_ASM + && gimple_asm_nlabels (as_a <gasm *> (SSA_NAME_DEF_STMT (op))) != 0) + return false; if ((ANY_INTEGRAL_TYPE_P (type) && TYPE_OVERFLOW_WRAPS (type)) || NON_SAT_FIXED_POINT_TYPE_P (type) || (flag_associative_math && FLOAT_TYPE_P (type))) </cut>

3 years, 11 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_gnu/gnu-master-arm-check_bootstrap - Build # 72 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_gnu/gnu-master-arm-check_bootstrap. So far, this commit has regressed CI configurations: - tcwg_gnu/gnu-master-arm-check_bootstrap Culprit: <cut> commit 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 Author: Ian Lance Taylor <iant(a)golang.org> Date: Mon Jun 28 16:47:55 2021 -0700 compiler: in composite literals use temps only for interfaces For a composite literal we only need to introduce a temporary variable if we may be converting to an interface type, so only do it then. This saves over 80% of compilation time when using gccgo to compile cmd/internal/obj/x86, as the GCC middle-end spends a lot of time pointlessly computing interactions between temporary variables. For PR debug/101064 For golang/go#46600 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/331513 </cut> Results regressed to (for first_bad == 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 # # Comparing directories # # REFERENCE: base-artifacts/sumfiles # # CURRENT: /home/tcwg-buildslave/workspace/tcwg_gnu_2/artifacts/build-8a8a7d332d5d01db5aea7336a36d9fd71a679fb1/sumfiles # # # Comparing 12 common sum files: # g++.sum # gcc.sum # gfortran.sum # go.sum # gotools.sum # libatomic.sum # libffi.sum # libgo.sum # libgomp.sum # libitm.sum # libstdc++.sum # objc.sum # Comparing: # REFERENCE:/tmp/gxx-sum1.1601595 # CURRENT: /tmp/gxx-sum2.1601595 # # ` +---------+---------+ # o RUN STATUS: | REF | RES | # +------------------------------------------+---------+---------+ # | Passes [PASS] | 460522 | 460519 | # | Unexpected fails [FAIL] | 194 | 197 | # | Errors [ERROR] | 0 | 0 | # | Unexpected passes [XPASS] | 15 | 15 | # | Expected fails [XFAIL] | 2737 | 2737 | # | Unresolved [UNRESOLVED] | 104 | 104 | # | Unsupported [UNSUPPORTED] | 22896 | 22896 | # | Untested [UNTESTED] | 10 | 10 | # +------------------------------------------+---------+---------+ # # REF PASS ratio: 0.952271 # RES PASS ratio: 0.952265 # # o REGRESSIONS: # +------------------------------------------+---------+ # | PASS now FAIL [PASS => FAIL] | 3 | # +------------------------------------------+---------+ # | TOTAL_REGRESSIONS | 3 | # +------------------------------------------+---------+ # # - PASS now FAIL [PASS => FAIL]: # # Executed from: go.test/go-test.exp # go:go.test/test/fixedbugs/issue19182.go execution, -O2 -g # Executed from: /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gcc.git~master/libgo/libgo.exp # libgo:os/signal # libgo:sync/atomic # # # # o IMPROVEMENTS TO BE CHECKED: # +------------------------------------------+---------+ # +------------------------------------------+---------+ # | TOTAL_IMPROVEMENTS_TO_BE_CHECKED | 0 | # +------------------------------------------+---------+ # # # # Regressions found # # Regressions in 12 common sum files found from (for last_good == c60d9160b4d966dbea5b1bbea4f817c64d0bee2d) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… Build top page/logs: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 cd investigate-gcc-8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 ../artifacts/test.sh # Reproduce last_good build git checkout --detach c60d9160b4d966dbea5b1bbea4f817c64d0bee2d ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… Build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/72… Full commit (up to 1000 lines): <cut> commit 8a8a7d332d5d01db5aea7336a36d9fd71a679fb1 Author: Ian Lance Taylor <iant(a)golang.org> Date: Mon Jun 28 16:47:55 2021 -0700 compiler: in composite literals use temps only for interfaces For a composite literal we only need to introduce a temporary variable if we may be converting to an interface type, so only do it then. This saves over 80% of compilation time when using gccgo to compile cmd/internal/obj/x86, as the GCC middle-end spends a lot of time pointlessly computing interactions between temporary variables. For PR debug/101064 For golang/go#46600 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/331513 --- gcc/go/gofrontend/MERGE | 2 +- gcc/go/gofrontend/expressions.cc | 17 +++++++++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index f16fb9facc3..f7bcc8c484a 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -bcafcb3c39530bb325514d6377747eb3127d1a03 +cad187fe3aceb2a7d964b64c70dfa8c8ad24ce65 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc index 5d45e4baab4..94342b2f9b8 100644 --- a/gcc/go/gofrontend/expressions.cc +++ b/gcc/go/gofrontend/expressions.cc @@ -15148,7 +15148,7 @@ Struct_construction_expression::do_copy() } // Flatten a struct construction expression. Store the values into -// temporaries in case they need interface conversion. +// temporaries if they may need interface conversion. Expression* Struct_construction_expression::do_flatten(Gogo*, Named_object*, @@ -15162,10 +15162,13 @@ Struct_construction_expression::do_flatten(Gogo*, Named_object*, return this; Location loc = this->location(); + const Struct_field_list* fields = this->type_->struct_type()->fields(); + Struct_field_list::const_iterator pf = fields->begin(); for (Expression_list::iterator pv = this->vals()->begin(); pv != this->vals()->end(); - ++pv) + ++pv, ++pf) { + go_assert(pf != fields->end()); if (*pv != NULL) { if ((*pv)->is_error_expression() || (*pv)->type()->is_error_type()) @@ -15173,7 +15176,8 @@ Struct_construction_expression::do_flatten(Gogo*, Named_object*, go_assert(saw_errors()); return Expression::make_error(loc); } - if (!(*pv)->is_multi_eval_safe()) + if (pf->type()->interface_type() != NULL + && !(*pv)->is_multi_eval_safe()) { Temporary_statement* temp = Statement::make_temporary(NULL, *pv, loc); @@ -15448,7 +15452,7 @@ Array_construction_expression::do_check_types(Gogo*) } // Flatten an array construction expression. Store the values into -// temporaries in case they need interface conversion. +// temporaries if they may need interface conversion. Expression* Array_construction_expression::do_flatten(Gogo*, Named_object*, @@ -15467,6 +15471,11 @@ Array_construction_expression::do_flatten(Gogo*, Named_object*, if (this->is_constant_array() || this->is_static_initializer()) return this; + // If the array element type is not an interface type, we don't need + // temporaries. + if (this->type_->array_type()->element_type()->interface_type() == NULL) + return this; + Location loc = this->location(); for (Expression_list::iterator pv = this->vals()->begin(); pv != this->vals()->end(); </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-master-aarch64-spec2k6-O2_LTO - Build # 16 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O2_LTO Culprit: <cut> commit 6998f8ae2d14e096aff33968f226587b5c1a193a Author: David Sherwood <david.sherwood(a)arm.com> Date: Wed Mar 10 08:34:19 2021 +0000 [LoopVectorize] Simplify scalar cost calculation in getInstructionCost This patch simplifies the calculation of certain costs in getInstructionCost when isScalarAfterVectorization() returns a true value. There are a few places where we multiply a cost by a number N, i.e. unsigned N = isScalarAfterVectorization(I, VF) ? VF.getKnownMinValue() : 1; return N * TTI.getArithmeticInstrCost(... After some investigation it seems that there are only these cases that occur in practice: 1. VF is a scalar, in which case N = 1. 2. VF is a vector. We can only get here if: a) the instruction is a GEP/bitcast/PHI with scalar uses, or b) this is an update to an induction variable that remains scalar. I have changed the code so that N is assumed to always be 1. For GEPs the cost is always 0, since this is calculated later on as part of the load/store cost. PHI nodes are costed separately and were never previously multiplied by VF. For all other cases I have added an assert that none of the users needs scalarising, which didn't fire in any unit tests. Only one test required fixing and I believe the original cost for the scalar add instruction to have been wrong, since only one copy remains after vectorisation. I have also added a new test for the case when a pointer PHI feeds directly into a store that will be scalarised as we were previously never testing it. Differential Revision: https://reviews.llvm.org/D99718 </cut> Results regressed to (for first_bad == 6998f8ae2d14e096aff33968f226587b5c1a193a) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO -- artifacts/build-6998f8ae2d14e096aff33968f226587b5c1a193a/results_id: 1 # 462.libquantum,libquantum_base.default regressed by 113 from (for last_good == c835630c25a4f9925517949579f66a43b113fbc9) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO -- artifacts/build-c835630c25a4f9925517949579f66a43b113fbc9/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O2_LTO/1050 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O2_LTO/1048 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-6998f8ae2d14e096aff33968f226587b5c1a193a cd investigate-llvm-6998f8ae2d14e096aff33968f226587b5c1a193a git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 6998f8ae2d14e096aff33968f226587b5c1a193a ../artifacts/test.sh # Reproduce last_good build git checkout --detach c835630c25a4f9925517949579f66a43b113fbc9 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Full commit (up to 1000 lines): <cut> commit 6998f8ae2d14e096aff33968f226587b5c1a193a Author: David Sherwood <david.sherwood(a)arm.com> Date: Wed Mar 10 08:34:19 2021 +0000 [LoopVectorize] Simplify scalar cost calculation in getInstructionCost This patch simplifies the calculation of certain costs in getInstructionCost when isScalarAfterVectorization() returns a true value. There are a few places where we multiply a cost by a number N, i.e. unsigned N = isScalarAfterVectorization(I, VF) ? VF.getKnownMinValue() : 1; return N * TTI.getArithmeticInstrCost(... After some investigation it seems that there are only these cases that occur in practice: 1. VF is a scalar, in which case N = 1. 2. VF is a vector. We can only get here if: a) the instruction is a GEP/bitcast/PHI with scalar uses, or b) this is an update to an induction variable that remains scalar. I have changed the code so that N is assumed to always be 1. For GEPs the cost is always 0, since this is calculated later on as part of the load/store cost. PHI nodes are costed separately and were never previously multiplied by VF. For all other cases I have added an assert that none of the users needs scalarising, which didn't fire in any unit tests. Only one test required fixing and I believe the original cost for the scalar add instruction to have been wrong, since only one copy remains after vectorisation. I have also added a new test for the case when a pointer PHI feeds directly into a store that will be scalarised as we were previously never testing it. Differential Revision: https://reviews.llvm.org/D99718 --- llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | 73 +++++++++++++--------- .../AArch64/no_vector_instructions.ll | 2 +- .../LoopVectorize/AArch64/predication_costs.ll | 35 +++++++++++ .../Transforms/LoopVectorize/scalarized-bitcast.ll | 40 ++++++++++++ 4 files changed, 121 insertions(+), 29 deletions(-) diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp index 2b413fc49505..f25af23c86c2 100644 --- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -7383,10 +7383,39 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, Type *RetTy = I->getType(); if (canTruncateToMinimalBitwidth(I, VF)) RetTy = IntegerType::get(RetTy->getContext(), MinBWs[I]); - VectorTy = isScalarAfterVectorization(I, VF) ? RetTy : ToVectorTy(RetTy, VF); auto SE = PSE.getSE(); TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput; + auto hasSingleCopyAfterVectorization = [this](Instruction *I, + ElementCount VF) -> bool { + if (VF.isScalar()) + return true; + + auto Scalarized = InstsToScalarize.find(VF); + assert(Scalarized != InstsToScalarize.end() && + "VF not yet analyzed for scalarization profitability"); + return !Scalarized->second.count(I) && + llvm::all_of(I->users(), [&](User *U) { + auto *UI = cast<Instruction>(U); + return !Scalarized->second.count(UI); + }); + }; + + if (isScalarAfterVectorization(I, VF)) { + // With the exception of GEPs and PHIs, after scalarization there should + // only be one copy of the instruction generated in the loop. This is + // because the VF is either 1, or any instructions that need scalarizing + // have already been dealt with by the the time we get here. As a result, + // it means we don't have to multiply the instruction cost by VF. + assert(I->getOpcode() == Instruction::GetElementPtr || + I->getOpcode() == Instruction::PHI || + (I->getOpcode() == Instruction::BitCast && + I->getType()->isPointerTy()) || + hasSingleCopyAfterVectorization(I, VF)); + VectorTy = RetTy; + } else + VectorTy = ToVectorTy(RetTy, VF); + // TODO: We need to estimate the cost of intrinsic calls. switch (I->getOpcode()) { case Instruction::GetElementPtr: @@ -7514,21 +7543,16 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, Op2VK = TargetTransformInfo::OK_UniformValue; SmallVector<const Value *, 4> Operands(I->operand_values()); - unsigned N = isScalarAfterVectorization(I, VF) ? VF.getKnownMinValue() : 1; - return N * TTI.getArithmeticInstrCost( - I->getOpcode(), VectorTy, CostKind, - TargetTransformInfo::OK_AnyValue, - Op2VK, TargetTransformInfo::OP_None, Op2VP, Operands, I); + return TTI.getArithmeticInstrCost( + I->getOpcode(), VectorTy, CostKind, TargetTransformInfo::OK_AnyValue, + Op2VK, TargetTransformInfo::OP_None, Op2VP, Operands, I); } case Instruction::FNeg: { assert(!VF.isScalable() && "VF is assumed to be non scalable."); - unsigned N = isScalarAfterVectorization(I, VF) ? VF.getKnownMinValue() : 1; - return N * TTI.getArithmeticInstrCost( - I->getOpcode(), VectorTy, CostKind, - TargetTransformInfo::OK_AnyValue, - TargetTransformInfo::OK_AnyValue, - TargetTransformInfo::OP_None, TargetTransformInfo::OP_None, - I->getOperand(0), I); + return TTI.getArithmeticInstrCost( + I->getOpcode(), VectorTy, CostKind, TargetTransformInfo::OK_AnyValue, + TargetTransformInfo::OK_AnyValue, TargetTransformInfo::OP_None, + TargetTransformInfo::OP_None, I->getOperand(0), I); } case Instruction::Select: { SelectInst *SI = cast<SelectInst>(I); @@ -7583,6 +7607,10 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, VectorTy = ToVectorTy(getMemInstValueType(I), Width); return getMemoryInstructionCost(I, VF); } + case Instruction::BitCast: + if (I->getType()->isPointerTy()) + return 0; + LLVM_FALLTHROUGH; case Instruction::ZExt: case Instruction::SExt: case Instruction::FPToUI: @@ -7593,8 +7621,7 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, case Instruction::SIToFP: case Instruction::UIToFP: case Instruction::Trunc: - case Instruction::FPTrunc: - case Instruction::BitCast: { + case Instruction::FPTrunc: { // Computes the CastContextHint from a Load/Store instruction. auto ComputeCCH = [&](Instruction *I) -> TTI::CastContextHint { assert((isa<LoadInst>(I) || isa<StoreInst>(I)) && @@ -7672,14 +7699,7 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, } } - unsigned N; - if (isScalarAfterVectorization(I, VF)) { - assert(!VF.isScalable() && "VF is assumed to be non scalable"); - N = VF.getKnownMinValue(); - } else - N = 1; - return N * - TTI.getCastInstrCost(Opcode, VectorTy, SrcVecTy, CCH, CostKind, I); + return TTI.getCastInstrCost(Opcode, VectorTy, SrcVecTy, CCH, CostKind, I); } case Instruction::Call: { bool NeedToScalarize; @@ -7694,11 +7714,8 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, ElementCount VF, case Instruction::ExtractValue: return TTI.getInstructionCost(I, TTI::TCK_RecipThroughput); default: - // The cost of executing VF copies of the scalar instruction. This opcode - // is unknown. Assume that it is the same as 'mul'. - return VF.getKnownMinValue() * TTI.getArithmeticInstrCost( - Instruction::Mul, VectorTy, CostKind) + - getScalarizationOverhead(I, VF); + // This opcode is unknown. Assume that it is the same as 'mul'. + return TTI.getArithmeticInstrCost(Instruction::Mul, VectorTy, CostKind); } // end of switch. } diff --git a/llvm/test/Transforms/LoopVectorize/AArch64/no_vector_instructions.ll b/llvm/test/Transforms/LoopVectorize/AArch64/no_vector_instructions.ll index 247ea35ff5d0..3061998518ad 100644 --- a/llvm/test/Transforms/LoopVectorize/AArch64/no_vector_instructions.ll +++ b/llvm/test/Transforms/LoopVectorize/AArch64/no_vector_instructions.ll @@ -6,7 +6,7 @@ target triple = "aarch64--linux-gnu" ; CHECK-LABEL: all_scalar ; CHECK: LV: Found scalar instruction: %i.next = add nuw nsw i64 %i, 2 -; CHECK: LV: Found an estimated cost of 2 for VF 2 For instruction: %i.next = add nuw nsw i64 %i, 2 +; CHECK: LV: Found an estimated cost of 1 for VF 2 For instruction: %i.next = add nuw nsw i64 %i, 2 ; CHECK: LV: Not considering vector loop of width 2 because it will not generate any vector instructions ; define void @all_scalar(i64* %a, i64 %n) { diff --git a/llvm/test/Transforms/LoopVectorize/AArch64/predication_costs.ll b/llvm/test/Transforms/LoopVectorize/AArch64/predication_costs.ll index b0ebb4edf2ad..858b28ddd321 100644 --- a/llvm/test/Transforms/LoopVectorize/AArch64/predication_costs.ll +++ b/llvm/test/Transforms/LoopVectorize/AArch64/predication_costs.ll @@ -86,6 +86,41 @@ for.end: ret void } +; CHECK-LABEL: predicated_store_phi +; +; Same as predicate_store except we use a pointer PHI to maintain the address +; +; CHECK: Found new scalar instruction: %addr = phi i32* [ %a, %entry ], [ %addr.next, %for.inc ] +; CHECK: Found new scalar instruction: %addr.next = getelementptr inbounds i32, i32* %addr, i64 1 +; CHECK: Scalarizing and predicating: store i32 %tmp2, i32* %addr, align 4 +; CHECK: Found an estimated cost of 0 for VF 2 For instruction: %addr = phi i32* [ %a, %entry ], [ %addr.next, %for.inc ] +; CHECK: Found an estimated cost of 3 for VF 2 For instruction: store i32 %tmp2, i32* %addr, align 4 +; +define void @predicated_store_phi(i32* %a, i1 %c, i32 %x, i64 %n) { +entry: + br label %for.body + +for.body: + %i = phi i64 [ 0, %entry ], [ %i.next, %for.inc ] + %addr = phi i32 * [ %a, %entry ], [ %addr.next, %for.inc ] + %tmp1 = load i32, i32* %addr, align 4 + %tmp2 = add nsw i32 %tmp1, %x + br i1 %c, label %if.then, label %for.inc + +if.then: + store i32 %tmp2, i32* %addr, align 4 + br label %for.inc + +for.inc: + %i.next = add nuw nsw i64 %i, 1 + %cond = icmp slt i64 %i.next, %n + %addr.next = getelementptr inbounds i32, i32* %addr, i64 1 + br i1 %cond, label %for.body, label %for.end + +for.end: + ret void +} + ; CHECK-LABEL: predicated_udiv_scalarized_operand ; ; This test checks that we correctly compute the cost of the predicated udiv diff --git a/llvm/test/Transforms/LoopVectorize/scalarized-bitcast.ll b/llvm/test/Transforms/LoopVectorize/scalarized-bitcast.ll new file mode 100644 index 000000000000..0c97e6ac475e --- /dev/null +++ b/llvm/test/Transforms/LoopVectorize/scalarized-bitcast.ll @@ -0,0 +1,40 @@ +; REQUIRES: asserts +; RUN: opt -loop-vectorize -force-vector-width=2 -debug-only=loop-vectorize -S -o - < %s 2>&1 | FileCheck %s + +%struct.foo = type { i32, i64 } + +; CHECK: LV: Found an estimated cost of 0 for VF 2 For instruction: %0 = bitcast i64* %b to i32* + +; The bitcast below will be scalarized due to the predication in the loop. Bitcasts +; between pointer types should be treated as free, despite the scalarization. +define void @foo(%struct.foo* noalias nocapture %in, i32* noalias nocapture readnone %out, i64 %n) { +entry: + br label %for.body + +for.body: ; preds = %entry, %if.end + %i.012 = phi i64 [ %inc, %if.end ], [ 0, %entry ] + %b = getelementptr inbounds %struct.foo, %struct.foo* %in, i64 %i.012, i32 1 + %0 = bitcast i64* %b to i32* + %a = getelementptr inbounds %struct.foo, %struct.foo* %in, i64 %i.012, i32 0 + %1 = load i32, i32* %a, align 8 + %tobool.not = icmp eq i32 %1, 0 + br i1 %tobool.not, label %if.end, label %land.lhs.true + +land.lhs.true: ; preds = %for.body + %2 = load i32, i32* %0, align 4 + %cmp2 = icmp sgt i32 %2, 0 + br i1 %cmp2, label %if.then, label %if.end + +if.then: ; preds = %land.lhs.true + %sub = add nsw i32 %2, -1 + store i32 %sub, i32* %0, align 4 + br label %if.end + +if.end: ; preds = %if.then, %land.lhs.true, %for.body + %inc = add nuw nsw i64 %i.012, 1 + %exitcond.not = icmp eq i64 %inc, %n + br i1 %exitcond.not, label %for.end, label %for.body + +for.end: ; preds = %if.end + ret void +} </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_gnu/gnu-master-arm-check_bootstrap - Build # 71 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_gnu/gnu-master-arm-check_bootstrap. So far, this commit has regressed CI configurations: - tcwg_gnu/gnu-master-arm-check_bootstrap Culprit: <cut> commit c60d9160b4d966dbea5b1bbea4f817c64d0bee2d Author: Uros Bizjak <ubizjak(a)gmail.com> Date: Tue Jun 29 19:14:35 2021 +0200 i386: Add V2SFmode vec_addsub pattern [PR95046] gcc/ 2021-06-21 Uroš Bizjak <ubizjak(a)gmail.com> PR target/95046 * config/i386/mmx.md (vec_addsubv2sf3): New insn pattern. gcc/testsuite/ 2021-06-21 Uroš Bizjak <ubizjak(a)gmail.com> PR target/95046 * gcc.target/i386/pr95046-9.c: New test. </cut> Results regressed to (for first_bad == c60d9160b4d966dbea5b1bbea4f817c64d0bee2d) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 # # Comparing directories # # REFERENCE: base-artifacts/sumfiles # # CURRENT: /home/tcwg-buildslave/workspace/tcwg_gnu_2/artifacts/build-c60d9160b4d966dbea5b1bbea4f817c64d0bee2d/sumfiles # # # Comparing 12 common sum files: # g++.sum # gcc.sum # gfortran.sum # go.sum # gotools.sum # libatomic.sum # libffi.sum # libgo.sum # libgomp.sum # libitm.sum # libstdc++.sum # objc.sum # Comparing: # REFERENCE:/tmp/gxx-sum1.3448361 # CURRENT: /tmp/gxx-sum2.3448361 # # ` +---------+---------+ # o RUN STATUS: | REF | RES | # +------------------------------------------+---------+---------+ # | Passes [PASS] | 460521 | 460519 | # | Unexpected fails [FAIL] | 195 | 197 | # | Errors [ERROR] | 0 | 0 | # | Unexpected passes [XPASS] | 15 | 15 | # | Expected fails [XFAIL] | 2737 | 2737 | # | Unresolved [UNRESOLVED] | 104 | 104 | # | Unsupported [UNSUPPORTED] | 22896 | 22896 | # | Untested [UNTESTED] | 10 | 10 | # +------------------------------------------+---------+---------+ # # REF PASS ratio: 0.952269 # RES PASS ratio: 0.952265 # # o REGRESSIONS: # +------------------------------------------+---------+ # | PASS now FAIL [PASS => FAIL] | 1 | # | FAIL appears [ => FAIL] | 1 | # +------------------------------------------+---------+ # | TOTAL_REGRESSIONS | 2 | # +------------------------------------------+---------+ # # - PASS now FAIL [PASS => FAIL]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/warn/Wextra-semi.C -std=gnu++14 (test for excess errors) # # # - FAIL appears [ => FAIL]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/warn/Wextra-semi.C -std=gnu++14 expected multiline pattern lines 21-23 not found: " friend void bar \{\};.*\n \^\n -.*\n" # # # # o IMPROVEMENTS TO BE CHECKED: # +------------------------------------------+---------+ # | PASS disappears [PASS => ] | 1 | # +------------------------------------------+---------+ # | TOTAL_IMPROVEMENTS_TO_BE_CHECKED | 1 | # +------------------------------------------+---------+ # # - PASS disappears [PASS => ]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/warn/Wextra-semi.C -std=gnu++14 expected multiline pattern lines 21-23 was found: " friend void bar \{\};.*\n \^\n -.*\n" # # # # # Regressions found # # Regressions in 12 common sum files found from (for last_good == c0f8c22a3e9f8cd45c1cb4be5f83afbebe3bfdc9) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… Build top page/logs: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-c60d9160b4d966dbea5b1bbea4f817c64d0bee2d cd investigate-gcc-c60d9160b4d966dbea5b1bbea4f817c64d0bee2d git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach c60d9160b4d966dbea5b1bbea4f817c64d0bee2d ../artifacts/test.sh # Reproduce last_good build git checkout --detach c0f8c22a3e9f8cd45c1cb4be5f83afbebe3bfdc9 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… Build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/71… Full commit (up to 1000 lines): <cut> commit c60d9160b4d966dbea5b1bbea4f817c64d0bee2d Author: Uros Bizjak <ubizjak(a)gmail.com> Date: Tue Jun 29 19:14:35 2021 +0200 i386: Add V2SFmode vec_addsub pattern [PR95046] gcc/ 2021-06-21 Uroš Bizjak <ubizjak(a)gmail.com> PR target/95046 * config/i386/mmx.md (vec_addsubv2sf3): New insn pattern. gcc/testsuite/ 2021-06-21 Uroš Bizjak <ubizjak(a)gmail.com> PR target/95046 * gcc.target/i386/pr95046-9.c: New test. --- gcc/config/i386/mmx.md | 18 ++++++++++++++++++ gcc/testsuite/gcc.target/i386/pr95046-9.c | 14 ++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index e887f03474d..5f10572718d 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -788,6 +788,24 @@ (set_attr "prefix_extra" "1") (set_attr "mode" "V2SF")]) +(define_insn "vec_addsubv2sf3" + [(set (match_operand:V2SF 0 "register_operand" "=x,x") + (vec_merge:V2SF + (minus:V2SF + (match_operand:V2SF 1 "register_operand" "0,x") + (match_operand:V2SF 2 "register_operand" "x,x")) + (plus:V2SF (match_dup 1) (match_dup 2)) + (const_int 1)))] + "TARGET_SSE3 && TARGET_MMX_WITH_SSE" + "@ + addsubps\t{%2, %0|%0, %2} + vaddsubps\t{%2, %1, %0|%0, %1, %2}" + [(set_attr "isa" "noavx,avx") + (set_attr "type" "sseadd") + (set_attr "prefix" "orig,vex") + (set_attr "prefix_rep" "1,*") + (set_attr "mode" "V4SF")]) + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; ;; Parallel single-precision floating point comparisons diff --git a/gcc/testsuite/gcc.target/i386/pr95046-9.c b/gcc/testsuite/gcc.target/i386/pr95046-9.c new file mode 100644 index 00000000000..54e948ccfb0 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr95046-9.c @@ -0,0 +1,14 @@ +/* PR target/95046 */ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-O3 -msse3" } */ + +float r[2], a[2], b[2]; + +void +test (void) +{ + r[0] = a[0] - b[0]; + r[1] = a[1] + b[1]; +} + +/* { dg-final { scan-assembler "\tv?addsubps" } } */ </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O2_LTO - Build # 19 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO Culprit: <cut> commit 8208be389bce84be0e1c35a3daa0c3467418f921 Author: Florian Weimer <fweimer(a)redhat.com> Date: Mon Jun 28 08:33:57 2021 +0200 Install shared objects under their ABI names Previously, the installed objects were named like libc-2.33.so, and the ABI soname libc.so.6 was just a symbolic link. The Makefile targets to install these symbolic links are no longer needed after this, so they are removed with this commit. The more general $(make-link) command (which invokes scripts/rellns-sh) is retained because other symbolic links are still needed. Reviewed-by: Carlos O'Donell <carlos(a)redhat.com> Tested-by: Carlos O'Donell <carlos(a)rehdat.com> </cut> Results regressed to (for first_bad == 8208be389bce84be0e1c35a3daa0c3467418f921) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-8208be389bce84be0e1c35a3daa0c3467418f921/results_id: 1 # 434.zeusmp,zeusmp_base.default regressed by 7549591 # 435.gromacs,gromacs_base.default regressed by 10863956 # 447.dealII,dealII_base.default regressed by 12999253 # 454.calculix,calculix_base.default regressed by 3929138 # 465.tonto,tonto_base.default regressed by 12056000 # 459.GemsFDTD,GemsFDTD_base.default regressed by 7978538 # 410.bwaves,bwaves_base.default regressed by 8373106 # 416.gamess,gamess_base.default regressed by 4372732 # 481.wrf,wrf_base.default regressed by 8973237 # 436.cactusADM,cactusADM_base.default regressed by 4181826 # 437.leslie3d,leslie3d_base.default regressed by 7255644 from (for last_good == 6bf789d69e6be48419094ca98f064e00297a27d5) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-6bf789d69e6be48419094ca98f064e00297a27d5/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/976 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/988 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-8208be389bce84be0e1c35a3daa0c3467418f921 cd investigate-glibc-8208be389bce84be0e1c35a3daa0c3467418f921 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach 8208be389bce84be0e1c35a3daa0c3467418f921 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 6bf789d69e6be48419094ca98f064e00297a27d5 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit 8208be389bce84be0e1c35a3daa0c3467418f921 Author: Florian Weimer <fweimer(a)redhat.com> Date: Mon Jun 28 08:33:57 2021 +0200 Install shared objects under their ABI names Previously, the installed objects were named like libc-2.33.so, and the ABI soname libc.so.6 was just a symbolic link. The Makefile targets to install these symbolic links are no longer needed after this, so they are removed with this commit. The more general $(make-link) command (which invokes scripts/rellns-sh) is retained because other symbolic links are still needed. Reviewed-by: Carlos O'Donell <carlos(a)redhat.com> Tested-by: Carlos O'Donell <carlos(a)rehdat.com> --- Makefile | 6 ------ Makerules | 45 +++++---------------------------------------- NEWS | 8 ++++++++ elf/Makefile | 10 ++-------- 4 files changed, 15 insertions(+), 54 deletions(-) diff --git a/Makefile b/Makefile index 0157b53cb8..f98d5a9e67 100644 --- a/Makefile +++ b/Makefile @@ -109,12 +109,6 @@ elf/ldso_install: # Ignore the error if we cannot update /etc/ld.so.cache. ifeq (no,$(cross-compiling)) ifeq (yes,$(build-shared)) -install: install-symbolic-link -.PHONY: install-symbolic-link -install-symbolic-link: subdir_install - $(symbolic-link-prog) $(symbolic-link-list) - rm -f $(symbolic-link-list) - install: -test ! -x $(elf-objpfx)ldconfig || LC_ALL=C \ $(elf-objpfx)ldconfig $(addprefix -r ,$(install_root)) \ diff --git a/Makerules b/Makerules index f2587907fb..596fa68376 100644 --- a/Makerules +++ b/Makerules @@ -990,14 +990,12 @@ versioned := $(strip $(foreach so,$(install-lib.so),\ install-lib.so-versioned := $(filter $(versioned), $(install-lib.so)) install-lib.so-unversioned := $(filter-out $(versioned), $(install-lib.so)) -# For libraries whose soname have version numbers, we install three files: +# For libraries whose soname have version numbers, we install two files: # $(inst_libdir)/libfoo.so -- for linking, symlink or ld script -# $(inst_slibdir)/libfoo.so.NN -- for loading by SONAME, symlink -# $(inst_slibdir)/libfoo-X.Y.Z.so -- the real shared object file +# $(inst_slibdir)/libfoo.so.NN -- for loading by SONAME install-lib-nosubdir: $(install-lib.so-unversioned:%=$(inst_slibdir)/%) \ $(foreach L,$(install-lib.so-versioned),\ $(inst_libdir)/$L \ - $(inst_slibdir)/$(L:.so=)-$(version).so \ $(inst_slibdir)/$L$($L-version)) # Install all the unversioned shared libraries. @@ -1030,35 +1028,10 @@ ln -f $(objpfx)/$(@F) $@ endef endif -ifeq (yes,$(build-shared)) -ifeq (no,$(cross-compiling)) -symbolic-link-prog := $(elf-objpfx)sln -symbolic-link-list := $(elf-objpfx)symlink.list -define make-shlib-link -echo `$(..)scripts/rellns-sh -p $< $@` $@ >> $(symbolic-link-list) -endef -else # cross-compiling -# We need a definition that can be used by elf/Makefile's install rules. -symbolic-link-prog = $(LN_S) -endif -endif -ifndef make-shlib-link -define make-shlib-link -rm -f $@ -$(LN_S) `$(..)scripts/rellns-sh -p $< $@` $@ -endef -endif - ifdef libc.so-version -# For a library specified to be version N, install three files: -# libc.so -> libc.so.N (e.g. libc.so.6) -# libc.so.6 -> libc-VERSION.so (e.g. libc-1.10.so) - -$(inst_slibdir)/libc.so$(libc.so-version): $(inst_slibdir)/libc-$(version).so \ - $(+force) - $(make-shlib-link) -$(inst_slibdir)/libc-$(version).so: $(common-objpfx)libc.so $(+force) +$(inst_slibdir)/libc.so$(libc.so-version): $(common-objpfx)libc.so $(+force) $(do-install-program) + install: $(inst_slibdir)/libc.so$(libc.so-version) # This fragment of linker script gives the OUTPUT_FORMAT statement @@ -1126,15 +1099,7 @@ include $(o-iterator) generated += $(foreach o,$(versioned),$o$($o-version)) define o-iterator-doit -$(inst_slibdir)/$o$($o-version): $(inst_slibdir)/$(o:.so=)-$(version).so \ - $(+force); - $$(make-shlib-link) -endef -object-suffixes-left := $(versioned) -include $(o-iterator) - -define o-iterator-doit -$(inst_slibdir)/$(o:.so=)-$(version).so: $(objpfx)$o $(+force); +$(inst_slibdir)/$o$($o-version): $(objpfx)$o $(+force); $$(do-install-program) endef object-suffixes-left := $(versioned) diff --git a/NEWS b/NEWS index b24ebf9898..37ba4334c6 100644 --- a/NEWS +++ b/NEWS @@ -74,6 +74,14 @@ Deprecated and removed features, and other changes affecting compatibility: buggy kernel interfaces (for instance some CIFS version) that could still see spurious EINTR error when cancellation interrupts a blocking syscall. +* Previously, glibc installed its various shared objects under versioned + file names such as libc-2.33.so. The ABI sonames (e.g., libc.so.6) + were provided as symbolic links. Starting with glibc 2.34, the shared + objects are installed under their ABI sonames directly, without + symbolic links. This increases compatibility with distribution + package managers that delete removed files late during the package + upgrade or downgrade process. + Changes to build and runtime requirements: * On Linux, the shm_open, sem_open, and related functions now expect the diff --git a/elf/Makefile b/elf/Makefile index 62f7e8a225..cdbcc14087 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -630,20 +630,14 @@ $(objpfx)trusted-dirs.st: Makefile $(..)Makeconfig CPPFLAGS-dl-load.c += -I$(objpfx). -I$(csu-objpfx). ifeq (yes,$(build-shared)) -$(inst_slibdir)/$(rtld-version-installed-name): $(objpfx)ld.so $(+force) +$(inst_rtlddir)/$(rtld-installed-name): $(objpfx)ld.so $(+force) $(make-target-directory) $(do-install-program) -$(inst_rtlddir)/$(rtld-installed-name): \ - $(inst_slibdir)/$(rtld-version-installed-name) \ - $(inst_slibdir)/libc-$(version).so - $(make-target-directory) - $(make-shlib-link) - # Special target called by parent to install just the dynamic linker. .PHONY: ldso_install ldso_install: $(inst_rtlddir)/$(rtld-installed-name) -endif +endif # $(build-shared) # Workarounds for ${exec_prefix} expansion in configure variables. </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-release-aarch64-spec2k6-Os - Build # 5 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-Os. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-Os Culprit: <cut> commit f96fef89b5eca29f2dc41e97829c20bf742cdcd9 Author: Fangrui Song <i(a)maskray.me> Date: Tue Nov 24 09:51:32 2020 -0800 [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables In GCC, `aarch64-*-linux` and `aarch64-*-freebsd` made the switch in 2018 (https://gcc.gnu.org/pipermail/gcc-patches/2018-March/495549.html). In Clang, FreeBSD/Fuchsia/NetBSD/MinGW aarch64 default to -fasynchronous-unwind-tables. This patch defaults Generic_GCC aarch64 (which affects Linux) to use -fasynchronous-unwind-tables. Reviewed By: nickdesaulniers Differential Revision: https://reviews.llvm.org/D91760 </cut> Results regressed to (for first_bad == f96fef89b5eca29f2dc41e97829c20bf742cdcd9) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os -- artifacts/build-f96fef89b5eca29f2dc41e97829c20bf742cdcd9/results_id: 1 # 433.milc,milc_base.default regressed by 112 # 445.gobmk,gobmk_base.default regressed by 108 # 447.dealII,dealII_base.default regressed by 102 # 400.perlbench,perlbench_base.default regressed by 109 # 401.bzip2,bzip2_base.default regressed by 107 # 403.gcc,gcc_base.default regressed by 107 # 429.mcf,mcf_base.default regressed by 110 # 450.soplex,soplex_base.default regressed by 103 # 453.povray,povray_base.default regressed by 102 # 456.hmmer,hmmer_base.default regressed by 110 # 458.sjeng,sjeng_base.default regressed by 105 # 462.libquantum,libquantum_base.default regressed by 113 # 464.h264ref,h264ref_base.default regressed by 105 # 470.lbm,lbm_base.default regressed by 108 # 471.omnetpp,omnetpp_base.default regressed by 104 # 473.astar,astar_base.default regressed by 105 # 482.sphinx3,sphinx_livepretend_base.default regressed by 110 from (for last_good == 4926eed59c77bb452539d88a0a8ba3f3c21c4016) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os -- artifacts/build-4926eed59c77bb452539d88a0a8ba3f3c21c4016/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-Os/934 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-Os/963 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-f96fef89b5eca29f2dc41e97829c20bf742cdcd9 cd investigate-llvm-f96fef89b5eca29f2dc41e97829c20bf742cdcd9 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach f96fef89b5eca29f2dc41e97829c20bf742cdcd9 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 4926eed59c77bb452539d88a0a8ba3f3c21c4016 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Full commit (up to 1000 lines): <cut> commit f96fef89b5eca29f2dc41e97829c20bf742cdcd9 Author: Fangrui Song <i(a)maskray.me> Date: Tue Nov 24 09:51:32 2020 -0800 [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables In GCC, `aarch64-*-linux` and `aarch64-*-freebsd` made the switch in 2018 (https://gcc.gnu.org/pipermail/gcc-patches/2018-March/495549.html). In Clang, FreeBSD/Fuchsia/NetBSD/MinGW aarch64 default to -fasynchronous-unwind-tables. This patch defaults Generic_GCC aarch64 (which affects Linux) to use -fasynchronous-unwind-tables. Reviewed By: nickdesaulniers Differential Revision: https://reviews.llvm.org/D91760 --- clang/lib/Driver/ToolChains/Gnu.cpp | 8 +++++++- clang/test/Driver/aarch64-features.c | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp index 7d75e90c6092..08158ba4bae8 100644 --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -2672,7 +2672,13 @@ void Generic_GCC::printVerboseInfo(raw_ostream &OS) const { } bool Generic_GCC::IsUnwindTablesDefault(const ArgList &Args) const { - return getArch() == llvm::Triple::x86_64; + switch (getArch()) { + case llvm::Triple::aarch64: + case llvm::Triple::x86_64: + return true; + default: + return false; + } } bool Generic_GCC::isPICDefault() const { diff --git a/clang/test/Driver/aarch64-features.c b/clang/test/Driver/aarch64-features.c index 7c3f8754049a..8d8cc3c68afe 100644 --- a/clang/test/Driver/aarch64-features.c +++ b/clang/test/Driver/aarch64-features.c @@ -1,6 +1,8 @@ // RUN: %clang -target aarch64-none-linux-gnu -### %s -fsyntax-only 2>&1 | FileCheck %s // RUN: %clang -target arm64-none-linux-gnu -### %s -fsyntax-only 2>&1 | FileCheck %s +// CHECK: "-munwind-tables" + // The AArch64 PCS states that chars should be unsigned. // CHECK: fno-signed-char </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-release-arm-spec2k6-Os - Build # 16 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Os. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Os Culprit: <cut> commit b6bf4d8a773cde07e751542f2911307d78b717fd Author: Andreas Tobler <andreast(a)gcc.gnu.org> Date: Thu Apr 25 22:03:35 2019 +0200 freebsd64.h: Add bits for 32-bit multilib support. 2019-04-25 Andreas Tobler <andreast(a)gcc.gnu.org> * config/i386/freebsd64.h: Add bits for 32-bit multilib support. * config/i386/t-freebsd64: New file. * config.gcc: Add the t-freebsd64 for multilib support. From-SVN: r270586 </cut> Results regressed to (for first_bad == b6bf4d8a773cde07e751542f2911307d78b717fd) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os_mthumb -- artifacts/build-b6bf4d8a773cde07e751542f2911307d78b717fd/results_id: 1 # 429.mcf,mcf_base.default regressed by 104 # 470.lbm,lbm_base.default regressed by 103 from (for last_good == 8a55f9c57a1ffd900262aa2fc2015822dc059331) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os_mthumb -- artifacts/build-baseline/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/baseline-llvm-release-arm-spec2k6-Os/824 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-release-arm-spec2k6-Os/929 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-b6bf4d8a773cde07e751542f2911307d78b717fd cd investigate-gcc-b6bf4d8a773cde07e751542f2911307d78b717fd git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach b6bf4d8a773cde07e751542f2911307d78b717fd ../artifacts/test.sh # Reproduce last_good build git checkout --detach 8a55f9c57a1ffd900262aa2fc2015822dc059331 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Full commit (up to 1000 lines): <cut> commit b6bf4d8a773cde07e751542f2911307d78b717fd Author: Andreas Tobler <andreast(a)gcc.gnu.org> Date: Thu Apr 25 22:03:35 2019 +0200 freebsd64.h: Add bits for 32-bit multilib support. 2019-04-25 Andreas Tobler <andreast(a)gcc.gnu.org> * config/i386/freebsd64.h: Add bits for 32-bit multilib support. * config/i386/t-freebsd64: New file. * config.gcc: Add the t-freebsd64 for multilib support. From-SVN: r270586 --- gcc/ChangeLog | 6 ++++++ gcc/config.gcc | 5 ++++- gcc/config/i386/freebsd64.h | 5 ++++- gcc/config/i386/t-freebsd64 | 30 ++++++++++++++++++++++++++++++ 4 files changed, 44 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7cd02c850d3..3a927ed00d3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2019-04-25 Andreas Tobler <andreast(a)gcc.gnu.org> + + * config/i386/freebsd64.h: Add bits for 32-bit multilib support. + * config/i386/t-freebsd64: New file. + * config.gcc: Add the t-freebsd64 for multilib support. + 2019-04-25 Uroš Bizjak <ubizjak(a)gmail.com> * doc/extend.texi (vector_size): Add missing comma after @xref. diff --git a/gcc/config.gcc b/gcc/config.gcc index 09fb9ecd2cd..c7a464c89d0 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -4927,7 +4927,10 @@ case ${target} in ;; i[34567]86-*-dragonfly* | x86_64-*-dragonfly*) ;; - i[34567]86-*-freebsd* | x86_64-*-freebsd*) + i[34567]86-*-freebsd*) + ;; + x86_64-*-freebsd*) + tmake_file="${tmake_file} i386/t-freebsd64" ;; ia64*-*-linux*) ;; diff --git a/gcc/config/i386/freebsd64.h b/gcc/config/i386/freebsd64.h index 1f99e812f01..bffe19c14ff 100644 --- a/gcc/config/i386/freebsd64.h +++ b/gcc/config/i386/freebsd64.h @@ -31,7 +31,7 @@ along with GCC; see the file COPYING3. If not see #undef LINK_SPEC #define LINK_SPEC "\ - %{m32:-m elf_i386_fbsd} \ + %{m32:-m elf_i386_fbsd}%{!m32:-m elf_x86_64_fbsd} \ %{p:%nconsider using '-pg' instead of '-p' with gprof(1)} \ %{v:-V} \ %{assert*} %{R*} %{rpath*} %{defsym*} \ @@ -42,3 +42,6 @@ along with GCC; see the file COPYING3. If not see -dynamic-linker %(fbsd_dynamic_linker) } \ %{static:-Bstatic}} \ %{symbolic:-Bsymbolic}" + +#undef MULTILIB_DEFAULTS +#define MULTILIB_DEFAULTS { "m64" } diff --git a/gcc/config/i386/t-freebsd64 b/gcc/config/i386/t-freebsd64 new file mode 100644 index 00000000000..0dd05d479ac --- /dev/null +++ b/gcc/config/i386/t-freebsd64 @@ -0,0 +1,30 @@ +# Copyright (C) 2019 Free Software Foundation, Inc. +# +# This file is part of GCC. +# +# GCC is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3, or (at your option) +# any later version. +# +# GCC is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with GCC; see the file COPYING3. If not see +# <http://www.gnu.org/licenses/>. + +# The 32-bit libraries are found in /usr/lib32 + +# To support i386 and x86-64, the directory structrue +# should be: +# +# /lib has x86-64 libraries. +# /lib32 has i386 libraries. +# + +MULTILIB_OPTIONS = m32 +MULTILIB_DIRNAMES = 32 +MULTILIB_OSDIRNAMES = ../lib32 </cut>

3 years, 12 months

1
0
0 0

toolchain+qemu regression testing

by Richard Henderson

Hey, Maxim, You recently mentioned we have such a setup working, yes? Is there an easy way to point the qemu portion to a custom branch? I'm currently working on adding vdso support to qemu, and want to make sure that the unwind info that I've written works correctly with libgcc and llvm's libunwind. Also, what arm CPU models are being used? My edge cases are v4, v4t, m0 (which is not really linux-user, but I think Christophe Lyon had made work). r~

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-release-aarch64-spec2k6-O3 - Build # 3 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-O3 Culprit: <cut> commit 445db89b537e5397a2d4b08e79751edb845b2c2a Author: Nikita Popov <nikita.ppv(a)gmail.com> Date: Sun Sep 20 21:07:52 2020 +0200 [LVI] Get value range from mask comparison InstCombine likes to canonicalize comparisons of the form X == C || X == C+1 into (X & -2) == C'. Make sure LVI can still recover the value range from this. Can of course also be useful for proper mask comparisons. For the sake of clarity, the implementation goes through KnownBits to compute the range. </cut> Results regressed to (for first_bad == 445db89b537e5397a2d4b08e79751edb845b2c2a) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O3 -- artifacts/build-445db89b537e5397a2d4b08e79751edb845b2c2a/results_id: 1 # 400.perlbench,perlbench_base.default regressed by 103 from (for last_good == 91af6a78d00f731826ff2eb81c9a9281b1d21388) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O3 -- artifacts/build-91af6a78d00f731826ff2eb81c9a9281b1d21388/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O3/880 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-O3/890 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-445db89b537e5397a2d4b08e79751edb845b2c2a cd investigate-llvm-445db89b537e5397a2d4b08e79751edb845b2c2a git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 445db89b537e5397a2d4b08e79751edb845b2c2a ../artifacts/test.sh # Reproduce last_good build git checkout --detach 91af6a78d00f731826ff2eb81c9a9281b1d21388 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Full commit (up to 1000 lines): <cut> commit 445db89b537e5397a2d4b08e79751edb845b2c2a Author: Nikita Popov <nikita.ppv(a)gmail.com> Date: Sun Sep 20 21:07:52 2020 +0200 [LVI] Get value range from mask comparison InstCombine likes to canonicalize comparisons of the form X == C || X == C+1 into (X & -2) == C'. Make sure LVI can still recover the value range from this. Can of course also be useful for proper mask comparisons. For the sake of clarity, the implementation goes through KnownBits to compute the range. --- llvm/lib/Analysis/LazyValueInfo.cpp | 14 ++++++++++++++ .../test/Transforms/CorrelatedValuePropagation/icmp.ll | 18 ++++++------------ 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/llvm/lib/Analysis/LazyValueInfo.cpp b/llvm/lib/Analysis/LazyValueInfo.cpp index 4e9505a12cb8..cc364fc93337 100644 --- a/llvm/lib/Analysis/LazyValueInfo.cpp +++ b/llvm/lib/Analysis/LazyValueInfo.cpp @@ -36,6 +36,7 @@ #include "llvm/InitializePasses.h" #include "llvm/Support/Debug.h" #include "llvm/Support/FormattedStream.h" +#include "llvm/Support/KnownBits.h" #include "llvm/Support/raw_ostream.h" #include <map> using namespace llvm; @@ -1145,6 +1146,19 @@ static ValueLatticeElement getValueFromICmpCondition(Value *Val, ICmpInst *ICI, if (matchICmpOperand(Offset, RHS, Val, SwappedPred)) return getValueFromSimpleICmpCondition(SwappedPred, LHS, Offset); + // If (Val & Mask) == C then all the masked bits are known and we can compute + // a value range based on that. + const APInt *Mask, *C; + if (EdgePred == ICmpInst::ICMP_EQ && + match(LHS, m_And(m_Specific(Val), m_APInt(Mask))) && + match(RHS, m_APInt(C))) { + KnownBits Known; + Known.Zero = ~*C & *Mask; + Known.One = *C & *Mask; + return ValueLatticeElement::getRange( + ConstantRange::fromKnownBits(Known, /*IsSigned*/ false)); + } + return ValueLatticeElement::getOverdefined(); } diff --git a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll index 76d8e0d00f70..cdc5140b6548 100644 --- a/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll +++ b/llvm/test/Transforms/CorrelatedValuePropagation/icmp.ll @@ -995,14 +995,10 @@ define void @test_icmp_mask_two_values(i32 %a) { ; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], 10 ; CHECK-NEXT: br i1 [[CMP]], label [[IF_TRUE:%.*]], label [[IF_FALSE:%.*]] ; CHECK: if.true: -; CHECK-NEXT: [[CMP2:%.*]] = icmp uge i32 [[A]], 10 -; CHECK-NEXT: call void @check1(i1 [[CMP2]]) -; CHECK-NEXT: [[CMP3:%.*]] = icmp ule i32 [[A]], 11 -; CHECK-NEXT: call void @check1(i1 [[CMP3]]) -; CHECK-NEXT: [[CMP4:%.*]] = icmp ult i32 [[A]], 10 -; CHECK-NEXT: call void @check1(i1 [[CMP4]]) -; CHECK-NEXT: [[CMP5:%.*]] = icmp ugt i32 [[A]], 11 -; CHECK-NEXT: call void @check1(i1 [[CMP5]]) +; CHECK-NEXT: call void @check1(i1 true) +; CHECK-NEXT: call void @check1(i1 true) +; CHECK-NEXT: call void @check1(i1 false) +; CHECK-NEXT: call void @check1(i1 false) ; CHECK-NEXT: ret void ; CHECK: if.false: ; CHECK-NEXT: ret void @@ -1032,8 +1028,7 @@ define void @test_icmp_mask_bit_set(i32 %a) { ; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], 32 ; CHECK-NEXT: br i1 [[CMP]], label [[IF_TRUE:%.*]], label [[IF_FALSE:%.*]] ; CHECK: if.true: -; CHECK-NEXT: [[CMP2:%.*]] = icmp uge i32 [[A]], 32 -; CHECK-NEXT: call void @check1(i1 [[CMP2]]) +; CHECK-NEXT: call void @check1(i1 true) ; CHECK-NEXT: [[CMP3:%.*]] = icmp uge i32 [[A]], 33 ; CHECK-NEXT: call void @check1(i1 [[CMP3]]) ; CHECK-NEXT: ret void @@ -1061,8 +1056,7 @@ define void @test_icmp_mask_bit_unset(i32 %a) { ; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], 0 ; CHECK-NEXT: br i1 [[CMP]], label [[IF_TRUE:%.*]], label [[IF_FALSE:%.*]] ; CHECK: if.true: -; CHECK-NEXT: [[CMP2:%.*]] = icmp ule i32 [[A]], -33 -; CHECK-NEXT: call void @check1(i1 [[CMP2]]) +; CHECK-NEXT: call void @check1(i1 true) ; CHECK-NEXT: [[CMP3:%.*]] = icmp ule i32 [[A]], -34 ; CHECK-NEXT: call void @check1(i1 [[CMP3]]) ; CHECK-NEXT: ret void </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_gnu/gnu-master-arm-check_bootstrap - Build # 68 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_gnu/gnu-master-arm-check_bootstrap. So far, this commit has regressed CI configurations: - tcwg_gnu/gnu-master-arm-check_bootstrap Culprit: <cut> commit 095a01cf6e3883b3083cf339b680cdb39910f529 Author: David Edelsohn <dje.gcc(a)gmail.com> Date: Mon Jun 28 22:54:42 2021 -0400 bootstrap: Include tm_p.h in btfout.c and ctfout.c. btfout.c and ctfout.c reference target-specific macros that may reference target-specific functions that are declared in a target-specific header. tm_p.h must be included to provide the target-specific header. gcc/ChangeLog: * btfout.c: Include tm_p.h. * ctfout.c: Same. </cut> Results regressed to (for first_bad == 095a01cf6e3883b3083cf339b680cdb39910f529) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 # # Comparing directories # # REFERENCE: base-artifacts/sumfiles # # CURRENT: /home/tcwg-buildslave/workspace/tcwg_gnu_3/artifacts/build-095a01cf6e3883b3083cf339b680cdb39910f529/sumfiles # # # Comparing 12 common sum files: # g++.sum # gcc.sum # gfortran.sum # go.sum # gotools.sum # libatomic.sum # libffi.sum # libgo.sum # libgomp.sum # libitm.sum # libstdc++.sum # objc.sum # Comparing: # REFERENCE:/tmp/gxx-sum1.2252296 # CURRENT: /tmp/gxx-sum2.2252296 # # ` +---------+---------+ # o RUN STATUS: | REF | RES | # +------------------------------------------+---------+---------+ # | Passes [PASS] | 460490 | 460509 | # | Unexpected fails [FAIL] | 192 | 193 | # | Errors [ERROR] | 0 | 0 | # | Unexpected passes [XPASS] | 15 | 15 | # | Expected fails [XFAIL] | 2737 | 2737 | # | Unresolved [UNRESOLVED] | 104 | 104 | # | Unsupported [UNSUPPORTED] | 22896 | 22896 | # | Untested [UNTESTED] | 10 | 10 | # +------------------------------------------+---------+---------+ # # REF PASS ratio: 0.952272 # RES PASS ratio: 0.952272 # # o REGRESSIONS: # +------------------------------------------+---------+ # | PASS now FAIL [PASS => FAIL] | 1 | # +------------------------------------------+---------+ # | TOTAL_REGRESSIONS | 1 | # +------------------------------------------+---------+ # # - PASS now FAIL [PASS => FAIL]: # # Executed from: go.test/go-test.exp # go:go.test/test/fixedbugs/issue13160.go execution, -O2 -g # # # # o IMPROVEMENTS TO BE CHECKED: # +------------------------------------------+---------+ # | New PASS [ => PASS] | 20 | # +------------------------------------------+---------+ # | TOTAL_IMPROVEMENTS_TO_BE_CHECKED | 20 | # +------------------------------------------+---------+ # # - New PASS [ => PASS]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/uninit-pr74762.C -std=gnu++14 (test for warnings, line 23) # g++:g++.dg/uninit-pr74762.C -std=gnu++14 (test for excess errors) # g++:g++.dg/uninit-pr74762.C -std=gnu++17 (test for warnings, line 23) # g++:g++.dg/uninit-pr74762.C -std=gnu++17 (test for excess errors) # g++:g++.dg/uninit-pr74762.C -std=gnu++2a (test for warnings, line 23) # g++:g++.dg/uninit-pr74762.C -std=gnu++2a (test for excess errors) # g++:g++.dg/uninit-pr74762.C -std=gnu++98 (test for warnings, line 23) # g++:g++.dg/uninit-pr74762.C -std=gnu++98 (test for excess errors) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++14 (test for warnings, line 10) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++14 (test for warnings, line 20) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++14 (test for excess errors) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++17 (test for warnings, line 10) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++17 (test for warnings, line 20) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++17 (test for excess errors) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++2a (test for warnings, line 10) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++2a (test for warnings, line 20) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++2a (test for excess errors) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++98 (test for warnings, line 10) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++98 (test for warnings, line 20) # g++:g++.dg/warn/uninit-pr74765.C -std=gnu++98 (test for excess errors) # # # # # Regressions found # # Regressions in 12 common sum files found from (for last_good == c8abc2058e96dd12454078d66be9982dfebfd154) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… Build top page/logs: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-095a01cf6e3883b3083cf339b680cdb39910f529 cd investigate-gcc-095a01cf6e3883b3083cf339b680cdb39910f529 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 095a01cf6e3883b3083cf339b680cdb39910f529 ../artifacts/test.sh # Reproduce last_good build git checkout --detach c8abc2058e96dd12454078d66be9982dfebfd154 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… Build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/68… Full commit (up to 1000 lines): <cut> commit 095a01cf6e3883b3083cf339b680cdb39910f529 Author: David Edelsohn <dje.gcc(a)gmail.com> Date: Mon Jun 28 22:54:42 2021 -0400 bootstrap: Include tm_p.h in btfout.c and ctfout.c. btfout.c and ctfout.c reference target-specific macros that may reference target-specific functions that are declared in a target-specific header. tm_p.h must be included to provide the target-specific header. gcc/ChangeLog: * btfout.c: Include tm_p.h. * ctfout.c: Same. --- gcc/btfout.c | 1 + gcc/ctfout.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/btfout.c b/gcc/btfout.c index 45954b4b7b9..2316dea5f27 100644 --- a/gcc/btfout.c +++ b/gcc/btfout.c @@ -26,6 +26,7 @@ along with GCC; see the file COPYING3. If not see #include "system.h" #include "coretypes.h" #include "target.h" +#include "tm_p.h" #include "output.h" #include "dwarf2asm.h" #include "debug.h" diff --git a/gcc/ctfout.c b/gcc/ctfout.c index c264fd6661a..71d7a62e6ef 100644 --- a/gcc/ctfout.c +++ b/gcc/ctfout.c @@ -21,6 +21,7 @@ along with GCC; see the file COPYING3. If not see #include "system.h" #include "coretypes.h" #include "target.h" +#include "tm_p.h" #include "output.h" #include "dwarf2asm.h" #include "debug.h" </cut>

3 years, 12 months

2
1
0 0

[ACTIVITY] report week ending 2 Jul

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Code review: - RTH's latest bswap series - RTH's series converting nios2 to TranslatorOps - Alex's SYS_HEAPINFO series - RTH's series to avoid linux-user putting signal trampoline code on the stack - Renesas SCI device refactoring + Working on making the docs report the license, version, etc in each page's footer (something I was asked for back when I did the initial conversion to Sphinx and which I promised I would do afterwards...) + Investigated a bug reported by Maxim Uvarov where the virt board's GPIO-driven shutdown/reset mechanism for secure firmware wasn't working correctly. This turns out to be caused by our PL061 GPIO implementation hardcoding that GPIO lines have pullup resistors, whereas the virt board and the gpio-pwr device implicitly assume pulldown. That bug was then masked/confused by a second bug, where we only actually signal the line level implied by the pullup when the guest first touches the PL061, rather than on reset. Sent a series that fixes both of these things (and does a bit of other PL061 cleanup in the process). * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Implemented all the non-vector shift insns + Sent out a second slice of patches for review + Progress: 112/210 (53%) -- PMM

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_gnu/gnu-master-arm-check_bootstrap - Build # 67 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_gnu/gnu-master-arm-check_bootstrap. So far, this commit has regressed CI configurations: - tcwg_gnu/gnu-master-arm-check_bootstrap Culprit: <cut> commit c1f76af469388d3df815c82de566387da5ae000f Author: Indu Bhagat <indu.bhagat(a)oracle.com> Date: Thu May 20 11:19:04 2021 -0700 CTF/BTF testsuites This commit adds a new testsuite for the CTF debug format. 2021-06-28 Indu Bhagat <indu.bhagat(a)oracle.com> David Faust <david.faust(a)oracle.com> gcc/testsuite/ * lib/gcc-dg.exp (gcc-dg-frontend-supports-ctf): New procedure. (gcc-dg-debug-runtest): Add -gctf support. * gcc.dg/debug/btf/btf-1.c: New test. * gcc.dg/debug/btf/btf-2.c: Likewise. * gcc.dg/debug/btf/btf-anonymous-struct-1.c: Likewise. * gcc.dg/debug/btf/btf-anonymous-union-1.c: Likewise. * gcc.dg/debug/btf/btf-array-1.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-1.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-2.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-3.c: Likewise. * gcc.dg/debug/btf/btf-cvr-quals-1.c: Likewise. * gcc.dg/debug/btf/btf-enum-1.c: Likewise. * gcc.dg/debug/btf/btf-forward-1.c: Likewise. * gcc.dg/debug/btf/btf-function-1.c: Likewise. * gcc.dg/debug/btf/btf-function-2.c: Likewise. * gcc.dg/debug/btf/btf-int-1.c: Likewise. * gcc.dg/debug/btf/btf-pointers-1.c: Likewise. * gcc.dg/debug/btf/btf-struct-1.c: Likewise. * gcc.dg/debug/btf/btf-typedef-1.c: Likewise. * gcc.dg/debug/btf/btf-union-1.c: Likewise. * gcc.dg/debug/btf/btf-variables-1.c: Likewise. * gcc.dg/debug/btf/btf.exp: Likewise. * gcc.dg/debug/ctf/ctf-1.c: Likewise. * gcc.dg/debug/ctf/ctf-2.c: Likewise. * gcc.dg/debug/ctf/ctf-anonymous-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-anonymous-union-1.c: Likewise. * gcc.dg/debug/ctf/ctf-array-1.c: Likewise. * gcc.dg/debug/ctf/ctf-array-2.c: Likewise. * gcc.dg/debug/ctf/ctf-array-3.c: Likewise. * gcc.dg/debug/ctf/ctf-array-4.c: Likewise. * gcc.dg/debug/ctf/ctf-attr-mode-1.c: Likewise. * gcc.dg/debug/ctf/ctf-attr-used-1.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-1.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-2.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-3.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-4.c: Likewise. * gcc.dg/debug/ctf/ctf-complex-1.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-1.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-2.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-3.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-4.c: Likewise. * gcc.dg/debug/ctf/ctf-enum-1.c: Likewise. * gcc.dg/debug/ctf/ctf-enum-2.c: Likewise. * gcc.dg/debug/ctf/ctf-file-scope-1.c: Likewise. * gcc.dg/debug/ctf/ctf-float-1.c: Likewise. * gcc.dg/debug/ctf/ctf-forward-1.c: Likewise. * gcc.dg/debug/ctf/ctf-forward-2.c: Likewise. * gcc.dg/debug/ctf/ctf-func-index-1.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-1.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-2.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-3.c: Likewise. * gcc.dg/debug/ctf/ctf-functions-1.c: Likewise. * gcc.dg/debug/ctf/ctf-int-1.c: Likewise. * gcc.dg/debug/ctf/ctf-objt-index-1.c: Likewise. * gcc.dg/debug/ctf/ctf-pointers-1.c: Likewise. * gcc.dg/debug/ctf/ctf-pointers-2.c: Likewise. * gcc.dg/debug/ctf/ctf-preamble-1.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-1.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-2.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-3.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-4.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-5.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-6.c: Likewise. * gcc.dg/debug/ctf/ctf-str-table-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-2.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-array-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-pointer-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-pointer-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-1.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-3.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-3.c: Likewise. * gcc.dg/debug/ctf/ctf-union-1.c: Likewise. * gcc.dg/debug/ctf/ctf-variables-1.c: Likewise. * gcc.dg/debug/ctf/ctf-variables-2.c: Likewise. * gcc.dg/debug/ctf/ctf.exp: Likewise. </cut> Results regressed to (for first_bad == c1f76af469388d3df815c82de566387da5ae000f) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 # # Comparing directories # # REFERENCE: base-artifacts/sumfiles # # CURRENT: /home/tcwg-buildslave/workspace/tcwg_gnu_3/artifacts/build-c1f76af469388d3df815c82de566387da5ae000f/sumfiles # # # Comparing 12 common sum files: # g++.sum # gcc.sum # gfortran.sum # go.sum # gotools.sum # libatomic.sum # libffi.sum # libgo.sum # libgomp.sum # libitm.sum # libstdc++.sum # objc.sum # Comparing: # REFERENCE:/tmp/gxx-sum1.3784533 # CURRENT: /tmp/gxx-sum2.3784533 # # ` +---------+---------+ # o RUN STATUS: | REF | RES | # +------------------------------------------+---------+---------+ # | Passes [PASS] | 460026 | 460487 | # | Unexpected fails [FAIL] | 192 | 195 | # | Errors [ERROR] | 0 | 0 | # | Unexpected passes [XPASS] | 15 | 15 | # | Expected fails [XFAIL] | 2737 | 2737 | # | Unresolved [UNRESOLVED] | 104 | 104 | # | Unsupported [UNSUPPORTED] | 22890 | 22896 | # | Untested [UNTESTED] | 10 | 10 | # +------------------------------------------+---------+---------+ # # REF PASS ratio: 0.952238 # RES PASS ratio: 0.952266 # # o REGRESSIONS: # +------------------------------------------+---------+ # | PASS now FAIL [PASS => FAIL] | 1 | # | FAIL appears [ => FAIL] | 2 | # +------------------------------------------+---------+ # | TOTAL_REGRESSIONS | 3 | # +------------------------------------------+---------+ # # - PASS now FAIL [PASS => FAIL]: # # Executed from: g++.dg/dg.exp # g++:c-c++-common/missing-header-1.c -std=gnu++14 (test for excess errors) # # # - FAIL appears [ => FAIL]: # # Executed from: g++.dg/dg.exp # g++:c-c++-common/missing-header-1.c -std=gnu++14 expected multiline pattern lines 5-7 not found: "\s*#include "this-file-does-not-exist\.h".*\n \^~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated\..*\n" # Executed from: gcc.dg/debug/ctf/ctf.exp # gcc:gcc.dg/debug/ctf/ctf-skip-types-2.c (test for excess errors) # # # # o IMPROVEMENTS TO BE CHECKED: # +------------------------------------------+---------+ # | PASS disappears [PASS => ] | 1 | # | New PASS [ => PASS] | 463 | # | UNSUPPORTED appears [ =>UNSUP] | 6 | # +------------------------------------------+---------+ # | TOTAL_IMPROVEMENTS_TO_BE_CHECKED | 470 | # +------------------------------------------+---------+ # # - PASS disappears [PASS => ]: # # Executed from: g++.dg/dg.exp # g++:c-c++-common/missing-header-1.c -std=gnu++14 expected multiline pattern lines 5-7 was found: "\s*#include "this-file-does-not-exist\.h".*\n \^~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated\..*\n" # # # - New PASS [ => PASS]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/ipa/ipa-sra-4.C -std=gnu++14 (test for excess errors) # g++:g++.dg/ipa/ipa-sra-4.C -std=gnu++17 (test for excess errors) # g++:g++.dg/ipa/ipa-sra-4.C -std=gnu++2a (test for excess errors) # Executed from: gcc.dg/debug/debug.exp # gcc:gcc.dg/debug/20000503-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20010207-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20011223-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20020104-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20020220-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20020220-1.c -gctf execution test # gcc:gcc.dg/debug/20020224-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20020327-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20030605-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20031231-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20041023-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20041219-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/20050907-1.c -gctf (test for excess errors) # Executed from: gcc.dg/debug/btf/btf.exp # gcc:gcc.dg/debug/btf/btf-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-2.c scan-assembler-times 0.*btf_flags 1 # gcc:gcc.dg/debug/btf/btf-2.c scan-assembler-times 0x1.*btf_version 1 # gcc:gcc.dg/debug/btf/btf-2.c scan-assembler-times 0xeb9f.*btf_magic 1 # gcc:gcc.dg/debug/btf/btf-anonymous-struct-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-anonymous-struct-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*btt_name 1 # gcc:gcc.dg/debug/btf/btf-anonymous-struct-1.c scan-assembler-times [\t ]0x4000001[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-anonymous-struct-1.c scan-assembler-times [\t ]0x4000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-anonymous-union-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-anonymous-union-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*btt_name 1 # gcc:gcc.dg/debug/btf/btf-anonymous-union-1.c scan-assembler-times [\t ]0x4000001[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-anonymous-union-1.c scan-assembler-times [\t ]0x5000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-array-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-array-1.c scan-assembler-times 0x3000000[\t ]+[^\n]*btt_info 5 # gcc:gcc.dg/debug/btf/btf-array-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*bta_nelems 1 # gcc:gcc.dg/debug/btf/btf-array-1.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*bta_nelems 2 # gcc:gcc.dg/debug/btf/btf-array-1.c scan-assembler-times [\t ]0x3[\t ]+[^\n]*bta_nelems 1 # gcc:gcc.dg/debug/btf/btf-array-1.c scan-assembler-times [\t ]0x5[\t ]+[^\n]*bta_nelems 1 # gcc:gcc.dg/debug/btf/btf-bitfields-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-bitfields-1.c scan-assembler-times [\t ]0x13000040[\t ]+[^\n]*btm_offset 1 # gcc:gcc.dg/debug/btf/btf-bitfields-1.c scan-assembler-times [\t ]0x700002a[\t ]+[^\n]*btm_offset 1 # gcc:gcc.dg/debug/btf/btf-bitfields-1.c scan-assembler-times [\t ]0x84000004[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-bitfields-1.c scan-assembler-times [\t ]0xa000020[\t ]+[^\n]*btm_offset 1 # gcc:gcc.dg/debug/btf/btf-bitfields-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-bitfields-2.c scan-assembler-times [\t ]0x1f000000[\t ]+[^\n]*btm_offset 1 # gcc:gcc.dg/debug/btf/btf-bitfields-2.c scan-assembler-times [\t ]0x20000020[\t ]+[^\n]*btm_offset 1 # gcc:gcc.dg/debug/btf/btf-bitfields-2.c scan-assembler-times [\t ]0x84000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-bitfields-2.c scan-assembler-times btm_name 2 # gcc:gcc.dg/debug/btf/btf-bitfields-3.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-bitfields-3.c scan-assembler-times [\t ]0x1[\t ]+[^\n]*btm_type 1 # gcc:gcc.dg/debug/btf/btf-bitfields-3.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*btm_type 1 # gcc:gcc.dg/debug/btf/btf-bitfields-3.c scan-assembler-times [\t ]0x6000004[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-bitfields-3.c scan-assembler-times [\t ]0x84000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-bitfields-4.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-bitfields-4.c scan-assembler-times [\t ]0x4000003[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c scan-assembler-times [\t ]0x2000000[\t ]+[^\n]*btt_info 2 # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c scan-assembler-times [\t ]0x9000000[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c scan-assembler-times [\t ]0xa000000[\t ]+[^\n]*btt_info 2 # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c scan-assembler-times [\t ]0xb000000[\t ]+[^\n]*btt_info 2 # gcc:gcc.dg/debug/btf/btf-cvr-quals-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-datasec-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times 0[\t ]+[^\n]*bts_offset 7 # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times 0xf000001[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times 0xf000003[\t ]+[^\n]*btt_info 2 # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times ascii ".bss.0"[\t ]+[^\n]*btf_aux_string 1 # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times ascii ".data.0"[\t ]+[^\n]*btf_aux_string 1 # gcc:gcc.dg/debug/btf/btf-datasec-1.c scan-assembler-times ascii ".rodata.0"[\t ]+[^\n]*btf_aux_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times [\t ]0x6000003[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times [\t ]0x6000004[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "IDUNNO.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "NO.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "QAD.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "QED.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "QOD.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "QUD.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times ascii "YES.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-enum-1.c scan-assembler-times bte_value 7 # gcc:gcc.dg/debug/btf/btf-forward-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-forward-1.c scan-assembler-times [\t ]0x7000000[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-forward-1.c scan-assembler-times [\t ]0x87000000[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-function-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-function-1.c scan-assembler-times [\t ]0xd000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-function-1.c scan-assembler-times ascii "alpha.0"[\t ]+[^\n]*btf_aux_string 1 # gcc:gcc.dg/debug/btf/btf-function-1.c scan-assembler-times ascii "bravo.0"[\t ]+[^\n]*btf_aux_string 1 # gcc:gcc.dg/debug/btf/btf-function-1.c scan-assembler-times farg_name 2 # gcc:gcc.dg/debug/btf/btf-function-1.c scan-assembler-times farg_type 2 # gcc:gcc.dg/debug/btf/btf-function-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-function-2.c scan-assembler-times [\t ]0[\t ]+[^\n]*farg_name 1 # gcc:gcc.dg/debug/btf/btf-function-2.c scan-assembler-times [\t ]0[\t ]+[^\n]*farg_type 1 # gcc:gcc.dg/debug/btf/btf-function-2.c scan-assembler-times [\t ]0xd000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-function-2.c scan-assembler-times farg_name 2 # gcc:gcc.dg/debug/btf/btf-function-2.c scan-assembler-times farg_type 2 # gcc:gcc.dg/debug/btf/btf-function-3.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-function-3.c scan-assembler-times [\t ]0[\t ]+[^\n]*farg_type 1 # gcc:gcc.dg/debug/btf/btf-function-3.c scan-assembler-times [\t ]0xd000003[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-function-3.c scan-assembler-times farg_name 3 # gcc:gcc.dg/debug/btf/btf-function-3.c scan-assembler-times farg_type 3 # gcc:gcc.dg/debug/btf/btf-int-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times [\t ]0x10000..[\t ]+[^\n]*bti_encoding 3 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times [\t ]0x1000000[\t ]+[^\n]*btt_info 8 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times [\t ]0x20000..[\t ]+[^\n]*bti_encoding 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times [\t ]0x30000..[\t ]+[^\n]*bti_encoding 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "long int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "long unsigned int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "short int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "short unsigned int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "signed char.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "unsigned char.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-int-1.c scan-assembler-times ascii "unsigned int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-pointers-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-pointers-1.c scan-assembler-times [\t ]0x2000000[\t ]+[^\n]*btt_info 2 # gcc:gcc.dg/debug/btf/btf-pointers-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-pointers-1.c scan-assembler-times ascii "st.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-pointers-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-pointers-2.c scan-assembler-times [\t ]0x1000000[\t ]+[^\n]*btt_info 0 # gcc:gcc.dg/debug/btf/btf-pointers-2.c scan-assembler-times [\t ]0x2000000[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-struct-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-struct-1.c scan-assembler-times [\t ]0x4000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-struct-1.c scan-assembler-times [\t ]0x4000003[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-struct-1.c scan-assembler-times btm_name 5 # gcc:gcc.dg/debug/btf/btf-struct-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-struct-2.c scan-assembler-times [\t ]0x4000002[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x3[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x4[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x6[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x8000000[\t ]+[^\n]*btt_info 7 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0x8[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0xb[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times [\t ]0xf[\t ]+[^\n]*btv_type 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "CBAR.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "CBARP.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "arena_t.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "bar_int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "foo_int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "my_int.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-typedef-1.c scan-assembler-times ascii "node_t.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-union-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-union-1.c scan-assembler-times [\t ]0x5000004[\t ]+[^\n]*btt_info 1 # gcc:gcc.dg/debug/btf/btf-union-1.c scan-assembler-times btm_name 4 # gcc:gcc.dg/debug/btf/btf-variables-1.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-variables-1.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*btv_info 6 # gcc:gcc.dg/debug/btf/btf-variables-2.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-variables-2.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*btv_info 3 # gcc:gcc.dg/debug/btf/btf-variables-2.c scan-assembler-times ascii "baz.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-variables-2.c scan-assembler-times ascii "foo.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-variables-2.c scan-assembler-times ascii "myst.0"[\t ]+[^\n]*btf_string 1 # gcc:gcc.dg/debug/btf/btf-variables-3.c (test for excess errors) # gcc:gcc.dg/debug/btf/btf-variables-3.c scan-assembler-times [\t ]0[\t ]+[^\n]*btv_linkage 3 # gcc:gcc.dg/debug/btf/btf-variables-3.c scan-assembler-times [\t ]0x1[\t ]+[^\n]*btv_linkage 3 # gcc:gcc.dg/debug/btf/btf-variables-3.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*btv_info 6 # Executed from: gcc.dg/debug/debug.exp # gcc:gcc.dg/debug/const-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/const-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/const-3.c -gctf scan-assembler-not dontgenerate # gcc:gcc.dg/debug/const-3.c -gctf (test for excess errors) # gcc:gcc.dg/debug/crash1.c -gctf (test for excess errors) # Executed from: gcc.dg/debug/ctf/ctf.exp # gcc:gcc.dg/debug/ctf/ctf-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-2.c scan-assembler-times 0.*CTF preamble flags 0 # gcc:gcc.dg/debug/ctf/ctf-2.c scan-assembler-times 0x4.*CTF preamble version 0 # gcc:gcc.dg/debug/ctf/ctf-2.c scan-assembler-times 0xdff2.*CTF preamble magic number 0 # gcc:gcc.dg/debug/ctf/ctf-anonymous-struct-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-anonymous-struct-1.c scan-assembler-times 0x1a000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-anonymous-struct-1.c scan-assembler-times 0x1a000002[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-anonymous-struct-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctt_name 1 # gcc:gcc.dg/debug/ctf/ctf-anonymous-union-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-anonymous-union-1.c scan-assembler-times 0x1a000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-anonymous-union-1.c scan-assembler-times 0x1e000002[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-anonymous-union-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctt_name 1 # gcc:gcc.dg/debug/ctf/ctf-array-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-array-1.c scan-assembler-times 0x12000000[\t ]+[^\n]*ctt_info 5 # gcc:gcc.dg/debug/ctf/ctf-array-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-array-1.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*cta_nelems 2 # gcc:gcc.dg/debug/ctf/ctf-array-1.c scan-assembler-times [\t ]0x3[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-array-1.c scan-assembler-times [\t ]0x5[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-array-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-array-2.c scan-assembler-times 0x12000000[\t ]+[^\n]*ctt_info 5 # gcc:gcc.dg/debug/ctf/ctf-array-2.c scan-assembler-times [\t ]0[\t ]+[^\n]*cta_nelems 3 # gcc:gcc.dg/debug/ctf/ctf-array-2.c scan-assembler-times [\t ]0x5[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-array-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-array-4.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-array-4.c scan-assembler-times 0x12000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-array-4.c scan-assembler-times [\t ]0x1[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times [\t ]0x22000003[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times [\t ]0x2a000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times [\t ]0x3[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times ascii "B1.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times ascii "B2.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times ascii "B3.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-attr-mode-1.c scan-assembler-times cte_value 3 # gcc:gcc.dg/debug/ctf/ctf-attr-used-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-attr-used-1.c scan-assembler-times ascii "keep_this.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-attr-used-1.c scan-assembler-times ascii "lose_this.0"[\t ]+[^\n]*ctf_string 0 # gcc:gcc.dg/debug/ctf/ctf-bitfields-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-bitfields-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctt_name 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-1.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*cts_bits 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-1.c scan-assembler-times [\t ]0x3[\t ]+[^\n]*cts_bits 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times [\t ]0x10[\t ]+[^\n]*cts_bits 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times [\t ]0x21[\t ]+[^\n]*cts_bits 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*cts_type 3 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times [\t ]0x6[\t ]+[^\n]*cts_type 3 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times [\t ]0xf[\t ]+[^\n]*cts_bits 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times ascii "long long int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-2.c scan-assembler-times ascii "long long unsigned int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-bitfields-3.c scan-assembler-times [\t ]0x1[\t ]+[^\n]*cts_bits 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-3.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*cts_type 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-3.c scan-assembler-times ascii "_Bool.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-4.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-bitfields-4.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*cts_type 2 # gcc:gcc.dg/debug/ctf/ctf-bitfields-4.c scan-assembler-times [\t ]0x5[\t ]+[^\n]*cts_bits 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-4.c scan-assembler-times [\t ]0xa[\t ]+[^\n]*cts_bits 1 # gcc:gcc.dg/debug/ctf/ctf-bitfields-4.c scan-assembler-times ctm_name 2 # gcc:gcc.dg/debug/ctf/ctf-complex-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-complex-1.c scan-assembler-times ascii "complex double.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-complex-1.c scan-assembler-times ascii "complex float.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-complex-1.c scan-assembler-times ascii "complex long double.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctt_name 7 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times [\t ]0x2e000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times [\t ]0x36000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-2.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-2.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-3.c scan-assembler-times [\t ]0x12000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-3.c scan-assembler-times [\t ]0x2e000000[\t ]+[^\n]*ctt_info 5 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-3.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 3 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-3.c scan-assembler-times ascii "unsigned char.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-4.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-4.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctt_name 2 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-4.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-cvr-quals-4.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-debug-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-debug-1.c scan-assembler 0xdff2.*CTF preamble magic number # gcc:gcc.dg/debug/ctf/ctf-debug-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-debug-2.c scan-assembler 0xdff2.*CTF preamble magic number # gcc:gcc.dg/debug/ctf/ctf-enum-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-enum-1.c scan-assembler-times ascii "BLUE.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-1.c scan-assembler-times ascii "GREEN.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-1.c scan-assembler-times ascii "RED.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-1.c scan-assembler-times ascii "YELLOW.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-1.c scan-assembler-times cte_value 4 # gcc:gcc.dg/debug/ctf/ctf-enum-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-enum-2.c scan-assembler-times ascii "GFS_MONOTONIC.0"[\t ]+[^\n]*ctf_string 0 # gcc:gcc.dg/debug/ctf/ctf-enum-2.c scan-assembler-times ascii "GFS_RUNTIME.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-2.c scan-assembler-times ascii "GFS_STATIC.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-enum-2.c scan-assembler-times cte_value 2 # gcc:gcc.dg/debug/ctf/ctf-file-scope-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-file-scope-1.c scan-assembler-times ascii "SFOO.0"[\t ]+[^\n]*ctf_string 0 # gcc:gcc.dg/debug/ctf/ctf-file-scope-1.c scan-assembler-times ascii "foo.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-file-scope-1.c scan-assembler-times ascii "gfoo.0"[\t ]+[^\n]*ctf_string 0 # gcc:gcc.dg/debug/ctf/ctf-float-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-float-1.c scan-assembler-times ascii "double.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-float-1.c scan-assembler-times ascii "float.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-float-1.c scan-assembler-times ascii "long double.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-forward-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-forward-1.c scan-assembler-times [\t ]0x26000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-forward-1.c scan-assembler-times [\t ]0x6[\t ]+[^\n]*ctt_size or ctt_type 2 # gcc:gcc.dg/debug/ctf/ctf-forward-1.c scan-assembler-times [\t ]0x7[\t ]+[^\n]*ctt_size or ctt_type 2 # gcc:gcc.dg/debug/ctf/ctf-forward-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-forward-2.c scan-assembler-times [\t ]0x26000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-forward-2.c scan-assembler-times [\t ]0x8[\t ]+[^\n]*ctt_size or ctt_type 1 # gcc:gcc.dg/debug/ctf/ctf-forward-2.c scan-assembler-times ascii "vibgyor.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-func-index-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-func-index-1.c scan-assembler-times ascii "bar.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-func-index-1.c scan-assembler-times ascii "foo.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-func-index-1.c scan-assembler-times funcinfo_func_type 2 # gcc:gcc.dg/debug/ctf/ctf-func-index-1.c scan-assembler-times funcinfo_name 2 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times [\t ]0x16000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times [\t ]0x16000002[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times [\t ]0x16000003[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times ascii "__foo_fn.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times ascii "destroy.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-1.c scan-assembler-times ascii "func.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-function-pointers-2.c scan-assembler-times [\t ]0x16000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-2.c scan-assembler-times ascii "func.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-2.c scan-assembler-times ascii "rcu_callback_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-function-pointers-3.c scan-assembler-times [\t ]0x16000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-3.c scan-assembler-times ascii "fn.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-3.c scan-assembler-times ascii "foo_init_callback.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-4.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-function-pointers-4.c scan-assembler-times [\t ]0x16000001[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-function-pointers-4.c scan-assembler-times ascii "var_assign_func_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-functions-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-functions-1.c scan-assembler-times [\t ]0[\t ]+[^\n]*dtu_argv 1 # gcc:gcc.dg/debug/ctf/ctf-functions-1.c scan-assembler-times [\t ]0x16000002[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-functions-1.c scan-assembler-times dtu_argv 2 # gcc:gcc.dg/debug/ctf/ctf-int-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-int-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-int-1.c scan-assembler-times ascii "long int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-int-1.c scan-assembler-times ascii "short int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times ascii "a.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times ascii "a1.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times ascii "b.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times ascii "d_instance.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times objtinfo_name 4 # gcc:gcc.dg/debug/ctf/ctf-objt-index-1.c scan-assembler-times objtinfo_var_type 4 # gcc:gcc.dg/debug/ctf/ctf-pointers-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-pointers-1.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*ctt_info 2 # gcc:gcc.dg/debug/ctf/ctf-pointers-1.c scan-assembler-times ascii "foo_struct.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-pointers-1.c scan-assembler-times ascii "int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-pointers-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-pointers-2.c scan-assembler-times [\t ]0xe000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-preamble-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-preamble-1.c scan-assembler 0.*CTF preamble flags # gcc:gcc.dg/debug/ctf/ctf-preamble-1.c scan-assembler 0x4.*CTF preamble version # gcc:gcc.dg/debug/ctf/ctf-preamble-1.c scan-assembler 0xdff2.*CTF preamble magic number # gcc:gcc.dg/debug/ctf/ctf-skip-types-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-skip-types-1.c scan-assembler-times [\t ]0x2000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-1.c scan-assembler-times ascii "unknown.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times [\t ]0x1a000003[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times [\t ]0x2a000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times ascii "c1.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times ascii "comp_type.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times ascii "comp_type_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-skip-types-8.c scan-assembler-times ctm_name 3 # gcc:gcc.dg/debug/ctf/ctf-str-table-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-str-table-1.c scan-assembler-times ascii ".0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-1.c scan-assembler-times [\t ]0x1a000002[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-struct-1.c scan-assembler-times [\t ]0x1a000004[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-struct-1.c scan-assembler-times ctm_name 6 # gcc:gcc.dg/debug/ctf/ctf-struct-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-2.c scan-assembler-times ascii "dmx_dtdef.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-2.c scan-assembler-times ascii "dmx_dtdef_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-2.c scan-assembler-times ascii "dtd_name.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-2.c scan-assembler-times ascii "dtd_type.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 3 # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c scan-assembler-times ascii "cmodel.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c scan-assembler-times ascii "cmodel_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c scan-assembler-times ascii "cname.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-1.c scan-assembler-times ascii "cpointer.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-array-2.c scan-assembler-times 0x12000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-2.c scan-assembler-times [\t ]0[\t ]+[^\n]*ctm_offset 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-2.c scan-assembler-times [\t ]0x4[\t ]+[^\n]*cta_nelems 1 # gcc:gcc.dg/debug/ctf/ctf-struct-array-2.c scan-assembler-times [\t ]0x4[\t ]+[^\n]*ctm_offset 1 # gcc:gcc.dg/debug/ctf/ctf-struct-pointer-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-pointer-1.c scan-assembler-times [\t ]"bar.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-struct-pointer-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-struct-pointer-2.c scan-assembler-times [\t ]"bar.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times 0x2a000000[\t ]+[^\n]*ctt_info 7 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0x2[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0x4[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0x5[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0x9[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0xa[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0xc[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times [\t ]0xf[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "CINT.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "CINTP.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "bar_int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "foo_int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "my_array.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "my_int.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-1.c scan-assembler-times ascii "my_node_t.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-2.c scan-assembler-times 0x2a000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-2.c scan-assembler-times ascii "foo_void_type.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-2.c scan-assembler-times ascii "void.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-3.c scan-assembler-times 0x2a000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-3.c scan-assembler-times ascii "foo.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-3.c scan-assembler-times ascii "foo_type.0"[\t ]+[^\n]*ctf_string 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-3.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-3.c scan-assembler-times [\t ]0x2a000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-3.c scan-assembler-times [\t ]0x32000000[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-typedef-struct-3.c scan-assembler-times [\t ]0x4[\t ]+[^\n]*ctv_typeidx 1 # gcc:gcc.dg/debug/ctf/ctf-union-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-union-1.c scan-assembler-times [\t ]0x1e000004[\t ]+[^\n]*ctt_info 1 # gcc:gcc.dg/debug/ctf/ctf-union-1.c scan-assembler-times ctm_name 4 # gcc:gcc.dg/debug/ctf/ctf-variables-1.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-variables-1.c scan-assembler-times ctv_name 7 # gcc:gcc.dg/debug/ctf/ctf-variables-2.c (test for excess errors) # gcc:gcc.dg/debug/ctf/ctf-variables-2.c scan-assembler-times ascii "bstatic.0"[\t ]+[^\n]*ctf_string 0 # gcc:gcc.dg/debug/ctf/ctf-variables-2.c scan-assembler-times ctv_name 0 # Executed from: gcc.dg/debug/debug.exp # gcc:gcc.dg/debug/debug-3.c -gctf (test for excess errors) # gcc:gcc.dg/debug/debug-4.c -gctf (test for excess errors) # gcc:gcc.dg/debug/debug-5.c -gctf (test for excess errors) # gcc:gcc.dg/debug/debug-7.c -gctf (test for excess errors) # gcc:gcc.dg/debug/dwarf2-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/dwarf2-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/enum-1.c -gctf scan-assembler JTI_MAX # gcc:gcc.dg/debug/enum-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr16676.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr26881.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr29558.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr29609-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr29609-1.c -gctf execution test # gcc:gcc.dg/debug/pr29609-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr29609-2.c -gctf execution test # gcc:gcc.dg/debug/pr32610.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr33316.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr36690-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr36690-1.c -gctf execution test # gcc:gcc.dg/debug/pr36690-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr36690-2.c -gctf execution test # gcc:gcc.dg/debug/pr36690-3.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr36690-3.c -gctf execution test # gcc:gcc.dg/debug/pr37616.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr37616.c -gctf execution test # gcc:gcc.dg/debug/pr39412.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr41264-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr41343-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr41717.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr41893-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr41893-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr42244.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr42767.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr43972.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr45849.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr46409.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr46782.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr47498.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr47501.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr49032.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr49294.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr49522.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr55730.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr57351.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr65771.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr66068.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr66432.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr78587.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr80321.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr85252.c -gctf (test for warnings, line 10) # gcc:gcc.dg/debug/pr85252.c -gctf (test for warnings, line 8) # gcc:gcc.dg/debug/pr85252.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr89704.c -gctf (test for excess errors) # gcc:gcc.dg/debug/pr97714.c -gctf (test for excess errors) # gcc:gcc.dg/debug/redecl-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/redecl-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/redecl-3.c -gctf (test for excess errors) # gcc:gcc.dg/debug/redecl-4.c -gctf (test for excess errors) # gcc:gcc.dg/debug/redecl-5.c -gctf (test for excess errors) # gcc:gcc.dg/debug/tls-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/trivial.c -gctf (test for excess errors) # gcc:gcc.dg/debug/trivial.c -gctf execution test # gcc:gcc.dg/debug/vta-1.c -gctf (test for excess errors) # gcc:gcc.dg/debug/vta-2.c -gctf (test for excess errors) # gcc:gcc.dg/debug/vta-3.c -gctf (test for excess errors) # Executed from: gcc.dg/ipa/ipa.exp # gcc:gcc.dg/ipa/ipa-sra-23.c (test for excess errors) # gcc:gcc.dg/ipa/ipa-sra-24.c (test for excess errors) # gcc:gcc.dg/ipa/pr93385.c (test for excess errors) # gcc:gcc.dg/ipa/pr93385.c execution test # # # - UNSUPPORTED appears [ =>UNSUP]: # # Executed from: g++.dg/dg.exp # g++:g++.dg/ipa/ipa-sra-4.C -std=gnu++98 # Executed from: gcc.dg/debug/ctf/ctf.exp # gcc:gcc.dg/debug/ctf/ctf-skip-types-4.c # gcc:gcc.dg/debug/ctf/ctf-skip-types-5.c # gcc:gcc.dg/debug/ctf/ctf-skip-types-6.c # gcc:gcc.dg/debug/ctf/ctf-skip-types-7.c # Executed from: gcc.dg/debug/debug.exp # gcc:gcc.dg/debug/pr35154.c -gctf # # # # # Regressions found # # Regressions in 12 common sum files found from (for last_good == b7e215a8ee81d44281d9e0a2a25eceb47b6911dd) # reset_artifacts: -10 # build_abe bootstrap: 0 # build_abe check_bootstrap: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… Build top page/logs: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67/ Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-c1f76af469388d3df815c82de566387da5ae000f cd investigate-gcc-c1f76af469388d3df815c82de566387da5ae000f git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach c1f76af469388d3df815c82de566387da5ae000f ../artifacts/test.sh # Reproduce last_good build git checkout --detach b7e215a8ee81d44281d9e0a2a25eceb47b6911dd ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… Build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-check_bootstrap/67… Full commit (up to 1000 lines): <cut> commit c1f76af469388d3df815c82de566387da5ae000f Author: Indu Bhagat <indu.bhagat(a)oracle.com> Date: Thu May 20 11:19:04 2021 -0700 CTF/BTF testsuites This commit adds a new testsuite for the CTF debug format. 2021-06-28 Indu Bhagat <indu.bhagat(a)oracle.com> David Faust <david.faust(a)oracle.com> gcc/testsuite/ * lib/gcc-dg.exp (gcc-dg-frontend-supports-ctf): New procedure. (gcc-dg-debug-runtest): Add -gctf support. * gcc.dg/debug/btf/btf-1.c: New test. * gcc.dg/debug/btf/btf-2.c: Likewise. * gcc.dg/debug/btf/btf-anonymous-struct-1.c: Likewise. * gcc.dg/debug/btf/btf-anonymous-union-1.c: Likewise. * gcc.dg/debug/btf/btf-array-1.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-1.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-2.c: Likewise. * gcc.dg/debug/btf/btf-bitfields-3.c: Likewise. * gcc.dg/debug/btf/btf-cvr-quals-1.c: Likewise. * gcc.dg/debug/btf/btf-enum-1.c: Likewise. * gcc.dg/debug/btf/btf-forward-1.c: Likewise. * gcc.dg/debug/btf/btf-function-1.c: Likewise. * gcc.dg/debug/btf/btf-function-2.c: Likewise. * gcc.dg/debug/btf/btf-int-1.c: Likewise. * gcc.dg/debug/btf/btf-pointers-1.c: Likewise. * gcc.dg/debug/btf/btf-struct-1.c: Likewise. * gcc.dg/debug/btf/btf-typedef-1.c: Likewise. * gcc.dg/debug/btf/btf-union-1.c: Likewise. * gcc.dg/debug/btf/btf-variables-1.c: Likewise. * gcc.dg/debug/btf/btf.exp: Likewise. * gcc.dg/debug/ctf/ctf-1.c: Likewise. * gcc.dg/debug/ctf/ctf-2.c: Likewise. * gcc.dg/debug/ctf/ctf-anonymous-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-anonymous-union-1.c: Likewise. * gcc.dg/debug/ctf/ctf-array-1.c: Likewise. * gcc.dg/debug/ctf/ctf-array-2.c: Likewise. * gcc.dg/debug/ctf/ctf-array-3.c: Likewise. * gcc.dg/debug/ctf/ctf-array-4.c: Likewise. * gcc.dg/debug/ctf/ctf-attr-mode-1.c: Likewise. * gcc.dg/debug/ctf/ctf-attr-used-1.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-1.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-2.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-3.c: Likewise. * gcc.dg/debug/ctf/ctf-bitfields-4.c: Likewise. * gcc.dg/debug/ctf/ctf-complex-1.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-1.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-2.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-3.c: Likewise. * gcc.dg/debug/ctf/ctf-cvr-quals-4.c: Likewise. * gcc.dg/debug/ctf/ctf-enum-1.c: Likewise. * gcc.dg/debug/ctf/ctf-enum-2.c: Likewise. * gcc.dg/debug/ctf/ctf-file-scope-1.c: Likewise. * gcc.dg/debug/ctf/ctf-float-1.c: Likewise. * gcc.dg/debug/ctf/ctf-forward-1.c: Likewise. * gcc.dg/debug/ctf/ctf-forward-2.c: Likewise. * gcc.dg/debug/ctf/ctf-func-index-1.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-1.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-2.c: Likewise. * gcc.dg/debug/ctf/ctf-function-pointers-3.c: Likewise. * gcc.dg/debug/ctf/ctf-functions-1.c: Likewise. * gcc.dg/debug/ctf/ctf-int-1.c: Likewise. * gcc.dg/debug/ctf/ctf-objt-index-1.c: Likewise. * gcc.dg/debug/ctf/ctf-pointers-1.c: Likewise. * gcc.dg/debug/ctf/ctf-pointers-2.c: Likewise. * gcc.dg/debug/ctf/ctf-preamble-1.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-1.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-2.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-3.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-4.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-5.c: Likewise. * gcc.dg/debug/ctf/ctf-skip-types-6.c: Likewise. * gcc.dg/debug/ctf/ctf-str-table-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-2.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-array-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-pointer-1.c: Likewise. * gcc.dg/debug/ctf/ctf-struct-pointer-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-1.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-3.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-1.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-2.c: Likewise. * gcc.dg/debug/ctf/ctf-typedef-struct-3.c: Likewise. * gcc.dg/debug/ctf/ctf-union-1.c: Likewise. * gcc.dg/debug/ctf/ctf-variables-1.c: Likewise. * gcc.dg/debug/ctf/ctf-variables-2.c: Likewise. * gcc.dg/debug/ctf/ctf.exp: Likewise. --- gcc/testsuite/gcc.dg/debug/btf/btf-1.c | 6 ++ gcc/testsuite/gcc.dg/debug/btf/btf-2.c | 10 +++ .../gcc.dg/debug/btf/btf-anonymous-struct-1.c | 23 ++++++ .../gcc.dg/debug/btf/btf-anonymous-union-1.c | 23 ++++++ gcc/testsuite/gcc.dg/debug/btf/btf-array-1.c | 31 ++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-1.c | 34 +++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-2.c | 26 +++++++ gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-3.c | 43 ++++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-4.c | 23 ++++++ gcc/testsuite/gcc.dg/debug/btf/btf-cvr-quals-1.c | 52 ++++++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 45 ++++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c | 30 ++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-forward-1.c | 24 +++++++ gcc/testsuite/gcc.dg/debug/btf/btf-function-1.c | 18 +++++ gcc/testsuite/gcc.dg/debug/btf/btf-function-2.c | 18 +++++ gcc/testsuite/gcc.dg/debug/btf/btf-function-3.c | 22 ++++++ gcc/testsuite/gcc.dg/debug/btf/btf-int-1.c | 44 ++++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-pointers-1.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/btf/btf-pointers-2.c | 13 ++++ gcc/testsuite/gcc.dg/debug/btf/btf-struct-1.c | 22 ++++++ gcc/testsuite/gcc.dg/debug/btf/btf-struct-2.c | 19 +++++ gcc/testsuite/gcc.dg/debug/btf/btf-typedef-1.c | 82 ++++++++++++++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-union-1.c | 16 +++++ gcc/testsuite/gcc.dg/debug/btf/btf-variables-1.c | 33 +++++++++ gcc/testsuite/gcc.dg/debug/btf/btf-variables-2.c | 27 +++++++ gcc/testsuite/gcc.dg/debug/btf/btf-variables-3.c | 36 ++++++++++ gcc/testsuite/gcc.dg/debug/btf/btf.exp | 41 +++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-1.c | 6 ++ gcc/testsuite/gcc.dg/debug/ctf/ctf-2.c | 10 +++ .../gcc.dg/debug/ctf/ctf-anonymous-struct-1.c | 23 ++++++ .../gcc.dg/debug/ctf/ctf-anonymous-union-1.c | 26 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-array-1.c | 31 ++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-array-2.c | 38 ++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-array-3.c | 17 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-array-4.c | 13 ++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-mode-1.c | 22 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-attr-used-1.c | 22 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-bitfields-1.c | 30 ++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-bitfields-2.c | 39 ++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-bitfields-3.c | 16 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-bitfields-4.c | 19 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-complex-1.c | 21 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-cvr-quals-1.c | 65 +++++++++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-cvr-quals-2.c | 30 ++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-cvr-quals-3.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-cvr-quals-4.c | 23 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-debug-1.c | 7 ++ gcc/testsuite/gcc.dg/debug/ctf/ctf-debug-2.c | 7 ++ gcc/testsuite/gcc.dg/debug/ctf/ctf-enum-1.c | 21 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-enum-2.c | 27 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-file-scope-1.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-float-1.c | 16 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-forward-1.c | 40 +++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-forward-2.c | 16 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-func-index-1.c | 25 +++++++ .../gcc.dg/debug/ctf/ctf-function-pointers-1.c | 24 +++++++ .../gcc.dg/debug/ctf/ctf-function-pointers-2.c | 22 ++++++ .../gcc.dg/debug/ctf/ctf-function-pointers-3.c | 21 ++++++ .../gcc.dg/debug/ctf/ctf-function-pointers-4.c | 18 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-functions-1.c | 34 +++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-int-1.c | 17 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-objt-index-1.c | 30 ++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-pointers-1.c | 26 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-pointers-2.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-preamble-1.c | 11 +++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-1.c | 38 ++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-2.c | 17 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-3.c | 20 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-4.c | 19 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-5.c | 19 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-6.c | 18 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-7.c | 18 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-skip-types-8.c | 27 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-str-table-1.c | 26 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-struct-1.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-struct-2.c | 32 +++++++++ .../gcc.dg/debug/ctf/ctf-struct-array-1.c | 65 +++++++++++++++++ .../gcc.dg/debug/ctf/ctf-struct-array-2.c | 15 ++++ .../gcc.dg/debug/ctf/ctf-struct-pointer-1.c | 21 ++++++ .../gcc.dg/debug/ctf/ctf-struct-pointer-2.c | 22 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-typedef-1.c | 68 ++++++++++++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-typedef-2.c | 20 ++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-typedef-3.c | 24 +++++++ .../gcc.dg/debug/ctf/ctf-typedef-struct-1.c | 14 ++++ .../gcc.dg/debug/ctf/ctf-typedef-struct-2.c | 17 +++++ .../gcc.dg/debug/ctf/ctf-typedef-struct-3.c | 32 +++++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-union-1.c | 14 ++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-variables-1.c | 25 +++++++ gcc/testsuite/gcc.dg/debug/ctf/ctf-variables-2.c | 16 +++++ gcc/testsuite/gcc.dg/debug/ctf/ctf.exp | 41 +++++++++++ gcc/testsuite/lib/gcc-dg.exp | 64 +++++++++++++---- 91 files changed, 2376 insertions(+), 15 deletions(-) diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-1.c new file mode 100644 index 00000000000..bcbc9492439 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-1.c @@ -0,0 +1,6 @@ +/* { dg-do compile } */ +/* { dg-options "-gbtf" } */ + +void func(void) +{ +} diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-2.c b/gcc/testsuite/gcc.dg/debug/btf/btf-2.c new file mode 100644 index 00000000000..70e2ff1e053 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-2.c @@ -0,0 +1,10 @@ +/* Check the BTF header information. */ + +/* { dg-do compile } */ +/* { dg-options "-gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "0xeb9f.*btf_magic" 1} } */ +/* { dg-final { scan-assembler-times "0x1.*btf_version" 1 } } */ +/* { dg-final { scan-assembler-times "0.*btf_flags" 1 } } */ + +int foo; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-struct-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-struct-1.c new file mode 100644 index 00000000000..89a5701bba0 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-struct-1.c @@ -0,0 +1,23 @@ +/* Test BTF generation of anonymous struct. + + We expect two BTF struct records: + - struct foo, with two fields "a" and "bar" + - struct <anonymous> with one field "b" + + The anonymous struct should have a name of 0, pointing to the null string + at the start of the string table. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Struct type with 2 members (struct foo). */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000002\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* Struct type with 1 member (anon struct). */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000001\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*btt_name" 1 } } */ + +struct foo +{ + int a; + struct { int b; } bar; +} myfoo; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-union-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-union-1.c new file mode 100644 index 00000000000..f3b120bb458 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-anonymous-union-1.c @@ -0,0 +1,23 @@ +/* Test BTF generation of anonymous union. + + We expect a named struct type and an anonymous union type record to + be generated. The anonymous union record should have a name of 0, + pointing to the null string at the start of the string table. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Struct type with 1 member. */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000001\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* Union type with 2 members. */ +/* { dg-final { scan-assembler-times "\[\t \]0x5000002\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*btt_name" 1 } } */ + +struct foo +{ + union + { + int value; + char ascii; + }; +} myfoo; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-array-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-array-1.c new file mode 100644 index 00000000000..ab55445bd35 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-array-1.c @@ -0,0 +1,31 @@ +/* BTF generation for array type. + + Unsized arrays are encoded with a 0 for the number of elements. + + In this testcase, 5 distinct BTF records for arrays are expected + b1 : cta_nelems = 2 + c1 : cta_nelems = 3 + a1 : cta_nelems = 2, 5 + buf : cta_nelems = 0. */ + +/* { dg-do compile ) */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "0x3000000\[\t \]+\[^\n\]*btt_info" 5 } } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x2\[\t \]+\[^\n\]*bta_nelems" 2 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x3\[\t \]+\[^\n\]*bta_nelems" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x5\[\t \]+\[^\n\]*bta_nelems" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*bta_nelems" 1 } } */ + +int b1[2] = {0,1}; +int c1[5] = {0,1,2,3,4}; +int a1[2][3] = { {3,4,5}, {2,3,4} }; + +/* Variable length struct using arrays. */ +struct my_array +{ + int flags; + int length; + int buf[]; +} my_array_obj; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-1.c new file mode 100644 index 00000000000..c6bf52130dc --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-1.c @@ -0,0 +1,34 @@ +/* Basic tests for BTF bitfields. + + The structure containing bitfield members should be marked with KIND_FLAG=1 + The bitfield member offsets should be encoded as: + (bit_size << 24) | bit_offset + - (0xa << 24) | 0x20 + - (0x7 << 24) | 0x2a + - (0x13 << 24) | 0x40 - note that this is aligned to 0x40. */ + +/* { dg-do compile ) */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x84000004\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* { dg-final { scan-assembler-times "\[\t \]0xa000020\[\t \]+\[^\n\]*btm_offset" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x700002a\[\t \]+\[^\n\]*btm_offset" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x13000040\[\t \]+\[^\n\]*btm_offset" 1 } } */ + +struct bitt { + int a; + unsigned int bitfield_a : 10; + unsigned int bitfield_b : 7; + unsigned int bitfield_c : 19; +} bitty; + +struct no_bitt { + int a; + int b; +} no_bitty; + +int main () +{ + return bitty.bitfield_b + bitty.a; +} diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-2.c b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-2.c new file mode 100644 index 00000000000..9665ab67145 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-2.c @@ -0,0 +1,26 @@ +/* Test BTF generation for struct with 0 size bitfield. + + We expect a struct with 2 members to be generated. The size 0 bitfield + should not have any entry in the member list. */ + +/* { dg-do compile ) */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Struct with bitfield members, and 2 members. */ +/* { dg-final { scan-assembler-times "\[\t \]0x84000002\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* Bitfield size 31 (0x1f) at offset 0. */ +/* { dg-final { scan-assembler-times "\[\t \]0x1f000000\[\t \]+\[^\n\]*btm_offset" 1 } } */ + +/* Bitfield size 32 (0x20) at offset 32. */ +/* { dg-final { scan-assembler-times "\[\t \]0x20000020\[\t \]+\[^\n\]*btm_offset" 1 } } */ + +/* Only 2 members. */ +/* { dg-final { scan-assembler-times "btm_name" 2 } } */ + +struct foo +{ + unsigned a : 31; + unsigned : 0; + unsigned c : 32; +} myfoo; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-3.c b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-3.c new file mode 100644 index 00000000000..440623c3b16 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-3.c @@ -0,0 +1,43 @@ +/* Test BTF generation for enum-type bitfields + + It is allowed to have a bitfield type be an enum type. + We expect the following types: + + [1] enum 'foo'(1U#B) size=4U#B + 'BAR' value=0 + 'BAZ' value=1 + 'QUZ' value=2 + 'QUX' value=3 + [2] int 'unsigned int' size=4 offset=0 bits=32 + [3] struct 'bitt' size=4 + member 'f' type=1 bitfield_size=2 bit_offset=0 + member 'data' type=2 bitfield_size=14 bit_offset=2 + */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Enum with 4 members. */ +/* { dg-final { scan-assembler-times "\[\t \]0x6000004\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* Struct with bitfield members, and 2 members. */ +/* { dg-final { scan-assembler-times "\[\t \]0x84000002\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* Bitfield "f" points to type ID 1. */ +/* { dg-final { scan-assembler-times "\[\t \]0x1\[\t \]+\[^\n\]*btm_type" 1 } } */ + +/* Bitfield "data" points to type ID 2. */ +/* { dg-final { scan-assembler-times "\[\t \]0x2\[\t \]+\[^\n\]*btm_type" 1 } } */ + +enum foo +{ + BAR = 0, + BAZ = 1, + QUZ = 2, + QUX = 3 +}; + +struct bitt +{ + enum foo f : 2; + unsigned data : 14; +} bitty; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-4.c b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-4.c new file mode 100644 index 00000000000..af91845726f --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-bitfields-4.c @@ -0,0 +1,23 @@ +/* Test BTF generation for non-representable bitfields. + + Due to the limitations of BTF, we only have 24 bits in which to store + the bitfield offset (in bits, from the beginning of the struct). + + In this test, we construct a structure such that the bitfield will have + an offset so large as to be unrepresentable in BTF. We expect that the + resulting BTF will describe the rest of the structure, ignoring the + non-representable bitfield. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Struct with 3 members and no bitfield (kind_flag not set). */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000003\[\t \]+\[^\n\]*btt_info" 1 } } */ + +struct bigly +{ + int a; + int b[((0xffffff + 1) / (8 * sizeof (int)))]; + unsigned unsup : 7; + char c; +} big; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-cvr-quals-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-cvr-quals-1.c new file mode 100644 index 00000000000..79e9f52a479 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-cvr-quals-1.c @@ -0,0 +1,52 @@ +/* Test BTF generation of BTF_KIND_{CONST,VOLATILE,RESTRICT} records. + + BTF const, volatile and restrict records are nameless type records pointing + to the type they modify. + + Types: + [1] int 'int' size=4U offset=0 bits=32 SIGNED + [2] const <anonymous> type=1 + [3] volatile <anonymous> type=1 + [4] const <anonymous> type=3 + [5] ptr <anonymous> type=1 + [6] restrict <anonymous> type=5 + [7] ptr <anonymous> type=2 + [8] restrict <anonymous> type=7 + + Note: + - Type id 3 describes a volatile int. + - Type id 2 describes a const int. + - Type id 4 describes a const volatile int by modifying id 3. + - Type id 6 describes a restrict pointer to int. + - Type id 8 describes a restrict pointer to const int. + */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "ascii \"int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ + +/* types 5 and 7 are pointers, to 'int' and 'const int' respectively. */ +/* { dg-final { scan-assembler-times "\[\t \]0x2000000\[\t \]+\[^\n\]*btt_info" 2 } } */ + +/* type 3 has VOLATILE qualifier */ +/* { dg-final { scan-assembler-times "\[\t \]0x9000000\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* types 2 and 4 have CONST qualifier. */ +/* { dg-final { scan-assembler-times "\[\t \]0xa000000\[\t \]+\[^\n\]*btt_info" 2 } } */ + +/* types 6 and 8 have RESTRICT qualifier. */ +/* { dg-final { scan-assembler-times "\[\t \]0xb000000\[\t \]+\[^\n\]*btt_info" 2 } } */ + +const int a = 10; + +volatile int b; + +int * restrict c; + +const volatile int d = 20; + +const int * restrict e; + +const int * f; +int const * g; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c new file mode 100644 index 00000000000..88ae4c4edfd --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c @@ -0,0 +1,45 @@ +/* BTF generation of BTF_KIND_DATASEC records. + + We expect 3 DATASEC records: one for each of .data, .rodata and .bss. + .rodata: the consts; c,e,my_cstruct + .bss: a,b,bigarr + .data: d + + The type IDs of the variables placed in each section are not deterministic + so we cannot check them. + */ + +/* { dg-do compile ) */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Check for two DATASEC entries with vlen 3, and one with vlen 1. */ +/* { dg-final { scan-assembler-times "0xf000003\[\t \]+\[^\n\]*btt_info" 2 } } */ +/* { dg-final { scan-assembler-times "0xf000001\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* The offset entry for each variable in a DATSEC should be 0 at compile time. */ +/* { dg-final { scan-assembler-times "0\[\t \]+\[^\n\]*bts_offset" 7 } } */ + +/* Check that strings for each DATASEC have been added to the BTF string table. */ +/* { dg-final { scan-assembler-times "ascii \".data.0\"\[\t \]+\[^\n\]*btf_aux_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \".rodata.0\"\[\t \]+\[^\n\]*btf_aux_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \".bss.0\"\[\t \]+\[^\n\]*btf_aux_string" 1 } } */ + +int a; +long long b; +const long unsigned int c; + +int d = 137; + +const int e = -55; + +int bigarr[20][10]; + +struct c_struct { + long x; + char c; +}; + +const struct c_struct my_cstruct = { + 99, + '?' +}; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c new file mode 100644 index 00000000000..728493b0804 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-enum-1.c @@ -0,0 +1,30 @@ +/* Test BTF generation for enums. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x6000004\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x6000003\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"QAD.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"QED.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"QOD.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"QUD.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"YES.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"NO.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"IDUNNO.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "bte_value" 7 } } */ + +enum foo +{ + QAD, + QED, + QOD, + QUD, +} a; + +enum barsigned +{ + YES=1000, + NO=-1000, + IDUNNO=0, +} b; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-forward-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-forward-1.c new file mode 100644 index 00000000000..c894fa26bc7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-forward-1.c @@ -0,0 +1,24 @@ +/* Test BTF generation of forwards. + + Check that the KIND_FLAG (bit 31) of btt_info is set (1) for the forward to + union, and not set (0) for forward to struct. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x87000000\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x7000000\[\t \]+\[^\n\]*btt_info" 1 } } */ + +typedef struct _fwd_st +{ + struct unk_struct_type *data[4]; +} fwd_st_t; + +fwd_st_t struct_container; + +typedef struct _fwd_un +{ + union unk_union_type *options[4]; +} fwd_un_t; + +fwd_un_t union_container; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-function-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-function-1.c new file mode 100644 index 00000000000..9fa1498bd8e --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-function-1.c @@ -0,0 +1,18 @@ +/* Test BTF generation for functions. + + We expect to see one BTF_KIND_FUNC_PROTO with 2 named arguments. + The parameter names should appear in the auxilliary string table. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0xd000002\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "farg_name" 2 } } */ +/* { dg-final { scan-assembler-times "farg_type" 2 } } */ +/* { dg-final { scan-assembler-times "ascii \"alpha.0\"\[\t \]+\[^\n\]*btf_aux_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"bravo.0\"\[\t \]+\[^\n\]*btf_aux_string" 1 } } */ + +int funfoo (int alpha, long bravo) +{ + return 0; +} diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-function-2.c b/gcc/testsuite/gcc.dg/debug/btf/btf-function-2.c new file mode 100644 index 00000000000..3c7fda9ee35 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-function-2.c @@ -0,0 +1,18 @@ +/* Test BTF generation for functions with varargs. + + We expect one BTF_KIND_FUNC_PROTO with two arguments. The second argument + should have "farg_name" and "farg_type" both of 0, representing varargs. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0xd000002\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "farg_name" 2 } } */ +/* { dg-final { scan-assembler-times "farg_type" 2 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*farg_name" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*farg_type" 1 } } */ + +int fmt (const char * format, ...) +{ + return 0; +} diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-function-3.c b/gcc/testsuite/gcc.dg/debug/btf/btf-function-3.c new file mode 100644 index 00000000000..35f96a2152c --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-function-3.c @@ -0,0 +1,22 @@ +/* Test BTF generation for a function with an unrepresentable parameter. + + BTF has no encoding for floating point types, among others. Function + parameters of unrepresentable types are emitted as 'void' types. + + We expect one BTF_KIND_FUNC_PROTO with 3 parameters, one of which + has type_id=0. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0xd000003\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "farg_name" 3 } } */ +/* { dg-final { scan-assembler-times "farg_type" 3 } } */ + +/* Exactly one function parameter should have type_id=0. */ +/* { dg-final { scan-assembler-times "\[\t \]0\[\t \]+\[^\n\]*farg_type" 1 } } */ + +int foo (int a, float f, long b) +{ + return 0; +} diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-int-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-int-1.c new file mode 100644 index 00000000000..2381decd6ff --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-int-1.c @@ -0,0 +1,44 @@ +/* Tests for BTF integer base types. + + 0 f ff 00 ff + | 0 | encoding | offset | 00 | bits | + encoding: + signed 1 << 24 + char 2 << 24 + + All offsets in this test should be 0. + This test does _not_ check number of bits, as it may vary between targets. + */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Check for 8 BTF_KIND_INT types. */ +/* { dg-final { scan-assembler-times "\[\t \]0x1000000\[\t \]+\[^\n\]*btt_info" 8 } } */ + +/* Check the signed/char flags, but not bit size. */ +/* { dg-final { scan-assembler-times "\[\t \]0x10000..\[\t \]+\[^\n\]*bti_encoding" 3 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x20000..\[\t \]+\[^\n\]*bti_encoding" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x30000..\[\t \]+\[^\n\]*bti_encoding" 1 } } */ + +/* Check that there is a string entry for each type name. */ +/* { dg-final { scan-assembler-times "ascii \"unsigned char.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"signed char.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"short unsigned int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"short int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"unsigned int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"long unsigned int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"long int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ + +unsigned char a = 11; +signed char b = -22; + +unsigned short c = 33; +signed short d = 44; + +unsigned int e = 55; +signed int f = -66; + +unsigned long int g = 77; +signed long int h = 88; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-1.c new file mode 100644 index 00000000000..a14ac0f89b2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-1.c @@ -0,0 +1,25 @@ +/* Test BTF generation for pointer types. + + Two pointer types are expected: + - int * + - struct st * + */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x2000000\[\t \]+\[^\n\]*btt_info" 2 } } */ +/* { dg-final { scan-assembler-times "ascii \"int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"st.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ + +int foo = 10; +int *pfoo = &foo; + +struct st +{ + int a; + int *pb; + struct st * next; +}; + +struct st * bar; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-2.c b/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-2.c new file mode 100644 index 00000000000..c77b224d711 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-pointers-2.c @@ -0,0 +1,13 @@ +/* Test BTF generation for pointers to void. + + In this test, we expect that the pointer references type ID 0, the reserved + void typeid, and that no intermediate type is generated for void. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x2000000\[\t \]+\[^\n\]*btt_info" 1 } } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x1000000\[\t \]+\[^\n\]*btt_info" 0 } } */ + +void *ptr; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-struct-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-struct-1.c new file mode 100644 index 00000000000..bc3281437c9 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-struct-1.c @@ -0,0 +1,22 @@ +/* Test BTF generation of struct type. + + Two BTF_KIND_STRUCT records are expected. + - struct foo with 3 members + - struct data with 2 members */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x4000003\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000002\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "btm_name" 5 } } */ + +struct foo +{ + int after; + int before; + struct { + unsigned short n_valid; + int set[10]; + } data; +} my_foo; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-struct-2.c b/gcc/testsuite/gcc.dg/debug/btf/btf-struct-2.c new file mode 100644 index 00000000000..24514fcb31e --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-struct-2.c @@ -0,0 +1,19 @@ +/* Test BTF generation for struct type with a member which refers to an + unsupported type. + + BTF does not support floating point types (among other things). When + generating BTF for a struct (or union) type, members which refer to + unsupported types should be skipped. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* Expect a struct with only 2 members - 'f' should not be present. */ +/* { dg-final { scan-assembler-times "\[\t \]0x4000002\[\t \]+\[^\n\]*btt_info" 1 } } */ + +struct with_float +{ + int a; + float f; + char c; +} instance; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-typedef-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-typedef-1.c new file mode 100644 index 00000000000..472cc63f600 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-typedef-1.c @@ -0,0 +1,82 @@ +/* Test BTF generation for BTF_KIND_TYPEDEF records. + + 7 typedef records are expected. We expect the following types (among others): + [1] int 'int' size=4 offset=0 bits=32 SIGNED + [2] typedef 'my_int' type=1 + [3] typedef 'foo_int' type=1 + [4] typedef 'bar_int' type=1 + .. + [6] typedef 'CBAR' type=5 + .. + [8] typedef 'CBARP' type=7 + [9] struct '_node' size=16 + .. + [11] typedef 'node_t' type=9 + [12] struct '_arena' + .. + [15] typedef 'arena_t' type=12 + [16] var 'a' type=2 linkage=1 (global) + [17] var 'suitcase' type=15 linkage=1 (global) + [18] var 'b' type=3 linkage=1 (global) + [19] var 'c' type=4 linkage=1 (global) + [20] var 'd' type=11 linkage=1 (global) + [21] var 'destination' type=6 linkage=1 (global) + [22] var 'ticket' type=8 linkage=1 (global) + + Note that the order of the variables is not guaranteed, so we do not check + particular variables have exactly the right typedef. Instead, we check: + 1. 7 typedef records are generated, along with the correct strings for them. + 2. There is one variable pointing to each typedef. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x8000000\[\t \]+\[^\n\]*btt_info" 7 } } */ + +/* { dg-final { scan-assembler-times "ascii \"my_int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"foo_int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"bar_int.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"CBAR.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"CBARP.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"node_t.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ +/* { dg-final { scan-assembler-times "ascii \"arena_t.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ + +/* { dg-final { scan-assembler-times "\[\t \]0x2\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x3\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x4\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x6\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0x8\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0xb\[\t \]+\[^\n\]*btv_type" 1 } } */ +/* { dg-final { scan-assembler-times "\[\t \]0xf\[\t \]+\[^\n\]*btv_type" 1 } } */ + +typedef int my_int; +typedef int foo_int; +typedef int bar_int; + +typedef const bar_int CBAR; +typedef const bar_int * CBARP; + +typedef struct _node +{ + foo_int name_off; + bar_int info; + struct _node * next; +} node_t; + + +typedef struct _arena +{ + node_t nodes[16]; + my_int vardata; + bar_int flags; +} arena_t; + +my_int a; +foo_int b; +bar_int c; +node_t d; + +CBAR destination; +CBARP ticket = &destination; + +arena_t suitcase; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-union-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-union-1.c new file mode 100644 index 00000000000..d66843717b3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-union-1.c @@ -0,0 +1,16 @@ +/* Test BTF generation for union type. */ + +/* { dg-do compile ) */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* One union type with 4 members */ +/* { dg-final { scan-assembler-times "\[\t \]0x5000004\[\t \]+\[^\n\]*btt_info" 1 } } */ +/* { dg-final { scan-assembler-times "btm_name" 4 } } */ + +union onion +{ + int redness; + char *name; + unsigned short freshness; + unsigned short flavor; +} my_onion; diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-variables-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-variables-1.c new file mode 100644 index 00000000000..a79ed1d53b7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-variables-1.c @@ -0,0 +1,33 @@ +/* BTF generation for variables. */ + +/* { dg-do compile } */ +/* { dg-options "-O0 -gbtf -dA" } */ + +/* We expect 6 variables */ +/* { dg-final { scan-assembler-times "\[\t \]0xe000000\[\t \]+\[^\n\]*btv_info" 6 } } */ + +unsigned int x1; + +struct st +{ + int a; + int b; +}; + +union { + long int value; + struct st * pointer; +} bar; + </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-release-arm-spec2k6-O3 - Build # 24 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-O3 Culprit: <cut> commit a20f263ba1a76af40eb4e6734529739a2a30ed65 Author: Jan Hubicka <hubicka(a)ucw.cz> Date: Sun Jul 14 13:57:10 2019 +0200 ipa-fnsummary.c (ipa_dump_hints): Do not dump array_index. * ipa-fnsummary.c (ipa_dump_hints): Do not dump array_index. (ipa_fn_summary::~ipa_fn_summary): Do not destroy array_index. (ipa_fn_summary_t::duplicate): Do not duplicate array_index. (array_index_predicate): Remove. (analyze_function_body): Account cost for variable ofsetted array indexing. (estimate_node_size_and_time): Do not compute array index hint. (ipa_merge_fn_summary_after_inlining): Do not merge array index hint. (inline_read_section): Do not read array index hint. (ipa_fn_summary_write): Do not write array index hint. * doc/invoke.texi (ipa-cp-array-index-hint-bonus): Remove. * ipa-cp.c (hint_time_bonus): Remove. * ipa-fnsummary.h (ipa_hints_vals): Remove array_index. (ipa_fnsummary): Remove array_index. * ipa-inline.c (want_inline_small_function_p): Do not use array_index. (edge_badness): Likewise. * params.def (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS): Remove. From-SVN: r273479 </cut> Results regressed to (for first_bad == a20f263ba1a76af40eb4e6734529739a2a30ed65) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_marm -- artifacts/build-a20f263ba1a76af40eb4e6734529739a2a30ed65/results_id: 1 # 410.bwaves,[.] mat_times_vec_ regressed by 195 from (for last_good == d67dfb85ba4f89f5f3045f2483005c290bc18108) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O3_marm -- artifacts/build-d67dfb85ba4f89f5f3045f2483005c290bc18108/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3/753 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-O3/758 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-a20f263ba1a76af40eb4e6734529739a2a30ed65 cd investigate-gcc-a20f263ba1a76af40eb4e6734529739a2a30ed65 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach a20f263ba1a76af40eb4e6734529739a2a30ed65 ../artifacts/test.sh # Reproduce last_good build git checkout --detach d67dfb85ba4f89f5f3045f2483005c290bc18108 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… Full commit (up to 1000 lines): <cut> commit a20f263ba1a76af40eb4e6734529739a2a30ed65 Author: Jan Hubicka <hubicka(a)ucw.cz> Date: Sun Jul 14 13:57:10 2019 +0200 ipa-fnsummary.c (ipa_dump_hints): Do not dump array_index. * ipa-fnsummary.c (ipa_dump_hints): Do not dump array_index. (ipa_fn_summary::~ipa_fn_summary): Do not destroy array_index. (ipa_fn_summary_t::duplicate): Do not duplicate array_index. (array_index_predicate): Remove. (analyze_function_body): Account cost for variable ofsetted array indexing. (estimate_node_size_and_time): Do not compute array index hint. (ipa_merge_fn_summary_after_inlining): Do not merge array index hint. (inline_read_section): Do not read array index hint. (ipa_fn_summary_write): Do not write array index hint. * doc/invoke.texi (ipa-cp-array-index-hint-bonus): Remove. * ipa-cp.c (hint_time_bonus): Remove. * ipa-fnsummary.h (ipa_hints_vals): Remove array_index. (ipa_fnsummary): Remove array_index. * ipa-inline.c (want_inline_small_function_p): Do not use array_index. (edge_badness): Likewise. * params.def (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS): Remove. From-SVN: r273479 --- gcc/ChangeLog | 21 ++++++++++ gcc/doc/invoke.texi | 6 --- gcc/ipa-cp.c | 2 - gcc/ipa-fnsummary.c | 109 +++++++++++++++------------------------------------- gcc/ipa-fnsummary.h | 11 ++---- gcc/ipa-inline.c | 3 -- gcc/params.def | 6 --- 7 files changed, 54 insertions(+), 104 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9376ab41542..9b5cc7a5b5b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,24 @@ +2019-07-14 Jan Hubicka <hubicka(a)ucw.cz> + + * ipa-fnsummary.c (ipa_dump_hints): Do not dump array_index. + (ipa_fn_summary::~ipa_fn_summary): Do not destroy array_index. + (ipa_fn_summary_t::duplicate): Do not duplicate array_index. + (array_index_predicate): Remove. + (analyze_function_body): Account cost for variable ofsetted array + indexing. + (estimate_node_size_and_time): Do not compute array index hint. + (ipa_merge_fn_summary_after_inlining): Do not merge array index hint. + (inline_read_section): Do not read array index hint. + (ipa_fn_summary_write): Do not write array index hint. + * doc/invoke.texi (ipa-cp-array-index-hint-bonus): Remove. + * ipa-cp.c (hint_time_bonus): Remove. + * ipa-fnsummary.h (ipa_hints_vals): Remove array_index. + (ipa_fnsummary): Remove array_index. + * ipa-inline.c (want_inline_small_function_p): Do not use + array_index. + (edge_badness): Likewise. + * params.def (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS): Remove. + 2019-07-14 Segher Boessenkool <segher(a)kernel.crashing.org> PR target/91148 diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index b4e71f2c8fd..758aef36bd8 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -11895,12 +11895,6 @@ of iterations of a loop known, it adds a bonus of @option{ipa-cp-loop-hint-bonus} to the profitability score of the candidate. -@item ipa-cp-array-index-hint-bonus -When IPA-CP determines that a cloning candidate would make the index of -an array access known, it adds a bonus of -@option{ipa-cp-array-index-hint-bonus} to the profitability -score of the candidate. - @item ipa-max-aa-steps During its analysis of function bodies, IPA-CP employs alias analysis in order to track values pointed to by function parameters. In order diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 0fd36506c00..b20a6d08794 100644 --- a/gcc/ipa-cp.c +++ b/gcc/ipa-cp.c @@ -2607,8 +2607,6 @@ hint_time_bonus (ipa_hints hints) int result = 0; if (hints & (INLINE_HINT_loop_iterations | INLINE_HINT_loop_stride)) result += PARAM_VALUE (PARAM_IPA_CP_LOOP_HINT_BONUS); - if (hints & INLINE_HINT_array_index) - result += PARAM_VALUE (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS); return result; } diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c index 09986211a1d..78eb8cb6f50 100644 --- a/gcc/ipa-fnsummary.c +++ b/gcc/ipa-fnsummary.c @@ -134,11 +134,6 @@ ipa_dump_hints (FILE *f, ipa_hints hints) hints &= ~INLINE_HINT_declared_inline; fprintf (f, " declared_inline"); } - if (hints & INLINE_HINT_array_index) - { - hints &= ~INLINE_HINT_array_index; - fprintf (f, " array_index"); - } if (hints & INLINE_HINT_known_hot) { hints &= ~INLINE_HINT_known_hot; @@ -549,8 +544,6 @@ ipa_fn_summary::~ipa_fn_summary () edge_predicate_pool.remove (loop_iterations); if (loop_stride) edge_predicate_pool.remove (loop_stride); - if (array_index) - edge_predicate_pool.remove (array_index); vec_free (conds); vec_free (size_time_table); } @@ -703,8 +696,6 @@ ipa_fn_summary_t::duplicate (cgraph_node *src, possible_truths); remap_hint_predicate_after_duplication (&info->loop_stride, possible_truths); - remap_hint_predicate_after_duplication (&info->array_index, - possible_truths); /* If inliner or someone after inliner will ever start producing non-trivial clones, we will get trouble with lack of information @@ -727,12 +718,6 @@ ipa_fn_summary_t::duplicate (cgraph_node *src, info->loop_stride = NULL; set_hint_predicate (&info->loop_stride, p); } - if (info->array_index) - { - predicate p = *info->array_index; - info->array_index = NULL; - set_hint_predicate (&info->array_index, p); - } } if (!dst->global.inlined_to) ipa_update_overall_fn_summary (dst); @@ -894,11 +879,6 @@ ipa_dump_fn_summary (FILE *f, struct cgraph_node *node) fprintf (f, " loop stride:"); s->loop_stride->dump (f, s->conds); } - if (s->array_index) - { - fprintf (f, " array index:"); - s->array_index->dump (f, s->conds); - } fprintf (f, " calls:\n"); dump_ipa_call_summary (f, 4, node, s); fprintf (f, "\n"); @@ -1824,27 +1804,6 @@ predicate_for_phi_result (class ipa_fn_summary *summary, gphi *phi, nonconstant_names[SSA_NAME_VERSION (gimple_phi_result (phi))] = *p; } -/* Return predicate specifying when array index in access OP becomes non-constant. */ - -static predicate -array_index_predicate (ipa_fn_summary *info, - vec< predicate> nonconstant_names, tree op) -{ - predicate p = false; - while (handled_component_p (op)) - { - if (TREE_CODE (op) == ARRAY_REF || TREE_CODE (op) == ARRAY_RANGE_REF) - { - if (TREE_CODE (TREE_OPERAND (op, 1)) == SSA_NAME) - p = p.or_with (info->conds, - nonconstant_names[SSA_NAME_VERSION - (TREE_OPERAND (op, 1))]); - } - op = TREE_OPERAND (op, 0); - } - return p; -} - /* For a typical usage of __builtin_expect (a<b, 1), we may introduce an extra relation stmt: With the builtin, we have @@ -2001,7 +1960,6 @@ analyze_function_body (struct cgraph_node *node, bool early) vec<predicate> nonconstant_names = vNULL; int nblocks, n; int *order; - predicate array_index = true; gimple *fix_builtin_expect_stmt; gcc_assert (my_function && my_function->cfg); @@ -2146,26 +2104,6 @@ analyze_function_body (struct cgraph_node *node, bool early) this_time); } - if (gimple_assign_load_p (stmt) && nonconstant_names.exists ()) - { - predicate this_array_index; - this_array_index = - array_index_predicate (info, nonconstant_names, - gimple_assign_rhs1 (stmt)); - if (this_array_index != false) - array_index &= this_array_index; - } - if (gimple_store_p (stmt) && nonconstant_names.exists ()) - { - predicate this_array_index; - this_array_index = - array_index_predicate (info, nonconstant_names, - gimple_get_lhs (stmt)); - if (this_array_index != false) - array_index &= this_array_index; - } - - if (is_gimple_call (stmt) && !gimple_call_internal_p (stmt)) { @@ -2273,14 +2211,40 @@ analyze_function_body (struct cgraph_node *node, bool early) if (dump_file) fprintf (dump_file, " fp_expression set\n"); } + } - gcc_assert (time >= 0); - gcc_assert (size >= 0); + /* Account cost of address calculations in the statements. */ + for (unsigned int i = 0; i < gimple_num_ops (stmt); i++) + { + for (tree op = gimple_op (stmt, i); + op && handled_component_p (op); + op = TREE_OPERAND (op, 0)) + if ((TREE_CODE (op) == ARRAY_REF + || TREE_CODE (op) == ARRAY_RANGE_REF) + && TREE_CODE (TREE_OPERAND (op, 1)) == SSA_NAME) + { + predicate p = bb_predicate; + if (fbi.info) + p = p & will_be_nonconstant_expr_predicate + (&fbi, info, TREE_OPERAND (op, 1), + nonconstant_names); + if (p != false) + { + time += freq; + size += 1; + if (dump_file) + fprintf (dump_file, + "\t\tAccounting address calculation.\n"); + info->account_size_time (ipa_fn_summary::size_scale, + freq, + bb_predicate, + p); + } + } } + } } - set_hint_predicate (&ipa_fn_summaries->get_create (node)->array_index, - array_index); free (order); if (nonconstant_names.exists () && !early) @@ -2783,9 +2747,6 @@ estimate_node_size_and_time (struct cgraph_node *node, if (info->loop_stride && !info->loop_stride->evaluate (possible_truths)) hints |= INLINE_HINT_loop_stride; - if (info->array_index - && !info->array_index->evaluate (possible_truths)) - hints |= INLINE_HINT_array_index; if (info->scc_no) hints |= INLINE_HINT_in_scc; if (DECL_DECLARED_INLINE_P (node->decl)) @@ -3106,9 +3067,6 @@ ipa_merge_fn_summary_after_inlining (struct cgraph_edge *edge) remap_hint_predicate (info, callee_info, &callee_info->loop_stride, operand_map, offset_map, clause, &toplev_predicate); - remap_hint_predicate (info, callee_info, - &callee_info->array_index, - operand_map, offset_map, clause, &toplev_predicate); ipa_call_summary *s = ipa_call_summaries->get (edge); inline_update_callee_summaries (edge->callee, s->loop_depth); @@ -3366,9 +3324,6 @@ inline_read_section (struct lto_file_decl_data *file_data, const char *data, p.stream_in (&ib); if (info) set_hint_predicate (&info->loop_stride, p); - p.stream_in (&ib); - if (info) - set_hint_predicate (&info->array_index, p); for (e = node->callees; e; e = e->next_callee) read_ipa_call_summary (&ib, e, info != NULL); for (e = node->indirect_calls; e; e = e->next_callee) @@ -3517,10 +3472,6 @@ ipa_fn_summary_write (void) info->loop_stride->stream_out (ob); else streamer_write_uhwi (ob, 0); - if (info->array_index) - info->array_index->stream_out (ob); - else - streamer_write_uhwi (ob, 0); for (edge = cnode->callees; edge; edge = edge->next_callee) write_ipa_call_summary (ob, edge); for (edge = cnode->indirect_calls; edge; edge = edge->next_callee) diff --git a/gcc/ipa-fnsummary.h b/gcc/ipa-fnsummary.h index 55bc34146aa..173d3f2a652 100644 --- a/gcc/ipa-fnsummary.h +++ b/gcc/ipa-fnsummary.h @@ -48,11 +48,8 @@ enum ipa_hints_vals { if functions are in different modules, inlining may not be so important. Set by simple_edge_hints in ipa-inline-analysis.c. */ INLINE_HINT_cross_module = 64, - /* If array indexes of loads/stores become known there may be room for - further optimization. */ - INLINE_HINT_array_index = 128, /* We know that the callee is hot by profile. */ - INLINE_HINT_known_hot = 256 + INLINE_HINT_known_hot = 128 }; typedef int ipa_hints; @@ -97,7 +94,7 @@ public: fp_expressions (false), estimated_stack_size (false), stack_frame_offset (false), time (0), size (0), conds (NULL), size_time_table (NULL), loop_iterations (NULL), loop_stride (NULL), - array_index (NULL), growth (0), scc_no (0) + growth (0), scc_no (0) { } @@ -111,7 +108,7 @@ public: stack_frame_offset (s.stack_frame_offset), time (s.time), size (s.size), conds (s.conds), size_time_table (s.size_time_table), loop_iterations (s.loop_iterations), loop_stride (s.loop_stride), - array_index (s.array_index), growth (s.growth), scc_no (s.scc_no) + growth (s.growth), scc_no (s.scc_no) {} /* Default constructor. */ @@ -157,8 +154,6 @@ public: /* Predicate on when some loop in the function becomes to have known stride. */ predicate * GTY((skip)) loop_stride; - /* Predicate on when some array indexes become constants. */ - predicate * GTY((skip)) array_index; /* Estimated growth for inlining all copies of the function before start of small functions inlining. This value will get out of date as the callers are duplicated, but diff --git a/gcc/ipa-inline.c b/gcc/ipa-inline.c index 939d86ef94a..e73006662ad 100644 --- a/gcc/ipa-inline.c +++ b/gcc/ipa-inline.c @@ -807,7 +807,6 @@ want_inline_small_function_p (struct cgraph_edge *e, bool report) || (!(hints & (INLINE_HINT_indirect_call | INLINE_HINT_known_hot | INLINE_HINT_loop_iterations - | INLINE_HINT_array_index | INLINE_HINT_loop_stride)) && !(big_speedup = big_speedup_p (e))))) { @@ -833,7 +832,6 @@ want_inline_small_function_p (struct cgraph_edge *e, bool report) && !(hints & INLINE_HINT_known_hot) && growth >= ((hints & (INLINE_HINT_indirect_call | INLINE_HINT_loop_iterations - | INLINE_HINT_array_index | INLINE_HINT_loop_stride)) ? MAX (MAX_INLINE_INSNS_AUTO, MAX_INLINE_INSNS_SINGLE) @@ -1227,7 +1225,6 @@ edge_badness (struct cgraph_edge *edge, bool dump) badness = badness.shift (badness > 0 ? 4 : -4); if ((hints & (INLINE_HINT_indirect_call | INLINE_HINT_loop_iterations - | INLINE_HINT_array_index | INLINE_HINT_loop_stride)) || callee_info->growth <= 0) badness = badness.shift (badness > 0 ? -2 : 2); diff --git a/gcc/params.def b/gcc/params.def index c56055da9d9..7d0dcae0aee 100644 --- a/gcc/params.def +++ b/gcc/params.def @@ -1109,12 +1109,6 @@ DEFPARAM (PARAM_IPA_CP_LOOP_HINT_BONUS, "bounds or strides known.", 64, 0, 0) -DEFPARAM (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS, - "ipa-cp-array-index-hint-bonus", - "Compile-time bonus IPA-CP assigns to candidates which make an array " - "index known.", - 48, 0, 0) - DEFPARAM (PARAM_IPA_MAX_AA_STEPS, "ipa-max-aa-steps", "Maximum number of statements that will be visited by IPA formal " </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-release-aarch64-spec2k6-Oz - Build # 8 - Fixed!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-Oz. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-release-aarch64-spec2k6-Oz Culprit: <cut> commit 4b1120159274ca98b4a58064b116aba88372ac98 Author: Michael Liao <michael.hliao(a)gmail.com> Date: Mon Oct 12 10:01:40 2020 -0400 [MachineInstr] Add support for instructions with multiple memory operands. - Basically iterate each pair of memory operands from both instructions and return true if any of them may alias. - The exception are memory instructions without any memory operand. They may touch everything and could alias to any memory instruction. Differential Revision: https://reviews.llvm.org/D89447 </cut> Results regressed to (for first_bad == 4b1120159274ca98b4a58064b116aba88372ac98) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz -- artifacts/build-4b1120159274ca98b4a58064b116aba88372ac98/results_id: 1 # 445.gobmk,[.] do_play_move regressed by 111 from (for last_good == cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz -- artifacts/build-cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-Oz/744 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-release-aarch64-spec2k6-Oz/734 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-4b1120159274ca98b4a58064b116aba88372ac98 cd investigate-llvm-4b1120159274ca98b4a58064b116aba88372ac98 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 4b1120159274ca98b4a58064b116aba88372ac98 ../artifacts/test.sh # Reproduce last_good build git checkout --detach cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-release… Full commit (up to 1000 lines): <cut> commit 4b1120159274ca98b4a58064b116aba88372ac98 Author: Michael Liao <michael.hliao(a)gmail.com> Date: Mon Oct 12 10:01:40 2020 -0400 [MachineInstr] Add support for instructions with multiple memory operands. - Basically iterate each pair of memory operands from both instructions and return true if any of them may alias. - The exception are memory instructions without any memory operand. They may touch everything and could alias to any memory instruction. Differential Revision: https://reviews.llvm.org/D89447 --- llvm/include/llvm/CodeGen/TargetInstrInfo.h | 15 +++ llvm/lib/CodeGen/MachineInstr.cpp | 145 ++++++++++++--------- .../test/CodeGen/AArch64/merge-store-dependency.ll | 4 +- .../CodeGen/ARM/big-endian-neon-fp16-bitconv.ll | 4 +- llvm/test/CodeGen/Thumb2/mve-float32regloops.ll | 8 +- llvm/test/CodeGen/Thumb2/mve-phireg.ll | 10 +- llvm/test/CodeGen/Thumb2/mve-vst3.ll | 2 +- .../Thumb2/umulo-128-legalisation-lowering.ll | 8 +- llvm/test/CodeGen/X86/store_op_load_fold2.ll | 11 +- 9 files changed, 118 insertions(+), 89 deletions(-) diff --git a/llvm/include/llvm/CodeGen/TargetInstrInfo.h b/llvm/include/llvm/CodeGen/TargetInstrInfo.h index 5d5a6efab220..68fc129cc0ed 100644 --- a/llvm/include/llvm/CodeGen/TargetInstrInfo.h +++ b/llvm/include/llvm/CodeGen/TargetInstrInfo.h @@ -1737,6 +1737,21 @@ public: return 5; } + /// Return the maximal number of alias checks on memory operands. For + /// instructions with more than one memory operands, the alias check on a + /// single MachineInstr pair has quadratic overhead and results in + /// unacceptable performance in the worst case. The limit here is to clamp + /// that maximal checks performed. Usually, that's the product of memory + /// operand numbers from that pair of MachineInstr to be checked. For + /// instance, with two MachineInstrs with 4 and 5 memory operands + /// correspondingly, a total of 20 checks are required. With this limit set to + /// 16, their alias check is skipped. We choose to limit the product instead + /// of the individual instruction as targets may have special MachineInstrs + /// with a considerably high number of memory operands, such as `ldm` in ARM. + /// Setting this limit per MachineInstr would result in either too high + /// overhead or too rigid restriction. + virtual unsigned getMemOperandAACheckLimit() const { return 16; } + /// Return an array that contains the ids of the target indices (used for the /// TargetIndex machine operand) and their names. /// diff --git a/llvm/lib/CodeGen/MachineInstr.cpp b/llvm/lib/CodeGen/MachineInstr.cpp index d45c53b81816..fd658cdb41b9 100644 --- a/llvm/lib/CodeGen/MachineInstr.cpp +++ b/llvm/lib/CodeGen/MachineInstr.cpp @@ -1276,81 +1276,96 @@ bool MachineInstr::mayAlias(AAResults *AA, const MachineInstr &Other, if (TII->areMemAccessesTriviallyDisjoint(*this, Other)) return false; - // FIXME: Need to handle multiple memory operands to support all targets. - if (!hasOneMemOperand() || !Other.hasOneMemOperand()) + // Memory operations without memory operands may access anything. Be + // conservative and assume `MayAlias`. + if (memoperands_empty() || Other.memoperands_empty()) return true; - MachineMemOperand *MMOa = *memoperands_begin(); - MachineMemOperand *MMOb = *Other.memoperands_begin(); - - // The following interface to AA is fashioned after DAGCombiner::isAlias - // and operates with MachineMemOperand offset with some important - // assumptions: - // - LLVM fundamentally assumes flat address spaces. - // - MachineOperand offset can *only* result from legalization and - // cannot affect queries other than the trivial case of overlap - // checking. - // - These offsets never wrap and never step outside - // of allocated objects. - // - There should never be any negative offsets here. - // - // FIXME: Modify API to hide this math from "user" - // Even before we go to AA we can reason locally about some - // memory objects. It can save compile time, and possibly catch some - // corner cases not currently covered. - - int64_t OffsetA = MMOa->getOffset(); - int64_t OffsetB = MMOb->getOffset(); - int64_t MinOffset = std::min(OffsetA, OffsetB); - - uint64_t WidthA = MMOa->getSize(); - uint64_t WidthB = MMOb->getSize(); - bool KnownWidthA = WidthA != MemoryLocation::UnknownSize; - bool KnownWidthB = WidthB != MemoryLocation::UnknownSize; - - const Value *ValA = MMOa->getValue(); - const Value *ValB = MMOb->getValue(); - bool SameVal = (ValA && ValB && (ValA == ValB)); - if (!SameVal) { - const PseudoSourceValue *PSVa = MMOa->getPseudoValue(); - const PseudoSourceValue *PSVb = MMOb->getPseudoValue(); - if (PSVa && ValB && !PSVa->mayAlias(&MFI)) - return false; - if (PSVb && ValA && !PSVb->mayAlias(&MFI)) - return false; - if (PSVa && PSVb && (PSVa == PSVb)) - SameVal = true; - } + // Skip if there are too many memory operands. + auto NumChecks = getNumMemOperands() * Other.getNumMemOperands(); + if (NumChecks > TII->getMemOperandAACheckLimit()) + return true; + + auto HasAlias = [MFI, AA, UseTBAA](const MachineMemOperand *MMOa, + const MachineMemOperand *MMOb) { + // The following interface to AA is fashioned after DAGCombiner::isAlias + // and operates with MachineMemOperand offset with some important + // assumptions: + // - LLVM fundamentally assumes flat address spaces. + // - MachineOperand offset can *only* result from legalization and + // cannot affect queries other than the trivial case of overlap + // checking. + // - These offsets never wrap and never step outside + // of allocated objects. + // - There should never be any negative offsets here. + // + // FIXME: Modify API to hide this math from "user" + // Even before we go to AA we can reason locally about some + // memory objects. It can save compile time, and possibly catch some + // corner cases not currently covered. + + int64_t OffsetA = MMOa->getOffset(); + int64_t OffsetB = MMOb->getOffset(); + int64_t MinOffset = std::min(OffsetA, OffsetB); + + uint64_t WidthA = MMOa->getSize(); + uint64_t WidthB = MMOb->getSize(); + bool KnownWidthA = WidthA != MemoryLocation::UnknownSize; + bool KnownWidthB = WidthB != MemoryLocation::UnknownSize; + + const Value *ValA = MMOa->getValue(); + const Value *ValB = MMOb->getValue(); + bool SameVal = (ValA && ValB && (ValA == ValB)); + if (!SameVal) { + const PseudoSourceValue *PSVa = MMOa->getPseudoValue(); + const PseudoSourceValue *PSVb = MMOb->getPseudoValue(); + if (PSVa && ValB && !PSVa->mayAlias(&MFI)) + return false; + if (PSVb && ValA && !PSVb->mayAlias(&MFI)) + return false; + if (PSVa && PSVb && (PSVa == PSVb)) + SameVal = true; + } + + if (SameVal) { + if (!KnownWidthA || !KnownWidthB) + return true; + int64_t MaxOffset = std::max(OffsetA, OffsetB); + int64_t LowWidth = (MinOffset == OffsetA) ? WidthA : WidthB; + return (MinOffset + LowWidth > MaxOffset); + } - if (SameVal) { - if (!KnownWidthA || !KnownWidthB) + if (!AA) return true; - int64_t MaxOffset = std::max(OffsetA, OffsetB); - int64_t LowWidth = (MinOffset == OffsetA) ? WidthA : WidthB; - return (MinOffset + LowWidth > MaxOffset); - } - if (!AA) - return true; + if (!ValA || !ValB) + return true; - if (!ValA || !ValB) - return true; + assert((OffsetA >= 0) && "Negative MachineMemOperand offset"); + assert((OffsetB >= 0) && "Negative MachineMemOperand offset"); - assert((OffsetA >= 0) && "Negative MachineMemOperand offset"); - assert((OffsetB >= 0) && "Negative MachineMemOperand offset"); + int64_t OverlapA = KnownWidthA ? WidthA + OffsetA - MinOffset + : MemoryLocation::UnknownSize; + int64_t OverlapB = KnownWidthB ? WidthB + OffsetB - MinOffset + : MemoryLocation::UnknownSize; - int64_t OverlapA = KnownWidthA ? WidthA + OffsetA - MinOffset - : MemoryLocation::UnknownSize; - int64_t OverlapB = KnownWidthB ? WidthB + OffsetB - MinOffset - : MemoryLocation::UnknownSize; + AliasResult AAResult = + AA->alias(MemoryLocation(ValA, OverlapA, + UseTBAA ? MMOa->getAAInfo() : AAMDNodes()), + MemoryLocation(ValB, OverlapB, + UseTBAA ? MMOb->getAAInfo() : AAMDNodes())); - AliasResult AAResult = AA->alias( - MemoryLocation(ValA, OverlapA, - UseTBAA ? MMOa->getAAInfo() : AAMDNodes()), - MemoryLocation(ValB, OverlapB, - UseTBAA ? MMOb->getAAInfo() : AAMDNodes())); + return (AAResult != NoAlias); + }; - return (AAResult != NoAlias); + // Check each pair of memory operands from both instructions, which can't + // alias only if all pairs won't alias. + for (auto *MMOa : memoperands()) + for (auto *MMOb : Other.memoperands()) + if (HasAlias(MMOa, MMOb)) + return true; + + return false; } /// hasOrderedMemoryRef - Return true if this instruction may have an ordered diff --git a/llvm/test/CodeGen/AArch64/merge-store-dependency.ll b/llvm/test/CodeGen/AArch64/merge-store-dependency.ll index 6850846fec06..3a768d0e3f9b 100644 --- a/llvm/test/CodeGen/AArch64/merge-store-dependency.ll +++ b/llvm/test/CodeGen/AArch64/merge-store-dependency.ll @@ -19,11 +19,11 @@ define void @test(%struct1* %fde, i32 %fd, void (i32, i32, i8*)* %func, i8* %arg ; A53-NEXT: mov x19, x8 ; A53-NEXT: mov w0, w1 ; A53-NEXT: mov w9, #256 +; A53-NEXT: stp x2, x3, [x8, #32] +; A53-NEXT: mov x2, x8 ; A53-NEXT: str q0, [x19, #16]! ; A53-NEXT: str w1, [x19] ; A53-NEXT: mov w1, #4 -; A53-NEXT: stp x2, x3, [x8, #32] -; A53-NEXT: mov x2, x8 ; A53-NEXT: str q0, [x8] ; A53-NEXT: strh w9, [x8, #24] ; A53-NEXT: str wzr, [x8, #20] diff --git a/llvm/test/CodeGen/ARM/big-endian-neon-fp16-bitconv.ll b/llvm/test/CodeGen/ARM/big-endian-neon-fp16-bitconv.ll index 9942d6df99a4..693f33553591 100644 --- a/llvm/test/CodeGen/ARM/big-endian-neon-fp16-bitconv.ll +++ b/llvm/test/CodeGen/ARM/big-endian-neon-fp16-bitconv.ll @@ -503,12 +503,12 @@ define void @conv_v8f16_to_i128( <8 x half> %a, i128* %store ) { ; CHECK-NEXT: vmov.32 r3, d16[1] ; CHECK-NEXT: vmov.32 r1, d16[0] ; CHECK-NEXT: subs r12, r12, #1 +; CHECK-NEXT: str r12, [r0, #12] ; CHECK-NEXT: sbcs r2, r2, #0 +; CHECK-NEXT: str r2, [r0, #8] ; CHECK-NEXT: sbcs r3, r3, #0 ; CHECK-NEXT: sbc r1, r1, #0 ; CHECK-NEXT: stm r0, {r1, r3} -; CHECK-NEXT: str r2, [r0, #8] -; CHECK-NEXT: str r12, [r0, #12] ; CHECK-NEXT: bx lr ; CHECK-NEXT: .p2align 4 ; CHECK-NEXT: @ %bb.1: diff --git a/llvm/test/CodeGen/Thumb2/mve-float32regloops.ll b/llvm/test/CodeGen/Thumb2/mve-float32regloops.ll index a43f564951e9..4fe8877aa8bd 100644 --- a/llvm/test/CodeGen/Thumb2/mve-float32regloops.ll +++ b/llvm/test/CodeGen/Thumb2/mve-float32regloops.ll @@ -1094,6 +1094,7 @@ define void @fir(%struct.arm_fir_instance_f32* nocapture readonly %S, float* noc ; CHECK-NEXT: ldrd r11, r8, [r12, #24] ; CHECK-NEXT: vstrb.8 q0, [r9], #16 ; CHECK-NEXT: vldrw.u32 q0, [r5], #32 +; CHECK-NEXT: strd r9, r1, [sp, #24] @ 8-byte Folded Spill ; CHECK-NEXT: vldrw.u32 q1, [r5, #-28] ; CHECK-NEXT: vmul.f32 q0, q0, r7 ; CHECK-NEXT: vldrw.u32 q6, [r5, #-24] @@ -1105,13 +1106,12 @@ define void @fir(%struct.arm_fir_instance_f32* nocapture readonly %S, float* noc ; CHECK-NEXT: vfma.f32 q0, q4, r6 ; CHECK-NEXT: vldrw.u32 q3, [r5, #-8] ; CHECK-NEXT: vfma.f32 q0, q5, r3 -; CHECK-NEXT: vldrw.u32 q1, [r5, #-4] -; CHECK-NEXT: vfma.f32 q0, q2, lr ; CHECK-NEXT: ldr r0, [sp, #20] @ 4-byte Reload +; CHECK-NEXT: vfma.f32 q0, q2, lr +; CHECK-NEXT: vldrw.u32 q1, [r5, #-4] ; CHECK-NEXT: vfma.f32 q0, q3, r11 -; CHECK-NEXT: strd r9, r1, [sp, #24] @ 8-byte Folded Spill -; CHECK-NEXT: vfma.f32 q0, q1, r8 ; CHECK-NEXT: cmp r0, #16 +; CHECK-NEXT: vfma.f32 q0, q1, r8 ; CHECK-NEXT: blo .LBB16_7 ; CHECK-NEXT: @ %bb.5: @ %for.body.preheader ; CHECK-NEXT: @ in Loop: Header=BB16_4 Depth=1 diff --git a/llvm/test/CodeGen/Thumb2/mve-phireg.ll b/llvm/test/CodeGen/Thumb2/mve-phireg.ll index e7d6a7323bc1..0fe26fbc4753 100644 --- a/llvm/test/CodeGen/Thumb2/mve-phireg.ll +++ b/llvm/test/CodeGen/Thumb2/mve-phireg.ll @@ -168,16 +168,14 @@ define dso_local i32 @e() #0 { ; CHECK-NEXT: vmov q1, q4 ; CHECK-NEXT: vmov s1, r7 ; CHECK-NEXT: vmov.32 q1[1], r6 -; CHECK-NEXT: mov.w r10, #0 -; CHECK-NEXT: vmov.32 q1[2], r5 ; CHECK-NEXT: vmov.32 q5[0], r7 +; CHECK-NEXT: vmov.32 q1[2], r5 +; CHECK-NEXT: vmov s9, r4 ; CHECK-NEXT: vmov.32 q1[3], r4 -; CHECK-NEXT: strd r0, r10, [sp, #24] +; CHECK-NEXT: vdup.32 q6, r7 ; CHECK-NEXT: vstrw.32 q1, [sp, #76] ; CHECK-NEXT: vmov q1, q5 -; CHECK-NEXT: vmov s9, r4 ; CHECK-NEXT: vmov.32 q1[1], r7 -; CHECK-NEXT: vdup.32 q6, r7 ; CHECK-NEXT: vmov.f32 s2, s1 ; CHECK-NEXT: vmov.f32 s8, s0 ; CHECK-NEXT: vmov.32 q1[2], r6 @@ -185,6 +183,7 @@ define dso_local i32 @e() #0 { ; CHECK-NEXT: vmov q7, q6 ; CHECK-NEXT: vmov.f32 s10, s1 ; CHECK-NEXT: mov.w r8, #4 +; CHECK-NEXT: mov.w r10, #0 ; CHECK-NEXT: vmov.32 q1[3], r4 ; CHECK-NEXT: vmov.32 q3[0], r4 ; CHECK-NEXT: vmov.32 q7[1], r4 @@ -192,6 +191,7 @@ define dso_local i32 @e() #0 { ; CHECK-NEXT: vmov.f32 s11, s3 ; CHECK-NEXT: movs r1, #64 ; CHECK-NEXT: strh.w r8, [sp, #390] +; CHECK-NEXT: strd r0, r10, [sp, #24] ; CHECK-NEXT: vstrw.32 q0, [sp, #44] ; CHECK-NEXT: str r0, [r0] ; CHECK-NEXT: vstrw.32 q2, [r0] diff --git a/llvm/test/CodeGen/Thumb2/mve-vst3.ll b/llvm/test/CodeGen/Thumb2/mve-vst3.ll index 600c5279ca91..1ae74c1738c7 100644 --- a/llvm/test/CodeGen/Thumb2/mve-vst3.ll +++ b/llvm/test/CodeGen/Thumb2/mve-vst3.ll @@ -24,8 +24,8 @@ define void @vst3_v2i32(<2 x i32> *%src, <6 x i32> *%dst) { ; CHECK-NEXT: vmov.f32 s9, s6 ; CHECK-NEXT: vmov.f32 s10, s0 ; CHECK-NEXT: vmov.f32 s11, s5 -; CHECK-NEXT: strd r2, r0, [r1, #16] ; CHECK-NEXT: vstrw.32 q2, [r1] +; CHECK-NEXT: strd r2, r0, [r1, #16] ; CHECK-NEXT: pop {r4, pc} entry: %s1 = getelementptr <2 x i32>, <2 x i32>* %src, i32 0 diff --git a/llvm/test/CodeGen/Thumb2/umulo-128-legalisation-lowering.ll b/llvm/test/CodeGen/Thumb2/umulo-128-legalisation-lowering.ll index ac1c814b838e..f57c9226179b 100644 --- a/llvm/test/CodeGen/Thumb2/umulo-128-legalisation-lowering.ll +++ b/llvm/test/CodeGen/Thumb2/umulo-128-legalisation-lowering.ll @@ -8,17 +8,17 @@ define { i128, i8 } @muloti_test(i128 %l, i128 %r) unnamed_addr #0 { ; THUMBV7-NEXT: push.w {r4, r5, r6, r7, r8, r9, r10, r11, lr} ; THUMBV7-NEXT: .pad #44 ; THUMBV7-NEXT: sub sp, #44 -; THUMBV7-NEXT: ldrd r4, r7, [sp, #88] -; THUMBV7-NEXT: mov r5, r3 ; THUMBV7-NEXT: str r0, [sp, #40] @ 4-byte Spill ; THUMBV7-NEXT: movs r0, #0 -; THUMBV7-NEXT: strd r4, r7, [sp] -; THUMBV7-NEXT: mov r1, r3 +; THUMBV7-NEXT: ldrd r4, r7, [sp, #88] +; THUMBV7-NEXT: mov r5, r3 ; THUMBV7-NEXT: strd r0, r0, [sp, #8] +; THUMBV7-NEXT: mov r1, r3 ; THUMBV7-NEXT: mov r6, r2 ; THUMBV7-NEXT: mov r0, r2 ; THUMBV7-NEXT: movs r2, #0 ; THUMBV7-NEXT: movs r3, #0 +; THUMBV7-NEXT: strd r4, r7, [sp] ; THUMBV7-NEXT: bl __multi3 ; THUMBV7-NEXT: strd r1, r0, [sp, #32] @ 8-byte Folded Spill ; THUMBV7-NEXT: strd r3, r2, [sp, #24] @ 8-byte Folded Spill diff --git a/llvm/test/CodeGen/X86/store_op_load_fold2.ll b/llvm/test/CodeGen/X86/store_op_load_fold2.ll index 674b8d8f9384..6f088772436e 100644 --- a/llvm/test/CodeGen/X86/store_op_load_fold2.ll +++ b/llvm/test/CodeGen/X86/store_op_load_fold2.ll @@ -17,13 +17,12 @@ cond_true2732.preheader: ; preds = %entry store i64 %tmp2676.us.us, i64* %tmp2666 ret i32 0 -; INTEL: and {{e..}}, dword ptr [356] -; INTEL: and dword ptr [360], {{e..}} -; FIXME: mov dword ptr [356], {{e..}} -; The above line comes out as 'mov 360, eax', but when the register is ecx it works? +; INTEL-DAG: and {{e..}}, dword ptr [356] +; INTEL-DAG: and dword ptr [360], {{e..}} +; INTEL: mov dword ptr [356], {{e..}} -; ATT: andl 356, %{{e..}} -; ATT: andl %{{e..}}, 360 +; ATT-DAG: andl 356, %{{e..}} +; ATT-DAG: andl %{{e..}}, 360 ; ATT: movl %{{e..}}, 356 } </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-release-arm-spec2k6-Oz - Build # 9 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Oz. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Oz Culprit: <cut> commit b4916918e5219ac25a5b6472c5638450f867d975 Author: Roman Lebedev <lebedev.ri(a)gmail.com> Date: Fri Oct 30 09:12:49 2020 +0300 [SCEV] SCEVPtrToIntExpr simplifications If we've got an SCEVPtrToIntExpr(op), where op is not an SCEVUnknown, we want to sink the SCEVPtrToIntExpr into an operand, so that the operation is performed on integers, and eventually we end up with just an `SCEVPtrToIntExpr(SCEVUnknown)`. Reviewed By: mkazantsev Differential Revision: https://reviews.llvm.org/D89692 </cut> Results regressed to (for first_bad == b4916918e5219ac25a5b6472c5638450f867d975) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz_mthumb -- artifacts/build-b4916918e5219ac25a5b6472c5638450f867d975/results_id: 1 # 483.xalancbmk,[.] _ZSt9__find_ifIN9__gnu_cxx17__normal_iterat regressed by 111 from (for last_good == 81fc53a36a4e3ca5cc9d5bc9b3ea32f304e35b93) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Oz_mthumb -- artifacts/build-81fc53a36a4e3ca5cc9d5bc9b3ea32f304e35b93/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-release-arm-spec2k6-Oz/749 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-release-arm-spec2k6-Oz/752 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-b4916918e5219ac25a5b6472c5638450f867d975 cd investigate-llvm-b4916918e5219ac25a5b6472c5638450f867d975 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach b4916918e5219ac25a5b6472c5638450f867d975 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 81fc53a36a4e3ca5cc9d5bc9b3ea32f304e35b93 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Full commit (up to 1000 lines): <cut> commit b4916918e5219ac25a5b6472c5638450f867d975 Author: Roman Lebedev <lebedev.ri(a)gmail.com> Date: Fri Oct 30 09:12:49 2020 +0300 [SCEV] SCEVPtrToIntExpr simplifications If we've got an SCEVPtrToIntExpr(op), where op is not an SCEVUnknown, we want to sink the SCEVPtrToIntExpr into an operand, so that the operation is performed on integers, and eventually we end up with just an `SCEVPtrToIntExpr(SCEVUnknown)`. Reviewed By: mkazantsev Differential Revision: https://reviews.llvm.org/D89692 --- llvm/lib/Analysis/ScalarEvolution.cpp | 56 +++++++++++++++++++--- llvm/test/Analysis/ScalarEvolution/ptrtoint.ll | 52 ++++++++++---------- .../LoopStrengthReduce/X86/expander-crashes.ll | 54 ++++++++++----------- polly/test/ScopInfo/int2ptr_ptr2int.ll | 16 +++---- polly/test/ScopInfo/int2ptr_ptr2int_2.ll | 17 ++++--- 5 files changed, 118 insertions(+), 77 deletions(-) diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp index 11b99553bf6b..91f3b947fc50 100644 --- a/llvm/lib/Analysis/ScalarEvolution.cpp +++ b/llvm/lib/Analysis/ScalarEvolution.cpp @@ -1047,17 +1047,61 @@ const SCEV *ScalarEvolution::getPtrToIntExpr(const SCEV *Op, Type *Ty, ID.AddPointer(Op); void *IP = nullptr; if (const SCEV *S = UniqueSCEVs.FindNodeOrInsertPos(ID, IP)) - return getTruncateOrZeroExtend(S, Ty); + return getTruncateOrZeroExtend(S, Ty, Depth); - assert(!isa<SCEVConstant>(Op) && - "SCEVConstant is an integer, no constant folding to do."); + assert((isa<SCEVNAryExpr>(Op) || isa<SCEVUnknown>(Op)) && + "We can only gen an nary expression, or an unknown here."); - // FIXME: simplifications. + Type *IntPtrTy = getDataLayout().getIntPtrType(Op->getType()); + + // If the input operand is not an unknown (and thus is an nary expression), + // sink the cast to operands, so that the operation is performed on integers, + // and we eventually end up with just an ptrtoint(unknown). + if (const SCEVNAryExpr *NaryExpr = dyn_cast<SCEVNAryExpr>(Op)) { + SmallVector<const SCEV *, 2> NewOps; + NewOps.reserve(NaryExpr->getNumOperands()); + for (const SCEV *Op : NaryExpr->operands()) + NewOps.push_back(Op->getType()->isPointerTy() + ? getPtrToIntExpr(Op, IntPtrTy, Depth + 1) + : Op); + const SCEV *NewNaryExpr = nullptr; + switch (SCEVTypes SCEVType = NaryExpr->getSCEVType()) { + case scAddExpr: + NewNaryExpr = getAddExpr(NewOps, NaryExpr->getNoWrapFlags(), Depth + 1); + break; + case scAddRecExpr: + NewNaryExpr = + getAddRecExpr(NewOps, cast<SCEVAddRecExpr>(NaryExpr)->getLoop(), + NaryExpr->getNoWrapFlags()); + break; + case scUMaxExpr: + case scSMaxExpr: + case scUMinExpr: + case scSMinExpr: + NewNaryExpr = getMinMaxExpr(SCEVType, NewOps); + break; + + case scMulExpr: + NewNaryExpr = getMulExpr(NewOps, NaryExpr->getNoWrapFlags(), Depth + 1); + break; + case scUDivExpr: + NewNaryExpr = getUDivExpr(NewOps[0], NewOps[1]); + break; + case scConstant: + case scTruncate: + case scZeroExtend: + case scSignExtend: + case scPtrToInt: + case scUnknown: + case scCouldNotCompute: + llvm_unreachable("We can't get these types here."); + } + return getTruncateOrZeroExtend(NewNaryExpr, Ty, Depth); + } // The cast wasn't folded; create an explicit cast node. We can reuse // the existing insert position since if we get here, we won't have // made any changes which would invalidate it. - Type *IntPtrTy = getDataLayout().getIntPtrType(Op->getType()); assert(getDataLayout().getTypeSizeInBits(getEffectiveSCEVType( Op->getType())) == getDataLayout().getTypeSizeInBits(IntPtrTy) && "We can only model ptrtoint if SCEV's effective (integer) type is " @@ -1066,7 +1110,7 @@ const SCEV *ScalarEvolution::getPtrToIntExpr(const SCEV *Op, Type *Ty, SCEVPtrToIntExpr(ID.Intern(SCEVAllocator), Op, IntPtrTy); UniqueSCEVs.InsertNode(S, IP); addToLoopUseLists(S); - return getTruncateOrZeroExtend(S, Ty); + return getTruncateOrZeroExtend(S, Ty, Depth); } const SCEV *ScalarEvolution::getTruncateExpr(const SCEV *Op, Type *Ty, diff --git a/llvm/test/Analysis/ScalarEvolution/ptrtoint.ll b/llvm/test/Analysis/ScalarEvolution/ptrtoint.ll index 9a6c77e8968e..70fb37984d8a 100644 --- a/llvm/test/Analysis/ScalarEvolution/ptrtoint.ll +++ b/llvm/test/Analysis/ScalarEvolution/ptrtoint.ll @@ -196,7 +196,7 @@ define void @ptrtoint_of_gep(i8* %in, i64* %out0) { ; X64-NEXT: %in_adj = getelementptr inbounds i8, i8* %in, i64 42 ; X64-NEXT: --> (42 + %in)<nsw> U: [-9223372036854775766,-9223372036854775808) S: [-9223372036854775766,-9223372036854775808) ; X64-NEXT: %p0 = ptrtoint i8* %in_adj to i64 -; X64-NEXT: --> (ptrtoint i8* (42 + %in)<nsw> to i64) U: [-9223372036854775766,-9223372036854775808) S: [-9223372036854775766,-9223372036854775808) +; X64-NEXT: --> (42 + (ptrtoint i8* %in to i64))<nsw> U: [-9223372036854775766,-9223372036854775808) S: [-9223372036854775766,-9223372036854775808) ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_gep ; ; X32-LABEL: 'ptrtoint_of_gep' @@ -204,7 +204,7 @@ define void @ptrtoint_of_gep(i8* %in, i64* %out0) { ; X32-NEXT: %in_adj = getelementptr inbounds i8, i8* %in, i64 42 ; X32-NEXT: --> (42 + %in)<nsw> U: [-2147483606,-2147483648) S: [-2147483606,-2147483648) ; X32-NEXT: %p0 = ptrtoint i8* %in_adj to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* (42 + %in)<nsw> to i32) to i64) U: [0,4294967296) S: [0,4294967296) +; X32-NEXT: --> (zext i32 (42 + (ptrtoint i8* %in to i32))<nsw> to i64) U: [0,4294967296) S: [0,4294967296) ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_gep ; %in_adj = getelementptr inbounds i8, i8* %in, i64 42 @@ -226,7 +226,7 @@ define void @ptrtoint_of_addrec(i32* %in, i32 %count) { ; X64-NEXT: %i7 = getelementptr inbounds i32, i32* %in, i64 %i6 ; X64-NEXT: --> {%in,+,4}<nsw><%loop> U: full-set S: full-set Exits: (-4 + (4 * (zext i32 %count to i64))<nuw><nsw> + %in) LoopDispositions: { %loop: Computable } ; X64-NEXT: %i8 = ptrtoint i32* %i7 to i64 -; X64-NEXT: --> (ptrtoint i32* {%in,+,4}<nsw><%loop> to i64) U: full-set S: full-set Exits: (ptrtoint i32* (-4 + (4 * (zext i32 %count to i64))<nuw><nsw> + %in) to i64) LoopDispositions: { %loop: Computable } +; X64-NEXT: --> {(ptrtoint i32* %in to i64),+,4}<nsw><%loop> U: full-set S: full-set Exits: (-4 + (4 * (zext i32 %count to i64))<nuw><nsw> + (ptrtoint i32* %in to i64)) LoopDispositions: { %loop: Computable } ; X64-NEXT: %i9 = add nuw nsw i64 %i6, 1 ; X64-NEXT: --> {1,+,1}<nuw><%loop> U: [1,0) S: [1,0) Exits: (zext i32 %count to i64) LoopDispositions: { %loop: Computable } ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_addrec @@ -245,7 +245,7 @@ define void @ptrtoint_of_addrec(i32* %in, i32 %count) { ; X32-NEXT: %i7 = getelementptr inbounds i32, i32* %in, i64 %i6 ; X32-NEXT: --> {%in,+,4}<%loop> U: full-set S: full-set Exits: (-4 + (4 * %count) + %in) LoopDispositions: { %loop: Computable } ; X32-NEXT: %i8 = ptrtoint i32* %i7 to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i32* {%in,+,4}<%loop> to i32) to i64) U: [0,4294967296) S: [0,4294967296) Exits: (zext i32 (ptrtoint i32* (-4 + (4 * %count) + %in) to i32) to i64) LoopDispositions: { %loop: Computable } +; X32-NEXT: --> (zext i32 {(ptrtoint i32* %in to i32),+,4}<%loop> to i64) U: [0,4294967296) S: [0,4294967296) Exits: (zext i32 (-4 + (4 * %count) + (ptrtoint i32* %in to i32)) to i64) LoopDispositions: { %loop: Computable } ; X32-NEXT: %i9 = add nuw nsw i64 %i6, 1 ; X32-NEXT: --> {1,+,1}<nuw><%loop> U: [1,0) S: [1,0) Exits: (zext i32 %count to i64) LoopDispositions: { %loop: Computable } ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_addrec @@ -280,7 +280,7 @@ define void @ptrtoint_of_umax(i8* %in0, i8* %in1, i64* %out0) { ; X64-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X64-NEXT: --> (%in0 umax %in1) U: full-set S: full-set ; X64-NEXT: %p0 = ptrtoint i8* %s to i64 -; X64-NEXT: --> (ptrtoint i8* (%in0 umax %in1) to i64) U: full-set S: full-set +; X64-NEXT: --> ((ptrtoint i8* %in0 to i64) umax (ptrtoint i8* %in1 to i64)) U: full-set S: full-set ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_umax ; ; X32-LABEL: 'ptrtoint_of_umax' @@ -288,7 +288,7 @@ define void @ptrtoint_of_umax(i8* %in0, i8* %in1, i64* %out0) { ; X32-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X32-NEXT: --> (%in0 umax %in1) U: full-set S: full-set ; X32-NEXT: %p0 = ptrtoint i8* %s to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* (%in0 umax %in1) to i32) to i64) U: [0,4294967296) S: [0,4294967296) +; X32-NEXT: --> (zext i32 ((ptrtoint i8* %in0 to i32) umax (ptrtoint i8* %in1 to i32)) to i64) U: [0,4294967296) S: [0,4294967296) ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_umax ; %c = icmp uge i8* %in0, %in1 @@ -304,7 +304,7 @@ define void @ptrtoint_of_smax(i8* %in0, i8* %in1, i64* %out0) { ; X64-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X64-NEXT: --> (%in0 smax %in1) U: full-set S: full-set ; X64-NEXT: %p0 = ptrtoint i8* %s to i64 -; X64-NEXT: --> (ptrtoint i8* (%in0 smax %in1) to i64) U: full-set S: full-set +; X64-NEXT: --> ((ptrtoint i8* %in0 to i64) smax (ptrtoint i8* %in1 to i64)) U: full-set S: full-set ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_smax ; ; X32-LABEL: 'ptrtoint_of_smax' @@ -312,7 +312,7 @@ define void @ptrtoint_of_smax(i8* %in0, i8* %in1, i64* %out0) { ; X32-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X32-NEXT: --> (%in0 smax %in1) U: full-set S: full-set ; X32-NEXT: %p0 = ptrtoint i8* %s to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* (%in0 smax %in1) to i32) to i64) U: [0,4294967296) S: [0,4294967296) +; X32-NEXT: --> (zext i32 ((ptrtoint i8* %in0 to i32) smax (ptrtoint i8* %in1 to i32)) to i64) U: [0,4294967296) S: [0,4294967296) ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_smax ; %c = icmp sge i8* %in0, %in1 @@ -328,7 +328,7 @@ define void @ptrtoint_of_umin(i8* %in0, i8* %in1, i64* %out0) { ; X64-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X64-NEXT: --> (%in0 umin %in1) U: full-set S: full-set ; X64-NEXT: %p0 = ptrtoint i8* %s to i64 -; X64-NEXT: --> (ptrtoint i8* (%in0 umin %in1) to i64) U: full-set S: full-set +; X64-NEXT: --> ((ptrtoint i8* %in0 to i64) umin (ptrtoint i8* %in1 to i64)) U: full-set S: full-set ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_umin ; ; X32-LABEL: 'ptrtoint_of_umin' @@ -336,7 +336,7 @@ define void @ptrtoint_of_umin(i8* %in0, i8* %in1, i64* %out0) { ; X32-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X32-NEXT: --> (%in0 umin %in1) U: full-set S: full-set ; X32-NEXT: %p0 = ptrtoint i8* %s to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* (%in0 umin %in1) to i32) to i64) U: [0,4294967296) S: [0,4294967296) +; X32-NEXT: --> (zext i32 ((ptrtoint i8* %in0 to i32) umin (ptrtoint i8* %in1 to i32)) to i64) U: [0,4294967296) S: [0,4294967296) ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_umin ; %c = icmp ule i8* %in0, %in1 @@ -352,7 +352,7 @@ define void @ptrtoint_of_smin(i8* %in0, i8* %in1, i64* %out0) { ; X64-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X64-NEXT: --> (%in0 smin %in1) U: full-set S: full-set ; X64-NEXT: %p0 = ptrtoint i8* %s to i64 -; X64-NEXT: --> (ptrtoint i8* (%in0 smin %in1) to i64) U: full-set S: full-set +; X64-NEXT: --> ((ptrtoint i8* %in0 to i64) smin (ptrtoint i8* %in1 to i64)) U: full-set S: full-set ; X64-NEXT: Determining loop execution counts for: @ptrtoint_of_smin ; ; X32-LABEL: 'ptrtoint_of_smin' @@ -360,7 +360,7 @@ define void @ptrtoint_of_smin(i8* %in0, i8* %in1, i64* %out0) { ; X32-NEXT: %s = select i1 %c, i8* %in0, i8* %in1 ; X32-NEXT: --> (%in0 smin %in1) U: full-set S: full-set ; X32-NEXT: %p0 = ptrtoint i8* %s to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* (%in0 smin %in1) to i32) to i64) U: [0,4294967296) S: [0,4294967296) +; X32-NEXT: --> (zext i32 ((ptrtoint i8* %in0 to i32) smin (ptrtoint i8* %in1 to i32)) to i64) U: [0,4294967296) S: [0,4294967296) ; X32-NEXT: Determining loop execution counts for: @ptrtoint_of_smin ; %c = icmp sle i8* %in0, %in1 @@ -384,11 +384,11 @@ define void @pr46786_c26_char(i8* %arg, i8* %arg1, i8* %arg2) { ; X64-NEXT: %i8 = load i8, i8* %i7, align 1 ; X64-NEXT: --> %i8 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X64-NEXT: %i9 = ptrtoint i8* %i7 to i64 -; X64-NEXT: --> (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i64) U: full-set S: full-set Exits: (ptrtoint i8* (-1 + %arg1) to i64) LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> {(ptrtoint i8* %arg to i64),+,1}<nuw><%bb6> U: full-set S: full-set Exits: (-1 + (-1 * %arg) + (ptrtoint i8* %arg to i64) + %arg1) LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i10 = sub i64 %i9, %i4 -; X64-NEXT: --> ((-1 * (ptrtoint i8* %arg to i64)) + (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i64)) U: full-set S: full-set Exits: ((-1 * (ptrtoint i8* %arg to i64)) + (ptrtoint i8* (-1 + %arg1) to i64)) LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> {0,+,1}<nw><%bb6> U: [0,-1) S: [0,-1) Exits: (-1 + (-1 * %arg) + %arg1) LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i11 = getelementptr inbounds i8, i8* %arg2, i64 %i10 -; X64-NEXT: --> ((-1 * (ptrtoint i8* %arg to i64)) + (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i64) + %arg2) U: full-set S: full-set Exits: ((-1 * (ptrtoint i8* %arg to i64)) + (ptrtoint i8* (-1 + %arg1) to i64) + %arg2) LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> {%arg2,+,1}<nw><%bb6> U: full-set S: full-set Exits: (-1 + (-1 * %arg) + %arg1 + %arg2) LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i12 = load i8, i8* %i11, align 1 ; X64-NEXT: --> %i12 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X64-NEXT: %i13 = add i8 %i12, %i8 @@ -411,11 +411,11 @@ define void @pr46786_c26_char(i8* %arg, i8* %arg1, i8* %arg2) { ; X32-NEXT: %i8 = load i8, i8* %i7, align 1 ; X32-NEXT: --> %i8 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X32-NEXT: %i9 = ptrtoint i8* %i7 to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i32) to i64) U: [0,4294967296) S: [0,4294967296) Exits: (zext i32 (ptrtoint i8* (-1 + %arg1) to i32) to i64) LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> {(zext i32 (ptrtoint i8* %arg to i32) to i64),+,1}<nuw><%bb6> U: [0,8589934590) S: [0,8589934590) Exits: ((zext i8* (-1 + (-1 * %arg) + %arg1) to i64) + (zext i32 (ptrtoint i8* %arg to i32) to i64)) LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i10 = sub i64 %i9, %i4 -; X32-NEXT: --> ((zext i32 (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i8* %arg to i32) to i64))<nsw>) U: [-4294967295,4294967296) S: [-4294967295,4294967296) Exits: ((zext i32 (ptrtoint i8* (-1 + %arg1) to i32) to i64) + (-1 * (zext i32 (ptrtoint i8* %arg to i32) to i64))<nsw>) LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> {0,+,1}<nw><%bb6> U: [0,4294967295) S: [0,4294967295) Exits: (zext i8* (-1 + (-1 * %arg) + %arg1) to i64) LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i11 = getelementptr inbounds i8, i8* %arg2, i64 %i10 -; X32-NEXT: --> ((-1 * (ptrtoint i8* %arg to i32)) + (ptrtoint i8* {%arg,+,1}<nuw><%bb6> to i32) + %arg2) U: full-set S: full-set Exits: ((-1 * (ptrtoint i8* %arg to i32)) + (ptrtoint i8* (-1 + %arg1) to i32) + %arg2) LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> {%arg2,+,1}<%bb6> U: full-set S: full-set Exits: (-1 + (-1 * %arg) + %arg1 + %arg2) LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i12 = load i8, i8* %i11, align 1 ; X32-NEXT: --> %i12 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X32-NEXT: %i13 = add i8 %i12, %i8 @@ -469,13 +469,13 @@ define void @pr46786_c26_int(i32* %arg, i32* %arg1, i32* %arg2) { ; X64-NEXT: %i8 = load i32, i32* %i7, align 4 ; X64-NEXT: --> %i8 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X64-NEXT: %i9 = ptrtoint i32* %i7 to i64 -; X64-NEXT: --> (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64) U: full-set S: full-set Exits: (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64) LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> {(ptrtoint i32* %arg to i64),+,4}<nuw><%bb6> U: full-set S: full-set Exits: ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + (ptrtoint i32* %arg to i64)) LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i10 = sub i64 %i9, %i4 -; X64-NEXT: --> ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64)) U: full-set S: full-set Exits: ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64)) LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> {0,+,4}<nw><%bb6> U: [0,-3) S: [-9223372036854775808,9223372036854775805) Exits: (4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i11 = ashr exact i64 %i10, 2 -; X64-NEXT: --> (((((-1 * (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64)) + (ptrtoint i32* %arg to i64)) smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64))) /u 4) * (1 smin (-1 smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64)))))<nsw> U: [-4611686018427387903,4611686018427387904) S: [-4611686018427387903,4611686018427387904) Exits: (((((-1 * (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64)) + (ptrtoint i32* %arg to i64)) smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64))) /u 4) * (1 smin (-1 smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64)))))<nsw> LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> ((({0,+,4}<nw><%bb6> smax {0,+,-4}<nw><%bb6>) /u 4) * (1 smin (-1 smax {0,+,4}<nw><%bb6>)))<nsw> U: [-4611686018427387903,4611686018427387904) S: [-4611686018427387903,4611686018427387904) Exits: ((((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> smax (-4 * ((-4 + (-1 * %arg) + %arg1) /u 4))) /u 4) * (1 smin (-1 smax (4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw>)))<nsw> LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i12 = getelementptr inbounds i32, i32* %arg2, i64 %i11 -; X64-NEXT: --> ((4 * ((((-1 * (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64)) + (ptrtoint i32* %arg to i64)) smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64))) /u 4) * (1 smin (-1 smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i64))))) + %arg2)<nsw> U: full-set S: full-set Exits: ((4 * ((((-1 * (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64)) + (ptrtoint i32* %arg to i64)) smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64))) /u 4) * (1 smin (-1 smax ((-1 * (ptrtoint i32* %arg to i64)) + (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i64))))) + %arg2)<nsw> LoopDispositions: { %bb6: Computable } +; X64-NEXT: --> ((4 * (({0,+,4}<nw><%bb6> smax {0,+,-4}<nw><%bb6>) /u 4) * (1 smin (-1 smax {0,+,4}<nw><%bb6>))) + %arg2)<nsw> U: full-set S: full-set Exits: ((4 * (((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> smax (-4 * ((-4 + (-1 * %arg) + %arg1) /u 4))) /u 4) * (1 smin (-1 smax (4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw>))) + %arg2)<nsw> LoopDispositions: { %bb6: Computable } ; X64-NEXT: %i13 = load i32, i32* %i12, align 4 ; X64-NEXT: --> %i13 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X64-NEXT: %i14 = add nsw i32 %i13, %i8 @@ -498,13 +498,13 @@ define void @pr46786_c26_int(i32* %arg, i32* %arg1, i32* %arg2) { ; X32-NEXT: %i8 = load i32, i32* %i7, align 4 ; X32-NEXT: --> %i8 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X32-NEXT: %i9 = ptrtoint i32* %i7 to i64 -; X32-NEXT: --> (zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) U: [0,4294967296) S: [0,4294967296) Exits: (zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> {(zext i32 (ptrtoint i32* %arg to i32) to i64),+,4}<nuw><%bb6> U: [0,8589934588) S: [0,8589934588) Exits: ((zext i32 (ptrtoint i32* %arg to i32) to i64) + (4 * ((zext i32* (-4 + (-1 * %arg) + %arg1) to i64) /u 4))<nuw><nsw>) LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i10 = sub i64 %i9, %i4 -; X32-NEXT: --> ((zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) U: [-4294967295,4294967296) S: [-4294967295,4294967296) Exits: ((zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> {0,+,4}<nw><%bb6> U: [0,4294967293) S: [0,4294967293) Exits: (4 * ((zext i32* (-4 + (-1 * %arg) + %arg1) to i64) /u 4))<nuw><nsw> LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i11 = ashr exact i64 %i10, 2 -; X32-NEXT: --> (((((zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) smax ((zext i32 (ptrtoint i32* %arg to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64))<nsw>)) /u 4) * (1 smin (-1 smax ((zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>))))<nsw> U: [-4611686018427387903,4611686018427387904) S: [-4611686018427387903,4611686018427387904) Exits: (((((zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) smax ((zext i32 (ptrtoint i32* %arg to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64))<nsw>)) /u 4) * (1 smin (-1 smax ((zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>))))<nsw> LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> ({0,+,1}<nw><%bb6> * (1 smin {0,+,4}<nuw><nsw><%bb6>))<nuw><nsw> U: [0,1073741824) S: [0,1073741824) Exits: (((zext i32* (-4 + (-1 * %arg) + %arg1) to i64) /u 4) * (1 smin (4 * ((zext i32* (-4 + (-1 * %arg) + %arg1) to i64) /u 4))<nuw><nsw>))<nuw><nsw> LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i12 = getelementptr inbounds i32, i32* %arg2, i64 %i11 -; X32-NEXT: --> ((4 * (trunc i64 (((((zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) smax ((zext i32 (ptrtoint i32* %arg to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64))<nsw>)) /u 4) * (1 smin (-1 smax ((zext i32 (ptrtoint i32* {%arg,+,4}<nuw><%bb6> to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>))))<nsw> to i32))<nsw> + %arg2)<nsw> U: full-set S: full-set Exits: ((4 * (trunc i64 (((((zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>) smax ((zext i32 (ptrtoint i32* %arg to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64))<nsw>)) /u 4) * (1 smin (-1 smax ((zext i32 (ptrtoint i32* ((4 * ((-4 + (-1 * %arg) + %arg1) /u 4))<nuw> + %arg) to i32) to i64) + (-1 * (zext i32 (ptrtoint i32* %arg to i32) to i64))<nsw>))))<nsw> to i32))<nsw> + %arg2)<nsw> LoopDispositions: { %bb6: Computable } +; X32-NEXT: --> (((trunc i64 (1 smin {0,+,4}<nuw><nsw><%bb6>) to i32) * {0,+,4}<%bb6>) + %arg2)<nsw> U: full-set S: full-set Exits: ((4 * (trunc i64 (1 smin (4 * ((zext i32* (-4 + (-1 * %arg) + %arg1) to i64) /u 4))<nuw><nsw>) to i32) * ((-4 + (-1 * %arg) + %arg1) /u 4)) + %arg2)<nsw> LoopDispositions: { %bb6: Computable } ; X32-NEXT: %i13 = load i32, i32* %i12, align 4 ; X32-NEXT: --> %i13 U: full-set S: full-set Exits: <<Unknown>> LoopDispositions: { %bb6: Variant } ; X32-NEXT: %i14 = add nsw i32 %i13, %i8 diff --git a/llvm/test/Transforms/LoopStrengthReduce/X86/expander-crashes.ll b/llvm/test/Transforms/LoopStrengthReduce/X86/expander-crashes.ll index c895a10ba110..1525b811c0ca 100644 --- a/llvm/test/Transforms/LoopStrengthReduce/X86/expander-crashes.ll +++ b/llvm/test/Transforms/LoopStrengthReduce/X86/expander-crashes.ll @@ -11,44 +11,42 @@ target triple = "x86_64-apple-macosx10.15.0" define i64 @blam(%struct.hoge* %start, %struct.hoge* %end, %struct.hoge* %ptr.2) { ; CHECK-LABEL: @blam( ; CHECK-NEXT: entry: -; CHECK-NEXT: [[END16:%.*]] = bitcast %struct.hoge* [[END:%.*]] to i8* -; CHECK-NEXT: [[START17:%.*]] = ptrtoint %struct.hoge* [[START:%.*]] to i64 -; CHECK-NEXT: [[SCEVGEP12:%.*]] = getelementptr [[STRUCT_HOGE:%.*]], %struct.hoge* [[START]], i64 0, i32 3 -; CHECK-NEXT: [[SCEVGEP1213:%.*]] = bitcast i32* [[SCEVGEP12]] to %struct.hoge* -; CHECK-NEXT: [[TMP0:%.*]] = sub i64 0, [[START17]] -; CHECK-NEXT: [[UGLYGEP18:%.*]] = getelementptr i8, i8* [[END16]], i64 [[TMP0]] -; CHECK-NEXT: [[UGLYGEP1819:%.*]] = bitcast i8* [[UGLYGEP18]] to %struct.hoge* +; CHECK-NEXT: [[START9:%.*]] = ptrtoint %struct.hoge* [[START:%.*]] to i64 +; CHECK-NEXT: [[START6:%.*]] = bitcast %struct.hoge* [[START]] to i8* +; CHECK-NEXT: [[END8:%.*]] = bitcast %struct.hoge* [[END:%.*]] to i8* +; CHECK-NEXT: [[TMP0:%.*]] = ptrtoint %struct.hoge* [[START]] to i64 +; CHECK-NEXT: [[TMP1:%.*]] = sub i64 0, [[START9]] +; CHECK-NEXT: [[UGLYGEP10:%.*]] = getelementptr i8, i8* [[END8]], i64 [[TMP1]] ; CHECK-NEXT: br label [[LOOP_1_HEADER:%.*]] ; CHECK: loop.1.header: -; CHECK-NEXT: [[LSR_IV20:%.*]] = phi %struct.hoge* [ [[SCEVGEP21:%.*]], [[LOOP_1_HEADER]] ], [ [[UGLYGEP1819]], [[ENTRY:%.*]] ] -; CHECK-NEXT: [[LSR_IV14:%.*]] = phi %struct.hoge* [ [[SCEVGEP15:%.*]], [[LOOP_1_HEADER]] ], [ [[SCEVGEP1213]], [[ENTRY]] ] -; CHECK-NEXT: [[SCEVGEP15]] = getelementptr [[STRUCT_HOGE]], %struct.hoge* [[LSR_IV14]], i64 1 -; CHECK-NEXT: [[SCEVGEP21]] = getelementptr [[STRUCT_HOGE]], %struct.hoge* [[LSR_IV20]], i64 -1 -; CHECK-NEXT: [[EC:%.*]] = icmp eq %struct.hoge* [[SCEVGEP21]], null +; CHECK-NEXT: [[LSR_IV4:%.*]] = phi i64 [ [[LSR_IV_NEXT5:%.*]], [[LOOP_1_HEADER]] ], [ 0, [[ENTRY:%.*]] ] +; CHECK-NEXT: [[LSR_IV_NEXT5]] = add i64 [[LSR_IV4]], -16 +; CHECK-NEXT: [[SCEVGEP11:%.*]] = getelementptr i8, i8* [[UGLYGEP10]], i64 [[LSR_IV_NEXT5]] +; CHECK-NEXT: [[SCEVGEP1112:%.*]] = bitcast i8* [[SCEVGEP11]] to %struct.hoge* +; CHECK-NEXT: [[EC:%.*]] = icmp eq %struct.hoge* [[SCEVGEP1112]], null ; CHECK-NEXT: br i1 [[EC]], label [[LOOP_2_PH:%.*]], label [[LOOP_1_HEADER]] ; CHECK: loop.2.ph: +; CHECK-NEXT: [[TMP2:%.*]] = sub i64 [[TMP0]], [[LSR_IV_NEXT5]] +; CHECK-NEXT: [[TMP3:%.*]] = mul i64 [[LSR_IV_NEXT5]], -1 +; CHECK-NEXT: [[UGLYGEP:%.*]] = getelementptr i8, i8* [[START6]], i64 [[TMP3]] +; CHECK-NEXT: [[UGLYGEP7:%.*]] = bitcast i8* [[UGLYGEP]] to %struct.hoge* ; CHECK-NEXT: br label [[LOOP_2_HEADER:%.*]] ; CHECK: loop.2.header: -; CHECK-NEXT: [[LSR_IV3:%.*]] = phi %struct.hoge* [ [[SCEVGEP4:%.*]], [[LOOP_2_LATCH:%.*]] ], [ [[SCEVGEP15]], [[LOOP_2_PH]] ] -; CHECK-NEXT: [[LSR_IV310:%.*]] = bitcast %struct.hoge* [[LSR_IV3]] to i32* -; CHECK-NEXT: [[LSR_IV37:%.*]] = bitcast %struct.hoge* [[LSR_IV3]] to i8* -; CHECK-NEXT: [[UGLYGEP8:%.*]] = getelementptr i8, i8* [[LSR_IV37]], i64 -12 -; CHECK-NEXT: [[UGLYGEP89:%.*]] = bitcast i8* [[UGLYGEP8]] to %struct.hoge* -; CHECK-NEXT: [[LSR_IV35:%.*]] = bitcast %struct.hoge* [[LSR_IV3]] to i8* -; CHECK-NEXT: [[TMP8:%.*]] = ptrtoint i32* [[LSR_IV310]] to i64 -; CHECK-NEXT: call void @use.i64(i64 [[TMP8]]) -; CHECK-NEXT: [[SCEVGEP11:%.*]] = getelementptr i32, i32* [[LSR_IV310]], i64 -1 -; CHECK-NEXT: store i32 10, i32* [[SCEVGEP11]], align 8 -; CHECK-NEXT: [[EC_2:%.*]] = icmp ugt %struct.hoge* [[UGLYGEP89]], [[PTR_2:%.*]] +; CHECK-NEXT: [[LSR_IV1:%.*]] = phi i64 [ [[LSR_IV_NEXT2:%.*]], [[LOOP_2_LATCH:%.*]] ], [ [[TMP2]], [[LOOP_2_PH]] ] +; CHECK-NEXT: [[IV2:%.*]] = phi %struct.hoge* [ [[IV2_NEXT:%.*]], [[LOOP_2_LATCH]] ], [ [[UGLYGEP7]], [[LOOP_2_PH]] ] +; CHECK-NEXT: [[IV23:%.*]] = bitcast %struct.hoge* [[IV2]] to i32* +; CHECK-NEXT: [[TMP4:%.*]] = add i64 [[LSR_IV1]], 12 +; CHECK-NEXT: call void @use.i64(i64 [[TMP4]]) +; CHECK-NEXT: [[SCEVGEP:%.*]] = getelementptr i32, i32* [[IV23]], i64 2 +; CHECK-NEXT: store i32 10, i32* [[SCEVGEP]], align 8 +; CHECK-NEXT: [[EC_2:%.*]] = icmp ugt %struct.hoge* [[IV2]], [[PTR_2:%.*]] ; CHECK-NEXT: br i1 [[EC_2]], label [[LOOP_2_EXIT:%.*]], label [[LOOP_2_LATCH]] ; CHECK: loop.2.latch: -; CHECK-NEXT: [[SCEVGEP4]] = getelementptr [[STRUCT_HOGE]], %struct.hoge* [[LSR_IV3]], i64 1 +; CHECK-NEXT: [[IV2_NEXT]] = getelementptr inbounds [[STRUCT_HOGE:%.*]], %struct.hoge* [[IV2]], i64 1 +; CHECK-NEXT: [[LSR_IV_NEXT2]] = add i64 [[LSR_IV1]], 16 ; CHECK-NEXT: br label [[LOOP_2_HEADER]] ; CHECK: loop.2.exit: -; CHECK-NEXT: [[UGLYGEP:%.*]] = getelementptr i8, i8* [[LSR_IV35]], i64 -12 -; CHECK-NEXT: [[UGLYGEP6:%.*]] = bitcast i8* [[UGLYGEP]] to %struct.hoge* -; CHECK-NEXT: [[IV2_CAST:%.*]] = ptrtoint %struct.hoge* [[UGLYGEP6]] to i64 -; CHECK-NEXT: ret i64 [[IV2_CAST]] +; CHECK-NEXT: ret i64 [[LSR_IV1]] ; entry: br label %loop.1.header diff --git a/polly/test/ScopInfo/int2ptr_ptr2int.ll b/polly/test/ScopInfo/int2ptr_ptr2int.ll index 9618ea068e1b..2a0b69c7536f 100644 --- a/polly/test/ScopInfo/int2ptr_ptr2int.ll +++ b/polly/test/ScopInfo/int2ptr_ptr2int.ll @@ -17,25 +17,25 @@ ; CHECK-NEXT: [val, ptr] -> { Stmt_for_body[i0] -> MemRef_A[9 + ptr] }; ; ; IR: polly.stmt.for.body: -; IR-NEXT: %p_tmp1 = inttoptr i64 %0 to i64* +; IR-NEXT: %p_tmp1 = inttoptr i64 %14 to i64* ; IR-NEXT: %p_add.ptr2 = getelementptr inbounds i64, i64* %p_tmp1, i64 1 ; IR-NEXT: %p_tmp2 = ptrtoint i64* %p_add.ptr2 to i64 ; IR-NEXT: %p_arrayidx = getelementptr inbounds i64, i64* %A, i64 %p_tmp2 ; IR-NEXT: %tmp3_p_scalar_ = load i64, i64* %p_arrayidx, align 8, !alias.scope !0, !noalias !2 -; IR-NEXT: %tmp4_p_scalar_ = load i64, i64* %scevgep1, align 8, !alias.scope !0, !noalias !2 +; IR-NEXT: %tmp4_p_scalar_ = load i64, i64* %scevgep, align 8, !alias.scope !0, !noalias !2 ; IR-NEXT: %p_add4 = add nsw i64 %tmp4_p_scalar_, %tmp3_p_scalar_ -; IR-NEXT: store i64 %p_add4, i64* %scevgep1, align 8, !alias.scope !0, !noalias !2 +; IR-NEXT: store i64 %p_add4, i64* %scevgep, align 8, !alias.scope !0, !noalias !2 ; IR-NEXT: %polly.indvar_next = add nsw i64 %polly.indvar, 1 ; IR-NEXT: %polly.loop_cond = icmp sle i64 %polly.indvar_next, 99 ; IR-NEXT: br i1 %polly.loop_cond, label %polly.loop_header, label %polly.loop_exit ; ; IR: polly.loop_preheader: -; IR-NEXT: %0 = add i64 %val, 1 -; IR-NEXT: %scevgep = getelementptr i64, i64* %ptr, i32 1 -; IR-NEXT: %1 = ptrtoint i64* %scevgep to i32 -; IR-NEXT: %2 = add i32 %1, 1 -; IR-NEXT: %scevgep1 = getelementptr i64, i64* %A, i32 %2 +; IR-NEXT: %14 = add i64 %val, 1 +; IR-NEXT: %15 = ptrtoint i64* %ptr to i32 +; IR-NEXT: %16 = add i32 %15, 9 +; IR-NEXT: %scevgep = getelementptr i64, i64* %A, i32 %16 ; IR-NEXT: br label %polly.loop_header + ; target datalayout = "e-p:32:32:32-m:e-i64:64-f80:128-n8:16:32:64-S128" diff --git a/polly/test/ScopInfo/int2ptr_ptr2int_2.ll b/polly/test/ScopInfo/int2ptr_ptr2int_2.ll index 894f5f308a07..c0bd80b1e242 100644 --- a/polly/test/ScopInfo/int2ptr_ptr2int_2.ll +++ b/polly/test/ScopInfo/int2ptr_ptr2int_2.ll @@ -13,7 +13,7 @@ ; ; CHECK: ReadAccess := [Reduction Type: NONE] [Scalar: 0] ; CHECK-NEXT: [val, ptr] -> { Stmt_for_body[i0] -> MemRef_B[9 + val] }; -; CHECK-NEXT: Execution Context: [val, ptr] -> { : val <= 32766 } +; CHECK-NEXT: Execution Context: [val, ptr] -> { : -4097 <= val <= 4086 } ; ; CHECK: ReadAccess := [Reduction Type: +] [Scalar: 0] ; CHECK-NEXT: [val, ptr] -> { Stmt_for_body[i0] -> MemRef_A[9 + ptr] }; @@ -21,19 +21,18 @@ ; CHECK-NEXT: [val, ptr] -> { Stmt_for_body[i0] -> MemRef_A[9 + ptr] }; ; ; IR: polly.stmt.for.body: -; IR-NEXT: %tmp4_p_scalar_ = load i64, i64* %scevgep13, align 8, !alias.scope !3, !noalias !4 +; IR-NEXT: %tmp4_p_scalar_ = load i64, i64* %scevgep, align 8, !alias.scope !3, !noalias !4 ; IR-NEXT: %p_add4 = add nsw i64 %tmp4_p_scalar_, %polly.preload.tmp3.merge -; IR-NEXT: store i64 %p_add4, i64* %scevgep13, align 8, !alias.scope !3, !noalias !4 +; IR-NEXT: store i64 %p_add4, i64* %scevgep, align 8, !alias.scope !3, !noalias !4 ; IR-NEXT: %polly.indvar_next = add nsw i64 %polly.indvar, 1 ; IR-NEXT: %polly.loop_cond = icmp sle i64 %polly.indvar_next, 99 ; IR-NEXT: br i1 %polly.loop_cond, label %polly.loop_header, label %polly.loop_exit -; + ; IR: polly.loop_preheader: -; IR-NEXT: %35 = add i16 %val, 1 -; IR-NEXT: %scevgep = getelementptr i64, i64* %ptr, i16 1 -; IR-NEXT: %36 = ptrtoint i64* %scevgep to i16 -; IR-NEXT: %37 = add i16 %36, 1 -; IR-NEXT: %scevgep13 = getelementptr i64, i64* %A, i16 %37 +; IR-NEXT: %41 = add i16 %val, 1 +; IR-NEXT: %42 = ptrtoint i64* %ptr to i16 +; IR-NEXT: %43 = add i16 %42, 9 +; IR-NEXT: %scevgep = getelementptr i64, i64* %A, i16 %43 ; IR-NEXT: br label %polly.loop_header ; target datalayout = "e-p:16:16:16-m:e-i64:64-f80:128-n8:16:16:64-S128" </cut>

3 years, 12 months

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/llvm-release-arm-spec2k6-Os - Build # 15 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Os. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tk1/llvm-release-arm-spec2k6-Os Culprit: <cut> commit 3a2b05f9fe74fcf9560632cf2695058d47d8683b Author: Evgeniy Brevnov <ybrevnov(a)azul.com> Date: Fri Jul 24 18:57:10 2020 +0700 [BPI][NFC] Consolidate code to deal with SCCs under a dedicated data structure. In order to facilitate review of D79485 here is a small NFC change which restructures code around handling of SCCs in BPI. Reviewed By: davidxl Differential Revision: https://reviews.llvm.org/D84514 </cut> Results regressed to (for first_bad == 3a2b05f9fe74fcf9560632cf2695058d47d8683b) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os_mthumb -- artifacts/build-3a2b05f9fe74fcf9560632cf2695058d47d8683b/results_id: 1 # 401.bzip2,bzip2_base.default regressed by 104 from (for last_good == 7294ca3f6ecacd05a197bbf0637e10afcb99b6d6) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -Os_mthumb -- artifacts/build-7294ca3f6ecacd05a197bbf0637e10afcb99b6d6/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of last_good: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-release-arm-spec2k6-Os/699 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Results ID of first_bad: tk1_32/tcwg_bmk_llvm_tk1/bisect-llvm-release-arm-spec2k6-Os/688 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-3a2b05f9fe74fcf9560632cf2695058d47d8683b cd investigate-llvm-3a2b05f9fe74fcf9560632cf2695058d47d8683b git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 3a2b05f9fe74fcf9560632cf2695058d47d8683b ../artifacts/test.sh # Reproduce last_good build git checkout --detach 7294ca3f6ecacd05a197bbf0637e10afcb99b6d6 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tk1-llvm-release… Full commit (up to 1000 lines): <cut> commit 3a2b05f9fe74fcf9560632cf2695058d47d8683b Author: Evgeniy Brevnov <ybrevnov(a)azul.com> Date: Fri Jul 24 18:57:10 2020 +0700 [BPI][NFC] Consolidate code to deal with SCCs under a dedicated data structure. In order to facilitate review of D79485 here is a small NFC change which restructures code around handling of SCCs in BPI. Reviewed By: davidxl Differential Revision: https://reviews.llvm.org/D84514 --- llvm/include/llvm/Analysis/BranchProbabilityInfo.h | 71 ++++++++- llvm/lib/Analysis/BranchProbabilityInfo.cpp | 164 +++++++++++++-------- 2 files changed, 169 insertions(+), 66 deletions(-) diff --git a/llvm/include/llvm/Analysis/BranchProbabilityInfo.h b/llvm/include/llvm/Analysis/BranchProbabilityInfo.h index 3e72afba36c3..7feb5b625938 100644 --- a/llvm/include/llvm/Analysis/BranchProbabilityInfo.h +++ b/llvm/include/llvm/Analysis/BranchProbabilityInfo.h @@ -151,13 +151,66 @@ public: /// Forget analysis results for the given basic block. void eraseBlock(const BasicBlock *BB); - // Use to track SCCs for handling irreducible loops. - using SccMap = DenseMap<const BasicBlock *, int>; - using SccHeaderMap = DenseMap<const BasicBlock *, bool>; - using SccHeaderMaps = std::vector<SccHeaderMap>; - struct SccInfo { + class SccInfo { + // Enum of types to classify basic blocks in SCC. Basic block belonging to + // SCC is 'Inner' until it is either 'Header' or 'Exiting'. Note that a + // basic block can be 'Header' and 'Exiting' at the same time. + enum SccBlockType { + Inner = 0x0, + Header = 0x1, + Exiting = 0x2, + }; + // Map of basic blocks to SCC IDs they belong to. If basic block doesn't + // belong to any SCC it is not in the map. + using SccMap = DenseMap<const BasicBlock *, int>; + // Each basic block in SCC is attributed with one or several types from + // SccBlockType. Map value has uint32_t type (instead of SccBlockType) + // since basic block may be for example "Header" and "Exiting" at the same + // time and we need to be able to keep more than one value from + // SccBlockType. + using SccBlockTypeMap = DenseMap<const BasicBlock *, uint32_t>; + // Vector containing classification of basic blocks for all SCCs where i'th + // vector element corresponds to SCC with ID equal to i. + using SccBlockTypeMaps = std::vector<SccBlockTypeMap>; + SccMap SccNums; - SccHeaderMaps SccHeaders; + SccBlockTypeMaps SccBlocks; + + public: + explicit SccInfo(const Function &F); + + /// If \p BB belongs to some SCC then ID of that SCC is returned, otherwise + /// -1 is returned. If \p BB belongs to more than one SCC at the same time + /// result is undefined. + int getSCCNum(const BasicBlock *BB) const; + /// Returns true if \p BB is a 'header' block in SCC with \p SccNum ID, + /// false otherwise. + bool isSCCHeader(const BasicBlock *BB, int SccNum) const { + return getSccBlockType(BB, SccNum) & Header; + } + /// Returns true if \p BB is an 'exiting' block in SCC with \p SccNum ID, + /// false otherwise. + bool isSCCExitingBlock(const BasicBlock *BB, int SccNum) const { + return getSccBlockType(BB, SccNum) & Exiting; + } + /// Fills in \p Enters vector with all such blocks that don't belong to + /// SCC with \p SccNum ID but there is an edge to a block belonging to the + /// SCC. + void getSccEnterBlocks(int SccNum, + SmallVectorImpl<BasicBlock *> &Enters) const; + /// Fills in \p Exits vector with all such blocks that don't belong to + /// SCC with \p SccNum ID but there is an edge from a block belonging to the + /// SCC. + void getSccExitBlocks(int SccNum, + SmallVectorImpl<BasicBlock *> &Exits) const; + + private: + /// Returns \p BB's type according to classification given by SccBlockType + /// enum. Please note that \p BB must belong to SSC with \p SccNum ID. + uint32_t getSccBlockType(const BasicBlock *BB, int SccNum) const; + /// Calculates \p BB's type and stores it in internal data structures for + /// future use. Please note that \p BB must belong to SSC with \p SccNum ID. + void calculateSccBlockType(const BasicBlock *BB, int SccNum); }; private: @@ -196,6 +249,9 @@ private: /// Track the last function we run over for printing. const Function *LastF = nullptr; + /// Keeps information about all SCCs in a function. + std::unique_ptr<const SccInfo> SccI; + /// Track the set of blocks directly succeeded by a returning block. SmallPtrSet<const BasicBlock *, 16> PostDominatedByUnreachable; @@ -210,8 +266,7 @@ private: bool calcMetadataWeights(const BasicBlock *BB); bool calcColdCallHeuristics(const BasicBlock *BB); bool calcPointerHeuristics(const BasicBlock *BB); - bool calcLoopBranchHeuristics(const BasicBlock *BB, const LoopInfo &LI, - SccInfo &SccI); + bool calcLoopBranchHeuristics(const BasicBlock *BB, const LoopInfo &LI); bool calcZeroHeuristics(const BasicBlock *BB, const TargetLibraryInfo *TLI); bool calcFloatingPointHeuristics(const BasicBlock *BB); bool calcInvokeHeuristics(const BasicBlock *BB); diff --git a/llvm/lib/Analysis/BranchProbabilityInfo.cpp b/llvm/lib/Analysis/BranchProbabilityInfo.cpp index a396b5ad21c6..195fc69d9601 100644 --- a/llvm/lib/Analysis/BranchProbabilityInfo.cpp +++ b/llvm/lib/Analysis/BranchProbabilityInfo.cpp @@ -148,6 +148,105 @@ static const uint32_t IH_TAKEN_WEIGHT = 1024 * 1024 - 1; /// instruction. This is essentially never taken. static const uint32_t IH_NONTAKEN_WEIGHT = 1; +BranchProbabilityInfo::SccInfo::SccInfo(const Function &F) { + // Record SCC numbers of blocks in the CFG to identify irreducible loops. + // FIXME: We could only calculate this if the CFG is known to be irreducible + // (perhaps cache this info in LoopInfo if we can easily calculate it there?). + int SccNum = 0; + for (scc_iterator<const Function *> It = scc_begin(&F); !It.isAtEnd(); + ++It, ++SccNum) { + // Ignore single-block SCCs since they either aren't loops or LoopInfo will + // catch them. + const std::vector<const BasicBlock *> &Scc = *It; + if (Scc.size() == 1) + continue; + + LLVM_DEBUG(dbgs() << "BPI: SCC " << SccNum << ":"); + for (const auto *BB : Scc) { + LLVM_DEBUG(dbgs() << " " << BB->getName()); + SccNums[BB] = SccNum; + calculateSccBlockType(BB, SccNum); + } + LLVM_DEBUG(dbgs() << "\n"); + } +} + +int BranchProbabilityInfo::SccInfo::getSCCNum(const BasicBlock *BB) const { + auto SccIt = SccNums.find(BB); + if (SccIt == SccNums.end()) + return -1; + return SccIt->second; +} + +void BranchProbabilityInfo::SccInfo::getSccEnterBlocks( + int SccNum, SmallVectorImpl<BasicBlock *> &Enters) const { + + for (auto MapIt : SccBlocks[SccNum]) { + const auto *BB = MapIt.first; + if (isSCCHeader(BB, SccNum)) + for (const auto *Pred : predecessors(BB)) + if (getSCCNum(Pred) != SccNum) + Enters.push_back(const_cast<BasicBlock *>(BB)); + } +} + +void BranchProbabilityInfo::SccInfo::getSccExitBlocks( + int SccNum, SmallVectorImpl<BasicBlock *> &Exits) const { + for (auto MapIt : SccBlocks[SccNum]) { + const auto *BB = MapIt.first; + if (isSCCExitingBlock(BB, SccNum)) + for (const auto *Succ : successors(BB)) + if (getSCCNum(Succ) != SccNum) + Exits.push_back(const_cast<BasicBlock *>(BB)); + } +} + +uint32_t BranchProbabilityInfo::SccInfo::getSccBlockType(const BasicBlock *BB, + int SccNum) const { + assert(getSCCNum(BB) == SccNum); + + assert(SccBlocks.size() > static_cast<unsigned>(SccNum) && "Unknown SCC"); + const auto &SccBlockTypes = SccBlocks[SccNum]; + + auto It = SccBlockTypes.find(BB); + if (It != SccBlockTypes.end()) { + return It->second; + } + return Inner; +} + +void BranchProbabilityInfo::SccInfo::calculateSccBlockType(const BasicBlock *BB, + int SccNum) { + assert(getSCCNum(BB) == SccNum); + uint32_t BlockType = Inner; + + if (llvm::any_of(make_range(pred_begin(BB), pred_end(BB)), + [&](const BasicBlock *Pred) { + // Consider any block that is an entry point to the SCC as + // a header. + return getSCCNum(Pred) != SccNum; + })) + BlockType |= Header; + + if (llvm::any_of( + make_range(succ_begin(BB), succ_end(BB)), + [&](const BasicBlock *Succ) { return getSCCNum(Succ) != SccNum; })) + BlockType |= Exiting; + + // Lazily compute the set of headers for a given SCC and cache the results + // in the SccHeaderMap. + if (SccBlocks.size() <= static_cast<unsigned>(SccNum)) + SccBlocks.resize(SccNum + 1); + auto &SccBlockTypes = SccBlocks[SccNum]; + + if (BlockType != Inner) { + bool IsInserted; + std::tie(std::ignore, IsInserted) = + SccBlockTypes.insert(std::make_pair(BB, BlockType)); + assert(IsInserted && "Duplicated block in SCC"); + } +} + static void UpdatePDTWorklist(const BasicBlock *BB, PostDominatorTree *PDT, SmallVectorImpl<const BasicBlock *> &WorkList, SmallPtrSetImpl<const BasicBlock *> &TargetSet) { @@ -511,38 +610,6 @@ bool BranchProbabilityInfo::calcPointerHeuristics(const BasicBlock *BB) { return true; } -static int getSCCNum(const BasicBlock *BB, - const BranchProbabilityInfo::SccInfo &SccI) { - auto SccIt = SccI.SccNums.find(BB); - if (SccIt == SccI.SccNums.end()) - return -1; - return SccIt->second; -} - -// Consider any block that is an entry point to the SCC as a header. -static bool isSCCHeader(const BasicBlock *BB, int SccNum, - BranchProbabilityInfo::SccInfo &SccI) { - assert(getSCCNum(BB, SccI) == SccNum); - - // Lazily compute the set of headers for a given SCC and cache the results - // in the SccHeaderMap. - if (SccI.SccHeaders.size() <= static_cast<unsigned>(SccNum)) - SccI.SccHeaders.resize(SccNum + 1); - auto &HeaderMap = SccI.SccHeaders[SccNum]; - bool Inserted; - BranchProbabilityInfo::SccHeaderMap::iterator HeaderMapIt; - std::tie(HeaderMapIt, Inserted) = HeaderMap.insert(std::make_pair(BB, false)); - if (Inserted) { - bool IsHeader = llvm::any_of(make_range(pred_begin(BB), pred_end(BB)), - [&](const BasicBlock *Pred) { - return getSCCNum(Pred, SccI) != SccNum; - }); - HeaderMapIt->second = IsHeader; - return IsHeader; - } else - return HeaderMapIt->second; -} - // Compute the unlikely successors to the block BB in the loop L, specifically // those that are unlikely because this is a loop, and add them to the // UnlikelyBlocks set. @@ -653,12 +720,11 @@ computeUnlikelySuccessors(const BasicBlock *BB, Loop *L, // Calculate Edge Weights using "Loop Branch Heuristics". Predict backedges // as taken, exiting edges as not-taken. bool BranchProbabilityInfo::calcLoopBranchHeuristics(const BasicBlock *BB, - const LoopInfo &LI, - SccInfo &SccI) { + const LoopInfo &LI) { int SccNum; Loop *L = LI.getLoopFor(BB); if (!L) { - SccNum = getSCCNum(BB, SccI); + SccNum = SccI->getSCCNum(BB); if (SccNum < 0) return false; } @@ -685,9 +751,9 @@ bool BranchProbabilityInfo::calcLoopBranchHeuristics(const BasicBlock *BB, else InEdges.push_back(I.getSuccessorIndex()); } else { - if (getSCCNum(*I, SccI) != SccNum) + if (SccI->getSCCNum(*I) != SccNum) ExitingEdges.push_back(I.getSuccessorIndex()); - else if (isSCCHeader(*I, SccNum, SccI)) + else if (SccI->isSCCHeader(*I, SccNum)) BackEdges.push_back(I.getSuccessorIndex()); else InEdges.push_back(I.getSuccessorIndex()); @@ -1072,26 +1138,7 @@ void BranchProbabilityInfo::calculate(const Function &F, const LoopInfo &LI, assert(PostDominatedByUnreachable.empty()); assert(PostDominatedByColdCall.empty()); - // Record SCC numbers of blocks in the CFG to identify irreducible loops. - // FIXME: We could only calculate this if the CFG is known to be irreducible - // (perhaps cache this info in LoopInfo if we can easily calculate it there?). - int SccNum = 0; - SccInfo SccI; - for (scc_iterator<const Function *> It = scc_begin(&F); !It.isAtEnd(); - ++It, ++SccNum) { - // Ignore single-block SCCs since they either aren't loops or LoopInfo will - // catch them. - const std::vector<const BasicBlock *> &Scc = *It; - if (Scc.size() == 1) - continue; - - LLVM_DEBUG(dbgs() << "BPI: SCC " << SccNum << ":"); - for (auto *BB : Scc) { - LLVM_DEBUG(dbgs() << " " << BB->getName()); - SccI.SccNums[BB] = SccNum; - } - LLVM_DEBUG(dbgs() << "\n"); - } + SccI = std::make_unique<SccInfo>(F); std::unique_ptr<PostDominatorTree> PDTPtr; @@ -1119,7 +1166,7 @@ void BranchProbabilityInfo::calculate(const Function &F, const LoopInfo &LI, continue; if (calcColdCallHeuristics(BB)) continue; - if (calcLoopBranchHeuristics(BB, LI, SccI)) + if (calcLoopBranchHeuristics(BB, LI)) continue; if (calcPointerHeuristics(BB)) continue; @@ -1131,6 +1178,7 @@ void BranchProbabilityInfo::calculate(const Function &F, const LoopInfo &LI, PostDominatedByUnreachable.clear(); PostDominatedByColdCall.clear(); + SccI.release(); if (PrintBranchProb && (PrintBranchProbFuncName.empty() || </cut>

4 years

1
0
0 0

Binutils help? Aarch64 PE/COFF support to enable UEFI Secure Boot

by Steve McIntyre

Hi folks, I'm hoping that I might be able to get some development help with binutils for aarch64... I'm maintaining the UEFI Secure Boot stack in Debian (shim etc.), including for arm64/aarch64 (as I wanted to make that work too!). UEFI binaries are awkward for those of used to the Linux and ELF world - they're PE/COFF format with different calling conventions to match the Microsoft world. But we've made things work. On x86 platforms, the shim build process uses objcopy --target=efi-app-$(ARCH) to produce the final output binaries. We've never had similar support for the aarch64 platform, and instead somebody came up with a method using locally-hacked linker script and "-O binary" to generate the output binaries. That's worked well enough for a while, but it's been annoying for various reasons (particularly debugging problems). *However*, recently for security reasons we've tweaked the layout of Secure Boot binaries [1] and this has caused lots of problems. The older hacks to hand-build the right sections etc. needed significant extra work, and we're still dealing with awkward bugs related to this. Based ont these problems, I recently had to make the painful decision to drop support for arm64 SB in Debian. I know that other distributions are feeling similar pain. :-( Rather than continuing to hack on things, I think it's (way past) time that we did things correctly! We need aarch64 binary format support in binutils so we can just use it like we do on x86. AFAICS, there is already a bug open asking for this from last year [2]. Could I please prevail on some friendly neighourhood aarch64 toolchain engineer to help with that? Thanks for considering, Steve [1] https://github.com/rhboot/shim/blob/main/SBAT.md [2] https://sourceware.org/bugzilla/show_bug.cgi?id=26206#add_comment -- Steve McIntyre, Cambridge, UK. steve(a)einval.com "...In the UNIX world, people tend to interpret `non-technical user' as meaning someone who's only ever written one device driver." -- Daniel Pead

4 years

5
6
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/llvm-master-aarch64-spec2k6-O2_LTO - Build # 15 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *llvm* in CI configuration tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_llvm_tx1/llvm-master-aarch64-spec2k6-O2_LTO Culprit: <cut> commit 8fe62b7af1127691d6732438b322e66ae6d39a03 Author: Max Kazantsev <mkazantsev(a)azul.com> Date: Thu Apr 22 12:50:38 2021 +0700 [GVN] Introduce loop load PRE This patch allows PRE of the following type of loads: ``` preheader: br label %loop loop: br i1 ..., label %merge, label %clobber clobber: call foo() // Clobbers %p br label %merge merge: ... br i1 ..., label %loop, label %exit ``` Into ``` preheader: %x0 = load %p br label %loop loop: %x.pre = phi(x0, x2) br i1 ..., label %merge, label %clobber clobber: call foo() // Clobbers %p %x1 = load %p br label %merge merge: x2 = phi(x.pre, x1) ... br i1 ..., label %loop, label %exit ``` So instead of loading from %p on every iteration, we load only when the actual clobber happens. The typical pattern which it is trying to address is: hot loop, with all code inlined and provably having no side effects, and some side-effecting calls on cold path. The worst overhead from it is, if we always take clobber block, we make 1 more load overall (in preheader). It only matters if loop has very few iteration. If clobber block is not taken at least once, the transform is neutral or profitable. There are several improvements prospect open up: - We can sometimes be smarter in loop-exiting blocks via split of critical edges; - If we have block frequency info, we can handle multiple clobbers. The only obstacle now is that we don't know if their sum is colder than the header. Differential Revision: https://reviews.llvm.org/D99926 Reviewed By: reames </cut> Results regressed to (for first_bad == 8fe62b7af1127691d6732438b322e66ae6d39a03) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO -- artifacts/build-8fe62b7af1127691d6732438b322e66ae6d39a03/results_id: 1 # 464.h264ref,h264ref_base.default regressed by 104 from (for last_good == 722d4d8e7585457d407d0639a4ae2610157e06a8) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # build_llvm true: -3 # true: 0 # benchmark -O2_LTO -- artifacts/build-722d4d8e7585457d407d0639a4ae2610157e06a8/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Results ID of last_good: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O2_LTO/641 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Results ID of first_bad: tx1_64/tcwg_bmk_llvm_tx1/bisect-llvm-master-aarch64-spec2k6-O2_LTO/642 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Configuration details: Reproduce builds: <cut> mkdir investigate-llvm-8fe62b7af1127691d6732438b322e66ae6d39a03 cd investigate-llvm-8fe62b7af1127691d6732438b322e66ae6d39a03 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd llvm # Reproduce first_bad build git checkout --detach 8fe62b7af1127691d6732438b322e66ae6d39a03 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 722d4d8e7585457d407d0639a4ae2610157e06a8 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_llvm-bisect-tcwg_bmk_tx1-llvm-master-… Full commit (up to 1000 lines): <cut> commit 8fe62b7af1127691d6732438b322e66ae6d39a03 Author: Max Kazantsev <mkazantsev(a)azul.com> Date: Thu Apr 22 12:50:38 2021 +0700 [GVN] Introduce loop load PRE This patch allows PRE of the following type of loads: ``` preheader: br label %loop loop: br i1 ..., label %merge, label %clobber clobber: call foo() // Clobbers %p br label %merge merge: ... br i1 ..., label %loop, label %exit ``` Into ``` preheader: %x0 = load %p br label %loop loop: %x.pre = phi(x0, x2) br i1 ..., label %merge, label %clobber clobber: call foo() // Clobbers %p %x1 = load %p br label %merge merge: x2 = phi(x.pre, x1) ... br i1 ..., label %loop, label %exit ``` So instead of loading from %p on every iteration, we load only when the actual clobber happens. The typical pattern which it is trying to address is: hot loop, with all code inlined and provably having no side effects, and some side-effecting calls on cold path. The worst overhead from it is, if we always take clobber block, we make 1 more load overall (in preheader). It only matters if loop has very few iteration. If clobber block is not taken at least once, the transform is neutral or profitable. There are several improvements prospect open up: - We can sometimes be smarter in loop-exiting blocks via split of critical edges; - If we have block frequency info, we can handle multiple clobbers. The only obstacle now is that we don't know if their sum is colder than the header. Differential Revision: https://reviews.llvm.org/D99926 Reviewed By: reames --- llvm/include/llvm/Transforms/Scalar/GVN.h | 6 ++ llvm/lib/Transforms/Scalar/GVN.cpp | 92 +++++++++++++++++++++++++-- llvm/test/Transforms/GVN/PRE/pre-loop-load.ll | 9 ++- 3 files changed, 98 insertions(+), 9 deletions(-) diff --git a/llvm/include/llvm/Transforms/Scalar/GVN.h b/llvm/include/llvm/Transforms/Scalar/GVN.h index 13f55ddcf2d6..70662ca213c3 100644 --- a/llvm/include/llvm/Transforms/Scalar/GVN.h +++ b/llvm/include/llvm/Transforms/Scalar/GVN.h @@ -328,6 +328,12 @@ private: bool PerformLoadPRE(LoadInst *Load, AvailValInBlkVect &ValuesPerBlock, UnavailBlkVect &UnavailableBlocks); + /// Try to replace a load which executes on each loop iteraiton with Phi + /// translation of load in preheader and load(s) in conditionally executed + /// paths. + bool performLoopLoadPRE(LoadInst *Load, AvailValInBlkVect &ValuesPerBlock, + UnavailBlkVect &UnavailableBlocks); + /// Eliminates partially redundant \p Load, replacing it with \p /// AvailableLoads (connected by Phis if needed). void eliminatePartiallyRedundantLoad( diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index 846a5cdb33d1..29da739fa16e 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -91,13 +91,14 @@ using namespace PatternMatch; #define DEBUG_TYPE "gvn" -STATISTIC(NumGVNInstr, "Number of instructions deleted"); -STATISTIC(NumGVNLoad, "Number of loads deleted"); -STATISTIC(NumGVNPRE, "Number of instructions PRE'd"); +STATISTIC(NumGVNInstr, "Number of instructions deleted"); +STATISTIC(NumGVNLoad, "Number of loads deleted"); +STATISTIC(NumGVNPRE, "Number of instructions PRE'd"); STATISTIC(NumGVNBlocks, "Number of blocks merged"); -STATISTIC(NumGVNSimpl, "Number of instructions simplified"); +STATISTIC(NumGVNSimpl, "Number of instructions simplified"); STATISTIC(NumGVNEqProp, "Number of equalities propagated"); -STATISTIC(NumPRELoad, "Number of loads PRE'd"); +STATISTIC(NumPRELoad, "Number of loads PRE'd"); +STATISTIC(NumPRELoopLoad, "Number of loop loads PRE'd"); STATISTIC(IsValueFullyAvailableInBlockNumSpeculationsMax, "Number of blocks speculated as available in " @@ -1447,6 +1448,84 @@ bool GVN::PerformLoadPRE(LoadInst *Load, AvailValInBlkVect &ValuesPerBlock, return true; } +bool GVN::performLoopLoadPRE(LoadInst *Load, AvailValInBlkVect &ValuesPerBlock, + UnavailBlkVect &UnavailableBlocks) { + if (!LI) + return false; + + const Loop *L = LI->getLoopFor(Load->getParent()); + // TODO: Generalize to other loop blocks that dominate the latch. + if (!L || L->getHeader() != Load->getParent()) + return false; + + BasicBlock *Preheader = L->getLoopPreheader(); + BasicBlock *Latch = L->getLoopLatch(); + if (!Preheader || !Latch) + return false; + + Value *LoadPtr = Load->getPointerOperand(); + // Must be available in preheader. + if (!L->isLoopInvariant(LoadPtr)) + return false; + + // We plan to hoist the load to preheader without introducing a new fault. + // In order to do it, we need to prove that we cannot side-exit the loop + // once loop header is first entered before execution of the load. + if (ICF->isDominatedByICFIFromSameBlock(Load)) + return false; + + BasicBlock *LoopBlock = nullptr; + for (auto *Blocker : UnavailableBlocks) { + // Blockers from outside the loop are handled in preheader. + if (!L->contains(Blocker)) + continue; + + // Only allow one loop block. Loop header is not less frequently executed + // than each loop block, and likely it is much more frequently executed. But + // in case of multiple loop blocks, we need extra information (such as block + // frequency info) to understand whether it is profitable to PRE into + // multiple loop blocks. + if (LoopBlock) + return false; + + // Do not sink into inner loops. This may be non-profitable. + if (L != LI->getLoopFor(Blocker)) + return false; + + // Blocks that dominate the latch execute on every single iteration, maybe + // except the last one. So PREing into these blocks doesn't make much sense + // in most cases. But the blocks that do not necessarily execute on each + // iteration are sometimes much colder than the header, and this is when + // PRE is potentially profitable. + if (DT->dominates(Blocker, Latch)) + return false; + + // Make sure that the terminator itself doesn't clobber. + if (Blocker->getTerminator()->mayWriteToMemory()) + return false; + + LoopBlock = Blocker; + } + + if (!LoopBlock) + return false; + + // Make sure the memory at this pointer cannot be freed, therefore we can + // safely reload from it after clobber. + if (LoadPtr->canBeFreed()) + return false; + + // TODO: Support critical edge splitting if blocker has more than 1 successor. + MapVector<BasicBlock *, Value *> AvailableLoads; + AvailableLoads[LoopBlock] = LoadPtr; + AvailableLoads[Preheader] = LoadPtr; + + LLVM_DEBUG(dbgs() << "GVN REMOVING PRE LOOP LOAD: " << *Load << '\n'); + eliminatePartiallyRedundantLoad(Load, ValuesPerBlock, AvailableLoads); + ++NumPRELoopLoad; + return true; +} + static void reportLoadElim(LoadInst *Load, Value *AvailableValue, OptimizationRemarkEmitter *ORE) { using namespace ore; @@ -1544,7 +1623,8 @@ bool GVN::processNonLocalLoad(LoadInst *Load) { if (!isLoadInLoopPREEnabled() && LI && LI->getLoopFor(Load->getParent())) return Changed; - return Changed || PerformLoadPRE(Load, ValuesPerBlock, UnavailableBlocks); + return Changed || PerformLoadPRE(Load, ValuesPerBlock, UnavailableBlocks) || + performLoopLoadPRE(Load, ValuesPerBlock, UnavailableBlocks); } static bool impliesEquivalanceIfTrue(CmpInst* Cmp) { diff --git a/llvm/test/Transforms/GVN/PRE/pre-loop-load.ll b/llvm/test/Transforms/GVN/PRE/pre-loop-load.ll index 15bc49e7ab9a..8ca12284d5c4 100644 --- a/llvm/test/Transforms/GVN/PRE/pre-loop-load.ll +++ b/llvm/test/Transforms/GVN/PRE/pre-loop-load.ll @@ -7,22 +7,25 @@ declare void @may_free_memory() declare i32 @personality_function() -; TODO: We can PRE the load from gc-managed memory away from the hot path. +; We can PRE the load from gc-managed memory away from the hot path. define i32 @test_load_on_cold_path_gc(i32 addrspace(1)* %p) gc "statepoint-example" personality i32 ()* @"personality_function" { ; CHECK-LABEL: @test_load_on_cold_path_gc( ; CHECK-NEXT: entry: +; CHECK-NEXT: [[X_PRE1:%.*]] = load i32, i32 addrspace(1)* [[P:%.*]], align 4 ; CHECK-NEXT: br label [[LOOP:%.*]] ; CHECK: loop: -; CHECK-NEXT: [[IV:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[IV_NEXT:%.*]], [[BACKEDGE:%.*]] ] -; CHECK-NEXT: [[X:%.*]] = load i32, i32 addrspace(1)* [[P:%.*]], align 4 +; CHECK-NEXT: [[X:%.*]] = phi i32 [ [[X_PRE1]], [[ENTRY:%.*]] ], [ [[X2:%.*]], [[BACKEDGE:%.*]] ] +; CHECK-NEXT: [[IV:%.*]] = phi i32 [ 0, [[ENTRY]] ], [ [[IV_NEXT:%.*]], [[BACKEDGE]] ] ; CHECK-NEXT: [[COND:%.*]] = icmp ne i32 [[X]], 0 ; CHECK-NEXT: br i1 [[COND]], label [[HOT_PATH:%.*]], label [[COLD_PATH:%.*]] ; CHECK: hot_path: ; CHECK-NEXT: br label [[BACKEDGE]] ; CHECK: cold_path: ; CHECK-NEXT: call void @may_free_memory() +; CHECK-NEXT: [[X_PRE:%.*]] = load i32, i32 addrspace(1)* [[P]], align 4 ; CHECK-NEXT: br label [[BACKEDGE]] ; CHECK: backedge: +; CHECK-NEXT: [[X2]] = phi i32 [ [[X_PRE]], [[COLD_PATH]] ], [ [[X]], [[HOT_PATH]] ] ; CHECK-NEXT: [[IV_NEXT]] = add i32 [[IV]], [[X]] ; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i32 [[IV_NEXT]], 1000 ; CHECK-NEXT: br i1 [[LOOP_COND]], label [[LOOP]], label [[EXIT:%.*]] </cut>

4 years

1
0
0 0

Re: Buildbot failure in LLVM Buildbot on clang-armv7-quick

by Philip Reames

This bot failure appears to be unrelated to the fingered change. From the commit log, I'd guess that 9eaf0d120 by Joel E. Denny <jdenny.ornl(a)gmail.com> was the triggering change, but that's not in the blame list. Joel, FYI. Linaro folks, as bot owner, you should investigate why the blame list is wrong. JFYI, this is not the only bot failing with the wrong blame list, so it might be a common problem. Philip On 6/25/21 10:43 AM, llvm.buildmaster(a)lab.llvm.org wrote: > The Buildbot has detected a failed build on builder clang-armv7-quick while building llvm. > > Full details are available at: > https://lab.llvm.org/buildbot#builders/171/builds/113 > > Worker for this Build: linaro-clang-armv7-quick > Blamelist: > Philip Reames <listmail(a)philipreames.com> > > BUILD FAILED: failed 48104 expected passes 1 unexpected failures 72 expected failures Unexpected test result output SKIPPED 26089 unsupported tests (failure) > > Step 5 (ninja check 1) failure: 48104 expected passes 1 unexpected failures 72 expected failures Unexpected test result output SKIPPED 26089 unsupported tests (failure) > ******************** TEST 'Clang :: utils/update_cc_test_checks/check-globals.test' FAILED ******************** > Script: > -- > : 'RUN: at line 1'; rm -rf /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp && mkdir /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp > : 'RUN: at line 5'; cp /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/Inputs/check-globals.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c > : 'RUN: at line 6'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py --clang /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang --opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c --check-globals > : 'RUN: at line 7'; /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/FileCheck /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/check-globals.test --input-file=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c --match-full-lines -strict-whitespace -check-prefixes=BOTH,NRM > : 'RUN: at line 10'; cp /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/Inputs/check-globals.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c > : 'RUN: at line 11'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py --clang /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang --opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c --check-globals --include-generated-funcs > : 'RUN: at line 12'; /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/FileCheck /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/check-globals.test --input-file=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c --match-full-lines -strict-whitespace -check-prefixes=BOTH,IGF > : 'RUN: at line 17'; cp /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm-again.c > : 'RUN: at line 18'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py --clang /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang --opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm-again.c --check-globals > : 'RUN: at line 19'; diff -u /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm-again.c > : 'RUN: at line 20'; rm /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm-again.c > : 'RUN: at line 22'; cp /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf-again.c > : 'RUN: at line 23'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py --clang /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang --opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf-again.c --check-globals --include-generated-funcs > : 'RUN: at line 25'; diff -u /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf-again.c > : 'RUN: at line 26'; rm /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf-again.c > : 'RUN: at line 31'; cp /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/Inputs/lit.cfg.example /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/lit.cfg > : 'RUN: at line 33'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/lit/lit.py -Dclang_obj_root=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang -j1 -vv /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp > : 'RUN: at line 35'; /usr/bin/python3.6 /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/lit/lit.py -Dclang_obj_root=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang -j1 -vv /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp 2>&1 | /home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/FileCheck -check-prefix=LIT-RUN /home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/check-globals.test > -- > Exit Code: 1 > > Command Output (stdout): > -- > $ ":" "RUN: at line 1" > $ "rm" "-rf" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp" > $ "mkdir" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp" > $ ":" "RUN: at line 5" > $ "cp" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/Inputs/check-globals.c" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c" > $ ":" "RUN: at line 6" > $ "/usr/bin/python3.6" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py" "--clang" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang" "--opt" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c" "--check-globals" > # command stderr: > NOTE: Executing non-FileChecked RUN line: true > > $ ":" "RUN: at line 7" > $ "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/FileCheck" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/check-globals.test" "--input-file=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c" "--match-full-lines" "-strict-whitespace" "-check-prefixes=BOTH,NRM" > $ ":" "RUN: at line 10" > $ "cp" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/Inputs/check-globals.c" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c" > $ ":" "RUN: at line 11" > $ "/usr/bin/python3.6" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/llvm/utils/update_cc_test_checks.py" "--clang" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/clang" "--opt" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/opt" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c" "--check-globals" "--include-generated-funcs" > # command stderr: > NOTE: Executing non-FileChecked RUN line: true > > $ ":" "RUN: at line 12" > $ "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/bin/FileCheck" "/home/tcwg-buildslave/worker/clang-armv7-quick/llvm/clang/test/utils/update_cc_test_checks/check-globals.test" "--input-file=/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/igf.c" "--match-full-lines" "-strict-whitespace" "-check-prefixes=BOTH,IGF" > $ ":" "RUN: at line 17" > $ "cp" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm.c" "/home/tcwg-buildslave/worker/clang-armv7-quick/stage1/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp/norm-again.c" > $ ":" "RUN: at line 18" > ... > > Sincerely, > LLVM Buildbot >

4 years

3
2
0 0

Re: [CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-release-arm-spec2k6-Os_LTO - Build # 31 - Fixed!

by Maxim Kuvyrkov

I’m running historical performance experiments, and this commit from 2019 showed up on my radar. Just in case someone is interested in running Fortran code on memory-constrained M-profile cores ... It appears that Janne’s patch increases code-size of 437.leslie3d by around 2% on 32-bit ARM (well, Thumb2, to be precise). It may be interesting to check what’s going on, since AArch64 is not affected. One possibility is that before this patch all literal-pool entries for error messages were shared, and with variation of error messages all of them became different entries, thus increasing code size. -- Maxim Kuvyrkov https://www.linaro.org > On 28 Jun 2021, at 00:54, ci_notify(a)linaro.org wrote: > > Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-Os_LTO. So far, this commit has regressed CI configurations: > - tcwg_bmk_gnu_tk1/gnu-release-arm-spec2k6-Os_LTO > - tcwg_bmk_tk1/gnu-release-arm-spec2k6-Os > > Culprit: > <cut> > commit d74a8b0579edd0c42921eccc45ab986d24f2fef0 > Author: Janne Blomqvist <jb(a)gcc.gnu.org> > > PR fortran/68401 Improve allocation error message > </cut> > > Results regressed to (for first_bad == d74a8b0579edd0c42921eccc45ab986d24f2fef0) > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: > -8 > # build_abe linux: > -7 > # build_abe glibc: > -6 > # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: > -5 > # true: > 0 > # benchmark -Os_LTO_mthumb -- artifacts/build-d74a8b0579edd0c42921eccc45ab986d24f2fef0/results_id: > 1 > # 437.leslie3d,leslie3d_base.default regressed by 102 > > from (for last_good == 777c02825229f14cf91c6044827ea42a77ded4a3) > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: > -8 > # build_abe linux: > -7 > # build_abe glibc: > -6 > # build_abe stage2 -- --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--disable-libsanitizer: > -5 > # true: > 0 > # benchmark -Os_LTO_mthumb -- artifacts/build-777c02825229f14cf91c6044827ea42a77ded4a3/results_id: > 1 > > Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… > Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-Os_LTO/531 > Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… > Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-release-arm-spec2k6-Os_LTO/539 > Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… > > Configuration details: > > > Reproduce builds: > <cut> > mkdir investigate-gcc-d74a8b0579edd0c42921eccc45ab986d24f2fef0 > cd investigate-gcc-d74a8b0579edd0c42921eccc45ab986d24f2fef0 > > git clone https://git.linaro.org/toolchain/jenkins-scripts > > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail > curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail > curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… --fail > chmod +x artifacts/test.sh > > # Reproduce the baseline build (build all pre-requisites) > ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh > > cd gcc > > # Reproduce first_bad build > git checkout --detach d74a8b0579edd0c42921eccc45ab986d24f2fef0 > ../artifacts/test.sh > > # Reproduce last_good build > git checkout --detach 777c02825229f14cf91c6044827ea42a77ded4a3 > ../artifacts/test.sh > > cd .. > </cut> > > History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… > > Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… > Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-release-a… > > Full commit (up to 1000 lines): > <cut> > commit d74a8b0579edd0c42921eccc45ab986d24f2fef0 > Author: Janne Blomqvist <jb(a)gcc.gnu.org> > Date: Sat Aug 17 08:45:37 2019 +0300 > > PR fortran/68401 Improve allocation error message > > Improve the error message that is printed when a memory allocation > fails, by including the location, and the size of the allocation that > failed. > > Regtested on x86_64-pc-linux-gnu. > > gcc/fortran/ChangeLog: > > 2019-08-17 Janne Blomqvist <jb(a)gcc.gnu.org> > > PR fortran/68401 > * trans-decl.c (gfc_build_builtin_function_decls): Replace > os_error with os_error_at decl. > * trans.c (trans_runtime_error_vararg): Modify so the error > function decl is passed directly. > (gfc_trans_runtime_error): Pass correct error function decl. > (gfc_trans_runtime_check): Likewise. > (trans_os_error_at): New function. > (gfc_call_malloc): Use trans_os_error_at. > (gfc_allocate_using_malloc): Likewise. > (gfc_call_realloc): Likewise. > * trans.h (gfor_fndecl_os_error): Replace with gfor_fndecl_os_error_at. > > libgfortran/ChangeLog: > > 2019-08-17 Janne Blomqvist <jb(a)gcc.gnu.org> > > PR fortran/68401 > * gfortran.map: Add GFORTRAN_10 node, add _gfortran_os_error_at > symbol. > * libgfortran.h (os_error_at): New prototype. > * runtime/error.c (os_error_at): New function. > > From-SVN: r274599 > --- > gcc/fortran/ChangeLog | 17 +++++++++++- > gcc/fortran/trans-decl.c | 12 ++++---- > gcc/fortran/trans.c | 68 +++++++++++++++++++++++++++------------------ > gcc/fortran/trans.h | 2 +- > libgfortran/ChangeLog | 8 ++++++ > libgfortran/gfortran.map | 5 ++++ > libgfortran/libgfortran.h | 4 +++ > libgfortran/runtime/error.c | 46 +++++++++++++++++++++++++++++- > 8 files changed, 126 insertions(+), 36 deletions(-) > > diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog > index bab69f3000e..a3b9e6bf486 100644 > --- a/gcc/fortran/ChangeLog > +++ b/gcc/fortran/ChangeLog > @@ -1,3 +1,18 @@ > +2019-08-17 Janne Blomqvist <jb(a)gcc.gnu.org> > + > + PR fortran/68401 > + * trans-decl.c (gfc_build_builtin_function_decls): Replace > + os_error with os_error_at decl. > + * trans.c (trans_runtime_error_vararg): Modify so the error > + function decl is passed directly. > + (gfc_trans_runtime_error): Pass correct error function decl. > + (gfc_trans_runtime_check): Likewise. > + (trans_os_error_at): New function. > + (gfc_call_malloc): Use trans_os_error_at. > + (gfc_allocate_using_malloc): Likewise. > + (gfc_call_realloc): Likewise. > + * trans.h (gfor_fndecl_os_error): Replace with gfor_fndecl_os_error_at. > + > 2019-08-16 Jeff Law <law(a)redhat.com> > Mark Eggleston <mark.eggleston(a)codethink.com> > > @@ -18,7 +33,7 @@ > * trans-common.c (find_equivalence) : New local variable dummy_symbol, > accumulated equivalence attributes from each symbol then check for > conflicts. > - > + > 2019-08-16 Richard Biener <rguenther(a)suse.de> > > * trans-intrinsic.c (gfc_conv_intrinsic_findloc): Initialize > diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c > index 2a9b852568a..3c6ab60e9b2 100644 > --- a/gcc/fortran/trans-decl.c > +++ b/gcc/fortran/trans-decl.c > @@ -102,7 +102,7 @@ tree gfor_fndecl_error_stop_string; > tree gfor_fndecl_runtime_error; > tree gfor_fndecl_runtime_error_at; > tree gfor_fndecl_runtime_warning_at; > -tree gfor_fndecl_os_error; > +tree gfor_fndecl_os_error_at; > tree gfor_fndecl_generate_error; > tree gfor_fndecl_set_args; > tree gfor_fndecl_set_fpe; > @@ -3679,11 +3679,11 @@ gfc_build_builtin_function_decls (void) > void_type_node, 3, pvoid_type_node, integer_type_node, > pchar_type_node); > > - gfor_fndecl_os_error = gfc_build_library_function_decl_with_spec ( > - get_identifier (PREFIX("os_error")), ".R", > - void_type_node, 1, pchar_type_node); > - /* The runtime_error function does not return. */ > - TREE_THIS_VOLATILE (gfor_fndecl_os_error) = 1; > + gfor_fndecl_os_error_at = gfc_build_library_function_decl_with_spec ( > + get_identifier (PREFIX("os_error_at")), ".RR", > + void_type_node, -2, pchar_type_node, pchar_type_node); > + /* The os_error_at function does not return. */ > + TREE_THIS_VOLATILE (gfor_fndecl_os_error_at) = 1; > > gfor_fndecl_set_args = gfc_build_library_function_decl ( > get_identifier (PREFIX("set_args")), > diff --git a/gcc/fortran/trans.c b/gcc/fortran/trans.c > index 84511477b39..583f6e3b25b 100644 > --- a/gcc/fortran/trans.c > +++ b/gcc/fortran/trans.c > @@ -447,7 +447,7 @@ gfc_build_array_ref (tree base, tree offset, tree decl, tree vptr) > arguments and a locus. */ > > static tree > -trans_runtime_error_vararg (bool error, locus* where, const char* msgid, > +trans_runtime_error_vararg (tree errorfunc, locus* where, const char* msgid, > va_list ap) > { > stmtblock_t block; > @@ -501,18 +501,13 @@ trans_runtime_error_vararg (bool error, locus* where, const char* msgid, > /* Build the function call to runtime_(warning,error)_at; because of the > variable number of arguments, we can't use build_call_expr_loc dinput_location, > irectly. */ > - if (error) > - fntype = TREE_TYPE (gfor_fndecl_runtime_error_at); > - else > - fntype = TREE_TYPE (gfor_fndecl_runtime_warning_at); > + fntype = TREE_TYPE (errorfunc); > > loc = where ? where->lb->location : input_location; > tmp = fold_build_call_array_loc (loc, TREE_TYPE (fntype), > fold_build1_loc (loc, ADDR_EXPR, > build_pointer_type (fntype), > - error > - ? gfor_fndecl_runtime_error_at > - : gfor_fndecl_runtime_warning_at), > + errorfunc), > nargs + 2, argarray); > gfc_add_expr_to_block (&block, tmp); > > @@ -527,7 +522,10 @@ gfc_trans_runtime_error (bool error, locus* where, const char* msgid, ...) > tree result; > > va_start (ap, msgid); > - result = trans_runtime_error_vararg (error, where, msgid, ap); > + result = trans_runtime_error_vararg (error > + ? gfor_fndecl_runtime_error_at > + : gfor_fndecl_runtime_warning_at, > + where, msgid, ap); > va_end (ap); > return result; > } > @@ -566,8 +564,10 @@ gfc_trans_runtime_check (bool error, bool once, tree cond, stmtblock_t * pblock, > /* The code to generate the error. */ > va_start (ap, msgid); > gfc_add_expr_to_block (&block, > - trans_runtime_error_vararg (error, where, > - msgid, ap)); > + trans_runtime_error_vararg > + (error ? gfor_fndecl_runtime_error_at > + : gfor_fndecl_runtime_warning_at, > + where, msgid, ap)); > va_end (ap); > > if (once) > @@ -595,13 +595,28 @@ gfc_trans_runtime_check (bool error, bool once, tree cond, stmtblock_t * pblock, > } > > > +static tree > +trans_os_error_at (locus* where, const char* msgid, ...) > +{ > + va_list ap; > + tree result; > + > + va_start (ap, msgid); > + result = trans_runtime_error_vararg (gfor_fndecl_os_error_at, > + where, msgid, ap); > + va_end (ap); > + return result; > +} > + > + > + > /* Call malloc to allocate size bytes of memory, with special conditions: > + if size == 0, return a malloced area of size 1, > + if malloc returns NULL, issue a runtime error. */ > tree > gfc_call_malloc (stmtblock_t * block, tree type, tree size) > { > - tree tmp, msg, malloc_result, null_result, res, malloc_tree; > + tree tmp, malloc_result, null_result, res, malloc_tree; > stmtblock_t block2; > > /* Create a variable to hold the result. */ > @@ -626,13 +641,14 @@ gfc_call_malloc (stmtblock_t * block, tree type, tree size) > null_result = fold_build2_loc (input_location, EQ_EXPR, > logical_type_node, res, > build_int_cst (pvoid_type_node, 0)); > - msg = gfc_build_addr_expr (pchar_type_node, > - gfc_build_localized_cstring_const ("Memory allocation failed")); > tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node, > null_result, > - build_call_expr_loc (input_location, > - gfor_fndecl_os_error, 1, msg), > - build_empty_stmt (input_location)); > + trans_os_error_at (NULL, > + "Error allocating %lu bytes", > + fold_convert > + (long_unsigned_type_node, > + size)), > + build_empty_stmt (input_location)); > gfc_add_expr_to_block (&block2, tmp); > } > > @@ -701,11 +717,9 @@ gfc_allocate_using_malloc (stmtblock_t * block, tree pointer, > } > else > { > - /* Here, os_error already implies PRED_NORETURN. */ > - tmp = build_call_expr_loc (input_location, gfor_fndecl_os_error, 1, > - gfc_build_addr_expr (pchar_type_node, > - gfc_build_localized_cstring_const > - ("Allocation would exceed memory limit"))); > + /* Here, os_error_at already implies PRED_NORETURN. */ > + tree lusize = fold_convert (long_unsigned_type_node, size); > + tmp = trans_os_error_at (NULL, "Error allocating %lu bytes", lusize); > gfc_add_expr_to_block (&on_error, tmp); > } > > @@ -1664,7 +1678,7 @@ internal_realloc (void *mem, size_t size) > tree > gfc_call_realloc (stmtblock_t * block, tree mem, tree size) > { > - tree msg, res, nonzero, null_result, tmp; > + tree res, nonzero, null_result, tmp; > tree type = TREE_TYPE (mem); > > /* Only evaluate the size once. */ > @@ -1684,12 +1698,12 @@ gfc_call_realloc (stmtblock_t * block, tree mem, tree size) > build_int_cst (size_type_node, 0)); > null_result = fold_build2_loc (input_location, TRUTH_AND_EXPR, logical_type_node, > null_result, nonzero); > - msg = gfc_build_addr_expr (pchar_type_node, gfc_build_localized_cstring_const > - ("Allocation would exceed memory limit")); > tmp = fold_build3_loc (input_location, COND_EXPR, void_type_node, > null_result, > - build_call_expr_loc (input_location, > - gfor_fndecl_os_error, 1, msg), > + trans_os_error_at (NULL, > + "Error reallocating to %lu bytes", > + fold_convert > + (long_unsigned_type_node, size)), > build_empty_stmt (input_location)); > gfc_add_expr_to_block (block, tmp); > > diff --git a/gcc/fortran/trans.h b/gcc/fortran/trans.h > index a3726e84140..8082b414df1 100644 > --- a/gcc/fortran/trans.h > +++ b/gcc/fortran/trans.h > @@ -803,7 +803,7 @@ extern GTY(()) tree gfor_fndecl_error_stop_string; > extern GTY(()) tree gfor_fndecl_runtime_error; > extern GTY(()) tree gfor_fndecl_runtime_error_at; > extern GTY(()) tree gfor_fndecl_runtime_warning_at; > -extern GTY(()) tree gfor_fndecl_os_error; > +extern GTY(()) tree gfor_fndecl_os_error_at; > extern GTY(()) tree gfor_fndecl_generate_error; > extern GTY(()) tree gfor_fndecl_set_fpe; > extern GTY(()) tree gfor_fndecl_set_options; > diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog > index 7a11ca29fd3..23a4c579351 100644 > --- a/libgfortran/ChangeLog > +++ b/libgfortran/ChangeLog > @@ -1,3 +1,11 @@ > +2019-08-17 Janne Blomqvist <jb(a)gcc.gnu.org> > + > + PR fortran/68401 > + * gfortran.map: Add GFORTRAN_10 node, add _gfortran_os_error_at > + symbol. > + * libgfortran.h (os_error_at): New prototype. > + * runtime/error.c (os_error_at): New function. > + > 2019-08-13 Janne Blomqvist <jb(a)gcc.gnu.org> > > PR fortran/91414 > diff --git a/libgfortran/gfortran.map b/libgfortran/gfortran.map > index 2b2243b4fd4..3601bc24414 100644 > --- a/libgfortran/gfortran.map > +++ b/libgfortran/gfortran.map > @@ -1602,3 +1602,8 @@ GFORTRAN_9.2 { > _gfortran_mfindloc1_r10; > _gfortran_sfindloc1_r10; > } GFORTRAN_9; > + > +GFORTRAN_10 { > + global: > + _gfortran_os_error_at; > +} GFORTRAN_9.2; > diff --git a/libgfortran/libgfortran.h b/libgfortran/libgfortran.h > index c0db96f02a8..9f535b12e73 100644 > --- a/libgfortran/libgfortran.h > +++ b/libgfortran/libgfortran.h > @@ -728,6 +728,10 @@ internal_proto(gfc_xtoa); > extern _Noreturn void os_error (const char *); > iexport_proto(os_error); > > +extern _Noreturn void os_error_at (const char *, const char *, ...) > + __attribute__ ((format (gfc_printf, 2, 3))); > +iexport_proto(os_error_at); > + > extern void show_locus (st_parameter_common *); > internal_proto(show_locus); > > diff --git a/libgfortran/runtime/error.c b/libgfortran/runtime/error.c > index 0335a165edc..cbe0642f3f8 100644 > --- a/libgfortran/runtime/error.c > +++ b/libgfortran/runtime/error.c > @@ -403,7 +403,51 @@ os_error (const char *message) > estr_writev (iov, 5); > exit_error (1); > } > -iexport(os_error); > +iexport(os_error); /* TODO, DEPRECATED, ABI: Should not be exported > + anymore when bumping so version. */ > + > + > +/* Improved version of os_error with a printf style format string and > + a locus. */ > + > +void > +os_error_at (const char *where, const char *message, ...) > +{ > + char errmsg[STRERR_MAXSZ]; > + char buffer[STRERR_MAXSZ]; > + struct iovec iov[6]; > + va_list ap; > + recursion_check (); > + int written; > + > + iov[0].iov_base = (char*) where; > + iov[0].iov_len = strlen (where); > + > + iov[1].iov_base = (char*) ": "; > + iov[1].iov_len = strlen (iov[1].iov_base); > + > + va_start (ap, message); > + written = vsnprintf (buffer, STRERR_MAXSZ, message, ap); > + va_end (ap); > + iov[2].iov_base = buffer; > + if (written >= 0) > + iov[2].iov_len = written; > + else > + iov[2].iov_len = 0; > + > + iov[3].iov_base = (char*) ": "; > + iov[3].iov_len = strlen (iov[3].iov_base); > + > + iov[4].iov_base = gf_strerror (errno, errmsg, STRERR_MAXSZ); > + iov[4].iov_len = strlen (iov[4].iov_base); > + > + iov[5].iov_base = (char*) "\n"; > + iov[5].iov_len = 1; > + > + estr_writev (iov, 6); > + exit_error (1); > +} > +iexport(os_error_at); > > > /* void runtime_error()-- These are errors associated with an > </cut>

4 years

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tk1/gnu-master-arm-spec2k6-O2_LTO - Build # 31 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tk1/gnu-master-arm-spec2k6-O2_LTO Culprit: <cut> commit 32955416d8040b1fa1ba21cd4179b3264e6c5bd6 Author: Richard Biener <rguenther(a)suse.de> Date: Mon May 3 12:07:58 2021 +0200 Improve PHI handling in DSE This improves handling of PHI defs when walking uses in dse_classify_store to track two PHI defs. This happens when there are CFG merges and one PHI feeds into another. If we decide to want more then using a sbitmap for this might be the way to go. 2021-05-03 Richard Biener <rguenther(a)suse.de> * tree-ssa-dse.c (dse_classify_store): Track two PHI defs. * gcc.dg/tree-ssa/ssa-dse-42.c: New testcase. * gcc.dg/pr81192.c: Disable DSE. </cut> Results regressed to (for first_bad == 32955416d8040b1fa1ba21cd4179b3264e6c5bd6) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO_marm -- artifacts/build-32955416d8040b1fa1ba21cd4179b3264e6c5bd6/results_id: 1 # 483.xalancbmk,Xalan_base.default regressed by 103 from (for last_good == ed3c43224cc4e378dbab066122bc63536ccb1276) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--with-mode=arm --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO_marm -- artifacts/build-ed3c43224cc4e378dbab066122bc63536ccb1276/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of last_good: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O2_LTO/458 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Results ID of first_bad: tk1_32/tcwg_bmk_gnu_tk1/bisect-gnu-master-arm-spec2k6-O2_LTO/480 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-32955416d8040b1fa1ba21cd4179b3264e6c5bd6 cd investigate-gcc-32955416d8040b1fa1ba21cd4179b3264e6c5bd6 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 32955416d8040b1fa1ba21cd4179b3264e6c5bd6 ../artifacts/test.sh # Reproduce last_good build git checkout --detach ed3c43224cc4e378dbab066122bc63536ccb1276 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tk1-gnu-master-ar… Full commit (up to 1000 lines): <cut> commit 32955416d8040b1fa1ba21cd4179b3264e6c5bd6 Author: Richard Biener <rguenther(a)suse.de> Date: Mon May 3 12:07:58 2021 +0200 Improve PHI handling in DSE This improves handling of PHI defs when walking uses in dse_classify_store to track two PHI defs. This happens when there are CFG merges and one PHI feeds into another. If we decide to want more then using a sbitmap for this might be the way to go. 2021-05-03 Richard Biener <rguenther(a)suse.de> * tree-ssa-dse.c (dse_classify_store): Track two PHI defs. * gcc.dg/tree-ssa/ssa-dse-42.c: New testcase. * gcc.dg/pr81192.c: Disable DSE. --- gcc/testsuite/gcc.dg/pr81192.c | 4 +++- gcc/testsuite/gcc.dg/tree-ssa/ssa-dse-42.c | 20 ++++++++++++++++++++ gcc/tree-ssa-dse.c | 23 ++++++++++++++--------- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/gcc/testsuite/gcc.dg/pr81192.c b/gcc/testsuite/gcc.dg/pr81192.c index 71bbc13a0e9..6cab6056558 100644 --- a/gcc/testsuite/gcc.dg/pr81192.c +++ b/gcc/testsuite/gcc.dg/pr81192.c @@ -1,4 +1,4 @@ -/* { dg-options "-Os -fdump-tree-pre-details -fdisable-tree-evrp" } */ +/* { dg-options "-Os -fdump-tree-pre-details -fdisable-tree-evrp -fno-tree-dse" } */ /* Disable tree-evrp because the new version of evrp sees <bb 3> : @@ -16,6 +16,8 @@ produces # iftmp.2_12 = PHI <2147483647(3), iftmp.2_11(4)> which causes the situation being tested to dissapear before we get to PRE. */ +/* Likewise disable DSE which also elides the tail merging "opportunity". */ + #if __SIZEOF_INT__ == 2 #define unsigned __UINT32_TYPE__ #define int __INT32_TYPE__ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-dse-42.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dse-42.c new file mode 100644 index 00000000000..34108c83828 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dse-42.c @@ -0,0 +1,20 @@ +/* { dg-do compile } */ +/* { dg-options "-O -fdump-tree-dse1" } */ + +int a[2]; +void foo(int i, int k, int j) +{ + a[0] = i; + if (k) + a[0] = a[i] + k; + else + { + if (j) + a[1] = 1; + a[0] = a[i] + 3; + } + a[0] = 0; +} + +/* The last stores to a[0] and a[1] remain. */ +/* { dg-final { scan-tree-dump-times " = " 2 "dse1" } } */ diff --git a/gcc/tree-ssa-dse.c b/gcc/tree-ssa-dse.c index e0a944c704a..dfa6d314727 100644 --- a/gcc/tree-ssa-dse.c +++ b/gcc/tree-ssa-dse.c @@ -799,7 +799,8 @@ dse_classify_store (ao_ref *ref, gimple *stmt, return DSE_STORE_LIVE; auto_vec<gimple *, 10> defs; - gimple *phi_def = NULL; + gimple *first_phi_def = NULL; + gimple *last_phi_def = NULL; FOR_EACH_IMM_USE_STMT (use_stmt, ui, defvar) { /* Limit stmt walking. */ @@ -825,7 +826,9 @@ dse_classify_store (ao_ref *ref, gimple *stmt, SSA_NAME_VERSION (PHI_RESULT (use_stmt)))) { defs.safe_push (use_stmt); - phi_def = use_stmt; + if (!first_phi_def) + first_phi_def = use_stmt; + last_phi_def = use_stmt; } } /* If the statement is a use the store is not dead. */ @@ -889,6 +892,8 @@ dse_classify_store (ao_ref *ref, gimple *stmt, gimple *def = defs[i]; gimple *use_stmt; use_operand_p use_p; + tree vdef = (gimple_code (def) == GIMPLE_PHI + ? gimple_phi_result (def) : gimple_vdef (def)); /* If the path to check starts with a kill we do not need to process it further. ??? With byte tracking we need only kill the bytes currently @@ -901,8 +906,7 @@ dse_classify_store (ao_ref *ref, gimple *stmt, } /* If the path ends here we do not need to process it further. This for example happens with calls to noreturn functions. */ - else if (gimple_code (def) != GIMPLE_PHI - && has_zero_uses (gimple_vdef (def))) + else if (has_zero_uses (vdef)) { /* But if the store is to global memory it is definitely not dead. */ @@ -912,12 +916,13 @@ dse_classify_store (ao_ref *ref, gimple *stmt, } /* In addition to kills we can remove defs whose only use is another def in defs. That can only ever be PHIs of which - we track a single for simplicity reasons (we fail for multiple - PHIs anyways). We can also ignore defs that feed only into + we track two for simplicity reasons, the first and last in + {first,last}_phi_def (we fail for multiple PHIs anyways). + We can also ignore defs that feed only into already visited PHIs. */ - else if (gimple_code (def) != GIMPLE_PHI - && single_imm_use (gimple_vdef (def), &use_p, &use_stmt) - && (use_stmt == phi_def + else if (single_imm_use (vdef, &use_p, &use_stmt) + && (use_stmt == first_phi_def + || use_stmt == last_phi_def || (gimple_code (use_stmt) == GIMPLE_PHI && bitmap_bit_p (visited, SSA_NAME_VERSION </cut>

4 years

3
2
0 0

[ACTIVITY] 14 - 25 June 2021

by Prathamesh Kulkarni

== This Week == * PR97906 (missed lowering to vac) - Committed patch. * PR66791 (replace builtins with vector extensions in neon intrinsics): - Committed patch for vceq - Submitted patch for vca - Submitted patch for vdup * PR98435 (missed opt in expanding vector constructor) - Patch conditionally approved by Kyrill == Next Week == - PR98435: Address changes and commit the fix. - PR66791: Continue with intrinsics.

4 years

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O2 - Build # 21 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2 Culprit: <cut> commit 87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb Author: GCC Administrator <gccadmin(a)gcc.gnu.org> Date: Sat May 15 00:16:27 2021 +0000 Daily bump. </cut> Results regressed to (for first_bad == 87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2 -- artifacts/build-87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb/results_id: 1 # 459.GemsFDTD,GemsFDTD_base.default regressed by 103 from (for last_good == 0e3702f8daeec5897982d185650b78a5c1c53c25) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2 -- artifacts/build-0e3702f8daeec5897982d185650b78a5c1c53c25/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2/533 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2/530 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb cd investigate-gcc-87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach 87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb ../artifacts/test.sh # Reproduce last_good build git checkout --detach 0e3702f8daeec5897982d185650b78a5c1c53c25 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit 87a7d10c2e9ec34a276e6acb5d2282a35b9cfafb Author: GCC Administrator <gccadmin(a)gcc.gnu.org> Date: Sat May 15 00:16:27 2021 +0000 Daily bump. --- contrib/ChangeLog | 14 +++++++++++ gcc/ChangeLog | 55 ++++++++++++++++++++++++++++++++++++++++++++ gcc/DATESTAMP | 2 +- gcc/ada/ChangeLog | 6 +++++ gcc/c-family/ChangeLog | 4 ++++ gcc/cp/ChangeLog | 21 +++++++++++++++++ gcc/fortran/ChangeLog | 25 ++++++++++++++++++++ gcc/testsuite/ChangeLog | 42 +++++++++++++++++++++++++++++++++ libgomp/ChangeLog | 4 ++++ libphobos/ChangeLog | 5 ++++ maintainer-scripts/ChangeLog | 4 ++++ 11 files changed, 181 insertions(+), 1 deletion(-) diff --git a/contrib/ChangeLog b/contrib/ChangeLog index f7c1e867879..8e393b7ed72 100644 --- a/contrib/ChangeLog +++ b/contrib/ChangeLog @@ -1,3 +1,17 @@ +2021-05-14 Martin Liska <mliska(a)suse.cz> + + * download_prerequisites: Use version 4.1.0. + +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + * gcc-changelog/git_update_version.py: Remove releases/gcc-8 from + active_refs. + +2021-05-14 Martin Liska <mliska(a)suse.cz> + + * gcc-changelog/git_commit.py: Support Co-Authored-By before + a first ChangeLog entry. + 2021-05-13 Martin Liska <mliska(a)suse.cz> * mklog.py: Put PR entries before all ChangeLog entries diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3b937d4d66f..dfa8ae2824f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,58 @@ +2021-05-14 Jason Merrill <jason(a)redhat.com> + + * intl.h: Add comments. + +2021-05-14 Kyrylo Tkachov <kyrylo.tkachov(a)arm.com> + + * config/aarch64/aarch64-simd.md + (aarch64_sqdml<SBINQOPS:as>l2_lane<mode>_internal): Split into... + (aarch64_sqdmlsl2_lane<mode>_internal): ... This... + (aarch64_sqdmlal2_lane<mode>_internal): ... And this. + (aarch64_sqdml<SBINQOPS:as>l2_laneq<mode>_internal): Split into ... + (aarch64_sqdmlsl2_laneq<mode>_internal): ... This... + (aarch64_sqdmlal2_laneq<mode>_internal): ... And this. + (aarch64_sqdml<SBINQOPS:as>l2_n<mode>_internal): Split into... + (aarch64_sqdmlsl2_n<mode>_internal): ... This... + (aarch64_sqdmlal2_n<mode>_internal): ... And this. + +2021-05-14 Prathamesh Kulkarni <prathamesh.kulkarni(a)linaro.org> + + PR target/66791 + * config/arm/arm_neon.h (vtst_s8): Replace call to vtst builtin with it's + boolean logic equivalent. + (vtst_s16): Likewise. + (vtst_s32): Likewise. + (vtst_u8): Likewise. + (vtst_u16): Likewise. + (vtst_u32): Likewise. + (vtst_p8): Likewise. + (vtst_p16): Likewise. + (vtstq_s8): Likewise. + (vtstq_s16): Likewise. + (vtstq_s32): Likewise. + (vtstq_u8): Likewise. + (vtstq_u16): Likewise. + (vtstq_u32): Likewise. + (vtstq_p8): Likewise. + (vtstq_p16): Likewise. + * config/arm/arm_neon_builtins.def: Remove entry for vtst. + * config/arm/neon.md (neon_vtst<mode>): Remove pattern. + +2021-05-14 Kyrylo Tkachov <kyrylo.tkachov(a)arm.com> + + * config/aarch64/aarch64-simd.md (aarch64_sqdmlal2<mode>): Merge into... + (aarch64_sqdml<SBINQOPS:as>l2<mode>): ... This. + (aarch64_sqdmlsl2<mode>): Delete. + (aarch64_sqdmlal2_lane<mode>): Merge this... + (aarch64_sqdmlsl2_lane<mode>): ... And this... + (aarch64_sqdml<SBINQOPS:as>l2_lane<mode>): ... Into this. + (aarch64_sqdmlal2_laneq<mode>): Merge this... + (aarch64_sqdmlsl2_laneq<mode>): ... And this... + (aarch64_sqdml<SBINQOPS:as>l2_laneq<mode>): ... Into this. + (aarch64_sqdmlal2_n<mode>): Merge this... + (aarch64_sqdmlsl2_n<mode>): ... And this... + (aarch64_sqdml<SBINQOPS:as>l2_n<mode>): ... Into this. + 2021-05-13 Martin Sebor <msebor(a)redhat.com> PR middle-end/100574 diff --git a/gcc/DATESTAMP b/gcc/DATESTAMP index 552c3b209c0..40eb1cad583 100644 --- a/gcc/DATESTAMP +++ b/gcc/DATESTAMP @@ -1 +1 @@ -20210514 +20210515 diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index 2279e46b775..514682006a7 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,9 @@ +2021-05-14 Martin Liska <mliska(a)suse.cz> + + * doc/Makefile: Add gnat-style target. + * doc/share/conf.py: Likewise. + * doc/gnat-style.rst: New file. + 2021-05-12 Bob Duff <duff(a)adacore.com> PR ada/100564 diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog index d33ad4a4c57..7fc64a513d5 100644 --- a/gcc/c-family/ChangeLog +++ b/gcc/c-family/ChangeLog @@ -1,3 +1,7 @@ +2021-05-14 Martin Liska <mliska(a)suse.cz> + + * c.opt: Add Warning keyword for 2 options. + 2021-05-13 Martin Liska <mliska(a)suse.cz> PR middle-end/100504 diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 5a8a650d3d7..48425b9dc67 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,24 @@ +2021-05-14 Jason Merrill <jason(a)redhat.com> + + PR c++/95870 + * pt.c (enclosing_instantiation_of): Just compare + DECL_SOURCE_LOCATION. + (regenerate_decl_from_template): Copy DECL_SOURCE_LOCATION. + +2021-05-14 Marek Polacek <polacek(a)redhat.com> + Jason Merrill <jason(a)redhat.com> + + PR c++/99032 + * cp-tree.h (any_non_type_attribute_p): Declare. + * decl.c (grokdeclarator): Diagnose when an attribute appertains to + a friend declaration that is not a definition. + * decl2.c (any_non_type_attribute_p): New. + * parser.c (cp_parser_decl_specifier_seq): Diagnose standard attributes + in the middle of decl-specifiers. + (cp_parser_elaborated_type_specifier): Diagnose when an attribute + appertains to a friend declaration that is not a definition. + (cp_parser_member_declaration): Likewise. + 2021-05-12 Marek Polacek <polacek(a)redhat.com> * pt.c (tsubst_copy_and_build): Add warn_int_in_bool_context diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 71cc3d86491..781dedd8220 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,28 @@ +2021-05-14 Tobias Burnus <tobias(a)codesourcery.com> + + * dump-parse-tree.c (show_omp_node, show_code_node): Handle + EXEC_OMP_PARALLEL_MASTER. + * frontend-passes.c (gfc_code_walker): Likewise. + * gfortran.h (enum gfc_statement): Add ST_OMP_PARALLEL_MASTER and + ST_OMP_END_PARALLEL_MASTER. + (enum gfc_exec_op): Add EXEC_OMP_PARALLEL_MASTER.. + * match.h (gfc_match_omp_parallel_master): Handle it. + * openmp.c (gfc_match_omp_parallel_master, resolve_omp_clauses, + omp_code_to_statement, gfc_resolve_omp_directive): Likewise. + * parse.c (decode_omp_directive, case_exec_markers, + gfc_ascii_statement, parse_omp_structured_block, + parse_executable): Likewise. + * resolve.c (gfc_resolve_blocks, gfc_resolve_code): Likewise. + * st.c (gfc_free_statement): Likewise. + * trans-openmp.c (gfc_trans_omp_parallel_master, + gfc_trans_omp_workshare, gfc_trans_omp_directive): Likewise. + * trans.c (trans_code): Likewise. + +2021-05-14 Tobias Burnus <tobias(a)codesourcery.com> + + * resolve.c (resolve_symbol): Handle implicit SAVE of main-program + for vars in 'omp threadprivate' and 'omp declare target'. + 2021-05-10 Martin Liska <mliska(a)suse.cz> * decl.c (variable_decl): Use startswith diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 9dfab7b873d..564795068b0 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,45 @@ +2021-05-14 Tobias Burnus <tobias(a)codesourcery.com> + + * gfortran.dg/gomp/parallel-master-1.f90: New test. + * gfortran.dg/gomp/parallel-master-2.f90: New test. + +2021-05-14 Tobias Burnus <tobias(a)codesourcery.com> + + * gfortran.dg/gomp/implicit-save.f90: New test. + +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + PR c++/95226 + * g++.dg/cpp1y/pr95226.C: New test. + +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + PR c++/94616 + * g++.dg/cpp0x/pr94616.C: New test. + +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + PR c++/90019 + * g++.dg/cpp0x/sfinae68.C: New test. + +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + * g++.dg/cpp1y/pr88872.C: New test. + +2021-05-14 Michael de Lang <kingoipo(a)gmail.com> + + * g++.dg/tsan/pthread_cond_clockwait.C: New test. + +2021-05-14 Marek Polacek <polacek(a)redhat.com> + Jason Merrill <jason(a)redhat.com> + + PR c++/99032 + * g++.dg/cpp0x/friend7.C: New test. + * g++.dg/cpp0x/gen-attrs-4.C: Add dg-error. + * g++.dg/cpp0x/gen-attrs-39-1.C: Likewise. + * g++.dg/cpp0x/gen-attrs-74.C: New test. + * g++.dg/ext/attrib63.C: New test. + 2021-05-13 Martin Sebor <msebor(a)redhat.com> PR tree-optimization/93100 diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 1daf0c82f2c..424c574dce8 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,7 @@ +2021-05-14 Tobias Burnus <tobias(a)codesourcery.com> + + * testsuite/libgomp.fortran/parallel-master.f90: New test. + 2021-05-13 Martin Liska <mliska(a)suse.cz> PR testsuite/100569 diff --git a/libphobos/ChangeLog b/libphobos/ChangeLog index 7574416b9aa..7b57d92f64a 100644 --- a/libphobos/ChangeLog +++ b/libphobos/ChangeLog @@ -1,3 +1,8 @@ +2021-05-14 Bernd Edlinger <bernd.edlinger(a)hotmail.de> + + * src/std/process.d (unittest): Remove tmpname on exit. + * src/MERGE: Merge upstream phobos 63f4caa90. + 2021-05-13 Iain Buclaw <ibuclaw(a)gdcproject.org> * libdruntime/MERGE: Merge upstream druntime 98c6ff0c. diff --git a/maintainer-scripts/ChangeLog b/maintainer-scripts/ChangeLog index ab18cfd905d..8f306552396 100644 --- a/maintainer-scripts/ChangeLog +++ b/maintainer-scripts/ChangeLog @@ -1,3 +1,7 @@ +2021-05-14 Jakub Jelinek <jakub(a)redhat.com> + + * crontab: Stop doing gcc-8 snapshots. + 2021-04-20 Jakub Jelinek <jakub(a)redhat.com> * crontab: Snapshots from trunk are now GCC 12 related. </cut>

4 years

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O2_LTO - Build # 18 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *glibc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO Culprit: <cut> commit f79f2065817e080f65f3c3a2fee966f5a97f1746 Author: Florian Weimer <fweimer(a)redhat.com> Date: Wed Apr 21 19:49:50 2021 +0200 nptl: Move legacy unwinding implementation into libc It is still used internally. Since unwinding is now available unconditionally, avoid indirect calls through function pointers loaded from the stack by inlining the non-cancellation cleanup code. This avoids a regression in security hardening. The out-of-line __libc_cleanup_routine implementation is no longer needed because the inline definition is now static __always_inline. Reviewed-by: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> </cut> Results regressed to (for first_bad == f79f2065817e080f65f3c3a2fee966f5a97f1746) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-f79f2065817e080f65f3c3a2fee966f5a97f1746/results_id: 1 # 410.bwaves,bwaves_base.default regressed by 104 from (for last_good == 5715c29e91076800418833f2196f2082f439da75) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-5715c29e91076800418833f2196f2082f439da75/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/461 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/470 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-glibc-f79f2065817e080f65f3c3a2fee966f5a97f1746 cd investigate-glibc-f79f2065817e080f65f3c3a2fee966f5a97f1746 git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd glibc # Reproduce first_bad build git checkout --detach f79f2065817e080f65f3c3a2fee966f5a97f1746 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 5715c29e91076800418833f2196f2082f439da75 ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit f79f2065817e080f65f3c3a2fee966f5a97f1746 Author: Florian Weimer <fweimer(a)redhat.com> Date: Wed Apr 21 19:49:50 2021 +0200 nptl: Move legacy unwinding implementation into libc It is still used internally. Since unwinding is now available unconditionally, avoid indirect calls through function pointers loaded from the stack by inlining the non-cancellation cleanup code. This avoids a regression in security hardening. The out-of-line __libc_cleanup_routine implementation is no longer needed because the inline definition is now static __always_inline. Reviewed-by: Adhemerval Zanella <adhemerval.zanella(a)linaro.org> --- nptl/Versions | 2 ++ nptl/cleanup_defer_compat.c | 56 ++--------------------------------- nptl/libc-cleanup.c | 64 ++++++++++++++++++++++++++++++++++++++-- nptl/nptl-init.c | 2 -- sysdeps/nptl/libc-lock.h | 59 ++++++++++++++++++------------------ sysdeps/nptl/libc-lockP.h | 26 +--------------- sysdeps/nptl/pthread-functions.h | 4 --- 7 files changed, 97 insertions(+), 116 deletions(-) diff --git a/nptl/Versions b/nptl/Versions index 60202b4969..2e5a964b11 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -87,6 +87,8 @@ libc { __futex_abstimed_wait64; __futex_abstimed_wait_cancelable64; __libc_alloca_cutoff; + __libc_cleanup_pop_restore; + __libc_cleanup_push_defer; __libc_dl_error_tsd; __libc_pthread_init; __lll_clocklock_elision; diff --git a/nptl/cleanup_defer_compat.c b/nptl/cleanup_defer_compat.c index 49ef53ea60..1957318208 100644 --- a/nptl/cleanup_defer_compat.c +++ b/nptl/cleanup_defer_compat.c @@ -17,41 +17,15 @@ <https://www.gnu.org/licenses/>. */ #include "pthreadP.h" - +#include <libc-lock.h> void _pthread_cleanup_push_defer (struct _pthread_cleanup_buffer *buffer, void (*routine) (void *), void *arg) { - struct pthread *self = THREAD_SELF; - buffer->__routine = routine; buffer->__arg = arg; - buffer->__prev = THREAD_GETMEM (self, cleanup); - - int cancelhandling = THREAD_GETMEM (self, cancelhandling); - - /* Disable asynchronous cancellation for now. */ - if (__glibc_unlikely (cancelhandling & CANCELTYPE_BITMASK)) - while (1) - { - int curval = THREAD_ATOMIC_CMPXCHG_VAL (self, cancelhandling, - cancelhandling - & ~CANCELTYPE_BITMASK, - cancelhandling); - if (__glibc_likely (curval == cancelhandling)) - /* Successfully replaced the value. */ - break; - - /* Prepare for the next round. */ - cancelhandling = curval; - } - - buffer->__canceltype = (cancelhandling & CANCELTYPE_BITMASK - ? PTHREAD_CANCEL_ASYNCHRONOUS - : PTHREAD_CANCEL_DEFERRED); - - THREAD_SETMEM (self, cleanup, buffer); + __libc_cleanup_push_defer (buffer); } strong_alias (_pthread_cleanup_push_defer, __pthread_cleanup_push_defer) @@ -60,31 +34,7 @@ void _pthread_cleanup_pop_restore (struct _pthread_cleanup_buffer *buffer, int execute) { - struct pthread *self = THREAD_SELF; - - THREAD_SETMEM (self, cleanup, buffer->__prev); - - int cancelhandling; - if (__builtin_expect (buffer->__canceltype != PTHREAD_CANCEL_DEFERRED, 0) - && ((cancelhandling = THREAD_GETMEM (self, cancelhandling)) - & CANCELTYPE_BITMASK) == 0) - { - while (1) - { - int curval = THREAD_ATOMIC_CMPXCHG_VAL (self, cancelhandling, - cancelhandling - | CANCELTYPE_BITMASK, - cancelhandling); - if (__glibc_likely (curval == cancelhandling)) - /* Successfully replaced the value. */ - break; - - /* Prepare for the next round. */ - cancelhandling = curval; - } - - CANCELLATION_P (self); - } + __libc_cleanup_pop_restore (buffer); /* If necessary call the cleanup routine after we removed the current cleanup block from the list. */ diff --git a/nptl/libc-cleanup.c b/nptl/libc-cleanup.c index 61f97eceda..14ccfe9285 100644 --- a/nptl/libc-cleanup.c +++ b/nptl/libc-cleanup.c @@ -17,11 +17,69 @@ <https://www.gnu.org/licenses/>. */ #include "pthreadP.h" +#include <tls.h> +#include <libc-lock.h> +void +__libc_cleanup_push_defer (struct _pthread_cleanup_buffer *buffer) +{ + struct pthread *self = THREAD_SELF; + + buffer->__prev = THREAD_GETMEM (self, cleanup); + + int cancelhandling = THREAD_GETMEM (self, cancelhandling); + + /* Disable asynchronous cancellation for now. */ + if (__glibc_unlikely (cancelhandling & CANCELTYPE_BITMASK)) + while (1) + { + int curval = THREAD_ATOMIC_CMPXCHG_VAL (self, cancelhandling, + cancelhandling + & ~CANCELTYPE_BITMASK, + cancelhandling); + if (__glibc_likely (curval == cancelhandling)) + /* Successfully replaced the value. */ + break; + + /* Prepare for the next round. */ + cancelhandling = curval; + } + + buffer->__canceltype = (cancelhandling & CANCELTYPE_BITMASK + ? PTHREAD_CANCEL_ASYNCHRONOUS + : PTHREAD_CANCEL_DEFERRED); + + THREAD_SETMEM (self, cleanup, buffer); +} +libc_hidden_def (__libc_cleanup_push_defer) void -__libc_cleanup_routine (struct __pthread_cleanup_frame *f) +__libc_cleanup_pop_restore (struct _pthread_cleanup_buffer *buffer) { - if (f->__do_it) - f->__cancel_routine (f->__cancel_arg); + struct pthread *self = THREAD_SELF; + + THREAD_SETMEM (self, cleanup, buffer->__prev); + + int cancelhandling; + if (__builtin_expect (buffer->__canceltype != PTHREAD_CANCEL_DEFERRED, 0) + && ((cancelhandling = THREAD_GETMEM (self, cancelhandling)) + & CANCELTYPE_BITMASK) == 0) + { + while (1) + { + int curval = THREAD_ATOMIC_CMPXCHG_VAL (self, cancelhandling, + cancelhandling + | CANCELTYPE_BITMASK, + cancelhandling); + if (__glibc_likely (curval == cancelhandling)) + /* Successfully replaced the value. */ + break; + + /* Prepare for the next round. */ + cancelhandling = curval; + } + + CANCELLATION_P (self); + } } +libc_hidden_def (__libc_cleanup_pop_restore) diff --git a/nptl/nptl-init.c b/nptl/nptl-init.c index 2c7e2222d4..43e2564e59 100644 --- a/nptl/nptl-init.c +++ b/nptl/nptl-init.c @@ -95,8 +95,6 @@ static const struct pthread_functions pthread_functions = .ptr___pthread_key_create = __pthread_key_create, .ptr___pthread_getspecific = __pthread_getspecific, .ptr___pthread_setspecific = __pthread_setspecific, - .ptr__pthread_cleanup_push_defer = __pthread_cleanup_push_defer, - .ptr__pthread_cleanup_pop_restore = __pthread_cleanup_pop_restore, .ptr_nthreads = &__nptl_nthreads, .ptr___pthread_unwind = &__pthread_unwind, .ptr__nptl_deallocate_tsd = __nptl_deallocate_tsd, diff --git a/sysdeps/nptl/libc-lock.h b/sysdeps/nptl/libc-lock.h index dea96121b3..e8a5e68a12 100644 --- a/sysdeps/nptl/libc-lock.h +++ b/sysdeps/nptl/libc-lock.h @@ -143,39 +143,40 @@ typedef struct __libc_lock_recursive_opaque__ __libc_lock_recursive_t; __libc_maybe_call (__pthread_mutex_unlock, (&(NAME).mutex), 0) #endif -/* Note that for I/O cleanup handling we are using the old-style - cancel handling. It does not have to be integrated with C++ since - no C++ code is called in the middle. The old-style handling is - faster and the support is not going away. */ -extern void _pthread_cleanup_push_defer (struct _pthread_cleanup_buffer *buffer, - void (*routine) (void *), void *arg); -extern void _pthread_cleanup_pop_restore (struct _pthread_cleanup_buffer *buffer, - int execute); +/* Put the unwind buffer BUFFER on the per-thread callback stack. The + caller must fill BUFFER->__routine and BUFFER->__arg before calling + this function. */ +void __libc_cleanup_push_defer (struct _pthread_cleanup_buffer *buffer); +libc_hidden_proto (__libc_cleanup_push_defer) +/* Remove BUFFER from the unwind callback stack. The caller must invoke + the callback if desired. */ +void __libc_cleanup_pop_restore (struct _pthread_cleanup_buffer *buffer); +libc_hidden_proto (__libc_cleanup_pop_restore) /* Start critical region with cleanup. */ -#define __libc_cleanup_region_start(DOIT, FCT, ARG) \ - { struct _pthread_cleanup_buffer _buffer; \ - int _avail; \ - if (DOIT) { \ - _avail = PTFAVAIL (_pthread_cleanup_push_defer); \ - if (_avail) { \ - __libc_ptf_call_always (_pthread_cleanup_push_defer, (&_buffer, FCT, \ - ARG)); \ - } else { \ - _buffer.__routine = (FCT); \ - _buffer.__arg = (ARG); \ - } \ - } else { \ - _avail = 0; \ - } +#define __libc_cleanup_region_start(DOIT, FCT, ARG) \ + { bool _cleanup_start_doit; \ + struct _pthread_cleanup_buffer _buffer; \ + /* Non-addressable copy of FCT, so that we avoid indirect calls on \ + the non-unwinding path. */ \ + void (*_cleanup_routine) (void *) = (FCT); \ + _buffer.__arg = (ARG); \ + if (DOIT) \ + { \ + _cleanup_start_doit = true; \ + _buffer.__routine = _cleanup_routine; \ + __libc_cleanup_push_defer (&_buffer); \ + } \ + else \ + _cleanup_start_doit = false; /* End critical region with cleanup. */ -#define __libc_cleanup_region_end(DOIT) \ - if (_avail) { \ - __libc_ptf_call_always (_pthread_cleanup_pop_restore, (&_buffer, DOIT));\ - } else if (DOIT) \ - _buffer.__routine (_buffer.__arg); \ - } +#define __libc_cleanup_region_end(DOIT) \ + if (_cleanup_start_doit) \ + __libc_cleanup_pop_restore (&_buffer); \ + if (DOIT) \ + _cleanup_routine (_buffer.__arg); \ + } /* matches __libc_cleanup_region_start */ /* Hide the definitions which are only supposed to be used inside libc in diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h index 63b605dee2..2c928b7a76 100644 --- a/sysdeps/nptl/libc-lockP.h +++ b/sysdeps/nptl/libc-lockP.h @@ -251,32 +251,12 @@ _Static_assert (LLL_LOCK_INITIALIZER == 0, "LLL_LOCK_INITIALIZER != 0"); /* Get once control variable. */ #define __libc_once_get(ONCE_CONTROL) ((ONCE_CONTROL) != PTHREAD_ONCE_INIT) -/* Note that for I/O cleanup handling we are using the old-style - cancel handling. It does not have to be integrated with C++ snce - no C++ code is called in the middle. The old-style handling is - faster and the support is not going away. */ -extern void _pthread_cleanup_push (struct _pthread_cleanup_buffer *buffer, - void (*routine) (void *), void *arg); -extern void _pthread_cleanup_pop (struct _pthread_cleanup_buffer *buffer, - int execute); -extern void _pthread_cleanup_push_defer (struct _pthread_cleanup_buffer *buffer, - void (*routine) (void *), void *arg); -extern void _pthread_cleanup_pop_restore (struct _pthread_cleanup_buffer *buffer, - int execute); - -/* Sometimes we have to exit the block in the middle. */ -#define __libc_cleanup_end(DOIT) \ - if (_avail) { \ - __libc_ptf_call_always (_pthread_cleanup_pop_restore, (&_buffer, DOIT));\ - } else if (DOIT) \ - _buffer.__routine (_buffer.__arg) - /* __libc_cleanup_push and __libc_cleanup_pop depend on exception handling and stack unwinding. */ #ifdef __EXCEPTIONS /* Normal cleanup handling, based on C cleanup attribute. */ -__extern_inline void +static __always_inline void __libc_cleanup_routine (struct __pthread_cleanup_frame *f) { if (f->__do_it) @@ -388,8 +368,6 @@ weak_extern (__pthread_once) weak_extern (__pthread_initialize) weak_extern (__pthread_atfork) weak_extern (__pthread_setcancelstate) -weak_extern (_pthread_cleanup_push_defer) -weak_extern (_pthread_cleanup_pop_restore) # else # pragma weak __pthread_mutex_init # pragma weak __pthread_mutex_destroy @@ -412,8 +390,6 @@ weak_extern (_pthread_cleanup_pop_restore) # pragma weak __pthread_initialize # pragma weak __pthread_atfork # pragma weak __pthread_setcancelstate -# pragma weak _pthread_cleanup_push_defer -# pragma weak _pthread_cleanup_pop_restore # endif #endif diff --git a/sysdeps/nptl/pthread-functions.h b/sysdeps/nptl/pthread-functions.h index 97a5c48939..4268084b66 100644 --- a/sysdeps/nptl/pthread-functions.h +++ b/sysdeps/nptl/pthread-functions.h @@ -57,10 +57,6 @@ struct pthread_functions int (*ptr___pthread_key_create) (pthread_key_t *, void (*) (void *)); void *(*ptr___pthread_getspecific) (pthread_key_t); int (*ptr___pthread_setspecific) (pthread_key_t, const void *); - void (*ptr__pthread_cleanup_push_defer) (struct _pthread_cleanup_buffer *, - void (*) (void *), void *); - void (*ptr__pthread_cleanup_pop_restore) (struct _pthread_cleanup_buffer *, - int); #define HAVE_PTR_NTHREADS unsigned int *ptr_nthreads; void (*ptr___pthread_unwind) (__pthread_unwind_buf_t *) </cut>

4 years

3
3
0 0

[ACTIVITY] week ending Jun. 27 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - spent some time trying to get Xen working on MachiatoBin again - almost working, need SMC/HVC passthrough for platform [STR-9] <https://projects.linaro.org/browse/STR-9> QEMU Upstream Work ([UM-2]) =========================== - posted [[PATCH v3 0/2] semihosting/next (SYS_HEAPINFO)] - posted [PULL 0/7] misc fixes (docs, plugins, tests) Message-Id: <20210625091355.25673-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> [[PATCH v3 0/2] semihosting/next (SYS_HEAPINFO)] <gnus:nntp+news.gmane.io:gmane.comp.emulators.qemu#20210615165800.23265-1-alex.bennee@linaro.org> [RFC PATCH] semihosting/arm-compat: remove heuristic softmmu SYS_HEAPINFO Message-Id: <20210601090715.22330-1-alex.bennee(a)linaro.org> Other ===== - ARM CCA Announcement Event - Rust Training Completed Reviews [9/9] ======================= [PATCH 00/11] softfloat: Improve denormal handling Message-Id: <20210527041405.391567-1-richard.henderson(a)linaro.org> [PATCH v2 00/28] Convert floatx80 and float128 to FloatParts Message-Id: <20210525150706.294968-1-richard.henderson(a)linaro.org> [PATCH 00/11] softfloat: Improve denormal handling Message-Id: <20210527041405.391567-1-richard.henderson(a)linaro.org> [PATCH v3 00/28] tcg: Clean up code_gen_buffer allocation Message-Id: <20210502231844.1977630-1-richard.henderson(a)linaro.org> Re: [PATCH] replay: fix watchpoint processing for reverse debugging Message-Id: <fc75c7b5-e99c-f558-d24f-519041aa8d46(a)ispras.ru> [Email from Richard Henderson: [PATCH v2 0/8] configure: Change to -std=gnu11] [Email from Richard Henderson: [PATCH v2 0/8] configure: Change to -std=gnu11] <gnus:nntp+news.gmane.io:gmane.comp.emulators.qemu#20210614233143.1221879-1-richard.henderson@linaro.org> [PATCH] i386: load kernel on xen using DMA Message-Id: <20210426034709.595432-1-marmarek(a)invisiblethingslab.com> [PATCH v2 0/2] execlog TCG plugin to log instructions Message-Id: <20210618091101.2802534-1-erdnaxe(a)crans.org> [RFC PATCH v3 0/4] Cache TCG plugin & symbol-resolution API Message-Id: <20210608040532.56449-1-ma.mandourr(a)gmail.com> Absences ======== Current Review Queue ==================== TODO [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb Message-Id: <20210621013439.1791385-1-richard.henderson(a)linaro.org> ================================================================================================================================= TODO [Email from Mathieu Poirier: [PATCH v2 0/5] virtio: Add vhost-user based RNG] ================================================================================== [Email from Mathieu Poirier: [PATCH v2 0/5] virtio: Add vhost-user based RNG] <gnus:nntp+news.gmane.io:gmane.comp.emulators.qemu#20210614202842.581640-1-mathieu.poirier@linaro.org> TODO [PATCH 0/5] virtio: Add vhost-user based RNG service Message-Id: <20210601200305.1772391-1-mathieu.poirier(a)linaro.org> ========================================================================================================================== TODO [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd. -- Alex Bennée

4 years

1
0
0 0

[ACTIVITY] report week ending 25 Jun

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Not much this week. Reviewed rth's bswap improvement/cleanup series * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Implemented logical-immediate insns; various vector shifts; VADDLV; some of the scalar shifts that work on general-purpose registers + Fixed a few bugs in already-implemented insns (widening/narrowing load/store, and VRMLALDAVH, VRMLSLDAVH) + Progress: 102/210 (48%) -- PMM

4 years

1
0
0 0

[CI-NOTIFY]: TCWG Bisect tcwg_bmk_tx1/gnu-master-aarch64-spec2k6-O2_LTO - Build # 16 - Successful!

by ci_notify＠linaro.org

Successfully identified regression in *gcc* in CI configuration tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO. So far, this commit has regressed CI configurations: - tcwg_bmk_gnu_tx1/gnu-master-aarch64-spec2k6-O2_LTO Culprit: <cut> commit de56f95afaaa22c67cbeec780921d63e8b34514e Author: Xionghu Luo <luoxhu(a)linux.ibm.com> Date: Tue May 18 21:34:18 2021 -0500 Run pass_sink_code once more before store_merging Gimple sink code pass runs quite early, there may be some new oppertunities exposed by later gimple optmization passes, this patch runs the sink code pass once more before store_merging. For detailed discussion, please refer to: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562352.html Tested the SPEC2017 performance on P8LE, 544.nab_r is improved by 2.43%, but no big changes to other cases, GEOMEAN is improved quite small with 0.25%. gcc/ChangeLog: 2021-05-18 Xionghu Luo <luoxhu(a)linux.ibm.com> * passes.def: Add sink_code pass before store_merging. * tree-ssa-sink.c (pass_sink_code:clone): New. gcc/testsuite/ChangeLog: 2021-05-18 Xionghu Luo <luoxhu(a)linux.ibm.com> * gcc.dg/tree-ssa/ssa-sink-1.c: Adjust. * gcc.dg/tree-ssa/ssa-sink-2.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-3.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-4.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-5.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-6.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-7.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-8.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-9.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-10.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-13.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-14.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-16.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-17.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-18.c: New. </cut> Results regressed to (for first_bad == de56f95afaaa22c67cbeec780921d63e8b34514e) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-de56f95afaaa22c67cbeec780921d63e8b34514e/results_id: 1 # 447.dealII,dealII_base.default regressed by 103 from (for last_good == 39ed6a88c74db5412652f0167d03f71eca4f02fc) # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer: -8 # build_abe linux: -7 # build_abe glibc: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer: -5 # true: 0 # benchmark -O2_LTO -- artifacts/build-39ed6a88c74db5412652f0167d03f71eca4f02fc/results_id: 1 Artifacts of last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of last_good: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/381 Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Results ID of first_bad: tx1_64/tcwg_bmk_gnu_tx1/bisect-gnu-master-aarch64-spec2k6-O2_LTO/350 Build top page/logs: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Configuration details: Reproduce builds: <cut> mkdir investigate-gcc-de56f95afaaa22c67cbeec780921d63e8b34514e cd investigate-gcc-de56f95afaaa22c67cbeec780921d63e8b34514e git clone https://git.linaro.org/toolchain/jenkins-scripts mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh cd gcc # Reproduce first_bad build git checkout --detach de56f95afaaa22c67cbeec780921d63e8b34514e ../artifacts/test.sh # Reproduce last_good build git checkout --detach 39ed6a88c74db5412652f0167d03f71eca4f02fc ../artifacts/test.sh cd .. </cut> History of pending regressions and results: https://git.linaro.org/toolchain/ci/base-artifacts.git/log/?h=linaro-local/… Artifacts: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Build log: https://ci.linaro.org/job/tcwg_bmk_ci_gnu-bisect-tcwg_bmk_tx1-gnu-master-aa… Full commit (up to 1000 lines): <cut> commit de56f95afaaa22c67cbeec780921d63e8b34514e Author: Xionghu Luo <luoxhu(a)linux.ibm.com> Date: Tue May 18 21:34:18 2021 -0500 Run pass_sink_code once more before store_merging Gimple sink code pass runs quite early, there may be some new oppertunities exposed by later gimple optmization passes, this patch runs the sink code pass once more before store_merging. For detailed discussion, please refer to: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562352.html Tested the SPEC2017 performance on P8LE, 544.nab_r is improved by 2.43%, but no big changes to other cases, GEOMEAN is improved quite small with 0.25%. gcc/ChangeLog: 2021-05-18 Xionghu Luo <luoxhu(a)linux.ibm.com> * passes.def: Add sink_code pass before store_merging. * tree-ssa-sink.c (pass_sink_code:clone): New. gcc/testsuite/ChangeLog: 2021-05-18 Xionghu Luo <luoxhu(a)linux.ibm.com> * gcc.dg/tree-ssa/ssa-sink-1.c: Adjust. * gcc.dg/tree-ssa/ssa-sink-2.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-3.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-4.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-5.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-6.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-7.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-8.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-9.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-10.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-13.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-14.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-16.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-17.c: Ditto. * gcc.dg/tree-ssa/ssa-sink-18.c: New. --- gcc/passes.def | 1 + gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-1.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c | 4 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c | 4 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-16.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-17.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-18.c | 212 ++++++++++++++++++++++++++++ gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-2.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-3.c | 15 -- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-4.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-5.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-6.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-7.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-8.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-9.c | 2 +- gcc/tree-ssa-sink.c | 1 + 17 files changed, 229 insertions(+), 30 deletions(-) diff --git a/gcc/passes.def b/gcc/passes.def index de39fa48b3d..945d2bc797c 100644 --- a/gcc/passes.def +++ b/gcc/passes.def @@ -348,6 +348,7 @@ along with GCC; see the file COPYING3. If not see NEXT_PASS (pass_phiopt, false /* early_p */); NEXT_PASS (pass_fold_builtins); NEXT_PASS (pass_optimize_widening_mul); + NEXT_PASS (pass_sink_code); NEXT_PASS (pass_store_merging); NEXT_PASS (pass_tail_calls); /* If DCE is not run before checking for uninitialized uses, diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-1.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-1.c index 411585a6dc4..57b501681f3 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-1.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-1.c @@ -7,4 +7,4 @@ foo (int a, int b, int c) return c ? x : a; } /* We should sink the x = a * b calculation into the branch that returns x. */ -/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c index 37e4d2fe687..535cb3208f5 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c @@ -16,4 +16,4 @@ void foo (void) } } -/* { dg-final { scan-tree-dump-times "Sinking # VUSE" 4 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sinking # VUSE" 4 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c index a65ba35d4ba..584fd91f43a 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-13.c @@ -21,5 +21,5 @@ void test () /* We should sink/merge all stores and end up with a single BB. */ -/* { dg-final { scan-tree-dump-times "MEM\[^\n\r\]* = 0;" 3 "sink" } } */ -/* { dg-final { scan-tree-dump-times "<bb " 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "MEM\[^\n\r\]* = 0;" 3 "sink1" } } */ +/* { dg-final { scan-tree-dump-times "<bb " 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c index 771cd4420c4..f5418b06deb 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-14.c @@ -13,5 +13,5 @@ void foo (int b) /* We should have sunk the store and inserted a PHI to merge the stored values. */ -/* { dg-final { scan-tree-dump-times " = PHI" 1 "sink" } } */ -/* { dg-final { scan-tree-dump-times "x = " 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times " = PHI" 1 "sink1" } } */ +/* { dg-final { scan-tree-dump-times "x = " 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-16.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-16.c index 610c8d60ebe..012b165fbab 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-16.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-16.c @@ -10,5 +10,5 @@ int f(int n) return j; } -/* { dg-final { scan-tree-dump "Sinking j_. = __builtin_ffs" "sink" } } */ +/* { dg-final { scan-tree-dump "Sinking j_. = __builtin_ffs" "sink1" } } */ /* { dg-final { scan-tree-dump "return 2;" "optimized" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-17.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-17.c index cf2e2a0f766..d0aeeb312cc 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-17.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-17.c @@ -12,4 +12,4 @@ int my_f(int a, int b) } /* We should sink the call to pure_f to the if block. */ -/* { dg-final { scan-tree-dump "Sinking # VUSE" "sink" } } */ +/* { dg-final { scan-tree-dump "Sinking # VUSE" "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-18.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-18.c new file mode 100644 index 00000000000..421c78eba50 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-18.c @@ -0,0 +1,212 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-sink-stats" } */ + +#include <stdint.h> + +#define HLOG 16 +#define MAX_LIT (1 << 5) +typedef const uint8_t *LZF_HSLOT; +typedef LZF_HSLOT LZF_STATE[1 << (HLOG)]; + +int +compute_on_bytes (uint8_t *in_data, int in_len, uint8_t *out_data, int out_len) +{ + LZF_STATE htab; + + uint8_t *ip = in_data; + uint8_t *op = out_data; + uint8_t *in_end = ip + in_len; + uint8_t *out_end = op + out_len; + uint8_t *ref; + + unsigned long off; + unsigned int hval; + int lit; + + if (!in_len || !out_len) + return 0; + + lit = 0; + op++; + hval = (((ip[0]) << 8) | ip[1]); + + while (ip < in_end - 2) + { + uint8_t *hslot; + + hval = (((hval) << 8) | ip[2]); + hslot = (uint8_t*)(htab + (((hval >> (3 * 8 - 16)) - hval * 5) & ((1 << (16)) - 1))); + + ref = *hslot + in_data; + *hslot = ip - in_data; + + if (1 && (off = ip - ref - 1) < (1 << 13) && ref > in_data + && ref[2] == ip[2] + && ((ref[1] << 8) | ref[0]) == ((ip[1] << 8) | ip[0])) + { + unsigned int len = 2; + unsigned int maxlen = in_end - ip - len; + maxlen + = maxlen > ((1 << 8) + (1 << 3)) ? ((1 << 8) + (1 << 3)) : maxlen; + + if ((op + 3 + 1 >= out_end) != 0) + if (op - !lit + 3 + 1 >= out_end) + return 0; + + op[-lit - 1] = lit - 1; + op -= !lit; + + for (;;) + { + if (maxlen > 16) + { + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + len++; + if (ref[len] != ip[len]) + break; + } + + do + { + len++; + } + while (len < maxlen && ip[len] == ref[len]); + + break; + } + + len -= 2; + ip++; + + if (len < 7) + { + *op++ = (off >> 8) + (len << 5); + } + else + { + *op++ = (off >> 8) + (7 << 5); + *op++ = len - 7; + } + *op++ = off; + lit = 0; + op++; + ip += len + 1; + + if (ip >= in_end - 2) + break; + + --ip; + --ip; + + hval = (((ip[0]) << 8) | ip[1]); + hval = (((hval) << 8) | ip[2]); + htab[(((hval >> (3 * 8 - 16)) - hval * 5) & ((1 << (16)) - 1))] + = (LZF_HSLOT)(ip - in_data); + ip++; + + hval = (((hval) << 8) | ip[2]); + htab[(((hval >> (3 * 8 - 16)) - hval * 5) & ((1 << (16)) - 1))] + = (LZF_HSLOT)(ip - in_data); + ip++; + } + else + { + if (op >= out_end) + return 0; + + lit++; + *op++ = *ip++; + + if (lit == (1 << 5)) + { + op[-lit - 1] = lit - 1; + lit = 0; + op++; + } + } + } + if (op + 3 > out_end) /* at most 3 bytes can be missing here */ + return 0; + + while (ip < in_end) + { + lit++; + *op++ = *ip++; + if (lit == MAX_LIT) + { + op[-lit - 1] = lit - 1; /* stop run */ + lit = 0; + op++; /* start run */ + } + } + + op[-lit - 1] = lit - 1; /* end run */ + op -= !lit; /* undo run if length is zero */ + + return op - out_data; + } + + /* For this case, pass sink2 sinks statements from hot loop header to loop + exits after gimple loop optimizations, which generates instructions executed + each iteration in loop, but the results are used outside of loop: + With -m64, + "Sinking _367 = (uint8_t *) _320; + from bb 31 to bb 90 + Sinking _320 = _321 + ivtmp.25_326; + from bb 31 to bb 90 + Sinking _321 = (unsigned long) ip_229; + from bb 31 to bb 90 + Sinking len_158 = _322 + 4294967295; + from bb 31 to bb 33" + When -m32, Power and X86 will sink 3 instructions, but arm ilp32 couldn't + sink due to ivopts chooses two IV candidates instead of one, which is + expected, so this case is restricted to lp64 only so far. */ + + /* { dg-final { scan-tree-dump-times "Sunk statements: 4" 1 "sink2" { target lp64 } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-2.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-2.c index 6aa5a182a3a..a0b4734b1e0 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-2.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-2.c @@ -9,4 +9,4 @@ bar (int a, int b, int c) return y; } /* We should sink the x = a * b calculation into the else branch */ -/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-3.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-3.c index 599997e0e6b..e69de29bb2d 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-3.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-3.c @@ -1,15 +0,0 @@ -/* { dg-do compile } */ -/* { dg-options "-O2 -fdump-tree-sink-stats" } */ -extern void foo(int a); -int -main (int argc) -{ - int a; - a = argc + 1; - if (argc + 3) - { - foo (a); - } -} -/* We should sink the a = argc + 1 calculation into the if branch */ -/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-4.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-4.c index 784edd2fc87..1e3cfa93fa8 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-4.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-4.c @@ -17,4 +17,4 @@ main (int argc) foo2 (a); } /* We should sink the first a = b + c calculation into the else branch */ -/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sunk statements: 1" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-5.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-5.c index dbdde39add6..f04da5da9b0 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-5.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-5.c @@ -44,4 +44,4 @@ void foo(int16_t runs[], uint8_t alpha[], int x, int count) } /* We should not sink the next_runs = runs + x calculation after the loop. */ -/* { dg-final { scan-tree-dump-times "Sunk statements:" 0 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sunk statements:" 0 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-6.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-6.c index 1abae9f7943..31f5af330f9 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-6.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-6.c @@ -14,4 +14,4 @@ int foo(int *a, int r) /* *a = 1 should be sunk to the else block. */ -/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-7.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-7.c index ec3288f4e69..bd748442edc 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-7.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-7.c @@ -15,4 +15,4 @@ int foo(int *a, int r, short *b) /* *a = 1 should be sunk to the else block. */ -/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-8.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-8.c index 48af4218fc0..4b23b567fd0 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-8.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-8.c @@ -24,4 +24,4 @@ int foo(int *a, int r, short *b) /* *a = 1 should be sunk into the default case. */ -/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink1" } } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-9.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-9.c index 509a76330a4..32bfc81741a 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-9.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-9.c @@ -15,4 +15,4 @@ int foo(int *a, int r, int *b) /* *a = 1 should be sunk to the else block. */ -/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink" } } */ +/* { dg-final { scan-tree-dump-times "Sinking" 1 "sink1" } } */ diff --git a/gcc/tree-ssa-sink.c b/gcc/tree-ssa-sink.c index d33e56ef915..d252cbb5c51 100644 --- a/gcc/tree-ssa-sink.c +++ b/gcc/tree-ssa-sink.c @@ -819,6 +819,7 @@ public: /* opt_pass methods: */ virtual bool gate (function *) { return flag_tree_sink != 0; } virtual unsigned int execute (function *); + opt_pass *clone (void) { return new pass_sink_code (m_ctxt); } }; // class pass_sink_code </cut>

4 years

1
0
0 0

Flang buildbot workers

by Andrzej Warzynski

Hi, I've just noticed that all of Flang's buildbot workers managed by Linaro are offline: https://lab.llvm.org/buildbot/#/builders (type "flang" in the search box). As 8 out of 10 Flang's workers are managed by Linaro, in practice this means that we have almost no testing :( Please, could you look into this or let me know who to get in touch with? Thank you, -Andrzej IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

4 years

3
8
0 0

[ACTIVITY] week ending 20 Jun 2021

by Richard Henderson

[UM-2] * Version 2 of signal trampolines, * Version 1 of vdso, * RFC patch set for #360 (unaligned mmio), * Beginning on #404 (breakpoint slowdown), - convert cris, nios2, avr to translator loop. - translator_use_goto_tb Both of these, working toward improving the recognition of pc's with bp's, and avoiding the need for any tb flushing at all. r~

4 years

1
0
0 0

[ACTIVITY] 14-18 June 2021

by Christophe Lyon

== Progress == * GCC - MVE/vectorization: committed patches for vec_pack / vec_unpack - handling feedback on patch for PR 100757 * GCC upstream validation: - reported a couple of regressions == Next == Now leaving Linaro, hopefully I can continue to work on: * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M Thanks for the great time at Linaro!

4 years

1
0
0 0

[ACTIVITY] report week ending 18 Jun

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Usual code review and pull request wrangling (nothing major this week) + Added information to our documentation about what Arm architecture features our emulation supports (we get asked this from time to time, and users shouldn't have to dig through back issues of the Changelogs or decipher the ID register updates in the source code...) + Investigated some bugs in v8.1M VLDR/VSTR sysreg detected by trying to run some gcc test cases under QEMU: sent patches + KVM Forum programme committee meeting & voting on talk abstracts * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Fixed various issues in the first-part-of-MVE patchset; it's now through code review and ready to go in + Started looking at the logical-immediate insns + Progress meter: 74/210 (35%) (still) -- PMM

4 years

1
0
0 0

[ACTIVITY] week ending 13 Jun 2021

by Richard Henderson

[UM-2] Upstream bugs: #390, fix posted #403, fix posted #360, lots of investigation, and work on updating a patch from 2017. I have a workable change, which ought to be improved. Reorg for tcg bswap opcode. r~

4 years

1
0
0 0

[ACTIVITY] 7-11 June 2021

by Christophe Lyon

== Progress == * GCC - MVE/vectorization: committed patches for vhadd/vrhadd and vclz - handling feedback on patch for vec_pack / vec_unpack - PR 100757 * GCC upstream validation: - reported a couple of regressions == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M

4 years

1
0
0 0

[ACTIVITY] report week ending 10 June

by Peter Maydell

Progress (short week, 3 days): * UM-2 [QEMU upstream maintainership] + Code review: + v4 of Shashi's ITS series. I think this is getting pretty close to good to go in now. * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Completed implementation of PSR.ECI handling + Implemented VADDV + Sent out an interim patchset for early code review (55 patches, ~3400 lines, covers about 35% of the ISA) + Started working through the code review comments from rth + Progress meter: 74/210 (35%) -- PMM

4 years

1
0
0 0

[ACTIVITY] week ending 6 June 2021

by Richard Henderson

[UM-2] * Refresh tci patch set. * Review: - target/s390 vector enhancements - arm refactor * Knocked up a tcg patch for Peter's MVE work. r~

4 years

1
0
0 0

[ACTIVITY] 31 May - 4 June 2021

by Prathamesh Kulkarni

== This Week == * GCC (1) PR66791 (replace builtins with gcc vector extensions): - Waiting for feedback on vmul_n patch - Created patch for vector comparison ops. (2) PR97906 (missed lowering to vacge) - Submitted patch upstream. (3) PR98435 (missed optimization in expanding vec constructor) - Submitted patch upstream. * Sick leave - Off on thursday. == Next Week == - Continue with PR66791 - Address comments for PR97906 and PR98435

4 years

1
0
0 0

[ACTIVITY] week ending Jun. 6 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - posted [RFC PATCH] configure: allow the overriding of default-config in the build Message-Id: <20210528163116.31902-1-alex.bennee(a)linaro.org> - posted [PATCH v16 00/99] arm tcg/kvm refactor and split with kvm only support Message-Id: <20210604155312.15902-1-alex.bennee(a)linaro.org> [STR-9] <https://projects.linaro.org/browse/STR-9> QEMU Device and Machine Models ([QEMU-418]) =========================================== - started prepping v3 of the kvm-unit-tests [QEMU-418] <https://projects.linaro.org/browse/QEMU-418> QEMU Upstream Work ([UM-2]) =========================== - posted [RFC PATCH] semihosting/arm-compat: remove heuristic softmmu SYS_HEAPINFO Message-Id: <20210601090715.22330-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> Completed Reviews [5/5] ======================= [RFC PATCH 0/3] Cache modelling TCG plugin Message-Id: <20210529152203.40358-1-ma.mandourr(a)gmail.com> [PATCH v2 00/28] Convert floatx80 and float128 to FloatParts Message-Id: <20210525150706.294968-1-richard.henderson(a)linaro.org> [PATCH v7 00/27] TCI fixes and cleanups Message-Id: <20210601150106.12761-1-richard.henderson(a)linaro.org> [PATCH v8 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210526170432.343588-1-philmd(a)redhat.com> [PATCH v2 00/12] hw: Various Kconfig fixes Message-Id: <20210515173716.358295-1-philmd(a)redhat.com> Absences ======== Current Review Queue ==================== TODO [PATCH 0/5] virtio: Add vhost-user based RNG service Message-Id: <20210601200305.1772391-1-mathieu.poirier(a)linaro.org> ========================================================================================================================== TODO [PATCH v2 00/11] linux-user changes to run docker Message-Id: <20210531055019.10149-1-yamamoto(a)midokura.com> ================================================================================================================ TODO [PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm") Message-Id: <1621603005-5799-1-git-send-email-olekstysh(a)gmail.com> ====================================================================================================================================================================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== -- Alex Bennée

4 years

1
0
0 0

[ACTIVITY] report week ending 4 Jun

by Peter Maydell

Progress (short week, 3 days): * UM-2 [QEMU upstream maintainership] + Code review: - reviewed the easy half of the "aarch64 support for osx hvf accelerator" patchseries - RTH's bfloat16 support series + Misc bugs: - Sent a patchset fixing a compile failure reported by MS when the 'virt' board is not enabled (requires a custom local config) * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Working through the details of how PSR.ECI works for resuming half-executed insns (annoyingly awkward to implement for a subfeature that will almost never get used...). I have most of an implementation now but it needs a bit of new functionality in TCG ("throw away any TCG ops we just generated and rewind to point X") which RTH hasn't written yet :-) + None of that work corresponds to adding more insn patterns, so no change on the Progress meter: 73/210 (34%) -- PMM

4 years

1
0
0 0

[ACTIVITY] 31 May - 4 June 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - reported a couple of regressions * GCC - MVE/vectorization: committed patches for vans - submitted patch for vhadd/vrhadd - WIP on vclz / vec_pack / vec_unpack - PR 100757 == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M

4 years

1
0
0 0

[ACTIVITY] 24-28 May 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - reported a couple of regressions * GCC - MVE/vectorization: committed patches for vld2/vst2, vld4/st4, vaddv - WIP on vhadd/vrhadd == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending May. 30 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - more work on getting [arm refactor] ready for posting - posted [RFC PATCH] configure: allow the overriding of default-config in the build Message-Id: <20210528163116.31902-1-alex.bennee(a)linaro.org> [arm refactor] <https://github.com/stsquad/qemu/tree/arm/refactor-tcg-accel-split-v16> QEMU Device and Machine Models ([QEMU-418]) =========================================== - posted [kvm-unit-tests PATCH v2 0/4] enable LPI and ITS for TCG Message-Id: <20210525172628.2088-4-alex.bennee(a)linaro.org> [QEMU-418] <https://projects.linaro.org/browse/QEMU-418> QEMU Upstream Work ([UM-2]) =========================== - posted [PULL 1/7] gitlab: explicitly reference the upstream registry Message-Id: <20210525112431.22005-1-alex.bennee(a)linaro.org> [testing/next branch] <https://github.com/stsquad/qemu/tree/testing/next> Completed Reviews [5/5] ======================= [PATCH 0/5] linux-user changes to run docker Message-Id: <20210524045412.15152-1-yamamoto(a)midokura.com> [PATCH 0/4] gitlab-ci: Allow using FreeBSD runners Message-Id: <20210510152254.2543047-1-f4bug(a)amsat.org> [RFC PATCH 0/5] Use ccache in the gitlab-CI Message-Id: <20210414081907.871437-1-thuth(a)redhat.com> [PATCH 0/9] gitlab-ci: Make mainstream CI green again Message-Id: <20210525082556.4011380-1-f4bug(a)amsat.org> [PATCH] HMP: added cpustats to removed_features.rst Message-Id: <20210527191028.24febe7e(a)bahia.lan> Absences ======== Current Review Queue ==================== TODO [PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm") Message-Id: <1621603005-5799-1-git-send-email-olekstysh(a)gmail.com> ====================================================================================================================================================================== TODO [PATCH v2 00/12] hw: Various Kconfig fixes Message-Id: <20210515173716.358295-1-philmd(a)redhat.com> ====================================================================================================== TODO [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> =================================================================================================================================================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== -- Alex Bennée

4 years, 1 month

1
0
0 0

[ACTIVITY] report week ending 27 May

by Peter Maydell

Progress (short week, 3 days): * UM-2 [QEMU upstream maintainership] + Code review: - SVE2 series v7 (now finally done) - RTH's tlb_flush range refactoring - A few other minor patchsets + Arm pullrequest: SVE2 emulation support is now upstream + Misc bugs: - sent some patches fixing a few coverity nits in our test suite code * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Implemented: - VQDMULL, VRHADD, VADC, VSBC, VCADD, VHCADD - LCTP, LETP, WLSTP, DLSTP (the tail-predicating loop insns) - Progress meter: 73/210 (34%) -- PMM

4 years, 1 month

1
0
0 0

[ACTIVITY] 17 - 21 May 2021

by Prathamesh Kulkarni

== This Week == * PR66791 (Replace builtins with C operations in intrinsics) - vtst: Committed patch to trunk. - vshl_n: Patch results in worse code-gen, abandoned. - vmul_n: Created patch, looking into testsuite fallout * PR97906 (Missed lowering abs(x) >= abs(y) to vcage x, y) - Investigated PR and have a WIP fix. == Next Week == - Continue with PR66791, PR97906

4 years, 1 month

1
0
0 0

[ACTIVITY] report week ending 21 May

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Code review: - bfloat16 support patchset - v3 of ITS emulation patchset + Misc bugs: - sent a patch fixing a bug where we sometimes selected the wrong stack pointer when doing a v8M exception return in a case involving tail-chaining (needed by an upcoming Arm TF-M change) * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Sent a small patchset which implements a few preliminary MVE things (VPR register, FPSCR.QC bit, fixing checks for existing insns which now need to be "FP or MVE" rather than just "FP") + Implemented: - VADD VSUB VMULL VHADD VHSUB VQADD VQSUB VQDMULH VQRDMULH scalar - VBRSR, VPST, VQDMULH, VQRDMULH, VQADD, VQSUB - VQSHL VQRSHL VSHL VRSHL vector forms - VQDMLADH, VQRDMLADH, VQDMLSDH, VQRDMLSDH Progress meter: 63/210 (30%) -- PMM

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending May. 23 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - worked with Viresh on getting more reliable Xen up and running - formally took over Caludio's arm branch as I need it for mine - preparing [my version] for posting [my version] <https://github.com/stsquad/qemu/tree/arm/refactor-tcg-accel-split-v16> QEMU Upstream Work ([UM-2]) =========================== - finally got [PULL v2 00/29] testing and plugin updates Message-Id: <20210518090720.21915-1-alex.bennee(a)linaro.org> merged - posted [PATCH v1 0/8] various misc fixes (gitlab, gdbstub, plugins) Message-Id: <20210520174303.12310-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> [testing/next branch] <https://github.com/stsquad/qemu/tree/testing/next> Other ===== - [Blog post on QEMU went live] [Blog post on QEMU went live] <https://www.linaro.org/blog/many-uses-of-qemu/> Current Review Queue ==================== TODO [PATCH v2 00/12] hw: Various Kconfig fixes Message-Id: <20210515173716.358295-1-philmd(a)redhat.com> ====================================================================================================== TODO [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> =================================================================================================================================================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== TODO [PATCH v2 00/12] virtio-gpu: Add support for Blob resources feature Message-Id: <20210420065347.2685768-1-vivek.kasireddy(a)intel.com> ======================================================================================================================================== -- Alex Bennée

4 years, 1 month

1
0
0 0

[ACTIVITY] 17-21 May 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - reported a couple of regressions * GCC - MVE/vectorization: committed patches for vcmp, waiting for feedback on the remaining patches for vld2/vst2, vld4/st4 - started work on vaddv support - committed a few testsuite improvement patches - committed patch for PR 42579 * Misc - looking at gdb issue with register names in target description == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending 16 May 2021

by Richard Henderson

3 day week. [UM-2 # QEMU Upstream] * Refresh target/i386 translate user/sysemu cleanup. * Pull request for half of my softfloat reorg. * Tiny pull request for collected tcg patches. [QEMU-349 # SVE2] * Processing Peter's review comments. Another 3 day week this week. r~

4 years, 1 month

1
0
0 0

[ACTIVITY] 10-14 May 2021

by Christophe Lyon

Short week (2.5 days off) == Progress == * GCC upstream validation: - discussing update of the list of configs * GCC - MVE/vectorization: committing cleanup patches for vcmp, waiting for feedback on the remaining patches for vcmp, vld2/vst2, vld4/st4 * Misc - scripts patch reviews - looking at gdb issue with register names in target description == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * GDB/cortex-M

4 years, 1 month

1
0
0 0

[ACTIVITY] report week ending 14 May

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] + Code review: - Managed to review all of RTH's 82-patch SVE2 patchset... + Misc bugs: - fixed some errors in modelling of SRAM in AN547 board - fixed a bug in GICv3 EOI (EL3 should be able to handle Group 1 NS IRQs) * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] + Implemented multiply-add-long-dual-accumulate insns (VMLALDAV, VMLSLDAV, VRMLALDAVH, VRMLSLDAVH) Progress meter: 40/210 (19%) -- PMM

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending May. 16 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - did some investigation on getting [Gunyah hypervisor] up and running - debugging xl domU launch under QEMU - got reverse debugging working on virtio ;-) [STR-9] <https://projects.linaro.org/browse/STR-9> [Gunyah hypervisor] <https://github.com/quic/gunyah-hypervisor> QEMU Upstream Work ([UM-2]) =========================== - reviewed a large chunk of rth's FloatParts opus Message-Id: <20210508014802.892561-1-richard.henderson(a)linaro.org> - posted [PATCH v3 00/31] testing/next pre-PR (hexagon, tricore, misc) Message-Id: <20210512102051.12134-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> [testing/next branch] <https://github.com/stsquad/qemu/tree/testing/next> Other ===== [Linaro JIRA Issues] Updates for LBO-99: QEMU's usage in Linaro Message-Id: <01000178a38e5f60-4b7149b0-b71b-4952-869f-cabdfb9078a6-000000(a)email.amazonses.com> Completed Reviews [1/1] ======================= [PATCH 00/72] Convert floatx80 and float128 to FloatParts Message-Id: <20210508014802.892561-1-richard.henderson(a)linaro.org> Absences ======== - Bank Holiday on Monday Current Review Queue ==================== TODO [PATCH v3 0/8] GICv3 LPI and ITS feature implementation Message-Id: <20210429234201.125565-1-shashi.mallela(a)linaro.org> =========================================================================================================================== TODO [PATCH v8 0/4] aarch64: add support for FEAT_TLBIRANGE and FEAT_TLBIOS Message-Id: <20210505030443.25310-1-rebecca(a)nuviainc.com> ==================================================================================================================================== TODO [PATCH v6 00/82] target/arm: Implement SVE2 Message-Id: <20210430202610.1136687-1-richard.henderson(a)linaro.org> =================================================================================================================== TODO [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> =================================================================================================================================================== -- Alex Bennée

4 years, 1 month

1
0
0 0

Bootstrap-O3 broken on 32-bit ARM

by Maxim Kuvyrkov

Hi Richard, Your patch a076632e274abe344ca7648b7c7f299273d4cbe0 appears to have broken bootstrap-O3 for 32-bit armhf. Do you have an AArch32-capable machine to reproduce/investigate this on? Let me know if not, and I'll make a proper bug report with a testcase. ICE: 00:33:32 In function ‘syscall.forkExec’: 00:33:32 go1: error: address taken, but ADDRESSABLE bit not set 00:33:32 PHI argument 00:33:32 &go..C479; 00:33:32 for PHI node 00:33:32 err$__object_78 = PHI <err$__object_76(58), &go..C479(59)> 00:33:32 during GIMPLE pass: fre 00:33:32 go1: internal compiler error: verify_ssa failed 00:33:32 0x9c18d7 verify_ssa(bool, bool) 00:33:32 /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/tree-ssa.c:1214 00:33:32 0x6f8d5b execute_function_todo 00:33:32 /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/passes.c:2049 00:33:32 0x6f9abf do_per_function 00:33:32 /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/passes.c:1687 00:33:32 0x6f9abf execute_todo 00:33:32 /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/passes.c:2096 00:33:32 Please submit a full bug report, 00:33:32 with preprocessed source if appropriate. 00:33:32 Please include the complete backtrace with any bug report. 00:33:32 See <https://gcc.gnu.org/bugs/> for instructions. 00:33:32 Makefile:3001: recipe for target 'syscall.lo' failed Full build log: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-bootstrap_O3/16/ar… Regards, -- Maxim Kuvyrkov https://www.linaro.org > On May 11, 2021, at 8:15 AM, tcwg-jira (Jira) <projects(a)linaro.org> wrote: > > There is 1 comment. > > > GNU Toolchain / <Mail Attachment.png> GNU-692 IN PROGRESS > Regressions from tcwg_binutils/tcwg_cross/tcwg_gnu CI > > View issue · Add comment > > 1 comment > > tcwg-jira on 11/May/21 5:04 AM > > Successfully identified regression in gcc in CI configuration tcwg_gnu/gnu-master-arm-bootstrap_O3. So far, this commit has regressed CI configurations: > • tcwg_gnu/gnu-master-arm-bootstrap_O3 > Culprit: > <cut> > commit a076632e274abe344ca7648b7c7f299273d4cbe0 > Author: Richard Biener <rguenther(a)suse.de> > Date: Fri May 7 09:51:18 2021 +0200 > middle-end/100464 - avoid spurious TREE_ADDRESSABLE in folding debug stmts > canonicalize_constructor_val was setting TREE_ADDRESSABLE on bases > of ADDR_EXPRs but that's futile when we're dealing with CTOR values > in debug stmts. This rips out the code which was added for Java > and should have been an assertion when we didn't have debug stmts. > To not regress g++.dg/tree-ssa/array-temp1.C we have to adjust the > testcase to not look for a no longer applied invalid optimization. > 2021-05-10 Richard Biener <rguenther(a)suse.de> > PR middle-end/100464 > PR c++/100468 > gcc/ > • gimple-fold.c (canonicalize_constructor_val): Do not set > TREE_ADDRESSABLE. > gcc/cp/ > • call.c (set_up_extended_ref_temp): Mark the temporary > addressable if the TARGET_EXPR was. > gcc/testsuite/ > • gcc.dg/pr100464.c: New testcase. > • g++.dg/tree-ssa/array-temp1.C: Adjust. > </cut> > Details: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-bootstrap_O3/16/ar… > Even more details: https://ci.linaro.org/job/tcwg_gcc-bisect-gnu-master-arm-bootstrap_O3/16/ar… > > > This message was sent by Atlassian Jira (v8.11.1#811002-sha1:94cd716) > Jira is improving email notifications, share your feedback! > Get Jira notifications on your phone! Download the Jira Server app for Android or iOS.

4 years, 1 month

2
1
0 0

[ACTIVITY] 3 - 7 May 2021

by Prathamesh Kulkarni

== This Week == * GCC - PR97903 (missed lowering to vtst): Committed fix to trunk, - PR66791: Submitted patch to replace vtst* (a, b) by (a & b) != 0 in arm_neon.h. - Committed fix for build failure in trunk. * Validation - vect metric: Pushed all pending patches. == Next Week == - PR66791: Continue working on more intrinsics - Validation: Monitor vect metric

4 years, 1 month

1
0
0 0

[ACTIVITY] 3-7 May 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Reported a few regressions - discussing update of the list of configs - tried qemu-6.0, issue with hwasan testing on aarch64 * GCC - MVE/vectorization: waiting for feedback on patches for vcmp, vld2/vst2, vld4/st4 * Misc - scripts patch reviews - looking at gdb issue with register names in target description == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending May. 9 2021

by Alex Bennée

QEMU Upstream Work ([UM-2]) =========================== - posted [PATCH v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirrus) Message-Id: <20210504100223.25427-1-alex.bennee(a)linaro.org> - posted [PATCH v1 0/7] plugins/next (windows, leaks, tcg tracing) Message-Id: <20210505092259.8202-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> [testing/next branch] <https://github.com/stsquad/qemu/tree/testing/next> [Linaro JIRA Issues] Updates for LBO-99: QEMU's usage in Linaro Message-Id: <01000178a38e5f60-4b7149b0-b71b-4952-869f-cabdfb9078a6-000000(a)email.amazonses.com> ============================================================================================================================================================= Completed Reviews [3/3] ======================= [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> [PATCH 0/5] misc: Replace alloca() by g_malloc() Message-Id: <20210505170055.1415360-6-philmd(a)redhat.com> [PATCH v2 0/9] misc: Replace alloca() by g_malloc() Message-Id: <CANCZdfqiHxQoG+g3bq_KL01yWCHUbF5qxJWN=sD37h7UJFMZ7g(a)mail.gmail.com> Absences ======== - Bank Holiday on Monday Current Review Queue ==================== TODO [PATCH v6 00/82] target/arm: Implement SVE2 Message-Id: <20210430202610.1136687-1-richard.henderson(a)linaro.org> =================================================================================================================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== TODO [PATCH v2 00/12] virtio-gpu: Add support for Blob resources feature Message-Id: <20210420065347.2685768-1-vivek.kasireddy(a)intel.com> ======================================================================================================================================== -- Alex Bennée

4 years, 1 month

1
0
0 0

[ACTIVITY] report week ending 6 May

by Peter Maydell

Progress (short week, 2 days): * UM-2 [QEMU upstream maintainership] - sent some small patches: fixing Coverity issues; converting a few users of a legacy API to the new function * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] - Implemented more insns: VMUL, VSTRB/H/W, VMAX, VMIN, VABD, VHADD, VHSUB, VMULL, VRMULH. Progress meter: 36/210 (17%) -- PMM

4 years, 1 month

1
0
0 0

Flakey LLVM buildbot builds on clang-cmake-armv7-quick

by Christian Kühnel

Hi folks, I just noticed that your builds on clang-cmake-armv7-quick seem to be flakey from time to time: https://lab.llvm.org/buildbot/#/builders/107/builds/7394 https://lab.llvm.org/buildbot/#/builders/107/builds/7390 https://lab.llvm.org/buildbot/#/builders/107/builds/7369 https://lab.llvm.org/buildbot/#/builders/107/builds/7359 I just got hit by one of the flakes with a documentation-only change. I looks like the build is timing out... Best, Christian

4 years, 1 month

1
1
0 0

[ACTIVITY] week ending 2 May 2021

by Richard Henderson

[um-2] Patch review: power10, arm. Fixes for Alex's new signals.c test: sparc, s390. [qemu-349] Refreshed sve2 patch set. r~

4 years, 1 month

1
0
0 0

[ACTIVITY] week ending May. 2 2021

by Alex Bennée

QEMU Device and Machine Models ([QEMU-418]) =========================================== - posted [kvm-unit-tests PATCH v1 0/4] enable LPI and ITS for TCG Message-Id: <20210428101844.22656-1-alex.bennee(a)linaro.org> [QEMU-418] <https://projects.linaro.org/browse/QEMU-418> QEMU Upstream Work ([UM-2]) =========================== - updated [testing/next branch] we some more fixes [UM-2] <https://projects.linaro.org/browse/UM-2> [testing/next branch] <https://github.com/stsquad/qemu/tree/testing/next> Other ===== - Spent more time on blog post for [LBO-99] [LBO-99] <https://projects.linaro.org/browse/LBO-99> Completed Reviews [3/3] ======================= [PATCH v3 0/2] tests/docker: tests/tcg/ppc64le: Newer toolchain to build tests for PowerISA v3.1 instructions Message-Id: <20210423205757.1752480-1-matheus.ferst(a)eldorado.org.br> [PATCH 0/2] plugins: Freeing allocated values in hash tables. Message-Id: <20210421140934.7561-1-ma.mandourr(a)gmail.com> [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> [PATCH v2 0/8] GICv3 LPI and ITS feature implementation Message-Id: <20210401024152.203896-1-shashi.mallela(a)linaro.org> Absences ======== - Bank Holiday on Monday Current Review Queue ==================== TODO [PATCH v4 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-Id: <20210415163304.4120052-1-philmd(a)redhat.com> =================================================================================================================================================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== TODO [PATCH v2 00/12] virtio-gpu: Add support for Blob resources feature Message-Id: <20210420065347.2685768-1-vivek.kasireddy(a)intel.com> ======================================================================================================================================== TODO [RFC v14 00/80] arm cleanup experiment for kvm-only build Message-Id: <20210416162824.25131-1-cfontana(a)suse.de> =================================================================================================================== -- Alex Bennée

4 years, 2 months

1
0
0 0

[ACTIVITY] report week ending 30 Apr

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] - release work: rc5 Monday, and then 6.0 final release on Thursday. - sent a pullreq with some accumulated arm patches now 6.1 is open - fixed a trivial bug where WFI in the usermode emulator crashed * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] - Implemented more instructions: logic ops, VCLS, VCLZ, VREV, VMVN, VABS, VNEG, VADD, VDUP, VSUB, VMULH, and widening VLDR. (These are all simple "always call an out-of-line helper" versions. We'll want an optimised "we know we have no predication" version for many of them, but I plan to do that afterwards.) - Worked through the v8M Arm ARM identifying which insns we must implement. There are 210 insn patterns in total, of which I have currently implemented 23, so we can produce a rough-and-ready progress meter: 23/210 (11%) (There is of course work to do beyond just the insns, but they form the bulk of it, so the meter has some utility.) -- PMM

4 years, 2 months

1
0
0 0

[ACTIVITY] 26-30 April 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Reported a few regressions * GCC - committed cleanup patches - sent a few testsuite improvement patches - MVE/vectorization: Send patches for vcmp, vld2/vst2, vld4/st4 * Misc - scripts patch reviews == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes

4 years, 2 months

1
0
0 0

[ACTIVITY] week ending Apr. 25 2021

by Alex Bennée

QEMU Support for Xen ([STR-20]) =============================== - continued reviewing [RFC v12 00/65] arm cleanup experiment for kvm-only build Message-Id: <20210326193701.5981-1-cfontana(a)suse.de> - this is looking pretty solid now - cut new version of [arm build clean-ups based on Claudio's series] - testing reveals some breakage to track down next week [STR-20] <https://projects.linaro.org/browse/STR-20> [arm build clean-ups based on Claudio's series] <https://github.com/stsquad/qemu/tree/xen/arm-build-cleanups-v3> QEMU Upstream Work ([UM-2]) =========================== - posted [PULL 00/11] rc2 fixes (check-tcg, gitlab, gdbstub) Message-Id: <20210406150041.28753-1-alex.bennee(a)linaro.org> - some time trying to debug last weeks PR, eventually merged - posted [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) Message-Id: <20210419145435.14083-1-alex.bennee(a)linaro.org> - posted [RFC PATCH] tests/tcg: add a multiarch signals test to stress test signal delivery Message-Id: <20210421132931.11127-1-alex.bennee(a)linaro.org> - hunting for RC failure in s390x - posted [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability Message-Id: <20210422154427.13038-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> GSoC/Intern Mentoring ===================== GSoC 2021 proposal initiation for AGL Message-Id: <CAC+yH-Z_KZKuQ0nmAgk-+B+HW88sNjztObtWwazof+cAGJGuuQ(a)mail.gmail.com> GSoC: cache modelling plugin inquiry Message-Id: <CAD-LL6hLk1XAB5VWwHgMOWQV=bT1+FCnf8f-q9MVw5e5A4RMqg(a)mail.gmail.com> GSoC - QEMU Ideas Message-Id: <CALpwMJz0kb2BDreTWBbt945FR+sLX=sKzHSv8pMb5LkLwXqEJA(a)mail.gmail.com> Synced up with potential AGL Jailhouse/VirtIO GSoC applicant Other ===== - bit more write-up of blog post for [LBO-99] [LBO-99] <https://projects.linaro.org/browse/LBO-99> Completed Reviews [8/8] ======================= [PATCH RESEND] docs: clarify absence of set_features in vhost-user Message-Id: <20210325144846.17520-1-hi(a)alyssa.is> [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document Message-Id: <72bc8020-2028-82db-219c-a6ae311e26df(a)redhat.com> [PATCH v4 00/12] target/arm mte fixes Message-Id: <20210406174031.64299-4-richard.henderson(a)linaro.org> [PATCH 0/4] Acceptance Tests: update assets location and cancel tests if missing Message-Id: <20200907042000.415931-1-crosa(a)redhat.com> Added: <2020-09-07 Mon> [RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests Message-Id: <20210415214138.563795-1-matheus.ferst(a)eldorado.org.br> [RFC PATCH 00/15] gitlab-ci: Allow forks to use different pipelines than mainstream Message-Id: <20210418233448.1267991-11-f4bug(a)amsat.org> [PATCH 0/2] gdbstub: implement support for blocking interrupts on single stepping Message-Id: <20210401144152.1031282-1-mlevitsk(a)redhat.com> [PATCH v2 0/7] linux-user: sigaction fixes/cleanups Message-Id: <20210422230227.314751-1-richard.henderson(a)linaro.org> testing/next - hexagon toolchain update Message-Id: <BN7PR02MB4194DF5752EF3BADE858018DB8799(a)BN7PR02MB4194.namprd02.prod.outlook.com> [PATCH] tests/tcg: Run tests on arch variants again Message-Id: <20210312152105.1836543-1-f4bug(a)amsat.org> [PATCH 0/1] libbpf dependecy for docker containers. Message-Id: <20210406082947.672708-1-andrew(a)daynix.com> [PATCH v3 00/15] tests/tcg: Add TriCore tests Message-Id: <20210305170045.869437-1-kbastian(a)mail.uni-paderborn.de> Absences ======== Current Review Queue ==================== TODO [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Message-Id: <20210413080745.33004-1-wangyanan55(a)huawei.com> ============================================================================================================================== TODO [PATCH v2 00/12] virtio-gpu: Add support for Blob resources feature Message-Id: <20210420065347.2685768-1-vivek.kasireddy(a)intel.com> ======================================================================================================================================== TODO [RFC v14 00/80] arm cleanup experiment for kvm-only build Message-Id: <20210416162824.25131-1-cfontana(a)suse.de> =================================================================================================================== TODO [PATCH v2 0/8] GICv3 LPI and ITS feature implementation Message-Id: <20210401024152.203896-1-shashi.mallela(a)linaro.org> =========================================================================================================================== -- Alex Bennée

4 years, 2 months

1
0
0 0

[ACTIVITY] report week ending 23 Apr

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] - code review: + Shashi's ITS emulation patchset + RTH's remaining fixes for MTE + RTH's patchset to implement alignment checking - release work: sadly we found a pretty nasty crasher bug at the last minute, so we'll release rc5 on Monday and final release Thursday (with luck) * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] - useful discussions with RTH about how to implement MVE and in particular how to handle its various flavours of insn predication - some progress in writing code to implement the first insn (VLDR) thanks -- PMM

4 years, 2 months

1
0
0 0

[ACTIVITY] 19-23 April 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Reported a few regressions * GCC - committed further fix for testcase for PR96770 - sent a few testsuite improvement patches - resumed work on MVE/auto-vectorization. Added support for vcmp.f16. Checking fp16 support in previous patches. * Misc - scripts patch reviews == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes

4 years, 2 months

1
0
0 0

[ACTIVITY] 12-16 April 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Reported a few regressions - Reduced build frequency on release branches, now same as trunk: daily bump and arm/aarch64 "interesting" commits * GCC - pinged further fix for testcase for PR96770 - preparing cortex-m55 validation setup - looking at cmse tests vs qemu - Linaro BZ 5755/upstream 100049 * GDB - uploaded cleaned up last known-to-work branch to sourceware so that maintainers can have a look at it - uploaded latest wip based on 8.2 branch too * Misc - scripts patch reviews == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes

4 years, 2 months

1
0
0 0

[ACTIVITY] report week ending Apr 16

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] - Finished and posted patches implementing remap support for AN524 - Release work for rc3 - Sent a set of refactoring patches that split out some files we were previously #including into translate.c so they are separate compilation units. - Thought a bit more about reset handling (in the course of writing the AN524 remap patches I again ran into some of the deficiencies of our current reset implementation; I really must take some time this release cycle to try to improve things here...) - Fixed bug where our AN547 board model accidentally disabled the FPU on the Cortex-M55... - ...and one where we were accidentally giving it an M33 rather than an M55 ! - Respun and extended some patches from Paolo which fix our use of QEMU and system headers in the 2 C++ files in the codebase (which were broken by a change in new versions of glib) - started looking at some of the for-6.1 patch review queue, which I had been postponing in favour of for-6.0 stuff * QEMU-406 [QEMU support for MVE (M-profile Vector Extension; Helium)] - re-read the MVE portions of the v8M Arm ARM, sketched out a plan of where to start with the QEMU implementation thanks -- PMM

4 years, 2 months

1
0
0 0

qemu bfloat16 branch

by Richard Henderson

https://gitlab.com/rth7680/qemu/-/commits/tgt-arm-bf16 It isn't a large extension, so all done. I added aarch64 simd, aarch32 neon, and sve support all at once. I've tested it via risu vs FVP. I've based this on my SVE2 branch, since there are some cleanups that made that easier. I'll post patches to qemu-devel next week. r~

4 years, 2 months

2
1
0 0

[ACTIVITY] 5-9 April 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - No regression to report this week. Issues on gcc-9 and gcc-10 release branches had already been reported by other people. * GCC - pinged further fix for testcase for PR96770 - Looking at failures for cortex-M, only found testisms so far * Misc - Fixed benchmarking jobs on stm32 == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * Resume GDB/FDPIC work

4 years, 2 months

1
0
0 0

[ACTIVITY] week ending 11 Apr 2021

by Richard Henderson

[UM-2] * Patch review. Lots. [QEMU-389 # Bfloat16 ] * Implemented. Will post patches next week. r~

4 years, 2 months

1
0
0 0

[ACTIVITY] week ending Apr. 11 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - had sync-up with Akashi-san/Vincent about approaches for the Zephyr demo - need to write-up on Monday [STR-9] <https://projects.linaro.org/browse/STR-9> QEMU Support for Xen ([STR-20]) =============================== - continued reviewing [RFC v12 00/65] arm cleanup experiment for kvm-only build Message-Id: <20210326193701.5981-1-cfontana(a)suse.de> - this is looking pretty solid now - cut new version of [arm build clean-ups based on Claudio's series] - testing reveals some breakage to track down next week [STR-20] <https://projects.linaro.org/browse/STR-20> [arm build clean-ups based on Claudio's series] <https://github.com/stsquad/qemu/tree/xen/arm-build-cleanups-v3> QEMU Upstream Work ([UM-2]) =========================== - posted [PULL 00/11] rc2 fixes (check-tcg, gitlab, gdbstub) Message-Id: <20210406150041.28753-1-alex.bennee(a)linaro.org> - some time trying to debug last weeks PR, eventually merged [UM-2] <https://projects.linaro.org/browse/UM-2> GSoC/Intern Mentoring ===================== GSoC 2021 proposal initiation for AGL Message-Id: <CAC+yH-Z_KZKuQ0nmAgk-+B+HW88sNjztObtWwazof+cAGJGuuQ(a)mail.gmail.com> GSoC: cache modelling plugin inquiry Message-Id: <CAD-LL6hLk1XAB5VWwHgMOWQV=bT1+FCnf8f-q9MVw5e5A4RMqg(a)mail.gmail.com> GSoC - QEMU Ideas Message-Id: <CALpwMJz0kb2BDreTWBbt945FR+sLX=sKzHSv8pMb5LkLwXqEJA(a)mail.gmail.com> Synced up with potential AGL Jailhouse/VirtIO GSoC applicant Completed Reviews [3/3] ======================= [PATCH RESEND] docs: clarify absence of set_features in vhost-user Message-Id: <20210325144846.17520-1-hi(a)alyssa.is> [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document Message-Id: <72bc8020-2028-82db-219c-a6ae311e26df(a)redhat.com> [PATCH v4 00/12] target/arm mte fixes Message-Id: <20210406174031.64299-4-richard.henderson(a)linaro.org> Absences ======== Current Review Queue ==================== TODO [RFC v12 00/65] arm cleanup experiment for kvm-only build Message-Id: <20210326193701.5981-1-cfontana(a)suse.de> ================================================================================================================== TODO [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci Message-Id: <20210325150735.1098387-1-groug(a)kaod.org> =================================================================================================================================== TODO [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Message-Id: <cover.1616570702.git.viresh.kumar(a)linaro.org> =========================================================================================================================== TODO [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug Message-Id: <20210314212724.1917075-1-richard.henderson(a)linaro.org> ================================================================================================================================ -- Alex Bennée

4 years, 2 months

1
0
0 0

[ACTIVITY] report week ending 9 Apr

by Peter Maydell

Progress (short week, 2 days): * UM-2 [QEMU upstream maintainership] - more release work, bug triage, etc - started implementing the memory-remapping feature of the AN524 FPGA image (which allows the BRAM and QSPI to be swapped either at startup or dynamically under guest control). Some guests (like ARM TF-M) assume the QSPI mapping. thanks -- PMM

4 years, 2 months

1
0
0 0

[ACTIVITY] 29 March-2 April 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Reported minor testsuite issues (eg failures with -mabi=ilp32 on aarch64) - re-started looking at validation for cortex-m55, realized that qemu does not support MVE yet * GCC - posted further fix for testcase for PR96770 - fixed PR 99786 - committed fix for PR 99773 * Misc == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * Resume GDB/FDPIC work

4 years, 2 months

1
0
0 0

[ACTIVITY] week ending Apr. 4 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - posted virtio-scmi backend on Zephyr as both Xen DomU and Jailhouse Partition demo suggestion Message-Id: <87ft0cyiqi.fsf(a)linaro.org> QEMU Upstream Work ([UM-2]) =========================== - posted [PATCH for 6.0-rc2? v1 0/6] check-tcg for non-x86 hosts Message-Id: <20210329110303.15235-1-alex.bennee(a)linaro.org> - posted [PATCH for 6.0-rc2 v2 00/11] various fixes, pre-PR (check-tcg, gdbstub, gitlab) Message-Id: <20210401102530.12030-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> Completed Reviews [7/7] ======================= [PATCH v1 0/8] GICv3 LPI and ITS feature implementation Message-Id: <20210323041238.133835-1-shashi.mallela(a)linaro.org> [PATCH RESEND] docs: clarify absence of set_features in vhost-user Message-Id: <20210325144846.17520-1-hi(a)alyssa.is> [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Message-Id: <cover.1616570702.git.viresh.kumar(a)linaro.org> [PATCH V2 0/6] virtio: Implement generic vhost-user-i2c backend Message-Id: <cover.1617278395.git.viresh.kumar(a)linaro.org> [0/0] tcg/mips: Fix SoftTLB comparison on mips backend Message-Id: <20210401100457.191458-1-kele.hwang(a)gmail.com> [PATCH RESEND] docs: clarify absence of set_features in vhost-user Message-Id: <20210325144846.17520-1-hi(a)alyssa.is> [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document Message-Id: <72bc8020-2028-82db-219c-a6ae311e26df(a)redhat.com> Current Review Queue ==================== TODO [RFC v12 00/65] arm cleanup experiment for kvm-only build Message-Id: <20210326193701.5981-1-cfontana(a)suse.de> ================================================================================================================== TODO [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci Message-Id: <20210325150735.1098387-1-groug(a)kaod.org> =================================================================================================================================== TODO [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Message-Id: <cover.1616570702.git.viresh.kumar(a)linaro.org> =========================================================================================================================== TODO [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug Message-Id: <20210314212724.1917075-1-richard.henderson(a)linaro.org> ================================================================================================================================ -- Alex Bennée

4 years, 3 months

1
0
0 0

[ACTIVITY] week ending 28 Mar 2021

by Richard Henderson

[UM-2] * Fix exec-vary.c vs gcc -flto. * Fix ppc tb->flags usage. * Patch review: - v11 of claudio's arm accel work - hexagon stuff - arm pcmr settings r~

4 years, 3 months

1
0
0 0

[ACTIVITY] week ending Mar. 28 2021

by Alex Bennée

VirtIO Initiative ([STR-9]) =========================== - attended the [Stratos sync-call] - more talk about rust-vmm for daemons QEMU Upstream Work ([UM-2]) =========================== - posted [PULL v2 00/15] misc fixes (strtoz, plugins, guest-loader) Message-Id: <20210317072216.16316-1-alex.bennee(a)linaro.org> - posted [RFC PATCH] gitlab: extend timeouts for CFI builds Message-Id: <20210322142110.4766-1-alex.bennee(a)linaro.org> - posted [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing) Message-Id: <20210323165308.15244-1-alex.bennee(a)linaro.org> - posted [PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing) Message-Id: <20210324143021.8560-1-alex.bennee(a)linaro.org> [UM-2] <https://projects.linaro.org/browse/UM-2> Other ===== - Provisioning new aarch64 CI machine for QEMU project Completed Reviews [7/7] ======================= [PATCH] FreeBSD: Upgrade to 12.2 release Message-Id: <20210319165138.117225-1-thuth(a)redhat.com> [PATCH] tests/meson: Only build softfloat objects if TCG is selected Message-Id: <20210322114739.4078408-1-f4bug(a)amsat.org> [PATCH v28 00/23] i386 cleanup PART 2 Message-Id: <20210322132800.7470-1-cfontana(a)suse.de> [RFC v10 00/49] arm cleanup experiment for kvm-only build Message-Id: <20210322140206.9513-1-cfontana(a)suse.de> [RFC v11 00/55] arm cleanup experiment for kvm-only build Message-Id: <20210323151749.21299-5-cfontana(a)suse.de> [PATCH 0/2] Fix atomic test in "configure" + bump FreeBSD CI to 12.2 Message-Id: <20210317110512.583747-1-thuth(a)redhat.com> [PATCH v1 0/8] GICv3 LPI and ITS feature implementation Message-Id: <20210323041238.133835-1-shashi.mallela(a)linaro.org> Absences ======== - Linaro Connect Sessions Current Review Queue ==================== TODO [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci Message-Id: <20210325150735.1098387-1-groug(a)kaod.org> =================================================================================================================================== TODO [PATCH RESEND] docs: clarify absence of set_features in vhost-user Message-Id: <20210325144846.17520-1-hi(a)alyssa.is> ======================================================================================================================== TODO [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Message-Id: <cover.1616570702.git.viresh.kumar(a)linaro.org> =========================================================================================================================== TODO [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug Message-Id: <20210314212724.1917075-1-richard.henderson(a)linaro.org> ================================================================================================================================ -- Alex Bennée

4 years, 3 months

1
0
0 0

[ACTIVITY] report week ending 26 Mar

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] - tagged rc0 - various bug investigation/patches for 6.0-ish stuff: + machines with a 'platform bus' incorrectly treated all sysbus devices as hotpluggable: wrote and sent patchseries + respin of gpex pci-host "don't fault for unmapped MMIO/PIO window accesses" patch + document how to use gdbstub/gdb for a multi-cluster machine where the clusters are different gdb inferiors + looked for workarounds for macos Appkit bug where Apple broke menubars for apps that start off as console apps and programmatically switch themselves to being GUI apps; various online suggestions don't seem to help, except for "when app starts, force the Dock to become active and then grab back focus 200ms later". Maybe we'll do that, but it's pretty ugly... thanks -- PMM

4 years, 3 months

1
0
0 0

[ACTIVITY] 22-26 March 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - No regression to report this week * GCC - testsuite cleanup: committed a patch series - fixed PR 99727 - filed / discussed PR 99773 - WIP PR 99786 * Misc == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * Resume GDB/FDPIC work

4 years, 3 months

1
0
0 0

[ACTIVITY] 15-19 March 2021

by Christophe Lyon

== Progress == * GCC upstream validation: - Small improvement to pre-commit testing scripts to allow running a subset of the tests (and thus save a lot of time) * GCC - MVE autovectorization: - vcmp support of FP types OK. - testsuite cleanup: looking at current failures, only found issues with tests so far. Testing several small testsuite patches is taking a long time due to the number of configurations * Misc == Next == * MVE auto-vectorization/intrinsics improvements * GCC/cortex-M testing improvements & fixes * Resume GDB/FDPIC work

4 years, 3 months

1
0
0 0

[ACTIVITY] report week ending 19 Mar

by Peter Maydell

Progress: * UM-2 [QEMU upstream maintainership] - softfreeze was this week, lots of pullreq processing - spun v2 of "fix M-profile load of PC/SP from ELF images via memory aliases" thanks -- PMM

4 years, 3 months

1
0
0 0

Please use staging for your new bots; clang-cmake-aarch64-full is red for a month

by Galina Kistanova

Hello Linaro Toolchain Working Group, Please connect your new bots to the staging first and make them reliably green there: linaro-aarch64-flang-debug linaro-aarch64-flang-latest-clang linaro-aarch64-flang-latest-gcc clang-cmake-aarch64-full is red for a month. https://lab.llvm.org/buildbot/#/builders/7?numbuilds=700 Could you move linaro-aarch64-full to the staging and make it green again, please? Please let me know if I could help or you have questions. Thanks Galina

4 years, 3 months

3
4
0 0

Re: Clang targetting x64 linker

by Maxim Kuvyrkov

Hi Joel, Indeed, LLD is not configured to be used by default in LLVM-12.0.0-rc1. You need to add -fuse-ld=lld option for it to work. We’ll fix this in the final LLVM-12 release for WoA, which is expected in around 2 weeks. Thanks for catching this! c:\Users\tcwg\source\maxim>..\llvm-12.0.0-rc1\bin\clang-cl.exe hello.c clang-cl: error: unable to execute command: Couldn't execute program 'C:\BuildTools\VC\Tools\MSVC\14.28.29333\bin\Hostx64\arm64\link.exe': Unknown error (0xD8) clang-cl: error: linker command failed with exit code 1 (use -v to see invocation) c:\Users\tcwg\source\maxim>..\llvm-12.0.0-rc1\bin\clang-cl.exe -fuse-ld=lld hello.c c:\Users\tcwg\source\maxim>hello.exe Hello c:\Users\tcwg\source\maxim>..\llvm-12.0.0-rc1\bin\clang.exe -fuse-ld=lld hello.c c:\Users\tcwg\source\maxim>hello.exe Hello -- Maxim Kuvyrkov https://www.linaro.org > On 4 Mar 2021, at 19:43, Joel Cox <Joel.Cox(a)arm.com> wrote: > > Hi > > I was trying "clang hello.c" from command line, but "clang-cl hello.c" gives me the same error. I am unsure if this is what you mean but neither work. > > Thanks, > Joel > > -----Original Message----- > From: Maxim Kuvyrkov <maxim.kuvyrkov(a)linaro.org> > Sent: 04 March 2021 16:40 > To: Joel Cox <Joel.Cox(a)arm.com> > Cc: linaro-toolchain(a)lists.linaro.org > Subject: Re: Clang targetting x64 linker > > Hi Joel, > > Are you using clang-cl.exe as compiler/linker driver? It’s easiest to use clang-cl.exe as it aims to be a direct replacement for MSVC’s cl.exe, but will use LLVM tools. In particular, when clang-cl.exe uses LLVM Linker (LLD) by default. > > If you are using linux-style clang.exe as the driver, then you need to specify -fuse-ld=lld to use LLD. > > Does this help? > > Regards, > > -- > Maxim Kuvyrkov > https://www.linaro.org > >> On 4 Mar 2021, at 19:11, Joel Cox <Joel.Cox(a)arm.com> wrote: >> >> Hi >> >> I've been trying to run clang on a Windows on Arm machine, but it keeps trying to using the link.exe located in "Visual studio/..../Host64/arm64", which is (seemingly) an x64 tool and as such doesn't run, and crashes the process. >> Is there a way to set clang to look at VS's x86 link.exe? Or if there is an arm64 version that clang should be using instead? >> >> Thanks, >> Joel >> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. >> _______________________________________________ >> linaro-toolchain mailing list >> linaro-toolchain(a)lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/linaro-toolchain > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

4 years, 3 months

1
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-toolchain