Re: [Linaro-TCWG-CI] FAIL: 1 regressions after glibc-2.38.9000-71-g7086332e06 elf: Check that --list-diagnostics output has the expected syntax
On Aug 25, 2023, at 19:18, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch. Please find below some details about it. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list.
In CI config tcwg_glibc_check/master-aarch64 after:
| Patchwork URL: https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6.fsf@oldenbur... | commit 7086332e068cbe778cb47a9baf23cd1d2401444a | Author: Florian Weimer fweimer@redhat.com | Date: Fri Aug 25 14:52:01 2023 +0200 | | elf: Check that --list-diagnostics output has the expected syntax | | Parts of elf/tst-rtld-list-diagnostics.py have been copied from | scripts/tst-ld-trace.py. | | The abnf module is entirely optional and used to verify the | ... 3 lines of the commit log omitted.
FAIL: 1 regressions
regressions.sum: === glibc tests ===
Running glibc:elf ... FAIL: elf/tst-rtld-list-diagnostics
Hi Florian,
Output of failed test is in [1].
[1] https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/art... .
Regards,
-- Maxim Kuvyrkov https://www.linaro.org
=== Results Summary ===
-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:
Current build : https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/art... Reference build : https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-build/622/artifac...
Reproduce last good and first bad builds: https://git.linaro.org/toolchain/ci/interesting-commits.git/plain/glibc/sha1...
Full commit : https://sourceware.org/git/?p=glibc.git%3Ba=commitdiff%3Bh=7086332e068cbe778...
Latest bug report status : https://linaro.atlassian.net/browse/GNU-692
List of configurations that regressed due to this commit :
- tcwg_glibc_check
** master-aarch64 *** FAIL: 1 regressions *** https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/
* Maxim Kuvyrkov:
On Aug 25, 2023, at 19:18, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch. Please find below some details about it. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list.
In CI config tcwg_glibc_check/master-aarch64 after:
| Patchwork URL: https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6.fsf@oldenbur... | commit 7086332e068cbe778cb47a9baf23cd1d2401444a | Author: Florian Weimer fweimer@redhat.com | Date: Fri Aug 25 14:52:01 2023 +0200 | | elf: Check that --list-diagnostics output has the expected syntax | | Parts of elf/tst-rtld-list-diagnostics.py have been copied from | scripts/tst-ld-trace.py. | | The abnf module is entirely optional and used to verify the | ... 3 lines of the commit log omitted.
FAIL: 1 regressions
regressions.sum: === glibc tests ===
Running glibc:elf ... FAIL: elf/tst-rtld-list-diagnostics
Hi Florian,
Output of failed test is in [1].
[1] https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/art... .
Nope:
| FAIL: elf/tst-rtld-list-diagnostics | original exit status 1 | info: skipping ABNF validation because the abnf module is missing
The failure is in the “make check” logs:
| Traceback (most recent call last): | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 303, in <module> | main(sys.argv[1:]) | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 294, in main | check_consistency_with_manual(opts.manual) | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 188, in check_consistency_with_manual | manual_abnf = extract_lines(manual_path, | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 172, in extract_lines | raise ValueError('{!r} not found in {!r}'.format(start_line, path)) | ValueError: '@c ABNF-START' not found in '../manual/dynlink.texi'
Arguably this is a problem in the test/test machinery (we do not redirect standard error with the Python exceptions).
This likely means that
commit f21962ddfc8bb23e92597da1f98e313dbde11cc1 Author: Florian Weimer fweimer@redhat.com Date: Fri Aug 25 14:15:28 2023 +0200
manual: Document ld.so --list-diagnostics output
Reviewed-by: Adhemerval Zanella adhemerval.zanella@linaro.org
was missing during the build. The original notification said that it was against this commit:
| Full commit : https://sourceware.org/git/?p=glibc.git%3Ba=commitdiff%3Bh=7086332e068cbe778...
But that's not a commit hash I can find anywhere else.
Thanks, Florian
On Aug 25, 2023, at 21:02, Florian Weimer fweimer@redhat.com wrote:
- Maxim Kuvyrkov:
On Aug 25, 2023, at 19:18, ci_notify@linaro.org wrote:
Dear contributor, our automatic CI has detected problems related to your patch. Please find below some details about it. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list.
In CI config tcwg_glibc_check/master-aarch64 after:
| Patchwork URL: https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6.fsf@oldenbur... | commit 7086332e068cbe778cb47a9baf23cd1d2401444a | Author: Florian Weimer fweimer@redhat.com | Date: Fri Aug 25 14:52:01 2023 +0200 | | elf: Check that --list-diagnostics output has the expected syntax | | Parts of elf/tst-rtld-list-diagnostics.py have been copied from | scripts/tst-ld-trace.py. | | The abnf module is entirely optional and used to verify the | ... 3 lines of the commit log omitted.
FAIL: 1 regressions
regressions.sum: === glibc tests ===
Running glibc:elf ... FAIL: elf/tst-rtld-list-diagnostics
Hi Florian,
Output of failed test is in [1].
[1] https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/art... .
Nope:
| FAIL: elf/tst-rtld-list-diagnostics | original exit status 1 | info: skipping ABNF validation because the abnf module is missing
The failure is in the “make check” logs:
| Traceback (most recent call last): | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 303, in <module> | main(sys.argv[1:]) | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 294, in main | check_consistency_with_manual(opts.manual) | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 188, in check_consistency_with_manual | manual_abnf = extract_lines(manual_path, | File "/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", line 172, in extract_lines | raise ValueError('{!r} not found in {!r}'.format(start_line, path)) | ValueError: '@c ABNF-START' not found in '../manual/dynlink.texi'
Arguably this is a problem in the test/test machinery (we do not redirect standard error with the Python exceptions).
This likely means that
commit f21962ddfc8bb23e92597da1f98e313dbde11cc1 Author: Florian Weimer fweimer@redhat.com Date: Fri Aug 25 14:15:28 2023 +0200
manual: Document ld.so --list-diagnostics output
Reviewed-by: Adhemerval Zanella adhemerval.zanella@linaro.org
was missing during the build.
Right. The scenario was: 1. Post-commit build starts against glibc:master == glibc:abc123 2. Developer (you in this case) commits patch:123 and posts it to libc-alpha@. 3. Post-commit build completes and sets baseline for pre-commit testing to glibc:abc123, which is now 30+ minutes old. 4. Post-commit build triggers pre-commit testing, including patch:123. 5. Pre-commit testing applies patch:123 to baseline glibc:abc123, which succeeds.
The problem occurs if committed patch depends on another patch outside of its patch series.
The original notification said that it was against this commit:
| Full commit : https://sourceware.org/git/?p=glibc.git%3Ba=commitdiff%3Bh=7086332e068cbe778...
But that's not a commit hash I can find anywhere else.
Above "Full commit" is what was tested; it was your patch applied on top of pre-commit baseline. I need to remove that line from the email.
Regards,
-- Maxim Kuvyrkov https://www.linaro.org
linaro-toolchain@lists.linaro.org
-
Florian Weimer -
Maxim Kuvyrkov