Linux-kselftest-mirror

linux-kselftest-mirror@lists.linaro.org

135 participants
14278 discussions

[PATCH cgroup/for-6.20 v4 0/5] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict

by Waiman Long

v4: - Add tags and fix patch 4 commit log v3: - Patch 2: Change the condition for calling reset_partition_data() to (new_prs <= 0). - Patch 4: Update commit log and code comment to clarify the change. - Add a new patch 5 to move the empty cpus/mems check to cpuset1_validate_change(). v2: - Patch 1: additional comment - Patch 2: simplify the conditions for triggering call to compute_excpus(). - Patch 3: update description of cpuset.cpus.exclusive in cgroup-v2.rst to reflect the new behavior and change the name of the new cpus_excl_conflict() parameter to xcpus_changed. - Patch 4: update description of cpuset.cpus.partition in cgroup-v2.rst to clarify what exclusive CPUs will be used when a partition is created. This patch series is inspired by the cpuset patch sent by Sun Shaojie [1]. The idea is to avoid invalidating sibling partitions when there is a cpuset.cpus conflict. However this patch series does it in a slightly different way to make its behavior more consistent with other cpuset properties. The first 3 patches are just some cleanup and minor bug fixes on issues found during the investigation process. The last one is the major patch that changes the way cpuset.cpus is being handled during the partition creation process. Instead of invalidating sibling partitions when there is a conflict, it will strip out the conflicting exclusive CPUs and assign the remaining non-conflicting exclusive CPUs to the new partition unless there is no more CPU left which will fail the partition creation process. It is similar to the idea that cpuset.cpus.effective may only contain a subset of CPUs specified in cpuset.cpus. So cpuset.cpus.exclusive.effective may contain only a subset of cpuset.cpus when a partition is created without setting cpuset.cpus.exclusive. Even setting cpuset.cpus.exclusive instead of cpuset.cpus may not guarantee all the requested CPUs can be granted if parent doesn't have access to some of those exclusive CPUs. The difference is that conflicts from siblings is not possible with cpuset.cpus.exclusive as long as it can be set successfully without failure. [1] https://lore.kernel.org/lkml/20251117015708.977585-1-sunshaojie@kylinos.cn/ Waiman Long (5): cgroup/cpuset: Streamline rm_siblings_excl_cpus() cgroup/cpuset: Consistently compute effective_xcpus in update_cpumasks_hier() cgroup/cpuset: Don't fail cpuset.cpus change in v2 cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict cgroup/cpuset: Move the v1 empty cpus/mems check to cpuset1_validate_change() Documentation/admin-guide/cgroup-v2.rst | 40 +++-- kernel/cgroup/cpuset-internal.h | 12 ++ kernel/cgroup/cpuset-v1.c | 33 ++++ kernel/cgroup/cpuset.c | 163 ++++++------------ .../selftests/cgroup/test_cpuset_prs.sh | 29 +++- 5 files changed, 150 insertions(+), 127 deletions(-) -- 2.52.0

1 day, 1 hour

[PATCH bpf-next v5 0/9] bpf: Extend BPF syscall with common attributes support

by Leon Hwang

This patch series builds upon the discussion in "[PATCH bpf-next v4 0/4] bpf: Improve error reporting for freplace attachment failure" [1]. This patch series introduces support for *common attributes* in the BPF syscall, providing a unified mechanism for passing shared metadata across all BPF commands. The initial set of common attributes includes: 1. 'log_buf': User-provided buffer for storing log output. 2. 'log_size': Size of the provided log buffer. 3. 'log_level': Verbosity level for logging. 4. 'log_true_size': The size of log reported by kernel. With this extension, the BPF syscall will be able to return meaningful error messages (e.g., failures of creating map), improving debuggability and user experience. Links: [1] https://lore.kernel.org/bpf/20250224153352.64689-1-leon.hwang@linux.dev/ Changes: v4 -> v5: * Rework reporting 'log_true_size' for prog_load, btf_load, and map_create (per Alexei). RFC v3 -> v4: * Drop RFC. * Address comments from Andrii: * Add parentheses in 'sys_bpf_ext()'. * Avoid creating new fd in 'probe_sys_bpf_ext()'. * Add a new struct to wrap log fields in libbpf. * Address comments from Alexei: * Do not skip writing to user space when log_true_size is zero. * Do not use 'bool' arguments. * Drop the adding WARN_ON_ONCE()'s. RFC v2 -> RFC v3: * Rename probe_sys_bpf_extended to probe_sys_bpf_ext. * Refactor reporting 'log_true_size' for prog_load. * Refactor reporting 'btf_log_true_size' for btf_load. * Add warnings for internal bugs in map_create. * Check log_true_size in test cases. * Address comment from Alexei: * Change kvzalloc/kvfree to kzalloc/kfree. * Address comments from Andrii: * Move BPF_COMMON_ATTRS to 'enum bpf_cmd' alongside brief comment. * Add bpf_check_uarg_tail_zero() for extra checks. * Rename sys_bpf_extended to sys_bpf_ext. * Rename sys_bpf_fd_extended to sys_bpf_ext_fd. * Probe the new feature using NULL and -EFAULT. * Move probe_sys_bpf_ext to libbpf_internal.h and drop LIBBPF_API. * Return -EUSERS when log attrs are conflict between bpf_attr and bpf_common_attr. * Avoid touching bpf_vlog_init(). * Update the reason messages in map_create. * Finalize the log using __cleanup(). * Report log size to users. * Change type of log_buf from '__u64' to 'const char *' and cast type using ptr_to_u64() in bpf_map_create(). * Do not return -EOPNOTSUPP when kernel doesn't support this feature in bpf_map_create(). * Add log_level support for map creation for consistency. * Address comment from Eduard: * Use common_attrs->log_level instead of BPF_LOG_FIXED. RFC v1 -> RFC v2: * Fix build error reported by test bot. * Address comments from Alexei: * Drop new uapi for freplace. * Add common attributes support for prog_load and btf_load. * Add common attributes support for map_create. Leon Hwang (9): bpf: Extend BPF syscall with common attributes support libbpf: Add support for extended bpf syscall bpf: Refactor reporting log_true_size for prog_load bpf: Add syscall common attributes support for prog_load bpf: Refactor reporting btf_log_true_size for btf_load bpf: Add syscall common attributes support for btf_load bpf: Add syscall common attributes support for map_create libbpf: Add common attr support for map_create selftests/bpf: Add tests to verify map create failure log include/linux/bpf.h | 19 +- include/linux/bpf_verifier.h | 17 ++ include/linux/btf.h | 3 +- include/linux/syscalls.h | 3 +- include/uapi/linux/bpf.h | 8 + kernel/bpf/btf.c | 32 +--- kernel/bpf/log.c | 103 +++++++++++ kernel/bpf/syscall.c | 122 ++++++++++--- kernel/bpf/verifier.c | 19 +- tools/include/uapi/linux/bpf.h | 8 + tools/lib/bpf/bpf.c | 49 ++++- tools/lib/bpf/bpf.h | 17 +- tools/lib/bpf/features.c | 8 + tools/lib/bpf/libbpf_internal.h | 3 + .../selftests/bpf/prog_tests/map_init.c | 168 ++++++++++++++++++ 15 files changed, 518 insertions(+), 61 deletions(-) -- 2.52.0

1 day, 2 hours

[PATCH v5 net 2/2] selftests: net: simple selftest for ipvtap

by Dmitry Skorodumov

This is a simple ipvtap test to test handling IP-address add/remove on ipvlan interface. It creates a veth-interface and then creates several network-namespace with ipvlan0 interface in it linked to veth. Then it starts to add/remove addresses on ipvlan0 interfaces in several threads. At finish, it checks that there is no duplicated addresses. Signed-off-by: Dmitry Skorodumov <skorodumov.dmitry(a)huawei.com> --- v5: - Execution time of ip-set thread is limited with 1 minute. - Don't use KSFT_MACHINE_SLOW. - Fixed position of "CONFIG_TAP=m" in config v4: - Removed unneeded modprobe - Number of threads is 8, if KSFT_MACHINE_SLOW==yes. It is needed, since on debug-build test may take more than 15 minutes. - Now veth is created in own namespace - Added comment about why test adds/removes random ip tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/config | 2 + tools/testing/selftests/net/ipvtap_test.sh | 168 +++++++++++++++++++++ 3 files changed, 171 insertions(+) create mode 100755 tools/testing/selftests/net/ipvtap_test.sh diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index b66ba04f19d9..45c4ea381bc3 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -48,6 +48,7 @@ TEST_PROGS := \ ipv6_flowlabel.sh \ ipv6_force_forwarding.sh \ ipv6_route_update_soft_lockup.sh \ + ipvtap_test.sh \ l2_tos_ttl_inherit.sh \ l2tp.sh \ link_netns.py \ diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 1e1f253118f5..b84362b9b508 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -48,6 +48,7 @@ CONFIG_IPV6_SEG6_LWTUNNEL=y CONFIG_IPV6_SIT=y CONFIG_IPV6_VTI=y CONFIG_IPVLAN=m +CONFIG_IPVTAP=m CONFIG_KALLSYMS=y CONFIG_L2TP=m CONFIG_L2TP_ETH=m @@ -116,6 +117,7 @@ CONFIG_PROC_SYSCTL=y CONFIG_PSAMPLE=m CONFIG_RPS=y CONFIG_SYSFS=y +CONFIG_TAP=m CONFIG_TCP_MD5SIG=y CONFIG_TEST_BLACKHOLE_DEV=m CONFIG_TEST_BPF=m diff --git a/tools/testing/selftests/net/ipvtap_test.sh b/tools/testing/selftests/net/ipvtap_test.sh new file mode 100755 index 000000000000..354ca7ce8584 --- /dev/null +++ b/tools/testing/selftests/net/ipvtap_test.sh @@ -0,0 +1,168 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# +# Simple tests for ipvtap + + +# +# The testing environment looks this way: +# +# |------HNS-------| |------PHY-------| +# | veth<----------------->veth | +# |------|--|------| |----------------| +# | | +# | | |-----TST0-------| +# | |------------|----ipvlan | +# | |----------------| +# | +# | |-----TST1-------| +# |---------------|----ipvlan | +# |----------------| +# + +ALL_TESTS=" + test_ip_set +" + +source lib.sh + +DEBUG=0 + +VETH_HOST=vethtst.h +VETH_PHY=vethtst.p + +NS_COUNT=32 +IP_ITERATIONS=1024 +IPSET_TIMEOUT="60s" + +ns_run() { + ns=$1 + shift + if [[ "$ns" == "global" ]]; then + "$@" >/dev/null + else + ip netns exec "$ns" "$@" >/dev/null + fi +} + +test_ip_setup_env() { + setup_ns NS_PHY + setup_ns HST_NS + + # setup simulated other-host (phy) and host itself + ns_run "$HST_NS" ip link add $VETH_HOST type veth peer name $VETH_PHY \ + netns "$NS_PHY" >/dev/null + ns_run "$HST_NS" ip link set $VETH_HOST up + ns_run "$NS_PHY" ip link set $VETH_PHY up + + for ((i=0; i<NS_COUNT; i++)); do + setup_ns ipvlan_ns_$i + ns="ipvlan_ns_$i" + if [ "$DEBUG" = "1" ]; then + echo "created NS ${!ns}" + fi + if ! ns_run "$HST_NS" ip link add netns ${!ns} ipvlan0 \ + link $VETH_HOST \ + type ipvtap mode l2 bridge; then + exit_error "FAIL: Failed to configure ipvlan link." + fi + done +} + +test_ip_cleanup_env() { + ns_run "$HST_NS" ip link del $VETH_HOST + cleanup_all_ns +} + +exit_error() { + echo "$1" + exit $ksft_fail +} + +rnd() { + echo $(( RANDOM % 32 + 16 )) +} + +test_ip_set_thread() { + # Here we are trying to create some IP conflicts between namespaces. + # If just add/remove IP, nothing interesting will happen. + # But if add random IP and then remove random IP, + # eventually conflicts start to apear. + ip link set ipvlan0 up + for ((i=0; i<IP_ITERATIONS; i++)); do + v=$(rnd) + ip a a "172.25.0.$v/24" dev ipvlan0 2>/dev/null + ip a a "fc00::$v/64" dev ipvlan0 2>/dev/null + v=$(rnd) + ip a d "172.25.0.$v/24" dev ipvlan0 2>/dev/null + ip a d "fc00::$v/64" dev ipvlan0 2>/dev/null + done +} + +test_ip_set() { + RET=0 + + trap test_ip_cleanup_env EXIT + + test_ip_setup_env + + declare -A ns_pids + for ((i=0; i<NS_COUNT; i++)); do + ns="ipvlan_ns_$i" + ns_run ${!ns} timeout "$IPSET_TIMEOUT" \ + bash -c "$0 test_ip_set_thread"& + ns_pids[$i]=$! + done + + for ((i=0; i<NS_COUNT; i++)); do + wait "${ns_pids[$i]}" + done + + declare -A all_ips + for ((i=0; i<NS_COUNT; i++)); do + ns="ipvlan_ns_$i" + ip_output=$(ip netns exec ${!ns} ip a l dev ipvlan0 | grep inet) + while IFS= read -r nsip_out; do + if [[ -z $nsip_out ]]; then + continue; + fi + nsip=$(awk '{print $2}' <<< "$nsip_out") + if [[ -v all_ips[$nsip] ]]; then + RET=$ksft_fail + log_test "conflict for $nsip" + return "$RET" + else + all_ips[$nsip]=$i + fi + done <<< "$ip_output" + done + + if [ "$DEBUG" = "1" ]; then + for key in "${!all_ips[@]}"; do + echo "$key: ${all_ips[$key]}" + done + fi + + trap - EXIT + test_ip_cleanup_env + + log_test "test multithreaded ip set" +} + +if [[ "$1" == "-d" ]]; then + DEBUG=1 + shift +fi + +if [[ "$1" == "-t" ]]; then + shift + TESTS="$*" +fi + +if [[ "$1" == "test_ip_set_thread" ]]; then + test_ip_set_thread +else + require_command ip + + tests_run +fi -- 2.43.0

1 day, 2 hours

[PATCH v1 0/2] selftests/x86: Skip int80 if not supported

by Slawomir Rosek

The IA32 Emulation support can be either removed from the kernel, disabled by default or disabled at runtime. Some of x86 selftests are crashing for all of above thus is_32bit_syscall_supported() helper is added to skip int80 syscalls if they are not supported. Slawomir Rosek (2): selftests/x86/ldt_gdt: Skip int80 if not supported selftests/x86/ptrace_syscall: Skip int80 if not supported tools/testing/selftests/x86/ldt_gdt.c | 21 +++++++++++++++++++- tools/testing/selftests/x86/ptrace_syscall.c | 20 +++++++++++++++++-- 2 files changed, 38 insertions(+), 3 deletions(-) -- 2.52.0.305.g3fc767764a-goog

1 day, 5 hours

next-20251020: selftests: helpers.h:10:10: fatal error: kselftest.h: No such file or directory

by Naresh Kamboju

The selftests x86_64 builds failed due to following build warnings / errors on the Linux next-20251020 and next-20251021 tags with gcc-14 and clang-21. First seen on next-20251020 Good: next-20251020 Bad: next-20251017 Regression Analysis: - New regression? yes - Reproducibility? yes ### Build errors x86_64-linux-gnu-gcc -m64 -o kselftest/x86/single_step_syscall_64 -O2 -g -std=gnu99 -pthread -Wall -isystem usr/include -no-pie -DCAN_BUILD_64 single_step_syscall.c -lrt -ldl In file included from single_step_syscall.c:34: helpers.h:10:10: fatal error: kselftest.h: No such file or directory 10 | #include "kselftest.h" | ^~~~~~~~~~~~~ compilation terminated. make[4]: *** [Makefile:86: kselftest/x86/single_step_syscall_64] Error 1 ### Suspected patch git log --oneline next-20251017..next-20251020 -- tools/testing/selftests/x86/ 4d89827dfb274 selftests: complete kselftest include centralization Build regressions: next-20251020: selftests: helpers.h:10:10: fatal error: kselftest.h: No such file or directory Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> ### Steps to reproduce - tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-14 \ --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/34JgN0fZ9uXj6HVnjvjq… \ debugkernel cpupower headers kernel kselftest modules ## Source * Kernel version: 6.18.0-rc2 * Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git * Git describe: next-20251021 and next-20251020 * Git commit: fe45352cd106ae41b5ad3f0066c2e54dbb2dfd70 * Architectures: x86_64 * Toolchains: gcc-14 and clang-21 * Kconfigs: defconfig+selftests/*/configs ## Build * Build log: https://storage.tuxsuite.com/public/linaro/lkft/builds/34JgN0fZ9uXj6HVnjvjq… * Build details: https://regressions.linaro.org/lkft/linux-next-master/next-20251020/kselfte… * Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/34JgN0fZ9uXj6HVnjvjq… * Kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/34JgN0fZ9uXj6HVnjvjq… -- Linaro LKFT https://lkft.linaro.org

1 day, 6 hours

Re: [PATCH 5/6] powerpc64/bpf: Support exceptions

by Christophe Leroy (CS GROUP)

Le 12/01/2026 à 07:58, adubey a écrit : > [Vous ne recevez pas souvent de courriers de adubey(a)imap.linux.ibm.com. > D?couvrez pourquoi ceci est important ? https://aka.ms/ > LearnAboutSenderIdentification ] > > On 2026-01-12 11:21, Saket Kumar Bhaskar wrote: >> On Mon, Jan 05, 2026 at 04:22:11PM +0530, adubey(a)linux.ibm.com wrote: >>> From: Abhishek Dubey <adubey(a)linux.ibm.com> >>> >>> The modified prologue/epilogue generation code now >>> enables exception-callback to use the stack frame of >>> the program marked as exception boundary, where callee >>> saved registers are stored. >>> >>> As per ppc64 ABIv2 documentation[1], r14-r31 are callee >>> saved registers. BPF programs on ppc64 already saves >>> r26-r31 registers. Saving the remaining set of callee >>> saved registers(r14-r25) is handled in the next patch. >>> >>> [1] >>> https://eur01.safelinks.protection.outlook.com/? >>> url=https%3A%2F%2Fftp.rtems.org%2Fpub%2Frtems%2Fpeople%2Fsebh%2FABI64BitOpenPOWERv1.1_16July2015_pub.pdf&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cdecf1943ac9949608edb08de51a7f357%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639037978954052961%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=uCfpmnY2bQT7yD3esp8nkyLPGfEzpK9UoCgV2sm0j80%3D&reserved=0 >>> >>> Following is exceptions selftest result on ppc64le: >>> >>> # ./test_progs -t exceptions >>> #100/1 exceptions/exception_throw_always_1:OK >>> #100/2 exceptions/exception_throw_always_2:OK >>> #100/3 exceptions/exception_throw_unwind_1:OK >>> #100/4 exceptions/exception_throw_unwind_2:OK >>> #100/5 exceptions/exception_throw_default:OK >>> #100/6 exceptions/exception_throw_default_value:OK >>> #100/7 exceptions/exception_tail_call:OK >>> #100/8 exceptions/exception_ext:OK >>> #100/9 exceptions/exception_ext_mod_cb_runtime:OK >>> #100/10 exceptions/exception_throw_subprog:OK >>> #100/11 exceptions/exception_assert_nz_gfunc:OK >>> #100/12 exceptions/exception_assert_zero_gfunc:OK >>> #100/13 exceptions/exception_assert_neg_gfunc:OK >>> #100/14 exceptions/exception_assert_pos_gfunc:OK >>> #100/15 exceptions/exception_assert_negeq_gfunc:OK >>> #100/16 exceptions/exception_assert_poseq_gfunc:OK >>> #100/17 exceptions/exception_assert_nz_gfunc_with:OK >>> #100/18 exceptions/exception_assert_zero_gfunc_with:OK >>> #100/19 exceptions/exception_assert_neg_gfunc_with:OK >>> #100/20 exceptions/exception_assert_pos_gfunc_with:OK >>> #100/21 exceptions/exception_assert_negeq_gfunc_with:OK >>> #100/22 exceptions/exception_assert_poseq_gfunc_with:OK >>> #100/23 exceptions/exception_bad_assert_nz_gfunc:OK >>> #100/24 exceptions/exception_bad_assert_zero_gfunc:OK >>> #100/25 exceptions/exception_bad_assert_neg_gfunc:OK >>> #100/26 exceptions/exception_bad_assert_pos_gfunc:OK >>> #100/27 exceptions/exception_bad_assert_negeq_gfunc:OK >>> #100/28 exceptions/exception_bad_assert_poseq_gfunc:OK >>> #100/29 exceptions/exception_bad_assert_nz_gfunc_with:OK >>> #100/30 exceptions/exception_bad_assert_zero_gfunc_with:OK >>> #100/31 exceptions/exception_bad_assert_neg_gfunc_with:OK >>> #100/32 exceptions/exception_bad_assert_pos_gfunc_with:OK >>> #100/33 exceptions/exception_bad_assert_negeq_gfunc_with:OK >>> #100/34 exceptions/exception_bad_assert_poseq_gfunc_with:OK >>> #100/35 exceptions/exception_assert_range:OK >>> #100/36 exceptions/exception_assert_range_with:OK >>> #100/37 exceptions/exception_bad_assert_range:OK >>> #100/38 exceptions/exception_bad_assert_range_with:OK >>> #100/39 exceptions/non-throwing fentry -> exception_cb:OK >>> #100/40 exceptions/throwing fentry -> exception_cb:OK >>> #100/41 exceptions/non-throwing fexit -> exception_cb:OK >>> #100/42 exceptions/throwing fexit -> exception_cb:OK >>> #100/43 exceptions/throwing extension (with custom cb) -> >>> exception_cb:OK >>> #100/44 exceptions/throwing extension -> global func in >>> exception_cb:OK >>> #100/45 exceptions/exception_ext_mod_cb_runtime:OK >>> #100/46 exceptions/throwing extension (with custom cb) -> global func >>> in exception_cb:OK >>> #100/47 exceptions/exception_ext:OK >>> #100/48 exceptions/non-throwing fentry -> non-throwing subprog:OK >>> #100/49 exceptions/throwing fentry -> non-throwing subprog:OK >>> #100/50 exceptions/non-throwing fentry -> throwing subprog:OK >>> #100/51 exceptions/throwing fentry -> throwing subprog:OK >>> #100/52 exceptions/non-throwing fexit -> non-throwing subprog:OK >>> #100/53 exceptions/throwing fexit -> non-throwing subprog:OK >>> #100/54 exceptions/non-throwing fexit -> throwing subprog:OK >>> #100/55 exceptions/throwing fexit -> throwing subprog:OK >>> #100/56 exceptions/non-throwing fmod_ret -> non-throwing subprog:OK >>> #100/57 exceptions/non-throwing fmod_ret -> non-throwing global >>> subprog:OK >>> #100/58 exceptions/non-throwing extension -> non-throwing subprog:OK >>> #100/59 exceptions/non-throwing extension -> throwing subprog:OK >>> #100/60 exceptions/non-throwing extension -> non-throwing subprog:OK >>> #100/61 exceptions/non-throwing extension -> throwing global >>> subprog:OK >>> #100/62 exceptions/throwing extension -> throwing global subprog:OK >>> #100/63 exceptions/throwing extension -> non-throwing global >>> subprog:OK >>> #100/64 exceptions/non-throwing extension -> main subprog:OK >>> #100/65 exceptions/throwing extension -> main subprog:OK >>> #100/66 exceptions/reject_exception_cb_type_1:OK >>> #100/67 exceptions/reject_exception_cb_type_2:OK >>> #100/68 exceptions/reject_exception_cb_type_3:OK >>> #100/69 exceptions/reject_exception_cb_type_4:OK >>> #100/70 exceptions/reject_async_callback_throw:OK >>> #100/71 exceptions/reject_with_lock:OK >>> #100/72 exceptions/reject_subprog_with_lock:OK >>> #100/73 exceptions/reject_with_rcu_read_lock:OK >>> #100/74 exceptions/reject_subprog_with_rcu_read_lock:OK >>> #100/75 exceptions/reject_with_rbtree_add_throw:OK >>> #100/76 exceptions/reject_with_reference:OK >>> #100/77 exceptions/reject_with_cb_reference:OK >>> #100/78 exceptions/reject_with_cb:OK >>> #100/79 exceptions/reject_with_subprog_reference:OK >>> #100/80 exceptions/reject_throwing_exception_cb:OK >>> #100/81 exceptions/reject_exception_cb_call_global_func:OK >>> #100/82 exceptions/reject_exception_cb_call_static_func:OK >>> #100/83 exceptions/reject_multiple_exception_cb:OK >>> #100/84 exceptions/reject_exception_throw_cb:OK >>> #100/85 exceptions/reject_exception_throw_cb_diff:OK >>> #100/86 exceptions/reject_set_exception_cb_bad_ret1:OK >>> #100/87 exceptions/reject_set_exception_cb_bad_ret2:OK >>> #100/88 exceptions/check_assert_eq_int_min:OK >>> #100/89 exceptions/check_assert_eq_int_max:OK >>> #100/90 exceptions/check_assert_eq_zero:OK >>> #100/91 exceptions/check_assert_eq_llong_min:OK >>> #100/92 exceptions/check_assert_eq_llong_max:OK >>> #100/93 exceptions/check_assert_lt_pos:OK >>> #100/94 exceptions/check_assert_lt_zero:OK >>> #100/95 exceptions/check_assert_lt_neg:OK >>> #100/96 exceptions/check_assert_le_pos:OK >>> #100/97 exceptions/check_assert_le_zero:OK >>> #100/98 exceptions/check_assert_le_neg:OK >>> #100/99 exceptions/check_assert_gt_pos:OK >>> #100/100 exceptions/check_assert_gt_zero:OK >>> #100/101 exceptions/check_assert_gt_neg:OK >>> #100/102 exceptions/check_assert_ge_pos:OK >>> #100/103 exceptions/check_assert_ge_zero:OK >>> #100/104 exceptions/check_assert_ge_neg:OK >>> #100/105 exceptions/check_assert_range_s64:OK >>> #100/106 exceptions/check_assert_range_u64:OK >>> #100/107 exceptions/check_assert_single_range_s64:OK >>> #100/108 exceptions/check_assert_single_range_u64:OK >>> #100/109 exceptions/check_assert_generic:OK >>> #100/110 exceptions/check_assert_with_return:OK >>> #100 exceptions:OK >>> Summary: 1/110 PASSED, 0 SKIPPED, 0 FAILED >>> >> It would be great to include this selftest output in the cover letter >> instead, since it makes the git log excessively long. >> >> Thanks, >> Saket > > Major contributors in the community routinely include test case results > in commit messages, and this is not viewed as problematic. > Eg: bpf-next : e59997d9052599feb17419289f2a57ed300e1dfa, This is a merge commit, the message comes from the cover letter of the series: https://lore.kernel.org/all/20240201125225.72796-1-puranjay12@gmail.com/ > 6c17a882d3804dce1c66e1fec25f96d39a184067 In this one the list of tests is rather small compared to the entire commit message. So I also recommend to move this big list of tests in the cover letter. Christophe

1 day, 9 hours

[PATCH 0/6] powerpc64/bpf: Support tailcalls with subprogs & BPF exceptions

by adubey＠linux.ibm.com

From: Abhishek Dubey <adubey(a)linux.ibm.com> This patch series enables support for two BPF JIT features on powerpc64. The first three patches target support for tail calls with subprogram combinations. The third patch includes an optimization in which NVRs are accommodated in the stack save area of the trampoline frame. Implementation details are provided in the commit messages. The last three patches add support for BPF exceptions. An architecture-specific stack walker is implemented to assist with stack walk during exceptions. BPF selftest results and implementation details are presented in the corresponding commits. Abhishek Dubey (6): powerpc64/bpf: Support tailcalls with subprogs powerpc64/bpf: Tailcall handling with trampolines powerpc/bpf: use BPF_PPC_STACK_SAVE to spill trampoline NVRs powerpc64/bpf: Add arch_bpf_stack_walk() for BPF JIT powerpc64/bpf: Support exceptions powerpc64/bpf: Additional NVR handling for bpf_throw arch/powerpc/net/bpf_jit.h | 16 ++- arch/powerpc/net/bpf_jit_comp.c | 90 +++++++++---- arch/powerpc/net/bpf_jit_comp64.c | 214 ++++++++++++++++++++++++------ 3 files changed, 256 insertions(+), 64 deletions(-) -- 2.48.1

1 day, 11 hours

[PATCH] kunit: tool: suppress confusing error output in test

by Jinseok Kim

When running kunit_tool_test.py, the test_run_raw_output_invalid test prints invalid usage text and error messages to stderr. This happens because the test triggers kunit.main() with an invalid argument, causing argparse to print the usage and exit. This output is confusing to the user because it looks like a test failure or usage error, even though the test passed successfully. Furthermore, argparse displays 'usage: kunit_tool_test.py run ...', which is misleading since the test script itself does not accept the 'run' command. This patch mocks sys.stderr in the test to suppress this expected error output, making the test execution output cleaner. Signed-off-by: Jinseok Kim <always.starving0(a)gmail.com> --- tools/testing/kunit/kunit_tool_test.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index bbba921e0eac..7a8ba8e4f1d4 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -8,6 +8,7 @@ import unittest from unittest import mock +import io import tempfile, shutil # Handling test_tmpdir @@ -688,8 +689,9 @@ class KUnitMainTest(unittest.TestCase): def test_run_raw_output_invalid(self): self.linux_source_mock.run_kernel = mock.Mock(return_value=[]) - with self.assertRaises(SystemExit) as e: - kunit.main(['run', '--raw_output=invalid']) + with mock.patch('sys.stderr', new=io.StringIO()): + with self.assertRaises(SystemExit) as e: + kunit.main(['run', '--raw_output=invalid']) self.assertNotEqual(e.exception.code, 0) def test_run_raw_output_does_not_take_positional_args(self): -- 2.43.0

1 day, 12 hours

[PATCH cgroup/for-6.20 v3 0/5] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict

by Waiman Long

v3: - Patch 2: Change the condition for calling reset_partition_data() to (new_prs <= 0). - Patch 4: Update commit log and code comment to clarify the change. - Add a new patch 5 to move the empty cpus/mems check to cpuset1_validate_change(). v2: - Patch 1: additional comment - Patch 2: simplify the conditions for triggering call to compute_excpus(). - Patch 3: update description of cpuset.cpus.exclusive in cgroup-v2.rst to reflect the new behavior and change the name of the new cpus_excl_conflict() parameter to xcpus_changed. - Patch 4: update description of cpuset.cpus.partition in cgroup-v2.rst to clarify what exclusive CPUs will be used when a partition is created. This patch series is inspired by the cpuset patch sent by Sun Shaojie [1]. The idea is to avoid invalidating sibling partitions when there is a cpuset.cpus conflict. However this patch series does it in a slightly different way to make its behavior more consistent with other cpuset properties. The first 3 patches are just some cleanup and minor bug fixes on issues found during the investigation process. The last one is the major patch that changes the way cpuset.cpus is being handled during the partition creation process. Instead of invalidating sibling partitions when there is a conflict, it will strip out the conflicting exclusive CPUs and assign the remaining non-conflicting exclusive CPUs to the new partition unless there is no more CPU left which will fail the partition creation process. It is similar to the idea that cpuset.cpus.effective may only contain a subset of CPUs specified in cpuset.cpus. So cpuset.cpus.exclusive.effective may contain only a subset of cpuset.cpus when a partition is created without setting cpuset.cpus.exclusive. Even setting cpuset.cpus.exclusive instead of cpuset.cpus may not guarantee all the requested CPUs can be granted if parent doesn't have access to some of those exclusive CPUs. The difference is that conflicts from siblings is not possible with cpuset.cpus.exclusive as long as it can be set successfully without failure. [1] https://lore.kernel.org/lkml/20251117015708.977585-1-sunshaojie@kylinos.cn/ Waiman Long (5): cgroup/cpuset: Streamline rm_siblings_excl_cpus() cgroup/cpuset: Consistently compute effective_xcpus in update_cpumasks_hier() cgroup/cpuset: Don't fail cpuset.cpus change in v2 cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict cgroup/cpuset: Move the v1 empty cpus/mems check to cpuset1_validate_change() Documentation/admin-guide/cgroup-v2.rst | 40 +++-- kernel/cgroup/cpuset-internal.h | 12 ++ kernel/cgroup/cpuset-v1.c | 33 ++++ kernel/cgroup/cpuset.c | 163 ++++++------------ .../selftests/cgroup/test_cpuset_prs.sh | 29 +++- 5 files changed, 150 insertions(+), 127 deletions(-) -- 2.52.0

1 day, 13 hours

[cgroup/for-6.20 PATCH v2 0/4] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict

by Waiman Long

v2: - Patch 1: additional comment - Patch 2: simplify the conditions for triggering call to compute_excpus(). - Patch 3: update description of cpuset.cpus.exclusive in cgroup-v2.rst to reflect the new behavior and change the name of the new cpus_excl_conflict() parameter to xcpus_changed. - Patch 4: update description of cpuset.cpus.partition in cgroup-v2.rst to clarify what exclusive CPUs will be used when a partition is created. This patch series is inspired by the cpuset patch sent by Sun Shaojie [1]. The idea is to avoid invalidating sibling partitions when there is a cpuset.cpus conflict. However this patch series does it in a slightly different way to make its behavior more consistent with other cpuset properties. The first 3 patches are just some cleanup and minor bug fixes on issues found during the investigation process. The last one is the major patch that changes the way cpuset.cpus is being handled during the partition creation process. Instead of invalidating sibling partitions when there is a conflict, it will strip out the conflicting exclusive CPUs and assign the remaining non-conflicting exclusive CPUs to the new partition unless there is no more CPU left which will fail the partition creation process. It is similar to the idea that cpuset.cpus.effective may only contain a subset of CPUs specified in cpuset.cpus. So cpuset.cpus.exclusive.effective may contain only a subset of cpuset.cpus when a partition is created without setting cpuset.cpus.exclusive. Even setting cpuset.cpus.exclusive instead of cpuset.cpus may not guarantee all the requested CPUs can be granted if parent doesn't have access to some of those exclusive CPUs. The difference is that conflicts from siblings is not possible with cpuset.cpus.exclusive as long as it can be set successfully without failure. [1] https://lore.kernel.org/lkml/20251117015708.977585-1-sunshaojie@kylinos.cn/ Waiman Long (4): cgroup/cpuset: Streamline rm_siblings_excl_cpus() cgroup/cpuset: Consistently compute effective_xcpus in update_cpumasks_hier() cgroup/cpuset: Don't fail cpuset.cpus change in v2 cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict Documentation/admin-guide/cgroup-v2.rst | 40 +++-- kernel/cgroup/cpuset-internal.h | 3 + kernel/cgroup/cpuset-v1.c | 19 +++ kernel/cgroup/cpuset.c | 141 +++++++----------- .../selftests/cgroup/test_cpuset_prs.sh | 26 +++- 5 files changed, 125 insertions(+), 104 deletions(-) -- 2.52.0

1 day, 16 hours

← Newer
1
2
3
4
5
6
7
...
1428
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror