- Linux-kselftest-mirror - lists.linaro.org

[PATCH 00/12] A minor flurry of selftest/mm fixes

by John Hubbard

It turned out that an even dozen patches were required in order to get the selftests building cleanly, and all running, once again. I made it worse on myself by insisting on using clang, which seems to uncover a few more warnings than gcc these days. So I still haven't gotten to my original goal of running a new HMM test that Alistair handed me (it's not here yet), but at least this fixes everything I ran into just now. John Hubbard (12): selftests/mm: fix uffd-stress unused function warning selftests/mm: fix unused variable warning in hugetlb-madvise.c selftests/mm: fix unused variable warning in migration.c selftests/mm: fix a char* assignment in mlock2-tests.c selftests/mm: fix invocation of tests that are run via shell scripts selftests/mm: .gitignore: add mkdirty, va_high_addr_switch selftests/mm: set -Wno-format-security to avoid uffd build warnings selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h selftests/mm: move psize(), pshift() into vm_utils.c selftests/mm: move uffd* routines from vm_util.c to uffd-common.c selftests/mm: fix missing UFFDIO_CONTINUE_MODE_WP and similar build failures selftests/mm: fix uffd-unit-tests.c build failure due to missing MADV_COLLAPSE tools/testing/selftests/mm/.gitignore | 2 + tools/testing/selftests/mm/Makefile | 9 +- tools/testing/selftests/mm/cow.c | 7 -- tools/testing/selftests/mm/hugepage-mremap.c | 2 +- tools/testing/selftests/mm/hugetlb-madvise.c | 2 +- tools/testing/selftests/mm/khugepaged.c | 10 -- .../selftests/mm/ksm_functional_tests.c | 2 +- tools/testing/selftests/mm/migration.c | 2 +- tools/testing/selftests/mm/mlock2-tests.c | 2 +- tools/testing/selftests/mm/pkey-x86.h | 2 +- tools/testing/selftests/mm/run_vmtests.sh | 6 +- tools/testing/selftests/mm/uffd-common.c | 105 +++++++++++++++++ tools/testing/selftests/mm/uffd-common.h | 29 ++++- tools/testing/selftests/mm/uffd-stress.c | 10 -- tools/testing/selftests/mm/vm_util.c | 106 ++---------------- tools/testing/selftests/mm/vm_util.h | 36 ++---- 16 files changed, 170 insertions(+), 162 deletions(-) base-commit: 929ed21dfdb6ee94391db51c9eedb63314ef6847 -- 2.40.1

2 years, 1 month

4
53
0 0

[PATCH V2 1/4] tracing/user_events: Fix the incorrect trace record for empty arguments events

by sunliming

The user_events support events that has empty arguments. But the trace event is discarded and not really committed when the arguments is empty. Fix this by not attempting to copy in zero-length data. Signed-off-by: sunliming <sunliming(a)kylinos.cn> --- kernel/trace/trace_events_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index 0d91dac206ff..698703a3d234 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1399,7 +1399,7 @@ static void user_event_ftrace(struct user_event *user, struct iov_iter *i, if (unlikely(!entry)) return; - if (unlikely(!copy_nofault(entry + 1, i->count, i))) + if (unlikely(i->count != 0 && !copy_nofault(entry + 1, i->count, i))) goto discard; if (!list_empty(&user->validators) && @@ -1440,7 +1440,7 @@ static void user_event_perf(struct user_event *user, struct iov_iter *i, perf_fetch_caller_regs(regs); - if (unlikely(!copy_nofault(perf_entry + 1, i->count, i))) + if (unlikely(i->count != 0 && !copy_nofault(perf_entry + 1, i->count, i))) goto discard; if (!list_empty(&user->validators) && -- 2.25.1

2 years, 1 month

2
4
0 0

[linux-next:master] BUILD REGRESSION 9ca10bfb8aa8fbf19ee22e702c8cf9b66ea73a54

by kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9ca10bfb8aa8fbf19ee22e702c8cf9b66ea73a54 Add linux-next specific files for 20230605 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202305070840.X0G3ofjl-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202305132244.DwzBUcUd-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306021936.OktTcMAT-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306051319.EihCQZPs-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306051812.1YdWyZca-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202306051823.Gbzkjb7e-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) arch/x86/tests/amd-ibs-via-core-pmu.c:47:25: error: 'pmus' undeclared (first use in this function) arch/x86/tests/amd-ibs-via-core-pmu.c:48:17: error: implicit declaration of function 'perf_pmu__scan'; did you mean 'perf_pmus__scan'? [-Werror=implicit-function-declaration] arch/x86/tests/amd-ibs-via-core-pmu.c:50:17: error: assignment to 'struct perf_pmu *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] arch/x86/tests/amd-ibs-via-core-pmu.c:50:19: error: implicit declaration of function 'perf_pmu__find'; did you mean 'perf_pmus__find'? [-Werror=implicit-function-declaration] drivers/bus/fsl-mc/fsl-mc-allocator.c:108:12: warning: variable 'mc_bus_dev' is uninitialized when used here [-Wuninitialized] drivers/cpufreq/cpufreq-dt-platdev.c:104:34: warning: 'blocklist' defined but not used [-Wunused-const-variable=] drivers/cpufreq/cpufreq-dt-platdev.c:17:34: warning: 'allowlist' defined but not used [-Wunused-const-variable=] include/drm/drm_print.h:456:39: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Werror=format=] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:336:1: warning: no previous prototype for 'bpf_kfunc_call_memb_acquire' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:342:18: warning: no previous prototype for 'bpf_kfunc_call_memb1_release' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:394:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail1' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:398:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail2' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:402:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail3' [-Wmissing-prototypes] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:410:18: warning: no previous prototype for 'bpf_kfunc_call_test_mem_len_fail1' [-Wmissing-prototypes] Unverified Error/Warning (likely false positive, please contact us if interested): drivers/clk/qcom/gpucc-sm8550.c:37:22: sparse: sparse: decimal constant 2300000000 is between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are very likely to produce unsigned long (and a warning) here drivers/clk/qcom/videocc-sm8550.c:34:22: sparse: sparse: decimal constant 2300000000 is between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are very likely to produce unsigned long (and a warning) here drivers/usb/cdns3/cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c:217:30: sparse: sparse: incorrect type in argument 1 (different base types) fs/btrfs/volumes.c:6407 btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6245) fs/smb/client/cifsfs.c:982 cifs_smb3_do_mount() warn: possible memory leak of 'cifs_sb' fs/smb/client/cifssmb.c:4089 CIFSFindFirst() warn: missing error code? 'rc' fs/smb/client/cifssmb.c:4216 CIFSFindNext() warn: missing error code? 'rc' fs/smb/client/connect.c:2725 cifs_match_super() error: 'tlink' dereferencing possible ERR_PTR() fs/smb/client/connect.c:2924 generic_ip_connect() error: we previously assumed 'socket' could be null (see line 2912) fs/xfs/scrub/fscounters.c:459 xchk_fscounters() warn: ignoring unreachable code. kernel/events/uprobes.c:478 uprobe_write_opcode() warn: passing zero to 'PTR_ERR' lib/kunit/test.c:336 __kunit_abort() warn: ignoring unreachable code. {standard input}:1078: Error: pcrel too far Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- arc-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- arm-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- arm-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- arm-randconfig-c031-20230605 | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- arm64-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- i386-allyesconfig | `-- include-drm-drm_print.h:error:format-ld-expects-argument-of-type-long-int-but-argument-has-type-size_t-aka-unsigned-int |-- i386-randconfig-m021-20230605 | |-- fs-smb-client-cifsfs.c-cifs_smb3_do_mount()-warn:possible-memory-leak-of-cifs_sb | |-- fs-smb-client-cifssmb.c-CIFSFindFirst()-warn:missing-error-code-rc | |-- fs-smb-client-cifssmb.c-CIFSFindNext()-warn:missing-error-code-rc | |-- fs-smb-client-connect.c-cifs_match_super()-error:tlink-dereferencing-possible-ERR_PTR() | |-- fs-smb-client-connect.c-generic_ip_connect()-error:we-previously-assumed-socket-could-be-null-(see-line-) | |-- fs-xfs-scrub-fscounters.c-xchk_fscounters()-warn:ignoring-unreachable-code. | `-- kernel-events-uprobes.c-uprobe_write_opcode()-warn:passing-zero-to-PTR_ERR |-- i386-randconfig-s042-20230605 | |-- drivers-cpufreq-cpufreq-dt-platdev.c:warning:allowlist-defined-but-not-used | `-- drivers-cpufreq-cpufreq-dt-platdev.c:warning:blocklist-defined-but-not-used |-- m68k-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- m68k-randconfig-m041-20230605 | `-- lib-kunit-test.c-__kunit_abort()-warn:ignoring-unreachable-code. |-- m68k-randconfig-s043-20230605 | |-- drivers-clk-qcom-gpucc-sm8550.c:sparse:sparse:decimal-constant-is-between-LONG_MAX-and-ULONG_MAX.-For-C99-that-means-long-long-C90-compilers-are-very-likely-to-produce-unsigned-long-(and-a-warning)-he | `-- drivers-clk-qcom-videocc-sm8550.c:sparse:sparse:decimal-constant-is-between-LONG_MAX-and-ULONG_MAX.-For-C99-that-means-long-long-C90-compilers-are-very-likely-to-produce-unsigned-long-(and-a-warning)- |-- mips-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- mips-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- powerpc-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- powerpc-randconfig-s053-20230604 | `-- drivers-usb-typec-tcpm-qcom-qcom_pmic_typec_pdphy.c:sparse:sparse:incorrect-type-in-argument-(different-base-types)-expected-unsigned-short-usertype-header-got-restricted-__le16-const-usertype-header |-- riscv-allmodconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- s390-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- s390-randconfig-s052-20230604 | |-- mm-filemap.c:sparse:sparse:Using-plain-integer-as-NULL-pointer | `-- mm-kfence-core.c:sparse:sparse:cast-to-restricted-__le64 |-- sh-allmodconfig | `-- standard-input:Error:pcrel-too-far |-- sparc-allyesconfig | `-- drivers-usb-cdns3-cdns3-starfive.c:warning:expecting-prototype-for-cdns3().-Prototype-was-for-USB_STRAP_HOST()-instead |-- x86_64-randconfig-k001-20230605 | |-- arch-x86-tests-amd-ibs-via-core-pmu.c:error:assignment-to-struct-perf_pmu-from-int-makes-pointer-from-integer-without-a-cast | |-- arch-x86-tests-amd-ibs-via-core-pmu.c:error:implicit-declaration-of-function-perf_pmu__find | |-- arch-x86-tests-amd-ibs-via-core-pmu.c:error:implicit-declaration-of-function-perf_pmu__scan | |-- arch-x86-tests-amd-ibs-via-core-pmu.c:error:pmus-undeclared-(first-use-in-this-function) | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_memb1_release | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_memb_acquire | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_test_fail1 | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_test_fail2 | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_test_fail3 | |-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_test_mem_len_fail1 | `-- tools-testing-selftests-bpf-bpf_testmod-bpf_testmod.c:warning:no-previous-prototype-for-bpf_kfunc_call_test_offset `-- x86_64-randconfig-m001-20230605 |-- fs-btrfs-volumes.c-btrfs_map_block()-error:we-previously-assumed-mirror_num_ret-could-be-null-(see-line-) `-- fs-xfs-scrub-fscounters.c-xchk_fscounters()-warn:ignoring-unreachable-code. clang_recent_errors `-- arm-randconfig-r046-20230605 `-- drivers-bus-fsl-mc-fsl-mc-allocator.c:warning:variable-mc_bus_dev-is-uninitialized-when-used-here elapsed time: 726m configs tested: 162 configs skipped: 9 tested configs: alpha allyesconfig gcc alpha buildonly-randconfig-r005-20230605 gcc alpha defconfig gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_defconfig gcc arc randconfig-r005-20230605 gcc arc randconfig-r012-20230605 gcc arc randconfig-r013-20230605 gcc arc randconfig-r043-20230605 gcc arm allmodconfig gcc arm allyesconfig gcc arm defconfig gcc arm imx_v4_v5_defconfig clang arm lpc18xx_defconfig gcc arm randconfig-r006-20230605 gcc arm randconfig-r036-20230605 gcc arm randconfig-r046-20230605 clang arm vexpress_defconfig clang arm64 allyesconfig gcc arm64 buildonly-randconfig-r003-20230605 clang arm64 defconfig gcc arm64 randconfig-r006-20230605 clang arm64 randconfig-r014-20230605 gcc csky defconfig gcc csky randconfig-r033-20230605 gcc hexagon randconfig-r002-20230605 clang hexagon randconfig-r011-20230605 clang hexagon randconfig-r034-20230605 clang hexagon randconfig-r041-20230605 clang hexagon randconfig-r045-20230605 clang i386 allyesconfig gcc i386 debian-10.3 gcc i386 defconfig gcc i386 randconfig-i001-20230605 clang i386 randconfig-i002-20230605 clang i386 randconfig-i003-20230605 clang i386 randconfig-i004-20230605 clang i386 randconfig-i005-20230605 clang i386 randconfig-i006-20230605 clang i386 randconfig-i011-20230605 gcc i386 randconfig-i012-20230605 gcc i386 randconfig-i013-20230605 gcc i386 randconfig-i014-20230605 gcc i386 randconfig-i015-20230605 gcc i386 randconfig-i016-20230605 gcc i386 randconfig-i051-20230605 clang i386 randconfig-i052-20230605 clang i386 randconfig-i053-20230605 clang i386 randconfig-i054-20230605 clang i386 randconfig-i055-20230605 clang i386 randconfig-i056-20230605 clang i386 randconfig-i061-20230605 clang i386 randconfig-i062-20230605 clang i386 randconfig-i063-20230605 clang i386 randconfig-i064-20230605 clang i386 randconfig-i065-20230605 clang i386 randconfig-i066-20230605 clang ia64 gensparse_defconfig gcc loongarch allmodconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc m68k allmodconfig gcc m68k defconfig gcc m68k randconfig-r024-20230605 gcc microblaze randconfig-r005-20230605 gcc microblaze randconfig-r014-20230605 gcc mips allmodconfig gcc mips allyesconfig gcc mips cavium_octeon_defconfig clang mips db1xxx_defconfig gcc mips fuloong2e_defconfig gcc mips gcw0_defconfig gcc mips pic32mzda_defconfig clang mips qi_lb60_defconfig clang mips randconfig-r023-20230605 clang mips randconfig-r035-20230605 gcc nios2 3c120_defconfig gcc nios2 defconfig gcc nios2 randconfig-r016-20230605 gcc nios2 randconfig-r025-20230605 gcc nios2 randconfig-r031-20230605 gcc openrisc buildonly-randconfig-r001-20230605 gcc openrisc or1klitex_defconfig gcc openrisc randconfig-r002-20230605 gcc openrisc randconfig-r016-20230605 gcc openrisc randconfig-r021-20230605 gcc openrisc randconfig-r022-20230605 gcc parisc defconfig gcc parisc randconfig-r032-20230605 gcc parisc64 defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc buildonly-randconfig-r006-20230605 gcc powerpc mpc5200_defconfig clang powerpc mpc8315_rdb_defconfig clang powerpc randconfig-r011-20230605 gcc powerpc randconfig-r015-20230605 gcc powerpc sequoia_defconfig gcc riscv allmodconfig gcc riscv allnoconfig gcc riscv defconfig gcc riscv randconfig-r033-20230605 clang riscv randconfig-r042-20230605 gcc riscv rv32_defconfig gcc s390 allmodconfig gcc s390 allyesconfig gcc s390 defconfig gcc s390 randconfig-r003-20230605 clang s390 randconfig-r004-20230605 clang s390 randconfig-r032-20230605 clang s390 randconfig-r044-20230605 gcc sh allmodconfig gcc sh ecovec24-romimage_defconfig gcc sh edosk7760_defconfig gcc sh espt_defconfig gcc sh hp6xx_defconfig gcc sh randconfig-r001-20230605 gcc sh randconfig-r012-20230605 gcc sh randconfig-r013-20230605 gcc sh randconfig-r031-20230605 gcc sh se7722_defconfig gcc sh sh7770_generic_defconfig gcc sh sh7785lcr_32bit_defconfig gcc sparc defconfig gcc sparc64 randconfig-r026-20230605 gcc um i386_defconfig gcc um x86_64_defconfig gcc x86_64 allyesconfig gcc x86_64 buildonly-randconfig-r002-20230605 clang x86_64 defconfig gcc x86_64 kexec gcc x86_64 randconfig-a001-20230605 clang x86_64 randconfig-a002-20230605 clang x86_64 randconfig-a003-20230605 clang x86_64 randconfig-a004-20230605 clang x86_64 randconfig-a005-20230605 clang x86_64 randconfig-a006-20230605 clang x86_64 randconfig-a011-20230605 gcc x86_64 randconfig-a012-20230605 gcc x86_64 randconfig-a013-20230605 gcc x86_64 randconfig-a014-20230605 gcc x86_64 randconfig-a015-20230605 gcc x86_64 randconfig-a016-20230605 gcc x86_64 randconfig-k001-20230605 gcc x86_64 randconfig-x051-20230605 gcc x86_64 randconfig-x052-20230605 gcc x86_64 randconfig-x053-20230605 gcc x86_64 randconfig-x054-20230605 gcc x86_64 randconfig-x055-20230605 gcc x86_64 randconfig-x056-20230605 gcc x86_64 randconfig-x061-20230605 gcc x86_64 randconfig-x062-20230605 gcc x86_64 randconfig-x063-20230605 gcc x86_64 randconfig-x064-20230605 gcc x86_64 randconfig-x065-20230605 gcc x86_64 randconfig-x066-20230605 gcc x86_64 rhel-8.3 gcc xtensa buildonly-randconfig-r004-20230605 gcc xtensa randconfig-r003-20230605 gcc xtensa randconfig-r004-20230605 gcc xtensa randconfig-r015-20230605 gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

2 years, 1 month

1
0
0 0

Re: [PATCH v3 11/12] selftests/nolibc: add new gettimeofday test cases

by Arnd Bergmann

On Sun, Jun 4, 2023, at 10:29, 吴章金 wrote: > > Sorry for missing part of your feedbacks, I will check if -nostdlib > stops the linking of libgcc_s or my own separated test script forgot > linking the libgcc_s manually. According to the gcc documentation, -nostdlib drops libgcc.a, but adding -lgcc is the recommended way to bring it back. > And as suggestion from Thomas' reply, > >>> Perhaps we really need to add the missing __divdi3 and __aeabi_ldivmod and the >>> ones for the other architectures, or get one from lib/math/div64.c. > >>No, these ones come from the compiler via libgcc_s, we must not try to > reimplement them. And we should do our best to avoid depending on them > to avoid the error you got above. > > So, the explicit conversion is used instead in the patch. I think a cast to a 32-bit type is ideal when converting the clock_gettime() result into microseconds, since the kernel guarantees that the timespec value is normalized, with all zeroes in the upper 34 bits. Going through __aeabi_ldivmod would make the conversion much slower. For user supplied non-normalized timeval values, it's not obvious whether we need the full 64-bit division Arnd

2 years, 1 month

3
4
0 0

[PATCH net-next 0/8] mlxsw, selftests: Cleanups

by Petr Machata

This patchset consolidates a number of disparate items that can all be considered cleanups. They are all related to mlxsw in that they are directly in mlxsw code, or in selftests that mlxsw heavily uses. - patch #1 fixes a comment, patch #2 propagates an extack - patches #3 and #4 tweak several loops to query a resource once and cache in a local variable instead of querying on each iteration - patches #5 and #6 fix selftest diagrams, and #7 adds a missing diagram into an existing test - patch #8 disables a PVID on a bridge in a selftest that should not need said PVID Petr Machata (8): mlxsw: spectrum_router: Clarify a comment mlxsw: spectrum_router: Use extack in mlxsw_sp~_rif_ipip_lb_configure() mlxsw: spectrum_router: Do not query MAX_RIFS on each iteration mlxsw: spectrum_router: Do not query MAX_VRS on each iteration selftests: mlxsw: ingress_rif_conf_1d: Fix the diagram selftests: mlxsw: egress_vid_classification: Fix the diagram selftests: router_bridge_vlan: Add a diagram selftests: router_bridge_vlan: Set vlan_default_pvid 0 on the bridge .../ethernet/mellanox/mlxsw/spectrum_router.c | 26 ++++++++++++------- .../net/mlxsw/egress_vid_classification.sh | 5 ++-- .../drivers/net/mlxsw/ingress_rif_conf_1d.sh | 5 ++-- .../net/forwarding/router_bridge_vlan.sh | 24 ++++++++++++++++- 4 files changed, 43 insertions(+), 17 deletions(-) -- 2.40.1

2 years, 1 month

2
9
0 0

[PATCH 0/4] tools/nolibc: add two new syscall helpers

by Zhangjin Wu

Hi, Willy When I worked on adding new syscalls and the related library routines, I have seen most of the library routines share the same syscall call and return logic, this patchset adds two macros to simplify and shrink them. All of them have been tested on arm, aarch64, rv32 and rv64, no new regressions found. If this is ok, I will rebase the new syscalls and library routines on this patchset. Best regards, Zhangjin --- Zhangjin Wu (4): tools/nolibc: unistd.h: add __syscall() and __syscall_ret() helpers tools/nolibc: unistd.h: apply __syscall_ret() helper tools/nolibc: sys.h: apply __syscall_ret() helper tools/nolibc: sys.h: apply __syscall() helper tools/include/nolibc/sys.h | 369 ++++++---------------------------- tools/include/nolibc/unistd.h | 12 +- 2 files changed, 65 insertions(+), 316 deletions(-) -- 2.25.1

2 years, 1 month

3
9
0 0

[PATCH v1 1/1] selftests: alsa: pcm-test: Fix compiler warnings about the format

by Mirsad Goran Todorovac

GCC 11.3.0 issues warnings in this module about wrong sizes of format specifiers: pcm-test.c: In function ‘test_pcm_time’: pcm-test.c:384:68: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 \ has type ‘unsigned int’ [-Wformat=] 384 | snprintf(msg, sizeof(msg), "rate mismatch %ld != %ld", rate, rrate); pcm-test.c:455:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \ type ‘long int’ [-Wformat=] 455 | "expected %d, wrote %li", rate, frames); pcm-test.c:462:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \ type ‘long int’ [-Wformat=] 462 | "expected %d, wrote %li", rate, frames); pcm-test.c:467:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has \ type ‘long int’ [-Wformat=] 467 | "expected %d, wrote %li", rate, frames); Simple fix according to compiler's suggestion removed the warnings. Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr> --- tools/testing/selftests/alsa/pcm-test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/alsa/pcm-test.c b/tools/testing/selftests/alsa/pcm-test.c index 3e390fe67eb9..b7eef32addb4 100644 --- a/tools/testing/selftests/alsa/pcm-test.c +++ b/tools/testing/selftests/alsa/pcm-test.c @@ -381,7 +381,7 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class, goto __close; } if (rrate != rate) { - snprintf(msg, sizeof(msg), "rate mismatch %ld != %ld", rate, rrate); + snprintf(msg, sizeof(msg), "rate mismatch %ld != %d", rate, rrate); goto __close; } rperiod_size = period_size; @@ -447,24 +447,24 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class, frames = snd_pcm_writei(handle, samples, rate); if (frames < 0) { snprintf(msg, sizeof(msg), - "Write failed: expected %d, wrote %li", rate, frames); + "Write failed: expected %ld, wrote %li", rate, frames); goto __close; } if (frames < rate) { snprintf(msg, sizeof(msg), - "expected %d, wrote %li", rate, frames); + "expected %ld, wrote %li", rate, frames); goto __close; } } else { frames = snd_pcm_readi(handle, samples, rate); if (frames < 0) { snprintf(msg, sizeof(msg), - "expected %d, wrote %li", rate, frames); + "expected %ld, wrote %li", rate, frames); goto __close; } if (frames < rate) { snprintf(msg, sizeof(msg), - "expected %d, wrote %li", rate, frames); + "expected %ld, wrote %li", rate, frames); goto __close; } } -- 2.34.1

2 years, 1 month

3
3
0 0

[PATCH v3 00/12] nolibc: add generic part1 of prepare for rv32

by Zhangjin Wu

Hi, Willy This is the v3 generic part1 for rv32, all of the found issues of v2 part1 [1] have been fixed up, several generic patches have been fixed up and merged from v2 part2 [2] to this series, the standalone test_fork patch [4] is merged with a Reviewed-by line into this series too. This series is based on 20230528-nolibc-rv32+stkp5 branch of [5]. Changes from v2 -> v3: * selftests/nolibc: fix up compile warning with glibc on x86_64 Use simpler 'long long' conversion instead of old #ifdef ... (Suggestion from Willy) * tools/nolibc: add missing nanoseconds support for __NR_statx Split the compound assignment into two single assignments (Suggestion from Thomas) * selftests/nolibc: add new gettimeofday test cases Removed the gettimeofday(NULL, &tz) (Suggestion from Thomas) All of the commit messages have been re-checked, some missing Suggested-by lines are added. The whole patchset have been tested on arm, aarch64, rv32 and rv64, no regressions (the next compile patchset is required to do rv32 test). The nolibc-test has been tested with glibc on x86_64 too. Btw, we have found such poll failures on arm (not introduced by this patchset), this will be fixed in our coming ppoll_time64 patchset: 48 poll_null = -1 ENOSYS [FAIL] 49 poll_stdout = -1 ENOSYS [FAIL] 50 poll_fault = -1 ENOSYS != (-1 EFAULT) [FAIL] And the gettimeofday_null removal patch from Thomas [3] may conflicts with the gettimeofday removal and addition patches, but it is not hard to fix. Best regards, Zhangjin --- [1]: https://lore.kernel.org/linux-riscv/cover.1685362482.git.falcon@tinylab.org… [2]: https://lore.kernel.org/linux-riscv/cover.1685387484.git.falcon@tinylab.org… [3]: https://lore.kernel.org/lkml/20230530-nolibc-gettimeofday-v1-1-7307441a002b… [4]: https://lore.kernel.org/lkml/61bdfe7bacebdef8aa9195f6f2550a5b0d33aab3.16854… [5]: https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git Zhangjin Wu (12): selftests/nolibc: syscall_args: use generic __NR_statx tools/nolibc: add missing nanoseconds support for __NR_statx selftests/nolibc: allow specify extra arguments for qemu selftests/nolibc: fix up compile warning with glibc on x86_64 selftests/nolibc: not include limits.h for nolibc selftests/nolibc: use INT_MAX instead of __INT_MAX__ tools/nolibc: arm: add missing my_syscall6 tools/nolibc: open: fix up compile warning for arm selftests/nolibc: support two errnos with EXPECT_SYSER2() selftests/nolibc: remove gettimeofday_bad1/2 completely selftests/nolibc: add new gettimeofday test cases selftests/nolibc: test_fork: fix up duplicated print tools/include/nolibc/arch-arm.h | 23 +++++++++++ tools/include/nolibc/stdint.h | 14 +++++++ tools/include/nolibc/sys.h | 39 +++++++++--------- tools/testing/selftests/nolibc/Makefile | 2 +- tools/testing/selftests/nolibc/nolibc-test.c | 42 ++++++++++++-------- 5 files changed, 85 insertions(+), 35 deletions(-) -- 2.25.1

2 years, 1 month

3
18
0 0

[PATCH] tools/nolibc: ensure fast64 integer types have 64 bits

by Thomas Weißschuh

On 32bit platforms size_t is not enough to represent [u]int_fast64_t. Fixes: 3e9fd4e9a1d5 ("tools/nolibc: add integer types and integer limit macros") Signed-off-by: Thomas Weißschuh <linux(a)weissschuh.net> --- Cc: Vincent Dagonneau <v(a)vda.io> Note: We could also fall back to compiler-provided data like: __UINT_FAST{8,16,32,64}_{TYPE,MIN,MAX}__ --- tools/include/nolibc/stdint.h | 4 ++-- tools/testing/selftests/nolibc/nolibc-test.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/include/nolibc/stdint.h b/tools/include/nolibc/stdint.h index c1ce4f5e0603..3fc418cfc3d7 100644 --- a/tools/include/nolibc/stdint.h +++ b/tools/include/nolibc/stdint.h @@ -36,8 +36,8 @@ typedef ssize_t int_fast16_t; typedef size_t uint_fast16_t; typedef ssize_t int_fast32_t; typedef size_t uint_fast32_t; -typedef ssize_t int_fast64_t; -typedef size_t uint_fast64_t; +typedef int64_t int_fast64_t; +typedef uint64_t uint_fast64_t; typedef int64_t intmax_t; typedef uint64_t uintmax_t; diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 7de46305f419..65be0317d184 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -696,9 +696,9 @@ int run_stdlib(int min, int max) CASE_TEST(limit_int_fast32_min); EXPECT_EQ(1, INT_FAST32_MIN, (int_fast32_t) INTPTR_MIN); break; CASE_TEST(limit_int_fast32_max); EXPECT_EQ(1, INT_FAST32_MAX, (int_fast32_t) INTPTR_MAX); break; CASE_TEST(limit_uint_fast32_max); EXPECT_EQ(1, UINT_FAST32_MAX, (uint_fast32_t) UINTPTR_MAX); break; - CASE_TEST(limit_int_fast64_min); EXPECT_EQ(1, INT_FAST64_MIN, (int_fast64_t) INTPTR_MIN); break; - CASE_TEST(limit_int_fast64_max); EXPECT_EQ(1, INT_FAST64_MAX, (int_fast64_t) INTPTR_MAX); break; - CASE_TEST(limit_uint_fast64_max); EXPECT_EQ(1, UINT_FAST64_MAX, (uint_fast64_t) UINTPTR_MAX); break; + CASE_TEST(limit_int_fast64_min); EXPECT_EQ(1, INT_FAST64_MIN, (int_fast64_t) INT64_MIN); break; + CASE_TEST(limit_int_fast64_max); EXPECT_EQ(1, INT_FAST64_MAX, (int_fast64_t) INT64_MAX); break; + CASE_TEST(limit_uint_fast64_max); EXPECT_EQ(1, UINT_FAST64_MAX, (uint_fast64_t) UINT64_MAX); break; #if __SIZEOF_LONG__ == 8 CASE_TEST(limit_intptr_min); EXPECT_EQ(1, INTPTR_MIN, (intptr_t) 0x8000000000000000LL); break; CASE_TEST(limit_intptr_max); EXPECT_EQ(1, INTPTR_MAX, (intptr_t) 0x7fffffffffffffffLL); break; --- base-commit: 5b21219d67d3483144d10332709d0c04f733ab93 change-id: 20230530-nolibc-fast64-8777cdbc7e01 Best regards, -- Thomas Weißschuh <linux(a)weissschuh.net>

2 years, 1 month

3
3
0 0

[PATCH] selftests/nolibc: test_fork: fix up duplicated print

by Zhangjin Wu

running nolibc-test with glibc on x86_64 got such print issue: 29 execve_root = -1 EACCES [OK] 30 fork30 fork = 0 [OK] 31 getdents64_root = 712 [OK] The fork test case has three printf calls: (1) llen += printf("%d %s", test, #name); (2) llen += printf(" = %d %s ", expr, errorname(errno)); (3) llen += pad_spc(llen, 64, "[FAIL]\n"); --> vfprintf() In the following scene, the above issue happens: (a) The parent calls (1) (b) The parent calls fork() (c) The child runs and shares the print buffer of (1) (d) The child exits, flushs the print buffer and closes its own stdout/stderr * "30 fork" is printed at the first time. (e) The parent calls (2) and (3), with "\n" in (3), it flushs the whole buffer * "30 fork = 0 ..." is printed Therefore, there are two "30 fork" in the stdout. Between (a) and (b), if flush the stdout (and the sterr), the child in stage (c) will not be able to 'see' the print buffer. Signed-off-by: Zhangjin Wu <falcon(a)tinylab.org> --- tools/testing/selftests/nolibc/nolibc-test.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 7de46305f419..88323a60aa4a 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -486,7 +486,13 @@ static int test_getpagesize(void) static int test_fork(void) { int status; - pid_t pid = fork(); + pid_t pid; + + /* flush the printf buffer to avoid child flush it */ + fflush(stdout); + fflush(stderr); + + pid = fork(); switch (pid) { case -1: -- 2.25.1

2 years, 1 month

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror