- Linux-kselftest-mirror - lists.linaro.org

by Mark Brown

On Fri, May 06, 2022 at 04:50:41PM +0200, Cornelia Huck wrote: > I'm currently trying to run the MTE selftests on the FVP simulator (Base > Model)[1], mainly to verify things are sane on the host before wiring up > the KVM support in QEMU. However, I'm seeing some failures (the non-mte > tests seemed all fine): > Are the MTE tests supposed to work on the FVP model? Something broken in > my config? Anything I can debug? I would expect them to work, they seemed happy when I was doing the async mode support IIRC and a quick spin with -next in qemu everything seems fine, I'm travelling so don't have the environment for models to hand right now. > [1] Command line: > "$MODEL" \ > -C cache_state_modelled=0 \ > -C bp.refcounter.non_arch_start_at_default=1 \ > -C bp.secure_memory=false \ > -C cluster0.has_arm_v8-1=1 \ > -C cluster0.has_arm_v8-2=1 \ > -C cluster0.has_arm_v8-3=1 \ > -C cluster0.has_arm_v8-4=1 \ > -C cluster0.has_arm_v8-5=1 \ > -C cluster0.has_amu=1 \ > -C cluster0.NUM_CORES=4 \ > -C cluster0.memory_tagging_support_level=2 \ > -a "cluster0.*=$AXF" \ > where $AXF contains a kernel at v5.18-rc5-16-g107c948d1d3e[2] and an > initrd built by mbuto[3] from that level with a slightly tweaked "kselftests" > profile (adding /dev/shm). What are you using for EL3 with the model? Both TF-A and boot-wrapper are in regular use, TF-A gets *way* more testing than boot-wrapper which is mostly used by individual developers.

3 years, 2 months

2
4
0 0

[PATCH v2 0/5] binder: extended error and logging enhancements

by Carlos Llamas

This is a followup from [1], in which a split of commits was suggested by Greg. Additionally, the following changes were removed and not included in this v2 version: - dropped the binder_transaction_log_entry->strerr[] logic - dropped the binder_transaction_error() do-it-all function - dropped the re-work of current binder_user_error() messages [1] https://lore.kernel.org/r/20220421042040.759068-1-cmllamas@google.com/ Carlos Llamas (5): binder: add failed transaction logging info binder: add BINDER_GET_EXTENDED_ERROR ioctl binderfs: add extended_error feature entry binder: convert logging macros into functions binder: additional transaction error logs drivers/android/binder.c | 153 ++++++++++++++++-- drivers/android/binder_internal.h | 3 + drivers/android/binderfs.c | 8 + include/uapi/linux/android/binder.h | 16 ++ .../filesystems/binderfs/binderfs_test.c | 1 + 5 files changed, 165 insertions(+), 16 deletions(-) base-commit: 8013d1d3d2e33236dee13a133fba49ad55045e79 -- 2.36.0.464.gb9c8b46e94-goog

3 years, 2 months

3
15
0 0

[PATCH v6 1/2] net: fix wrong network header length

by Lina Wang

When clatd starts with ebpf offloaing, and NETIF_F_GRO_FRAGLIST is enable, several skbs are gathered in skb_shinfo(skb)->frag_list. The first skb's ipv6 header will be changed to ipv4 after bpf_skb_proto_6_to_4, network_header\transport_header\mac_header have been updated as ipv4 acts, but other skbs in frag_list didnot update anything, just ipv6 packets. udp_queue_rcv_skb will call skb_segment_list to traverse other skbs in frag_list and make sure right udp payload is delivered to user space. Unfortunately, other skbs in frag_list who are still ipv6 packets are updated like the first skb and will have wrong transport header length. e.g.before bpf_skb_proto_6_to_4,the first skb and other skbs in frag_list has the same network_header(24)& transport_header(64), after bpf_skb_proto_6_to_4, ipv6 protocol has been changed to ipv4, the first skb's network_header is 44,transport_header is 64, other skbs in frag_list didnot change.After skb_segment_list, the other skbs in frag_list has different network_header(24) and transport_header(44), so there will be 20 bytes different from original,that is difference between ipv6 header and ipv4 header. Just change transport_header to be the same with original. Actually, there are two solutions to fix it, one is traversing all skbs and changing every skb header in bpf_skb_proto_6_to_4, the other is modifying frag_list skb's header in skb_segment_list. Considering efficiency, adopt the second one--- when the first skb and other skbs in frag_list has different network_header length, restore them to make sure right udp payload is delivered to user space. Signed-off-by: Lina Wang <lina.wang(a)mediatek.com> --- net/core/skbuff.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 10bde7c6db44..e8006e0a1b25 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3897,7 +3897,7 @@ struct sk_buff *skb_segment_list(struct sk_buff *skb, unsigned int delta_len = 0; struct sk_buff *tail = NULL; struct sk_buff *nskb, *tmp; - int err; + int len_diff, err; skb_push(skb, -skb_network_offset(skb) + offset); @@ -3937,9 +3937,11 @@ struct sk_buff *skb_segment_list(struct sk_buff *skb, skb_push(nskb, -skb_network_offset(nskb) + offset); skb_release_head_state(nskb); + len_diff = skb_network_header_len(nskb) - skb_network_header_len(skb); __copy_skb_header(nskb, skb); skb_headers_offset_update(nskb, skb_headroom(nskb) - skb_headroom(skb)); + nskb->transport_header += len_diff; skb_copy_from_linear_data_offset(skb, -tnl_hlen, nskb->data - tnl_hlen, offset + tnl_hlen); -- 2.18.0

3 years, 2 months

2
2
0 0

[PATCH] KVM: selftests: riscv: Remove unneeded semicolon

by Jiapeng Chong

Fix the following coccicheck warnings: ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded semicolon. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- tools/testing/selftests/kvm/lib/riscv/processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/riscv/processor.c b/tools/testing/selftests/kvm/lib/riscv/processor.c index 3961487a4870..e17333518af2 100644 --- a/tools/testing/selftests/kvm/lib/riscv/processor.c +++ b/tools/testing/selftests/kvm/lib/riscv/processor.c @@ -350,7 +350,7 @@ void vcpu_args_set(struct kvm_vm *vm, uint32_t vcpuid, unsigned int num, ...) case 7: id = RISCV_CORE_REG(regs.a7); break; - }; + } set_reg(vm, vcpuid, id, va_arg(ap, uint64_t)); } -- 2.20.1.7.g153144c

3 years, 2 months

3
3
0 0

[next] gpio: gpio-sim.sh: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008

by Naresh Kamboju

Following kernel crash noticed while running kselftest gpio gpio-sim.sh on qemu_arm64 with Linux next-20220506 kernel [1] & [2]. Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> # selftests: gpio: gpio-sim.sh # 1. chip_name and dev_name attributes # 1.1. Chip name is communicated to user # 1.2. chip_name returns 'none' if the chip is still pending # 1.3. Device name is communicated to user # 2. Creating and configuring simulated chips # 2.1. Default number of lines is 1 # 2.2. Number of lines can be specified # 2.3. Label can be set # 2.4. Label can be left empty # 2.5. Line names can be configured # 2.6. Line config can remain unused if offset is greater than number of lines # 2.7. Line configfs directory names are sanitized # 2.8. Multiple chips can be created # 2.9. Can't modify settings when chip is live # 2.10. Can't create line items when chip is live # 2.11. Probe errors are propagated to user-space [ 218.163457] gpio gpiochip1: (gpio-sim.0-node0): line cnt 34463 is greater than fast path cnt 512 [ 218.163739] gpiochip_find_base: cannot find free range [ 218.164216] gpiochip_add_data_with_key: GPIOs 0..34462 (gpio-sim.0-node0) failed to register, -28 [ 218.164503] gpio-sim: probe of gpio-sim.0 failed with error -28 # 2.12. Cannot enable a chip without any GPIO banks # 2.13. Duplicate chip labels are not allowed # 2.14. Lines can be hogged [ 223.754983] gpio-2036 (?): hogged as input [ 224.231594] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 [ 224.233378] Mem abort info: [ 224.233719] ESR = 0x0000000096000006 [ 224.234076] EC = 0x25: DABT (current EL), IL = 32 bits [ 224.235432] SET = 0, FnV = 0 [ 224.235790] EA = 0, S1PTW = 0 [ 224.236146] FSC = 0x06: level 2 translation fault [ 224.236592] Data abort info: [ 224.236926] ISV = 0, ISS = 0x00000006 [ 224.237300] CM = 0, WnR = 0 [ 224.237738] user pgtable: 4k pages, 48-bit VAs, pgdp=000000010ab2b000 [ 224.238785] [0000000000000008] pgd=080000010b9c4003, p4d=080000010b9c4003, pud=080000010b990003, pmd=0000000000000000 [ 224.240838] Internal error: Oops: 96000006 [#1] PREEMPT SMP [ 224.241509] Modules linked in: gpio_sim rfkill crct10dif_ce sm3_ce sm3 sha3_ce sha512_ce sha512_arm64 fuse [last unloaded: gpio_mockup] [ 224.242848] CPU: 2 PID: 1105 Comm: gpio-mockup-cde Not tainted 5.18.0-rc5-next-20220506 #1 [ 224.243548] Hardware name: linux,dummy-virt (DT) [ 224.244109] pstate: 20400005 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 224.244643] pc : linereq_free+0xb0/0x120 [ 224.245515] lr : linereq_create+0x548/0x640 [ 224.245797] sp : ffff8000089eb870 [ 224.246065] x29: ffff8000089eb870 x28: ffffd5cd009d5cd8 x27: ffff0000c32da0c0 [ 224.246795] x26: ffffd5ccfeb521c8 x25: 0000000000000000 x24: ffff0000c60d1d20 [ 224.247318] x23: ffff0000c60d1c00 x22: 0000000000000000 x21: 0000000000000118 [ 224.247843] x20: 0000000000000001 x19: ffff0000c60d1c00 x18: 0000000000000000 [ 224.248352] x17: ffffd5ccfcc2c288 x16: ffffd5ccfd019804 x15: ffffd5ccfd468a48 [ 224.248875] x14: ffffd5ccfd4686c0 x13: ffffd5ccfcc11d48 x12: ffffd5ccfe224eec [ 224.249307] x11: ffffd5ccfe223b88 x10: ffffd5ccfcc2c4e8 x9 : ffffd5ccfd4688c8 [ 224.249840] x8 : ffff0000c32e6108 x7 : bbbbbbbbbbbbbbbb x6 : 0000000000000001 [ 224.250418] x5 : ffffd5ccff965000 x4 : ffffd5ccff9654f0 x3 : 0000000000000000 [ 224.251050] x2 : ffff0000c33e5080 x1 : 0000000000000000 x0 : 0000000000000000 [ 224.251741] Call trace: [ 224.251998] linereq_free+0xb0/0x120 [ 224.252315] linereq_create+0x548/0x640 [ 224.252571] gpio_ioctl+0x88/0x754 [ 224.252808] __arm64_sys_ioctl+0xb4/0x100 [ 224.253103] invoke_syscall+0x78/0x100 [ 224.253342] el0_svc_common.constprop.0+0x104/0x124 [ 224.253680] do_el0_svc+0xb4/0xcc [ 224.253922] el0_svc+0x68/0x160 [ 224.254173] el0t_64_sync_handler+0xbc/0x140 [ 224.254504] el0t_64_sync+0x18c/0x190 [ 224.254929] Code: cb160273 8b130ef3 f9409261 b9413260 (f9400422) [ 224.255783] ---[ end trace 0000000000000000 ]--- # ./gpio-sim.sh: line 318: 1105 Segmentation fault $BASE_DIR/gpio-mockup-cdev -s 1 /dev/`configfs_chip_name chip bank` 4 2> /dev/null Broadcast message from systemd-journald@juno (Fri 2022-05-06 09:51:02 UTC): kernel[304]: [ 224.240838] Internal error: Oops: 96000006 [#1] PREEMPT SMP Broadcast message from systemd-journald@juno (Fri 2022-05-06 09:51:02 UTC): kernel[304]: [ 224.254929] Code: cb160273 8b130ef3 f9409261 b9413260 (f9400422) # 3. Controlling simulated chips # 3.1. Pull can be set over sysfs # not ok 2 selftests: gpio: gpio-sim.sh # TIMEOUT 45 seconds metadata: git_ref: master git_repo: '' git_sha: 38a288f5941ef03752887ad86f2d85442358c99a git_describe: next-20220506 kernel_version: 5.18.0-rc5 kernel-config: https://builds.tuxbuild.com/28mio5DFBEfnEtkiTLdPb9tTWVa/config build-url: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next/-/pipelines/532821646 artifact-location: https://builds.tuxbuild.com/28mio5DFBEfnEtkiTLdPb9tTWVa toolchain: gcc-11 Steps to reproduce: # cd /opt/kselftests/default-in-kernel/gpio # ./gpio-sim.sh Full test logs. [1] https://lkft.validation.linaro.org/scheduler/job/4994124#L1108 [2] https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220506/te… -- Linaro LKFT https://lkft.linaro.org

3 years, 2 months

1
0
0 0

[REGRESSION] lkft kselftest for next-20220317

by lkft＠linaro.org

## Build * kernel: 5.17.0-rc8 * git: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next * git branch: master * git commit: 97add482e9033a9386baa8824fbea34d0cbfe663 * git describe: next-20220317 * test details: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220317 ## Test Regressions (compared to next-20220302) * i386, kselftest-rtc - rtc.rtctest * qemu_x86_64, kselftest-rtc - rtc.rtctest * x86, kselftest-pidfd - pidfd.pidfd_test ## Metric Regressions (compared to next-20220302) No metric regressions found. Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> ## Test Fixes (compared to next-20220302) No test fixes found. ## Metric Fixes (compared to next-20220302) No metric fixes found. ## Test result summary total: 5102, pass: 2816, fail: 472, skip: 1814, xfail: 0 ## Build Summary ## Test suites summary * kselftest-android * kselftest-arm64 * kselftest-breakpoints * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-drivers * kselftest-efivarfs * kselftest-filesystems * kselftest-firmware * kselftest-fpu * kselftest-futex * kselftest-gpio * kselftest-intel_pstate * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kexec * kselftest-kvm * kselftest-lib * kselftest-livepatch * kselftest-membarrier * kselftest-memfd * kselftest-memory-hotplug * kselftest-mincore * kselftest-mount * kselftest-mqueue * kselftest-openat2 * kselftest-pid_namespace * kselftest-pidfd * kselftest-proc * kselftest-pstore * kselftest-ptrace * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-timens * kselftest-timers * kselftest-tmpfs * kselftest-tpm2 * kselftest-user * kselftest-vm * kselftest-x86 * kselftest-zram -- Linaro LKFT https://lkft.linaro.org

3 years, 2 months

1
0
0 0

lkft kselftest for next-20220315

by lkft＠linaro.org

## Build * kernel: 5.17.0-rc8 * git: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next * git branch: master * git commit: a32cd981a6da2373c093d471ee4405a915e217d5 * git describe: next-20220315 * test details: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220315 ## Test Regressions (compared to next-20220302) No test regressions found. ## Metric Regressions (compared to next-20220302) No metric regressions found. Tested-by: Linux Kernel Functional Testing <lkft(a)linaro.org> ## Test Fixes (compared to next-20220302) No test fixes found. ## Metric Fixes (compared to next-20220302) No metric fixes found. ## Test result summary total: 2020, pass: 1067, fail: 118, skip: 835, xfail: 0 ## Build Summary ## Test suites summary * kselftest-android * kselftest-arm64 * kselftest-breakpoints * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-drivers * kselftest-efivarfs * kselftest-filesystems * kselftest-firmware * kselftest-fpu * kselftest-futex * kselftest-gpio * kselftest-intel_pstate * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kvm * kselftest-lib * kselftest-livepatch * kselftest-membarrier * kselftest-memfd * kselftest-memory-hotplug * kselftest-mincore * kselftest-mount * kselftest-openat2 * kselftest-pid_namespace * kselftest-pidfd * kselftest-pstore * kselftest-ptrace * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-timens * kselftest-timers * kselftest-tmpfs * kselftest-tpm2 * kselftest-user * kselftest-vm * kselftest-x86 * kselftest-zram -- Linaro LKFT https://lkft.linaro.org

3 years, 2 months

1
0
0 0

[PATCH] selftests: clarify common error when running gup_test

by Joel Savitz

The gup_test binary will fail showing only the output of perror("open") in the case that /sys/kernel/debug/gup_test is not found. This will almost always be due to CONFIG_GUP_TEST not being set, which enables compilation of a kernel that provides this file. Add a short error message to clarify this failure and point the user to the solution. Signed-off-by: Joel Savitz <jsavitz(a)redhat.com> --- tools/testing/selftests/vm/gup_test.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c index cda837a14736..ac4e804d47f0 100644 --- a/tools/testing/selftests/vm/gup_test.c +++ b/tools/testing/selftests/vm/gup_test.c @@ -18,6 +18,8 @@ #define FOLL_WRITE 0x01 /* check pte is writable */ #define FOLL_TOUCH 0x02 /* mark page accessed */ +#define GUP_TEST_FILE "/sys/kernel/debug/gup_test" + static unsigned long cmd = GUP_FAST_BENCHMARK; static int gup_fd, repeats = 1; static unsigned long size = 128 * MB; @@ -204,9 +206,11 @@ int main(int argc, char **argv) if (write) gup.gup_flags |= FOLL_WRITE; - gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR); + gup_fd = open(GUP_TEST_FILE, O_RDWR); if (gup_fd == -1) { perror("open"); + fprintf(stderr, "Unable to open %s: check that CONFIG_GUP_TEST=y\n", + GUP_TEST_FILE); exit(1); } -- 2.27.0

3 years, 2 months

2
1
0 0

[PATCH] kunit: take `kunit_assert` as `const`

by Miguel Ojeda

The `kunit_do_failed_assertion` function passes its `struct kunit_assert` argument to `kunit_fail`. This one, in turn, calls its `format` field passing the assert again as a `const` pointer. Therefore, the whole chain may be made `const`. Signed-off-by: Miguel Ojeda <ojeda(a)kernel.org> --- include/kunit/test.h | 2 +- lib/kunit/test.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/kunit/test.h b/include/kunit/test.h index 00b9ff7783ab..2eff4f1beb42 100644 --- a/include/kunit/test.h +++ b/include/kunit/test.h @@ -774,7 +774,7 @@ void __printf(2, 3) kunit_log_append(char *log, const char *fmt, ...); void kunit_do_failed_assertion(struct kunit *test, const struct kunit_loc *loc, enum kunit_assert_type type, - struct kunit_assert *assert, + const struct kunit_assert *assert, const char *fmt, ...); #define KUNIT_ASSERTION(test, assert_type, pass, assert_class, INITIALIZER, fmt, ...) do { \ diff --git a/lib/kunit/test.c b/lib/kunit/test.c index 3bca3bf5c15b..b84aed09a009 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -241,7 +241,7 @@ static void kunit_print_string_stream(struct kunit *test, } static void kunit_fail(struct kunit *test, const struct kunit_loc *loc, - enum kunit_assert_type type, struct kunit_assert *assert, + enum kunit_assert_type type, const struct kunit_assert *assert, const struct va_format *message) { struct string_stream *stream; @@ -281,7 +281,7 @@ static void __noreturn kunit_abort(struct kunit *test) void kunit_do_failed_assertion(struct kunit *test, const struct kunit_loc *loc, enum kunit_assert_type type, - struct kunit_assert *assert, + const struct kunit_assert *assert, const char *fmt, ...) { va_list args; -- 2.35.3

3 years, 2 months

5
6
0 0

Fwd: My name is Warren Buffett, an American businessman.

by Warren Buffett

My name is Warren Buffett, an American businessman and investor I have something important to discuss with you. Mr. Warren Buffett warren001buffett(a)gmail.com Chief Executive Officer: Berkshire Hathaway aphy/Warren-Edward-Buffett

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror