- Linux-kselftest-mirror - lists.linaro.org

by Cornelia Huck

[memo to self: don't send stuff on Friday evenings] Sorry about the spam, resend w/o config, see https://people.redhat.com/~cohuck/config-mte On Fri, May 06 2022, Cornelia Huck <cohuck(a)redhat.com> wrote: > Hi, > > I'm currently trying to run the MTE selftests on the FVP simulator (Base > Model)[1], mainly to verify things are sane on the host before wiring up > the KVM support in QEMU. However, I'm seeing some failures (the non-mte > tests seemed all fine): > > # selftests: /arm64: check_buffer_fill > # 1..20 > # ok 1 Check buffer correctness by byte with sync err mode and mmap memory > # ok 2 Check buffer correctness by byte with async err mode and mmap memory > # ok 3 Check buffer correctness by byte with sync err mode and mmap/mprotect memory > # ok 4 Check buffer correctness by byte with async err mode and mmap/mprotect memory > # not ok 5 Check buffer write underflow by byte with sync mode and mmap memory > # not ok 6 Check buffer write underflow by byte with async mode and mmap memory > # ok 7 Check buffer write underflow by byte with tag check fault ignore and mmap memory > # not ok 8 Check buffer write underflow by byte with sync mode and mmap memory > # not ok 9 Check buffer write underflow by byte with async mode and mmap memory > # ok 10 Check buffer write underflow by byte with tag check fault ignore and mmap memory > # not ok 11 Check buffer write overflow by byte with sync mode and mmap memory > # not ok 12 Check buffer write overflow by byte with async mode and mmap memory > # ok 13 Check buffer write overflow by byte with tag fault ignore mode and mmap memory > # ok 14 Check buffer write correctness by block with sync mode and mmap memory > # ok 15 Check buffer write correctness by block with async mode and mmap memory > # ok 16 Check buffer write correctness by block with tag fault ignore and mmap memory > # ok 17 Check initial tags with private mapping, sync error mode and mmap memory > # ok 18 Check initial tags with private mapping, sync error mode and mmap/mprotect memory > # ok 19 Check initial tags with shared mapping, sync error mode and mmap memory > # ok 20 Check initial tags with shared mapping, sync error mode and mmap/mprotect memory > # # Totals: pass:14 fail:6 xfail:0 xpass:0 skip:0 error:0 > not ok 24 selftests: /arm64: check_buffer_fill # exit=1 > > # selftests: /arm64: check_child_memory > # 1..12 > # not ok 1 Check child anonymous memory with private mapping, precise mode and mmap memory > # not ok 2 Check child anonymous memory with shared mapping, precise mode and mmap memory > # not ok 3 Check child anonymous memory with private mapping, imprecise mode and mmap memory > # not ok 4 Check child anonymous memory with shared mapping, imprecise mode and mmap memory > # not ok 5 Check child anonymous memory with private mapping, precise mode and mmap/mprotect memory > # not ok 6 Check child anonymous memory with shared mapping, precise mode and mmap/mprotect memory > # not ok 7 Check child file memory with private mapping, precise mode and mmap memory > # not ok 8 Check child file memory with shared mapping, precise mode and mmap memory > # not ok 9 Check child file memory with private mapping, imprecise mode and mmap memory > # not ok 10 Check child file memory with shared mapping, imprecise mode and mmap memory > # not ok 11 Check child file memory with private mapping, precise mode and mmap/mprotect memory > # not ok 12 Check child file memory with shared mapping, precise mode and mmap/mprotect memory > # # Totals: pass:0 fail:12 xfail:0 xpass:0 skip:0 error:0 > not ok 25 selftests: /arm64: check_child_memory # exit=1 > > # selftests: /arm64: check_gcr_el1_cswitch > # 1..1 > # 1..1 > # 1..1 > # 1..1 > [...many more lines of the same...] > # 1..1 > # > not ok 26 selftests: /arm64: check_gcr_el1_cswitch # TIMEOUT 45 seconds > > # selftests: /arm64: check_mmap_options > # 1..22 > # ok 1 Check anonymous memory with private mapping, sync error mode, mmap memory and tag check off > # ok 2 Check file memory with private mapping, sync error mode, mmap/mprotect memory and tag check off > # ok 3 Check anonymous memory with private mapping, no error mode, mmap memory and tag check off > # ok 4 Check file memory with private mapping, no error mode, mmap/mprotect memory and tag check off > # not ok 5 Check anonymous memory with private mapping, sync error mode, mmap memory and tag check on > # not ok 6 Check anonymous memory with private mapping, sync error mode, mmap/mprotect memory and tag check on > # not ok 7 Check anonymous memory with shared mapping, sync error mode, mmap memory and tag check on > # not ok 8 Check anonymous memory with shared mapping, sync error mode, mmap/mprotect memory and tag check on > # not ok 9 Check anonymous memory with private mapping, async error mode, mmap memory and tag check on > # not ok 10 Check anonymous memory with private mapping, async error mode, mmap/mprotect memory and tag check on > # not ok 11 Check anonymous memory with shared mapping, async error mode, mmap memory and tag check on > # not ok 12 Check anonymous memory with shared mapping, async error mode, mmap/mprotect memory and tag check on > # not ok 13 Check file memory with private mapping, sync error mode, mmap memory and tag check on > # not ok 14 Check file memory with private mapping, sync error mode, mmap/mprotect memory and tag check on > # not ok 15 Check file memory with shared mapping, sync error mode, mmap memory and tag check on > # not ok 16 Check file memory with shared mapping, sync error mode, mmap/mprotect memory and tag check on > # not ok 17 Check file memory with private mapping, async error mode, mmap memory and tag check on > # not ok 18 Check file memory with private mapping, async error mode, mmap/mprotect memory and tag check on > # not ok 19 Check file memory with shared mapping, async error mode, mmap memory and tag check on > # not ok 20 Check file memory with shared mapping, async error mode, mmap/mprotect memory and tag check on > # not ok 21 Check clear PROT_MTE flags with private mapping, sync error mode and mmap memory > # not ok 22 Check clear PROT_MTE flags with private mapping and sync error mode and mmap/mprotect memory > # # Totals: pass:4 fail:18 xfail:0 xpass:0 skip:0 error:0 > not ok 28 selftests: /arm64: check_mmap_options # exit=1 > > # selftests: /arm64: check_tags_inclusion > # 1..4 > # not ok 1 Check an included tag value with sync mode > # not ok 2 Check different included tags value with sync mode > # ok 3 Check none included tags value with sync mode > # not ok 4 Check all included tags value with sync mode > # # Totals: pass:1 fail:3 xfail:0 xpass:0 skip:0 error:0 > not ok 29 selftests: /arm64: check_tags_inclusion # exit=1 > > check_ksm_options and check_user_mem work as expected. > > Are the MTE tests supposed to work on the FVP model? Something broken in > my config? Anything I can debug? > > [1] Command line: > "$MODEL" \ > -C cache_state_modelled=0 \ > -C bp.refcounter.non_arch_start_at_default=1 \ > -C bp.secure_memory=false \ > -C cluster0.has_arm_v8-1=1 \ > -C cluster0.has_arm_v8-2=1 \ > -C cluster0.has_arm_v8-3=1 \ > -C cluster0.has_arm_v8-4=1 \ > -C cluster0.has_arm_v8-5=1 \ > -C cluster0.has_amu=1 \ > -C cluster0.NUM_CORES=4 \ > -C cluster0.memory_tagging_support_level=2 \ > -a "cluster0.*=$AXF" \ > > where $AXF contains a kernel at v5.18-rc5-16-g107c948d1d3e[2] and an > initrd built by mbuto[3] from that level with a slightly tweaked "kselftests" > profile (adding /dev/shm). > > [2] CONFIG_ARM64_MTE=y, no modules; complete config below[4] > > [3] https://mbuto.sh/mbuto/ > > [4] kernel config: https://people.redhat.com/~cohuck/config-mte

3 years, 2 months

1
0
0 0

[PATCH v2 0/2] Modify some code about kprobe

by Tiezhu Yang

v2: -- only replace __kprobes with NOKPROBE_SYMBOL() in patch #2 -- update the commit messages Tiezhu Yang (2): selftests/ftrace: Save kprobe_events to test log MIPS: Use NOKPROBE_SYMBOL() instead of __kprobes annotation arch/mips/kernel/kprobes.c | 39 ++++++++++++++-------- arch/mips/mm/fault.c | 6 ++-- .../ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ 3 files changed, 32 insertions(+), 15 deletions(-) -- 2.1.0

3 years, 2 months

1
2
0 0

Napływ Klientów ze strony

by "Mikołaj Rudzik"

Dzień dobry, chciałbym poinformować Państwa o możliwości pozyskania nowych zleceń ze strony www. Widzimy zainteresowanie potencjalnych Klientów Państwa firmą, dlatego chętnie pomożemy Państwu dotrzeć z ofertą do większego grona odbiorców poprzez efektywne metody pozycjonowania strony w Google. Czy mógłbym liczyć na kontakt zwrotny? Pozdrawiam, Mikołaj Rudzik

3 years, 2 months

1
0
0 0

[PATCH 0/2] Modify some code about kprobe

by Tiezhu Yang

This patch series is preparation to fix the problems when execute the multiple_kprobes.tc selftest on mips, some more work needs to be done. Tiezhu Yang (2): selftests/ftrace: Save kprobe_events to test log MIPS: Use NOKPROBE_SYMBOL() instead of __kprobes annotation arch/mips/kernel/kprobes.c | 45 +++++++++++++++------- arch/mips/mm/fault.c | 6 ++- .../ftrace/test.d/kprobe/multiple_kprobes.tc | 2 + 3 files changed, 38 insertions(+), 15 deletions(-) -- 2.1.0

3 years, 2 months

2
5
0 0

opportunity

by Allen

H e l l o, I lead family investment vehicles who want to invest a proportion of their funds with a trust party . Please are you interested in discussing investment in your sector? Please email, or simply write to me here: allen.large(a)cheapnet.it I value promptness and will make every attempt to respond within a short time. Thank you. Allen S.

3 years, 2 months

1
0
0 0

[PATCH] selftests: vm: Makefile: rename TARGETS to VMTARGETS

by Joel Savitz

The tools/testing/selftests/vm/Makefile uses the variable TARGETS internally to generate a list of platform-specific binary build targets suffixed with _{32,64}. When building the selftests using its own Makefile directly, such as via the following command run in a kernel tree: One receives an error such as the following: make: Entering directory '/root/linux/tools/testing/selftests' make --no-builtin-rules ARCH=x86 -C ../../.. headers_install make[1]: Entering directory '/root/linux' INSTALL ./usr/include make[1]: Leaving directory '/root/linux' make[1]: Entering directory '/root/linux/tools/testing/selftests/vm' make[1]: *** No rule to make target 'vm.c', needed by '/root/linux/tools/testing/selftests/vm/vm_64'. Stop. make[1]: Leaving directory '/root/linux/tools/testing/selftests/vm' make: *** [Makefile:175: all] Error 2 make: Leaving directory '/root/linux/tools/testing/selftests' The TARGETS variable passed to tools/testing/selftests/Makefile collides with the TARGETS used in tools/testing/selftests/vm/Makefile, so rename the latter to VMTARGETS, eliminating the collision with no functional change. Fixes: f21fda8f6453 ("selftests: vm: pkeys: fix multilib builds for x86") Signed-off-by: Joel Savitz <jsavitz(a)redhat.com> --- tools/testing/selftests/vm/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 04a49e876a46..5b1ecd00695b 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -57,9 +57,9 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_32bit_prog CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_64bit_program.c) CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_program.c -no-pie) -TARGETS := protection_keys -BINARIES_32 := $(TARGETS:%=%_32) -BINARIES_64 := $(TARGETS:%=%_64) +VMTARGETS := protection_keys +BINARIES_32 := $(VMTARGETS:%=%_32) +BINARIES_64 := $(VMTARGETS:%=%_64) ifeq ($(CAN_BUILD_WITH_NOPIE),1) CFLAGS += -no-pie @@ -112,7 +112,7 @@ $(BINARIES_32): CFLAGS += -m32 -mxsave $(BINARIES_32): LDLIBS += -lrt -ldl -lm $(BINARIES_32): $(OUTPUT)/%_32: %.c $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ -$(foreach t,$(TARGETS),$(eval $(call gen-target-rule-32,$(t)))) +$(foreach t,$(VMTARGETS),$(eval $(call gen-target-rule-32,$(t)))) endif ifeq ($(CAN_BUILD_X86_64),1) @@ -120,7 +120,7 @@ $(BINARIES_64): CFLAGS += -m64 -mxsave $(BINARIES_64): LDLIBS += -lrt -ldl $(BINARIES_64): $(OUTPUT)/%_64: %.c $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ -$(foreach t,$(TARGETS),$(eval $(call gen-target-rule-64,$(t)))) +$(foreach t,$(VMTARGETS),$(eval $(call gen-target-rule-64,$(t)))) endif # x86_64 users should be encouraged to install 32-bit libraries -- 2.27.0

3 years, 2 months

2
2
0 0

[PATCH v2 0/2] begin KTAP spec v2 process

by frowand.list＠gmail.com

From: Frank Rowand <frank.rowand(a)sony.com> The process to create version 2 of the KTAP Specification is documented in email discussions. I am attempting to capture this information at https://elinux.org/Test_Results_Format_Notes#KTAP_version_2 I am already not following the suggested process, which says: "...please try to follow this principal of one major topic per email thread." I think that is ok in this case because the two patches are related and (hopefully) not controversial. Changes since patch version 1: - drop patch 1/2. Jonathan Corbet has already applied this patch into version 1 of the Specification - rename patch 2/2 to patch 1/2, with updated patch comment - add new patch 2/2 Frank Rowand (2): ktap_v2: change version to 2-rc in KTAP specification ktap_v2: change "version 1" to "version 2" in examples Documentation/dev-tools/ktap.rst | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) -- Frank Rowand <frank.rowand(a)sony.com>

3 years, 2 months

2
3
0 0

[RFC PATCH 0/2] kunit: Support redirecting function calls

by David Gow

When writing tests, it'd often be very useful to be able to intercept calls to a function in the code being tested and replace it with a test-specific stub. This has always been an obviously missing piece of KUnit, and the solutions always involve some tradeoffs with cleanliness, performance, or impact on non-test code. See the folowing document for some of the challenges: https://kunit.dev/mocking.html This series consists of two prototype patches which add support for this sort of redirection to KUnit tests: 1: static_stub: Any function which might want to be intercepted adds a call to a macro which checks if a test has redirected calls to it, and calls the corresponding replacement. 2: ftrace_stub: Functions are intercepted using ftrace and livepatch. This doesn't require adding a new prologue to each function being replaced, but does have more dependencies (which restricts it to a small number of architectures, not including UML), and doesn't work well with inline functions. The API for both implementations is very similar, so it should be easy to migrate from one to the other if necessary. Both of these implementations restrict the redirection to the test context: it is automatically undone after the KUnit test completes, and does not affect calls in other threads. If CONFIG_KUNIT is not enabled, there should be no overhead in either implementation. Does either (or both) of these features sound useful, and is this sort-of API the right model? (Personally, I think there's a reasonable scope for both.) Is anything obviously missing or wrong? Do the names, descriptions etc. make any sense? Note that these patches are definitely still at the "prototype" level, and things like error-handling, documentation, and testing are still pretty sparse. There is also quite a bit of room for optimisation. These'll all be improved for v1 if the concept seems good. Cheers, -- David Daniel Latypov (1): kunit: expose ftrace-based API for stubbing out functions during tests David Gow (1): kunit: Expose 'static stub' API to redirect functions include/kunit/ftrace_stub.h | 84 +++++++++++++++++ include/kunit/static_stub.h | 106 +++++++++++++++++++++ lib/kunit/Kconfig | 11 +++ lib/kunit/Makefile | 5 + lib/kunit/ftrace_stub.c | 138 ++++++++++++++++++++++++++++ lib/kunit/kunit-example-test.c | 64 +++++++++++++ lib/kunit/static_stub.c | 125 +++++++++++++++++++++++++ lib/kunit/stubs_example.kunitconfig | 11 +++ 8 files changed, 544 insertions(+) create mode 100644 include/kunit/ftrace_stub.h create mode 100644 include/kunit/static_stub.h create mode 100644 lib/kunit/ftrace_stub.c create mode 100644 lib/kunit/static_stub.c create mode 100644 lib/kunit/stubs_example.kunitconfig -- 2.35.1.894.gb6a874cedc-goog

3 years, 2 months

5
14
0 0

[PATCH] kselftest/arm64: Fix ABI header directory location

by Mark Brown

Currently the arm64 kselftests attempt to locate the ABI headers using custom logic which doesn't work correctly in the case of out of tree builds if KBUILD_OUTPUT is not specified. Since lib.mk defines KHDR_INCLUDES with the appropriate flags we can simply remove the custom logic and use that instead. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- This fix is required to get us able to run the arm64 kselftests in KernelCI, it does out of tree kselftest builds triggering the issue especially in conjunction with the addition of the new definitions for SME. tools/testing/selftests/arm64/Makefile | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tools/testing/selftests/arm64/Makefile b/tools/testing/selftests/arm64/Makefile index 1e8d9a8f59df..9460cbe81bcc 100644 --- a/tools/testing/selftests/arm64/Makefile +++ b/tools/testing/selftests/arm64/Makefile @@ -17,16 +17,7 @@ top_srcdir = $(realpath ../../../../) # Additional include paths needed by kselftest.h and local headers CFLAGS += -I$(top_srcdir)/tools/testing/selftests/ -# Guessing where the Kernel headers could have been installed -# depending on ENV config -ifeq ($(KBUILD_OUTPUT),) -khdr_dir = $(top_srcdir)/usr/include -else -# the KSFT preferred location when KBUILD_OUTPUT is set -khdr_dir = $(KBUILD_OUTPUT)/kselftest/usr/include -endif - -CFLAGS += -I$(khdr_dir) +CFLAGS += $(KHDR_INCLUDES) export CFLAGS export top_srcdir -- 2.30.2

3 years, 2 months

2
2
0 0

[PATCH][next] selftests/seccomp: Fix spelling mistake "Coud" -> "Could"

by Colin Ian King

There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> --- tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 29c973f606b2..136df5b76319 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -4320,7 +4320,7 @@ static ssize_t get_nth(struct __test_metadata *_metadata, const char *path, f = fopen(path, "r"); ASSERT_NE(f, NULL) { - TH_LOG("Coud not open %s: %s", path, strerror(errno)); + TH_LOG("Could not open %s: %s", path, strerror(errno)); } for (i = 0; i < position; i++) { -- 2.35.1

3 years, 2 months

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror