On Thu, Apr 8, 2021 at 3:59 PM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Thu, 8 Apr 2021 at 15:17, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Thu, Apr 8, 2021 at 11:33 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Thu, 8 Apr 2021 at 04:21, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Thu, Apr 8, 2021 at 12:38 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
While running kselftest recently added gpio gpio-sim.sh test case the following warning was triggered on Linux next tag 20210330 tag running on arm64 juno and hikey devices.
GOOD: next-20210326 BAD: next-20210330
This is still happening today on Linux next tag 20210407.
Can you add the following
sysfs_attr_init(attrs[i]);
to the end of the loop in gpio_sim_setup_sysfs()?
Do you mean like this,
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index ea17289a869c..5fe67ccf45f7 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -296,6 +296,7 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip) dev_attr->store = gpio_sim_sysfs_line_store;
attrs[i] = &dev_attr->attr;
sysfs_attr_init(attrs[i]); } chip->attr_group.name = "line-ctrl";Precisely.
As per your suggestions the above line added and build tested the reported issue is fixed now.
Reported-by: Naresh Kamboju naresh.kamboju@linaro.org Tested-by: Naresh Kamboju naresh.kamboju@linaro.org
Thanks, I'll send a formal patch.
The rest I leave for Bart to figure out what to do.